[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #143: SLING-11497 - convert all cnd files to repoinit statements

2022-08-11 Thread GitBox
kwin commented on code in PR #143: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/143#discussion_r943520990 ## src/main/java/org/apache/sling/feature/cpconverter/handlers/slinginitialcontent/BundleSlingInitialContentJarEntryExtractor.java: ## @@

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #143: SLING-11497 - convert all cnd files to repoinit statements

2022-07-26 Thread GitBox
kwin commented on code in PR #143: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/143#discussion_r929850216 ## src/main/java/org/apache/sling/feature/cpconverter/handlers/slinginitialcontent/BundleSlingInitialContentJarEntryExtractor.java: ## @@

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #143: SLING-11497 - convert all cnd files to repoinit statements

2022-07-26 Thread GitBox
kwin commented on code in PR #143: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/143#discussion_r929848527 ## src/main/java/org/apache/sling/feature/cpconverter/handlers/slinginitialcontent/BundleSlingInitialContentExtractContext.java: ## @@

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #143: SLING-11497 - convert all cnd files to repoinit statements

2022-07-26 Thread GitBox
kwin commented on code in PR #143: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/143#discussion_r929765408 ## src/main/java/org/apache/sling/feature/cpconverter/handlers/slinginitialcontent/SlingInitialContentBundleEntryMetaDataCollector.java: