[GitHub] storm pull request: Send activate and deactivate command to ShellS...

2016-02-11 Thread obiwabrakenobi
GitHub user obiwabrakenobi opened a pull request: https://github.com/apache/storm/pull/1096 Send activate and deactivate command to ShellSpout By sending activate and deactivate to ShellSpout it is possible to react on these events i.E. closing/opening resources You can merge this

[GitHub] storm pull request: STORM-1272: port backtype.storm.disruptor to j...

2016-02-11 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1095#issuecomment-183201819 Travis check has passed. Ready for merge now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Commented] (STORM-1272) port backtype.storm.disruptor to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144156#comment-15144156 ] ASF GitHub Bot commented on STORM-1272: --- Github user abhishekagarwal87 commented on the pull

[GitHub] storm pull request: STORM-1248: port backtype.storm.messaging.load...

2016-02-11 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1097#issuecomment-183201855 Travis check passed. Ready for merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (STORM-1248) port backtype.storm.messaging.loader to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144157#comment-15144157 ] ASF GitHub Bot commented on STORM-1248: --- Github user abhishekagarwal87 commented on the pull

[GitHub] storm pull request: [STORM-1230] port backtype.storm.process-simul...

2016-02-11 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1100#discussion_r52710917 --- Diff: storm-core/src/jvm/org/apache/storm/ProcessSimulator.java --- @@ -0,0 +1,89 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (STORM-1230) port backtype.storm.process-simulator to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144190#comment-15144190 ] ASF GitHub Bot commented on STORM-1230: --- Github user abhishekagarwal87 commented on a diff in the

[jira] [Commented] (STORM-1230) port backtype.storm.process-simulator to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144192#comment-15144192 ] ASF GitHub Bot commented on STORM-1230: --- Github user abhishekagarwal87 commented on a diff in the

[GitHub] storm pull request: [STORM-1230] port backtype.storm.process-simul...

2016-02-11 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1100#discussion_r52710964 --- Diff: storm-core/src/jvm/org/apache/storm/ProcessSimulator.java --- @@ -0,0 +1,89 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request: [STORM-1230] port backtype.storm.process-simul...

2016-02-11 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1100#discussion_r52710990 --- Diff: storm-core/src/jvm/org/apache/storm/ProcessSimulator.java --- @@ -0,0 +1,89 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request: [STORM-1230] port backtype.storm.process-simul...

2016-02-11 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1100#discussion_r52711023 --- Diff: storm-core/src/jvm/org/apache/storm/ProcessSimulator.java --- @@ -0,0 +1,89 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (STORM-1230) port backtype.storm.process-simulator to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144193#comment-15144193 ] ASF GitHub Bot commented on STORM-1230: --- Github user abhishekagarwal87 commented on a diff in the

[jira] [Commented] (STORM-1230) port backtype.storm.process-simulator to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144194#comment-15144194 ] ASF GitHub Bot commented on STORM-1230: --- Github user abhishekagarwal87 commented on a diff in the

[GitHub] storm pull request: [STORM-1230] port backtype.storm.process-simul...

2016-02-11 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1100#discussion_r52711091 --- Diff: storm-core/src/jvm/org/apache/storm/ProcessSimulator.java --- @@ -0,0 +1,89 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request: [STORM-1230] port backtype.storm.process-simul...

2016-02-11 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1100#discussion_r52711184 --- Diff: storm-core/src/jvm/org/apache/storm/ProcessSimulator.java --- @@ -0,0 +1,89 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (STORM-1230) port backtype.storm.process-simulator to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144195#comment-15144195 ] ASF GitHub Bot commented on STORM-1230: --- Github user abhishekagarwal87 commented on a diff in the

[jira] [Commented] (STORM-1230) port backtype.storm.process-simulator to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144198#comment-15144198 ] ASF GitHub Bot commented on STORM-1230: --- Github user abhishekagarwal87 commented on a diff in the

[GitHub] storm pull request: [STORM-1230] port backtype.storm.process-simul...

2016-02-11 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1100#discussion_r52711320 --- Diff: storm-core/src/jvm/org/apache/storm/ProcessSimulator.java --- @@ -0,0 +1,89 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (STORM-1230) port backtype.storm.process-simulator to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144199#comment-15144199 ] ASF GitHub Bot commented on STORM-1230: --- Github user abhishekagarwal87 commented on a diff in the

[GitHub] storm pull request: [STORM-1230] port backtype.storm.process-simul...

2016-02-11 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1100#discussion_r52711383 --- Diff: storm-core/src/jvm/org/apache/storm/ProcessSimulator.java --- @@ -0,0 +1,89 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (STORM-1230) port backtype.storm.process-simulator to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144201#comment-15144201 ] ASF GitHub Bot commented on STORM-1230: --- Github user abhishekagarwal87 commented on a diff in the

[GitHub] storm pull request: [STORM-1253] - port backtype.storm.timer to ja...

2016-02-11 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1098#discussion_r52711933 --- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj --- @@ -332,19 +333,24 @@ :assignment-id (.getAssignmentId isupervisor)

[jira] [Commented] (STORM-1253) port backtype.storm.timer to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144206#comment-15144206 ] ASF GitHub Bot commented on STORM-1253: --- Github user abhishekagarwal87 commented on a diff in the

[jira] [Commented] (STORM-1253) port backtype.storm.timer to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144220#comment-15144220 ] ASF GitHub Bot commented on STORM-1253: --- Github user abhishekagarwal87 commented on a diff in the

[GitHub] storm pull request: [STORM-1253] - port backtype.storm.timer to ja...

2016-02-11 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1098#discussion_r52712565 --- Diff: storm-core/src/jvm/org/apache/storm/StormTimer.java --- @@ -0,0 +1,231 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (STORM-1253) port backtype.storm.timer to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144223#comment-15144223 ] ASF GitHub Bot commented on STORM-1253: --- Github user abhishekagarwal87 commented on a diff in the

[GitHub] storm pull request: [STORM-1253] - port backtype.storm.timer to ja...

2016-02-11 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1098#discussion_r52712695 --- Diff: storm-core/src/jvm/org/apache/storm/StormTimer.java --- @@ -0,0 +1,231 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request: [STORM-1253] - port backtype.storm.timer to ja...

2016-02-11 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1098#discussion_r52712733 --- Diff: storm-core/src/jvm/org/apache/storm/StormTimer.java --- @@ -0,0 +1,231 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (STORM-1253) port backtype.storm.timer to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144224#comment-15144224 ] ASF GitHub Bot commented on STORM-1253: --- Github user abhishekagarwal87 commented on a diff in the

[GitHub] storm pull request: [STORM-1253] - port backtype.storm.timer to ja...

2016-02-11 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1098#discussion_r52712839 --- Diff: storm-core/src/jvm/org/apache/storm/StormTimer.java --- @@ -0,0 +1,231 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (STORM-1253) port backtype.storm.timer to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144227#comment-15144227 ] ASF GitHub Bot commented on STORM-1253: --- Github user abhishekagarwal87 commented on a diff in the

[GitHub] storm pull request: [STORM-1253] - port backtype.storm.timer to ja...

2016-02-11 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1098#discussion_r52713030 --- Diff: storm-core/src/jvm/org/apache/storm/StormTimer.java --- @@ -0,0 +1,231 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (STORM-1253) port backtype.storm.timer to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144235#comment-15144235 ] ASF GitHub Bot commented on STORM-1253: --- Github user abhishekagarwal87 commented on a diff in the

Re: Trident pipelining and transactional properties

2016-02-11 Thread Arun Iyer
Hi Felix, What you have described is correct. The commits are ordered i.e batch 1, batch 2 etc in that order, even if batch 2 tuples completes processing before batch 1 (with pipelining). - Arun On 2/9/16, 4:55 AM, "Felix Dreissig" wrote: >Thanks for your quick replies, Bobby

[GitHub] storm pull request: STORM-1272: port backtype.storm.disruptor to j...

2016-02-11 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1095#issuecomment-182898283 I have not run performance tests as of now so you can run them --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (STORM-1272) port backtype.storm.disruptor to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15142840#comment-15142840 ] ASF GitHub Bot commented on STORM-1272: --- Github user abhishekagarwal87 commented on a diff in the

[jira] [Commented] (STORM-1533) topologies with metric consumers fail in config validation phase

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15142850#comment-15142850 ] ASF GitHub Bot commented on STORM-1533: --- Github user abhishekagarwal87 commented on the pull

Re: Any guidance around disruptor batch size ?

2016-02-11 Thread Bobby Evans
I played around with this a lot when developing the feature.  I wrote several micro benchmarks https://github.com/revans2/storm-micro-perf >From that I played around with the batch size on a 1024 deep queue, which is >what the default is for storm. 

[jira] [Commented] (STORM-1272) port backtype.storm.disruptor to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15142801#comment-15142801 ] ASF GitHub Bot commented on STORM-1272: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: STORM-1533: IntegerValidator for metric consum...

2016-02-11 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1091#issuecomment-182892954 +1 looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (STORM-1272) port backtype.storm.disruptor to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15142843#comment-15142843 ] ASF GitHub Bot commented on STORM-1272: --- Github user abhishekagarwal87 commented on the pull

[GitHub] storm pull request: STORM-1533: IntegerValidator for metric consum...

2016-02-11 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1091#issuecomment-182900605 Thanks @revans2 - can you also merge this PR? This affects 1.x release so it should be backported as well. --- If your project is set up for it, you can

[jira] [Commented] (STORM-1533) topologies with metric consumers fail in config validation phase

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15142822#comment-15142822 ] ASF GitHub Bot commented on STORM-1533: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: STORM-1272: port backtype.storm.disruptor to j...

2016-02-11 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1095#discussion_r52611699 --- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj --- @@ -219,7 +220,7 @@ (let [val (AddressedTuple. task tuple)]

[jira] [Commented] (STORM-1272) port backtype.storm.disruptor to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15142852#comment-15142852 ] ASF GitHub Bot commented on STORM-1272: --- Github user abhishekagarwal87 commented on the pull

[jira] [Commented] (STORM-1226) Port backtype.storm.util to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143298#comment-15143298 ] ASF GitHub Bot commented on STORM-1226: --- Github user asfgit closed the pull request at:

[GitHub] storm pull request: STORM-1226: Port backtype.storm.util to java

2016-02-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1074 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: STORM-1248: port backtype.storm.messaging.load...

2016-02-11 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1097#discussion_r52654035 --- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj --- @@ -461,11 +460,11 @@ ) (defn register-callbacks

[jira] [Commented] (STORM-1519) Storm syslog logging not confirming to RFC5426 3.1

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143349#comment-15143349 ] ASF GitHub Bot commented on STORM-1519: --- Github user asfgit closed the pull request at:

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-11 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1055#issuecomment-183044681 @redsanket sorry about this, but utils.clj got updated and now this needs to be rebased. It looks like most of the conflicts are fairly trivial. --- If your project

[GitHub] storm pull request: STORM-1248: port backtype.storm.messaging.load...

2016-02-11 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/1097#discussion_r52662362 --- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj --- @@ -487,11 +486,12 @@ ) (defn register-callbacks [worker]

[jira] [Commented] (STORM-1248) port backtype.storm.messaging.loader to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143465#comment-15143465 ] ASF GitHub Bot commented on STORM-1248: --- Github user knusbaum commented on a diff in the pull

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143271#comment-15143271 ] ASF GitHub Bot commented on STORM-1336: --- Github user knusbaum commented on a diff in the pull

[jira] [Commented] (STORM-1248) port backtype.storm.messaging.loader to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143287#comment-15143287 ] ASF GitHub Bot commented on STORM-1248: --- GitHub user abhishekagarwal87 opened a pull request:

[GitHub] storm pull request: STORM-1248: port backtype.storm.messaging.load...

2016-02-11 Thread abhishekagarwal87
GitHub user abhishekagarwal87 opened a pull request: https://github.com/apache/storm/pull/1097 STORM-1248: port backtype.storm.messaging.loader to java You can merge this pull request into a Git repository by running: $ git pull https://github.com/abhishekagarwal87/storm

[GitHub] storm pull request: STORM-1248: port backtype.storm.messaging.load...

2016-02-11 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/1097#discussion_r52656904 --- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj --- @@ -487,11 +486,12 @@ ) (defn register-callbacks [worker]

[jira] [Commented] (STORM-1248) port backtype.storm.messaging.loader to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143373#comment-15143373 ] ASF GitHub Bot commented on STORM-1248: --- Github user knusbaum commented on a diff in the pull

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-11 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52648907 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupOperation.java --- @@ -0,0 +1,78 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request: STORM-1272: port backtype.storm.disruptor to j...

2016-02-11 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1095#issuecomment-183019989 That is quite a difference in performance. Are you using ThroughputVsLatency to get these numbers? Also while you are looking into performance degrade and

[jira] [Commented] (STORM-1272) port backtype.storm.disruptor to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143314#comment-15143314 ] ASF GitHub Bot commented on STORM-1272: --- Github user abhishekagarwal87 commented on the pull

[GitHub] storm pull request: STORM-1272: port backtype.storm.disruptor to j...

2016-02-11 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1095#issuecomment-183029379 Yes, I used ThroughputvsLatency with a throughput of 20,000 sentences per second that I know 0.10.x can handle. Having a single reflection on the critical path can

[jira] [Commented] (STORM-1272) port backtype.storm.disruptor to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143342#comment-15143342 ] ASF GitHub Bot commented on STORM-1272: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: STORM-1248: port backtype.storm.messaging.load...

2016-02-11 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/1097#discussion_r52662537 --- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj --- @@ -487,11 +486,12 @@ ) (defn register-callbacks [worker]

[jira] [Commented] (STORM-1248) port backtype.storm.messaging.loader to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143468#comment-15143468 ] ASF GitHub Bot commented on STORM-1248: --- Github user knusbaum commented on a diff in the pull

[GitHub] storm pull request: STORM-1248: port backtype.storm.messaging.load...

2016-02-11 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/1097#discussion_r52651786 --- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj --- @@ -461,11 +460,11 @@ ) (defn register-callbacks [worker]

[GitHub] storm pull request: STORM-1248: port backtype.storm.messaging.load...

2016-02-11 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1097#discussion_r52658173 --- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj --- @@ -487,11 +486,12 @@ ) (defn register-callbacks

[GitHub] storm pull request: STORM-1248: port backtype.storm.messaging.load...

2016-02-11 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1097#discussion_r52662027 --- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj --- @@ -487,11 +486,12 @@ ) (defn register-callbacks

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-11 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52649491 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupUtils.java --- @@ -0,0 +1,119 @@ +/** + * Licensed to the Apache Software

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143281#comment-15143281 ] ASF GitHub Bot commented on STORM-1336: --- Github user knusbaum commented on a diff in the pull

[jira] [Commented] (STORM-1272) port backtype.storm.disruptor to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143295#comment-15143295 ] ASF GitHub Bot commented on STORM-1272: --- Github user revans2 commented on the pull request:

[jira] [Resolved] (STORM-1519) Storm syslog logging not confirming to RFC5426 3.1

2016-02-11 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1519. Resolution: Fixed Assignee: Boyang Jerry Peng Fix Version/s: 1.0.0

[jira] [Commented] (STORM-1248) port backtype.storm.messaging.loader to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143394#comment-15143394 ] ASF GitHub Bot commented on STORM-1248: --- Github user abhishekagarwal87 commented on a diff in the

[jira] [Commented] (STORM-1248) port backtype.storm.messaging.loader to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143422#comment-15143422 ] ASF GitHub Bot commented on STORM-1248: --- Github user knusbaum commented on a diff in the pull

[GitHub] storm pull request: STORM-1272: port backtype.storm.disruptor to j...

2016-02-11 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1095#issuecomment-183013900 The good news is that this patch doesn't seem to have made the performance on 2.x any worse. The bad news is that it is already 1/2 the throughput I can get on 1.x.

[jira] [Commented] (STORM-1248) port backtype.storm.messaging.loader to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143310#comment-15143310 ] ASF GitHub Bot commented on STORM-1248: --- Github user knusbaum commented on a diff in the pull

[jira] [Assigned] (STORM-1230) port backtype.storm.process-simulator to java

2016-02-11 Thread Zhuo Liu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuo Liu reassigned STORM-1230: --- Assignee: Zhuo Liu > port backtype.storm.process-simulator to java >

[jira] [Commented] (STORM-1248) port backtype.storm.messaging.loader to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143331#comment-15143331 ] ASF GitHub Bot commented on STORM-1248: --- Github user abhishekagarwal87 commented on a diff in the

[GitHub] storm pull request: [STORM-1519] - Storm syslog logging not confir...

2016-02-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1068 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (STORM-1532) Fix readCommandLineOpts to parse JSON correctly

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143376#comment-15143376 ] ASF GitHub Bot commented on STORM-1532: --- Github user revans2 commented on a diff in the pull

[GitHub] storm pull request: [STORM-1532]: Fix readCommandLineOpts to parse...

2016-02-11 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1094#discussion_r52656968 --- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java --- @@ -330,7 +330,11 @@ public static Map readCommandLineOpts() { Map ret = new

[GitHub] storm pull request: STORM-1248: port backtype.storm.messaging.load...

2016-02-11 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/1097#discussion_r52660183 --- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj --- @@ -487,11 +486,12 @@ ) (defn register-callbacks [worker]

[jira] [Commented] (STORM-1248) port backtype.storm.messaging.loader to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143457#comment-15143457 ] ASF GitHub Bot commented on STORM-1248: --- Github user abhishekagarwal87 commented on a diff in the

[GitHub] storm pull request: STORM-1272: port backtype.storm.disruptor to j...

2016-02-11 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1095#issuecomment-182860733 I have removed DisruptorUtils.java and squashed the commits along with it. --- If your project is set up for it, you can reply to this email and have your

[jira] [Updated] (STORM-1248) port backtype.storm.messaging.loader to java

2016-02-11 Thread Abhishek Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Agarwal updated STORM-1248: Assignee: Abhishek Agarwal > port backtype.storm.messaging.loader to java >

[jira] [Updated] (STORM-1247) port backtype.storm.messaging.local to java

2016-02-11 Thread Abhishek Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Agarwal updated STORM-1247: Assignee: Abhishek Agarwal > port backtype.storm.messaging.local to java >

[GitHub] storm pull request: STORM-1536: Remove Java use of TimeCacheMap

2016-02-11 Thread dossett
Github user dossett commented on the pull request: https://github.com/apache/storm/pull/1092#issuecomment-182878387 @knusbaum Just to be clear, you're suggesting that the `@deprecated` annotation and explanation be removed from TimeCacheMap? --- If your project is set up for it, you

[jira] [Commented] (STORM-1536) Eliminate or minimize use of deprecated TimeCacheMap

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15142769#comment-15142769 ] ASF GitHub Bot commented on STORM-1536: --- Github user dossett commented on the pull request:

[GitHub] storm pull request: STORM-1272: port backtype.storm.disruptor to j...

2016-02-11 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1095#discussion_r52607318 --- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj --- @@ -219,7 +220,7 @@ (let [val (AddressedTuple. task tuple)] (when (=

[jira] [Commented] (STORM-1272) port backtype.storm.disruptor to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15142712#comment-15142712 ] ASF GitHub Bot commented on STORM-1272: --- Github user abhishekagarwal87 commented on the pull

[jira] [Commented] (STORM-1272) port backtype.storm.disruptor to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15142798#comment-15142798 ] ASF GitHub Bot commented on STORM-1272: --- Github user revans2 commented on a diff in the pull

[GitHub] storm pull request: STORM-1272: port backtype.storm.disruptor to j...

2016-02-11 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1095#issuecomment-182889339 The changes look good to me and the unit tests all pass. My only concern now is the performance, and the disruptor queue code is on the critical path. Have you run

[jira] [Resolved] (STORM-1533) topologies with metric consumers fail in config validation phase

2016-02-11 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1533. Resolution: Fixed Fix Version/s: 1.0.0 Thanks [~abhishek.agarwal], I merged

[GitHub] storm pull request: STORM-1272: port backtype.storm.disruptor to j...

2016-02-11 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/1095#discussion_r52626052 --- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj --- @@ -227,13 +228,13 @@ component-id (.getComponentId worker-context (first

[jira] [Commented] (STORM-1533) topologies with metric consumers fail in config validation phase

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15142894#comment-15142894 ] ASF GitHub Bot commented on STORM-1533: --- Github user asfgit closed the pull request at:

[GitHub] storm pull request: STORM-1533: IntegerValidator for metric consum...

2016-02-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1091 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (STORM-1534) Incompatible jackson dependencies are being packed in storm package

2016-02-11 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1534. Resolution: Fixed Fix Version/s: 1.0.0 Thanks [~abhishek.agarwal], I merged

[GitHub] storm pull request: STORM-1536: Remove Java use of TimeCacheMap

2016-02-11 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/1092#issuecomment-182938537 @dossett Yes, that in addition to explaining that it is essentially a wrapper around `RotatingMap`. `RotatingMap`'s documentation should also be changed,

[jira] [Commented] (STORM-1536) Eliminate or minimize use of deprecated TimeCacheMap

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15142949#comment-15142949 ] ASF GitHub Bot commented on STORM-1536: --- Github user knusbaum commented on the pull request:

[jira] [Commented] (STORM-1272) port backtype.storm.disruptor to java

2016-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15142979#comment-15142979 ] ASF GitHub Bot commented on STORM-1272: --- Github user knusbaum commented on a diff in the pull

[GitHub] storm pull request: STORM-1242: migrate backtype.storm.command.con...

2016-02-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1059 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

  1   2   >