[GitHub] storm pull request #1882: STORM-1292: port backtype.storm.messaging-test to ...

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1882#discussion_r96807304 --- Diff: storm-core/test/jvm/org/apache/storm/MessagingTest.java --- @@ -0,0 +1,69 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] storm issue #1878: STORM-2295:KafkaSpoutStreamsNamedTopics changing the sequ...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1878 @pasalkarsachin1 PR has been applied to master via ba406c16a27221dc4c1ca7ac3d3c3164cb669bfd and 1.x-branch via f4fdab3a45017dc042eda0c0c65d06a37f6cf904. (I just cherry-picked 7168710

[GitHub] storm pull request #1883: STORM-2300 [Flux] support list of references

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1883 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1884: Storm-2236 Kafka Spout with manual partition management f...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1884 Travis CI build failure is unrelated and fix is available (#1887) @liurenjie1024 Could you please squash the commits into one? Ideally commit title would be `STORM-2236 Add manual

[GitHub] storm issue #1884: Storm-2236 Kafka Spout with manual partition management f...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1884 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #1887: STORM-2303 [storm-opentsdb] Fix list invariant issue for ...

Github user harshach commented on the issue: https://github.com/apache/storm/pull/1887 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #1886: STORM-2303 [storm-opentsdb] Fix list invariant issue for ...

Github user harshach commented on the issue: https://github.com/apache/storm/pull/1886 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm pull request #1887: STORM-2303 [storm-opentsdb] Fix list invariant iss...

GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/1887 STORM-2303 [storm-opentsdb] Fix list invariant issue for JDK 7 * use bounded wildcard type to fix invariant issue Succeed to build this with JDK 7, but let's see the result of Travis CI

[GitHub] storm pull request #1886: STORM-2303 [storm-opentsdb] Fix list invariant iss...

GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/1886 STORM-2303 [storm-opentsdb] Fix list invariant issue for JDK 7 * use bounded wildcard type to fix invariant issue I'll create pull request for 1.x separately to trigger Travis CI build

[GitHub] storm issue #1878: STORM-2295:KafkaSpoutStreamsNamedTopics changing the sequ...

Github user pasalkarsachin1 commented on the issue: https://github.com/apache/storm/pull/1878 I squashed it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] storm pull request #1866: STORM-2279: Unable to open bolt page of storm ui

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1866#discussion_r96786558 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -3600,7 +3600,7 @@ public ComponentPageInfo getComponentPageInfo(String

[GitHub] storm pull request #1884: Storm-2236 Kafka Spout with manual partition manag...

Github user liurenjie1024 commented on a diff in the pull request: https://github.com/apache/storm/pull/1884#discussion_r96784043 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/TopicPartitionComparator.java --- @@ -0,0 +1,16 @@ +package

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96763012 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -447,7 +440,10 @@ private void shutdown() {

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96764322 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaTuple.java --- @@ -15,22 +15,33 @@ * See the License for the

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96743744 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/selector/FieldNameTopicSelector.java --- @@ -0,0 +1,49 @@ +/** + *

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96756536 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/Subscription.java --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96763257 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -609,4 +593,7 @@ public String toString() {

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96763944 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaTuple.java --- @@ -15,22 +15,33 @@ * See the License for the

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96774008 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/RecordTranslator.java --- @@ -0,0 +1,55 @@ +/* + * Licensed to the

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96779787 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/TridentKafkaState.java --- @@ -0,0 +1,114 @@ +/** + * Licensed to

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96775680 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/RoundRobinManualPartitioner.java --- @@ -15,14 +15,26 @@ * See the

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96722977 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/mapper/TupleToKafkaMapper.java --- @@ -0,0 +1,32 @@ +/** + * Licensed

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96779676 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/TridentKafkaState.java --- @@ -0,0 +1,114 @@ +/** + * Licensed to

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96761049 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -325,15 +310,19 @@ private boolean

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96740920 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/selector/FieldIndexTopicSelector.java --- @@ -0,0 +1,52 @@ +/** + *

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96776152 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/Subscription.java --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96780580 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/mapper/FieldNameBasedTupleToKafkaMapper.java --- @@ -0,0 +1,41 @@ +/**

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96744488 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/selector/FieldIndexTopicSelector.java --- @@ -0,0 +1,52 @@ +/** + *

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96780567 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/mapper/FieldNameBasedTupleToKafkaMapper.java --- @@ -0,0 +1,41 @@ +/**

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96762055 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/TopicPartitionComparator.java --- @@ -1,16 +1,35 @@ +/* + * Licensed

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96773771 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/NamedSubscription.java --- @@ -0,0 +1,58 @@ +/* + * Licensed to the

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96774279 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/RecordTranslator.java --- @@ -0,0 +1,55 @@ +/* + * Licensed to the

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96780204 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/selector/KafkaTopicSelector.java --- @@ -0,0 +1,26 @@ +/** + * Licensed

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96767284 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/ManualPartitionNamedSubscription.java --- @@ -0,0 +1,78 @@ +/* + *

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96762352 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/NamedSubscription.java --- @@ -0,0 +1,58 @@ +/* + * Licensed to the

Re: [DISCUSS] Adopt pull request template

+1 for adopting a template. Not sure if it is possible, but I wouldn't mind eyeing the same for JIRA. -Taylor > On Jan 18, 2017, at 9:10 PM, Jungtaek Lim wrote: > > Hi devs, > > I have seen some pull requests which are not having JIRA issue, or bad > title, or no

[DISCUSS] Adopt pull request template

Hi devs, I have seen some pull requests which are not having JIRA issue, or bad title, or no description for rationale on pull request and issue. We already have DEVELOPER.md but this document covers more than contribution and also not shown while opening pull request. I think we should add

[GitHub] storm issue #1878: STORM-2295:KafkaSpoutStreamsNamedTopics changing the sequ...

Github user hmcl commented on the issue: https://github.com/apache/storm/pull/1878 I would suggest for title `STORM-2295 KafkaSpoutStreamsNamedTopics should return output fields with predictable ordering` --- If your project is set up for it, you can reply to this email and have

[GitHub] storm issue #1817: STORM-2237: Nimbus reports bad supervisor heartbeat - unk...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1817 Any updates here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] storm issue #1878: STORM-2295:KafkaSpoutStreamsNamedTopics changing the sequ...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1878 @pasalkarsachin1 And also please squash the commits into one after fixing license info. I recommend the title of commit message as `STORM-2295 KafkaSpoutStreamsNamedTopics changing the

[GitHub] storm issue #1881: STORM-2298 Don't kill Nimbus when ClusterMetricsConsumer ...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1881 @harshach Thanks for reviewing. I addressed your comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm pull request #1881: STORM-2298 Don't kill Nimbus when ClusterMetricsCo...

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1881#discussion_r96775630 --- Diff: storm-core/src/jvm/org/apache/storm/metric/ClusterMetricsConsumerExecutor.java --- @@ -40,31 +39,49 @@ public

[GitHub] storm issue #1831: STORM-2249: Make Distribution Scripts Put Examples to the...

Github user harshach commented on the issue: https://github.com/apache/storm/pull/1831 @HeartSaVioR I think it makes sense to have the shaded jars. It will be easier to run the code for the users who not familiar with storm packaging and gives insight into building a topology jar as

[GitHub] storm pull request #1881: STORM-2298 Don't kill Nimbus when ClusterMetricsCo...

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1881#discussion_r96770202 --- Diff: storm-core/src/jvm/org/apache/storm/metric/ClusterMetricsConsumerExecutor.java --- @@ -40,31 +39,49 @@ public

[GitHub] storm pull request #1850: STORM-2268 Disable integration test for Travis CI ...

Github user HeartSaVioR closed the pull request at: https://github.com/apache/storm/pull/1850 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1850: STORM-2268 Disable integration test for Travis CI build

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1850 OK I'll close this. Thanks @raghavgautam for following up the issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm issue #1873: Kafka spout - no duplicates on leader changes

Github user harshach commented on the issue: https://github.com/apache/storm/pull/1873 @ernisv please add to PR title as well. Also can you open this against 1.x-branch or master so that we can cherry-pick from there to other branches. --- If your project is set up for it, you can

[GitHub] storm issue #1878: STORM-2295:KafkaSpoutStreamsNamedTopics changing the sequ...

Github user harshach commented on the issue: https://github.com/apache/storm/pull/1878 @pasalkarsachin1 one of the files missing the License info. Please add that. We can merge it in after that. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm pull request #1878: STORM-2295:KafkaSpoutStreamsNamedTopics changing t...

Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1878#discussion_r96769287 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutStreamsNamedTopicsTest.java --- @@ -0,0 +1,23 @@ +package

[GitHub] storm pull request #1881: STORM-2298 Don't kill Nimbus when ClusterMetricsCo...

Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1881#discussion_r96769031 --- Diff: storm-core/src/jvm/org/apache/storm/metric/ClusterMetricsConsumerExecutor.java --- @@ -40,31 +39,49 @@ public

[GitHub] storm issue #1884: Storm-2236 Kafka Spout with manual partition management f...

Github user harshach commented on the issue: https://github.com/apache/storm/pull/1884 @liurenjie1024 TopicPartitionComparator missing Apache License. Can you add that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] storm pull request #1884: Storm-2236 Kafka Spout with manual partition manag...

Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1884#discussion_r96768426 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/TopicPartitionComparator.java --- @@ -0,0 +1,16 @@ +package

[GitHub] storm issue #1883: STORM-2300 [Flux] support list of references

Github user harshach commented on the issue: https://github.com/apache/storm/pull/1883 +1. Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] storm issue #1882: STORM-1292: port backtype.storm.messaging-test to java Vi...

Github user harshach commented on the issue: https://github.com/apache/storm/pull/1882 @kamleshbhatt you can do the following in your branch. git rebase -i HEAD~9 and pick one commit as your main commit and add "s" against all the other commits. and change the commit

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96731003 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -235,41 +355,116 @@ public Builder(Map

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96734787 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -61,129 +66,244 @@ * If no offset has

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96721536 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java --- @@ -0,0 +1,196 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96730185 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -235,41 +355,116 @@ public Builder(Map

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96723152 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java --- @@ -0,0 +1,196 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96733517 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/Subscription.java --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96728300 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -61,129 +66,244 @@ * If no offset has

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96727056 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -609,4 +593,7 @@ public String toString() {

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96734680 --- Diff: external/storm-kafka/src/jvm/org/apache/storm/kafka/bolt/KafkaBolt.java --- @@ -51,7 +51,9 @@ * This bolt uses 0.8.2 Kafka Producer API. *

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96729446 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -61,129 +66,244 @@ * If no offset has

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96726868 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -412,8 +401,12 @@ public void activate() {

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96726512 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -225,11 +213,7 @@ public void nextTuple() {

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96725508 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/ByTopicRecordTranslator.java --- @@ -0,0 +1,93 @@ +/* + * Licensed to

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96725703 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -80,16 +76,14 @@ private transient

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96730015 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -235,41 +355,116 @@ public Builder(Map

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96721101 --- Diff: external/storm-kafka-client/README.md --- @@ -1,191 +1,5 @@ -#Storm Kafka Spout with New Kafka Consumer API +#Storm Apache Kafka integration

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96721821 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java --- @@ -0,0 +1,196 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96712816 --- Diff: docs/storm-kafka-client.md --- @@ -1,90 +1,232 @@ -#Storm Kafka Spout with New Kafka Consumer API +#Storm Apache Kafka integration using the

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96712487 --- Diff: docs/storm-kafka-client.md --- @@ -1,90 +1,232 @@ -#Storm Kafka Spout with New Kafka Consumer API +#Storm Apache Kafka integration using the

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96713059 --- Diff: docs/storm-kafka-client.md --- @@ -1,90 +1,232 @@ -#Storm Kafka Spout with New Kafka Consumer API +#Storm Apache Kafka integration using the

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96711515 --- Diff: docs/storm-kafka-client.md --- @@ -1,90 +1,232 @@ -#Storm Kafka Spout with New Kafka Consumer API +#Storm Apache Kafka integration using the

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96719192 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java --- @@ -0,0 +1,196 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96719100 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java --- @@ -0,0 +1,196 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96713362 --- Diff: docs/storm-kafka-client.md --- @@ -1,90 +1,232 @@ -#Storm Kafka Spout with New Kafka Consumer API +#Storm Apache Kafka integration using the

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96716770 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java --- @@ -0,0 +1,194 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96720421 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java --- @@ -0,0 +1,196 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96710739 --- Diff: docs/storm-kafka-client.md --- @@ -1,90 +1,232 @@ -#Storm Kafka Spout with New Kafka Consumer API +#Storm Apache Kafka integration using the

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96717295 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java --- @@ -0,0 +1,196 @@ +/** + * Licensed to the Apache

[GitHub] storm issue #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1808 The test failures are unrelated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm issue #1884: Storm-2236 Kafka Spout with manual partition management f...

Github user harshach commented on the issue: https://github.com/apache/storm/pull/1884 +1. Thanks @liurenjie1024 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm issue #1850: STORM-2268 Disable integration test for Travis CI build

Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/1850 @harshach I worked on this jira and found a few product issues. I worked with @HeartSaVioR and all these issues have been fixed & closed. The tests are running fine now. We only see one

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96694593 --- Diff: docs/storm-kafka-client.md --- @@ -1,90 +1,232 @@ -#Storm Kafka Spout with New Kafka Consumer API +#Storm Apache Kafka integration using the

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96694426 --- Diff: docs/storm-kafka-client.md --- @@ -1,90 +1,232 @@ -#Storm Kafka Spout with New Kafka Consumer API +#Storm Apache Kafka integration using the

Re: Stop user from killing topology before X (configured) amount of time

1.x and master have diverged a lot.  If you want this on 1.x you will need to create two pull requests one for master and one for 1.x-branch https://github.com/apache/storm/tree/1.x-branch The code you want to look at for this is here

Re: Stop user from killing topology before X (configured) amount of time

Sorry for spamming. Can someone help in pointing out branch, I want to fix this if possible? Thanks, Sachin On 18/01/17, 8:06 AM, "Sachin Pasalkar" wrote: >Can you point out the branch which I need to checkout? I don¹t see below >Nimbus class in 1.x branch > >On

[GitHub] storm issue #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1808 @srdo @harshach sorry to do this to you, but I just fixed the conflicts with STORM-2236. Sadly the fastest way I could do it was to revert the original code and implement similar functionality,

ApacheCon CFP closing soon (11 February)

Hello, fellow Apache enthusiast. Thanks for your participation, and interest in, the projects of the Apache Software Foundation. I wanted to remind you that the Call For Papers (CFP) for ApacheCon North America, and Apache: Big Data North America, closes in less than a month. If you've been

[GitHub] storm issue #1882: STORM-1292: port backtype.storm.messaging-test to java Vi...

Github user kamleshbhatt commented on the issue: https://github.com/apache/storm/pull/1882 @harshach thanks for reviewing the PR. I tried to squash the commits but not sure why it is throwing error. --- If your project is set up for it, you can reply to this email and have your

Re: [DISCUSS] New Kafka spout doesn't support seek to given offset

[Updated Subject] Incase of 2nd case, as user has changed group.id there will be no history for this id. So code will automatically fall down to the EARLIEST or LATEST. I was able to code for it somewhat where I am able to fetch data from certain offset (with kind of hack). What I have seen is

Re: New Kafka spout doesn't support seek to given offset

Seems fair.  File a JIRA and we can look into it - Bobby On Wednesday, January 18, 2017, 10:21:36 AM CST, Jungtaek Lim wrote:Personally I met many situations in production which force me start reprocessing from specific offset (actually data source was not Kafka but

Re: New Kafka spout doesn't support seek to given offset

Personally I met many situations in production which force me start reprocessing from specific offset (actually data source was not Kafka but log-like structured MySQL table). Reprocessing is a common case which users occasionally meet the needs, and if possible it would be better for storm-kafka

Re: New Kafka spout doesn't support seek to given offset

Hi Sachin, The 2nd case can likely handled with the committed offset, which is covered by UNCOMMITTED_EARLIEST or UNCOMMITTED_LATEST. The 1st case it may make sense but even if you give the start offset, since Kafka polls a certain number of bytes, and not specifically a number of records, it

[GitHub] storm issue #1878: STORM-2295:KafkaSpoutStreamsNamedTopics changing the sequ...

Github user pasalkarsachin1 commented on the issue: https://github.com/apache/storm/pull/1878 Can someone merge it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request #1851: STORM-2270 Kafka spout should consume from latest ...

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1851#discussion_r96600516 --- Diff: external/storm-kafka/src/jvm/org/apache/storm/kafka/PartitionManager.java --- @@ -199,7 +199,12 @@ private void fill() { try {

[GitHub] storm pull request #1880: STORM-2297 [storm-opentsdb] Support Flux for OpenT...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1880 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #1875: STORM-2293 hostname should only refer node's 'stor...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1875 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

  1   2   >