[GitHub] storm pull request #2511: [STORM-2893] fix storm distribution build by using...

GitHub user erikdw opened a pull request: https://github.com/apache/storm/pull/2511 [STORM-2893] fix storm distribution build by using POSIX tar There is a known issue with the maven-assembly-plugin version 2.5+ where it fails with errors like the following: ```

[GitHub] storm pull request #2510: [STORM-2892] fix PATH substitution in flux tests

GitHub user erikdw opened a pull request: https://github.com/apache/storm/pull/2510 [STORM-2892] fix PATH substitution in flux tests The tests fail when the PATH environment variable has a trailing colon, despite that being a valid PATH. This happens because it is substituted

[GitHub] storm issue #2433: [STORM-2693] Heartbeats and assignments promotion for sto...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2433 @danny0405 Yeah I understand it is not ideal. Let's wait for more inputs. If the new behavior (for old workers, when supervisor killed) is acceptable we can just go on. If it isn't, the

[GitHub] storm issue #2433: [STORM-2693] Heartbeats and assignments promotion for sto...

Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/2433 @HeartSaVioR Yes, this is the case, but i don't suggest to mix two kinds of heartbeats aware logics in Nimbus, it's too heavy for scheduling[with old workers] and this is not the intention of

[GitHub] storm issue #2433: [STORM-2693] Heartbeats and assignments promotion for sto...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2433 @revans2 I'm going through workarounds here. Could you review this as well, and provide review comments/suggestions? It would be really appreciated if you could test the patch against old

[GitHub] storm issue #2433: [STORM-2693] Heartbeats and assignments promotion for sto...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2433 @danny0405 OK. I have been switching the context from multiple projects/issues recent days so may miss the detail on this patch, and even confusion with current implementation (sad).

[GitHub] storm issue #2433: [STORM-2693] Heartbeats and assignments promotion for sto...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2433 @danny0405 Sorry I should explain the motivation before. The motivation is well explained to the description on https://issues.apache.org/jira/browse/STORM-2448. Explaining

[GitHub] storm issue #2433: [STORM-2693] Heartbeats and assignments promotion for sto...

Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/2433 @HeartSaVioR But with this patch nimbus can collect both the 2.0./1.x workers heartbeats, this is no differences here. We do not collect heartbeats based on workers now. ---

[GitHub] storm issue #2433: [STORM-2693] Heartbeats and assignments promotion for sto...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2433 @danny0405 We have SUPERVISOR_WORKER_VERSION_CLASSPATH_MAP in Config, which is a map representing supported versions in supervisor. Assuming all the nodes have consistent configuration,

[GitHub] storm issue #2433: [STORM-2693] Heartbeats and assignments promotion for sto...

Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/2433 @HeartSaVioR Actually, this patch can work with old workers if we upgrade all the daemons: Nimbus/Supervisors, cause supervisors collect local heartbeats and report to Nimbus through RPC.

[GitHub] storm issue #2467: STORM-2860: Add Kerberos support to Solr bolt

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2467 @satishd @hmcl Friendly reminder: I'll merge this by tomorrow or so if we have no more comments from then. ---

[GitHub] storm issue #2505: STORM-2877: Add an option to configure pagination in Stor...

Github user srishtyagrawal commented on the issue: https://github.com/apache/storm/pull/2505 @revans2 I have made the changes suggested by you. I have also built and tested the code against values mentioned in the first comment (the functionality is same as mentioned in the table).

[GitHub] storm pull request #2505: STORM-2877: Add an option to configure pagination ...

Github user srishtyagrawal commented on a diff in the pull request: https://github.com/apache/storm/pull/2505#discussion_r160570956 --- Diff: storm-server/src/main/java/org/apache/storm/DaemonConfig.java --- @@ -307,6 +307,12 @@ @isString public static final

[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2203 @revans2 @ptgoetz Btw, shouldn't we pass task id instead of executor id? You know a executor has tasks and we are providing metrics from each task, not from executor. Also the format of

[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2203 @revans2 @ptgoetz Looks like string concatenation affects a lot. Maybe we should spend time to optimize here. One sketched idea is here: If metric name is deterministic at least

[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2203 I just tried it again with 44cd8ac on 1a03093 and got the same results. A maximum throughput of about 30,000 sentences per second. ---

[GitHub] storm pull request #2203: STORM-2153: New Metrics Reporting API

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2203#discussion_r160544887 --- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj --- @@ -446,7 +451,7 @@ (.ack spout msg-id) (task/apply-hooks

[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2203 The changes look good an I am +1 on where they are at now. I am a little concerned about the performance differences though. I did a quick test with 1.x-branch

[GitHub] storm pull request #2509: Add link to JIRA search showing open newbie labell...

GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2509 Add link to JIRA search showing open newbie labelled issues to contri… …buting page Seems like a good way to make finding issues a little more convenient for new people. You can merge

[GitHub] storm issue #2508: Updated how to get the storm-starter code

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2508 Thanks for contributing @aqeelvn. Keep up the good work :) ---

[GitHub] storm-site pull request #3: Update README, the guide for building the site w...

GitHub user srdo opened a pull request: https://github.com/apache/storm-site/pull/3 Update README, the guide for building the site was not correct The README contains a lot of references to the SVN repository. It also doesn't mention how to fetch the site dependencies

[GitHub] storm pull request #2203: STORM-2153: New Metrics Reporting API

Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/2203#discussion_r160513274 --- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj --- @@ -446,7 +451,7 @@ (.ack spout msg-id) (task/apply-hooks

[GitHub] storm pull request #2203: STORM-2153: New Metrics Reporting API

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2203#discussion_r160509152 --- Diff: storm-core/src/jvm/org/apache/storm/nimbus/DefaultTopologyValidator.java --- @@ -17,15 +17,49 @@ */ package org.apache.storm.nimbus;

[GitHub] storm-site pull request #2: Update dependencies

GitHub user srdo opened a pull request: https://github.com/apache/storm-site/pull/2 Update dependencies You can merge this pull request into a Git repository by running: $ git pull https://github.com/srdo/storm-site update-dependencies Alternatively you can review and apply

[GitHub] storm pull request #2203: STORM-2153: New Metrics Reporting API

Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/2203#discussion_r160508705 --- Diff: storm-core/src/jvm/org/apache/storm/nimbus/DefaultTopologyValidator.java --- @@ -17,15 +17,49 @@ */ package org.apache.storm.nimbus;

[GitHub] storm pull request #2203: STORM-2153: New Metrics Reporting API

Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/2203#discussion_r160506051 --- Diff: storm-core/src/jvm/org/apache/storm/task/TopologyContext.java --- @@ -386,4 +388,28 @@ public ReducedMetric registerMetric(String name, IReducer

[GitHub] storm pull request #2203: STORM-2153: New Metrics Reporting API

Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/2203#discussion_r160505473 --- Diff: storm-core/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java --- @@ -0,0 +1,156 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #2508: Updated how to get the storm-starter code

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2508 ---

[GitHub] storm pull request #2203: STORM-2153: New Metrics Reporting API

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2203#discussion_r160496988 --- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj --- @@ -446,7 +451,7 @@ (.ack spout msg-id) (task/apply-hooks

[GitHub] storm pull request #2203: STORM-2153: New Metrics Reporting API

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2203#discussion_r160499046 --- Diff: storm-core/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java --- @@ -0,0 +1,135 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #2203: STORM-2153: New Metrics Reporting API

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2203#discussion_r160499205 --- Diff: storm-core/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java --- @@ -0,0 +1,156 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #2203: STORM-2153: New Metrics Reporting API

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2203#discussion_r160498091 --- Diff: storm-core/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java --- @@ -0,0 +1,156 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #2203: STORM-2153: New Metrics Reporting API

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2203#discussion_r160501227 --- Diff: storm-core/src/jvm/org/apache/storm/nimbus/DefaultTopologyValidator.java --- @@ -17,15 +17,49 @@ */ package org.apache.storm.nimbus;

[GitHub] storm pull request #2203: STORM-2153: New Metrics Reporting API

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2203#discussion_r160498347 --- Diff: storm-core/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java --- @@ -0,0 +1,156 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #2203: STORM-2153: New Metrics Reporting API

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2203#discussion_r160501820 --- Diff: storm-core/src/jvm/org/apache/storm/task/TopologyContext.java --- @@ -386,4 +388,28 @@ public ReducedMetric registerMetric(String name, IReducer

[GitHub] storm pull request #2203: STORM-2153: New Metrics Reporting API

Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/2203#discussion_r160499395 --- Diff: storm-core/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java --- @@ -0,0 +1,135 @@ +/** + * Licensed to the Apache Software

[GitHub] storm issue #2508: Updated how to get the storm-starter code

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2508 +1 ---

[GitHub] storm pull request #2508: Updated how to get the storm-starter code

GitHub user aqeelvn opened a pull request: https://github.com/apache/storm/pull/2508 Updated how to get the storm-starter code A typical use case for somebody trying this is, first setting up a working storm installation and then running the example. If the storm-starter code is

[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2203 Sorry about not responding earlier. Thanks for addressing my comments. I skimmed the comments, and found a question that might have been missed

Re: [Discuss] Release Storm 1.2.0 (cont.)

On Dec 28, 2017, at 2:51 PM, Arun Mahadevan wrote: > >>> New Feature >> STORM-2153: New Metrics Reporting API [2] > > I think this is waiting for a final +1 from revans2. > Technically, we don’t need to wait for a +1 from any single committer, but in practice I like to

[GitHub] storm issue #2504: STORM-2156: store metrics into RocksDB

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2504 @revans2 Great news! Looking forward to new news about that. ---

[GitHub] storm issue #2504: STORM-2156: store metrics into RocksDB

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2504 @HeartSaVioR not a problem. I often forget that others are not able to read my thoughts and I sometimes forget to mention the context. The code was not really a prototype. We intend it to

[GitHub] storm issue #2504: STORM-2156: store metrics into RocksDB

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2504 @revans2 Thanks a lot for sharing current status. Actually I have been aware of the patch going through @abellina forked repo, so I expect HBase plugin and UI patch would be adopted internally,

[GitHub] storm issue #2504: STORM-2156: store metrics into RocksDB

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2504 @HeartSaVioR sorry about that I think we probably were not clear enough on this, what is covered and what is not currently covered by this pull request. Reading through the description of

Re: [DISCUSS] Release Storm 1.0.5 / 1.1.2

+1 to start release process for 1.1.2v On Tue, Jan 9, 2018 at 2:15 AM, Stig Rohde Døssing wrote: > +1 for starting 1.1.2 release process. > > 2018-01-08 20:27 GMT+01:00 P. Taylor Goetz : > > > +1 > > > > If there are no remaining issues to be included,