[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165852132 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -519,6 +519,15 @@ private boolean isEmitTuple(List

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165852072 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -453,37 +459,33 @@ public Builder(String

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165854399 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm issue #2537: STORM-2914: Implement ProcessingGuarantee.NONE in the spo...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2537 @hmcl Thanks for the review, caught a lot of oversights :) ---

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165853341 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165854507 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -469,11 +437,14 @@ private boolean

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165854506 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -396,7 +361,10 @@ private void

[GitHub] storm issue #2537: STORM-2914: Implement ProcessingGuarantee.NONE in the spo...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2537 @hmcl Addressed your comments. Also fixed the storm-kafka-client docs to use release specific links, instead of linking to the 1.0.x branch. I've removed some of the listings of enum values in favor of

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165852894 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -143,28 +146,28 @@ public String toString() {

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165852904 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -453,37 +459,33 @@ public Builder(String

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165854164 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165852737 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -469,11 +437,14 @@ private boolean

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165852696 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -396,7 +361,10 @@ private void

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165852835 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165852864 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165853160 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165852670 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -396,7 +361,10 @@ private void

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165853046 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -469,11 +437,14 @@ private boolean

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165852989 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165853240 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -311,7 +273,10 @@ public void nextTuple() {

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165852272 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -142,7 +139,7 @@ public void open(Map

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165853784 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -142,7 +139,7 @@ public void open(Map

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165853833 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165854458 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165854760 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165850084 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -210,23 +215,26 @@ public Builder(String

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165850087 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -453,37 +451,33 @@ public Builder(String

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165850081 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -519,6 +519,15 @@ private boolean isEmitTuple(List

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165851895 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -143,28 +146,28 @@ public String toString() {

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2537#discussion_r165852060 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -453,37 +459,33 @@ public Builder(String

[GitHub] storm issue #2537: STORM-2914: Implement ProcessingGuarantee.NONE in the spo...

Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2537 +1. Let's squash and as far as I am concerned it is good to merge. Once this is squash can you please rebase STORM-2913. Thanks. ---

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165853798 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -396,7 +361,10 @@ private void

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165854105 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm issue #2538: STORM-2913: Add metadata to at-most-once and at-least-onc...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2538 @hmcl Rebased. ---

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165857479 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -142,7 +139,7 @@ public void open(Map

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165857829 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -453,37 +460,37 @@ public Builder(String

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165857745 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165857816 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -453,37 +460,37 @@ public Builder(String

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165857620 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165859143 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm issue #2538: STORM-2913: Add metadata to at-most-once and at-least-onc...

Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2538 +1. Once squashed is good to merge as far as I am concerned. Thanks a lot @srdo. ---

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165858606 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165857949 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165857469 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -75,8 +75,9 @@ public boolean

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165857516 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165859312 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm issue #2538: STORM-2913: Add metadata to at-most-once and at-least-onc...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2538 @srdo Thanks for the great work. I'd rather not review the two PRs since @hmcl already gave a nice review. If you would like to merge twos by yourself, please replace storm-kafka-client

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2538 ---

[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2537 ---

[GitHub] storm issue #2537: STORM-2914: Implement ProcessingGuarantee.NONE in the spo...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2537 @srdo I've found some divergence between master and 1.x branch. Could you raise pull request on 1.x-branch as well? I'm OK to raise a PR with two commits (STORM-2914/STORM-2913). ---