[GitHub] storm pull request #2537: STORM-2914: Implement ProcessingGuarantee.NONE in ...

[srdo]

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2537#discussion_r165850087
  
    --- Diff: 
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
 ---
    @@ -453,37 +451,33 @@ public Builder(String bootstrapServers, Subscription 
subscription) {
             return builder;
         }
     
    -    private static void setAutoCommitMode(Builder<?, ?> builder) {
    +    private static void setPropsToFitProcessingGuarantee(Builder<?, ?> 
builder) {
             if 
(builder.kafkaProps.containsKey(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG)) {
    -            throw new IllegalArgumentException("Do not set " + 
ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG + " manually."
    -                + " Instead use 
KafkaSpoutConfig.Builder.setProcessingGuarantee");
    +            throw new IllegalArgumentException("Do not set " + 
ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG
    --- End diff --
    
    This isn't javadoc, so linking won't work. Changed the message to be 
friendlier.


---