Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r202504021
--- Diff: storm-core/src/clj/org/apache/storm/ui/core.clj ---
@@ -1613,24 +1613,24 @@
https-want-client-auth (conf
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2590
I have found that couple of public classes are renamed, but they're in
`internal` package which makes others feeling non-public, so I think we are OK.
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2590
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2762#discussion_r202300189
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java
---
@@ -47,12 +47,20 @@ public void channelRead(ChannelHandlerContext
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2762#discussion_r202299829
--- Diff:
storm-client/test/jvm/org/apache/storm/messaging/netty/BackPressureStatusTest.java
---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2762#discussion_r202341617
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java
---
@@ -47,12 +47,20 @@ public void
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2762#discussion_r202342773
--- Diff:
storm-client/test/jvm/org/apache/storm/messaging/netty/BackPressureStatusTest.java
---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2762#discussion_r202343054
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java
---
@@ -47,12 +47,20 @@ public void
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2762#discussion_r202342969
--- Diff:
storm-client/test/jvm/org/apache/storm/messaging/netty/BackPressureStatusTest.java
---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2762#discussion_r202344011
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java
---
@@ -47,12 +47,20 @@ public void channelRead(ChannelHandlerContext
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2762#discussion_r202343846
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java
---
@@ -47,12 +47,20 @@ public void channelRead(ChannelHandlerContext
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2762#discussion_r202344217
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java
---
@@ -47,12 +47,24 @@ public void channelRead(ChannelHandlerContext
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2762#discussion_r202346634
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java
---
@@ -47,12 +47,20 @@ public void channelRead(ChannelHandlerContext
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2762#discussion_r202345723
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java
---
@@ -47,12 +47,24 @@ public void
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202282820
--- Diff: docs/storm-sql-internal.md ---
@@ -1,59 +0,0 @@
--- End diff --
I removed the document since it is documented based on
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2443
@srdo
Rebased. I'm seeing intermittent test failure like below, but not
consistent failure. Will try to take a look at once I have time to, but let's
move it out of this PR.
```
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202356815
--- Diff:
sql/storm-sql-external/storm-sql-mongodb/src/jvm/org/apache/storm/sql/mongodb/MongoDataSourcesProvider.java
---
@@ -47,54 +45,60 @@
* The
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202355372
--- Diff:
sql/storm-sql-external/storm-sql-hdfs/src/test/org/apache/storm/sql/hdfs/TestHdfsDataSourcesProvider.java
---
@@ -88,46 +75,12 @@ public void
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202341073
--- Diff: docs/storm-sql-internal.md ---
@@ -1,59 +0,0 @@
--- End diff --
I'm wondering if it would be worth updating this rather than
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202347946
--- Diff:
sql/storm-sql-core/src/jvm/org/apache/storm/sql/compiler/CompilerUtil.java ---
@@ -118,16 +138,32 @@ public RelDataType getRowType(
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202345310
--- Diff: sql/README.md ---
@@ -1,187 +1,8 @@
# Storm SQL
-Compile SQL queries to Storm topologies.
+Compile SQL queries to Storm topologies
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202359820
--- Diff:
sql/storm-sql-runtime/src/test/org/apache/storm/sql/TestUtils.java ---
@@ -41,7 +26,46 @@
import java.util.Map;
import
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202357967
--- Diff:
sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/datasource/socket/bolt/SocketBolt.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202358383
--- Diff:
sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/datasource/socket/bolt/SocketBolt.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202349103
--- Diff:
sql/storm-sql-core/src/jvm/org/apache/storm/sql/planner/streams/StreamsStormRuleSets.java
---
@@ -72,13 +72,13 @@
// merge and push
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202350280
--- Diff:
sql/storm-sql-core/src/jvm/org/apache/storm/sql/planner/streams/rel/StreamsStreamInsertRel.java
---
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202344785
--- Diff: docs/storm-sql.md ---
@@ -6,14 +6,14 @@ documentation: true
The Storm SQL integration allows users to run SQL queries over streaming
data
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2744
@HeartSaVioR Removed unwanted condition.
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2762#discussion_r202431877
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java
---
@@ -47,12 +47,20 @@ public void
GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2764
STORM-3147: Port ClusterSummary to StormMetricsRegistry
This PR depends on #2763
The implementation is kind of ugly right now due to caching and
synchronization in metrics update. I hope
GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2763
STORM-3150: Improve Gauge registration methods and refactored code
STORM-3150
You can merge this pull request into a Git repository by running:
$ git pull
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2762#discussion_r202431655
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java
---
@@ -47,12 +47,24 @@ public void
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2762
---
33 matches
Mail list logo
