[GitHub] storm pull request: [STORM-1513] Added documentation for filter, m...

2016-02-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1070#issuecomment-179794733 +1 Great --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Assigned] (STORM-1492) With nimbus.seeds set to default, a nimbus for localhost may appear "Offline"

2016-02-04 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim reassigned STORM-1492: --- Assignee: Jungtaek Lim > With nimbus.seeds set to default, a nimbus for localhost may appear

[jira] [Updated] (STORM-1516) Topology with time based windowing bolts are not getting killed properly.

2016-02-04 Thread Satish Duggana (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated STORM-1516: -- Description: When topology with timebased windowing bolts are killed, respective workers are

[jira] [Commented] (STORM-1513) Update trident api docs

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132227#comment-15132227 ] ASF GitHub Bot commented on STORM-1513: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: [STORM-1524] Add Pluggable daemon statistics -...

2016-02-04 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1075#issuecomment-180056177 +1 one minor nit so small it does not matter. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Comment Edited] (STORM-1492) With nimbus.seeds set to default, a nimbus for localhost may appear "Offline"

2016-02-04 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132313#comment-15132313 ] Jungtaek Lim edited comment on STORM-1492 at 2/4/16 9:33 PM: - While I'm

Re: Performance Profiling - Storm core

2016-02-04 Thread Roshan Naik
Thanks Abhishek and Jungtaek for the response. That worked. (I thought I had already tried that but ..) Anyway here is the impact of that change on the Transfers for the Speed of Light topology (1 spout instance, 1 bolt instance, no ackers, 1 worker) ... Before: ~450k events/sec After : ~735k

[GitHub] storm pull request: [STORM-1524] Add Pluggable daemon statistics -...

2016-02-04 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1075#discussion_r51938178 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/metrics/reporters/ConsolePreparableReporter.java --- @@ -0,0 +1,81 @@ +/** + * Licensed to the

[jira] [Commented] (STORM-1524) Make Storm daemon function statistics reporter pluggable

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133039#comment-15133039 ] ASF GitHub Bot commented on STORM-1524: --- Github user revans2 commented on a diff in the pull

[jira] [Commented] (STORM-1368) For secure cluster, heapdump file lacks of group read permissions for UI download

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133260#comment-15133260 ] ASF GitHub Bot commented on STORM-1368: --- GitHub user zhuoliu opened a pull request:

[GitHub] storm pull request: [STORM-1368] change heapdump file permissions ...

2016-02-04 Thread zhuoliu
GitHub user zhuoliu opened a pull request: https://github.com/apache/storm/pull/1078 [STORM-1368] change heapdump file permissions so that UI download wil… Change heapdump file permissions so that UI download wil work in secure clusters. a. For automatically generated

[jira] [Commented] (STORM-1492) With nimbus.seeds set to default, a nimbus for localhost may appear "Offline"

2016-02-04 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133180#comment-15133180 ] Jungtaek Lim commented on STORM-1492: - Since Nimbus HA setup is not mandatory, I expect many users

[jira] [Assigned] (STORM-1526) Improve Storm core performance

2016-02-04 Thread Roshan Naik (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roshan Naik reassigned STORM-1526: -- Assignee: Roshan Naik > Improve Storm core performance > -- > >

[jira] [Commented] (STORM-1524) Make Storm daemon function statistics reporter pluggable

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133053#comment-15133053 ] ASF GitHub Bot commented on STORM-1524: --- Github user revans2 commented on the pull request:

[jira] [Created] (STORM-1526) Improve Storm core performance

2016-02-04 Thread Roshan Naik (JIRA)
Roshan Naik created STORM-1526: -- Summary: Improve Storm core performance Key: STORM-1526 URL: https://issues.apache.org/jira/browse/STORM-1526 Project: Apache Storm Issue Type: Bug

[jira] [Commented] (STORM-1492) With nimbus.seeds set to default, a nimbus for localhost may appear "Offline"

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133781#comment-15133781 ] ASF GitHub Bot commented on STORM-1492: --- Github user HeartSaVioR closed the pull request at:

[jira] [Commented] (STORM-1492) With nimbus.seeds set to default, a nimbus for localhost may appear "Offline"

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133782#comment-15133782 ] ASF GitHub Bot commented on STORM-1492: --- GitHub user HeartSaVioR reopened a pull request:

[GitHub] storm pull request: STORM-1455: Do not reset the emittedOffset for...

2016-02-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1026#issuecomment-180221434 Forgot to leave comment, also backported to 1.x-branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (STORM-1455) kafka spout should not reset to the beginning of partition when offsetoutofrange exception occurs

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133742#comment-15133742 ] ASF GitHub Bot commented on STORM-1455: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: [STORM-1273] port backtype.storm.cluster to ja...

2016-02-04 Thread hustfxj
GitHub user hustfxj opened a pull request: https://github.com/apache/storm/pull/1081 [STORM-1273] port backtype.storm.cluster to java 1. port cluster.clj to ClusterUtils/StormClusterState/StateStorage/ZKStateStorage/ZKStateStorageFactory 2. Update all the callings to cluster

[jira] [Commented] (STORM-1492) With nimbus.seeds set to default, a nimbus for localhost may appear "Offline"

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133765#comment-15133765 ] ASF GitHub Bot commented on STORM-1492: --- GitHub user HeartSaVioR opened a pull request:

[GitHub] storm pull request: STORM-1492 With nimbus.seeds set to default, a...

2016-02-04 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/1082 STORM-1492 With nimbus.seeds set to default, a nimbus for localhost may appear "Offline" First of all, AFAIK, it's just an issue of API output, and it doesn't hurt functionality although we

[GitHub] storm pull request: STORM-1492 With nimbus.seeds set to default, a...

2016-02-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1082#issuecomment-180232975 Three builds are failing, which are all intermittent. * storm-core test failure: nimbus-test could be not run completely *

[GitHub] storm pull request: STORM-1492 With nimbus.seeds set to default, a...

2016-02-04 Thread HeartSaVioR
GitHub user HeartSaVioR reopened a pull request: https://github.com/apache/storm/pull/1082 STORM-1492 With nimbus.seeds set to default, a nimbus for localhost may appear "Offline" First of all, AFAIK, it's just an issue of API output, and it doesn't hurt functionality although we

[jira] [Commented] (STORM-1492) With nimbus.seeds set to default, a nimbus for localhost may appear "Offline"

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133780#comment-15133780 ] ASF GitHub Bot commented on STORM-1492: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: STORM-1492 With nimbus.seeds set to default, a...

2016-02-04 Thread HeartSaVioR
Github user HeartSaVioR closed the pull request at: https://github.com/apache/storm/pull/1082 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Assigned] (STORM-1526) Improve Storm core performance

2016-02-04 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim reassigned STORM-1526: --- Assignee: Roshan Naik (was: Jungtaek Lim) > Improve Storm core performance >

[jira] [Assigned] (STORM-1455) kafka spout should not reset to the beginning of partition when offsetoutofrange exception occurs

2016-02-04 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim reassigned STORM-1455: --- Assignee: Abhishek Agarwal (was: Jungtaek Lim) > kafka spout should not reset to the

[jira] [Resolved] (STORM-1513) Update trident api docs

2016-02-04 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim resolved STORM-1513. - Resolution: Fixed Fix Version/s: 1.0.0 Thanks [~arunmahadevan], I merged into asf-site

[GitHub] storm pull request: Storm 1526

2016-02-04 Thread roshannaik
GitHub user roshannaik opened a pull request: https://github.com/apache/storm/pull/1080 Storm 1526 Benchmarking with this simple Speed of Light topology shows that this fix improved throughput by over 60%

[GitHub] storm pull request: Storm 1526 - Improve Storm core performance

2016-02-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1080#issuecomment-180162834 +1 Fixed line passes *reflection-on-warning* --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Updated] (STORM-1526) Improve Storm core performance

2016-02-04 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim updated STORM-1526: Linked this issue to EPIC (Release Storm 1.0.0), since it affects the performance which we should take

[GitHub] storm pull request: [STORM-1513] Added documentation for filter, m...

2016-02-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1070 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (STORM-1513) Update trident api docs

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133441#comment-15133441 ] ASF GitHub Bot commented on STORM-1513: --- Github user asfgit closed the pull request at:

[GitHub] storm pull request: Storm 1526 - Improve Storm core performance

2016-02-04 Thread satishd
Github user satishd commented on the pull request: https://github.com/apache/storm/pull/1080#issuecomment-180170555 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Assigned] (STORM-1493) Update Documentation for {{nimbus.seeds}}

2016-02-04 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim reassigned STORM-1493: --- Assignee: Jungtaek Lim > Update Documentation for {{nimbus.seeds}} >

[jira] [Commented] (STORM-1493) Update Documentation for {{nimbus.seeds}}

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133379#comment-15133379 ] ASF GitHub Bot commented on STORM-1493: --- GitHub user HeartSaVioR opened a pull request:

[GitHub] storm pull request: STORM-1493 Update Documentation for {{nimbus.s...

2016-02-04 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/1079 STORM-1493 Update Documentation for {{nimbus.seeds}} Please note that I'm not fluent so you may want to correct syntax, nuance, and so on. You can merge this pull request into a Git repository

[GitHub] storm pull request: Storm 1526 - Improve Storm core performance

2016-02-04 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/1080#issuecomment-180169524 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (STORM-1526) Improve Storm core performance

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133577#comment-15133577 ] ASF GitHub Bot commented on STORM-1526: --- Github user dossett commented on the pull request:

[GitHub] storm pull request: Storm 1526 - Improve Storm core performance

2016-02-04 Thread dossett
Github user dossett commented on the pull request: https://github.com/apache/storm/pull/1080#issuecomment-180173001 @roshannaik Can you update the title of this PR to begin with "STORM-1526" so that it gets associated with the JIRA? Thanks! --- If your project is set up for it, you

[jira] [Commented] (STORM-1511) min/max operations on trident stream

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132285#comment-15132285 ] ASF GitHub Bot commented on STORM-1511: --- Github user arunmahadevan commented on the pull request:

[GitHub] storm pull request: STORM-1511 min/max operations support on a tri...

2016-02-04 Thread arunmahadevan
Github user arunmahadevan commented on the pull request: https://github.com/apache/storm/pull/1061#issuecomment-179827493 Haven't gone through the implementation details yet, but from the api `public Stream max(String inputFieldName, String outputFieldName, Comparator

[jira] [Commented] (STORM-1492) With nimbus.seeds set to default, a nimbus for localhost may appear "Offline"

2016-02-04 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132313#comment-15132313 ] Jungtaek Lim commented on STORM-1492: - While I'm curious it's worth to make an effort, we could filter

[GitHub] storm pull request: STORM-1520 [for master branch] Nimbus Clojure/...

2016-02-04 Thread erikdw
Github user erikdw commented on a diff in the pull request: https://github.com/apache/storm/pull/1077#discussion_r51973554 --- Diff: storm-core/src/clj/org/apache/storm/cluster_state/zookeeper_state_factory.clj --- @@ -144,7 +145,7 @@ (let [curator-listener (reify

[GitHub] storm pull request: [STORM-1524] Add Pluggable daemon statistics -...

2016-02-04 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/storm/pull/1075#discussion_r51974741 --- Diff: storm-core/src/jvm/org/apache/storm/Config.java --- @@ -140,6 +140,45 @@ public static final String STORM_META_SERIALIZATION_DELEGATE =

[jira] [Commented] (STORM-1493) Update Documentation for {{nimbus.seeds}}

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133648#comment-15133648 ] ASF GitHub Bot commented on STORM-1493: --- Github user redsanket commented on a diff in the pull

[GitHub] storm pull request: STORM-1493 Update Documentation for {{nimbus.s...

2016-02-04 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1079#discussion_r51977242 --- Diff: documentation/Setting-up-development-environment.md --- @@ -29,13 +29,5 @@ Installing a Storm release locally is only for interacting with

[jira] [Commented] (STORM-1493) Update Documentation for {{nimbus.seeds}}

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133652#comment-15133652 ] ASF GitHub Bot commented on STORM-1493: --- Github user HeartSaVioR commented on a diff in the pull

[GitHub] storm pull request: STORM-1493 Update Documentation for {{nimbus.s...

2016-02-04 Thread redsanket
Github user redsanket commented on the pull request: https://github.com/apache/storm/pull/1079#issuecomment-180200298 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (STORM-1455) kafka spout should not reset to the beginning of partition when offsetoutofrange exception occurs

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133693#comment-15133693 ] ASF GitHub Bot commented on STORM-1455: --- Github user HeartSaVioR commented on the pull request:

[jira] [Commented] (STORM-1517) Add peek api in trident stream

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133692#comment-15133692 ] ASF GitHub Bot commented on STORM-1517: --- Github user arunmahadevan commented on the pull request:

[GitHub] storm pull request: [STORM-1517] add peek api in trident stream

2016-02-04 Thread arunmahadevan
Github user arunmahadevan commented on the pull request: https://github.com/apache/storm/pull/1065#issuecomment-180204642 done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: STORM-1455: Do not reset the emittedOffset for...

2016-02-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1026#issuecomment-180207678 Merged to master, backporting to 1.x-branch... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (STORM-1455) kafka spout should not reset to the beginning of partition when offsetoutofrange exception occurs

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133702#comment-15133702 ] ASF GitHub Bot commented on STORM-1455: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: STORM-1455: Do not reset the emittedOffset for...

2016-02-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1026 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (STORM-1523) Translate Available Ports task in util.java

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133737#comment-15133737 ] ASF GitHub Bot commented on STORM-1523: --- Github user abhishekagarwal87 commented on a diff in the

[GitHub] storm pull request: [STORM-1523] util.clj available-port conversio...

2016-02-04 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1073#discussion_r51981408 --- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java --- @@ -1374,5 +1393,21 @@ public static RuntimeException wrapInRuntime(Exception

[GitHub] storm pull request: [STORM-1517] add peek api in trident stream

2016-02-04 Thread redsanket
Github user redsanket commented on the pull request: https://github.com/apache/storm/pull/1065#issuecomment-180188256 upmerge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: STORM-1493 Update Documentation for {{nimbus.s...

2016-02-04 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/storm/pull/1079#discussion_r51976825 --- Diff: documentation/Setting-up-development-environment.md --- @@ -29,13 +29,5 @@ Installing a Storm release locally is only for interacting with remote

[GitHub] storm pull request: STORM-1520 [for master branch] Nimbus Clojure/...

2016-02-04 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1077#discussion_r51978814 --- Diff: storm-core/src/clj/org/apache/storm/cluster_state/zookeeper_state_factory.clj --- @@ -144,7 +145,7 @@ (let [curator-listener

[jira] [Commented] (STORM-1520) Nimbus Clojure/Zookeeper issue ("stateChanged" method not found)

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133686#comment-15133686 ] ASF GitHub Bot commented on STORM-1520: --- Github user HeartSaVioR commented on a diff in the pull

[GitHub] storm pull request: STORM-1520 [for master branch] Nimbus Clojure/...

2016-02-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1077#issuecomment-180175739 Seems like I didn't explain why this occurs and how to fix. Explained inline. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (STORM-1520) Nimbus Clojure/Zookeeper issue ("stateChanged" method not found)

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133591#comment-15133591 ] ASF GitHub Bot commented on STORM-1520: --- Github user HeartSaVioR commented on a diff in the pull

[jira] [Commented] (STORM-1520) Nimbus Clojure/Zookeeper issue ("stateChanged" method not found)

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133592#comment-15133592 ] ASF GitHub Bot commented on STORM-1520: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: STORM-1520 [for master branch] Nimbus Clojure/...

2016-02-04 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1077#discussion_r51973468 --- Diff: storm-core/src/clj/org/apache/storm/cluster_state/zookeeper_state_factory.clj --- @@ -144,7 +145,7 @@ (let [curator-listener

[jira] [Commented] (STORM-1522) REST API throws invalid worker log links.

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133641#comment-15133641 ] ASF GitHub Bot commented on STORM-1522: --- Github user satishd commented on the pull request:

[jira] [Commented] (STORM-1242) migrate backtype.storm.command.config-value to java

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133642#comment-15133642 ] ASF GitHub Bot commented on STORM-1242: --- Github user redsanket commented on a diff in the pull

[GitHub] storm pull request: STORM-1522 should create error worker log loca...

2016-02-04 Thread satishd
Github user satishd commented on the pull request: https://github.com/apache/storm/pull/1076#issuecomment-180188920 when REST API (http://localhost:8080/api/v1/topology/{topology-name}) is used for getting topology details. It throws up spouts/bolts details like below which has wrong

[jira] [Commented] (STORM-1455) kafka spout should not reset to the beginning of partition when offsetoutofrange exception occurs

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133728#comment-15133728 ] ASF GitHub Bot commented on STORM-1455: --- Github user abhishekagarwal87 commented on the pull

[GitHub] storm pull request: STORM-1455: Do not reset the emittedOffset for...

2016-02-04 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1026#issuecomment-180214818 Thanks @HeartSaVioR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (STORM-1524) Make Storm daemon function statistics reporter pluggable

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133619#comment-15133619 ] ASF GitHub Bot commented on STORM-1524: --- Github user redsanket commented on a diff in the pull

[jira] [Commented] (STORM-1517) Add peek api in trident stream

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133636#comment-15133636 ] ASF GitHub Bot commented on STORM-1517: --- Github user redsanket commented on the pull request:

[jira] [Commented] (STORM-1493) Update Documentation for {{nimbus.seeds}}

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133665#comment-15133665 ] ASF GitHub Bot commented on STORM-1493: --- Github user redsanket commented on the pull request:

[jira] [Resolved] (STORM-1455) kafka spout should not reset to the beginning of partition when offsetoutofrange exception occurs

2016-02-04 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim resolved STORM-1455. - Resolution: Fixed Fix Version/s: 1.0.0 Thanks [~abhishek.agarwal] for the great work, I

[jira] [Commented] (STORM-1492) With nimbus.seeds set to default, a nimbus for localhost may appear "Offline"

2016-02-04 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133726#comment-15133726 ] Jungtaek Lim commented on STORM-1492: - Thinking it once more, I realized I was wrong. Only users who

[jira] [Commented] (STORM-1520) Nimbus Clojure/Zookeeper issue ("stateChanged" method not found)

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133594#comment-15133594 ] ASF GitHub Bot commented on STORM-1520: --- Github user erikdw commented on a diff in the pull request:

[jira] [Commented] (STORM-1524) Make Storm daemon function statistics reporter pluggable

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133621#comment-15133621 ] ASF GitHub Bot commented on STORM-1524: --- Github user kishorvpatil commented on a diff in the pull

[GitHub] storm pull request: [STORM-1524] Add Pluggable daemon statistics -...

2016-02-04 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/1075#discussion_r51975200 --- Diff: storm-core/src/jvm/org/apache/storm/Config.java --- @@ -140,6 +140,45 @@ public static final String STORM_META_SERIALIZATION_DELEGATE

[jira] [Commented] (STORM-1242) migrate backtype.storm.command.config-value to java

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133644#comment-15133644 ] ASF GitHub Bot commented on STORM-1242: --- Github user redsanket commented on the pull request:

[GitHub] storm pull request: STORM-1242: migrate backtype.storm.command.con...

2016-02-04 Thread redsanket
Github user redsanket commented on the pull request: https://github.com/apache/storm/pull/1059#issuecomment-180189026 LGTM, minor clarification --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm pull request: STORM-1455: Do not reset the emittedOffset for...

2016-02-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1026#issuecomment-180204666 @abhishekagarwal87 Sorry to review in late. Looks good to me, +1. --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (STORM-1455) kafka spout should not reset to the beginning of partition when offsetoutofrange exception occurs

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133703#comment-15133703 ] ASF GitHub Bot commented on STORM-1455: --- Github user asfgit closed the pull request at:

[GitHub] storm pull request: [STORM-1523] util.clj available-port conversio...

2016-02-04 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1073#discussion_r51981374 --- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java --- @@ -1374,5 +1393,21 @@ public static RuntimeException wrapInRuntime(Exception

[GitHub] storm pull request: [STORM-1523] util.clj available-port conversio...

2016-02-04 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/storm/pull/1073#discussion_r51890142 --- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java --- @@ -1374,5 +1393,29 @@ public static RuntimeException wrapInRuntime(Exception e){

[jira] [Commented] (STORM-1520) Nimbus Clojure/Zookeeper issue ("stateChanged" method not found)

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132018#comment-15132018 ] ASF GitHub Bot commented on STORM-1520: --- GitHub user HeartSaVioR opened a pull request:

[GitHub] storm pull request: STORM-1520 [for master branch] Nimbus Clojure/...

2016-02-04 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/1077 STORM-1520 [for master branch] Nimbus Clojure/Zookeeper issue ("stateChanged" method not found) Please take a look at the mapping between Curator ConnectionState and Storm ConnectionState.

[jira] [Commented] (STORM-1520) Nimbus Clojure/Zookeeper issue ("stateChanged" method not found)

2016-02-04 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132027#comment-15132027 ] Jungtaek Lim commented on STORM-1520: - Since this bug also affects master branch (2.x), I submitted a

[jira] [Commented] (STORM-1520) Nimbus Clojure/Zookeeper issue ("stateChanged" method not found)

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132553#comment-15132553 ] ASF GitHub Bot commented on STORM-1520: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: [STORM-1524] Add Pluggable daemon statistics -...

2016-02-04 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1075#discussion_r51901735 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/metrics/StatisticsUtils.java --- @@ -0,0 +1,58 @@ +/** + * Licensed to the Apache Software

[jira] [Commented] (STORM-1524) Make Storm daemon function statistics reporter pluggable

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132566#comment-15132566 ] ASF GitHub Bot commented on STORM-1524: --- Github user d2r commented on a diff in the pull request:

[jira] [Commented] (STORM-1524) Make Storm daemon function statistics reporter pluggable

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132570#comment-15132570 ] ASF GitHub Bot commented on STORM-1524: --- Github user d2r commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-1524] Add Pluggable daemon statistics -...

2016-02-04 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1075#discussion_r51901697 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/metrics/StatisticsUtils.java --- @@ -0,0 +1,58 @@ +/** + * Licensed to the Apache Software

[jira] [Commented] (STORM-1524) Make Storm daemon function statistics reporter pluggable

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132565#comment-15132565 ] ASF GitHub Bot commented on STORM-1524: --- Github user d2r commented on a diff in the pull request:

[jira] [Commented] (STORM-1524) Make Storm daemon function statistics reporter pluggable

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132569#comment-15132569 ] ASF GitHub Bot commented on STORM-1524: --- Github user d2r commented on a diff in the pull request:

[jira] [Commented] (STORM-1524) Make Storm daemon function statistics reporter pluggable

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132575#comment-15132575 ] ASF GitHub Bot commented on STORM-1524: --- Github user d2r commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-1524] Add Pluggable daemon statistics -...

2016-02-04 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1075#discussion_r51902700 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/metrics/StatisticsUtils.java --- @@ -0,0 +1,58 @@ +/** + * Licensed to the Apache Software

[jira] [Commented] (STORM-1524) Make Storm daemon function statistics reporter pluggable

2016-02-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132587#comment-15132587 ] ASF GitHub Bot commented on STORM-1524: --- Github user revans2 commented on a diff in the pull

[GitHub] storm pull request: [STORM-1524] Add Pluggable daemon statistics -...

2016-02-04 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1075#discussion_r51902787 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/metrics/reporters/ConsolePreparableReporter.java --- @@ -0,0 +1,82 @@ +/** + * Licensed to the

[jira] [Created] (STORM-1525) Topology visualization causes integer overlfow error

2016-02-04 Thread Paul Poulosky (JIRA)
Paul Poulosky created STORM-1525: Summary: Topology visualization causes integer overlfow error Key: STORM-1525 URL: https://issues.apache.org/jira/browse/STORM-1525 Project: Apache Storm

  1   2   >