Re: [ANNOUNCE] New Storm Commiter/PMC Member: Xin Wang

[Xin Wang]

Thanks everyone! It is really awesome to be working with you on Storm!

- Xin Wang

2016-12-02 0:42 GMT+08:00 Hugo Da Cruz Louro :

> Congratulations Xing! Keep up the good work.
> Best,
> Hugo
>
> > On Dec 1, 2016, at 6:17 AM, Bobby Evans 
> wrote:
> >
> > Congratulations.
> > - Bobby
> >
> > On Thursday, December 1, 2016, 4:23:16 AM CST, Satish Duggana <
> sdugg...@hortonworks.com> wrote:Congratulations Xin!!
> >
> > ~Satish.
> >
> > On 12/1/16, 10:54 AM, "Matthias J. Sax"  wrote:
> >
> > -BEGIN PGP SIGNED MESSAGE-
> > Hash: SHA512
> >
> > Congrats!
> >
> > On 11/30/16 8:43 PM, Jungtaek Lim wrote:
> > > Please join me in welcoming Xin Wang as a new Apache Storm
> > > Committer and PMC member.
> > >
> > > Xin Wang has showed strong commitment to the Apache Storm community
> > > via code contributions for a long time spanning both core and as
> > > well as integration components. He also has showed active
> > > participation on mailing lists.
> > >
> > > Congratulations and welcome Xin!
> > >
> > > - Jungtaek Lim (HeartSaVioR)
> > >
> > -BEGIN PGP SIGNATURE-
> > Comment: GPGTools - https://gpgtools.org
> >
> > iQIYBAEBCgAGBQJYP7P1AAoJELz8Z8hxAGOi3egP3RcjYhi9Bof+Y/T30Sy2+TCH
> > ccBRcYxZcm2zRGZoLgAFO4HolBEaH0NyEhcj26lLzwl59zLrBWlpfxhSf0ruPW/X
> > Dg5Lm6dtY9LkweUePSgxh7SxnSL0wxh+5ID0Yyv4YuB0p9IE4D9+YM0ziKj+moFd
> > nlUICUd+eXzbro8oaa28Gi8D28v97N0vBQaZq9ATyzFkbpm9VTl3rEGw91q/b04n
> > kQfELba51TWG4gQGlsALAIBSuHhhJ9wVbFCGnJVLF4t47jS7gDYOZi7TqXOpPDU3
> > FS4VhYQUBNPpHgWseeetCSvYe8dGht2+lLYzlj37UDjfS22nGRHRMV3Jh+nQKRW2
> > CuDFxlZzH3sxHtvR4d7i5axP2cbFm1sqsn/UcmJsTq17jJBM+vZvv4MmxObS76yn
> > ZHo2i7mvuvkGfmgoByzuDaJb/eo30yCJ0+TC4nYaZaI+cLr3hHRRyI2WejtXCI3r
> > 8vrfHt3dXbbwLwFMRkckvdELqxnsxVI5oFbswPl+0H0SChI33rtL/L/lwvzqp3df
> > HHb75AJDHjFwHTvAakhuXACuQ/+y3ZezrKfhmjf4mWlYor5mNwMtMEMeH11LUDaV
> > 2CRrPVZ13GPJ3dyhgA/nCYFvsm9K5EINOpMW08saZg/yryK6ExoQDpJa8y8F6E4E
> > CoiIwY2RoW1P/T4=
> > =nTHE
> > -END PGP SIGNATURE-
> >
> >
> >
>
>

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

[arunmahadevan]

Github user arunmahadevan commented on the issue:

https://github.com/apache/storm/pull/1470
  
@kosii can you cherry pick the commits from 1606 plus your commits and 
raise a pr for 1.x branch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1584: STORM-1992 Added artifacts to make storm.js into an npm p...

[ptgoetz]

Github user ptgoetz commented on the issue:

https://github.com/apache/storm/pull/1584
  
My apologies for letting this go without review for so long.

+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1800: STORM-2217: Make DRPC pure java

[revans2]

Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/1800
  
@ptgoetz if this looks good as is I will look into shading Jersey.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1764: STORM-2190: reduce contention between submission and sche...

[revans2]

Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/1764
  
Just so we don't miss the comment from @jerrypeng 

> Couldn't a wrong ordering of events happen since we are locking when 
calculating a scheduling then unlocking and then locking and uploading the new 
scheduling and unlocking
> for example:
> T0: submit
> T1: rebalance
> T2: rebalance - calculate new scheduling
> T3: submit - calculate new scheduling
> T4: rebalance - upload new scheduling to zk
> T5: submit - upload new scheduling to zk
> 
> even though we should end up with the scheduling calculated by the 
rebalance but we end up with scheduling calculated from the original submit.

Yes, that is correct.  We should do something here, and he suggested that 
perhaps as part of a refactor of Nimbus we should look at support for long 
running scheduling.

In the short term I think I might make scheduling and writing to ZK atomic, 
but long term I think I will file a JIRA to look at better scheduling.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1764: STORM-2190: reduce contention between submission a...

[revans2]

Github user revans2 commented on a diff in the pull request:

https://github.com/apache/storm/pull/1764#discussion_r90542812
  
--- Diff: storm-core/src/clj/org/apache/storm/daemon/nimbus.clj ---
@@ -1008,23 +1008,24 @@
   (reset! (:id->worker-resources nimbus) {}))
 ;; tasks figure out what tasks to talk to by looking at topology at 
runtime
 ;; only log/set when there's been a change to the assignment
-(doseq [[topology-id assignment] new-assignments
-:let [existing-assignment (get existing-assignments 
topology-id)
-  topology-details (.getById topologies topology-id)]]
-  (if (= existing-assignment assignment)
-(log-debug "Assignment for " topology-id " hasn't changed")
-(do
-  (log-message "Setting new assignment for topology id " 
topology-id ": " (pr-str assignment))
-  (.setAssignment storm-cluster-state topology-id 
(thriftify-assignment assignment))
-  )))
-(->> new-assignments
-  (map (fn [[topology-id assignment]]
-(let [existing-assignment (get existing-assignments 
topology-id)]
-  [topology-id (map to-worker-slot (newly-added-slots 
existing-assignment assignment))]
-  )))
-  (into {})
-  (.assignSlots inimbus topologies)))
-(log-message "not a leader, skipping assignments")))
+(locking (:sched-lock nimbus)
--- End diff --

I agree and now that nimbus is in java we can look at doing some 
refactoring along those lines.  If you feel that we need to do it now and that 
this is a blocker I can spend some time looking into how to do that better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1764: STORM-2190: reduce contention between submission a...

[jerrypeng]

Github user jerrypeng commented on a diff in the pull request:

https://github.com/apache/storm/pull/1764#discussion_r90540863
  
--- Diff: storm-core/src/clj/org/apache/storm/daemon/nimbus.clj ---
@@ -1008,23 +1008,24 @@
   (reset! (:id->worker-resources nimbus) {}))
 ;; tasks figure out what tasks to talk to by looking at topology at 
runtime
 ;; only log/set when there's been a change to the assignment
-(doseq [[topology-id assignment] new-assignments
-:let [existing-assignment (get existing-assignments 
topology-id)
-  topology-details (.getById topologies topology-id)]]
-  (if (= existing-assignment assignment)
-(log-debug "Assignment for " topology-id " hasn't changed")
-(do
-  (log-message "Setting new assignment for topology id " 
topology-id ": " (pr-str assignment))
-  (.setAssignment storm-cluster-state topology-id 
(thriftify-assignment assignment))
-  )))
-(->> new-assignments
-  (map (fn [[topology-id assignment]]
-(let [existing-assignment (get existing-assignments 
topology-id)]
-  [topology-id (map to-worker-slot (newly-added-slots 
existing-assignment assignment))]
-  )))
-  (into {})
-  (.assignSlots inimbus topologies)))
-(log-message "not a leader, skipping assignments")))
+(locking (:sched-lock nimbus)
--- End diff --

maybe its also time to start thinking about decentralized scheduling 
mechanism if certain scheduling strategies may take a while to compute a 
schedule, but that would require a major overhaul in nimbus.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1768: STORM-2194: Report error and die, not report error or die

[chawco]

Github user chawco commented on the issue:

https://github.com/apache/storm/pull/1768
  
I've left some follow up comments in 
[1767](https://github.com/apache/storm/pull/1767).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1767: STORM-2194: Report error and die, not report error or die

[chawco]

Github user chawco commented on the issue:

https://github.com/apache/storm/pull/1767
  
So, there's some ambiguity in place here that would need to get resolved. 
Basically, there's two sources for InterruptedException/InterruptedIOException 
-- one from Storm itself, and one from the user's code (See: 
[STORM-2194](https://issues.apache.org/jira/browse/STORM-2194) If we want to 
have different behaviour from these two sources we do need some solution to 
disambiguate the uses.

Basically, the problem is this: If anything in the user's thread raises 
these exceptions, the executor thread will terminate *but the worker will not*. 
This leaves the entire topology in a zombified state. I find it difficult to 
see that this behaviour is "as intended". 

@revans2 can you suggest a way we can disambiguate between Storm initiated 
and user initiated exceptions here? I'm having a real tough time thinking how 
we could accomplish that. Alternatively, can you propose an alternate 
implementation for signalling this shutdown? I'm happy to take on that work to 
make things shutdown in a more appropriate manner, as long as we get to fix 
this zombie topology behaviour.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1764: STORM-2190: reduce contention between submission a...

[revans2]

Github user revans2 commented on a diff in the pull request:

https://github.com/apache/storm/pull/1764#discussion_r90538639
  
--- Diff: storm-core/src/clj/org/apache/storm/daemon/nimbus.clj ---
@@ -1008,23 +1008,24 @@
   (reset! (:id->worker-resources nimbus) {}))
 ;; tasks figure out what tasks to talk to by looking at topology at 
runtime
 ;; only log/set when there's been a change to the assignment
-(doseq [[topology-id assignment] new-assignments
-:let [existing-assignment (get existing-assignments 
topology-id)
-  topology-details (.getById topologies topology-id)]]
-  (if (= existing-assignment assignment)
-(log-debug "Assignment for " topology-id " hasn't changed")
-(do
-  (log-message "Setting new assignment for topology id " 
topology-id ": " (pr-str assignment))
-  (.setAssignment storm-cluster-state topology-id 
(thriftify-assignment assignment))
-  )))
-(->> new-assignments
-  (map (fn [[topology-id assignment]]
-(let [existing-assignment (get existing-assignments 
topology-id)]
-  [topology-id (map to-worker-slot (newly-added-slots 
existing-assignment assignment))]
-  )))
-  (into {})
-  (.assignSlots inimbus topologies)))
-(log-message "not a leader, skipping assignments")))
+(locking (:sched-lock nimbus)
--- End diff --

@jerrypeng You are correct that this could happen.  I don't really think it 
will be that likely to happen in practice but I'll think about it and see if we 
can fix it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1800: STORM-2217: Make DRPC pure java

[revans2]

Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/1800
  
Rebased again


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1765: STORM-2190: reduce contention between submission a...

[ptgoetz]

Github user ptgoetz commented on a diff in the pull request:

https://github.com/apache/storm/pull/1765#discussion_r90534501
  
--- Diff: 
examples/storm-starter/src/jvm/org/apache/storm/starter/WordCountTopology.java 
---
@@ -90,7 +90,9 @@ public static void main(String[] args) throws Exception {
 if (args != null && args.length > 0) {
   conf.setNumWorkers(3);
 
-  StormSubmitter.submitTopologyWithProgressBar(args[0], conf, 
builder.createTopology());
+  for (String name: args) {
--- End diff --

I'd say remove it. My reasoning is that it's an example, and new users 
might get confused.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1795: STORM-2215: validate blobs are present before submitting

[revans2]

Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/1795
  
#1744 is in and this is rebased


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1786: STORM-1281: LocalCluster, testing4j and testing.clj to ja...

[ptgoetz]

Github user ptgoetz commented on the issue:

https://github.com/apache/storm/pull/1786
  
@revans2 Thanks. Still +1.

(One procedural nit: Rebasing/squashing on big PRs like this can make 
reviews a little harder. E.g. After you added the javadocs I wanted to review 
just that change, but the squash forced me to wade through all the other 
changes to find the ones I was looking for. Not a big deal, but something to 
keep in mind.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1767: STORM-2194: Report error and die, not report error or die

[sathyafmt]

Github user sathyafmt commented on the issue:

https://github.com/apache/storm/pull/1767
  
@revans2 - His change in storm-1.0.2 is in the report-error-and-die 
function, so it should shutdown, correct ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1810: STORM-2204 Adding Bolt side caching for HBase Lookup Bolt...

[ambud]

Github user ambud commented on the issue:

https://github.com/apache/storm/pull/1810
  
https://github.com/apache/storm/pull/1783 original PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1783: STORM-2204 Adding caching capabilities in HBaseLookupBolt

[ambud]

Github user ambud commented on the issue:

https://github.com/apache/storm/pull/1783
  
1.x branch PR https://github.com/apache/storm/pull/1810


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1810: STORM-2204 Adding Bolt side caching for HBase Look...

[ambud]

GitHub user ambud opened a pull request:

https://github.com/apache/storm/pull/1810

STORM-2204 Adding Bolt side caching for HBase Lookup Bolt for 1.x branch



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ambud/storm 1.x-branch

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/1810.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1810


commit d4f996d9a17289b9c08a500c327e469b69384aeb
Author: ambud 
Date:   2016-12-01T20:22:42Z

Bolt side caching for HBase Lookup Bolt for 1.x branch




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1783: STORM-2204 Adding caching capabilities in HBaseLookupBolt

[ambud]

Github user ambud commented on the issue:

https://github.com/apache/storm/pull/1783
  
Can we merge this? @HeartSaVioR @revans2 @vesense 

I will need to open another pull request for 1.x branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1786: STORM-1281: LocalCluster, testing4j and testing.clj to ja...

[revans2]

Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/1786
  
Rebased now that java nimbus is in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/1744


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

topology.debug always true

[Ohad Edelstein]

We see that the topology.debug set to two different values:
[cid:57BDBB53-DB37-4DF8-8B26-D9BD1874CB9D]

And:
[cid:C121FA48-8020-4B00-A6B2-0652B1EF82BE]
We set the topology.debug to false ( we know its set that way to default but we 
thought that, this was the problem ).
Is there a different meaning to the param in this two screens?

[GitHub] storm pull request #1785: [STORM-2201] Add dynamic scheduler configuration l...

[jerrypeng]

Github user jerrypeng commented on a diff in the pull request:

https://github.com/apache/storm/pull/1785#discussion_r90526318
  
--- Diff: storm-core/src/jvm/org/apache/storm/Config.java ---
@@ -2177,13 +2177,37 @@
 @isMapEntryType(keyType = String.class, valueType = Number.class)
 public static final String MULTITENANT_SCHEDULER_USER_POOLS = 
"multitenant.scheduler.user.pools";
 
+ /**
+ * A plugin that should load the user pools for the multitenant 
scheduler
+ */
+@isString
+public static final String MULTITENANT_SCHEDULER_USER_POOLS_LOADER = 
"multitenant.scheduler.user.pools.loader";
+
+/**
+ * Configuration elements for scheduler config loader
+ */
+@isMapEntryType(keyType = String.class, valueType = String.class)
+public static final String 
MULTITENANT_SCHEDULER_USER_POOLS_LOADER_PARAMS = 
"multitenant.scheduler.user.pools.loader.params";
+
 /**
  * A map of users to another map of the resource guarantees of the 
user. Used by Resource Aware Scheduler to ensure
  * per user resource guarantees.
  */
 @isMapEntryCustom(keyValidatorClasses = {StringValidator.class}, 
valueValidatorClasses = {UserResourcePoolEntryValidator.class})
 public static final String RESOURCE_AWARE_SCHEDULER_USER_POOLS = 
"resource.aware.scheduler.user.pools";
 
+ /**
+ * A plugin that should load the user pools for the resource aware 
scheduler
+ */
+@isString
+public static final String RESOURCE_AWARE_SCHEDULER_USER_POOLS_LOADER 
= "resource.aware.scheduler.user.pools.loader";
--- End diff --

Yup that is what @isImplementationOfClass is for.  We should use it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1744: STORM-1276: line for line translation of nimbus to java

[revans2]

Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/1744
  
I am merging I am still happy to make changes on follow on JIRA. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1744: STORM-1276: line for line translation of nimbus to java

[srdo]

Github user srdo commented on the issue:

https://github.com/apache/storm/pull/1744
  
I only really have nitpicks, so I'm good with merging too. Really nice job.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1795: STORM-2215: validate blobs are present before submitting

[revans2]

Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/1795
  
@HeartSaVioR I rebased and addressed the review comments, but I want to 
merge in #1744 first and then I will update this one again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

[srdo]

Github user srdo commented on a diff in the pull request:

https://github.com/apache/storm/pull/1744#discussion_r90522761
  
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3729 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ * 
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.daemon.nimbus;
+
+import static org.apache.storm.metric.StormMetricsRegistry.registerMeter;
+import static org.apache.storm.utils.Utils.OR;
+
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.InterruptedIOException;
+import java.io.OutputStream;
+import java.net.BindException;
+import java.net.ServerSocket;
+import java.nio.ByteBuffer;
+import java.nio.channels.Channels;
+import java.nio.channels.WritableByteChannel;
+import java.security.Principal;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.Map.Entry;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.UnaryOperator;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import javax.security.auth.Subject;
+
+import org.apache.storm.Config;
+import org.apache.storm.StormTimer;
+import org.apache.storm.blobstore.AtomicOutputStream;
+import org.apache.storm.blobstore.BlobStore;
+import org.apache.storm.blobstore.BlobStoreAclHandler;
+import org.apache.storm.blobstore.BlobSynchronizer;
+import org.apache.storm.blobstore.InputStreamWithMeta;
+import org.apache.storm.blobstore.KeySequenceNumber;
+import org.apache.storm.blobstore.LocalFsBlobStore;
+import org.apache.storm.cluster.ClusterStateContext;
+import org.apache.storm.cluster.ClusterUtils;
+import org.apache.storm.cluster.DaemonType;
+import org.apache.storm.cluster.IStormClusterState;
+import org.apache.storm.daemon.DaemonCommon;
+import org.apache.storm.daemon.Shutdownable;
+import org.apache.storm.daemon.StormCommon;
+import org.apache.storm.generated.AlreadyAliveException;
+import org.apache.storm.generated.Assignment;
+import org.apache.storm.generated.AuthorizationException;
+import org.apache.storm.generated.BeginDownloadResult;
+import org.apache.storm.generated.ClusterSummary;
+import org.apache.storm.generated.CommonAggregateStats;
+import org.apache.storm.generated.ComponentAggregateStats;
+import org.apache.storm.generated.ComponentPageInfo;
+import org.apache.storm.generated.ComponentType;
+import org.apache.storm.generated.Credentials;
+import org.apache.storm.generated.DebugOptions;
+import org.apache.storm.generated.ErrorInfo;
+import org.apache.storm.generated.ExecutorInfo;
+import org.apache.storm.generated.ExecutorStats;
+import org.apache.storm.generated.ExecutorSummary;
+import org.apache.storm.generated.GetInfoOptions;
+import org.apache.storm.generated.InvalidTopologyException;
+import org.apache.storm.generated.KeyAlreadyExistsException;
+import org.apache.storm.generated.KeyNotFoundException;
+import org.apache.storm.generated.KillOptions;
+import org.apache.storm.generated.LSTopoHistory;
+import org.apache.storm.generated.ListBlobsResult;
+import org.apache.storm.generated.LogConfig;
+import org.apache.storm.generated.LogLevel;
+import org.apache.storm.generated.LogLevelAction;
+import org.apache.storm.generated.Nimbus.Iface;
+import org.apache.storm.generated.Nimbus.Processor;
+import org.apache.storm.generated.NimbusSummary;
+import org.apache.storm.generated.NodeInfo;
+import org.apache.storm.generated.NotAliveException;
+import org.apache.storm.generated.NumErrorsChoice;
+import org.apache.storm.generated.Prof

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

[srdo]

Github user srdo commented on a diff in the pull request:

https://github.com/apache/storm/pull/1744#discussion_r90521664
  
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3729 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ * 
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.daemon.nimbus;
+
+import static org.apache.storm.metric.StormMetricsRegistry.registerMeter;
+import static org.apache.storm.utils.Utils.OR;
+
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.InterruptedIOException;
+import java.io.OutputStream;
+import java.net.BindException;
+import java.net.ServerSocket;
+import java.nio.ByteBuffer;
+import java.nio.channels.Channels;
+import java.nio.channels.WritableByteChannel;
+import java.security.Principal;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.Map.Entry;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.UnaryOperator;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import javax.security.auth.Subject;
+
+import org.apache.storm.Config;
+import org.apache.storm.StormTimer;
+import org.apache.storm.blobstore.AtomicOutputStream;
+import org.apache.storm.blobstore.BlobStore;
+import org.apache.storm.blobstore.BlobStoreAclHandler;
+import org.apache.storm.blobstore.BlobSynchronizer;
+import org.apache.storm.blobstore.InputStreamWithMeta;
+import org.apache.storm.blobstore.KeySequenceNumber;
+import org.apache.storm.blobstore.LocalFsBlobStore;
+import org.apache.storm.cluster.ClusterStateContext;
+import org.apache.storm.cluster.ClusterUtils;
+import org.apache.storm.cluster.DaemonType;
+import org.apache.storm.cluster.IStormClusterState;
+import org.apache.storm.daemon.DaemonCommon;
+import org.apache.storm.daemon.Shutdownable;
+import org.apache.storm.daemon.StormCommon;
+import org.apache.storm.generated.AlreadyAliveException;
+import org.apache.storm.generated.Assignment;
+import org.apache.storm.generated.AuthorizationException;
+import org.apache.storm.generated.BeginDownloadResult;
+import org.apache.storm.generated.ClusterSummary;
+import org.apache.storm.generated.CommonAggregateStats;
+import org.apache.storm.generated.ComponentAggregateStats;
+import org.apache.storm.generated.ComponentPageInfo;
+import org.apache.storm.generated.ComponentType;
+import org.apache.storm.generated.Credentials;
+import org.apache.storm.generated.DebugOptions;
+import org.apache.storm.generated.ErrorInfo;
+import org.apache.storm.generated.ExecutorInfo;
+import org.apache.storm.generated.ExecutorStats;
+import org.apache.storm.generated.ExecutorSummary;
+import org.apache.storm.generated.GetInfoOptions;
+import org.apache.storm.generated.InvalidTopologyException;
+import org.apache.storm.generated.KeyAlreadyExistsException;
+import org.apache.storm.generated.KeyNotFoundException;
+import org.apache.storm.generated.KillOptions;
+import org.apache.storm.generated.LSTopoHistory;
+import org.apache.storm.generated.ListBlobsResult;
+import org.apache.storm.generated.LogConfig;
+import org.apache.storm.generated.LogLevel;
+import org.apache.storm.generated.LogLevelAction;
+import org.apache.storm.generated.Nimbus.Iface;
+import org.apache.storm.generated.Nimbus.Processor;
+import org.apache.storm.generated.NimbusSummary;
+import org.apache.storm.generated.NodeInfo;
+import org.apache.storm.generated.NotAliveException;
+import org.apache.storm.generated.NumErrorsChoice;
+import org.apache.storm.generated.Prof

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

[srdo]

Github user srdo commented on a diff in the pull request:

https://github.com/apache/storm/pull/1744#discussion_r90522896
  
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3729 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ * 
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.daemon.nimbus;
+
+import static org.apache.storm.metric.StormMetricsRegistry.registerMeter;
+import static org.apache.storm.utils.Utils.OR;
+
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.InterruptedIOException;
+import java.io.OutputStream;
+import java.net.BindException;
+import java.net.ServerSocket;
+import java.nio.ByteBuffer;
+import java.nio.channels.Channels;
+import java.nio.channels.WritableByteChannel;
+import java.security.Principal;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.Map.Entry;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.UnaryOperator;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import javax.security.auth.Subject;
+
+import org.apache.storm.Config;
+import org.apache.storm.StormTimer;
+import org.apache.storm.blobstore.AtomicOutputStream;
+import org.apache.storm.blobstore.BlobStore;
+import org.apache.storm.blobstore.BlobStoreAclHandler;
+import org.apache.storm.blobstore.BlobSynchronizer;
+import org.apache.storm.blobstore.InputStreamWithMeta;
+import org.apache.storm.blobstore.KeySequenceNumber;
+import org.apache.storm.blobstore.LocalFsBlobStore;
+import org.apache.storm.cluster.ClusterStateContext;
+import org.apache.storm.cluster.ClusterUtils;
+import org.apache.storm.cluster.DaemonType;
+import org.apache.storm.cluster.IStormClusterState;
+import org.apache.storm.daemon.DaemonCommon;
+import org.apache.storm.daemon.Shutdownable;
+import org.apache.storm.daemon.StormCommon;
+import org.apache.storm.generated.AlreadyAliveException;
+import org.apache.storm.generated.Assignment;
+import org.apache.storm.generated.AuthorizationException;
+import org.apache.storm.generated.BeginDownloadResult;
+import org.apache.storm.generated.ClusterSummary;
+import org.apache.storm.generated.CommonAggregateStats;
+import org.apache.storm.generated.ComponentAggregateStats;
+import org.apache.storm.generated.ComponentPageInfo;
+import org.apache.storm.generated.ComponentType;
+import org.apache.storm.generated.Credentials;
+import org.apache.storm.generated.DebugOptions;
+import org.apache.storm.generated.ErrorInfo;
+import org.apache.storm.generated.ExecutorInfo;
+import org.apache.storm.generated.ExecutorStats;
+import org.apache.storm.generated.ExecutorSummary;
+import org.apache.storm.generated.GetInfoOptions;
+import org.apache.storm.generated.InvalidTopologyException;
+import org.apache.storm.generated.KeyAlreadyExistsException;
+import org.apache.storm.generated.KeyNotFoundException;
+import org.apache.storm.generated.KillOptions;
+import org.apache.storm.generated.LSTopoHistory;
+import org.apache.storm.generated.ListBlobsResult;
+import org.apache.storm.generated.LogConfig;
+import org.apache.storm.generated.LogLevel;
+import org.apache.storm.generated.LogLevelAction;
+import org.apache.storm.generated.Nimbus.Iface;
+import org.apache.storm.generated.Nimbus.Processor;
+import org.apache.storm.generated.NimbusSummary;
+import org.apache.storm.generated.NodeInfo;
+import org.apache.storm.generated.NotAliveException;
+import org.apache.storm.generated.NumErrorsChoice;
+import org.apache.storm.generated.Prof

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

[srdo]

Github user srdo commented on a diff in the pull request:

https://github.com/apache/storm/pull/1744#discussion_r90513444
  
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3729 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ * 
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.daemon.nimbus;
+
+import static org.apache.storm.metric.StormMetricsRegistry.registerMeter;
+import static org.apache.storm.utils.Utils.OR;
+
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.InterruptedIOException;
+import java.io.OutputStream;
+import java.net.BindException;
+import java.net.ServerSocket;
+import java.nio.ByteBuffer;
+import java.nio.channels.Channels;
+import java.nio.channels.WritableByteChannel;
+import java.security.Principal;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.Map.Entry;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.UnaryOperator;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import javax.security.auth.Subject;
+
+import org.apache.storm.Config;
+import org.apache.storm.StormTimer;
+import org.apache.storm.blobstore.AtomicOutputStream;
+import org.apache.storm.blobstore.BlobStore;
+import org.apache.storm.blobstore.BlobStoreAclHandler;
+import org.apache.storm.blobstore.BlobSynchronizer;
+import org.apache.storm.blobstore.InputStreamWithMeta;
+import org.apache.storm.blobstore.KeySequenceNumber;
+import org.apache.storm.blobstore.LocalFsBlobStore;
+import org.apache.storm.cluster.ClusterStateContext;
+import org.apache.storm.cluster.ClusterUtils;
+import org.apache.storm.cluster.DaemonType;
+import org.apache.storm.cluster.IStormClusterState;
+import org.apache.storm.daemon.DaemonCommon;
+import org.apache.storm.daemon.Shutdownable;
+import org.apache.storm.daemon.StormCommon;
+import org.apache.storm.generated.AlreadyAliveException;
+import org.apache.storm.generated.Assignment;
+import org.apache.storm.generated.AuthorizationException;
+import org.apache.storm.generated.BeginDownloadResult;
+import org.apache.storm.generated.ClusterSummary;
+import org.apache.storm.generated.CommonAggregateStats;
+import org.apache.storm.generated.ComponentAggregateStats;
+import org.apache.storm.generated.ComponentPageInfo;
+import org.apache.storm.generated.ComponentType;
+import org.apache.storm.generated.Credentials;
+import org.apache.storm.generated.DebugOptions;
+import org.apache.storm.generated.ErrorInfo;
+import org.apache.storm.generated.ExecutorInfo;
+import org.apache.storm.generated.ExecutorStats;
+import org.apache.storm.generated.ExecutorSummary;
+import org.apache.storm.generated.GetInfoOptions;
+import org.apache.storm.generated.InvalidTopologyException;
+import org.apache.storm.generated.KeyAlreadyExistsException;
+import org.apache.storm.generated.KeyNotFoundException;
+import org.apache.storm.generated.KillOptions;
+import org.apache.storm.generated.LSTopoHistory;
+import org.apache.storm.generated.ListBlobsResult;
+import org.apache.storm.generated.LogConfig;
+import org.apache.storm.generated.LogLevel;
+import org.apache.storm.generated.LogLevelAction;
+import org.apache.storm.generated.Nimbus.Iface;
+import org.apache.storm.generated.Nimbus.Processor;
+import org.apache.storm.generated.NimbusSummary;
+import org.apache.storm.generated.NodeInfo;
+import org.apache.storm.generated.NotAliveException;
+import org.apache.storm.generated.NumErrorsChoice;
+import org.apache.storm.generated.Prof

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

[srdo]

Github user srdo commented on a diff in the pull request:

https://github.com/apache/storm/pull/1744#discussion_r90510263
  
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3729 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ * 
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.daemon.nimbus;
+
+import static org.apache.storm.metric.StormMetricsRegistry.registerMeter;
+import static org.apache.storm.utils.Utils.OR;
+
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.InterruptedIOException;
+import java.io.OutputStream;
+import java.net.BindException;
+import java.net.ServerSocket;
+import java.nio.ByteBuffer;
+import java.nio.channels.Channels;
+import java.nio.channels.WritableByteChannel;
+import java.security.Principal;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.Map.Entry;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.UnaryOperator;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import javax.security.auth.Subject;
+
+import org.apache.storm.Config;
+import org.apache.storm.StormTimer;
+import org.apache.storm.blobstore.AtomicOutputStream;
+import org.apache.storm.blobstore.BlobStore;
+import org.apache.storm.blobstore.BlobStoreAclHandler;
+import org.apache.storm.blobstore.BlobSynchronizer;
+import org.apache.storm.blobstore.InputStreamWithMeta;
+import org.apache.storm.blobstore.KeySequenceNumber;
+import org.apache.storm.blobstore.LocalFsBlobStore;
+import org.apache.storm.cluster.ClusterStateContext;
+import org.apache.storm.cluster.ClusterUtils;
+import org.apache.storm.cluster.DaemonType;
+import org.apache.storm.cluster.IStormClusterState;
+import org.apache.storm.daemon.DaemonCommon;
+import org.apache.storm.daemon.Shutdownable;
+import org.apache.storm.daemon.StormCommon;
+import org.apache.storm.generated.AlreadyAliveException;
+import org.apache.storm.generated.Assignment;
+import org.apache.storm.generated.AuthorizationException;
+import org.apache.storm.generated.BeginDownloadResult;
+import org.apache.storm.generated.ClusterSummary;
+import org.apache.storm.generated.CommonAggregateStats;
+import org.apache.storm.generated.ComponentAggregateStats;
+import org.apache.storm.generated.ComponentPageInfo;
+import org.apache.storm.generated.ComponentType;
+import org.apache.storm.generated.Credentials;
+import org.apache.storm.generated.DebugOptions;
+import org.apache.storm.generated.ErrorInfo;
+import org.apache.storm.generated.ExecutorInfo;
+import org.apache.storm.generated.ExecutorStats;
+import org.apache.storm.generated.ExecutorSummary;
+import org.apache.storm.generated.GetInfoOptions;
+import org.apache.storm.generated.InvalidTopologyException;
+import org.apache.storm.generated.KeyAlreadyExistsException;
+import org.apache.storm.generated.KeyNotFoundException;
+import org.apache.storm.generated.KillOptions;
+import org.apache.storm.generated.LSTopoHistory;
+import org.apache.storm.generated.ListBlobsResult;
+import org.apache.storm.generated.LogConfig;
+import org.apache.storm.generated.LogLevel;
+import org.apache.storm.generated.LogLevelAction;
+import org.apache.storm.generated.Nimbus.Iface;
+import org.apache.storm.generated.Nimbus.Processor;
+import org.apache.storm.generated.NimbusSummary;
+import org.apache.storm.generated.NodeInfo;
+import org.apache.storm.generated.NotAliveException;
+import org.apache.storm.generated.NumErrorsChoice;
+import org.apache.storm.generated.Prof

[GitHub] storm issue #1781: STORM-1369: Add MapState implementation to storm-cassandr...

[ptgoetz]

Github user ptgoetz commented on the issue:

https://github.com/apache/storm/pull/1781
  
Unfortunately this patch uses Cassandra-unit, which is LGPL licensed, so in 
it's current state we can't accept it. For that reason I am -1. We've run into 
this before, and I've lobbied the Cassandra-unit author to switch to an Apache 
compatible license (https://github.com/jsevellec/cassandra-unit/issues/163) to 
no avail.

We can, however, accept it if the Cassandra-unit dependency and tests that 
depend on it are removed.

Again, it's unfortunate. If more people encourage the Cassandra-unit author 
to choose a different license, perhaps he'll consider it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1744: STORM-1276: line for line translation of nimbus to java

[erikdw]

Github user erikdw commented on the issue:

https://github.com/apache/storm/pull/1744
  
@revans2 : Since I didn't have any substantive blocking commits I'm ok with 
merging it.  And it's been long enough that I think you're probably ok to merge 
away.  Any hidden problems will hopefully be surfaced by subsequent testing by 
others when this is in the mainline.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

[kosii]

Github user kosii commented on the issue:

https://github.com/apache/storm/pull/1470
  
@arunmahadevan actually my patch depends on #2020, which isn't yet in 
1.x-branch. how should we proceed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1809: STORM-1886 Extend KeyValueState iface with delete

[kosii]

Github user kosii closed the pull request at:

https://github.com/apache/storm/pull/1809


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1804: STORM-2222: Repeated NPEs thrown in nimbus if rebalance f...

[jerrypeng]

Github user jerrypeng commented on the issue:

https://github.com/apache/storm/pull/1804
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1809: STORM-1886 Extend KeyValueState iface with delete

[kosii]

GitHub user kosii opened a pull request:

https://github.com/apache/storm/pull/1809

STORM-1886 Extend KeyValueState iface with delete

The same as #1470, just against the 1.x-branch

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/s4mDev/storm keyvaluestate-with-delete

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/1809.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1809


commit 3a16070385e699af37d996fb2401260ec671a391
Author: Jungtaek Lim 
Date:   2016-09-23T01:39:04Z

add STORM-2101 to CHANGELOG

commit edd0c73d71dceeeb0e2d645a8d96da8fc1c13aa3
Author: Jungtaek Lim 
Date:   2016-09-23T01:43:33Z

Merge branch 'STORM-2110' of https://github.com/revans2/incubator-storm 
into STORM-2110

commit 1bdc922e288dac031cdb9bc628e3dd660385dd03
Author: Jungtaek Lim 
Date:   2016-09-23T01:44:02Z

add STORM-2110 to CHANGELOG

commit bd75c9352c45d7e7c16b46052c0a3c4e9b2513d2
Author: Jungtaek Lim 
Date:   2016-09-23T01:48:23Z

Merge branch 'master' of https://github.com/aichow/storm into STORM-2120

commit 5e5e83cabe3b66161d4774f5f5698fcad8012d0e
Author: Jungtaek Lim 
Date:   2016-09-23T01:48:43Z

add STORM-2120 to CHANGELOG

commit 1fed08f3ee56de4bc98adc8991c7b2c76f9bf4ec
Author: Jungtaek Lim 
Date:   2016-09-23T01:56:21Z

Merge branch 'STORM-1664' of https://github.com/srdo/storm into STORM-1664

commit eb02edeaa8e7e6daf0012c68650d35b5fd00baa6
Author: Jungtaek Lim 
Date:   2016-09-23T01:56:49Z

add STORM-1664 to CHANGELOG

commit 7140a1534c32b1ead35c4c35a251a543f2e0b488
Author: Jungtaek Lim 
Date:   2016-09-23T02:02:58Z

Merge branch 'STORM-2078_enable_pagination_in_worker_tables' of 
https://github.com/abellina/storm into STORM-2078

commit d2ca97f3e96e382f33978893e2fad9a887933b76
Author: Jungtaek Lim 
Date:   2016-09-23T02:13:29Z

add STORM-2078 to CHANGELOG

commit a7445d3f714e4eee913997689f87ad53b5483ac5
Author: Arun Mahadevan 
Date:   2016-09-23T05:57:45Z

[STORM-2118] address review comments

commit 6cd9661bde2ce4c93c5628aae2565e167b89aeb3
Author: Kyle Nusbaum 
Date:   2016-09-23T06:48:33Z

Fix ups.

commit 6a8be9f8c19bacb646c119c162c6cdba69cc66ff
Author: Kyle Nusbaum 
Date:   2016-09-23T07:03:46Z

Fix ups.

commit 523317b06abe87d7e745885c32c8a9c5dfbbeb0d
Author: Kyle Nusbaum 
Date:   2016-09-23T07:29:59Z

Cleaning up tests.

commit 410ef3a816fc6a961771abfbcac2d83512192040
Author: Kyle Nusbaum 
Date:   2016-09-23T07:31:54Z

Cleaning up.

commit 158228b7ad434287e7d1ec92aca9c5c08f144869
Author: Kyle Nusbaum 
Date:   2016-09-23T16:03:32Z

Kick travis

commit e55d9b7d47a8ea62174be106af0f9ab1cea402eb
Author: Robert (Bobby) Evans 
Date:   2016-09-23T16:26:34Z

STORM-2122: Cache dependency data, and serialize reading of the data.

commit 6a657f16301306b5b0d8d4ab91f916c6e7757ffe
Author: Kyle Nusbaum 
Date:   2016-09-23T16:28:39Z

Fixing travis, adding license to new code.

commit e5a8841d3138eb5b7ce7863b0b2a1c8452bb8b5c
Author: Robert (Bobby) Evans 
Date:   2016-09-21T14:41:15Z

STORM-2109: Treat Supervisor CPU/MEMORY Configs as Numbers

commit bf91e6d27912d02912d7220d2abeeaf05b8d5f0a
Author: Robert (Bobby) Evans 
Date:   2016-09-23T17:07:25Z

Addressed review comments

commit 7bb3b25473b7271512715f0599f27c334ef61332
Author: Robert (Bobby) Evans 
Date:   2016-09-23T17:28:03Z

Merge branch 'STORM-2117' of https://github.com/HeartSaVioR/storm into 
STORM-2117

STROM-2117:  Supervisor V2 with local mode extracts resources directory to 
the wrong directory

commit d8115e7bdfeb08a9629a6e8525b90de72c35cbf7
Author: Robert (Bobby) Evans 
Date:   2016-09-23T17:28:44Z

Added STORM-2117 to Changelog

commit 42722c5f1707d8179adf2903480744327b326954
Author: kamleshbhatt 
Date:   2016-09-23T17:48:51Z

correction as per review comments

commit dcd4de631cc3b4d5752da8e0246c658c9b0dca24
Author: kamleshbhatt 
Date:   2016-09-23T17:52:08Z

corrections as per review comments

commit 506b77ed2428d7554000d2bcdbb036c55c068825
Author: Jungtaek Lim 
Date:   2016-09-25T11:17:34Z

Merge branch 'STORM-2105_cluster_supervisor_total_and_avail_resources' of 
https://github.com/abellina/storm into STORM-2105

commit 5fea60211987043926fe404e1fbf86b69dfd1723
Author: Jungtaek Lim 
Date:   2016-09-25T11:44:48Z

add STORM-2105 to CHANGELOG

commit 1056efb227409c136e715da0f93a06633b53af8c
Author: Jungtaek Lim 
Date:   2016-09-25T11:57:04Z

Merge branch 'STORM-2122' of https://github.com/revans2/incubator-storm 
into STORM-2122

commit 22e9609e933587436aee018009684d5599c0f47b
Author: Jungtaek Lim 
Date:   2016-09-25T12:08:56Z

add STORM-2122 to CHANGELOG

commit 6220f71edf9906d2ec1197cb8f7316c85e4fa20d
Author: Jungtaek Lim 
Date:   2016-09-25T12:12:21Z

Merge branch 'STORM-2119' of https://github.com/jerrype

[GitHub] storm issue #1786: STORM-1281: LocalCluster, testing4j and testing.clj to ja...

[revans2]

Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/1786
  
@ptgoetz I added in javadocs for most of the new classes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [ANNOUNCE] New Storm Commiter/PMC Member: Xin Wang

[Hugo Da Cruz Louro]

Congratulations Xing! Keep up the good work.
Best,
Hugo

> On Dec 1, 2016, at 6:17 AM, Bobby Evans  wrote:
> 
> Congratulations.
> - Bobby
> 
> On Thursday, December 1, 2016, 4:23:16 AM CST, Satish Duggana 
>  wrote:Congratulations Xin!!
> 
> ~Satish.
> 
> On 12/1/16, 10:54 AM, "Matthias J. Sax"  wrote:
> 
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
> 
> Congrats!
> 
> On 11/30/16 8:43 PM, Jungtaek Lim wrote:
> > Please join me in welcoming Xin Wang as a new Apache Storm
> > Committer and PMC member.
> > 
> > Xin Wang has showed strong commitment to the Apache Storm community
> > via code contributions for a long time spanning both core and as
> > well as integration components. He also has showed active
> > participation on mailing lists.
> > 
> > Congratulations and welcome Xin!
> > 
> > - Jungtaek Lim (HeartSaVioR)
> > 
> -BEGIN PGP SIGNATURE-
> Comment: GPGTools - https://gpgtools.org
> 
> iQIYBAEBCgAGBQJYP7P1AAoJELz8Z8hxAGOi3egP3RcjYhi9Bof+Y/T30Sy2+TCH
> ccBRcYxZcm2zRGZoLgAFO4HolBEaH0NyEhcj26lLzwl59zLrBWlpfxhSf0ruPW/X
> Dg5Lm6dtY9LkweUePSgxh7SxnSL0wxh+5ID0Yyv4YuB0p9IE4D9+YM0ziKj+moFd
> nlUICUd+eXzbro8oaa28Gi8D28v97N0vBQaZq9ATyzFkbpm9VTl3rEGw91q/b04n
> kQfELba51TWG4gQGlsALAIBSuHhhJ9wVbFCGnJVLF4t47jS7gDYOZi7TqXOpPDU3
> FS4VhYQUBNPpHgWseeetCSvYe8dGht2+lLYzlj37UDjfS22nGRHRMV3Jh+nQKRW2
> CuDFxlZzH3sxHtvR4d7i5axP2cbFm1sqsn/UcmJsTq17jJBM+vZvv4MmxObS76yn
> ZHo2i7mvuvkGfmgoByzuDaJb/eo30yCJ0+TC4nYaZaI+cLr3hHRRyI2WejtXCI3r
> 8vrfHt3dXbbwLwFMRkckvdELqxnsxVI5oFbswPl+0H0SChI33rtL/L/lwvzqp3df
> HHb75AJDHjFwHTvAakhuXACuQ/+y3ZezrKfhmjf4mWlYor5mNwMtMEMeH11LUDaV
> 2CRrPVZ13GPJ3dyhgA/nCYFvsm9K5EINOpMW08saZg/yryK6ExoQDpJa8y8F6E4E
> CoiIwY2RoW1P/T4=
> =nTHE
> -END PGP SIGNATURE-
> 
> 
> 

[GitHub] storm issue #1807: fix NullPointException with acked.get(rtp)

[hmcl]

Github user hmcl commented on the issue:

https://github.com/apache/storm/pull/1807
  
@srdo @cutd looking at it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

[kosii]

Github user kosii commented on the issue:

https://github.com/apache/storm/pull/1470
  
Yes, I'll look into that!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1807: fix NullPointException with acked.get(rtp)

[srdo]

Github user srdo commented on the issue:

https://github.com/apache/storm/pull/1807
  
Good catch. I think I'd prefer disabling the retry logic entirely when auto 
commit is enabled though. It doesn't really make sense to me that you would 
want to have Storm guarantee at least once processing for tuples from the Kafka 
spout, but also don't care about losing tuples if the Kafka spout crashes. It 
would be good IMO if we added the same type of check to fail() as ack() has, so 
we skip scheduling tuples for retry if auto commit is enabled.

@hmcl do you have any thoughts on this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1786: STORM-1281: LocalCluster, testing4j and testing.clj to ja...

[revans2]

Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/1786
  
@ptgoetz I'll look at adding in some javadocs.  In general I tried to add 
javadocs where there were clojure doc strings, but there were not too many of 
them either. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1765: STORM-2190: reduce contention between submission a...

[revans2]

Github user revans2 commented on a diff in the pull request:

https://github.com/apache/storm/pull/1765#discussion_r90465747
  
--- Diff: 
examples/storm-starter/src/jvm/org/apache/storm/starter/WordCountTopology.java 
---
@@ -90,7 +90,9 @@ public static void main(String[] args) throws Exception {
 if (args != null && args.length > 0) {
   conf.setNumWorkers(3);
 
-  StormSubmitter.submitTopologyWithProgressBar(args[0], conf, 
builder.createTopology());
+  for (String name: args) {
--- End diff --

This was code that I put in to be able to reproduce the problem 
consistently.  If you want me to remove it I am happy to.  It does not really 
provide any real value beyond that.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1744: STORM-1276: line for line translation of nimbus to java

[revans2]

Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/1744
  
@erikdw I addressed your nits.  I appreciate the nits because we don't have 
a coding standard yet.

If we are just down to nits I really would like to get this in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

[revans2]

Github user revans2 commented on a diff in the pull request:

https://github.com/apache/storm/pull/1744#discussion_r90464031
  
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3729 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ * 
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.daemon.nimbus;
+
+import static org.apache.storm.metric.StormMetricsRegistry.registerMeter;
+import static org.apache.storm.utils.Utils.OR;
+
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.InterruptedIOException;
+import java.io.OutputStream;
+import java.net.BindException;
+import java.net.ServerSocket;
+import java.nio.ByteBuffer;
+import java.nio.channels.Channels;
+import java.nio.channels.WritableByteChannel;
+import java.security.Principal;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.Map.Entry;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.UnaryOperator;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import javax.security.auth.Subject;
+
+import org.apache.storm.Config;
+import org.apache.storm.StormTimer;
+import org.apache.storm.blobstore.AtomicOutputStream;
+import org.apache.storm.blobstore.BlobStore;
+import org.apache.storm.blobstore.BlobStoreAclHandler;
+import org.apache.storm.blobstore.BlobSynchronizer;
+import org.apache.storm.blobstore.InputStreamWithMeta;
+import org.apache.storm.blobstore.KeySequenceNumber;
+import org.apache.storm.blobstore.LocalFsBlobStore;
+import org.apache.storm.cluster.ClusterStateContext;
+import org.apache.storm.cluster.ClusterUtils;
+import org.apache.storm.cluster.DaemonType;
+import org.apache.storm.cluster.IStormClusterState;
+import org.apache.storm.daemon.DaemonCommon;
+import org.apache.storm.daemon.Shutdownable;
+import org.apache.storm.daemon.StormCommon;
+import org.apache.storm.generated.AlreadyAliveException;
+import org.apache.storm.generated.Assignment;
+import org.apache.storm.generated.AuthorizationException;
+import org.apache.storm.generated.BeginDownloadResult;
+import org.apache.storm.generated.ClusterSummary;
+import org.apache.storm.generated.CommonAggregateStats;
+import org.apache.storm.generated.ComponentAggregateStats;
+import org.apache.storm.generated.ComponentPageInfo;
+import org.apache.storm.generated.ComponentType;
+import org.apache.storm.generated.Credentials;
+import org.apache.storm.generated.DebugOptions;
+import org.apache.storm.generated.ErrorInfo;
+import org.apache.storm.generated.ExecutorInfo;
+import org.apache.storm.generated.ExecutorStats;
+import org.apache.storm.generated.ExecutorSummary;
+import org.apache.storm.generated.GetInfoOptions;
+import org.apache.storm.generated.InvalidTopologyException;
+import org.apache.storm.generated.KeyAlreadyExistsException;
+import org.apache.storm.generated.KeyNotFoundException;
+import org.apache.storm.generated.KillOptions;
+import org.apache.storm.generated.LSTopoHistory;
+import org.apache.storm.generated.ListBlobsResult;
+import org.apache.storm.generated.LogConfig;
+import org.apache.storm.generated.LogLevel;
+import org.apache.storm.generated.LogLevelAction;
+import org.apache.storm.generated.Nimbus.Iface;
+import org.apache.storm.generated.Nimbus.Processor;
+import org.apache.storm.generated.NimbusSummary;
+import org.apache.storm.generated.NodeInfo;
+import org.apache.storm.generated.NotAliveException;
+import org.apache.storm.generated.NumErrorsChoice;
+import org.apache.storm.generated.P

[GitHub] storm issue #1783: STORM-2204 Adding caching capabilities in HBaseLookupBolt

[HeartSaVioR]

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/1783
  
OK. Since we have other modules which depends on Guava, it might be better 
to have a rule and apply all of them. +1 to shade Guava on external modules if 
possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1808: STORM-2225: change spout config to be simpler.

[revans2]

Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/1808
  
I updated the docs and the examples.  This is a non-backwards compatible 
change from the 1.x release.  I have some code (not included here) that can 
maintain most compatibility if we really want to, but because of STORM-2228 I 
decided it would be better to just not support that at all.  If we want to add 
that compatibility for 1.x  but deprecated I am OK with that, but would like 
feedback on it before putting up some kind of a pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1808: STORM-1997: copy state/bolt from storm-kafka to st...

[revans2]

GitHub user revans2 opened a pull request:

https://github.com/apache/storm/pull/1808

STORM-1997: copy state/bolt from storm-kafka to storm-kafka-client


STORM-2228: removed ability to request a single topic go to multiple streams

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/revans2/incubator-storm STORM-2225

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/1808.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1808


commit 32da09c1b205e0e2822e959674557b7c61842a40
Author: Robert (Bobby) Evans 
Date:   2016-11-30T03:39:26Z

STORM-1997: copy state/bolt from storm-kafka to storm-kafka-client
STORM-2225: change spout config to be simpler.
STORM-2228: removed ability to request a single topic go to multiple streams




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [ANNOUNCE] New Storm Commiter/PMC Member: Xin Wang

[Bobby Evans]

Congratulations.
- Bobby

On Thursday, December 1, 2016, 4:23:16 AM CST, Satish Duggana 
 wrote:Congratulations Xin!!

~Satish.

On 12/1/16, 10:54 AM, "Matthias J. Sax"  wrote:

    -BEGIN PGP SIGNED MESSAGE-
    Hash: SHA512
    
    Congrats!
    
    On 11/30/16 8:43 PM, Jungtaek Lim wrote:
    > Please join me in welcoming Xin Wang as a new Apache Storm
    > Committer and PMC member.
    > 
    > Xin Wang has showed strong commitment to the Apache Storm community
    > via code contributions for a long time spanning both core and as
    > well as integration components. He also has showed active
    > participation on mailing lists.
    > 
    > Congratulations and welcome Xin!
    > 
    > - Jungtaek Lim (HeartSaVioR)
    > 
    -BEGIN PGP SIGNATURE-
    Comment: GPGTools - https://gpgtools.org
    
    iQIYBAEBCgAGBQJYP7P1AAoJELz8Z8hxAGOi3egP3RcjYhi9Bof+Y/T30Sy2+TCH
    ccBRcYxZcm2zRGZoLgAFO4HolBEaH0NyEhcj26lLzwl59zLrBWlpfxhSf0ruPW/X
    Dg5Lm6dtY9LkweUePSgxh7SxnSL0wxh+5ID0Yyv4YuB0p9IE4D9+YM0ziKj+moFd
    nlUICUd+eXzbro8oaa28Gi8D28v97N0vBQaZq9ATyzFkbpm9VTl3rEGw91q/b04n
    kQfELba51TWG4gQGlsALAIBSuHhhJ9wVbFCGnJVLF4t47jS7gDYOZi7TqXOpPDU3
    FS4VhYQUBNPpHgWseeetCSvYe8dGht2+lLYzlj37UDjfS22nGRHRMV3Jh+nQKRW2
    CuDFxlZzH3sxHtvR4d7i5axP2cbFm1sqsn/UcmJsTq17jJBM+vZvv4MmxObS76yn
    ZHo2i7mvuvkGfmgoByzuDaJb/eo30yCJ0+TC4nYaZaI+cLr3hHRRyI2WejtXCI3r
    8vrfHt3dXbbwLwFMRkckvdELqxnsxVI5oFbswPl+0H0SChI33rtL/L/lwvzqp3df
    HHb75AJDHjFwHTvAakhuXACuQ/+y3ZezrKfhmjf4mWlYor5mNwMtMEMeH11LUDaV
    2CRrPVZ13GPJ3dyhgA/nCYFvsm9K5EINOpMW08saZg/yryK6ExoQDpJa8y8F6E4E
    CoiIwY2RoW1P/T4=
    =nTHE
    -END PGP SIGNATURE-
    
    

[GitHub] storm issue #1783: STORM-2204 Adding caching capabilities in HBaseLookupBolt

[revans2]

Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/1783
  
I guess guava is OK for 1.x.  I would prefer to see it shaded if we do go 
with Guava, but I am only a -0 if it is not shaded.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [ANNOUNCE] New Storm Commiter/PMC Member: Xin Wang

[Satish Duggana]

Congratulations Xin!!

~Satish.

On 12/1/16, 10:54 AM, "Matthias J. Sax"  wrote:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Congrats!

On 11/30/16 8:43 PM, Jungtaek Lim wrote:
> Please join me in welcoming Xin Wang as a new Apache Storm
> Committer and PMC member.
> 
> Xin Wang has showed strong commitment to the Apache Storm community
> via code contributions for a long time spanning both core and as
> well as integration components. He also has showed active
> participation on mailing lists.
> 
> Congratulations and welcome Xin!
> 
> - Jungtaek Lim (HeartSaVioR)
> 
-BEGIN PGP SIGNATURE-
Comment: GPGTools - https://gpgtools.org

iQIYBAEBCgAGBQJYP7P1AAoJELz8Z8hxAGOi3egP3RcjYhi9Bof+Y/T30Sy2+TCH
ccBRcYxZcm2zRGZoLgAFO4HolBEaH0NyEhcj26lLzwl59zLrBWlpfxhSf0ruPW/X
Dg5Lm6dtY9LkweUePSgxh7SxnSL0wxh+5ID0Yyv4YuB0p9IE4D9+YM0ziKj+moFd
nlUICUd+eXzbro8oaa28Gi8D28v97N0vBQaZq9ATyzFkbpm9VTl3rEGw91q/b04n
kQfELba51TWG4gQGlsALAIBSuHhhJ9wVbFCGnJVLF4t47jS7gDYOZi7TqXOpPDU3
FS4VhYQUBNPpHgWseeetCSvYe8dGht2+lLYzlj37UDjfS22nGRHRMV3Jh+nQKRW2
CuDFxlZzH3sxHtvR4d7i5axP2cbFm1sqsn/UcmJsTq17jJBM+vZvv4MmxObS76yn
ZHo2i7mvuvkGfmgoByzuDaJb/eo30yCJ0+TC4nYaZaI+cLr3hHRRyI2WejtXCI3r
8vrfHt3dXbbwLwFMRkckvdELqxnsxVI5oFbswPl+0H0SChI33rtL/L/lwvzqp3df
HHb75AJDHjFwHTvAakhuXACuQ/+y3ZezrKfhmjf4mWlYor5mNwMtMEMeH11LUDaV
2CRrPVZ13GPJ3dyhgA/nCYFvsm9K5EINOpMW08saZg/yryK6ExoQDpJa8y8F6E4E
CoiIwY2RoW1P/T4=
=nTHE
-END PGP SIGNATURE-

[GitHub] storm issue #1783: STORM-2204 Adding caching capabilities in HBaseLookupBolt

[vesense]

Github user vesense commented on the issue:

https://github.com/apache/storm/pull/1783
  
+1 for merging to master after updating `docs/storm-hbase.md`. 
`external/storm-hbase/README.md` has been documented.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1798: Storm-2203 Add a getAll method to KeyValueState in...

[aandis]

Github user aandis commented on a diff in the pull request:

https://github.com/apache/storm/pull/1798#discussion_r90408316
  
--- Diff: storm-core/src/jvm/org/apache/storm/state/KeyValueState.java ---
@@ -45,4 +47,9 @@
  * @return the value or defaultValue if no mapping is found
  */
 V get(K key, V defaultValue);
+
+/**
+ * @return all key value mappings as an unmodifiable map.
+ */
+Map getAll();
--- End diff --

cool. I wasn't aware `hscan` gives you a `cursor`, redis is sort of new to 
me. I am gonna look into it and will update the pr. thanks guys. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1798: Storm-2203 Add a getAll method to KeyValueState in...

[HeartSaVioR]

Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/1798#discussion_r90406354
  
--- Diff: storm-core/src/jvm/org/apache/storm/state/KeyValueState.java ---
@@ -45,4 +47,9 @@
  * @return the value or defaultValue if no mapping is found
  */
 V get(K key, V defaultValue);
+
+/**
+ * @return all key value mappings as an unmodifiable map.
+ */
+Map getAll();
--- End diff --

You can implement custom iterator which stores cursor for `hscan` as 
internal state. Call hscan to get some elements and store to `queue` as 
internal state, pop and return it when next() is called. If queue is empty you 
can hscan again to determine there're more elements in the hash or it is end of 
elements in hash.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1798: Storm-2203 Add a getAll method to KeyValueState in...

[arunmahadevan]

Github user arunmahadevan commented on a diff in the pull request:

https://github.com/apache/storm/pull/1798#discussion_r90406042
  
--- Diff: storm-core/src/jvm/org/apache/storm/state/KeyValueState.java ---
@@ -45,4 +47,9 @@
  * @return the value or defaultValue if no mapping is found
  */
 V get(K key, V defaultValue);
+
+/**
+ * @return all key value mappings as an unmodifiable map.
+ */
+Map getAll();
--- End diff --

At a high level I think you should be able to use redis hscan to implement 
the iterator and deserialize the key/values as you return them. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1742: STORM-2170 [Storm SQL] Add built-in socket datasource to ...

[vesense]

Github user vesense commented on the issue:

https://github.com/apache/storm/pull/1742
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1798: Storm-2203 Add a getAll method to KeyValueState in...

[aandis]

Github user aandis commented on a diff in the pull request:

https://github.com/apache/storm/pull/1798#discussion_r90405070
  
--- Diff: storm-core/src/jvm/org/apache/storm/state/KeyValueState.java ---
@@ -45,4 +47,9 @@
  * @return the value or defaultValue if no mapping is found
  */
 V get(K key, V defaultValue);
+
+/**
+ * @return all key value mappings as an unmodifiable map.
+ */
+Map getAll();
--- End diff --

> the issue with map is that you need to load the entire state into the map 
before you can return 

true. It makes sense for the interface to return an iterator. But I am not 
sure of the implementation for say, `RedisKeyValueState`. Wouldn't you _need_ 
to load the entire state and preprocess them since there's 
[deserialization](https://github.com/apache/storm/pull/1798/files#diff-2e47d8842f277cb12f6bddbe2b7f94f5R161)
 involved?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1798: Storm-2203 Add a getAll method to KeyValueState in...

[aandis]

Github user aandis commented on a diff in the pull request:

https://github.com/apache/storm/pull/1798#discussion_r90398126
  
--- Diff: storm-core/src/jvm/org/apache/storm/state/KeyValueState.java ---
@@ -45,4 +47,9 @@
  * @return the value or defaultValue if no mapping is found
  */
 V get(K key, V defaultValue);
+
+/**
+ * @return all key value mappings as an unmodifiable map.
+ */
+Map getAll();
--- End diff --

@arunmahadevan You mean an `iterator` over the original 
[state](https://github.com/apache/storm/pull/1798/files#diff-ad463cc68c1b4705bce8681f13dcd6d4R35)?
 `iterator` also has a `remove` method which shouldn't be a supported operation 
over `KeyValueState` since there's 
[delete](https://github.com/apache/storm/commit/285668742742da6316d38c1ef492c7c873b5a649#diff-4ac32a78649ca5bdd8e0ba38b7006a1eR2).
 That's the reason for creating and returning an unmodifiable map. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---