Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1757
@HeartSaVioR I am OK with a common module, but does it make sense to have a
common module, with little or no dependencies, just to hold a couple of
classes, and have both kafka modules refer to it? In
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1679
@revans2 apologies for the delay... started it and then something came in
the way... will finish by tomorrow for sure. Will do my best to get this merged
in asap...
---
If your project is set up for
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1679
@revans2 reviewing this at this moment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1757
@harshach @HeartSaVioR I am fine either way. @HeartSaVioR, of all the
alternatives that we discussed, can you please let me know which one you prefer
? It should be an easy fix, and I can either
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1679#discussion_r86892941
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -266,26 +266,32 @@ private void
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1679#discussion_r79800258
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -479,16 +482,17 @@ public OffsetAndMetadata
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1679#discussion_r79797993
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -266,26 +266,32 @@ private void
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1679#discussion_r86892802
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -479,16 +487,17 @@ public OffsetAndMetadata
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1679#discussion_r86846452
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/builders/SingleTopicKafkaSpoutConfiguration.java
---
@@ -0,0 +1,85
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1679#discussion_r86846400
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/builders/SingleTopicKafkaSpoutConfiguration.java
---
@@ -0,0 +1,85
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1679#discussion_r86893341
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -266,19 +266,22 @@ private void
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1679#discussion_r86895288
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/SingleTopicKafkaSpoutTest.java
---
@@ -0,0 +1,250 @@
+/*
+ * Licensed
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1679#discussion_r86894060
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/builders/SingleTopicKafkaSpoutConfiguration.java
---
@@ -0,0 +1,85
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1679
+1 overall. It would be ideal to cleanup the test code according to my
earlier suggestion. Thanks for the work @jfenc91
---
If your project is set up for it, you can reply to this email and have your
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1757
@HeartSaVioR so that means that we can merge this in and address those
improvements later?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1679
+1
@jfenc91 thanks for the extra cleanup.
@revans2 as far as I am concerned this patch is ready to merge. Thanks for
your clarifying comments.
---
If your project is set up for it
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1687
@harshach I have changed the titles of the PRs, however what is really
important are the git commit messages, and those were correct. Once the patch
is merged, no one will ever look at the PR titles
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1757
@harshach changed the title of the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hmcl closed the pull request at:
https://github.com/apache/storm/pull/1687
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1687
@harshach done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/1779
STORM-1694: Kafka Spout Trident Implementation Using New Kafka Consumer API
@harshach I refactored the patch merged onto in order to compile. The
changes are to remove the use of lambdas and to fix
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/1787
STORM-2208: HDFS State Throws FileNotFoundException in Azure Data Lake
Store file system (adl://)
- Close OutputStream before file gets deleted
You can merge this pull request into a Git repository
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1787
Please backport to 1.x and 1.0.x branch. It should be a trivial merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1787
@revans2 agree && Done!
I followed your suggestion but most calls to fs will throw IOException. To
keep only one try catch block the cleanest way to do it is to close the
OutputStrea
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/1791
STORM-2212: Remove Redundant Declarations in Maven POM Files
- Remove redundant declarations cause warnings and make the build files
harder to extend and maintain
You can merge this pull request
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1791
The variable ${storm.topology} is not declared anywhere, hence why it was
removed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1787
@arunmahadevan I agree! I have already filed a but to the Azure team to fix
that case.
However, it does no harm that we account for this scenario.
---
If your project is set up for it, you
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1787
@revans2 I just tested in the Azure cluster running AFS and the fix works.
Please see attached screenshots.
 - please take a look
at the discussion thread. I believe that the
[JPMML](https://github.com
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1816
@vesense I addressed your serialization comment. I had to do some
refactoring of the code because it was a strong requirement to enforce
`ModelRunner` to be serializable. For instance, the JPMML
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1808
@revans2 I would like to take a look at this before this gets merged in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1821
@srdo what is `Thread.currentThread().interrupt();` trying to accomplish?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1816
@csivaguru @ptgoetz @harshach I uploaded a reviewed version addressing your
comments. Can you please take a look. thanks.
---
If your project is set up for it, you can reply to this email and have
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1816#discussion_r91879180
--- Diff:
external/storm-pmml/src/main/java/org/apache/storm/pmml/runner/jpmml/JPmmlModelRunner.java
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1821
@srdo [Kafka's
InterruptException](https://kafka.apache.org/090/javadoc/org/apache/kafka/common/errors/InterruptException.html)
is a RuntimeException, otherwise the code wouldn't even compi
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1821
@srdo I think I understand what you mean. However, I think that the
cleanest way to do this is to catch kafka's InterruptException, and call the
Spout's `close()` method. If it is an error
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1823
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1821
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1820
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1816#discussion_r92246988
--- Diff: external/storm-pmml/README.md ---
@@ -0,0 +1,104 @@
+#Storm PMML Bolt
+ Storm integration to load PMML models and compute predictive scores for
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1816#discussion_r92247952
--- Diff:
examples/storm-pmml-examples/src/main/resources/KNIME_PMML_4.1_Examples_single_audit_logreg.xml
---
@@ -0,0 +1,259 @@
+
--- End diff
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1816#discussion_r92249343
--- Diff: external/storm-pmml/README.md ---
@@ -0,0 +1,104 @@
+#Storm PMML Bolt
+ Storm integration to load PMML models and compute predictive scores for
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1826#discussion_r92546386
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -77,7 +77,7 @@
private KafkaSpoutStreams
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1818
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1825
@liurenjie1024 putting aside for a second the discussion about the need to
implement partition assignment, if we indeed agree that we should support it, I
think that the `KafkaSpout` class is getting a
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1816#discussion_r92736455
--- Diff: external/storm-pmml/README.md ---
@@ -0,0 +1,104 @@
+#Storm PMML Bolt
+ Storm integration to load PMML models and compute predictive scores for
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1816#discussion_r92736485
--- Diff:
examples/storm-pmml-examples/src/main/resources/KNIME_PMML_4.1_Examples_single_audit_logreg.xml
---
@@ -0,0 +1,259 @@
+
--- End diff
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1816#discussion_r92736533
--- Diff:
examples/storm-pmml-examples/src/main/java/org/apache/storm/pmml/JpmmlRunnerTestTopology.java
---
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1816#discussion_r92736541
--- Diff:
examples/storm-pmml-examples/src/main/java/org/apache/storm/pmml/JpmmlRunnerTestTopology.java
---
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1816#discussion_r92736555
--- Diff:
external/storm-pmml/src/main/java/org/apache/storm/pmml/PMMLPredictorBolt.java
---
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1816#discussion_r92736543
--- Diff:
examples/storm-pmml-examples/src/main/java/org/apache/storm/pmml/RawInputFromCSVSpout.java
---
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1816#discussion_r92736547
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/test/KafkaSpoutTopologyMainNamedTopics.java
---
@@ -39,7 +39,6 @@
import
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1816#discussion_r92736561
--- Diff:
external/storm-pmml/src/main/java/org/apache/storm/pmml/PMMLPredictorBolt.java
---
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1816#discussion_r92736718
--- Diff:
external/storm-pmml/src/main/java/org/apache/storm/pmml/PMMLPredictorBolt.java
---
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1816#discussion_r92736752
--- Diff:
external/storm-pmml/src/main/java/org/apache/storm/pmml/PMMLPredictorBolt.java
---
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1816
@ptgoetz @arunmahadevan @harshach Thanks for your reviews. I believe I
addressed all the comments. There is a separate commit with the comments
changes. When we all agree that the patch is ready to
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/1830
Fix typo in flux.md
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hmcl/storm-apache Apache_master_FluxMD
Alternatively you can review and apply
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1816
@arunmahadevan done!
@harshach @ptgoetz @csivaguru can you please take one final look.
If everything is OK, I will go ahead and squash the commits.
Thanks!
---
If your project is set up
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1826#discussion_r92919073
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -77,7 +77,7 @@
private KafkaSpoutStreams
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1831
Whit these changes the examples distribution looks like this:
, please squash the
commits into one commit, and make sure that
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1816#discussion_r93530698
--- Diff: storm-dist/binary/final-package/src/main/assembly/binary.xml ---
@@ -446,6 +446,29 @@
storm*jar
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1816
@ptgoetz
The main focus of this initial patch is to design the classes in such a way
that they can accommodate arbitrary runtime environments. The default
implementation provided uses one such
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1835#discussion_r93551580
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -218,7 +223,11 @@ public void nextTuple
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1835#discussion_r93553634
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/fetcher/ManualKafkaRecordsFetcher.java
---
@@ -0,0 +1,85
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1835#discussion_r93554219
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -61,6 +64,7 @@
// Storm
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1835#discussion_r93555336
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/fetcher/KafkaRecordsFetchers.java
---
@@ -0,0 +1,41 @@
+package
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1835#discussion_r93558112
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/fetcher/ManualKafkaRecordsFetcher.java
---
@@ -0,0 +1,85
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/1838
STORM-2223: PMMLBolt
- PMML Bolt supporting pluggable runners and configurable stream output
fields
- JPMML runner implementation
- JPMML Prediction Test Topology
- README
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1838
@harshach this is the cherry pick for 1.x-branch from
https://github.com/apache/storm/pull/1816
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1816
@harshach 1.x-branch [PR](https://github.com/apache/storm/pull/1838).
@harshach I believe that the license issue was addressed in
[here](https://github.com/apache/storm/pull/1816
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1834
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1837#discussion_r93810498
--- Diff:
storm-core/src/jvm/org/apache/storm/security/auth/SaslTransportPlugin.java ---
@@ -64,8 +64,14 @@ public void prepare(ThriftConnectionType type, Map
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1840
+1. Thanks for the fix.
I compiled this locally, a few times... wonder how this wasn't detected :(
---
If your project is set up for it, you can reply to this email and have your
reply a
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/1844
STORM-2265: Incorrectly Serialized JSON in TransactionalState causes Worker
to Die
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hmcl/storm
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/1845
Create DRPC client printer class reusable for local and remote DRPC
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hmcl/storm-apache
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1844
@HeartSaVioR `JSONValue.parse` will simply return null if there is a
serialization exception. How can that be better than this approach? Isn't
anything other than null better than null?
---
If
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1835#discussion_r93558408
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/partition/KafkaPartitionReaders.java
---
@@ -0,0 +1,27
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1835
+1. Just one minor nit on a name. can you please squash the commits and put
a little summary of the patch in the commit message. Thanks.
---
If your project is set up for it, you can reply to this
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1131
@jianbzhou thanks for your suggested fix and for the summary of changes. I
think that the best way to go about incorporating your changes is to create a
JIRA with summary along the lines "Kafka
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/1855
PMMLPredictorBolt - Handle duplicate output and predicted fields
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hmcl/storm-apache
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/1856
PMMLPredictorBolt - Handle duplicate output and predicted fields
Backport to 1.x-branch
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hmcl/storm
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1853
+1
@HeartSaVioR [STORM-2265](https://github.com/apache/storm/pull/1844) is a
duplicate of this that I found independently. We can go ahead and merge this
(revert) fix. We can keep STORM-2265 open
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1844
@HeartSaVioR I agree with you. Let's merge
[STORM-2264](https://github.com/apache/storm/pull/1853) and keep this open to
explore a more compelling fix. If we find out that the work around the S
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1131
@jianbzhou Thanks for filing the JIRA. I have assigned it to me, such that
it's easier to keep track and follow up on it.
---
If your project is set up for it, you can reply to this email and
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1878
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96694426
--- Diff: docs/storm-kafka-client.md ---
@@ -1,90 +1,232 @@
-#Storm Kafka Spout with New Kafka Consumer API
+#Storm Apache Kafka integration using the
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96694593
--- Diff: docs/storm-kafka-client.md ---
@@ -1,90 +1,232 @@
-#Storm Kafka Spout with New Kafka Consumer API
+#Storm Apache Kafka integration using the
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96717295
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java
---
@@ -0,0 +1,196 @@
+/**
+ * Licensed to the Apache
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96710739
--- Diff: docs/storm-kafka-client.md ---
@@ -1,90 +1,232 @@
-#Storm Kafka Spout with New Kafka Consumer API
+#Storm Apache Kafka integration using the
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96719100
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java
---
@@ -0,0 +1,196 @@
+/**
+ * Licensed to the Apache
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96713362
--- Diff: docs/storm-kafka-client.md ---
@@ -1,90 +1,232 @@
-#Storm Kafka Spout with New Kafka Consumer API
+#Storm Apache Kafka integration using the
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96716770
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java
---
@@ -0,0 +1,194 @@
+/**
+ * Licensed to the Apache
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96720421
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java
---
@@ -0,0 +1,196 @@
+/**
+ * Licensed to the Apache
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96711515
--- Diff: docs/storm-kafka-client.md ---
@@ -1,90 +1,232 @@
-#Storm Kafka Spout with New Kafka Consumer API
+#Storm Apache Kafka integration using the
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96719192
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java
---
@@ -0,0 +1,196 @@
+/**
+ * Licensed to the Apache
501 - 600 of 813 matches
Mail list logo
