Github user lazyval commented on a diff in the pull request:
https://github.com/apache/storm/pull/673#discussion_r37303658
--- Diff: storm-core/src/clj/backtype/storm/cluster.clj ---
@@ -240,7 +240,8 @@
(when cb
(cb id
-(defn- maybe-deserialize
Github user lazyval commented on the pull request:
https://github.com/apache/storm/pull/655#issuecomment-130072102
@revans2 any love for it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user lazyval commented on a diff in the pull request:
https://github.com/apache/storm/pull/667#discussion_r36594606
--- Diff: storm-core/src/clj/backtype/storm/cgroup/cgroup_manager.clj ---
@@ -0,0 +1,109 @@
+(ns backtype.storm.cgroup.cgroup-manager
+ (:import
Github user lazyval commented on a diff in the pull request:
https://github.com/apache/storm/pull/651#discussion_r35654576
--- Diff:
external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventDataScheme.java
---
@@ -42,6 +44,9 @@
AmqpValue amqpValue
Github user lazyval commented on the pull request:
https://github.com/apache/storm/pull/519#issuecomment-125667064
Hm, I tried to do the same on completely different machine (beefy linux
server instead of OSX laptop) and results are the very same:
```
[INFO
Github user lazyval commented on the pull request:
https://github.com/apache/storm/pull/519#issuecomment-125639681
Am I right that Storm still has no support for java 8? I tried to run test
from master on my local machine, but they're failing:
```
» mvn clean install
GitHub user lazyval opened a pull request:
https://github.com/apache/storm/pull/655
[Minor] Removing changelog file from kafka-storm sub-project
No other storm/external project has changelog and it looks like log became
obsolete ever since storm-kafka was incorporated into storm
Github user lazyval commented on the pull request:
https://github.com/apache/storm/pull/655#issuecomment-125712502
I also doubt that https://github.com/apache/storm/blob/master/TODO should
be around
---
If your project is set up for it, you can reply to this email and have your
Github user lazyval commented on the pull request:
https://github.com/apache/storm/pull/642#issuecomment-122858859
Minor complain, but [next time] it would be handy to keep commit messages
a bit more descriptive
img width=465 alt=storm 2015-07-20 14-42-47
src=https
Github user lazyval commented on a diff in the pull request:
https://github.com/apache/storm/pull/610#discussion_r34056406
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -262,7 +261,7 @@ private void retireEldestWriter
Github user lazyval commented on the pull request:
https://github.com/apache/storm/pull/572#issuecomment-118368768
Okay, I am too late to the party :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user lazyval commented on a diff in the pull request:
https://github.com/apache/storm/pull/572#discussion_r33868816
--- Diff: external/storm-kafka/pom.xml ---
@@ -113,8 +113,8 @@
/dependency
dependency
groupIdorg.apache.kafka
Github user lazyval commented on the pull request:
https://github.com/apache/storm/pull/613#issuecomment-118044177
:+1:
For those who wonders what this octal numbers mean, there is a great
[*humanizator*](http://permissions-calculator.org/decode/0644/).
---
If your project
Github user lazyval commented on the pull request:
https://github.com/apache/storm/pull/612#issuecomment-118042465
Code aside, I guess storing *compiled* binaries and libraries in git isn't
quite a good idea.
---
If your project is set up for it, you can reply to this email
Github user lazyval commented on the pull request:
https://github.com/apache/storm/pull/608#issuecomment-118050871
It might be too late for this particular PR, but it makes sense to separate
human changes and generated code into two separate commits. Otherwise it's
really hard
Github user lazyval commented on the pull request:
https://github.com/apache/storm/pull/468#issuecomment-91172000
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user lazyval commented on the pull request:
https://github.com/apache/storm/pull/510#issuecomment-90884297
@Parth-Brahmbhatt +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user lazyval commented on the pull request:
https://github.com/apache/storm/pull/469#issuecomment-88447333
Minor, but you would be better off with *Removed unused `topology-path`
variable* as PR title.
---
If your project is set up for it, you can reply to this email
Github user lazyval commented on a diff in the pull request:
https://github.com/apache/storm/pull/495#discussion_r27562061
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -135,35 +137,68 @@ public static void sleep(long millis) {
}
public
Github user lazyval commented on a diff in the pull request:
https://github.com/apache/storm/pull/495#discussion_r27561516
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -135,35 +137,68 @@ public static void sleep(long millis) {
}
public
Github user lazyval commented on a diff in the pull request:
https://github.com/apache/storm/pull/495#discussion_r27562802
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -135,35 +137,68 @@ public static void sleep(long millis) {
}
public
Github user lazyval commented on a diff in the pull request:
https://github.com/apache/storm/pull/495#discussion_r27571878
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -135,35 +137,68 @@ public static void sleep(long millis) {
}
public
Github user lazyval commented on the pull request:
https://github.com/apache/storm/pull/495#issuecomment-88550651
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user lazyval commented on a diff in the pull request:
https://github.com/apache/storm/pull/468#discussion_r27231134
--- Diff: storm-core/src/jvm/backtype/storm/drpc/DRPCSpout.java ---
@@ -129,7 +133,9 @@ private void checkFutures() {
public void open(Map conf
Github user lazyval commented on a diff in the pull request:
https://github.com/apache/storm/pull/468#discussion_r27230992
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -533,4 +533,16 @@ private static SerializationDelegate
getSerializationDelegate(Map
Github user lazyval commented on the pull request:
https://github.com/apache/storm/pull/468#issuecomment-85088535
And you sure it's not already happening?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user lazyval commented on the pull request:
https://github.com/apache/storm/pull/432#issuecomment-74532426
For those who wanders what exhibitor is -- [it's a zookeeper supervisor
used for monitoring, back up and
visualization](https://github.com/Netflix/exhibitor
Github user lazyval commented on the pull request:
https://github.com/apache/storm/pull/338#issuecomment-66127049
Guys, how about using curator api for this particular problem and raising
new ticket *Kafka spout should rely on kafka APIs, rather than perform
low-level manipulations
Github user lazyval commented on the pull request:
https://github.com/apache/storm/pull/338#issuecomment-65802076
Why not use kafka api for performing such check?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user lazyval commented on the pull request:
https://github.com/apache/storm/pull/338#issuecomment-65808799
@Lewuathe there is [similar method in kafka's
ZkUtils](https://github.com/apache/kafka/blob/0.8/core/src/main/scala/kafka/utils/ZkUtils.scala#L749-L755)
---
If your
30 matches
Mail list logo
