Re: sitemesh problem in 2.1.8

2009-10-22 Thread Christian Stone
Yes it does (well, it did... my changes to the FreeMarkerPageFilter use the newer SiteMeshFilter). They not only deprecated PageFilter, but deleted the code within it. You do not have access to everything in the decorators with SiteMeshFilter that you do with FreeMarkerPageFilter. For ins

Re: sitemesh problem in 2.1.8

2009-10-22 Thread Dale Newfield
Christian Stone wrote: It isn't a problem if you use the filter bundled with Sitemesh. However, it doesn't work if you use the plugin filters... Does that include com.opensymphony.module.sitemesh.filter.PageFilter ? I use .jsp decorators and use s: tags within them (by putting the sitemesh fi

Re: sitemesh problem in 2.1.8

2009-10-21 Thread Christian Stone
Welcome! By the way, I wrote the developer of Sitemesh 3, and will see about getting a plugin available for the new codebase too. By the way, I am testing a version of the plugin now with a bit more detail in the error reporting (reports URL and query with failed decorator). This is nice

Re: sitemesh problem in 2.1.8

2009-10-21 Thread Musachy Barroso
that was a quick turn around for a patch! thanks musachy On Wed, Oct 21, 2009 at 11:48 AM, Christian Stone wrote: > It isn't a problem if you use the filter bundled with Sitemesh.  However, it > doesn't work if you use the plugin filters... > >     >         sitemesh > > org.apache.struts2.site

Re: sitemesh problem in 2.1.8

2009-10-21 Thread Christian Stone
It isn't a problem if you use the filter bundled with Sitemesh. However, it doesn't work if you use the plugin filters... sitemesh class>org.apache.struts2.sitemesh.FreeMarkerPageFilter You need to use this filter to access the valueStack and other struts 2 ob

Re: sitemesh problem in 2.1.8

2009-10-21 Thread Musachy Barroso
I think this problem shows up when using Freemarker as the result of actions. On Wed, Oct 21, 2009 at 9:00 AM, Dale Newfield wrote: > I use struts 2.1.8 with freemarker 2.3.15 and sitemesh 2.4.2...I haven't > witnessed any problems, but besides the freemarker that struts uses to > expand tags I d

Re: sitemesh problem in 2.1.8

2009-10-21 Thread Christian Stone
Here is a JIRA tag to catch several other bugs (including two marked resolved when they were not). The patch file is included with the ticket! Please let me know how it goes. I have only minimally tested velocity, but have tested the FreeMarker side extensively. I am throwing the plugin

Re: sitemesh problem in 2.1.8

2009-10-21 Thread Dale Newfield
I use struts 2.1.8 with freemarker 2.3.15 and sitemesh 2.4.2...I haven't witnessed any problems, but besides the freemarker that struts uses to expand tags I don't use freemarker in my project. Are there issues that I've not noticed, or do those issues only arise when using freemarker more exe

Re: sitemesh problem in 2.1.8

2009-10-21 Thread Wes Wannemacher
We can't take a jar, create a patch from your modified sources and attach it to the jira issue related to upgrading sitemesh. One of us will take a look at the failing test if you don't figure it out. -Wes On 10/21/09, Christian Stone wrote: > That did it. Still have build failures on the tests

Re: sitemesh problem in 2.1.8

2009-10-21 Thread Christian Stone
That did it.  Still have build failures on the tests though (both xwork and struts 2).On a positive note... I was able to get the struts2-sitemesh pluging working with velocity and freemarker (using 2 filters, 1 for each).Is there a need for a combined filter, such as a velocity and freemarker acce

Re: sitemesh problem in 2.1.8

2009-10-21 Thread Nils-Helge Garli Hegvik
> > [ERROR] BUILD FAILURE > [INFO] > > [INFO] Compilation failure > error: error reading > /Users/xtian/.m2/repository/cglib/cglib-full/2.0.2/cglib-full-

Re: sitemesh problem in 2.1.8

2009-10-21 Thread Christian Stone
Oh, a second issue, this one with struts. I (temporarily) built xwork using the no tests option (mvn - Dmaven.test.skip=true -Pextras,plugins,xwork). Then after the artifacts were in place, I attempted to build struts... and have this issue: [INFO] -

Re: sitemesh problem in 2.1.8

2009-10-20 Thread Christian Stone
So some of the sitemesh 3 code is in the latest drop apparently, and it is marked alpha. So I am doing 2 things... 1. Updating the existing filters code (FreeMarkerPageFilter and VelocityPageFilter) to use the PageFilter.java implementation in SiteMesh 2.3 (note that I presume that I can

Re: sitemesh problem in 2.1.8

2009-10-20 Thread Wes Wannemacher
To help with both the patch creation and your sanity (matching up xwork and struts versions), work off of trunk for both of them. Check out xwork from subversion here - svn co http://svn.opensymphony.com/svn/xwork/trunk xwork and build it - cd xwork ; mvn clean install Then, checkout and build

Re: sitemesh problem in 2.1.8

2009-10-20 Thread Christian Stone
Okay, I'll do it... will take perhaps a day (free time... you know). -- Christian On Oct 20, 2009, at 9:14 PM, Musachy Barroso wrote: I don't think anyone here knows much about the sitemesh codebase, so feel free to take a shot at it and ask for help here if you need it. thanks for reporting

Re: sitemesh problem in 2.1.8

2009-10-20 Thread Musachy Barroso
I don't think anyone here knows much about the sitemesh codebase, so feel free to take a shot at it and ask for help here if you need it. thanks for reporting musachy On Tue, Oct 20, 2009 at 5:37 PM, Christian Stone wrote: > P.S.  Sorry about the posting on the vote thread. > > There is a good d

Re: sitemesh problem in 2.1.8

2009-10-20 Thread Christian Stone
P.S. Sorry about the posting on the vote thread. There is a good discussion about the three possible solutions with the bug (http://issues.apache.org/struts/browse/WW-3275). The easiest (but far from ideal) is to use the solution #2. However, there is a complete rewrite of PageFilter.jav