Re: Roadmap for 2.3

I love annotations for a lot of things, but I also prefer the XML based configuration for actions, interceptors, results, etc. On Tue, Mar 15, 2011 at 12:16 PM, Dave Newton wrote: > There's a tension between large-scale maintainability and small-scale > "hurry!" apps. > > I think it's important

Re: svn commit: r1098322 - /struts/sandbox/trunk/struts2-cdi-plugin/src/main/java/org/apache/struts2/cdi/CdiObjectFactory.java

+1 for slf4j On Tue, May 3, 2011 at 4:23 AM, Rene Gielen wrote: > There is another possible solution / improvement we might want to think > of: Switch our logging system to slf4j facade logging, which addresses - > besides a lot of other cool things - the parameter evaluation issue with > varags

Re: Unit test error for xwork-core in trunk

+1 for merging On Wed, Jun 1, 2011 at 3:55 PM, Johannes Geppert wrote: > +1 > > Johannes > > - > > -- > web: http://www.jgeppert.com > twitter: http://twitter.com/jogep > -- > View this message in context: > http://struts.1045723.n5.nabble.com/Unit-test-error-for-xwork-core-in-tr

OGNL Documentation Location?

With the recent closure of the OpenSymphony site, does anyone happen to know where the full OGNL documentation is kept now?

Struts2 Code Generification

I'd like to volunteer to help generify the Struts2 codebase. From an administrative perspective, what would be the easier way to proceed? Create a single JIRA ticket to attach patches to? Would it be easier to create several smaller patches or a few larger ones?

Struts2/XWork Java 5 or 6?

It looks like DefaultActionProxy (in XWork) was changed on 5/22 to add the following code: @Override public boolean isMethodSpecified() { return methodSpecified; } This method overrides an interface method and the use of the @Override for interface methods is Java 6 only.

Re: Struts2/XWork Java 5 or 6?

to my testing from now on. > > > >> > >> Dave > >> > >> On Sat, Jun 4, 2011 at 7:15 PM, Jason Pyeron wrote: > >> >> -Original Message- > >> >> From: Steven Benitez > >> >> Sen

Re: Struts2 Code Generification

ap is what we use for the session throughout Struts2 and its what the HttpSession uses too. Any objections to this change? On Sun, Jun 5, 2011 at 4:49 AM, Lukasz Lenart wrote: > 2011/6/4 Steven Benitez : > > I'd like to volunteer to help generify the Struts2 codebase. From an &

Re: Unit test error for xwork-core in trunk

Perhaps migrate the package structure to org.apache.struts.xwork and keep it as a separate jar for now to accomodate the non-web users. Then if we opt to merge it in the future it will already have the uniform package structure and still be semi-partitioned in the xwork sub-package. On Sun, Jun 5,

Re: [RT] Struts 3?

* Struts doesn't use Spring for DI. It actually uses an early version of Guice. * There were two annotation-based plugins. One is deprecated, the other is not. Take a look at the convention plugin. There has been some debate over XML vs annotations for action mapping and many of us (including my

Re: [RT] Struts 3?

symphony stuff (like packaging, etc). Again, there has been > some debate over as well. > Anyway, I think that what Christian suggested, is a good starting point. > > Maurizio Cucchiara > > > On 27 August 2011 17:41, Steven Benitez wrote: >> >> >> *  It woul

Re: Deprecate 2.1 version

I agree with deprecating older branches of 2.x and with the proposed versioning scheme. As far as the name goes, that's a tough call. I'd stick with Struts 2 until the API is changed in a major way or we run out of version numbers. Struts 3 is possible, but just pushes the problem into the future.

Re: svn commit: r1185523 - /struts/maven/trunk/pom/pom.xml

Congrats, Maurizio! On Thu, Oct 20, 2011 at 11:16 AM, Maurizio Cucchiara wrote: > Thank to all you guys. > > Twitter :http://www.twitter.com/m_cucchiara > G+ :https://plus.google.com/107903711540963855921 > Linkedin:http://www.linkedin.com/in/mauriziocucchiara > > Maurizio Cucchi

Proposed ObjectFactory API Change

Hey, all: I'd like to propose an API change to ObjectFactory to add a buildTypeConverter method. Currently, type converters are created using the more general buildBean method. My primary motivation for this is that the Google Guice Struts2 plug-in currently fails miserably if you use custom type

Re: Proposed ObjectFactory API Change

e Newton > wrote: > > > I'd also like to see a less hard-coded impl of the default type > converters. > > > > > > On Fri, Oct 21, 2011 at 9:37 PM, Steven Benitez < > steven.beni...@gmail.com>wrote: > > > >> Hey, all: > >> > &g

Re: Lead ?

S2 can already achieve restful URLs easily using either the rest plug-in or the named variable pattern matcher. What specifically are you asking for? On Mon, Nov 28, 2011 at 3:42 PM, Frans Thamura wrote: > S3 make it rest programming.. may be. > > Just idea > On Nov 29, 2011 3:38 AM, "Łu

Re: Deprecate 2.1 version

I agree with Dave's points as well as the need to discuss type conversion going forward. On Tue, Nov 29, 2011 at 12:34 PM, Dave Newton wrote: > +1, I'm good with branching now. > > On Tue, Nov 29, 2011 at 12:32 PM, Maurizio Cucchiara > wrote: > > I'd also prearrange the update of OGNL to common

Re: [jira] [Created] (WW-3714) Rename org.opensymphony.xwork2 to org.apache.struts2.xwork2

org.apache.struts2.xwork; keep it a separate JAR, but part of the S2 project (as it currently is). Since renaming the package is a breaking change, do we want to make any other API changes to XWork now or are we fine with just changing the package now and making (potential) API changes later? 201

Re: The Master Plan

This sounds good to me. I'm glad to chip in and contribute, as well. 2011/12/6 Łukasz Lenart > Hello all, > For the last few days I was cleaning up JIRA and moved some of > theissues to 3.x or future, some of them were already solved and so > on.You can check the results here [1] > There is stil

Re: snapshot on S2 homepage?

It should probably reference the last release (not snapshot). 2011/12/6 Łukasz Lenart > 2011/12/5 Dave Newton : > > http://struts.apache.org/2.x/ > > > > Lists the S2 download as 2.3.1-SNAPSHOT; is this on purpose? > > Is it a problem ? It's a site effect of using variables in the template, > eg

Re: S3 -> plugins -> for action

I don't know that a Play style module system would work well for Struts2. Perhaps a directory of plugins on the site like Play offers? I really like the existing plug-in system for Struts2 though. On Thursday, December 15, 2011, Dave Newton wrote: > Yeah, I'm actually asking you, rather than mak

Re: Generic Question about Struts2

I used to be active there, but I've been busy lately. Besides, Dave is a Titan on there. :) On Friday, December 30, 2011, Umesh Awasthi wrote: > Hi All, > > I am asking this question specifically in the dev list since i believe that > this is the best platform which can answer my question. > Work

Re: Struts 2: Non Submittable button

Just use HTML? On Mon, Feb 27, 2012 at 10:59 PM, Umesh Awasthi wrote: > It work as a submit button and will associate the form with your button.If > you want to use simple button, i suggest you to go with > > > As a side note the best place to ask such question is user mailing list <* > u...@st

Re: FYI

The advisory indicates this affects Atlassian's build of xwork. Does this also affect the official build of xwork? I'm guessing not. On Mon, Aug 5, 2013 at 5:23 PM, Martin Gainty wrote: > so..to mitigate > > struts-2.0.9 + > > ? > Martin > > > > > > Date: Mon, 5 Aug 2013 14:37:24 -0400 > > Subj

Re: JSP tag examples v. wiki snippets and Javadocs

Yes please! I read Javadoc directly in source and that stuff makes it cluttered and overly verbose. On Thu, Aug 8, 2013 at 2:55 AM, Lukasz Lenart wrote: > 2013/8/6 Dave Newton : > > No, I mean the JSP mixed into the tag Javadocs for all the examples. > > You mean this > > * > *

Spring Plugin Documentation

The Spring plugin docs don't indicate that "no" is a valid setting for "struts.objectFactory.spring.autoWire". http://struts.apache.org/release/2.3.x/docs/spring-plugin.html I'm not sure what process creates these docs, where the source code for the docs is at, how I could fix this and create a p

Re: Spring Plugin Documentation

Never mind, this looks to be driven by Confluence and I don't have permission to make changes. Can someone update this document accordingly? On Sat, Aug 10, 2013 at 1:35 AM, Steven Benitez wrote: > The Spring plugin docs don't indicate that "no"

Re: Spring Plugin Documentation

http://struts.apache.org/release/2.3.x/docs/spring-plugin.html still appears as it did before this email. Is there a delay before changes are reflected on the page? On Sat, Aug 10, 2013 at 5:15 AM, Rene Gielen wrote: > Am 10.08.13 07:42, schrieb Steven Benitez: > > Never mind, this lo

Re: Struts 1 migration to struts 2

>> 1) Does this security issue exist in struts 1 (1.2.9 specifically)? No. The recent exploit that was fixed in 2.3.15.1 was Struts 2 specific. >> 2) Is there migration documentation or advice that is available regarding moving from struts 1 to struts 2? Unsure. Struts 1 and Struts 2 are entirel

Re: Removing links from the main page

This sounds good to me. A more up to date site would be good. On Monday, September 2, 2013, Christian Grobmeier wrote: > Hi folks, > > at our main page are the following links: > > http://struts.SourceForge.net/ -> pretty outdated, last update from > 2006 it seems > > http://people.apache.org/~ru

Re: Documentation in general (was: Fwd: Re: Removing links from the main page)

I'm not sure that this would be a good fit for Struts2, but I'll throw the idea out there anyway. On my current project, we needed a way to have an internal documentation site and I am using Jekyll, Github's open source content generator (the same engine that powers Github Pages). The actual docum

Re: Something to think about maybe

I know it's the plan to move to Git, but that can't happen soon enough. Subversion is like a big cloud of sadness. On the bright side, it would be great to get a concerted effort at creating new documentation. I'd be happy to help. On Wed, Sep 4, 2013 at 1:35 PM, Paul Benedict wrote: > Christi

Re: Doubting OGNL

I prefer EL over OGNL, but the problem with removing OGNL in Struts 3 would be that there isn't currently (that I am aware of) a way to use EL within Velocity, FreeMarker, Thymleaf, etc. Not everyone uses JSP. Someone could probably create ElValueStack and ElValueStackFactory implementations. OGNL

Re: Doubting OGNL

I support EL3 over OGNL, but I realize this will be an uphill battle. I've used Struts2/Webwork with EL for years and I can continue to do that on my own. On Thu, Sep 5, 2013 at 3:22 PM, Lukasz Lenart wrote: > 2013/9/5 Christian Grobmeier : > > Am 05.09.13 20:43, schrieb Lukasz Lenart: > >> Guys

Re: Svn to Git migration

I use gitflow in my day job and its a great workflow. +1 On Wednesday, September 11, 2013, Lukasz Lenart wrote: > Hi, > > I'd like to start discussion about the migration process - there are > few things we must clarify, at least: > - Git structure > - development flow > > I think we should have

Re: Svn to Git migration

Use tags for all released versions, rather than keeping branches for them. As for Struts 2.5 or 3.0, I'd probably use feature branches for those. On Wed, Sep 11, 2013 at 10:19 AM, Christian Grobmeier wrote: > Am 11.09.13 11:24, schrieb Lukasz Lenart: > > Hi, > > > > I'd like to start discussion

Re: Proposal: "required" attribute changes (related to WW-4188)

I already updated to requiredLabel, so I vote we stick with that. :) Besides, requiredLabel actually makes more sense, since that's all it does. You could invert the logic you proposed so that if a required attribute is detected with a value of anything but "false", you consider that to trigger re

Re: Proposal: "required" attribute changes (related to WW-4188)

not-blank or null > 3) For the front-end to enforce that the field is filled out via html5 > 'required="required"' output, possibly dependent on theme > > > On Wed, Sep 11, 2013 at 12:02 PM, Steven Benitez > >wrote: > > > I already updated to require

Re: Strict DMI

Why not just have an @ActionMethod annotation? If its on the action method, you can invoke it, if not, you can't. The global config option for allowed methods sounds reasonable (e.g., execute, input, etc.) On Thu, Oct 3, 2013 at 11:21 AM, Lukasz Lenart wrote: > Hi, > > I'm working on extending

Re: Strict DMI

; On Fri, Oct 4, 2013 at 4:31 AM, Lukasz Lenart >wrote: > > > 2013/10/3 Steven Benitez : > > > Why not just have an @ActionMethod annotation? If its on the action > > method, > > > you can invoke it, if not, you can't. The global config option for > >

Re: Security judges

Can you clarify how this would affect custom action mappers? On Wed, Oct 9, 2013 at 4:05 PM, Lukasz Lenart wrote: > Hi, > > Another idea is to add some logic to handle security aspects of the > framework in one place - it would be some kind of stack of interfaces > which will try to cleanup inco

Re: Security judges

Yeah, I'm not a fan of the Judge name either. Guard is better, but I'm not sure if it's best. What would the API look like? On Thursday, October 10, 2013, Lukasz Lenart wrote: > 2013/10/10 Lukasz Lenart >: > > 2013/10/10 Paul Benedict >: > >> I like the idea except the Judge name. I think Authent

Re: InterceptorListeners

Why not just create an interceptor and run it before or after the interceptor you need? What specific use case does this address? On Tuesday, November 5, 2013, Ali Akhtar wrote: > It could be useful, especially for the interceptors in the default stack. > > > On Tue, Nov 5, 2013 at 1:58 PM, Lukas

Re: InterceptorListeners

Tue, Nov 5, 2013 at 4:11 AM, Lukasz Lenart wrote: > 2013/11/5 Steven Benitez : > > Why not just create an interceptor and run it before or after the > > interceptor you need? What specific use case does this address? > > You are perfectly right, it's the prefer way to achieve t

Re: InterceptorListeners

API. > > > > > > > > Thanks > > Umesh > > Sent from BlackBerry® on Airtel > > > > -Original Message- > > From: Steven Benitez > > Date: Tue, 5 Nov 2013 09:00:14 > > To: Struts Developers List > > Reply-To: "Struts

Re: Git flow

I vote for gitflow. It's simple and straight forward. On Tuesday, January 28, 2014, Rene Gielen wrote: > Am 28.01.14 12:19, schrieb Lukasz Lenart: > > I don't think we need git-flow - we don't have huge development team, > > there is (almost) no situation when we work together on some > > issue/

Re: Less boilerplate in code

I don't get why we wouldn't use slf4j. On Thursday, May 15, 2014, Lukasz Lenart wrote: > 2014-05-14 21:51 GMT+02:00 Chris Pratt > >: > > Yes, we could use Onyx's interface mechanism, but I think SLF4j's is > > probably more stable and definitely more supported. So I'd probably > > recommend th

Re: Struts 3 request/response processing

Wouldn't the action and method to select be up to the ActionMapper itself? What is the use case here? On Tuesday, November 25, 2014, Paul Benedict wrote: > I added this to the wiki [1] and would like this to have a general > discussion. > > S1 and S2 have different infrastructure to process a re

Re: Few ideas related to Struts 3

>> I much prefer a strong decoupling between layers, and accessing Servlet spec artifacts is a smell. Decoupling between layers is definitely a good thing, but wouldn't the servlet API and Struts actions both be considered the controller layer? Assuming so, why do you think accessing the Servlet A