Re: upgrade_tests 7 FAIL when working directory has a + character

2013-09-05 Thread Philip Martin
in libsvn_subr/path.c the table says that '+' should not be % encoded. The problem is that the Python testsuite uses urllib.pathname2url(self.repo_dir) and that has different ideas, it does % encode '+'. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: upgrade_tests 7 FAIL when working directory has a + character

2013-09-05 Thread Philip Martin
Philip Martin philip.mar...@wandisco.com writes: Daniel Shahaf danie...@apache.org writes: On Wed, Sep 04, 2013 at 11:50:49PM -0400, James McCoy wrote: This was with svn 1.7.9. I haven't had a chance to test newer versions, but looking through the code in trunk, it looks like it would

Re: SVN update of child ignores files if preceded by update --depth immediates

2013-09-05 Thread Philip Martin
/object2/* will work in parallel. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: SVN update of child ignores files if preceded by update --depth immediates

2013-09-05 Thread Philip Martin
/A. The result is that both 1.6 and 1.8 allow svn up wc/A/B svn up wc/X/Y in parallel, but only 1.6 allows svn up wc/A svn up wc/X/Y in parallel, and neither allows svn up wc/A svn up wc/X in parallel. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: Move Tracking in the Update Editor

2013-09-04 Thread Philip Martin
Julian Foad julianf...@btopenworld.com writes: Julian Foad wrote: Philip Martin wrote: [...] I can imagine an enhanced Ev1 editor drive that does    move away A    move to C (original A)    del A    move away B    move to C (original B)    del B    add C The deletes lead

javahl warnings

2013-09-03 Thread Philip Martin
../src/subversion/bindings/javahl/native/CreateJ.cpp:861:30: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] ../src/subversion/bindings/javahl/native/JNIUtil.cpp:665:36: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Re: svn: E000032: Can't write to connection: Broken pipe

2013-09-02 Thread Philip Martin
Victor Sudakov suda...@sibptus.tomsk.ru writes: Philip Martin wrote: Setting max-encryption = 0 really fixes the problem. Am I not supposed to use any encryption or what? It is supposed to work. With max-encryption = 0, is at least my Kerberos key encrypted (not sent in the clear

Re: svn: E000032: Can't write to connection: Broken pipe

2013-08-30 Thread Philip Martin
be the cause of the problem? Google suggests that encoded packet size too big is a SASL error. Does you conf/svnserve.conf on the server have use-sasl = true? If so what are the min/max-enryption settings? -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: svn: E000032: Can't write to connection: Broken pipe

2013-08-30 Thread Philip Martin
Victor Sudakov suda...@sibptus.tomsk.ru writes: Philip Martin wrote: On the host running svnserve there is the following in syslog: Aug 30 09:04:50 auth.err relay svnserve: encoded packet size too big (4156 4096) Aug 30 09:05:03 auth.err relay svnserve: encoded packet size too big

Re: svn: E000032: Can't write to connection: Broken pipe

2013-08-30 Thread Philip Martin
to 16384 on the client and the server. It's not clear to me why the SASL GSSAPI module is using 4096. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: Move Tracking in the Update Editor

2013-08-30 Thread Philip Martin
/tree-conflicts on C. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: svn commit: r1099094 - /subversion/trunk/subversion/libsvn_ra_serf/commit.c

2013-08-28 Thread Philip Martin
svn_io_file_del_on_close so we don't appear to have a blanket ban on using it. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: 1.8.3 up for testing/signing

2013-08-23 Thread Philip Martin
/UDcFyNc8j5T6qoor4e8GAgsDc28wZg5nI0DYSJv91Tfh 535MKQ7sj/cQZn9lDCWPBVSWEgjnib6UigorP01oncUaa0luccdGN2Efby4X9HGO fvYA8ptBoPCEmpCRdQbxQUiSm/p3nWzpny/NeIWw+Z0JqhXHcXslsD0lXuyC8NI= =Wif9 -END PGP SIGNATURE- -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: Provide a svn log -v with the option to filter out changeset's

2013-08-23 Thread Philip Martin
or server-side? We would probably want a client-side implementation so that this feature works with old servers. Would we also have a server-side implementation so that newer servers can avoid transferring data that the client will discard? -- Philip Martin | Subversion Committer WANdisco // *Non

Re: 1.7.13 up for testing/signing

2013-08-23 Thread Philip Martin
3ce6TwHbYS3/Ti4sqaEUozY5l735DAuUgoc1wuQhjMGmwhbdwQ5pTpe5Fyxvxzd8 dVBTW+5e9cY4A1bT5WFN/fZHDcmxRRmQjjx1itsyLm0XZM9dUK/IIw40n9MZnC5q 4f3j3RXkh3RoaJQG0wFi5p12ecHcAXzFO+7z2OWw9a0dhyOYCDMZM6rTj/usAOg= =eKaW -END PGP SIGNATURE- -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: [PATCH] add 'svn:use-commit-times' property

2013-08-22 Thread Philip Martin
to be unchanged when the property is removed. Is setting it to the current time useful behaviour? -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: Assertion in svn_uri_is_canonical

2013-08-22 Thread Philip Martin
svn_uri_is_canonical to allow a hostname '.'? -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: Assertion in svn_uri_is_canonical

2013-08-22 Thread Philip Martin
Philip Martin philip.mar...@wandisco.com writes: What is the canonical form of this? scheme://./ Should we drop '.' to give: scheme:/// or do we have to retain it as scheme://./ and change svn_uri_is_canonical to allow a hostname '.'? Another problem is scheme

Re: 1.8.2 up for testing/signing

2013-08-21 Thread Philip Martin
+tnO5MjAaK1gpBs182b2KCS9MPppczkp194gQNF1uyl71 wCJr0/5bQXGhgD+MrPB1LYsfRyTabPlIDEvAh6L8GQ0miD34Grp44O+cOJOUedkT ObtmSBzQyr43SlmR8UZLms+DbFJ1Atr7v1FAk/quRRfU1JgyIzyvEm0AK6H212c= =H9xA -END PGP SIGNATURE- -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: 1.7.12 up for testing/signing

2013-08-21 Thread Philip Martin
wC3lC1O36vuPF2JozatckNlGA5X0iNtPotYumkK1zpGuzp9dNiFFxTGCgLNLJVC5 f5CS7GhZx9QDZV07TGc9dAU1tYEU8wSgikH6AOxTjM2LnL2LBj0siGKa2Ojzy5P2 o5jc2UGV8SJJRGtCHtqcYpyVgICpB7yWOOntT6MkjEIk5kNvO5AMYRd8woGhxCw= =FyqS -END PGP SIGNATURE- -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: svnsync crashes on a huge commit

2013-08-16 Thread Philip Martin
(*info)); + + info-pool = pool; info-parent = parser-state-private; info-baton = NULL; info-stream = NULL; I've tested this by running syncs under valgrind, including the first 75 revisions of the chromium repository, and it doesn't trigger any warnings. -- Philip Martin

Re: [PATCH] Add serf library version information to svn --version

2013-08-15 Thread Philip Martin
= description_buf; + } + + return description; } /* Implements svn_ra__vtable_t.get_schemes(). */ -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: [PATCH] Add serf library version information to svn --version

2013-08-15 Thread Philip Martin
Ivan Zhakov i...@visualsvn.com writes: Good point. I'll fix it in separate commit. What do you think about patch itself? Is there any reason for the static optimisation? Does performance matter? Why not simply format each time? -- Philip Martin | Subversion Committer WANdisco // *Non-Stop

Re: [PATCH] Add serf library version information to svn --version

2013-08-15 Thread Philip Martin
Ivan Zhakov i...@visualsvn.com writes: On Thu, Aug 15, 2013 at 4:14 PM, Philip Martin phi...@codematters.co.uk wrote: Philip Martin philip.mar...@wandisco.com writes: Ivan Zhakov i...@visualsvn.com writes: Good point. I'll fix it in separate commit. What do you think about patch itself

Re: 1.7.12 1.8.2

2013-08-15 Thread Philip Martin
Ivan Zhakov i...@visualsvn.com writes: On Tue, Aug 13, 2013 at 5:33 PM, Philip Martin philip.mar...@wandisco.com wrote: Ben Reser b...@reser.org writes: I plan to roll tarballs for both next Monday (August 19th). Please finish voting for any issues by Monday morning US/Pacific. 1.8.x has

Ev2 alter_directory deltas

2013-08-14 Thread Philip Martin
Another problem with Ev2. Consider a cheap copy: svn cp ^/trunk ^/branches/foo With Ev1 this commit sends only a small amount of data across the wire. This is true even as the number of branches gets large. In the past there was a backend big directory storage problem, but that was solved

Re: Ev2 alter_directory deltas

2013-08-14 Thread Philip Martin
Julian Foad julianf...@btopenworld.com writes: Philip Martin wrote: [Conceivably the RA implementation of the current Ev2 API could deltify the list sent back by caching the list received but that's horrible and doesn't solve the problem of getting the list in the first place.] Why

Re: Ev2 using move-away and move-here

2013-08-14 Thread Philip Martin
update receiver it wants to record incomplete for adds but probably does nothing for replaces, it may not even do anything for deletes preferring to leave it to the delete call. 2. mv-away A (id=“original A”) 3. add-directory A (children={B}) 4. mv-here A/B (id=“original A”) -- Philip

Re: Ev2 using move-away and move-here

2013-08-14 Thread Philip Martin
path: 1. alter-dir A (children={...}) 2. mv-away A (id=...) 3. copy A (src=...) 4. alter-dir A (children={...}) [...] -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: Ev2 using move-away and move-here

2013-08-14 Thread Philip Martin
of the copy to make things unique either as that could be copied more than once. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: fsfs-improvements branch complete

2013-08-13 Thread Philip Martin
of it. If there are no objections, I will merge the code in the week of Aug 26th. I've read through all the commits and I'm happy for it to be merged. -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data

Re: 1.7.12 1.8.2

2013-08-13 Thread Philip Martin
that hasn't been proposed for 1.8.x. There may be a smaller pool fix that could be applied to 1.8.x but so such change has been identified. Is the parser rewrite suitable for 1.8.2? -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data

Re: [PATCH] speed up svn_repos_authz_check_access

2013-08-11 Thread Philip Martin
Roderich Schupp roderich.sch...@gmail.com writes: On Friday, August 9, 2013, Philip Martin wrote: We could cache the results of authz_parse_line. That would limit the cache size as it would only grow to the number of sections in the file. Also authz_parse_line is often the expensive bit

Re: SVN 1.7/1.8 commit after delete performance issue

2013-08-09 Thread Philip Martin
Alexander Lüders a...@entimo.de writes: How to proceed now? Shall I file a bug report? It's already fixed on trunk and I've just proposed it for 1.8. -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data

Re: [PATCH] speed up svn_repos_authz_check_access

2013-08-09 Thread Philip Martin
(... authz_parse_line ...) store section in baton. Then in authz_parse_line use the section from the baton to check the cache and return the cached result if possible, if not do the current processing and populate the cache. -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data

Re: fsfs-improvements branch complete

2013-08-08 Thread Philip Martin
is not necessary. Lots of FS functions are single pool because they were defined before we started using two pools. What should new functions do? -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data

Re: SVN update of child ignores files if preceded by update --depth immediates

2013-08-08 Thread Philip Martin
shows 22 pm wc 22 pm wc/D2 22 pm wc/D1 21 pm wc/D1/f1 So this is a bug in 1.6 that is fixed in 1.7 and 1.8. -- Philip Martin | Subversion Committer WANdisco

Re: [PATCH] speed up svn_repos_authz_check_access

2013-08-07 Thread Philip Martin
= authz_get_tree_access(authz, repos_name, path, user, required_access, pool); return SVN_NO_ERROR; -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data

Re: svn commit: r1507589 - in /subversion/trunk/subversion: libsvn_ra_serf/commit.c tests/cmdline/commit_tests.py

2013-08-07 Thread Philip Martin
(relpath) == strlen(dir-relpath) + 1) || strlen(parent-relpath) == 0)); -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data

Re: xml output changed - relative paths now appearing?

2013-08-07 Thread Philip Martin
that this is an issue - should I be submitting an issue formally- consider me new to this development model and unsure of what is the next step on this. It's fixed on trunk: http://subversion.tigris.org/issues/show_bug.cgi?id=4398 -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data

Re: svn commit: r1509917 [1/2] - in /subversion/branches/fsfs-improvements: ./ build/generator/ subversion/ subversion/include/ subversion/include/private/ subversion/libsvn_fs/ subversion/libsvn_fs_b

2013-08-06 Thread Philip Martin
, but that branch has root_vtable_t.dir_optimal_order so this code in libsvn_fsx/tree.c is wrong on the fsfs-improvements branch: x_dir_entries, /* x_dir_optimal_order,*/ x_make_dir, I think it should be un-commented. -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data

Re: [PATCH] add 'svn:use-commit-times' property

2013-08-01 Thread Philip Martin
Daniel Shahaf danie...@elego.de writes: Philip Martin wrote on Wed, Jul 31, 2013 at 15:09:10 +0100: Perhaps this property should be inheritable? Then it could be set on a directory and apply to the whole tree? Even if yes, can't inheritability be implemented in a future patch? i.e., maybe

Re: [PATCH] add 'svn:use-commit-times' property

2013-07-31 Thread Philip Martin
delete a property that isn't set, and it can't set it as that enables use-commit-times. How would we make inheriting work? Perhaps another property svn:no-commit-times? -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data

Re: Unexplained Corrupt representation errors with 1.8.1

2013-07-31 Thread Philip Martin
path with the same UUID. If that happens I think apache may have been using the in-memory cache associated with the old repository when accessing the new repository. -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data

Re: Unexplained Corrupt representation errors with 1.8.1

2013-07-31 Thread Philip Martin
Mark Phippard markp...@gmail.com writes: I have sent an email asking them to try stopping and starting Apache after all this. Maybe it is as simple as that? It definitely happens. I don't know whether it applies to the problem reported by Daniel. -- Philip Martin | Subversion Committer

Re: SVN 1.7/1.8 commit after delete performance issue

2013-07-30 Thread Philip Martin
with svn up wc/node when the update removes 'node' although this case it's only an inefficiency not a regression. -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data

Re: SVN 1.7/1.8 commit after delete performance issue

2013-07-30 Thread Philip Martin
+wcroot_abspath = NULL; + + svn_io_sleep_for_timestamps(wcroot_abspath, pool); +} + return svn_error_trace(err); } -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data

Re: SVN 1.7/1.8 commit after delete performance issue

2013-07-30 Thread Philip Martin
Philip Martin philip.mar...@wandisco.com writes: Index: subversion/libsvn_client/commit.c === --- subversion/libsvn_client/commit.c (revision 1508338) +++ subversion/libsvn_client/commit.c (working copy) @@ -1027,8 +1027,14

Re: [PATCH] Fix the out-of-bounds memory access in the 'test_string_matching' test

2013-07-29 Thread Philip Martin
access. Patch by: Evgeny Kotkov evgeny.kotkov{_AT_}visualsvn.com Committed in r1507993. Thanks! -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data

Re: fsfs-improvements branch complete

2013-07-29 Thread Philip Martin
as trunk. -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data

Re: fsfs-improvements branch complete

2013-07-29 Thread Philip Martin
Philip Martin philip.mar...@wandisco.com writes: Stefan Fuhrmann stefan.fuhrm...@wandisco.com writes: Thanks for spotting fixing this! The extra _ was a recent addition to make output match /trunk. Another difference: db/txn-current produced by the branch does not have a trailing \n

Re: SVN 1.7/1.8 commit after delete performance issue

2013-07-29 Thread Philip Martin
still exists in the working copy, while in 1.8 the path is the deleted file itself. Passing the deleted file means that the path based optimisations are not available in 1.7/1.8 and so svn_io_sleep_for_timestamps sleeps for longer. -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data

Re: Problem with Perl bindings?

2013-07-26 Thread Philip Martin
the change, resolve the conflicts and then nominate the branches. The conflict has to be resolved at some point and doing it in advance means a) it's clear what change is being proposed and b) it can be merged automatically. -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data

Re: fsfs-improvements branch complete

2013-07-26 Thread Philip Martin
5d9474c0309b7ca09a182d888f73b37a8fe1362c 0-0/_0 cpath: /g copyroot: 0 / The branch uniquifiers aren't unique. I see the branch code writing different uniqifiers into the transaction files but _0 values appear in the revision file. -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data

Re: fsfs-improvements branch complete

2013-07-26 Thread Philip Martin
Philip Martin philip.mar...@wandisco.com writes: The branch uniquifiers aren't unique. I see the branch code writing different uniqifiers into the transaction files but _0 values appear in the revision file. The code in svn_fs_fs__parse_representation doesn't seem to parse the uniqifier

Re: [PATCH] add 'svn:use-commit-times' property

2013-07-26 Thread Philip Martin
for the standard testsuite, see subversion/tests/cmdline/prop_tests.py. -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data

Re: 'svnadmin dump' is garbled on Japanese version of Windows.

2013-07-25 Thread Philip Martin
is svn_cmdline_cstring_from_utf8 failing? -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data

Re: Problem with Perl bindings?

2013-07-25 Thread Philip Martin
hash; -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data

Re: Problem with Perl bindings?

2013-07-25 Thread Philip Martin
they may contain NUL bytes). But AFAIK Perl also guarantees that there is always a trailing NUL byte at pointer+len, so using strlen(key) should be safe here. apr_pstrmemdup guarantees a null byte. -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data

Re: 'svnadmin dump' is garbled on Japanese version of Windows.

2013-07-25 Thread Philip Martin
Masaru Tsuchiyama m.tma...@gmail.com writes: Is that UTF-8? It's certainly UTF-8 in the email. No. It is Shift JIS. That is the problem. That string should be UTF-8. How does it get to be shift-JIS? The translations should be in UTF-8. Are you using old i18l tools? -- Philip Martin

Re: 'svnadmin dump' is garbled on Japanese version of Windows.

2013-07-25 Thread Philip Martin
Philip Martin philip.mar...@wandisco.com writes: Masaru Tsuchiyama m.tma...@gmail.com writes: Is that UTF-8? It's certainly UTF-8 in the email. No. It is Shift JIS. That is the problem. That string should be UTF-8. How does it get to be shift-JIS? The translations should be in UTF-8

Re: 'svnadmin dump' is garbled on Japanese version of Windows.

2013-07-25 Thread Philip Martin
Philip Martin phi...@codematters.co.uk writes: Ah! I see. There are two UTF-8 to native conversions. It looks like I did get r1485650 wrong. I can reproduce it on my Debian box. First do: dpkg-reconfigure locales and ensure the the ja_JP locales are produced. Then start a shift-JIS

Re: Trouble compiling using --with-serf=/home/myUserName/local

2013-07-23 Thread Philip Martin
a small test executable and that build is probably failing. If you look in config.log you should see the reason for the failure. configure: serf library configuration via pkg-config checking for serf-2 library... no checking for serf-1 library... no checking was serf enabled... no -- Philip

Re: Trouble compiling using --with-serf=/home/myUserName/local

2013-07-23 Thread Philip Martin
); fprintf(stderr, %s:%d, buf, sa-port); } +#endif fprintf(stderr, ] ); } It's only used in a rarely seen error message. -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data

Re: svnsync crashes on a huge commit

2013-07-19 Thread Philip Martin
Philip Martin philip.mar...@wandisco.com writes: I see those values with 1.8.x but the problem appears to be fixed on trunk where the memory use is remains more or less constant at 100MB virtual, 25MB resident. It's r1499863, the rewrite of ra_serf's replay code, that fixes the memory use

Re: svnsync crashes on a huge commit

2013-07-18 Thread Philip Martin
563 revisions. This was a sync to a local harddisk. -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data

Re: svnsync crashes on a huge commit

2013-07-18 Thread Philip Martin
I see those values with 1.8.x but the problem appears to be fixed on trunk where the memory use is remains more or less constant at 100MB virtual, 25MB resident. Philip Martin philip.mar...@wandisco.com writes: I see smaller numbers on my 64-bit Linux box. r18 is the worst at about 550MB

Re: 1.8.1 up for signing/testing

2013-07-17 Thread Philip Martin
/QgkdrjrHM6j9Tq7NbYRwsahWnMopKGi5hIve8 lB9Ruh9afZqWC3dedYnh0SXgDmozsPk8h54CKRC8RPftBxmXLS5snYPbcAuKcYA3 PKRA2UDD6j1fWyLTnJfqB3NYW0Jp8r9lOxrpjc5XKBMtUO2ojJ3fzp85uBsOQD4= =9rk6 -END PGP SIGNATURE- -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data www.wandisco.com

Re: 1.7.11 up for signing/testing

2013-07-17 Thread Philip Martin
+lJqtQL76SAuqW6bPnLgZl1S4XGpO0ziXg5MXiFyYh8n0LYXHBq I3ppNIbGNA1SrYJpYoMlWXVJMZtZLMD4x+2JRMlxX7sKsW9RcKZEu4jf0X1Vso+d 091xAojEgRnx/Fbe8F6nOV9dfTx4aYW/XGIIqZl5GesDhJH31HUr+0F/mpJLFXxT OBGlkWDDYxoqjxgvHN8wm1vOFE7m7dGilVe4KGJx99uXP3MtZrjH2mj2yPRyBE8= =Y5Z8 -END PGP SIGNATURE- -- Philip Martin | Subversion Committer WANdisco | Non-Stop

Re: xml output changed - relative paths now appearing?

2013-07-16 Thread Philip Martin
[CC to dev] Alexander Haley aha...@meditech.com writes: On Mon, Jul 15, 2013 at 5:21 PM, Philip Martin philip.mar...@wandisco.comwrote: I could not get this to happen on Linux. Are you using the same path in the checkout and status commands? Can you provide a complete recipe? Something

Re: svn commit: r1503010 - /subversion/trunk/subversion/libsvn_subr/utf.c

2013-07-15 Thread Philip Martin
, sizeof(apr_strerr)); + return svn_error_create(apr_err, + svn_error_create(apr_err, NULL, apr_strerr), + errstr); } /* Allocate and initialize the node. */ -- Philip Martin | Subversion Committer WANdisco | Non-Stop

Re: Tri-state for http-detect-chunking config option

2013-07-12 Thread Philip Martin
. Is there any difference? -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data www.wandisco.com

Re: svn commit: r1495419 - in /subversion/trunk/subversion/libsvn_ra_serf: options.c ra_serf.h serf.c util.c

2013-07-10 Thread Philip Martin
pipelined requests as there may be outstanding requests when the 411 is received. I posted a patch that keeps track of outstanding requests and retries, it works in lots of cases but won't work in all cases. -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data www.wandisco.com

Re: svn commit: r1499747 - /subversion/trunk/subversion/tests/libsvn_wc/op-depth-test.c

2013-07-09 Thread Philip Martin
path. I probably should have made 2 commits. -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data www.wandisco.com

Re: checkout_tests.py 12 (checkout_peg_rev_date) breaks on fast setups

2013-07-09 Thread Philip Martin
is better than testing only the equal value. -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data www.wandisco.com

Re: svn commit: r1501038 - /subversion/branches/1.8.x/STATUS

2013-07-09 Thread Philip Martin
. We can still notify to suggest that the user sets the config option to enable the OPTIONS probe. -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data www.wandisco.com

Re: svn commit: r1495419 - in /subversion/trunk/subversion/libsvn_ra_serf: options.c ra_serf.h serf.c util.c

2013-07-03 Thread Philip Martin
, - handler-location), - err)); + return SVN_NO_ERROR; } + SVN_ERR(svn_ra_serf__error_on_status(handler-sline, + handler-path, + handler-location)); return SVN_NO_ERROR; } -- Philip Martin

Re: Ev2 symlinks

2013-06-28 Thread Philip Martin
Daniel Shahaf danie...@elego.de writes: (pop quiz: who ran 'make check' with 1.7 client and 1.8 server, or 1.8 client and 1.7 server, during the soak?). I did it shortly before the soak, I raised issue 4348 :) -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data www.wandisco.com

Re: svn commit: r1495419 - in /subversion/trunk/subversion/libsvn_ra_serf: options.c ra_serf.h serf.c util.c

2013-06-28 Thread Philip Martin
Philip Martin philip.mar...@wandisco.com writes: Suppose serf were to keep track of the number of outstanding requests (it may already do that I haven't checked). Then if the number of outstanding requests is zero when the 411 is received the downgrade to HTTP/1.0 will be OK. Lots of client

Re: svn commit: r1495419 - in /subversion/trunk/subversion/libsvn_ra_serf: options.c ra_serf.h serf.c util.c

2013-06-28 Thread Philip Martin
Bert Huijben b...@qqmail.nl writes: -Original Message- From: Philip Martin [mailto:philip.mar...@wandisco.com] Sent: vrijdag 28 juni 2013 17:18 To: Ivan Zhakov Cc: Greg Stein; dev@subversion.apache.org Subject: Re: svn commit: r1495419 - in /subversion/trunk/subversion

Re: svn commit: r1495419 - in /subversion/trunk/subversion/libsvn_ra_serf: options.c ra_serf.h serf.c util.c

2013-06-28 Thread Philip Martin
. Don't you need r1497551? I have that. If I configure nginx with gzip = no then lots of the regression tests now pass when run through nginx with my patch. -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data www.wandisco.com

Re: svn commit: r1495419 - in /subversion/trunk/subversion/libsvn_ra_serf: options.c ra_serf.h serf.c util.c

2013-06-28 Thread Philip Martin
Philip Martin philip.mar...@wandisco.com writes: Lieven Govaerts svn...@mobsol.be writes: It seems to be connected to mod_deflate. My server was loading mod_deflate (but not setting up any filters) and the import works with the client setting http-compression = no but fails

Re: Ev2 as a move-aware editor

2013-06-27 Thread Philip Martin
Philip Martin philip.mar...@wandisco.com writes: Philip Martin philip.mar...@wandisco.com writes: I can't see any way to do the 9-node change without using temporaries. I think we can reduce the 9 nodes to 6 and still see the problem: Even 3 nodes is a problem. Start with A, A/B and A/B/C

Re: Ev2 as a move-aware editor

2013-06-27 Thread Philip Martin
to enable the moves to occur. I suppose different receivers could do different things. The driver knows when mv(A,B) is part of a rotate and when it is just a move. Perhaps it should distinguish the two and communicate this so the receiver knows as well? -- Philip Martin | Subversion Committer

Re: Ev2 as a move-aware editor

2013-06-26 Thread Philip Martin
that the server can combine multiple revisions. The two algorithms are essentially the same. -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data www.wandisco.com

Re: svn commit: r1496127 - /subversion/trunk/subversion/tests/cmdline/checkout_tests.py

2013-06-26 Thread Philip Martin
the sleep to 2.1s and continue to use whole second manipulations. I'm a bit reluctant to do that since the the sleep is already the main contribution to runtime of checkout_tests.py on my machine. -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data www.wandisco.com

Re: Ev2 as a move-aware editor

2013-06-26 Thread Philip Martin
Daniel Shahaf danie...@elego.de writes: Philip Martin wrote on Wed, Jun 26, 2013 at 09:30:42 +0100: Greg Stein gst...@gmail.com writes: You're affecting six nodes, so I think you should be able to pack this down into touching 6 nodes once each. I believe this will work: move(A/B, X/Y

Re: Ev2 as a move-aware editor

2013-06-26 Thread Philip Martin
is move(/M/N, /X/Y/Z/B/C/N) and now /M/N/O is already /X/Y/Z/B/C/N/O so the third move is move(/X/Y, /X/Y/Z/B/C/N/O/Y) which is impossible. I can't see any way to do the 9-node change without using temporaries. -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data

Re: Ev2 as a move-aware editor

2013-06-26 Thread Philip Martin
Philip Martin philip.mar...@wandisco.com writes: I can't see any way to do the 9-node change without using temporaries. I think we can reduce the 9 nodes to 6 and still see the problem: svnadmin create repo svnmucc -mm -U file://`pwd`/repo \ mkdir A mkdir A/B mkdir A/B/C \ mkdir X

Re: svn commit: r1496127 - /subversion/trunk/subversion/tests/cmdline/checkout_tests.py

2013-06-25 Thread Philip Martin
like the following without %f support? fmt = %Y-%m-%dT%H:%M:%S.%fZ r1_dt = datetime.datetime.strptime(r1_time, fmt) still_r1_time = (r1_dt + datetime.timedelta(seconds=1)).strftime(fmt) If we do have %f we could probably use a shorter sleep and a smaller delta. -- Philip Martin | Subversion

Re: Ev2 as a move-aware editor

2013-06-25 Thread Philip Martin
and retries every time a new operation is received? -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data www.wandisco.com

Re: svn commit: r1495419 - in /subversion/trunk/subversion/libsvn_ra_serf: options.c ra_serf.h serf.c util.c

2013-06-25 Thread Philip Martin
detection. But that's a theoretical problem, the bug reports so far involve a proxy with no support for chunked requests for which automatic detection should be possible. -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data www.wandisco.com

Re: Ev2 as a move-aware editor

2013-06-25 Thread Philip Martin
Branko Čibej br...@wandisco.com writes: On 25.06.2013 13:42, Philip Martin wrote: What about rotates that overlap. Consider a repository: svnadmin create repo svn mkdir -mm --parents file://`pwd`/repo/A/B/C ^/X/Y/Z Rotate /A and /X/Y/Z and /X and /A/B/C: svn mv wc/A wc/A2

Re: Ev2 as a move-aware editor

2013-06-25 Thread Philip Martin
Philip Martin philip.mar...@wandisco.com writes: alter(.) alter(A/B) alter(X/Y) rotate(A, X/Y/Z) rotate(X, A/B/C) alter(A) (pre-rotate X/Y/Z) alter(X/Y/Z) (pre-rotate A) move(X/Y/Z/B, A/B) alter(X) (pre-rotate A/B/X) Oops

Re: Commit error using 1.8.0 final

2013-06-18 Thread Philip Martin
://subversion.tigris.org/xmlns/dav/svn/log-revprops\r \r HTTP/1.1 204 No Content\r Date: Tue, 18 Jun 2013 11:04:35 GMT\r Server: Apache/2.2.22 (Debian) mod_ssl/2.2.22 OpenSSL/1.0.1e DAV/2 SVN/1.9.0-dev\r Content-Length: 0\r Content-Type: text/plain\r \r -- Philip Martin | Subversion Committer

Re: Commit error using 1.8.0 final

2013-06-18 Thread Philip Martin
/obj/repo/!svn/act/a0a022ce-26d5-4934-bce4-ea8e6a66ad2b HTTP/1.1 204 - Length:- so all the requests you show appeared to work. The client should have gone on to do HEAD, PUT, PUT, PUT but something caused it to abort the commit and send a DELETE instead. -- Philip Martin | Subversion Committer

Re: vimdiff wrapper for diff-cmd not working with 1.8

2013-06-18 Thread Philip Martin
file prevents the use of an external diff that expects a terminal. The only way I see to fix this is to stop using the stream API when the external diff command wants a terminal. I don't think it is possible to do this automatically, perhaps we need an --interactive-diff option? -- Philip Martin

Re: 1.8.0-rc3 up for testing/signing

2013-06-07 Thread Philip Martin
+kxEacELtltc7UmbKL3Jna2ZPz7Ek725W0nkLHVpww/U8 KYISo2RN2LgBX2FsiBfV0NLgT64oVAGKrZGxvskRlIlzLAvSSgitPS2TcKqv9ak= =rHu/ -END PGP SIGNATURE- -- Philip Martin WANdisco | www.wandisco.com

Re: serf error handling for locks without authn

2013-06-05 Thread Philip Martin
Philip Martin philip.mar...@wandisco.com writes: I'm trying to work out what this code should look like. This function is called after LOCK and PROPFIND, but not UNLOCK which has its own code. I think the function should be something like: apr_status_t errcode; if (err) return

Re: Segv in 1.8.0-rc2 used svn_client_status4 with a tree conflict

2013-06-03 Thread Philip Martin
Barry Scott ba...@barrys-emacs.org writes: Index: /Users/barry/wc/svn/svn-1.8.x/subversion/libsvn_wc/tree_conflicts.c === --- /Users/barry/wc/svn/svn-1.8.x/subversion/libsvn_wc/tree_conflicts.c (revision 1484244) +++

<    3   4   5   6   7   8   9   10   11   12   >