[GitHub] CasperLiu commented on issue #4701: Automatically assign "Verbose Name" for a table's fields

2018-03-28 Thread GitBox
CasperLiu commented on issue #4701: Automatically assign "Verbose Name" for a table's fields URL: https://github.com/apache/incubator-superset/issues/4701#issuecomment-377127746 Dear mistercrunch, Thanks for your sharing for the next phase's plan! They indeed looks beautiful and

[GitHub] CasperLiu commented on issue #4663: [Explore] Streamlined metric definitions for SQLA and Druid

2018-03-28 Thread GitBox
CasperLiu commented on issue #4663: [Explore] Streamlined metric definitions for SQLA and Druid URL: https://github.com/apache/incubator-superset/pull/4663#issuecomment-377127124 This PR looks brilliant, great work! Thanks! Which release/version would this functionilty go

[GitHub] mistercrunch opened a new issue #4707: [dashboard] clean up saved filter when removing slice

2018-03-28 Thread GitBox
mistercrunch opened a new issue #4707: [dashboard] clean up saved filter when removing slice URL: https://github.com/apache/incubator-superset/issues/4707 * create a dashboard * add a filter box * apply filter * save dash with applied filter * remove filter box filter from

[GitHub] john-bodley commented on issue #4551: [sql lab] option to disable cross schema search

2018-03-28 Thread GitBox
john-bodley commented on issue #4551: [sql lab] option to disable cross schema search URL: https://github.com/apache/incubator-superset/pull/4551#issuecomment-377123272 Sorry @mistercrunch I'm mistaken, the `update_datasource_cache` and the table caching logic is only used if

[GitHub] john-bodley commented on issue #4551: [sql lab] option to disable cross schema search

2018-03-28 Thread GitBox
john-bodley commented on issue #4551: [sql lab] option to disable cross schema search URL: https://github.com/apache/incubator-superset/pull/4551#issuecomment-377117995 @mistercrunch my other concern is if one sets `allow_multi_schema_metadata_fetch` to False or None then in essence

[GitHub] john-bodley commented on issue #4551: [sql lab] option to disable cross schema search

2018-03-28 Thread GitBox
john-bodley commented on issue #4551: [sql lab] option to disable cross schema search URL: https://github.com/apache/incubator-superset/pull/4551#issuecomment-377117995 @mistercrunch my other concern is if one sets `allow_multi_schema_metadata_fetch` to False or None then then in essence

[GitHub] mistercrunch opened a new issue #4706: Build duration/compression analysis

2018-03-28 Thread GitBox
mistercrunch opened a new issue #4706: Build duration/compression analysis URL: https://github.com/apache/incubator-superset/issues/4706 `$npm run build` ``` webpack.optimize.UglifyJsPlugin({ sourceMap: false, minimize: true, parallel: { cache: true,

[GitHub] mistercrunch commented on issue #4705: Smaller JS package sizes!

2018-03-28 Thread GitBox
mistercrunch commented on issue #4705: Smaller JS package sizes! URL: https://github.com/apache/incubator-superset/issues/4705#issuecomment-377111662 comments? ideas? @graceguo-supercat @williaster @GabeLoins This is an

[GitHub] codecov-io commented on issue #4669: [sqllab] Rendering query prior to sending to Celery

2018-03-28 Thread GitBox
codecov-io commented on issue #4669: [sqllab] Rendering query prior to sending to Celery URL: https://github.com/apache/incubator-superset/pull/4669#issuecomment-375514113 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4669?src=pr=h1) Report > Merging

[GitHub] betodealmeida commented on a change in pull request #4702: RFC: add logger that logs into browser console

2018-03-28 Thread GitBox
betodealmeida commented on a change in pull request #4702: RFC: add logger that logs into browser console URL: https://github.com/apache/incubator-superset/pull/4702#discussion_r177941322 ## File path: CONTRIBUTING.md ## @@ -195,6 +195,19 @@ Check the [OS

[GitHub] mistercrunch commented on issue #4665: Inconsistent inclusion of a footer template

2018-03-28 Thread GitBox
mistercrunch commented on issue #4665: Inconsistent inclusion of a footer template URL: https://github.com/apache/incubator-superset/issues/4665#issuecomment-377087325 Happy to review if you want to upstream your change.

[GitHub] mistercrunch commented on a change in pull request #4689: Move has access to superset security manager

2018-03-28 Thread GitBox
mistercrunch commented on a change in pull request #4689: Move has access to superset security manager URL: https://github.com/apache/incubator-superset/pull/4689#discussion_r177930467 ## File path: superset/security.py ## @@ -92,6 +99,42 @@ def can_access(self,

[GitHub] mistercrunch commented on a change in pull request #4689: Move has access to superset security manager

2018-03-28 Thread GitBox
mistercrunch commented on a change in pull request #4689: Move has access to superset security manager URL: https://github.com/apache/incubator-superset/pull/4689#discussion_r177930256 ## File path: superset/security.py ## @@ -92,6 +99,42 @@ def can_access(self,

[GitHub] mistercrunch commented on a change in pull request #4689: Move has access to superset security manager

2018-03-28 Thread GitBox
mistercrunch commented on a change in pull request #4689: Move has access to superset security manager URL: https://github.com/apache/incubator-superset/pull/4689#discussion_r177930072 ## File path: superset/security.py ## @@ -92,6 +99,42 @@ def can_access(self,

[GitHub] mistercrunch commented on a change in pull request #4689: Move has access to superset security manager

2018-03-28 Thread GitBox
mistercrunch commented on a change in pull request #4689: Move has access to superset security manager URL: https://github.com/apache/incubator-superset/pull/4689#discussion_r17793 ## File path: superset/security.py ## @@ -92,6 +99,42 @@ def can_access(self,

[GitHub] mistercrunch commented on issue #4669: [sqllab] Rendering query prior to sending to Celery

2018-03-28 Thread GitBox
mistercrunch commented on issue #4669: [sqllab] Rendering query prior to sending to Celery URL: https://github.com/apache/incubator-superset/pull/4669#issuecomment-377084979 Yes you're right there would be mocking involved. It might be tricky and out-of-scope for this PR here. Happy to

[GitHub] mistercrunch commented on issue #4663: [Explore] Streamlined metric definitions for SQLA and Druid

2018-03-28 Thread GitBox
mistercrunch commented on issue #4663: [Explore] Streamlined metric definitions for SQLA and Druid URL: https://github.com/apache/incubator-superset/pull/4663#issuecomment-377084315

[GitHub] mistercrunch closed pull request #4663: [Explore] Streamlined metric definitions for SQLA and Druid

2018-03-28 Thread GitBox
mistercrunch closed pull request #4663: [Explore] Streamlined metric definitions for SQLA and Druid URL: https://github.com/apache/incubator-superset/pull/4663 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] mistercrunch commented on issue #4704: allow customizable caching permissions

2018-03-28 Thread GitBox
mistercrunch commented on issue #4704: allow customizable caching permissions URL: https://github.com/apache/incubator-superset/pull/4704#issuecomment-377083886 I think this results in double-checking the permission at the moment, which is an extra database round trip. I'm not sure how

[GitHub] williaster commented on issue #4663: [Explore] Streamlined metric definitions for SQLA and Druid

2018-03-28 Thread GitBox
williaster commented on issue #4663: [Explore] Streamlined metric definitions for SQLA and Druid URL: https://github.com/apache/incubator-superset/pull/4663#issuecomment-377080746 lgtm, will let @mistercrunch pull the trigger tho 

[GitHub] mistercrunch commented on issue #3228: Cassandra

2018-03-28 Thread GitBox
mistercrunch commented on issue #3228: Cassandra URL: https://github.com/apache/incubator-superset/issues/3228#issuecomment-377074046 @iwechen I'm not aware of any. This is an automated message from the Apache Git Service.

[GitHub] mistercrunch commented on a change in pull request #4702: RFC: add logger that logs into browser console

2018-03-28 Thread GitBox
mistercrunch commented on a change in pull request #4702: RFC: add logger that logs into browser console URL: https://github.com/apache/incubator-superset/pull/4702#discussion_r177919793 ## File path: CONTRIBUTING.md ## @@ -195,6 +195,19 @@ Check the [OS

[GitHub] codecov-io commented on issue #4704: allow customizable caching permissions

2018-03-28 Thread GitBox
codecov-io commented on issue #4704: allow customizable caching permissions URL: https://github.com/apache/incubator-superset/pull/4704#issuecomment-377072620 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4704?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4702: RFC: add logger that logs into browser console

2018-03-28 Thread GitBox
codecov-io commented on issue #4702: RFC: add logger that logs into browser console URL: https://github.com/apache/incubator-superset/pull/4702#issuecomment-377009683 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4702?src=pr=h1) Report > Merging

[GitHub] graceguo-supercat commented on issue #2821: [explore, usability] filter drop-down lists are cut off

2018-03-28 Thread GitBox
graceguo-supercat commented on issue #2821: [explore, usability] filter drop-down lists are cut off URL: https://github.com/apache/incubator-superset/issues/2821#issuecomment-377071676 fixed in #3279. This is an automated

[GitHub] graceguo-supercat closed issue #2821: [explore, usability] filter drop-down lists are cut off

2018-03-28 Thread GitBox
graceguo-supercat closed issue #2821: [explore, usability] filter drop-down lists are cut off URL: https://github.com/apache/incubator-superset/issues/2821 This is an automated message from the Apache Git Service. To

[GitHub] graceguo-supercat commented on issue #2960: [explore] User can't see the complete dropdown list

2018-03-28 Thread GitBox
graceguo-supercat commented on issue #2960: [explore] User can't see the complete dropdown list URL: https://github.com/apache/incubator-superset/issues/2960#issuecomment-377071639 fixed in #3279. This is an automated

[GitHub] graceguo-supercat closed issue #2960: [explore] User can't see the complete dropdown list

2018-03-28 Thread GitBox
graceguo-supercat closed issue #2960: [explore] User can't see the complete dropdown list URL: https://github.com/apache/incubator-superset/issues/2960 This is an automated message from the Apache Git Service. To respond to

[GitHub] codecov-io commented on issue #4689: Move has access to superset security manager

2018-03-28 Thread GitBox
codecov-io commented on issue #4689: Move has access to superset security manager URL: https://github.com/apache/incubator-superset/pull/4689#issuecomment-376723053 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4689?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4689: Move has access to superset security manager

2018-03-28 Thread GitBox
codecov-io commented on issue #4689: Move has access to superset security manager URL: https://github.com/apache/incubator-superset/pull/4689#issuecomment-376723053 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4689?src=pr=h1) Report > Merging

[GitHub] timifasubaa opened a new pull request #4704: allow customizable caching permissions

2018-03-28 Thread GitBox
timifasubaa opened a new pull request #4704: allow customizable caching permissions URL: https://github.com/apache/incubator-superset/pull/4704 This PR allows deployments to restrict access to the cache with their custom logic by extending the new SupersetSecurityManager

[GitHub] codecov-io commented on issue #4689: Move has access to superset security manager

2018-03-28 Thread GitBox
codecov-io commented on issue #4689: Move has access to superset security manager URL: https://github.com/apache/incubator-superset/pull/4689#issuecomment-376723053 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4689?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4689: Move has access to superset security manager

2018-03-28 Thread GitBox
codecov-io commented on issue #4689: Move has access to superset security manager URL: https://github.com/apache/incubator-superset/pull/4689#issuecomment-376723053 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4689?src=pr=h1) Report > Merging

[GitHub] GabeLoins commented on issue #4663: [Explore] Streamlined metric definitions for SQLA and Druid

2018-03-28 Thread GitBox
GabeLoins commented on issue #4663: [Explore] Streamlined metric definitions for SQLA and Druid URL: https://github.com/apache/incubator-superset/pull/4663#issuecomment-377063105 @mistercrunch @michellethomas @williaster I believe this PR is ready to merge--- any objectors?

[GitHub] mistercrunch commented on issue #4701: Automatically assign "Verbose Name" for a table's fields

2018-03-28 Thread GitBox
mistercrunch commented on issue #4701: Automatically assign "Verbose Name" for a table's fields URL: https://github.com/apache/incubator-superset/issues/4701#issuecomment-377059241 We're planning on rewriting the "Table Editor" soon. Picture a nice editor inside a modal widow displayed

[GitHub] mistercrunch closed issue #4685: superset dashboard is blank

2018-03-28 Thread GitBox
mistercrunch closed issue #4685: superset dashboard is blank URL: https://github.com/apache/incubator-superset/issues/4685 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] mistercrunch commented on issue #4685: superset dashboard is blank

2018-03-28 Thread GitBox
mistercrunch commented on issue #4685: superset dashboard is blank URL: https://github.com/apache/incubator-superset/issues/4685#issuecomment-377057421 `0.24.0` is out and should address this This is an automated message

[GitHub] mistercrunch commented on a change in pull request #4545: add two more number formats, add number formats to table

2018-03-28 Thread GitBox
mistercrunch commented on a change in pull request #4545: add two more number formats, add number formats to table URL: https://github.com/apache/incubator-superset/pull/4545#discussion_r177907134 ## File path: superset/assets/visualizations/table.js ## @@ -90,7 +90,8 @@

[GitHub] mistercrunch commented on a change in pull request #4545: add two more number formats, add number formats to table

2018-03-28 Thread GitBox
mistercrunch commented on a change in pull request #4545: add two more number formats, add number formats to table URL: https://github.com/apache/incubator-superset/pull/4545#discussion_r177906645 ## File path: superset/assets/visualizations/table.js ## @@ -90,7 +90,8 @@

[GitHub] mistercrunch commented on issue #4551: [sql lab] option to disable cross schema search

2018-03-28 Thread GitBox
mistercrunch commented on issue #4551: [sql lab] option to disable cross schema search URL: https://github.com/apache/incubator-superset/pull/4551#issuecomment-377055545 @john-bodley do you think I should write a db migration script to handle this?

[GitHub] mistercrunch commented on issue #4702: RFC: add logger that logs into browser console

2018-03-28 Thread GitBox
mistercrunch commented on issue #4702: RFC: add logger that logs into browser console URL: https://github.com/apache/incubator-superset/pull/4702#issuecomment-377055005 LGTM but it could use a description in CONTRIBUTING.md !

[GitHub] mistercrunch closed pull request #4703: Rename no_reload

2018-03-28 Thread GitBox
mistercrunch closed pull request #4703: Rename no_reload URL: https://github.com/apache/incubator-superset/pull/4703 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] codecov-io commented on issue #4451: [cli] Preparing to deprecate wrapping of external commands

2018-03-28 Thread GitBox
codecov-io commented on issue #4451: [cli] Preparing to deprecate wrapping of external commands URL: https://github.com/apache/incubator-superset/pull/4451#issuecomment-373533218 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4451?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4702: RFC: add logger that logs into browser console

2018-03-28 Thread GitBox
codecov-io commented on issue #4702: RFC: add logger that logs into browser console URL: https://github.com/apache/incubator-superset/pull/4702#issuecomment-377009683 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4702?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4702: RFC: add logger that logs into browser console

2018-03-28 Thread GitBox
codecov-io commented on issue #4702: RFC: add logger that logs into browser console URL: https://github.com/apache/incubator-superset/pull/4702#issuecomment-377009683 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4702?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4663: [Explore] Streamlined metric definitions for SQLA and Druid

2018-03-28 Thread GitBox
codecov-io commented on issue #4663: [Explore] Streamlined metric definitions for SQLA and Druid URL: https://github.com/apache/incubator-superset/pull/4663#issuecomment-375497877 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4663?src=pr=h1) Report > Merging

[GitHub] john-bodley commented on issue #4551: [sql lab] option to disable cross schema search

2018-03-28 Thread GitBox
john-bodley commented on issue #4551: [sql lab] option to disable cross schema search URL: https://github.com/apache/incubator-superset/pull/4551#issuecomment-377004147 @mistercrunch it seems after the Alembic upgrade the `allow_multi_schema_metadata_fetch` is `NULL` rather than `True`

[GitHub] SpyderRivera commented on issue #4545: add two more number formats, add number formats to table

2018-03-28 Thread GitBox
SpyderRivera commented on issue #4545: add two more number formats, add number formats to table URL: https://github.com/apache/incubator-superset/pull/4545#issuecomment-376996805 LGTM, I checked out the PR, built, and tested the feature in the UI. No issues. Appreciate the fix for this

[GitHub] hughhhh commented on issue #4702: RFC: add logger that logs into browser console

2018-03-28 Thread GitBox
hug commented on issue #4702: RFC: add logger that logs into browser console URL: https://github.com/apache/incubator-superset/pull/4702#issuecomment-376995672  This is an automated message from the Apache Git Service.

[GitHub] graceguo-supercat commented on issue #3340: Calendar Heatmap callout hidden on dashboard

2018-03-28 Thread GitBox
graceguo-supercat commented on issue #3340: Calendar Heatmap callout hidden on dashboard URL: https://github.com/apache/incubator-superset/issues/3340#issuecomment-376995310 #4268 fixed this issue. This is an automated

[GitHub] graceguo-supercat closed issue #3340: Calendar Heatmap callout hidden on dashboard

2018-03-28 Thread GitBox
graceguo-supercat closed issue #3340: Calendar Heatmap callout hidden on dashboard URL: https://github.com/apache/incubator-superset/issues/3340 This is an automated message from the Apache Git Service. To respond to the

[GitHub] betodealmeida commented on a change in pull request #4702: RFC: add logger that logs into browser console

2018-03-28 Thread GitBox
betodealmeida commented on a change in pull request #4702: RFC: add logger that logs into browser console URL: https://github.com/apache/incubator-superset/pull/4702#discussion_r177851746 ## File path: superset/cli.py ## @@ -31,11 +32,47 @@ def init():

[GitHub] SpyderRivera commented on issue #4658: Question: How to convert timestamp field represented as text in ISO8601 format to datetime - superset evaluation

2018-03-28 Thread GitBox
SpyderRivera commented on issue #4658: Question: How to convert timestamp field represented as text in ISO8601 format to datetime - superset evaluation URL: https://github.com/apache/incubator-superset/issues/4658#issuecomment-376986255 I have not had issues with this. Any format of a

[GitHub] SpyderRivera commented on issue #4685: superset dashboard is blank

2018-03-28 Thread GitBox
SpyderRivera commented on issue #4685: superset dashboard is blank URL: https://github.com/apache/incubator-superset/issues/4685#issuecomment-376984575 Duplicate of #4619 This is an automated message from the Apache Git

[GitHub] SpyderRivera commented on issue #4685: superset dashboard is blank

2018-03-28 Thread GitBox
SpyderRivera commented on issue #4685: superset dashboard is blank URL: https://github.com/apache/incubator-superset/issues/4685#issuecomment-376984575 #4619 This is an automated message from the Apache Git Service. To

[GitHub] codecov-io commented on issue #4703: Rename no_reload

2018-03-28 Thread GitBox
codecov-io commented on issue #4703: Rename no_reload URL: https://github.com/apache/incubator-superset/pull/4703#issuecomment-376984054 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4703?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4703: Rename no_reload

2018-03-28 Thread GitBox
codecov-io commented on issue #4703: Rename no_reload URL: https://github.com/apache/incubator-superset/pull/4703#issuecomment-376984054 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4703?src=pr=h1) Report > Merging

Query:-- REST API For Superset

2018-03-28 Thread ashutosh khira
Hi dev@superset.incubator.apache.org, I am looking REST API document for superset’s slice & dashboard creation. Some where i read ,It is using Flask APP Builder Framework . I need end-point & post form-data or post request for each point . Thanks Ashutosh Khira

[GitHub] hughhhh commented on a change in pull request #4702: RFC: add logger that logs into browser console

2018-03-28 Thread GitBox
hug commented on a change in pull request #4702: RFC: add logger that logs into browser console URL: https://github.com/apache/incubator-superset/pull/4702#discussion_r177839075 ## File path: superset/cli.py ## @@ -31,11 +32,47 @@ def init():

[GitHub] betodealmeida opened a new pull request #4703: Rename no_reload

2018-03-28 Thread GitBox
betodealmeida opened a new pull request #4703: Rename no_reload URL: https://github.com/apache/incubator-superset/pull/4703 The variable `no_reload` is true whenever we **want** to reload, and is false when we want **no reload**. I renamed it to `use_reloader`.

[GitHub] betodealmeida opened a new pull request #4702: RFC: add logger that logs into browser console

2018-03-28 Thread GitBox
betodealmeida opened a new pull request #4702: RFC: add logger that logs into browser console URL: https://github.com/apache/incubator-superset/pull/4702 This PR integrates the [console_log](https://github.com/betodealmeida/consolelog) module with Superset, allowing records to be logged

[GitHub] GabeLoins commented on issue #4663: [Explore] Streamlined metric definitions for SQLA and Druid

2018-03-28 Thread GitBox
GabeLoins commented on issue #4663: [Explore] Streamlined metric definitions for SQLA and Druid URL: https://github.com/apache/incubator-superset/pull/4663#issuecomment-376960610 @williaster thanks for all the comments- they should be addressed now. Good callout on the

[GitHub] CasperLiu opened a new issue #4701: Automatically assign "Verbose Name" for a table's fields

2018-03-28 Thread GitBox
CasperLiu opened a new issue #4701: Automatically assign "Verbose Name" for a table's fields URL: https://github.com/apache/incubator-superset/issues/4701 Hello, Superset authors, Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked

[GitHub] behanjc commented on issue #4662: Key Error in Viz using Snowflake Connector

2018-03-28 Thread GitBox
behanjc commented on issue #4662: Key Error in Viz using Snowflake Connector URL: https://github.com/apache/incubator-superset/issues/4662#issuecomment-376910666 Finally figured setting this line to False fixes the issue. Not sure if there will be any negative consequences, as I'm sure

[GitHub] behanjc commented on issue #4662: Key Error in Viz using Snowflake Connector

2018-03-28 Thread GitBox
behanjc commented on issue #4662: Key Error in Viz using Snowflake Connector URL: https://github.com/apache/incubator-superset/issues/4662#issuecomment-376910666 Finally figured setting this line to False fixes the issue. Not sure if there will be any negative consequences, as I'm sure

[GitHub] KostasChr commented on issue #211: Query Time Lookups for Dimensions in Druid

2018-03-28 Thread GitBox
KostasChr commented on issue #211: Query Time Lookups for Dimensions in Druid URL: https://github.com/apache/incubator-superset/issues/211#issuecomment-376859934 I am happily using superset - and I have a calculated column on the datasource with a dimensionSpec expression that describes a

[GitHub] iwechen commented on issue #3228: Cassandra

2018-03-28 Thread GitBox
iwechen commented on issue #3228: Cassandra URL: https://github.com/apache/incubator-superset/issues/3228#issuecomment-376783732 @mistercrunch Where is the interface to the Mongo database? This is an automated message from

[GitHub] iwechen commented on issue #3228: Cassandra

2018-03-28 Thread GitBox
iwechen commented on issue #3228: Cassandra URL: https://github.com/apache/incubator-superset/issues/3228#issuecomment-376783732 Where is the interface to the Mongo database? This is an automated message from the Apache Git