[GitHub] pranavoyo commented on issue #1996: Custom SQL queries with filters
pranavoyo commented on issue #1996: Custom SQL queries with filters
URL:
https://github.com/apache/incubator-superset/issues/1996#issuecomment-371047524
@mistercrunch, I am getting this error in sql lab when running {{
current_username() }},
Template rendering failed: '_AppCtxGlobals' object has no attribute 'user'
Please help!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] kfk opened a new issue #4558: Vegalite charts
kfk opened a new issue #4558: Vegalite charts URL: https://github.com/apache/incubator-superset/issues/4558 I have been looking into vega lite charts: https://vega.github.io/vega-lite/examples/ And the corresponding Python library: https://altair-viz.github.io/ I was wondering if somebody was looking into this too. Vega charts are configured in json. This means that with the right setup in Superset we open up endless possibilities for creating new charts or change existing ones. Some ideas for creating the slice could come from here: http://vega.github.io/voyager/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pranavoyo commented on issue #1490: [sqllab] add username to jinja context
pranavoyo commented on issue #1490: [sqllab] add username to jinja context URL: https://github.com/apache/incubator-superset/issues/1490#issuecomment-371038898 any update on this please? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #4505: Expose hook to inject database connection logic on the fly
mistercrunch closed pull request #4505: Expose hook to inject database
connection logic on the fly
URL: https://github.com/apache/incubator-superset/pull/4505
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/config.py b/superset/config.py
index ae81cfcb6e..c9b8607e3e 100644
--- a/superset/config.py
+++ b/superset/config.py
@@ -377,6 +377,22 @@ class CeleryConfig(object):
# an XSS security vulnerability
ENABLE_JAVASCRIPT_CONTROLS = False
+# A callable that allows altering the database conneciton URL and params
+# on the fly, at runtime. This allows for things like impersonation or
+# arbitrary logic. For instance you can wire different users to
+# use different connection parameters, or pass their email address as the
+# username. The function receives the connection uri object, connection
+# params, and user object, and returns the mutated uri and params objects.
+# Example:
+# def DB_CONNECTION_MUTATOR(uri, params, user):
+# if user and user.email:
+# uri.username = user.email
+# return uri, params
+#
+# Note that the returned uri and params are passed directly to sqlalchemy's
+# as such `create_engine(url, **params)`
+DB_CONNECTION_MUTATOR = None
+
try:
if CONFIG_PATH_ENV_VAR in os.environ:
# Explicitly import config module that is not in pythonpath; useful
diff --git a/superset/models/core.py b/superset/models/core.py
index b4dbada947..41d8742b65 100644
--- a/superset/models/core.py
+++ b/superset/models/core.py
@@ -675,6 +675,9 @@ def get_sqla_engine(self, schema=None, nullpool=True,
user_name=None):
if configuration:
params['connect_args'] = {'configuration': configuration}
+DB_CONNECTION_MUTATOR = config.get('DB_CONNECTION_MUTATOR')
+if DB_CONNECTION_MUTATOR:
+url, params = DB_CONNECTION_MUTATOR(url, params, g.user)
return create_engine(url, **params)
def get_reserved_words(self):
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mistercrunch commented on issue #4505: Expose hook to inject database connection logic on the fly
mistercrunch commented on issue #4505: Expose hook to inject database connection logic on the fly URL: https://github.com/apache/incubator-superset/pull/4505#issuecomment-371038370 This is a pretty benign, just a hook we need in our env, mergin' This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4551: [sql lab] option to disable cross schema search
codecov-io commented on issue #4551: [sql lab] option to disable cross schema search URL: https://github.com/apache/incubator-superset/pull/4551#issuecomment-371030577 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=h1) Report > Merging [#4551](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d817b8ddbb3a8a1bd706f47ecd0934781aea100f?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `54.54%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4551 +/- ## == - Coverage71.2% 71.18% -0.02% == Files 187 187 Lines 1478214793 +11 Branches 1083 1084 +1 == + Hits1052510531 +6 - Misses 4254 4259 +5 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=tree) | Coverage ? | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.18% (?)` | :arrow_up: | | [...assets/javascripts/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `74.46% (?)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.81% <20%> (-0.62%)` | :arrow_down: | | [...javascripts/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `92.45% <83.33%> (-0.55%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=footer). Last update [d817b8d...ca38933](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4552: [wip][travis/tox] Restructuring configuration
codecov-io commented on issue #4552: [wip][travis/tox] Restructuring configuration URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=h1) Report > Merging [#4552](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/01e0a2f07101a0e48b778aa412a91f98fe769bfb?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4552 +/- ## === Coverage 71.12% 71.12% === Files 187 187 Lines 1478014780 Branches 1083 1083 === Hits1051310513 Misses 4264 4264 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree) | Coverage ? | | |---|---|---| | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.06% <0%> (?)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=footer). Last update [01e0a2f...c086986](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vinay87 opened a new issue #4557: Embedding Slices in crossdomain webpages leads to 400 error.
vinay87 opened a new issue #4557: Embedding Slices in crossdomain webpages
leads to 400 error.
URL: https://github.com/apache/incubator-superset/issues/4557
Make sure these boxes are checked before submitting your issue - thank you!
- [ x] I have checked the superset logs for python stacktraces and included
it here as text if any
- [ x] I have reproduced the issue with at least the latest released version
of superset
- [ x] I have checked the issue tracker for the same issue and I haven't
found one similar
### Superset version
0.23.2
### Expected results
Tried to embed a slice in a HTML page on my local machine. Superset server
was on another network, but accessible through my current system.
I've set HTTP = {} in the config.
### Actual results
The slice loads, but results in an "Unknown Error".
Chrome console shows a 400 error.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] john-bodley closed pull request #3881: [linting] Cleaning up linting documentation
john-bodley closed pull request #3881: [linting] Cleaning up linting
documentation
URL: https://github.com/apache/incubator-superset/pull/3881
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 3051d94fdc..b4cb0e21b9 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -287,10 +287,10 @@ We use [Mocha](https://mochajs.org/),
[Chai](http://chaijs.com/) and [Enzyme](ht
Lint the project with:
# for python
-flake8
+tox -e flake8
# for javascript
-npm run lint
+tox -e eslint
## Linting with codeclimate
Codeclimate is a service we use to measure code quality and test coverage. To
get codeclimate's report on your branch, ideally before sending your PR, you
can setup codeclimate against your Superset fork. After you push to your fork,
you should be able to get the report at http://codeclimate.com . Alternatively,
if you prefer to work locally, you can install the codeclimate cli tool.
diff --git a/tox.ini b/tox.ini
index 78198ea190..db32142ab8 100644
--- a/tox.ini
+++ b/tox.ini
@@ -46,6 +46,11 @@ commands =
pip install -r dev-reqs.txt
{toxinidir}/run_tests.sh
+[testenv:eslint]
+changedir = {toxinidir}/superset/assets
+commands =
+npm run lint
+
[testenv:flake8]
commands =
flake8
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mistercrunch closed pull request #4543: Setting up compression using flask-compress
mistercrunch closed pull request #4543: Setting up compression using
flask-compress
URL: https://github.com/apache/incubator-superset/pull/4543
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/setup.py b/setup.py
index 682fe336d8..ad33dcec58 100644
--- a/setup.py
+++ b/setup.py
@@ -59,6 +59,7 @@ def get_git_sha():
'flask-cache==0.13.1',
'flask-migrate==2.1.1',
'flask-script==2.0.6',
+'flask-compress==1.4.0',
'flask-sqlalchemy==2.1',
'flask-testing==0.7.1',
'flask-wtf==0.14.2',
diff --git a/superset/__init__.py b/superset/__init__.py
index 778bb61616..fbf11c0780 100644
--- a/superset/__init__.py
+++ b/superset/__init__.py
@@ -13,6 +13,7 @@
from flask import Flask, redirect
from flask_appbuilder import AppBuilder, IndexView, SQLA
from flask_appbuilder.baseviews import expose
+from flask_compress import Compress
from flask_migrate import Migrate
from flask_wtf.csrf import CSRFProtect
from werkzeug.contrib.fixers import ProxyFix
@@ -166,6 +167,9 @@ def index(self):
module_datasource_map.update(app.config.get('ADDITIONAL_MODULE_DS_MAP'))
ConnectorRegistry.register_sources(module_datasource_map)
+# Flask-Compress
+Compress(app)
+
# Hook that provides administrators a handle on the Flask APP
# after initialization
flask_app_mutator = app.config.get('FLASK_APP_MUTATOR')
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mistercrunch commented on issue #4549: [bugfix] Fixing regression from #4500
mistercrunch commented on issue #4549: [bugfix] Fixing regression from #4500 URL: https://github.com/apache/incubator-superset/pull/4549#issuecomment-371026069 Nice. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #4549: [bugfix] Fixing regression from #4500
mistercrunch closed pull request #4549: [bugfix] Fixing regression from #4500
URL: https://github.com/apache/incubator-superset/pull/4549
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/viz.py b/superset/viz.py
index 3595ebf767..9225e5da8f 100644
--- a/superset/viz.py
+++ b/superset/viz.py
@@ -288,7 +288,7 @@ def get_payload(self, query_obj=None):
df = payload.get('df')
if self.status != utils.QueryStatus.FAILED:
-if df is None or df.empty:
+if df is not None and df.empty:
payload['error'] = 'No data'
else:
payload['data'] = self.get_data(df)
@@ -611,7 +611,7 @@ def query_obj(self):
return None
def get_df(self, query_obj=None):
-return pd.DataFrame()
+return None
def get_data(self, df):
markup_type = self.form_data.get('markup_type')
diff --git a/tests/core_tests.py b/tests/core_tests.py
index 43a3bdfc71..e4df8bf05c 100644
--- a/tests/core_tests.py
+++ b/tests/core_tests.py
@@ -922,7 +922,7 @@ def test_slice_payload_no_data(self):
data = self.get_json_resp(url)
self.assertEqual(data['status'], utils.QueryStatus.SUCCESS)
-assert 'No data' in data['error']
+self.assertEqual(data['error'], 'No data')
def test_slice_payload_invalid_query(self):
self.login(username='admin')
@@ -937,6 +937,15 @@ def test_slice_payload_invalid_query(self):
self.assertEqual(data['status'], utils.QueryStatus.FAILED)
assert 'KeyError' in data['stacktrace']
+def test_slice_payload_viz_markdown(self):
+self.login(username='admin')
+slc = self.get_slice('Title', db.session)
+
+url = slc.get_explore_url(base_url='/superset/explore_json')
+data = self.get_json_resp(url)
+self.assertEqual(data['status'], None)
+self.assertEqual(data['error'], None)
+
if __name__ == '__main__':
unittest.main()
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io commented on issue #4552: [wip][travis/tox] Restructuring configuration
codecov-io commented on issue #4552: [wip][travis/tox] Restructuring configuration URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=h1) Report > Merging [#4552](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/01e0a2f07101a0e48b778aa412a91f98fe769bfb?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4552 +/- ## === Coverage 71.12% 71.12% === Files 187 187 Lines 1478014780 Branches 1083 1083 === Hits1051310513 Misses 4264 4264 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree) | Coverage ? | | |---|---|---| | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.06% <0%> (?)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=footer). Last update [01e0a2f...969a338](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4552: [wip][travis/tox] Restructuring configuration
codecov-io commented on issue #4552: [wip][travis/tox] Restructuring configuration URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=h1) Report > Merging [#4552](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/01e0a2f07101a0e48b778aa412a91f98fe769bfb?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4552 +/- ## === Coverage 71.12% 71.12% === Files 187 187 Lines 1478014780 Branches 1083 1083 === Hits1051310513 Misses 4264 4264 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree) | Coverage ? | | |---|---|---| | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.06% <0%> (?)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=footer). Last update [01e0a2f...969a338](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4552: [wip][travis/tox] Restructuring configuration
codecov-io commented on issue #4552: [wip][travis/tox] Restructuring configuration URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=h1) Report > Merging [#4552](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/01e0a2f07101a0e48b778aa412a91f98fe769bfb?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4552 +/- ## === Coverage 71.12% 71.12% === Files 187 187 Lines 1478014780 Branches 1083 1083 === Hits1051310513 Misses 4264 4264 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree) | Coverage ? | | |---|---|---| | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.06% <0%> (?)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=footer). Last update [01e0a2f...969a338](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4552: [wip][travis/tox] Restructuring configuration
codecov-io commented on issue #4552: [wip][travis/tox] Restructuring configuration URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=h1) Report > Merging [#4552](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/01e0a2f07101a0e48b778aa412a91f98fe769bfb?src=pr=desc) will **increase** coverage by `3.23%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4552 +/- ## == + Coverage 71.12% 74.36% +3.23% == Files 187 43 -144 Lines 14780 8309-6471 Branches 10830-1083 == - Hits10513 6179-4334 + Misses 4264 2130-2134 + Partials30 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree) | Coverage ? | | |---|---|---| | [superset/data/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvZGF0YS9jb3VudHJpZXMucHk=) | `0% <0%> (-100%)` | :arrow_down: | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.19% <0%> (-6.55%)` | :arrow_down: | | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `49.9% <0%> (-2.35%)` | :arrow_down: | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `86.62% <0%> (-1.32%)` | :arrow_down: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.88% <0%> (-0.31%)` | :arrow_down: | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.06% <0%> (?)` | :arrow_up: | | [superset/assets/javascripts/explore/validators.js](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvdmFsaWRhdG9ycy5qcw==) | | | | [...scripts/explore/components/ControlPanelSection.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxTZWN0aW9uLmpzeA==) | | | | [.../assets/javascripts/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | | | | [...ts/javascripts/explore/actions/saveModalActions.js](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvYWN0aW9ucy9zYXZlTW9kYWxBY3Rpb25zLmpz) | | | | ... and [140 more](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=footer). Last update [01e0a2f...c307390](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4552: [wip][travis/tox] Restructuring configuration
codecov-io commented on issue #4552: [wip][travis/tox] Restructuring configuration URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=h1) Report > Merging [#4552](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/01e0a2f07101a0e48b778aa412a91f98fe769bfb?src=pr=desc) will **increase** coverage by `3.24%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4552 +/- ## == + Coverage 71.12% 74.37% +3.24% == Files 187 43 -144 Lines 14780 8309-6471 Branches 10830-1083 == - Hits10513 6180-4333 + Misses 4264 2129-2135 + Partials30 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree) | Coverage ? | | |---|---|---| | [superset/data/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvZGF0YS9jb3VudHJpZXMucHk=) | `0% <0%> (-100%)` | :arrow_down: | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.19% <0%> (-6.55%)` | :arrow_down: | | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `49.9% <0%> (-2.35%)` | :arrow_down: | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `86.62% <0%> (-1.32%)` | :arrow_down: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.95% <0%> (-0.23%)` | :arrow_down: | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.06% <0%> (?)` | :arrow_up: | | [...ts/explore/components/controls/CheckboxControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9DaGVja2JveENvbnRyb2wuanN4) | | | | [...ssets/javascripts/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | | | | [...sets/javascripts/dashboard/components/GridCell.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9jb21wb25lbnRzL0dyaWRDZWxsLmpzeA==) | | | | [...ts/explore/components/controls/TextAreaControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0QXJlYUNvbnRyb2wuanN4) | | | | ... and [140 more](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=footer). Last update [01e0a2f...75589db](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hughhhh opened a new pull request #4556: [WIP] Preview data
hug opened a new pull request #4556: [WIP] Preview data URL: https://github.com/apache/incubator-superset/pull/4556 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yamyamyuo commented on issue #3978: Adding YAML Import-Export for Datasources to CLI
yamyamyuo commented on issue #3978: Adding YAML Import-Export for Datasources to CLI URL: https://github.com/apache/incubator-superset/pull/3978#issuecomment-371009589 @mistercrunch I have a deeper look at superset. I found the security part is very detailed but also complex. 1. How did Airbnb manage the user's authorization? Pick some people as admin and grant perm when new users come? How did the admin know every user's role? Shall I grant the Finance group datasource to a marketing employee? 2. Would it be too annoying for the admin to add/delete/edit all the roles and add the roles to each users? Is there an automatic way or more efficient way? 3. Does Airbnb deploy Superset to separate environment? Such as development, staging and production environment. Does the analyst try to create the slice/dashboard in development environment and when it success, do that process again in production environment? How did the analyst create same slice/dashboard in more than one environment? We can't just copy and paste since slice cannot import/export. Did they repeat the same process in different env? There are some many questions?I am really appreciated if you can share your experience or advice! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4555: [examples] let's not use 'date' as a col name
codecov-io commented on issue #4555: [examples] let's not use 'date' as a col name URL: https://github.com/apache/incubator-superset/pull/4555#issuecomment-371006081 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4555?src=pr=h1) Report > Merging [#4555](https://codecov.io/gh/apache/incubator-superset/pull/4555?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2e780e403418e6eefc0a91a89d01b3c2622aa0fd?src=pr=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4555?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4555 +/- ## === Coverage 71.12% 71.12% === Files 187 187 Lines 1478014780 Branches 1083 1083 === Hits1051310513 Misses 4264 4264 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4555?src=pr=tree) | Coverage ? | | |---|---|---| | [superset/data/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/4555/diff?src=pr=tree#diff-c3VwZXJzZXQvZGF0YS9fX2luaXRfXy5weQ==) | `100% <100%> (?)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4555?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4555?src=pr=footer). Last update [2e780e4...8065147](https://codecov.io/gh/apache/incubator-superset/pull/4555?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4555: [examples] let's not use 'date' as a col name
codecov-io commented on issue #4555: [examples] let's not use 'date' as a col name URL: https://github.com/apache/incubator-superset/pull/4555#issuecomment-371006081 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4555?src=pr=h1) Report > Merging [#4555](https://codecov.io/gh/apache/incubator-superset/pull/4555?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2e780e403418e6eefc0a91a89d01b3c2622aa0fd?src=pr=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4555?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4555 +/- ## === Coverage 71.12% 71.12% === Files 187 187 Lines 1478014780 Branches 1083 1083 === Hits1051310513 Misses 4264 4264 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4555?src=pr=tree) | Coverage ? | | |---|---|---| | [superset/data/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/4555/diff?src=pr=tree#diff-c3VwZXJzZXQvZGF0YS9fX2luaXRfXy5weQ==) | `100% <100%> (?)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4555?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4555?src=pr=footer). Last update [2e780e4...8065147](https://codecov.io/gh/apache/incubator-superset/pull/4555?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #4553: [landing] Making Dashboards the first/default tab
mistercrunch closed pull request #4553: [landing] Making Dashboards the
first/default tab
URL: https://github.com/apache/incubator-superset/pull/4553
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/assets/javascripts/welcome/App.jsx
b/superset/assets/javascripts/welcome/App.jsx
index 8f63719ea5..5c694de928 100644
--- a/superset/assets/javascripts/welcome/App.jsx
+++ b/superset/assets/javascripts/welcome/App.jsx
@@ -25,25 +25,7 @@ export default class App extends React.PureComponent {
return (
-
-
-
-{t('Recently Viewed')}
-
-
-
-
-
-
-
-
-{t('Favorites')}
-
-
-
-
-
-
+
{t('Dashboards')}
@@ -62,6 +44,24 @@ export default class App extends React.PureComponent {
+
+
+
+{t('Recently Viewed')}
+
+
+
+
+
+
+
+
+{t('Favorites')}
+
+
+
+
+
);
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mistercrunch opened a new pull request #4555: [examples] let's not use 'date' as a col name
mistercrunch opened a new pull request #4555: [examples] let's not use 'date' as a col name URL: https://github.com/apache/incubator-superset/pull/4555 'date' is a reserved word in most database This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] royce-hpcnt closed pull request #4554: Merge with dbi-superset
royce-hpcnt closed pull request #4554: Merge with dbi-superset
URL: https://github.com/apache/incubator-superset/pull/4554
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.gitignore b/.gitignore
index 9109bf1497..0437878125 100644
--- a/.gitignore
+++ b/.gitignore
@@ -35,7 +35,7 @@ node_modules
npm-debug.log*
yarn.lock
superset/assets/version_info.json
-
# IntelliJ
*.iml
venv
+superset-dev/*
diff --git a/superset/config.py b/superset/config.py
index ae81cfcb6e..920b662b2d 100644
--- a/superset/config.py
+++ b/superset/config.py
@@ -376,6 +376,7 @@ class CeleryConfig(object):
# geospatial ones) by inputing javascript in controls. This exposes
# an XSS security vulnerability
ENABLE_JAVASCRIPT_CONTROLS = False
+VISUALIZE_ACCESS_ROLE = 'visualize_access'
try:
if CONFIG_PATH_ENV_VAR in os.environ:
diff --git a/superset/views/core.py b/superset/views/core.py
index 5b0ee5f3bc..1305f14fb0 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -2131,14 +2131,23 @@ def sqllab_viz(self):
SqlaTable = ConnectorRegistry.sources['table']
data = json.loads(request.form.get('data'))
table_name = data.get('datasourceName')
+db_id = data.get('dbId')
+
table = (
db.session.query(SqlaTable)
-.filter_by(table_name=table_name)
-.first()
+.filter_by(table_name=table_name, database_id=db_id)
+.first()
)
+
+database = (
+db.session.query(models.Database)
+.filter_by(id=db_id)
+.first()
+)
+
if not table:
-table = SqlaTable(table_name=table_name)
-table.database_id = data.get('dbId')
+table = SqlaTable(table_name=table_name, database_id=db_id,
database=database)
+
q = SupersetQuery(data.get('sql'))
table.sql = q.stripped()
db.session.add(table)
@@ -2181,6 +2190,16 @@ def sqllab_viz(self):
table.columns = cols
table.metrics = metrics
db.session.commit()
+
+role_name = app.config.get('VISUALIZE_ACCESS_ROLE')
+if role_name is not None:
+view_menu_perm = sm.find_permission_view_menu(
+view_menu_name=table.get_perm(),
+permission_name='datasource_access')
+
+role = sm.find_role(role_name)
+sm.add_permission_role(role, view_menu_perm)
+
return self.json_response(json.dumps({
'table_id': table.id,
}))
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] royce-hpcnt opened a new pull request #4554: Merge with dbi-superset
royce-hpcnt opened a new pull request #4554: Merge with dbi-superset URL: https://github.com/apache/incubator-superset/pull/4554 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4553: [landing] Making Dashboards the first/default tab
codecov-io commented on issue #4553: [landing] Making Dashboards the first/default tab URL: https://github.com/apache/incubator-superset/pull/4553#issuecomment-370995410 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4553?src=pr=h1) Report > Merging [#4553](https://codecov.io/gh/apache/incubator-superset/pull/4553?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2e780e403418e6eefc0a91a89d01b3c2622aa0fd?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4553?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4553 +/- ## === Coverage 71.12% 71.12% === Files 187 187 Lines 1478014780 Branches 1083 1083 === Hits1051310513 Misses 4264 4264 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4553?src=pr=tree) | Coverage ? | | |---|---|---| | [superset/assets/javascripts/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4553/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL3dlbGNvbWUvQXBwLmpzeA==) | `94.44% (?)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4553?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4553?src=pr=footer). Last update [2e780e4...09b65bf](https://codecov.io/gh/apache/incubator-superset/pull/4553?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4553: [landing] Making Dashboards the first/default tab
codecov-io commented on issue #4553: [landing] Making Dashboards the first/default tab URL: https://github.com/apache/incubator-superset/pull/4553#issuecomment-370995410 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4553?src=pr=h1) Report > Merging [#4553](https://codecov.io/gh/apache/incubator-superset/pull/4553?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2e780e403418e6eefc0a91a89d01b3c2622aa0fd?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4553?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4553 +/- ## === Coverage 71.12% 71.12% === Files 187 187 Lines 1478014780 Branches 1083 1083 === Hits1051310513 Misses 4264 4264 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4553?src=pr=tree) | Coverage ? | | |---|---|---| | [superset/assets/javascripts/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4553/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL3dlbGNvbWUvQXBwLmpzeA==) | `94.44% (?)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4553?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4553?src=pr=footer). Last update [2e780e4...09b65bf](https://codecov.io/gh/apache/incubator-superset/pull/4553?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] john-bodley opened a new pull request #4553: [landing] Making Dashboards the first/default tab
john-bodley opened a new pull request #4553: [landing] Making Dashboards the first/default tab URL: https://github.com/apache/incubator-superset/pull/4553 @hug I think that the "Recently Viewed" tab still needs some refinement in terms of what we show there, and that user's may be somewhat confused, i.e.,  This PR changes the tab ordering and makes the "Dashboards" tab the first (and thus default) tab, which should seem familiar to the users,  to: @hug @mistercrunch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Podling Report Reminder - March 2018
Dear podling, This email was sent by an automated system on behalf of the Apache Incubator PMC. It is an initial reminder to give you plenty of time to prepare your quarterly board report. The board meeting is scheduled for Wed, 21 March 2018, 10:30 am PDT. The report for your podling will form a part of the Incubator PMC report. The Incubator PMC requires your report to be submitted 2 weeks before the board meeting, to allow sufficient time for review and submission (Wed, March 07). Please submit your report with sufficient time to allow the Incubator PMC, and subsequently board members to review and digest. Again, the very latest you should submit your report is 2 weeks prior to the board meeting. Thanks, The Apache Incubator PMC Submitting your Report -- Your report should contain the following: * Your project name * A brief description of your project, which assumes no knowledge of the project or necessarily of its field * A list of the three most important issues to address in the move towards graduation. * Any issues that the Incubator PMC or ASF Board might wish/need to be aware of * How has the community developed since the last report * How has the project developed since the last report. * How does the podling rate their own maturity. This should be appended to the Incubator Wiki page at: https://wiki.apache.org/incubator/March2018 Note: This is manually populated. You may need to wait a little before this page is created from a template. Mentors --- Mentors should review reports for their project(s) and sign them off on the Incubator wiki page. Signing off reports shows that you are following the project - projects that are not signed may raise alarms for the Incubator PMC. Incubator PMC
[GitHub] john-bodley commented on issue #4543: Setting up compression using flask-compress
john-bodley commented on issue #4543: Setting up compression using flask-compress URL: https://github.com/apache/incubator-superset/pull/4543#issuecomment-370975002 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] john-bodley opened a new pull request #4552: [wip][travis/tox] Restructuring configuration
john-bodley opened a new pull request #4552: [wip][travis/tox] Restructuring configuration URL: https://github.com/apache/incubator-superset/pull/4552 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch opened a new pull request #4551: [sql lab] disable cross schema search
mistercrunch opened a new pull request #4551: [sql lab] disable cross schema search URL: https://github.com/apache/incubator-superset/pull/4551 This is killing our metastore as people type it emits large all-table-dump as they hit the keystroke. It never returns as it times out and hammers the poor metastore. Also some improvements around the disabling the table select on the left panel and having the table name not be sticky. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4550: Evelynturner/annotation timezone fix2
codecov-io commented on issue #4550: Evelynturner/annotation timezone fix2 URL: https://github.com/apache/incubator-superset/pull/4550#issuecomment-370939815 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4550?src=pr=h1) Report > Merging [#4550](https://codecov.io/gh/apache/incubator-superset/pull/4550?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2e780e403418e6eefc0a91a89d01b3c2622aa0fd?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4550?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4550 +/- ## === Coverage 71.12% 71.12% === Files 187 187 Lines 1478014780 Branches 1083 1083 === Hits1051310513 Misses 4264 4264 Partials33 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4550?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4550?src=pr=footer). Last update [2e780e4...ad2b9e2](https://codecov.io/gh/apache/incubator-superset/pull/4550?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hughhhh commented on issue #4543: Setting up compression using flask-compress
hug commented on issue #4543: Setting up compression using flask-compress URL: https://github.com/apache/incubator-superset/pull/4543#issuecomment-370943870 ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4550: Evelynturner/annotation timezone fix2
codecov-io commented on issue #4550: Evelynturner/annotation timezone fix2 URL: https://github.com/apache/incubator-superset/pull/4550#issuecomment-370939815 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4550?src=pr=h1) Report > Merging [#4550](https://codecov.io/gh/apache/incubator-superset/pull/4550?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2e780e403418e6eefc0a91a89d01b3c2622aa0fd?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4550?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4550 +/- ## === Coverage 71.12% 71.12% === Files 187 187 Lines 1478014780 Branches 1083 1083 === Hits1051310513 Misses 4264 4264 Partials33 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4550?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4550?src=pr=footer). Last update [2e780e4...ad2b9e2](https://codecov.io/gh/apache/incubator-superset/pull/4550?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4549: [bugfix] Fixing regression from #4500
codecov-io commented on issue #4549: [bugfix] Fixing regression from #4500 URL: https://github.com/apache/incubator-superset/pull/4549#issuecomment-370939096 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4549?src=pr=h1) Report > Merging [#4549](https://codecov.io/gh/apache/incubator-superset/pull/4549?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2e780e403418e6eefc0a91a89d01b3c2622aa0fd?src=pr=desc) will **increase** coverage by `0.06%`. > The diff coverage is `50%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4549?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4549 +/- ## == + Coverage 71.12% 71.19% +0.06% == Files 187 187 Lines 1478014780 Branches 1083 1083 == + Hits1051310523 +10 + Misses 4264 4254 -10 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4549?src=pr=tree) | Coverage ? | | |---|---|---| | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4549/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `78.45% <50%> (+0.7%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4549?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4549?src=pr=footer). Last update [2e780e4...aef8ad3](https://codecov.io/gh/apache/incubator-superset/pull/4549?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] EvelynTurner opened a new pull request #4550: Evelynturner/annotation timezone fix2
EvelynTurner opened a new pull request #4550: Evelynturner/annotation timezone fix2 URL: https://github.com/apache/incubator-superset/pull/4550 Forgot to make the UTC change for Interval annotation layer as well This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] john-bodley opened a new pull request #4549: [bugfix] Fixing regression from #4500
john-bodley opened a new pull request #4549: [bugfix] Fixing regression from #4500 URL: https://github.com/apache/incubator-superset/pull/4549 This PR fixes a regression with markup visualizations which was introduced in https://github.com/apache/incubator-superset/pull/4500. to: @mistercrunch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] graceguo-supercat closed issue #4547: Dashboard cannot de displayed - TypeError: i.position_json.map is not a function
graceguo-supercat closed issue #4547: Dashboard cannot de displayed - TypeError: i.position_json.map is not a function URL: https://github.com/apache/incubator-superset/issues/4547 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mjgp2 commented on issue #3404: Feature: "Impersonate user" setting on Datasource
mjgp2 commented on issue #3404: Feature: "Impersonate user" setting on Datasource URL: https://github.com/apache/incubator-superset/pull/3404#issuecomment-370918280 Is there anything in the docs about this? Seems like it sets the DB user in the connection string to the superset user name, but I don't understand how the password for that DB user is set? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] grzegorz8 commented on issue #4547: Dashboard cannot de displayed - TypeError: i.position_json.map is not a function
grzegorz8 commented on issue #4547: Dashboard cannot de displayed - TypeError: i.position_json.map is not a function URL: https://github.com/apache/incubator-superset/issues/4547#issuecomment-370914437 It works. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4543: Setting up compression using flask-compress
codecov-io commented on issue #4543: Setting up compression using flask-compress URL: https://github.com/apache/incubator-superset/pull/4543#issuecomment-370913178 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4543?src=pr=h1) Report > Merging [#4543](https://codecov.io/gh/apache/incubator-superset/pull/4543?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2e780e403418e6eefc0a91a89d01b3c2622aa0fd?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4543?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4543 +/- ## == + Coverage 71.12% 71.13% +<.01% == Files 187 187 Lines 1478014782 +2 Branches 1083 1083 == + Hits1051310515 +2 Misses 4264 4264 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4543?src=pr=tree) | Coverage ? | | |---|---|---| | [superset/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/4543/diff?src=pr=tree#diff-c3VwZXJzZXQvX19pbml0X18ucHk=) | `71.69% <100%> (+0.54%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4543?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4543?src=pr=footer). Last update [2e780e4...4351bc9](https://codecov.io/gh/apache/incubator-superset/pull/4543?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4543: Setting up compression using flask-compress
codecov-io commented on issue #4543: Setting up compression using flask-compress URL: https://github.com/apache/incubator-superset/pull/4543#issuecomment-370913178 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4543?src=pr=h1) Report > Merging [#4543](https://codecov.io/gh/apache/incubator-superset/pull/4543?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2e780e403418e6eefc0a91a89d01b3c2622aa0fd?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4543?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4543 +/- ## == + Coverage 71.12% 71.13% +<.01% == Files 187 187 Lines 1478014782 +2 Branches 1083 1083 == + Hits1051310515 +2 Misses 4264 4264 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4543?src=pr=tree) | Coverage ? | | |---|---|---| | [superset/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/4543/diff?src=pr=tree#diff-c3VwZXJzZXQvX19pbml0X18ucHk=) | `71.69% <100%> (+0.54%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4543?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4543?src=pr=footer). Last update [2e780e4...4351bc9](https://codecov.io/gh/apache/incubator-superset/pull/4543?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4543: Setting up compression using flask-compress
codecov-io commented on issue #4543: Setting up compression using flask-compress URL: https://github.com/apache/incubator-superset/pull/4543#issuecomment-370913178 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4543?src=pr=h1) Report > Merging [#4543](https://codecov.io/gh/apache/incubator-superset/pull/4543?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2e780e403418e6eefc0a91a89d01b3c2622aa0fd?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4543?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4543 +/- ## == + Coverage 71.12% 71.13% +<.01% == Files 187 187 Lines 1478014782 +2 Branches 1083 1083 == + Hits1051310515 +2 Misses 4264 4264 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4543?src=pr=tree) | Coverage ? | | |---|---|---| | [superset/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/4543/diff?src=pr=tree#diff-c3VwZXJzZXQvX19pbml0X18ucHk=) | `71.69% <100%> (+0.54%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4543?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4543?src=pr=footer). Last update [2e780e4...4351bc9](https://codecov.io/gh/apache/incubator-superset/pull/4543?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4504: Return __time in Druid scan
codecov-io commented on issue #4504: Return __time in Druid scan URL: https://github.com/apache/incubator-superset/pull/4504#issuecomment-370896700 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4504?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@3a58dc7`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4504?src=pr=tree) ```diff @@Coverage Diff@@ ## master#4504 +/- ## = Coverage ? 71.12% = Files ? 187 Lines ?14781 Branches ? 1083 = Hits ?10513 Misses? 4265 Partials ?3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4504?src=pr=tree) | Coverage ? | | |---|---|---| | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4504/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `77.74% (?)` | | | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4504/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `76.25% <0%> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4504?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4504?src=pr=footer). Last update [3a58dc7...c439307](https://codecov.io/gh/apache/incubator-superset/pull/4504?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on a change in pull request #4543: Setting up compression using flask-compress
mistercrunch commented on a change in pull request #4543: Setting up
compression using flask-compress
URL:
https://github.com/apache/incubator-superset/pull/4543#discussion_r172626995
##
File path: superset/utils.py
##
@@ -838,3 +843,38 @@ def get_filter_key(f):
def get_update_perms_flag():
val = os.environ.get('SUPERSET_UPDATE_PERMS')
return val.lower() not in ('0', 'false', 'no') if val else True
+
+
+def gzipped(f):
Review comment:
Actually ran more tests and you're right, I think the payload I used for
testing didn't meet flask-compress threshold for zipping on my first round of
tests...
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mistercrunch commented on issue #4500: [bugfix] Fixing regression introduced in #4396
mistercrunch commented on issue #4500: [bugfix] Fixing regression introduced in #4396 URL: https://github.com/apache/incubator-superset/pull/4500#issuecomment-370885030 Sounds about right, this area is pretty brittle around the no-query special cases... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] john-bodley commented on issue #4500: [bugfix] Fixing regression introduced in #4396
john-bodley commented on issue #4500: [bugfix] Fixing regression introduced in #4396 URL: https://github.com/apache/incubator-superset/pull/4500#issuecomment-370874347 Sorry @mistercrunch. I think I may have a fix and will add an additional unit test for the `markup` test. I think the solution should be: ``` class MarkupViz(BaseViz): def get_df(self, query_obj=None): return None # like before ``` and ``` def get_payload(self, query_obj=None): ... if df is not None and df.empty: # previously if df is None or df.empty payload['error'] = 'No data' ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ktravis commented on issue #4285: Import CSV File Into PosgreSQL Table. Error: password authentication failed
ktravis commented on issue #4285: Import CSV File Into PosgreSQL Table. Error:
password authentication failed
URL:
https://github.com/apache/incubator-superset/issues/4285#issuecomment-370867065
I was experiencing the same issue and did some digging. It seems that as of
#4298, the call to `create_engine` within `create_table_from_csv` [located
here](https://github.com/apache/incubator-superset/blob/master/superset/db_engine_specs.py#L138)
is using `sqlalchemy_uri` to create a new SQLAlchemy engine. This works as
expected if the URI does not contain a password - however if it does, this
string contains the *masked* password (i.e. ``), and authentication is
attempted using that instead. Changing the line to use
`sqlalchemy_uri_decrypted` instead sends the actual password, resolving the
issue.
For example:
```python
# File "superset/db_engine_specs.py", line ~134
# ...
df_to_db_kwargs = {
'table': table,
'df': df,
'name': form.name.data,
'con': create_engine(form.con.data.sqlalchemy_uri_decrypted,
echo=False),
'schema': form.schema.data,
'if_exists': form.if_exists.data,
'index': form.index.data,
'index_label': form.index_label.data,
'chunksize': 1,
}
# ...
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] xrmx commented on issue #4285: Import CSV File Into PosgreSQL Table. Error: password authentication failed
xrmx commented on issue #4285: Import CSV File Into PosgreSQL Table. Error: password authentication failed URL: https://github.com/apache/incubator-superset/issues/4285#issuecomment-370867774 @ktravis care to open a PR please? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ktravis commented on issue #4285: Import CSV File Into PosgreSQL Table. Error: password authentication failed
ktravis commented on issue #4285: Import CSV File Into PosgreSQL Table. Error: password authentication failed URL: https://github.com/apache/incubator-superset/issues/4285#issuecomment-370867065 I was experiencing the same issue and did some digging. It seems that as of #4298, the call to `create_engine` within `create_table_from_csv` [located here](https://github.com/apache/incubator-superset/blob/master/superset/db_engine_specs.py#L138) is using `sqlalchemy_uri` to create a new SQLAlchemy engine. This works as expected if the URI does not contain a password - however if it does, this string contains the *masked* password (i.e. ``), and authentication is attempted using that instead. Changing the line to use `sqlalchemy_uri_decrypted` instead sends the actual password, resolving the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4500: [bugfix] Fixing regression introduced in #4396
mistercrunch commented on issue #4500: [bugfix] Fixing regression introduced in #4396 URL: https://github.com/apache/incubator-superset/pull/4500#issuecomment-370866365 I think this broke the brittle `markup` viz in trunk. Has to do with the fact that the payload gets a `error` key that says `No data` and the frontend then refuses to render the viz. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4500: [bugfix] Fixing regression introduced in #4396
mistercrunch commented on issue #4500: [bugfix] Fixing regression introduced in #4396 URL: https://github.com/apache/incubator-superset/pull/4500#issuecomment-370866365 I think this broke the brittle `markup` viz. Has to do with the fact that the payload gets a `error` key that says `No data` and the frontend then refuses to render the viz. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on a change in pull request #4543: Setting up compression using flask-compress
mistercrunch commented on a change in pull request #4543: Setting up
compression using flask-compress
URL:
https://github.com/apache/incubator-superset/pull/4543#discussion_r172600154
##
File path: superset/utils.py
##
@@ -838,3 +843,38 @@ def get_filter_key(f):
def get_update_perms_flag():
val = os.environ.get('SUPERSET_UPDATE_PERMS')
return val.lower() not in ('0', 'false', 'no') if val else True
+
+
+def gzipped(f):
Review comment:
Flask-Compress only takes care of static files :( , I agree that this seems
in-scope for it, I'll open a PR with them in parallel to this.
I actually tested by looking at headers and the decorator does do the
difference.
Looks like it's not py3 compatible, going to tweak this now.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] graceguo-supercat commented on issue #4547: Dashboard cannot de displayed - TypeError: i.position_json.map is not a function
graceguo-supercat commented on issue #4547: Dashboard cannot de displayed - TypeError: i.position_json.map is not a function URL: https://github.com/apache/incubator-superset/issues/4547#issuecomment-370864774 #4485 is the fix. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #4542: Removing unused files from MANIFEST.in
mistercrunch closed pull request #4542: Removing unused files from MANIFEST.in URL: https://github.com/apache/incubator-superset/pull/4542 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/MANIFEST.in b/MANIFEST.in index 715c6f1814..e14b66558e 100644 --- a/MANIFEST.in +++ b/MANIFEST.in @@ -1,6 +1,8 @@ recursive-include superset/data * recursive-include superset/migrations * recursive-include superset/static * +recursive-exclude superset/static/assets/docs * +recursive-exclude superset/static/assets/images/viz_thumbnails_large * recursive-exclude superset/static/docs * recursive-exclude superset/static/spec * recursive-exclude superset/static/images/viz_thumbnails_large * This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] john-bodley closed pull request #4548: [wip][dummy]
john-bodley closed pull request #4548: [wip][dummy]
URL: https://github.com/apache/incubator-superset/pull/4548
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/__init__.py b/superset/__init__.py
index 778bb61616..ea924d1022 100644
--- a/superset/__init__.py
+++ b/superset/__init__.py
@@ -33,13 +33,15 @@
app.config.from_object(CONFIG_MODULE)
conf = app.config
+def foobar():
+print('foobar')
+
#
# Handling manifest file logic at app start
#
MANIFEST_FILE = APP_DIR + '/static/assets/dist/manifest.json'
manifest = {}
-
def parse_manifest_json():
global manifest
try:
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] john-bodley closed pull request #4524: [setup] Adding requirements.txt
john-bodley closed pull request #4524: [setup] Adding requirements.txt URL: https://github.com/apache/incubator-superset/pull/4524 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3051d94fdc..09627b5163 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -49,7 +49,7 @@ If you are proposing a feature: implement. - Remember that this is a volunteer-driven project, and that contributions are welcome :) - + ### Questions There is a dedicated [tag](https://stackoverflow.com/questions/tagged/apache-superset) on [stackoverflow](https://stackoverflow.com/). Please use it when asking questions. @@ -98,7 +98,7 @@ to manage the Python packages you're about to install: virtualenv superset-dev source superset-dev/bin/activate -Finally, to make changes to the rst files and build the docs using Sphinx, +Finally, to make changes to the rst files and build the docs using Sphinx, you'll need to install a handful of dependencies from the repo you cloned: cd incubator-superset @@ -177,6 +177,7 @@ Check the [OS dependencies](https://superset.incubator.apache.org/installation.h source env/bin/activate # install for development +pip install -r requirements.txt pip install -e . # Create an admin user @@ -269,11 +270,11 @@ pip install -r dev-reqs.txt All python tests can be run with: ./run_tests.sh - + Alternatively, you can run a specific test with: ./run_specific_test.sh tests.core_tests:CoreTests.test_function_name - + Note that before running specific tests, you have to both setup the local testing environment and run all tests. We use [Mocha](https://mochajs.org/), [Chai](http://chaijs.com/) and [Enzyme](http://airbnb.io/enzyme/) to test Javascript. Tests can be run with: @@ -297,7 +298,7 @@ Codeclimate is a service we use to measure code quality and test coverage. To ge *Install the codeclimate cli tool* ``` -curl -L https://github.com/docker/machine/releases/download/v0.7.0/docker-machine-`uname -s`-`uname -m` > /usr/local/bin/docker-machine && chmod +x /usr/local/bin/docker-machine +curl -L https://github.com/docker/machine/releases/download/v0.7.0/docker-machine-`uname -s`-`uname -m` > /usr/local/bin/docker-machine && chmod +x /usr/local/bin/docker-machine brew install docker docker-machine create --driver virtual box default docker-machine env default @@ -428,7 +429,7 @@ https://github.com/apache/incubator-superset/pull/3013 # copy cp -r /tmp/tmp_superset_docs/ ~/incubator-superset-site.git/ - + # commit and push to `asf-site` branch cd ~/incubator-superset-site.git/ git checkout asf-site diff --git a/dev-reqs.txt b/dev-reqs.txt index 91a74d6a44..3b69ffdc96 100644 --- a/dev-reqs.txt +++ b/dev-reqs.txt @@ -6,6 +6,7 @@ ipdb mock mysqlclient nose +pip-tools psycopg2 pylint pyyaml diff --git a/requirements.txt b/requirements.txt new file mode 100644 index 00..8c3010582f --- /dev/null +++ b/requirements.txt @@ -0,0 +1,39 @@ +bleach==2.1.2 +boto3==1.4.7 +celery==4.1.0 +colorama==0.3.9 +cryptography==1.9 +flask==0.12.2 +flask-appbuilder==1.9.6 +flask-cache==0.13.1 +flask-migrate==2.1.1 +flask-script==2.0.6 +flask-sqlalchemy==2.1 +flask-testing==0.7.1 +flask-wtf==0.14.2 +flower==0.9.2 +future==0.16.0 +geopy==1.11.0 +gunicorn==19.7.1 +humanize==0.5.1 +idna==2.6 +markdown==2.6.11 +pandas==0.22.0 +parsedatetime==2.0.0 +pathlib2==2.3.0 +polyline==1.3.2 +pydruid==0.4.1 +pyhive==0.5.0 +python-dateutil==2.6.1 +python-geohash==0.8.5 +pyyaml==3.12 +requests==2.18.4 +simplejson==3.13.2 +six==1.11.0 +sqlalchemy==1.2.2 +sqlalchemy-utils==0.32.21 +sqlparse==0.2.4 +thrift==0.11.0 +thrift-sasl==0.3.0 +unicodecsv==0.14.1 +unidecode==1.0.22 diff --git a/setup.py b/setup.py index c32696e698..24a01536c2 100644 --- a/setup.py +++ b/setup.py @@ -50,48 +50,48 @@ def get_git_sha(): zip_safe=False, scripts=['superset/bin/superset'], install_requires=[ +'bleach', 'boto3>=1.4.6', -'celery==4.1.0', -'colorama==0.3.9', -'cryptography==1.9', -'flask==0.12.2', -'flask-appbuilder==1.9.6', -'flask-cache==0.13.1', -'flask-migrate==2.1.1', -'flask-script==2.0.6', -'flask-sqlalchemy==2.1', -'flask-testing==0.7.1', -'flask-wtf==0.14.2', -'flower==0.9.2', +'celery', +'colorama', +'cryptography', +'flask', +'flask-appbuilder', +'flask-cache', +'flask-migrate', +'flask-script', +'flask-sqlalchemy', +'flask-testing', +'flask-wtf', +'flower', 'future>=0.16.0, <0.17', -'geopy==1.11.0', -
[GitHub] john-bodley commented on issue #4524: [setup] Adding requirements.txt
john-bodley commented on issue #4524: [setup] Adding requirements.txt URL: https://github.com/apache/incubator-superset/pull/4524#issuecomment-370854139 Closing this in favor of incorporating this logic into a broader PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] john-bodley opened a new pull request #4548: [wip][dummy]
john-bodley opened a new pull request #4548: [wip][dummy] URL: https://github.com/apache/incubator-superset/pull/4548 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] john-bodley commented on a change in pull request #4543: Setting up compression using flask-compress
john-bodley commented on a change in pull request #4543: Setting up compression
using flask-compress
URL:
https://github.com/apache/incubator-superset/pull/4543#discussion_r172569182
##
File path: superset/utils.py
##
@@ -838,3 +843,38 @@ def get_filter_key(f):
def get_update_perms_flag():
val = os.environ.get('SUPERSET_UPDATE_PERMS')
return val.lower() not in ('0', 'false', 'no') if val else True
+
+
+def gzipped(f):
Review comment:
Max is this required? I felt that `Flask-Compress` takes care of all of
this. Also would it be possible to report the time it takes to execute the
`sql_json` and `explore_json` endpoints w/ and w/o caching?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] john-bodley closed pull request #4533: [coverage] Replacing coveralls with codecov
john-bodley closed pull request #4533: [coverage] Replacing coveralls with
codecov
URL: https://github.com/apache/incubator-superset/pull/4533
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.coveralls.yml b/.coveralls.yml
deleted file mode 100644
index e916d8ed05..00
--- a/.coveralls.yml
+++ /dev/null
@@ -1 +0,0 @@
-repo_token: 4P9MpvLrZfJKzHdGZsdV3MzO43OZJgYFn
diff --git a/.travis.yml b/.travis.yml
index ba589d4590..0a21126e69 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -27,5 +27,7 @@ before_script:
- export PATH=${PATH}:/tmp/hive/bin
install:
- pip install --upgrade pip
- - pip install tox tox-travis
+ - pip install codecov tox tox-travis
script: tox -e $TOX_ENV
+after_success:
+ - codecov
diff --git a/README.md b/README.md
index ef5464ee6c..a205a1c2c5 100644
--- a/README.md
+++ b/README.md
@@ -3,7 +3,7 @@ Superset
[](https://travis-ci.org/apache/incubator-superset)
[](https://badge.fury.io/py/superset)
-[](https://coveralls.io/github/apache/incubator-superset?branch=master)
+[](https://codecov.io/github/apache/incubator-superset)
[](https://pypi.python.org/pypi/superset)
[](https://requires.io/github/apache/incubator-superset/requirements/?branch=master)
[](https://gitter.im/airbnb/superset?utm_source=badge_medium=badge_campaign=pr-badge_content=badge)
@@ -165,7 +165,7 @@ the world know they are using Superset. Join our growing
community!
- [Konf?o](http://konfio.mx)
- [Lyft](https://www.lyft.com/)
- [Maieutical Labs](https://cloudschooling.it)
- - [PeopleDoc](https://www.people-doc.com)
+ - [PeopleDoc](https://www.people-doc.com)
- [Ona](https://ona.io)
- [Pronto Tools](http://www.prontotools.io)
- [Qunar](https://www.qunar.com/)
diff --git a/dev-reqs.txt b/dev-reqs.txt
index 91a74d6a44..b565fbdf23 100644
--- a/dev-reqs.txt
+++ b/dev-reqs.txt
@@ -1,5 +1,4 @@
codeclimate-test-reporter
-coveralls
flake8
flask_cors
ipdb
diff --git a/run_tests.sh b/run_tests.sh
index de40d6c75c..0648b5703c 100755
--- a/run_tests.sh
+++ b/run_tests.sh
@@ -10,6 +10,3 @@ set -e
superset/bin/superset db upgrade
superset/bin/superset version -v
python setup.py nosetests
-if [ "$CI" = "true" ] ; then
- coveralls
-fi
diff --git a/tox.ini b/tox.ini
index 280bcb4798..efdb8aba74 100644
--- a/tox.ini
+++ b/tox.ini
@@ -45,13 +45,8 @@ whitelist_externals =
npm
passenv =
HOME
-TRAVIS
-TRAVIS_BRANCH
-TRAVIS_BUILD_DIR
-TRAVIS_JOB_ID
USER
TRAVIS_CACHE
-TRAVIS_PULL_REQUEST
PATH
commands =
python --version
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] john-bodley commented on issue #4542: Removing unused files from MANIFEST.in
john-bodley commented on issue #4542: Removing unused files from MANIFEST.in URL: https://github.com/apache/incubator-superset/pull/4542#issuecomment-370830333 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] grzegorz8 opened a new issue #4547: Dashboard cannot de displayed - TypeError: i.position_json.map is not a function
grzegorz8 opened a new issue #4547: Dashboard cannot de displayed - TypeError: i.position_json.map is not a function URL: https://github.com/apache/incubator-superset/issues/4547 ### Superset version 0.23.2 ### Expected results Created dashboard should be shown with all its charts. ### Actual results Dashboard is now shown.  The browser console shows:  There are no errors / stacktraces from python code. ### Steps to reproduce 1. Create a chart. 2. Create a dashboard. 3. Add the chart to the dashboard. 4. Open the dashboard. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] schneems commented on issue #4539: Add CodeTriage badge to airbnb/caravel
schneems commented on issue #4539: Add CodeTriage badge to airbnb/caravel URL: https://github.com/apache/incubator-superset/pull/4539#issuecomment-370829859 Done and done https://www.codetriage.com/apache/incubator-superset. Let me know if you're interested in a fixed PR . This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] schneems commented on issue #4539: Add CodeTriage badge to airbnb/caravel
schneems commented on issue #4539: Add CodeTriage badge to airbnb/caravel URL: https://github.com/apache/incubator-superset/pull/4539#issuecomment-370828683 Thank's for the heads up. I'll rename the project on CodeTriage. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mausch commented on issue #4407: Error on SQL execution: "Could not broadcast input array from shape (26896) into shape (1,164)"
mausch commented on issue #4407: Error on SQL execution: "Could not broadcast input array from shape (26896) into shape (1,164)" URL: https://github.com/apache/incubator-superset/issues/4407#issuecomment-370828049 Same here. Seems it can only execute queries returning scalars, anything else throws that error. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jeffreythewang commented on issue #3603: 'Null' value is being displayed as '0' in the data retrieved.
jeffreythewang commented on issue #3603: 'Null' value is being displayed as '0' in the data retrieved. URL: https://github.com/apache/incubator-superset/issues/3603#issuecomment-370808954 Correct me if I'm wrong, but I believe this issue is fixed with https://github.com/apache/incubator-superset/pull/4358 Are you still seeing the issue on the latest version? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asyd commented on issue #4546: Can't create two tables from differents bases but where same schema / tablename
asyd commented on issue #4546: Can't create two tables from differents bases but where same schema / tablename URL: https://github.com/apache/incubator-superset/issues/4546#issuecomment-370797926 ahh my bad, I searched only in opened issues. dup of #3829 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asyd closed issue #4546: Can't create two tables from differents bases but where same schema / tablename
asyd closed issue #4546: Can't create two tables from differents bases but where same schema / tablename URL: https://github.com/apache/incubator-superset/issues/4546 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #4546: Can't create two tables from differents bases but where same schema / tablename
xrmx commented on issue #4546: Can't create two tables from differents bases but where same schema / tablename URL: https://github.com/apache/incubator-superset/issues/4546#issuecomment-370796752 I think this is already reported, possibly more than one time. UPDATE: and maybe already been fixed. I remember a PR updating models wrt this issue This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #4546: Can't create two tables from differents bases but where same schema / tablename
xrmx commented on issue #4546: Can't create two tables from differents bases but where same schema / tablename URL: https://github.com/apache/incubator-superset/issues/4546#issuecomment-370796752 I think this is already reported, possibly more than one time This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asyd opened a new issue #4546: Can't create two tables from differents bases but where same schema / tablename
asyd opened a new issue #4546: Can't create two tables from differents bases but where same schema / tablename URL: https://github.com/apache/incubator-superset/issues/4546 Make sure these boxes are checked before submitting your issue - thank you! - [x] I have checked the superset logs for python stacktraces and included it here as text if any - [x] I have reproduced the issue with at least the latest released version of superset - [x] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version 0.22.1 ### Expected results Possibility to add two tables with the same schema / table name but with different sources ### Actual results `Integrity error, probably unique constraint` ### Steps to reproduce Create a database named 'UAT', create a database named 'PROD'. Create two tables with the same schema and same table name but using different databases. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Pek1s opened a new pull request #4545: add two more number formats, add number formats to table
Pek1s opened a new pull request #4545: add two more number formats, add number formats to table URL: https://github.com/apache/incubator-superset/pull/4545 Add option to change number formats to table view. Add more suitable formats to number formats. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yamyamyuo commented on issue #2914: How to create a customized dashboard-based permission?
yamyamyuo commented on issue #2914: How to create a customized dashboard-based permission? URL: https://github.com/apache/incubator-superset/issues/2914#issuecomment-370710635 > I would like to have all datasources in the dashboard be automatically granted permission to role once the dashboard permission has been granted, just like when granting permission to the entire database. How should I go about to change that? So what's going on with this feature? I have the same desire... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] 296537044 closed issue #4498: how to shutdown superset gracefully
296537044 closed issue #4498: how to shutdown superset gracefully URL: https://github.com/apache/incubator-superset/issues/4498 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] 296537044 opened a new issue #4544: SQL Editor preview error, choose Hive table and preview throws error. version is v0.22.1.bug?
296537044 opened a new issue #4544: SQL Editor preview error, choose Hive table and preview throws error. version is v0.22.1.bug? URL: https://github.com/apache/incubator-superset/issues/4544 SQL Editor preview error, choose Hive table and preview throws error. version is v0.22.1. ### Superset version v0.22.1 ### Actual results Error while compiling statement: FAILED: SemanticException [Error 10008]: Line 26:5 Ambiguous table alias '8_1' ### Steps to reproduce add hive DataSource? go to SQL Editor page select a table like '8_1' ### what i found. i found that after i choose a table like '8_1', front page will post sql like that: SELECT `vbr`, `type`, `date` FROM `default`.`8_1`, default.8_1 here has two table to select,but i just choose one. Is this a bug? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
