[GitHub] codecov-io commented on issue #4590: Removing escape_sql so we dont double escape

[GitBox]

codecov-io commented on issue #4590: Removing escape_sql so we dont double 
escape
URL: 
https://github.com/apache/incubator-superset/pull/4590#issuecomment-371979771
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4590?src=pr=h1)
 Report
   > Merging 
[#4590](https://codecov.io/gh/apache/incubator-superset/pull/4590?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/f9881101ee9cd447f7ccb2d38bc7563f31f686c5?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4590/graphs/tree.svg?width=650=150=KsB0fHcx6l=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4590?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4590  +/-   ##
   ==
   + Coverage   71.17%   71.18%   +<.01% 
   ==
 Files 188  188  
 Lines   1483414828   -6 
 Branches 1086 1086  
   ==
   - Hits1055810555   -3 
   + Misses   4273 4270   -3 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4590?src=pr=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4590/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5)
 | `52.26%  (+0.01%)` | :arrow_up: |
   | 
[superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4590/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==)
 | `77.91%  (+0.11%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4590?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4590?src=pr=footer).
 Last update 
[f988110...e1af421](https://codecov.io/gh/apache/incubator-superset/pull/4590?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4590: Removing escape_sql so we dont double escape

[GitBox]

codecov-io commented on issue #4590: Removing escape_sql so we dont double 
escape
URL: 
https://github.com/apache/incubator-superset/pull/4590#issuecomment-371979771
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4590?src=pr=h1)
 Report
   > Merging 
[#4590](https://codecov.io/gh/apache/incubator-superset/pull/4590?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/f9881101ee9cd447f7ccb2d38bc7563f31f686c5?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4590/graphs/tree.svg?token=KsB0fHcx6l=pr=150=650)](https://codecov.io/gh/apache/incubator-superset/pull/4590?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4590  +/-   ##
   ==
   + Coverage   71.17%   71.18%   +<.01% 
   ==
 Files 188  188  
 Lines   1483414828   -6 
 Branches 1086 1086  
   ==
   - Hits1055810555   -3 
   + Misses   4273 4270   -3 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4590?src=pr=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4590/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==)
 | `77.91%  (+0.11%)` | :arrow_up: |
   | 
[superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4590/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5)
 | `52.26%  (+0.01%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4590?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4590?src=pr=footer).
 Last update 
[f988110...e1af421](https://codecov.io/gh/apache/incubator-superset/pull/4590?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] michellethomas commented on issue #4590: Removing escape_sql so we dont double escape

[GitBox]

michellethomas commented on issue #4590: Removing escape_sql so we dont double 
escape
URL: 
https://github.com/apache/incubator-superset/pull/4590#issuecomment-371979610
 
 
   @mistercrunch we are a little unsure what would have caused this regression, 
as nothing seems to have changed in the related code recently. It looks like in 
sqlalchemy 1.2 they did some work to their 
[autoescape](http://docs.sqlalchemy.org/en/latest/changelog/changelog_12.html) 
feature. Maybe our sqlalchemy upgrade caused this issue, but it's a little 
unclear. Any thoughts on why we might be seeing double % escaping? Anything 
else we should be aware of in removing this part of the code?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] michellethomas commented on issue #4590: Removing escape_sql so we dont double escape

[GitBox]

michellethomas commented on issue #4590: Removing escape_sql so we dont double 
escape
URL: 
https://github.com/apache/incubator-superset/pull/4590#issuecomment-371979610
 
 
   @mistercrunch we are a little unsure what would have caused this regression, 
as nothing seems to have changed in the related code recently. It looks like in 
sqlalchemy 1.2 they did some work to their autoescape feature. Maybe our 
sqlalchemy upgrade caused this issue, but it's a little unclear. Any thoughts 
on why we might be seeing double % escaping? Anything else we should be aware 
of in removing this part of the code?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] michellethomas opened a new pull request #4590: Removing escape_sql so we dont double escape

[GitBox]

michellethomas opened a new pull request #4590: Removing escape_sql so we dont 
double escape
URL: https://github.com/apache/incubator-superset/pull/4590
 
 
   @john-bodley Removing escape_sql because this seems to be handled by 
`qry.compile(engine)` 
[here](https://github.com/apache/incubator-superset/blob/master/superset/connectors/sqla/models.py#L411)
 and both of them escaping double escapes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed pull request #4532: histograms: fixup left margin assigment

[GitBox]

mistercrunch closed pull request #4532: histograms: fixup left margin assigment
URL: https://github.com/apache/incubator-superset/pull/4532
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/visualizations/histogram.js 
b/superset/assets/visualizations/histogram.js
index b4bf6fcc74..2f29231110 100644
--- a/superset/assets/visualizations/histogram.js
+++ b/superset/assets/visualizations/histogram.js
@@ -13,12 +13,11 @@ function histogram(slice, payload) {
 
   const draw = function () {
 // Set Margins
-const left = yAxisLabel ? 70 : 50;
 const margin = {
   top: 50,
   right: 10,
   bottom: 20,
-  left,
+  left: yAxisLabel ? 70 : 50,
 };
 const navBarHeight = 36;
 const navBarBuffer = 10;


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] danatvzw opened a new issue #4589: Problem installing sasl

[GitBox]

danatvzw opened a new issue #4589: Problem installing sasl
URL: https://github.com/apache/incubator-superset/issues/4589
 
 
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [x ] I have checked the superset logs for python stacktraces and included 
it here as text if any
   - [ x] I have reproduced the issue with at least the latest released version 
of superset
   - [ x] I have checked the issue tracker for the same issue and I haven't 
found one similar
   Receiving the following error when attempting to install:
   "Command "/usr/bin/python2.7 -u -c "import setuptools, 
tokenize;__file__='/tmp/pip-build-enrh6u/sasl/setup.py';f=getattr(tokenize, 
'open', open)(__file__);code=f.read().replace('\r\n', 
'\n');f.close();exec(compile(code, __file__, 'exec'))" install --record 
/tmp/pip-qb9oVE-record/install-record.txt --single-version-externally-managed 
--compile" failed with error code 1 in /tmp/pip-build-enrh6u/sasl/"
   
   
   ### Superset version
   superset-0.23.2
   setuptools-38.5.2
   pip-9.0.1
   sasl-0.2.1
   python 2.7
   OS: solaris 2.11
   ### Expected results
   Successful installation
   
   ### Actual results
   'cc' command failed with exit status 1
   
   ### Steps to reproduce
   python setup.py install 
   or
   pip install sasl==0.2.1
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed pull request #4504: Return __time in Druid scan

[GitBox]

mistercrunch closed pull request #4504: Return __time in Druid scan
URL: https://github.com/apache/incubator-superset/pull/4504
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/visualizations/deckgl/layers/scatter.jsx 
b/superset/assets/visualizations/deckgl/layers/scatter.jsx
index 087df3d7ef..26d320c502 100644
--- a/superset/assets/visualizations/deckgl/layers/scatter.jsx
+++ b/superset/assets/visualizations/deckgl/layers/scatter.jsx
@@ -14,7 +14,7 @@ import { unitToRadius } from 
'../../../javascripts/modules/geo';
 import sandboxedEval from '../../../javascripts/modules/sandbox';
 
 function getStep(timeGrain) {
-  // grain in microseconds
+  // grain in milliseconds
   const MINUTE = 60 * 1000;
   const HOUR = 60 * MINUTE;
   const DAY = 24 * HOUR;
diff --git a/superset/connectors/druid/models.py 
b/superset/connectors/druid/models.py
index a16baf1039..0541af07e7 100644
--- a/superset/connectors/druid/models.py
+++ b/superset/connectors/druid/models.py
@@ -130,7 +130,8 @@ def get_datasources(self):
 return json.loads(requests.get(endpoint).text)
 
 def get_druid_version(self):
-endpoint = self.get_base_coordinator_url() + '/status'
+endpoint = self.get_base_url(
+self.coordinator_host, self.coordinator_port) + '/status'
 return json.loads(requests.get(endpoint).text)['version']
 
 def refresh_datasources(
@@ -1114,6 +1115,7 @@ def run_query(  # noqa / druid
 order_direction = 'descending' if order_desc else 'ascending'
 
 if columns:
+columns.append('__time')
 del qry['post_aggregations']
 del qry['aggregations']
 qry['dimensions'] = columns
diff --git a/superset/viz.py b/superset/viz.py
index 31e06967a1..1adc16a117 100644
--- a/superset/viz.py
+++ b/superset/viz.py
@@ -2040,7 +2040,7 @@ def get_properties(self, d):
 'radius': self.fixed_value if self.fixed_value else 
d.get(self.metric),
 'cat_color': d.get(self.dim) if self.dim else None,
 'position': d.get('spatial'),
-'__timestamp': d.get('__timestamp'),
+'__timestamp': d.get(DTTM_ALIAS) or d.get('__time'),
 }
 
 def get_data(self, df):


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed pull request #4584: [sqllab] Added share button to bottom menu

[GitBox]

mistercrunch closed pull request #4584: [sqllab] Added share button to bottom 
menu
URL: https://github.com/apache/incubator-superset/pull/4584
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/javascripts/SqlLab/components/ShareQuery.jsx 
b/superset/assets/javascripts/SqlLab/components/ShareQuery.jsx
new file mode 100644
index 00..56556ac5dd
--- /dev/null
+++ b/superset/assets/javascripts/SqlLab/components/ShareQuery.jsx
@@ -0,0 +1,22 @@
+import React from 'react';
+
+import CopyToClipboard from '../../components/CopyToClipboard';
+import CopyQueryTabUrl from './CopyQueryTabUrl';
+import Button from '../../components/Button';
+import { t } from '../../locales';
+
+export default class ShareQueryBtn extends CopyQueryTabUrl {
+  render() {
+return (
+  
+ {t('Share Query')}
+  
+  )}
+tooltipText={t('copy URL to clipboard')}
+shouldShowText={false}
+getText={this.getUrl.bind(this)}
+  />);
+  }
+}
diff --git a/superset/assets/javascripts/SqlLab/components/SqlEditor.jsx 
b/superset/assets/javascripts/SqlLab/components/SqlEditor.jsx
index 3eab16c3b9..40099e1b71 100644
--- a/superset/assets/javascripts/SqlLab/components/SqlEditor.jsx
+++ b/superset/assets/javascripts/SqlLab/components/SqlEditor.jsx
@@ -19,6 +19,7 @@ import Button from '../../components/Button';
 import TemplateParamsEditor from './TemplateParamsEditor';
 import SouthPane from './SouthPane';
 import SaveQuery from './SaveQuery';
+import ShareQuery from './ShareQuery';
 import Timer from '../../components/Timer';
 import SqlEditorLeftBar from './SqlEditorLeftBar';
 import AceEditorWrapper from './AceEditorWrapper';
@@ -195,6 +196,9 @@ class SqlEditor extends React.PureComponent {
 dbId={qe.dbId}
   />
 
+
+  
+
 {ctasControls}
   
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] williaster commented on a change in pull request #4566: Adding column type label to dropdowns

[GitBox]

williaster commented on a change in pull request #4566: Adding column type 
label to dropdowns
URL: 
https://github.com/apache/incubator-superset/pull/4566#discussion_r173588482
 
 

 ##
 File path: superset/assets/spec/javascripts/components/ColumnTypeLabel_spec.jsx
 ##
 @@ -0,0 +1,62 @@
+import React from 'react';
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import { shallow } from 'enzyme';
+
+import ColumnTypeLabel from '../../../javascripts/components/ColumnTypeLabel';
+
+describe('ColumnOption', () => {
+  const defaultProps = {
+type: 'string',
+  };
+
+  let wrapper;
+  let props;
+  const factory = o => ;
 
 Review comment:
   I know there are a lot of places that do this already, but single character 
variable names don't facilitate readability.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] williaster commented on a change in pull request #4566: Adding column type label to dropdowns

[GitBox]

williaster commented on a change in pull request #4566: Adding column type 
label to dropdowns
URL: 
https://github.com/apache/incubator-superset/pull/4566#discussion_r173589480
 
 

 ##
 File path: superset/assets/spec/javascripts/components/ColumnTypeLabel_spec.jsx
 ##
 @@ -0,0 +1,62 @@
+import React from 'react';
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import { shallow } from 'enzyme';
+
+import ColumnTypeLabel from '../../../javascripts/components/ColumnTypeLabel';
+
+describe('ColumnOption', () => {
+  const defaultProps = {
+type: 'string',
+  };
+
+  let wrapper;
+  let props;
+  const factory = o => ;
+  beforeEach(() => {
+wrapper = shallow(factory(defaultProps));
+props = Object.assign({}, defaultProps);
 
 Review comment:
   I think this pattern for test setup is difficult to read in terms of what 
props are actually applied and it seems strange to allow tests to modify the 
`props` object directly / reset them every test . I've also seen several code 
bases move away from using shared `let` variables because it can result in race 
conditions in more complex tests.
   
   a more readable and common pattern I've seen is:
   
   ```javascript
   const props = { ...defaultProps };
   
   describe('MyComponent', () => {
 function setup(overrides) {
   const wrapper = shallow();
   return wrapper;
 }
   
 it('does something', () => {
   const wrapper = setup(/* { optional: override } */);
   expect(...);
 });
   
 ...
   });
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed pull request #4551: [sql lab] option to disable cross schema search

[GitBox]

mistercrunch closed pull request #4551: [sql lab] option to disable cross 
schema search
URL: https://github.com/apache/incubator-superset/pull/4551
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/javascripts/SqlLab/components/SqlEditor.jsx 
b/superset/assets/javascripts/SqlLab/components/SqlEditor.jsx
index 3eab16c3b9..682c7053aa 100644
--- a/superset/assets/javascripts/SqlLab/components/SqlEditor.jsx
+++ b/superset/assets/javascripts/SqlLab/components/SqlEditor.jsx
@@ -241,6 +241,7 @@ class SqlEditor extends React.PureComponent {
 >
   
 
@@ -186,7 +195,6 @@ class SqlEditorLeftBar extends React.PureComponent {
   name="select-table"
   ref="selectTable"
   isLoading={this.state.tableLoading}
-  value={this.state.tableName}
   placeholder={t('Add a table (%s)', 
this.state.tableOptions.length)}
   autosize={false}
   onChange={this.changeTable.bind(this)}
@@ -199,8 +207,8 @@ class SqlEditorLeftBar extends React.PureComponent {
   async
   name="async-select-table"
   ref="selectTable"
-  value={this.state.tableName}
-  placeholder={t('Type to search ...')}
+  placeholder={tableSelectPlaceholder}
+  disabled={tableSelectDisabled}
   autosize={false}
   onChange={this.changeTable.bind(this)}
   loadOptions={this.getTableNamesBySubStr.bind(this)}
diff --git a/superset/assets/spec/javascripts/sqllab/SqlEditorLeftBar_spec.jsx 
b/superset/assets/spec/javascripts/sqllab/SqlEditorLeftBar_spec.jsx
index 9c90661fee..5755c658d9 100644
--- a/superset/assets/spec/javascripts/sqllab/SqlEditorLeftBar_spec.jsx
+++ b/superset/assets/spec/javascripts/sqllab/SqlEditorLeftBar_spec.jsx
@@ -23,6 +23,7 @@ describe('SqlEditorLeftBar', () => {
 },
 tables: [table],
 queryEditor: defaultQueryEditor,
+database: {},
 height: 0,
   };
 
diff --git a/superset/assets/spec/javascripts/sqllab/TabbedSqlEditors_spec.jsx 
b/superset/assets/spec/javascripts/sqllab/TabbedSqlEditors_spec.jsx
index 35f8a45ee7..11e889eefb 100644
--- a/superset/assets/spec/javascripts/sqllab/TabbedSqlEditors_spec.jsx
+++ b/superset/assets/spec/javascripts/sqllab/TabbedSqlEditors_spec.jsx
@@ -51,6 +51,7 @@ describe('TabbedSqlEditors', () => {
 tabHistory: initialState.tabHistory,
 editorHeight: '',
 getHeight: () => ('100px'),
+database: {},
   };
   const getWrapper = () => (
 shallow(, {
diff --git 
a/superset/migrations/versions/e68c4473c581_allow_multi_schema_metadata_fetch.py
 
b/superset/migrations/versions/e68c4473c581_allow_multi_schema_metadata_fetch.py
new file mode 100644
index 00..dab7cb6079
--- /dev/null
+++ 
b/superset/migrations/versions/e68c4473c581_allow_multi_schema_metadata_fetch.py
@@ -0,0 +1,30 @@
+"""allow_multi_schema_metadata_fetch
+
+Revision ID: e68c4473c581
+Revises: e866bd2d4976
+Create Date: 2018-03-06 12:24:30.896293
+
+"""
+from alembic import op
+import sqlalchemy as sa
+
+# revision identifiers, used by Alembic.
+revision = 'e68c4473c581'
+down_revision = 'e866bd2d4976'
+
+
+def upgrade():
+
+op.add_column(
+'dbs',
+sa.Column(
+'allow_multi_schema_metadata_fetch',
+sa.Boolean(),
+nullable=True,
+default=True,
+),
+)
+
+
+def downgrade():
+op.drop_column('dbs', 'allow_multi_schema_metadata_fetch')
diff --git a/superset/models/core.py b/superset/models/core.py
index b4dbada947..466b9f62f6 100644
--- a/superset/models/core.py
+++ b/superset/models/core.py
@@ -567,6 +567,7 @@ class Database(Model, AuditMixinNullable, ImportMixin):
 allow_ctas = Column(Boolean, default=False)
 allow_dml = Column(Boolean, default=False)
 force_ctas_schema = Column(String(250))
+allow_multi_schema_metadata_fetch = Column(Boolean, default=True)
 extra = Column(Text, default=textwrap.dedent("""\
 {
 "metadata_params": {},
@@ -593,6 +594,8 @@ def data(self):
 return {
 'name': self.database_name,
 'backend': self.backend,
+'allow_multi_schema_metadata_fetch':
+self.allow_multi_schema_metadata_fetch,
 }
 
 @property
@@ -733,6 +736,8 @@ def inspector(self):
 
 def all_table_names(self, schema=None, force=False):
 if not schema:
+if not self.allow_multi_schema_metadata_fetch:
+return []
 tables_dict = self.db_engine_spec.fetch_result_sets(
 self, 'table', force=force)
 return tables_dict.get('', [])
@@ -741,6 +746,8 @@ def all_table_names(self, schema=None, 

[GitHub] timifasubaa opened a new issue #4588: [sqllab] How can we make large Superset queries load faster?

[GitBox]

timifasubaa opened a new issue #4588: [sqllab] How can we make large Superset 
queries load faster?
URL: https://github.com/apache/incubator-superset/issues/4588
 
 
   I'm looking into the possibility of making large superset queries load 
faster. And I want members of the community to share ideas here. 
   Many times, users run a long query for a slice and get stuck waiting for a 
long time to get tens of thousands of rows they don't intend to see. Before 
users can see the query the whole query has to run and there usually is a round 
trip to s3. This takes a really long time.
   
   For inspiration, the Presto/Hive CLI returns almost immediately because it 
uses something like the `less` bash command to load results immediately there 
are some rows. 
   
   There is a way to know if any data has been loaded in handle_cursor 
(https://github.com/apache/incubator-superset/blob/31a995714df49e55ff69474378845fd8af605d4b/superset/db_engine_specs.py#L617)
   I'm curious how we can load data from the curso
   
   The most basic idea is to make every query 2 queries. One query with a small 
limit (100?) and a View more button / loading icon so users don't wrongly 
assume that's all the results, while the actual full query keeps running. 
   
   I think we can do better than this starting idea. In particular, we 
shouldn't need 2 queries. Please share your thoughts. 
   
   @fabianmenges @hug @john-bodley  @michellethomas  @mistercrunch 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4572: Legend for deck.gl scatterplot

[GitBox]

codecov-io commented on issue #4572: Legend for deck.gl scatterplot
URL: 
https://github.com/apache/incubator-superset/pull/4572#issuecomment-371399030
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4572?src=pr=h1)
 Report
   > Merging 
[#4572](https://codecov.io/gh/apache/incubator-superset/pull/4572?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/9ad50c9d556a2fd333c1b9933140b46c91b42c69?src=pr=desc)
 will **decrease** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4572/graphs/tree.svg?token=KsB0fHcx6l=650=150=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4572?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4572  +/-   ##
   ==
   - Coverage71.2%   71.17%   -0.03% 
   ==
 Files 187  187  
 Lines   1478514813  +28 
 Branches 1083 1085   +2 
   ==
   + Hits1052710543  +16 
   - Misses   4255 4267  +12 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4572?src=pr=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[...rset/assets/javascripts/explore/stores/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/4572/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL3Zpc1R5cGVzLmpz)
 | `70.58%  (?)` | :arrow_up: |
   | 
[...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4572/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==)
 | `38.16%  (?)` | :arrow_up: |
   | 
[superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/4572/diff?src=pr=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==)
 | `73.33% <0%> (-4.93%)` | :arrow_down: |
   | 
[superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/4572/diff?src=pr=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==)
 | `74.21% <0%> (-0.13%)` | :arrow_down: |
   | 
[...cripts/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4572/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=)
 | `0% <0%> (?)` | :arrow_up: |
   | 
[superset/assets/javascripts/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4572/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvaW5kZXguanN4)
 | `0% <0%> (?)` | :arrow_up: |
   | 
[superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4572/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==)
 | `71.2% <0%> (+0.04%)` | :arrow_up: |
   | 
[superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4572/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
 | `92.18% <0%> (+0.06%)` | :arrow_up: |
   | ... and [2 
more](https://codecov.io/gh/apache/incubator-superset/pull/4572/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4572?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4572?src=pr=footer).
 Last update 
[9ad50c9...77ca442](https://codecov.io/gh/apache/incubator-superset/pull/4572?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] evgenyfadeev commented on issue #4518: Add Admin Reset Password Capability

[GitBox]

evgenyfadeev commented on issue #4518: Add Admin Reset Password Capability
URL: 
https://github.com/apache/incubator-superset/issues/4518#issuecomment-371936474
 
 
   Would be great to be able to change user's passwords via the UI. Admins can 
create users with new passwords via the UI and it would make sense to allow 
creating a new password as well.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4514: Added new exception class and start of better exception/error handling

[GitBox]

codecov-io commented on issue #4514: Added new exception class and start of 
better exception/error handling
URL: 
https://github.com/apache/incubator-superset/pull/4514#issuecomment-371323920
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4514?src=pr=h1)
 Report
   > Merging 
[#4514](https://codecov.io/gh/apache/incubator-superset/pull/4514?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/b512da8002dc0dc7f6a1f5eb983606118f484d32?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `92.3%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4514/graphs/tree.svg?token=KsB0fHcx6l=150=650=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4514?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4514  +/-   ##
   ==
   + Coverage   71.17%   71.18%   +<.01% 
   ==
 Files 187  188   +1 
 Lines   1480914824  +15 
 Branches 1085 1085  
   ==
   + Hits1054010552  +12 
   - Misses   4266 4269   +3 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4514?src=pr=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5)
 | `78.45%  (?)` | :arrow_up: |
   | 
[superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5)
 | `81.81% <100%> (?)` | :arrow_up: |
   | 
[superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5)
 | `52.33% <100%> (+0.08%)` | :arrow_up: |
   | 
[superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=)
 | `87.83% <100%> (-0.29%)` | :arrow_down: |
   | 
[superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==)
 | `100% <100%> (?)` | |
   | 
[superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=)
 | `76.39% <100%> (+0.03%)` | :arrow_up: |
   | 
[superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==)
 | `71.13% <60%> (-0.07%)` | :arrow_down: |
   | 
[superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==)
 | `74.21% <0%> (-0.13%)` | :arrow_down: |
   | 
[superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
 | `92.18% <0%> (+0.06%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4514?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4514?src=pr=footer).
 Last update 
[b512da8...d49c6b9](https://codecov.io/gh/apache/incubator-superset/pull/4514?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4514: Added new exception class and start of better exception/error handling

[GitBox]

codecov-io commented on issue #4514: Added new exception class and start of 
better exception/error handling
URL: 
https://github.com/apache/incubator-superset/pull/4514#issuecomment-371323920
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4514?src=pr=h1)
 Report
   > Merging 
[#4514](https://codecov.io/gh/apache/incubator-superset/pull/4514?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/b512da8002dc0dc7f6a1f5eb983606118f484d32?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `92.3%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4514/graphs/tree.svg?height=150=650=KsB0fHcx6l=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4514?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4514  +/-   ##
   ==
   + Coverage   71.17%   71.18%   +<.01% 
   ==
 Files 187  188   +1 
 Lines   1480914824  +15 
 Branches 1085 1085  
   ==
   + Hits1054010552  +12 
   - Misses   4266 4269   +3 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4514?src=pr=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5)
 | `78.45%  (?)` | :arrow_up: |
   | 
[superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5)
 | `81.81% <100%> (?)` | :arrow_up: |
   | 
[superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=)
 | `76.39% <100%> (+0.03%)` | :arrow_up: |
   | 
[superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==)
 | `100% <100%> (?)` | |
   | 
[superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5)
 | `52.33% <100%> (+0.08%)` | :arrow_up: |
   | 
[superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=)
 | `87.83% <100%> (-0.29%)` | :arrow_down: |
   | 
[superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==)
 | `71.13% <60%> (-0.07%)` | :arrow_down: |
   | 
[superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==)
 | `74.21% <0%> (-0.13%)` | :arrow_down: |
   | 
[superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
 | `92.18% <0%> (+0.06%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4514?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4514?src=pr=footer).
 Last update 
[b512da8...d49c6b9](https://codecov.io/gh/apache/incubator-superset/pull/4514?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4551: [sql lab] option to disable cross schema search

[GitBox]

codecov-io commented on issue #4551: [sql lab] option to disable cross schema 
search
URL: 
https://github.com/apache/incubator-superset/pull/4551#issuecomment-371030577
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=h1)
 Report
   > Merging 
[#4551](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/c85eea303787cf23248f0a507e83e22cd8c9e083?src=pr=desc)
 will **decrease** coverage by `0.01%`.
   > The diff coverage is `88.88%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4551/graphs/tree.svg?width=650=pr=KsB0fHcx6l=150)](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4551  +/-   ##
   ==
   - Coverage   71.17%   71.16%   -0.02% 
   ==
 Files 187  187  
 Lines   1480914824  +15 
 Branches 1085 1086   +1 
   ==
   + Hits1054010549   +9 
   - Misses   4266 4272   +6 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[...assets/javascripts/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=)
 | `74.46%  (?)` | :arrow_up: |
   | 
[superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==)
 | `71.2%  (?)` | :arrow_up: |
   | 
[superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=)
 | `86.7% <100%> (-0.62%)` | :arrow_down: |
   | 
[...javascripts/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4)
 | `92.45% <83.33%> (-0.55%)` | :arrow_down: |
   | 
[superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==)
 | `74.21% <0%> (-0.13%)` | :arrow_down: |
   | 
[superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
 | `92.18% <0%> (+0.06%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=footer).
 Last update 
[c85eea3...e78d788](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4551: [sql lab] option to disable cross schema search

[GitBox]

codecov-io commented on issue #4551: [sql lab] option to disable cross schema 
search
URL: 
https://github.com/apache/incubator-superset/pull/4551#issuecomment-371030577
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=h1)
 Report
   > Merging 
[#4551](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/c85eea303787cf23248f0a507e83e22cd8c9e083?src=pr=desc)
 will **decrease** coverage by `0.01%`.
   > The diff coverage is `88.88%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4551/graphs/tree.svg?src=pr=KsB0fHcx6l=650=150)](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4551  +/-   ##
   ==
   - Coverage   71.17%   71.16%   -0.02% 
   ==
 Files 187  187  
 Lines   1480914824  +15 
 Branches 1085 1086   +1 
   ==
   + Hits1054010549   +9 
   - Misses   4266 4272   +6 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==)
 | `71.2%  (?)` | :arrow_up: |
   | 
[...assets/javascripts/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=)
 | `74.46%  (?)` | :arrow_up: |
   | 
[superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=)
 | `86.7% <100%> (-0.62%)` | :arrow_down: |
   | 
[...javascripts/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4)
 | `92.45% <83.33%> (-0.55%)` | :arrow_down: |
   | 
[superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==)
 | `74.21% <0%> (-0.13%)` | :arrow_down: |
   | 
[superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
 | `92.18% <0%> (+0.06%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=footer).
 Last update 
[c85eea3...e78d788](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4584: [sqllab] Added share button to bottom menu

[GitBox]

codecov-io commented on issue #4584: [sqllab] Added share button to bottom menu
URL: 
https://github.com/apache/incubator-superset/pull/4584#issuecomment-371746821
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=h1)
 Report
   > Merging 
[#4584](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/b512da8002dc0dc7f6a1f5eb983606118f484d32?src=pr=desc)
 will **increase** coverage by `0.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4584/graphs/tree.svg?token=KsB0fHcx6l=650=150=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4584  +/-   ##
   ==
   + Coverage   71.17%   71.19%   +0.01% 
   ==
 Files 187  188   +1 
 Lines   1480914822  +13 
 Branches 1085 1085  
   ==
   + Hits1054010552  +12 
   - Misses   4266 4267   +1 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[...ssets/javascripts/SqlLab/components/ShareQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4584/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NoYXJlUXVlcnkuanN4)
 | `100% <100%> (?)` | |
   | 
[...assets/javascripts/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4584/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=)
 | `74.73% <100%> (+0.26%)` | :arrow_up: |
   | 
[superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/4584/diff?src=pr=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==)
 | `74.21% <0%> (-0.13%)` | :arrow_down: |
   | 
[superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4584/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
 | `92.18% <0%> (+0.06%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=footer).
 Last update 
[b512da8...fc0c346](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4584: [sqllab] Added share button to bottom menu

[GitBox]

codecov-io commented on issue #4584: [sqllab] Added share button to bottom menu
URL: 
https://github.com/apache/incubator-superset/pull/4584#issuecomment-371746821
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=h1)
 Report
   > Merging 
[#4584](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/b512da8002dc0dc7f6a1f5eb983606118f484d32?src=pr=desc)
 will **increase** coverage by `0.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4584/graphs/tree.svg?token=KsB0fHcx6l=650=pr=150)](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4584  +/-   ##
   ==
   + Coverage   71.17%   71.19%   +0.01% 
   ==
 Files 187  188   +1 
 Lines   1480914822  +13 
 Branches 1085 1085  
   ==
   + Hits1054010552  +12 
   - Misses   4266 4267   +1 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[...ssets/javascripts/SqlLab/components/ShareQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4584/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NoYXJlUXVlcnkuanN4)
 | `100% <100%> (?)` | |
   | 
[...assets/javascripts/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4584/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=)
 | `74.73% <100%> (+0.26%)` | :arrow_up: |
   | 
[superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/4584/diff?src=pr=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==)
 | `74.21% <0%> (-0.13%)` | :arrow_down: |
   | 
[superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4584/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
 | `92.18% <0%> (+0.06%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=footer).
 Last update 
[b512da8...fc0c346](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4566: Adding column type label to dropdowns

[GitBox]

codecov-io commented on issue #4566: Adding column type label to dropdowns
URL: 
https://github.com/apache/incubator-superset/pull/4566#issuecomment-371269963
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=h1)
 Report
   > Merging 
[#4566](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/826d0631e04f96365bd35a913604932852371659?src=pr=desc)
 will **increase** coverage by `0.02%`.
   > The diff coverage is `73.91%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4566/graphs/tree.svg?width=650=150=pr=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4566  +/-   ##
   ==
   + Coverage71.2%   71.22%   +0.02% 
   ==
 Files 187  188   +1 
 Lines   1478514841  +56 
 Branches 1083 1096  +13 
   ==
   + Hits1052710570  +43 
   - Misses   4255 4268  +13 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=)
 | `66.66% <0%> (?)` | :arrow_up: |
   | 
[.../assets/javascripts/components/ColumnTypeLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLmpzeA==)
 | `100% <100%> (?)` | |
   | 
[...set/assets/javascripts/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==)
 | `100% <100%> (?)` | :arrow_up: |
   | 
[...set/assets/javascripts/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==)
 | `100% <100%> (?)` | :arrow_up: |
   | 
[...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==)
 | `37.59% <8.33%> (-0.58%)` | :arrow_down: |
   | 
[superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==)
 | `73.33% <0%> (-4.93%)` | :arrow_down: |
   | 
[...rset/assets/javascripts/explore/stores/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL3Zpc1R5cGVzLmpz)
 | `70.58% <0%> (?)` | :arrow_up: |
   | 
[superset/assets/javascripts/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvaW5kZXguanN4)
 | `0% <0%> (?)` | :arrow_up: |
   | 
[superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
 | `92.12% <0%> (?)` | :arrow_up: |
   | ... and [5 
more](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=footer).
 Last update 
[826d063...9e46f4c](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] john-bodley opened a new pull request #4587: [logs] Dropping dt column

[GitBox]

john-bodley opened a new pull request #4587: [logs] Dropping dt column
URL: https://github.com/apache/incubator-superset/pull/4587
 
 
   Whist looking through the Superset `logs` table I discovered that there was 
a misalignment of the date defined in the `dt` column vs `dttm`.
   
   The reason for the inconsistency is `dttm` is defined in reference to the 
UTC timezone whereas `dt` use the date in reference to one's local timezone. 
One possible fix is

   dt = Column(Date, default=ddatetime.utcnow().date())
   
   however given that `dt` and `dttm` aren't using the same now instance, 
there's still no guarantee there will be consistency between these columns 
especially around 12:00:00 am UTC. 
   
   The fix here is simply to remove the `dt` column which is unnecessary as 
this information is completely defined by the `dttm` column.
   
   to: @michellethomas @mistercrunch


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4566: Adding column type label to dropdowns

[GitBox]

codecov-io commented on issue #4566: Adding column type label to dropdowns
URL: 
https://github.com/apache/incubator-superset/pull/4566#issuecomment-371269963
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=h1)
 Report
   > Merging 
[#4566](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/826d0631e04f96365bd35a913604932852371659?src=pr=desc)
 will **increase** coverage by `0.02%`.
   > The diff coverage is `73.91%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4566/graphs/tree.svg?src=pr=KsB0fHcx6l=650=150)](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4566  +/-   ##
   ==
   + Coverage71.2%   71.22%   +0.02% 
   ==
 Files 187  188   +1 
 Lines   1478514841  +56 
 Branches 1083 1096  +13 
   ==
   + Hits1052710570  +43 
   - Misses   4255 4268  +13 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=)
 | `66.66% <0%> (?)` | :arrow_up: |
   | 
[...set/assets/javascripts/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==)
 | `100% <100%> (?)` | :arrow_up: |
   | 
[...set/assets/javascripts/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==)
 | `100% <100%> (?)` | :arrow_up: |
   | 
[.../assets/javascripts/components/ColumnTypeLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLmpzeA==)
 | `100% <100%> (?)` | |
   | 
[...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==)
 | `37.59% <8.33%> (-0.58%)` | :arrow_down: |
   | 
[superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==)
 | `73.33% <0%> (-4.93%)` | :arrow_down: |
   | 
[superset/assets/javascripts/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvaW5kZXguanN4)
 | `0% <0%> (?)` | :arrow_up: |
   | 
[...rset/assets/javascripts/explore/stores/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL3Zpc1R5cGVzLmpz)
 | `70.58% <0%> (?)` | :arrow_up: |
   | 
[...cripts/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=)
 | `0% <0%> (?)` | :arrow_up: |
   | 
[superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
 | `92.12% <0%> (?)` | :arrow_up: |
   | ... and [5 
more](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=footer).
 Last update 
[826d063...9e46f4c](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] betodealmeida commented on issue #4572: Legend for deck.gl scatterplot

[GitBox]

betodealmeida commented on issue #4572: Legend for deck.gl scatterplot
URL: 
https://github.com/apache/incubator-superset/pull/4572#issuecomment-371921805
 
 
   
![overflow](https://user-images.githubusercontent.com/1534870/37225966-43b1c956-238d-11e8-8cf0-6d8428a879b5.gif)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed pull request #4585: [sql lab] comment injection hook

[GitBox]

mistercrunch closed pull request #4585: [sql lab] comment injection hook
URL: https://github.com/apache/incubator-superset/pull/4585
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/config.py b/superset/config.py
index c9b8607e3e..5e5a822f7a 100644
--- a/superset/config.py
+++ b/superset/config.py
@@ -382,9 +382,10 @@ class CeleryConfig(object):
 # arbitrary logic. For instance you can wire different users to
 # use different connection parameters, or pass their email address as the
 # username. The function receives the connection uri object, connection
-# params, and user object, and returns the mutated uri and params objects.
+# params, the username, and returns the mutated uri and params objects.
 # Example:
-#   def DB_CONNECTION_MUTATOR(uri, params, user):
+#   def DB_CONNECTION_MUTATOR(uri, params, username, security_manager):
+#   user = security_manager.find_user(username=username)
 #   if user and user.email:
 #   uri.username = user.email
 #   return uri, params
@@ -393,6 +394,15 @@ class CeleryConfig(object):
 # as such `create_engine(url, **params)`
 DB_CONNECTION_MUTATOR = None
 
+# A function that intercepts the SQL to be executed and can alter it.
+# The use case is can be around adding some sort of comment header
+# with information such as the username and worker node information
+#
+#def SQL_QUERY_MUTATOR(sql, username, security_manager):
+#dttm = datetime.now().isoformat()
+#return "-- [SQL LAB] {username} {dttm}\n sql"(**locals())
+SQL_QUERY_MUTATOR = None
+
 try:
 if CONFIG_PATH_ENV_VAR in os.environ:
 # Explicitly import config module that is not in pythonpath; useful
diff --git a/superset/models/core.py b/superset/models/core.py
index 41d8742b65..9caa7adce4 100644
--- a/superset/models/core.py
+++ b/superset/models/core.py
@@ -677,7 +677,7 @@ def get_sqla_engine(self, schema=None, nullpool=True, 
user_name=None):
 
 DB_CONNECTION_MUTATOR = config.get('DB_CONNECTION_MUTATOR')
 if DB_CONNECTION_MUTATOR:
-url, params = DB_CONNECTION_MUTATOR(url, params, g.user)
+url, params = DB_CONNECTION_MUTATOR(url, params, user_name, sm)
 return create_engine(url, **params)
 
 def get_reserved_words(self):
diff --git a/superset/sql_lab.py b/superset/sql_lab.py
index 4dae72720d..f98231ed77 100644
--- a/superset/sql_lab.py
+++ b/superset/sql_lab.py
@@ -17,7 +17,7 @@
 from sqlalchemy.orm import sessionmaker
 from sqlalchemy.pool import NullPool
 
-from superset import app, dataframe, db, results_backend, utils
+from superset import app, dataframe, db, results_backend, sm, utils
 from superset.db_engine_specs import LimitMethod
 from superset.jinja_context import get_template_processor
 from superset.models.sql_lab import Query
@@ -194,6 +194,11 @@ def handle_error(msg):
 msg = 'Template rendering failed: ' + utils.error_msg_from_exception(e)
 return handle_error(msg)
 
+# Hook to allow environment-specific mutation (usually comments) to the SQL
+SQL_QUERY_MUTATOR = config.get('SQL_QUERY_MUTATOR')
+if SQL_QUERY_MUTATOR:
+executed_sql = SQL_QUERY_MUTATOR(executed_sql, user_name, sm, database)
+
 query.executed_sql = executed_sql
 query.status = QueryStatus.RUNNING
 query.start_running_time = utils.now_as_float()


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4566: Adding column type label to dropdowns

[GitBox]

mistercrunch commented on issue #4566: Adding column type label to dropdowns
URL: 
https://github.com/apache/incubator-superset/pull/4566#issuecomment-371920480
 
 
   
![giphy](https://user-images.githubusercontent.com/487433/37225822-bffbcf58-238c-11e8-9003-c9b772e44975.gif)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4551: [sql lab] option to disable cross schema search

[GitBox]

codecov-io commented on issue #4551: [sql lab] option to disable cross schema 
search
URL: 
https://github.com/apache/incubator-superset/pull/4551#issuecomment-371030577
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=h1)
 Report
   > Merging 
[#4551](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/c85eea303787cf23248f0a507e83e22cd8c9e083?src=pr=desc)
 will **decrease** coverage by `0.01%`.
   > The diff coverage is `88.88%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4551/graphs/tree.svg?src=pr=KsB0fHcx6l=650=150)](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4551  +/-   ##
   ==
   - Coverage   71.17%   71.16%   -0.02% 
   ==
 Files 187  187  
 Lines   1480914820  +11 
 Branches 1085 1086   +1 
   ==
   + Hits1054010546   +6 
   - Misses   4266 4271   +5 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[...assets/javascripts/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=)
 | `74.46%  (?)` | :arrow_up: |
   | 
[superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==)
 | `71.2%  (?)` | :arrow_up: |
   | 
[superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=)
 | `86.7% <100%> (-0.62%)` | :arrow_down: |
   | 
[...javascripts/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4551/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4)
 | `92.45% <83.33%> (-0.55%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=footer).
 Last update 
[c85eea3...a57dd87](https://codecov.io/gh/apache/incubator-superset/pull/4551?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4585: [sql lab] comment injection hook

[GitBox]

codecov-io commented on issue #4585: [sql lab] comment injection hook
URL: 
https://github.com/apache/incubator-superset/pull/4585#issuecomment-371917967
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4585?src=pr=h1)
 Report
   > Merging 
[#4585](https://codecov.io/gh/apache/incubator-superset/pull/4585?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/c85eea303787cf23248f0a507e83e22cd8c9e083?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `66.66%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4585/graphs/tree.svg?token=KsB0fHcx6l=650=150=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4585?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4585  +/-   ##
   ==
   + Coverage   71.17%   71.17%   +<.01% 
   ==
 Files 187  187  
 Lines   1480914813   +4 
 Branches 1085 1085  
   ==
   + Hits1054010543   +3 
   - Misses   4266 4267   +1 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4585?src=pr=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4585/diff?src=pr=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=)
 | `87.31% <0%> (?)` | :arrow_up: |
   | 
[superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4585/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
 | `92.18% <100%> (+0.06%)` | :arrow_up: |
   | 
[superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/4585/diff?src=pr=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==)
 | `74.21% <75%> (-0.13%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4585?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4585?src=pr=footer).
 Last update 
[c85eea3...1a083d3](https://codecov.io/gh/apache/incubator-superset/pull/4585?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4579: Removing [dashboard] and [slice] titles to show name

[GitBox]

codecov-io commented on issue #4579: Removing [dashboard] and [slice] titles to 
show name
URL: 
https://github.com/apache/incubator-superset/pull/4579#issuecomment-371642722
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4579?src=pr=h1)
 Report
   > Merging 
[#4579](https://codecov.io/gh/apache/incubator-superset/pull/4579?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/9edbd64c5d2ac05c7a4a9eba8bb6de0d1ba4de03?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4579/graphs/tree.svg?width=650=pr=KsB0fHcx6l=150)](https://codecov.io/gh/apache/incubator-superset/pull/4579?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4579   +/-   ##
   ===
 Coverage   71.17%   71.17%   
   ===
 Files 187  187   
 Lines   1480914809   
 Branches 1085 1085   
   ===
 Hits1054010540   
 Misses   4266 4266   
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4579?src=pr=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4579/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==)
 | `71.2% <50%> (?)` | :arrow_up: |
   | 
[...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4579/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==)
 | `38.16% <0%> (?)` | :arrow_up: |
   | 
[...rset/assets/javascripts/explore/stores/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/4579/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL3Zpc1R5cGVzLmpz)
 | `70.58% <0%> (?)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4579?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4579?src=pr=footer).
 Last update 
[9edbd64...9e22701](https://codecov.io/gh/apache/incubator-superset/pull/4579?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4586: [Translate] Added Full Russian Translation

[GitBox]

mistercrunch commented on issue #4586: [Translate] Added Full Russian 
Translation
URL: 
https://github.com/apache/incubator-superset/pull/4586#issuecomment-371916638
 
 
   
![russia_240-animated-flag-gifs](https://user-images.githubusercontent.com/487433/37225253-e1f9ee66-238a-11e8-98ab-81fa11cc1276.gif)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4584: [sqllab] Added share button to bottom menu

[GitBox]

mistercrunch commented on issue #4584: [sqllab] Added share button to bottom 
menu
URL: 
https://github.com/apache/incubator-superset/pull/4584#issuecomment-371916318
 
 
   LGTM, feel free to ship as is despite the minor nit


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hughhhh commented on issue #4585: [sql lab] comment injection hook

[GitBox]

hug commented on issue #4585: [sql lab] comment injection hook
URL: 
https://github.com/apache/incubator-superset/pull/4585#issuecomment-371914758
 
 
   ? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hughhhh commented on issue #4551: [sql lab] option to disable cross schema search

[GitBox]

hug commented on issue #4551: [sql lab] option to disable cross schema 
search
URL: 
https://github.com/apache/incubator-superset/pull/4551#issuecomment-371914286
 
 
   ? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hughhhh commented on a change in pull request #4551: [sql lab] option to disable cross schema search

[GitBox]

hug commented on a change in pull request #4551: [sql lab] option to 
disable cross schema search
URL: 
https://github.com/apache/incubator-superset/pull/4551#discussion_r173538724
 
 

 ##
 File path: superset/views/core.py
 ##
 @@ -256,6 +258,10 @@ class DatabaseView(SupersetModelView, DeleteMixin, 
YamlExportMixin):  # noqa
 'If Hive and hive.server2.enable.doAs is enabled, will run the 
queries as '
 'service account, but impersonate the currently logged on user '
 'via hive.server2.proxy.user property.'),
+'allow_multi_schema_metadata_fetch': _(
+'Allow SQL Lab to fetch a list of all table and all views across '
 
 Review comment:
   nit: `list of all tables`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] michellethomas commented on issue #4579: Removing [dashboard] and [slice] titles to show name

[GitBox]

michellethomas commented on issue #4579: Removing [dashboard] and [slice] 
titles to show name
URL: 
https://github.com/apache/incubator-superset/pull/4579#issuecomment-371912024
 
 
   @williaster All of the crud pages list Superset as the title so there'd be 
no distinguishing explore from crud pages. What about just `explore - 
table_name`. I think just table_name could be ok too. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4566: Adding column type label to dropdowns

[GitBox]

codecov-io commented on issue #4566: Adding column type label to dropdowns
URL: 
https://github.com/apache/incubator-superset/pull/4566#issuecomment-371269963
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=h1)
 Report
   > Merging 
[#4566](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/826d0631e04f96365bd35a913604932852371659?src=pr=desc)
 will **decrease** coverage by `0.01%`.
   > The diff coverage is `63.04%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4566/graphs/tree.svg?token=KsB0fHcx6l=650=150=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4566  +/-   ##
   ==
   - Coverage71.2%   71.18%   -0.02% 
   ==
 Files 187  188   +1 
 Lines   1478514841  +56 
 Branches 1083 1096  +13 
   ==
   + Hits1052710565  +38 
   - Misses   4255 4272  +17 
   - Partials34   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=)
 | `66.66% <0%> (?)` | :arrow_up: |
   | 
[...set/assets/javascripts/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==)
 | `100% <100%> (?)` | :arrow_up: |
   | 
[...set/assets/javascripts/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==)
 | `100% <100%> (?)` | :arrow_up: |
   | 
[.../assets/javascripts/components/ColumnTypeLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLmpzeA==)
 | `77.27% <77.27%> (?)` | |
   | 
[...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==)
 | `37.59% <8.33%> (-0.58%)` | :arrow_down: |
   | 
[superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==)
 | `73.33% <0%> (-4.93%)` | :arrow_down: |
   | 
[...rset/assets/javascripts/explore/stores/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL3Zpc1R5cGVzLmpz)
 | `70.58% <0%> (?)` | :arrow_up: |
   | 
[superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
 | `92.12% <0%> (?)` | :arrow_up: |
   | 
[...cripts/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=)
 | `0% <0%> (?)` | :arrow_up: |
   | ... and [5 
more](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=footer).
 Last update 
[826d063...6d20431](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4566: Adding column type label to dropdowns

[GitBox]

codecov-io commented on issue #4566: Adding column type label to dropdowns
URL: 
https://github.com/apache/incubator-superset/pull/4566#issuecomment-371269963
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=h1)
 Report
   > Merging 
[#4566](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/826d0631e04f96365bd35a913604932852371659?src=pr=desc)
 will **decrease** coverage by `0.01%`.
   > The diff coverage is `63.04%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4566/graphs/tree.svg?width=650=KsB0fHcx6l=150=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4566  +/-   ##
   ==
   - Coverage71.2%   71.18%   -0.02% 
   ==
 Files 187  188   +1 
 Lines   1478514841  +56 
 Branches 1083 1096  +13 
   ==
   + Hits1052710565  +38 
   - Misses   4255 4272  +17 
   - Partials34   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=)
 | `66.66% <0%> (?)` | :arrow_up: |
   | 
[...set/assets/javascripts/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==)
 | `100% <100%> (?)` | :arrow_up: |
   | 
[...set/assets/javascripts/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==)
 | `100% <100%> (?)` | :arrow_up: |
   | 
[.../assets/javascripts/components/ColumnTypeLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLmpzeA==)
 | `77.27% <77.27%> (?)` | |
   | 
[...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==)
 | `37.59% <8.33%> (-0.58%)` | :arrow_down: |
   | 
[superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==)
 | `73.33% <0%> (-4.93%)` | :arrow_down: |
   | 
[...rset/assets/javascripts/explore/stores/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL3Zpc1R5cGVzLmpz)
 | `70.58% <0%> (?)` | :arrow_up: |
   | 
[...cripts/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=)
 | `0% <0%> (?)` | :arrow_up: |
   | 
[superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
 | `92.12% <0%> (?)` | :arrow_up: |
   | 
[superset/assets/javascripts/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvaW5kZXguanN4)
 | `0% <0%> (?)` | :arrow_up: |
   | ... and [5 
more](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=footer).
 Last update 
[826d063...6d20431](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #4584: [sqllab] Added share button to bottom menu

[GitBox]

mistercrunch commented on a change in pull request #4584: [sqllab] Added share 
button to bottom menu
URL: 
https://github.com/apache/incubator-superset/pull/4584#discussion_r173533310
 
 

 ##
 File path: superset/assets/javascripts/SqlLab/components/SqlEditor.jsx
 ##
 @@ -195,6 +196,11 @@ class SqlEditor extends React.PureComponent {
 dbId={qe.dbId}
   />
 
+
+  

[GitHub] codecov-io commented on issue #4586: [Translate] Added Full Russian Translation

[GitBox]

codecov-io commented on issue #4586: [Translate] Added Full Russian Translation
URL: 
https://github.com/apache/incubator-superset/pull/4586#issuecomment-371901217
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4586?src=pr=h1)
 Report
   > Merging 
[#4586](https://codecov.io/gh/apache/incubator-superset/pull/4586?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/c85eea303787cf23248f0a507e83e22cd8c9e083?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4586/graphs/tree.svg?width=650=150=pr=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/4586?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4586   +/-   ##
   ===
 Coverage   71.17%   71.17%   
   ===
 Files 187  187   
 Lines   1480914809   
 Branches 1085 1085   
   ===
 Hits1054010540   
 Misses   4266 4266   
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4586?src=pr=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4586/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
 | `92.12%  (?)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4586?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4586?src=pr=footer).
 Last update 
[c85eea3...8ba3dcd](https://codecov.io/gh/apache/incubator-superset/pull/4586?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4586: [Translate] Added Full Russian Translation

[GitBox]

codecov-io commented on issue #4586: [Translate] Added Full Russian Translation
URL: 
https://github.com/apache/incubator-superset/pull/4586#issuecomment-371901217
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4586?src=pr=h1)
 Report
   > Merging 
[#4586](https://codecov.io/gh/apache/incubator-superset/pull/4586?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/c85eea303787cf23248f0a507e83e22cd8c9e083?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4586/graphs/tree.svg?width=650=KsB0fHcx6l=150=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4586?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4586   +/-   ##
   ===
 Coverage   71.17%   71.17%   
   ===
 Files 187  187   
 Lines   1480914809   
 Branches 1085 1085   
   ===
 Hits1054010540   
 Misses   4266 4266   
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4586?src=pr=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4586/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
 | `92.12%  (?)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4586?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4586?src=pr=footer).
 Last update 
[c85eea3...8ba3dcd](https://codecov.io/gh/apache/incubator-superset/pull/4586?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing

[GitBox]

codecov-io commented on issue #4552: [travis/tox] Restructuring configuration 
and testing
URL: 
https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=h1)
 Report
   > Merging 
[#4552](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/c85eea303787cf23248f0a507e83e22cd8c9e083?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4552/graphs/tree.svg?token=KsB0fHcx6l=650=150=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4552   +/-   ##
   ===
 Coverage   71.17%   71.17%   
   ===
 Files 187  187   
 Lines   1480914809   
 Branches 1085 1085   
   ===
 Hits1054010540   
 Misses   4266 4266   
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
 | `92.12% <0%> (?)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=footer).
 Last update 
[c85eea3...ee32c6f](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] oxydash opened a new pull request #4586: [Translate] Added Full Russian Translation

[GitBox]

oxydash opened a new pull request #4586: [Translate] Added Full Russian 
Translation
URL: https://github.com/apache/incubator-superset/pull/4586
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch opened a new pull request #4585: [sql lab] comment injection hook

[GitBox]

mistercrunch opened a new pull request #4585: [sql lab] comment injection hook
URL: https://github.com/apache/incubator-superset/pull/4585
 
 
   This will allow us at Lyft to add a comment header that adds metadata to the 
query to the SQL sent to databases for audit/debug purpose. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing

[GitBox]

codecov-io commented on issue #4552: [travis/tox] Restructuring configuration 
and testing
URL: 
https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=h1)
 Report
   > Merging 
[#4552](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/c85eea303787cf23248f0a507e83e22cd8c9e083?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4552/graphs/tree.svg?height=150=KsB0fHcx6l=650=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4552   +/-   ##
   ===
 Coverage   71.17%   71.17%   
   ===
 Files 187  187   
 Lines   1480914809   
 Branches 1085 1085   
   ===
 Hits1054010540   
 Misses   4266 4266   
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
 | `92.12% <0%> (?)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=footer).
 Last update 
[c85eea3...ee32c6f](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing

[GitBox]

codecov-io commented on issue #4552: [travis/tox] Restructuring configuration 
and testing
URL: 
https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=h1)
 Report
   > Merging 
[#4552](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/c85eea303787cf23248f0a507e83e22cd8c9e083?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4552/graphs/tree.svg?src=pr=KsB0fHcx6l=650=150)](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4552   +/-   ##
   ===
 Coverage   71.17%   71.17%   
   ===
 Files 187  187   
 Lines   1480914809   
 Branches 1085 1085   
   ===
 Hits1054010540   
 Misses   4266 4266   
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
 | `92.12% <0%> (?)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=footer).
 Last update 
[c85eea3...ee32c6f](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] john-bodley closed pull request #4582: [code-climate] Deprecating Code Climate from JavaScript tests

[GitBox]

john-bodley closed pull request #4582: [code-climate] Deprecating Code Climate 
from JavaScript tests
URL: https://github.com/apache/incubator-superset/pull/4582
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.codeclimate.yml b/.codeclimate.yml
deleted file mode 100644
index 2da3213875..00
--- a/.codeclimate.yml
+++ /dev/null
@@ -1,40 +0,0 @@
-engines:
-  csslint:
-enabled: false
-  duplication:
-enabled: false
-  eslint:
-enabled: true
-checks:
-  import/extensions:
-enabled: false
-  import/no-extraneous-dependencies:
-enabled: false
-config:
-  config: superset/assets/.eslintrc
-  pep8:
-enabled: true
-  fixme:
-enabled: false
-  radon:
-enabled: true
-checks:
-  Complexity:
-enabled: false
-ratings:
-  paths:
-  - "**.py"
-  - "superset/assets/**.js"
-  - "superset/assets/**.jsx"
-exclude_paths:
-- ".*"
-- "**.pyc"
-- "**.gz"
-- "env/"
-- "tests/"
-- "superset/assets/images/"
-- "superset/assets/vendor/"
-- "superset/assets/node_modules/"
-- "superset/assets/javascripts/dist/"
-- "superset/migrations"
-- "docs/"
diff --git a/.travis.yml b/.travis.yml
index 0a21126e69..34b83e3609 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,9 +1,6 @@
 language: python
 services:
 - redis-server
-addons:
-  code_climate:
-repo_token: 
5f3a06c425eef7be4b43627d7d07a3e46c45bdc07155217825ff7c49cb6a470c
 cache:
   directories:
 - $HOME/.wheelhouse/
diff --git a/setup.py b/setup.py
index ad33dcec58..bdb0d5e42a 100644
--- a/setup.py
+++ b/setup.py
@@ -95,7 +95,6 @@ def get_git_sha():
 'cors': ['Flask-Cors>=2.0.0'],
 },
 tests_require=[
-'codeclimate-test-reporter',
 'coverage',
 'mock',
 'nose',
diff --git a/superset/assets/js_build.sh b/superset/assets/js_build.sh
index c71739888e..3c9a1ea1d2 100755
--- a/superset/assets/js_build.sh
+++ b/superset/assets/js_build.sh
@@ -9,4 +9,3 @@ npm run lint
 npm run test
 npm run build
 npm run cover
-CODECLIMATE_REPO_TOKEN=ded6121d25d593a1c5aee9f26d85717b19df058f7408cef26910aa731aa7cc3f
 ./node_modules/.bin/codeclimate-test-reporter < ./coverage/lcov.info
diff --git a/superset/assets/package.json b/superset/assets/package.json
index 03a6f652b0..dbd4b5de6d 100644
--- a/superset/assets/package.json
+++ b/superset/assets/package.json
@@ -122,7 +122,6 @@
 "babel-preset-airbnb": "^2.1.1",
 "chai": "^4.0.2",
 "clean-webpack-plugin": "^0.1.16",
-"codeclimate-test-reporter": "^0.5.0",
 "css-loader": "^0.28.0",
 "enzyme": "^2.0.0",
 "eslint": "^3.19.0",


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4473: [Wip] Added DeckGL unit test

[GitBox]

codecov-io commented on issue #4473: [Wip] Added DeckGL unit test
URL: 
https://github.com/apache/incubator-superset/pull/4473#issuecomment-371748732
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=h1)
 Report
   > Merging 
[#4473](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/b512da8002dc0dc7f6a1f5eb983606118f484d32?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4473/graphs/tree.svg?width=650=KsB0fHcx6l=150=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4473   +/-   ##
   ===
 Coverage   71.17%   71.17%   
   ===
 Files 187  187   
 Lines   1480914809   
 Branches 1085 1085   
   ===
 Hits1054010540   
 Misses   4266 4266   
 Partials33
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=footer).
 Last update 
[b512da8...e64aedb](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4473: [Wip] Added DeckGL unit test

[GitBox]

codecov-io commented on issue #4473: [Wip] Added DeckGL unit test
URL: 
https://github.com/apache/incubator-superset/pull/4473#issuecomment-371748732
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=h1)
 Report
   > Merging 
[#4473](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/b512da8002dc0dc7f6a1f5eb983606118f484d32?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4473/graphs/tree.svg?token=KsB0fHcx6l=pr=150=650)](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4473   +/-   ##
   ===
 Coverage   71.17%   71.17%   
   ===
 Files 187  187   
 Lines   1480914809   
 Branches 1085 1085   
   ===
 Hits1054010540   
 Misses   4266 4266   
 Partials33
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=footer).
 Last update 
[b512da8...e64aedb](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4584: [sqllab] Added share button to bottom menu

[GitBox]

codecov-io commented on issue #4584: [sqllab] Added share button to bottom menu
URL: 
https://github.com/apache/incubator-superset/pull/4584#issuecomment-371746821
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=h1)
 Report
   > Merging 
[#4584](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/b512da8002dc0dc7f6a1f5eb983606118f484d32?src=pr=desc)
 will **increase** coverage by `0.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4584/graphs/tree.svg?height=150=pr=KsB0fHcx6l=650)](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4584  +/-   ##
   ==
   + Coverage   71.17%   71.19%   +0.01% 
   ==
 Files 187  188   +1 
 Lines   1480914818   +9 
 Branches 1085 1085  
   ==
   + Hits1054010549   +9 
 Misses   4266 4266  
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[...ssets/javascripts/SqlLab/components/ShareQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4584/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NoYXJlUXVlcnkuanN4)
 | `100% <100%> (?)` | |
   | 
[...assets/javascripts/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4584/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=)
 | `74.73% <100%> (+0.26%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=footer).
 Last update 
[b512da8...d4f35d2](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hughhhh commented on issue #4582: [code-climate] Deprecating Code Climate from JavaScript tests

[GitBox]

hug commented on issue #4582: [code-climate] Deprecating Code Climate from 
JavaScript tests
URL: 
https://github.com/apache/incubator-superset/pull/4582#issuecomment-371743718
 
 
   ? RIP codeclimate


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hughhhh opened a new pull request #4584: added sharebtn

[GitBox]

hug opened a new pull request #4584: added sharebtn
URL: https://github.com/apache/incubator-superset/pull/4584
 
 
   Added share button to sqllab bottom menu
   
   
![ss-share](https://user-images.githubusercontent.com/27827808/37197183-a28ce10e-232e-11e8-90c4-e37546805dac.gif)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] alanderex commented on issue #4231: Does superset support integration with MongoDB?

[GitBox]

alanderex commented on issue #4231: Does superset support integration with 
MongoDB?
URL: 
https://github.com/apache/incubator-superset/issues/4231#issuecomment-371743216
 
 
   5th option:
   
   There is a tool called BI Connector from mongodb, this tool can map mongodb 
schemata to relational. It's used to interact e.g. with Tableau or other BI 
Tools. Unfortunately AFAIK it's only available in a paid mongodb version. 
https://www.mongodb.com/products/bi-connector


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services