[GitHub] [syncope] mmoayyed commented on pull request #279: code cleanup; diamond ops && lambda refs

2021-07-20 Thread GitBox
mmoayyed commented on pull request #279: URL: https://github.com/apache/syncope/pull/279#issuecomment-883218949 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [syncope] mmoayyed merged pull request #273: Switch to CAS 6.4 RC6

2021-07-20 Thread GitBox
mmoayyed merged pull request #273: URL: https://github.com/apache/syncope/pull/273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso commented on pull request #279: code cleanup; diamond ops && lambda refs

2021-07-20 Thread GitBox
ilgrosso commented on pull request #279: URL: https://github.com/apache/syncope/pull/279#issuecomment-883093366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [syncope] mmoayyed commented on pull request #279: code cleanup; diamond ops && lambda refs

2021-07-20 Thread GitBox
mmoayyed commented on pull request #279: URL: https://github.com/apache/syncope/pull/279#issuecomment-88363 Github Actions natively supports Docker with almost no effort; so probably a better task would be to disable Travis CI and instead focus the effort to move the Travis CI tests

[GitHub] [syncope] ilgrosso commented on pull request #279: code cleanup; diamond ops && lambda refs

2021-07-20 Thread GitBox
ilgrosso commented on pull request #279: URL: https://github.com/apache/syncope/pull/279#issuecomment-883220700 @mmoayyed I see about formatting changes. About Travis CI, instead, the checks done there are currently not performed with GitHub Actions (as they require Docker and might

[GitHub] [syncope] mmoayyed commented on pull request #279: code cleanup; diamond ops && lambda refs

2021-07-20 Thread GitBox
mmoayyed commented on pull request #279: URL: https://github.com/apache/syncope/pull/279#issuecomment-883218949 I don't think formatting changes can be undone, since the fix are not manually made and are a result of automated tools. If you wish to see the changes without formatting

[GitHub] [syncope] ilgrosso commented on pull request #279: code cleanup; diamond ops && lambda refs

2021-07-20 Thread GitBox
ilgrosso commented on pull request #279: URL: https://github.com/apache/syncope/pull/279#issuecomment-883122281 @mmoayyed it seems that Travis CI is failing due to a JDK bug like

[GitHub] [syncope] ilgrosso commented on pull request #279: code cleanup; diamond ops && lambda refs

2021-07-20 Thread GitBox
ilgrosso commented on pull request #279: URL: https://github.com/apache/syncope/pull/279#issuecomment-883093366 @mmoayyed thanks for taking care of such cleanup: would it be possible to remove the formatting changes from the PR? -- This is an automated message from the Apache Git

[GitHub] [syncope] ilgrosso opened a new pull request #280: [SYNCOPE-1618] Spring Boot configuration refactoring

2021-07-19 Thread GitBox
ilgrosso opened a new pull request #280: URL: https://github.com/apache/syncope/pull/280 - [ ] `@EnableConfigurationProperties`: - [X] Console - [ ] Enduser - [ ] SRA - [ ] WA - [ ] Core - [ ] Constructor-level dependency injections -- This is an

[GitHub] [syncope] mmoayyed opened a new pull request #279: code cleanup; diamond ops && lambda refs

2021-07-19 Thread GitBox
mmoayyed opened a new pull request #279: URL: https://github.com/apache/syncope/pull/279 This is purely a code clean-up patch: - Replace explicit types with their equivalent diamond operator - Replace methods calls with method references -- This is an automated message from the

[GitHub] [syncope] mmoayyed merged pull request #273: Switch to CAS 6.4 RC6

2021-07-19 Thread GitBox
mmoayyed merged pull request #273: URL: https://github.com/apache/syncope/pull/273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] mmoayyed edited a comment on pull request #273: Switch to CAS 6.4 RC6

2021-07-18 Thread GitBox
mmoayyed edited a comment on pull request #273: URL: https://github.com/apache/syncope/pull/273#issuecomment-878369661 I would prefer to wait since the next RC would be out in a few days. I will probably do another merge with master right before the rc release to make sure everything runs

[GitHub] [syncope] ilgrosso merged pull request #278: [SYNCOPE-1615] Loggers actuator for all components

2021-07-17 Thread GitBox
ilgrosso merged pull request #278: URL: https://github.com/apache/syncope/pull/278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso opened a new pull request #278: [SYNCOPE-1615] Loggers actuator for all components

2021-07-16 Thread GitBox
ilgrosso opened a new pull request #278: URL: https://github.com/apache/syncope/pull/278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso merged pull request #277: [SYNCOPE-1614] Spring Boot HealthIndicator and InfoContributor for al…

2021-07-13 Thread GitBox
ilgrosso merged pull request #277: URL: https://github.com/apache/syncope/pull/277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] mmoayyed commented on pull request #273: Switch to CAS 6.4 RC6

2021-07-12 Thread GitBox
mmoayyed commented on pull request #273: URL: https://github.com/apache/syncope/pull/273#issuecomment-878369661 I would prefer to wait since the next RC would be out on a few days. I will probably do another merge with master right before the rc release to make sure everything runs ok and

[GitHub] [syncope] ilgrosso opened a new pull request #277: [SYNCOPE-1614] Spring Boot HealthIndicator and InfoContributor for al…

2021-07-09 Thread GitBox
ilgrosso opened a new pull request #277: URL: https://github.com/apache/syncope/pull/277 …l components -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [syncope] loredicola merged pull request #275: [SYNCOPE-1435] New wicket enduser

2021-07-08 Thread GitBox
loredicola merged pull request #275: URL: https://github.com/apache/syncope/pull/275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso commented on a change in pull request #273: Switch to CAS 6.4 RC6

2021-07-06 Thread GitBox
ilgrosso commented on a change in pull request #273: URL: https://github.com/apache/syncope/pull/273#discussion_r663732471 ## File path: pom.xml ## @@ -3002,16 +2939,16 @@ under the License. -common -core -client + Review comment: Please

[GitHub] [syncope] ilgrosso commented on a change in pull request #273: Switch to CAS 6.4 RC6

2021-07-05 Thread GitBox
ilgrosso commented on a change in pull request #273: URL: https://github.com/apache/syncope/pull/273#discussion_r663732471 ## File path: pom.xml ## @@ -3002,16 +2939,16 @@ under the License. -common -core -client + Review comment: Please

[GitHub] [syncope] mmoayyed commented on a change in pull request #273: Switch to CAS 6.4 RC6

2021-07-05 Thread GitBox
mmoayyed commented on a change in pull request #273: URL: https://github.com/apache/syncope/pull/273#discussion_r663684568 ## File path: wa/starter/src/main/resources/log4j2.xml ## @@ -37,9 +37,14 @@ under the License. - + Review comment: OTOH, I think

[GitHub] [syncope] mmoayyed commented on a change in pull request #273: Switch to CAS 6.4 RC6

2021-07-05 Thread GitBox
mmoayyed commented on a change in pull request #273: URL: https://github.com/apache/syncope/pull/273#discussion_r663683511 ## File path: wa/starter/src/main/resources/log4j2.xml ## @@ -37,9 +37,14 @@ under the License. - + Review comment: No objections,

[GitHub] [syncope] ilgrosso commented on a change in pull request #273: Switch to CAS 6.4 RC6

2021-07-04 Thread GitBox
ilgrosso commented on a change in pull request #273: URL: https://github.com/apache/syncope/pull/273#discussion_r663656966 ## File path: wa/starter/src/main/resources/log4j2.xml ## @@ -37,9 +37,14 @@ under the License. - + Review comment: I think this

[GitHub] [syncope] mmoayyed commented on pull request #273: Switch to CAS 6.4 RC6

2021-07-02 Thread GitBox
mmoayyed commented on pull request #273: URL: https://github.com/apache/syncope/pull/273#issuecomment-873060998 Update: I am working on fixing/diagnosing issues with OIDC/SAML2 tests. There are changes that need to be mad to handle dynamic issuers for OIDC, and almost none belong in the

[GitHub] [syncope] ilgrosso merged pull request #276: [SYNCOPE-129] Delegation (#274)

2021-06-29 Thread GitBox
ilgrosso merged pull request #276: URL: https://github.com/apache/syncope/pull/276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso merged pull request #274: [SYNCOPE-129] Delegation

2021-06-29 Thread GitBox
ilgrosso merged pull request #274: URL: https://github.com/apache/syncope/pull/274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso merged pull request #276: [SYNCOPE-129] Delegation (#274)

2021-06-29 Thread GitBox
ilgrosso merged pull request #276: URL: https://github.com/apache/syncope/pull/276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso opened a new pull request #276: [SYNCOPE-129] Delegation (#274)

2021-06-29 Thread GitBox
ilgrosso opened a new pull request #276: URL: https://github.com/apache/syncope/pull/276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso merged pull request #274: [SYNCOPE-129] Delegation

2021-06-28 Thread GitBox
ilgrosso merged pull request #274: URL: https://github.com/apache/syncope/pull/274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] loredicola opened a new pull request #275: New wicket enduser

2021-06-25 Thread GitBox
loredicola opened a new pull request #275: URL: https://github.com/apache/syncope/pull/275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [syncope] ilgrosso opened a new pull request #274: [SYNCOPE-129] Delegation

2021-06-21 Thread GitBox
ilgrosso opened a new pull request #274: URL: https://github.com/apache/syncope/pull/274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [syncope] ilgrosso commented on a change in pull request #273: Switch to CAS 6.4 RC5

2021-06-14 Thread GitBox
ilgrosso commented on a change in pull request #273: URL: https://github.com/apache/syncope/pull/273#discussion_r650693344 ## File path: core/am/logic/src/main/java/org/apache/syncope/core/logic/wa/GoogleMfaAuthAccountLogic.java ## @@ -57,6 +58,26 @@ public void

[GitHub] [syncope] mmoayyed commented on pull request #273: Switch to CAS 6.4 RC5

2021-06-14 Thread GitBox
mmoayyed commented on pull request #273: URL: https://github.com/apache/syncope/pull/273#issuecomment-860448515 Good point on pac4j; thanks for the note. I upgraded it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [syncope] mmoayyed commented on a change in pull request #273: Switch to CAS 6.4 RC5

2021-06-14 Thread GitBox
mmoayyed commented on a change in pull request #273: URL: https://github.com/apache/syncope/pull/273#discussion_r650696389 ## File path: pom.xml ## @@ -2045,40 +2005,6 @@ under the License. true - -

[GitHub] [syncope] mmoayyed opened a new pull request #273: Switch to CAS 6.4 RC5

2021-06-14 Thread GitBox
mmoayyed opened a new pull request #273: URL: https://github.com/apache/syncope/pull/273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [syncope] ilgrosso commented on pull request #273: Switch to CAS 6.4 RC5

2021-06-14 Thread GitBox
ilgrosso commented on pull request #273: URL: https://github.com/apache/syncope/pull/273#issuecomment-860439625 @mmoayyed shouldn't pac4j be upgraded to 5.1.0 as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [syncope] ilgrosso merged pull request #272: Spring and Spring Security to latest 5.2 versions available

2021-06-01 Thread GitBox
ilgrosso merged pull request #272: URL: https://github.com/apache/syncope/pull/272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [syncope] ilgrosso opened a new pull request #272: Spring and Spring Security to latest 5.2 versions available

2021-06-01 Thread GitBox
ilgrosso opened a new pull request #272: URL: https://github.com/apache/syncope/pull/272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [syncope] andrea-patricelli merged pull request #271: enabling remediation create also from exceptions on pullActions (#269)

2021-05-28 Thread GitBox
andrea-patricelli merged pull request #271: URL: https://github.com/apache/syncope/pull/271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [syncope] ilgrosso merged pull request #270: Bump upgrades: CXF, Camel, OpenJPA, Elasticsearch, Tycho, cargo-maven2-plugin

2021-05-28 Thread GitBox
ilgrosso merged pull request #270: URL: https://github.com/apache/syncope/pull/270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [syncope] andrea-patricelli opened a new pull request #271: enabling remediation create also from exceptions on pullActions (#269)

2021-05-28 Thread GitBox
andrea-patricelli opened a new pull request #271: URL: https://github.com/apache/syncope/pull/271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [syncope] andrea-patricelli merged pull request #269: creating remediation also from exceptions on pullActions, also fixing…

2021-05-28 Thread GitBox
andrea-patricelli merged pull request #269: URL: https://github.com/apache/syncope/pull/269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [syncope] ilgrosso opened a new pull request #270: Bump upgrades: CXF, Camel, OpenJPA, Tycho, cargo-maven2-plugin

2021-05-28 Thread GitBox
ilgrosso opened a new pull request #270: URL: https://github.com/apache/syncope/pull/270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [syncope] andrea-patricelli commented on pull request #269: creating remediation also from exceptions on pullActions, also fixing…

2021-05-28 Thread GitBox
andrea-patricelli commented on pull request #269: URL: https://github.com/apache/syncope/pull/269#issuecomment-850264678 > @andrea-patricelli it seems that Travis CI is failing at https://travis-ci.com/github/apache/syncope/builds/227158553#L6736 > > ``` >

[GitHub] [syncope] ilgrosso commented on pull request #269: creating remediation also from exceptions on pullActions, also fixing…

2021-05-28 Thread GitBox
ilgrosso commented on pull request #269: URL: https://github.com/apache/syncope/pull/269#issuecomment-850197309 @andrea-patricelli it seems that Travis CI is failing at https://travis-ci.com/github/apache/syncope/builds/227158553#L6736 ``` PullTaskITCase.remediationSinglePull:845

[GitHub] [syncope] andrea-patricelli opened a new pull request #269: creating remediation also from exceptions on pullActions, also fixing…

2021-05-27 Thread GitBox
andrea-patricelli opened a new pull request #269: URL: https://github.com/apache/syncope/pull/269 … single pull -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [syncope] ilgrosso merged pull request #268: Disable CXF Services Listing

2021-05-26 Thread GitBox
ilgrosso merged pull request #268: URL: https://github.com/apache/syncope/pull/268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [syncope] coheigea commented on pull request #268: Disable CXF Services Listing

2021-05-26 Thread GitBox
coheigea commented on pull request #268: URL: https://github.com/apache/syncope/pull/268#issuecomment-848915752 Yes, it does, as does the WADL, openapi + Swagger links. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [syncope] ilgrosso commented on pull request #268: Disable CXF Services Listing

2021-05-26 Thread GitBox
ilgrosso commented on pull request #268: URL: https://github.com/apache/syncope/pull/268#issuecomment-848907146 @coheigea when you disable service listing, does doc page still works, a.k.a. /syncope/ which output is similar to http://syncope.apache.org/rest/2.1/index.html ? -- This is

[GitHub] [syncope] coheigea opened a new pull request #268: Disable CXF Services Listing

2021-05-26 Thread GitBox
coheigea opened a new pull request #268: URL: https://github.com/apache/syncope/pull/268 As Syncope 2.1.x is stuck on CXF 3.2.x, it is vulnerable to: http://cxf.apache.org/security-advisories.data/CVE-2020-13954.txt.asc I confirmed with this PR you can no longer see the

[GitHub] [syncope] ilgrosso merged pull request #267: Updating the docs to make it clear that SHA1 is not the default algor…

2021-05-26 Thread GitBox
ilgrosso merged pull request #267: URL: https://github.com/apache/syncope/pull/267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [syncope] ilgrosso merged pull request #266: Remove unused PasswordGenerator class in the installer

2021-05-26 Thread GitBox
ilgrosso merged pull request #266: URL: https://github.com/apache/syncope/pull/266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [syncope] ilgrosso commented on pull request #267: Updating the docs to make it clear that SHA1 is not the default algor…

2021-05-25 Thread GitBox
ilgrosso commented on pull request #267: URL: https://github.com/apache/syncope/pull/267#issuecomment-847766359 @coheigea please don't forget to cherry-pick this commit to branch `2_1_X` once merged, thanks. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [syncope] coheigea opened a new pull request #267: Updating the docs to make it clear that SHA1 is not the default algor…

2021-05-25 Thread GitBox
coheigea opened a new pull request #267: URL: https://github.com/apache/syncope/pull/267 …ithm anymore for the admin password -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [syncope] coheigea commented on pull request #266: Remove unused PasswordGenerator class in the installer

2021-05-25 Thread GitBox
coheigea commented on pull request #266: URL: https://github.com/apache/syncope/pull/266#issuecomment-847764964 Yep exactly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [syncope] coheigea opened a new pull request #266: Remove unused PasswordGenerator class in the installer

2021-05-25 Thread GitBox
coheigea opened a new pull request #266: URL: https://github.com/apache/syncope/pull/266 It's not used since the move to use SSHA-256 by default in MavenUtils. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [syncope] ilgrosso merged pull request #265: Removing ianal-maven-plugin for Geronimo's tools-maven-plugin

2021-05-21 Thread GitBox
ilgrosso merged pull request #265: URL: https://github.com/apache/syncope/pull/265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [syncope] ilgrosso opened a new pull request #265: Removing ianal-maven-plugin for Geronimo's tools-maven-plugin

2021-05-21 Thread GitBox
ilgrosso opened a new pull request #265: URL: https://github.com/apache/syncope/pull/265 Attempting to solve the problems raised in [this ML thread](https://lists.apache.org/thread.html/913b0e77db9d5bb346a24cd85d9b4393e383700a7998ab249af703f4%40%3Cdev.syncope.apache.org%3E). -- This is

[GitHub] [syncope] ilgrosso merged pull request #264: [SYNCOPE-1635] Use singleton bean for each domain for each rule with conf

2021-05-20 Thread GitBox
ilgrosso merged pull request #264: URL: https://github.com/apache/syncope/pull/264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [syncope] ilgrosso commented on a change in pull request #264: [SYNCOPE-1635] Use singleton bean for each domain for each rule with conf

2021-05-20 Thread GitBox
ilgrosso commented on a change in pull request #264: URL: https://github.com/apache/syncope/pull/264#discussion_r636617535 ## File path: core/spring/src/main/java/org/apache/syncope/core/spring/ImplementationManager.java ## @@ -216,28 +217,27 @@ }

[GitHub] [syncope] DmitriyBrashevets commented on a change in pull request #264: [SYNCOPE-1635] Use singleton bean for each domain for each rule with conf

2021-05-20 Thread GitBox
DmitriyBrashevets commented on a change in pull request #264: URL: https://github.com/apache/syncope/pull/264#discussion_r636195578 ## File path: core/spring/src/main/java/org/apache/syncope/core/spring/ImplementationManager.java ## @@ -216,28 +217,27 @@ }

[GitHub] [syncope] DmitriyBrashevets commented on a change in pull request #264: [SYNCOPE-1635] Use singleton bean for each domain for each rule with conf

2021-05-20 Thread GitBox
DmitriyBrashevets commented on a change in pull request #264: URL: https://github.com/apache/syncope/pull/264#discussion_r636195578 ## File path: core/spring/src/main/java/org/apache/syncope/core/spring/ImplementationManager.java ## @@ -216,28 +217,27 @@ }

[GitHub] [syncope] DmitriyBrashevets commented on a change in pull request #264: [SYNCOPE-1635] Use singleton bean for each domain for each rule with conf

2021-05-20 Thread GitBox
DmitriyBrashevets commented on a change in pull request #264: URL: https://github.com/apache/syncope/pull/264#discussion_r636191747 ## File path: core/spring/src/main/java/org/apache/syncope/core/spring/ImplementationManager.java ## @@ -216,28 +217,27 @@ }

[GitHub] [syncope] DmitriyBrashevets commented on a change in pull request #264: [SYNCOPE-1635] Use singleton bean for each domain for each rule with conf

2021-05-20 Thread GitBox
DmitriyBrashevets commented on a change in pull request #264: URL: https://github.com/apache/syncope/pull/264#discussion_r636192432 ## File path: core/spring/src/main/java/org/apache/syncope/core/spring/ImplementationManager.java ## @@ -48,7 +49,7 @@ private static

[GitHub] [syncope] DmitriyBrashevets commented on a change in pull request #264: [SYNCOPE-1635] Use singleton bean for each domain for each rule with conf

2021-05-20 Thread GitBox
DmitriyBrashevets commented on a change in pull request #264: URL: https://github.com/apache/syncope/pull/264#discussion_r636180820 ## File path: core/spring/src/main/java/org/apache/syncope/core/spring/ImplementationManager.java ## @@ -48,7 +49,7 @@ private static

[GitHub] [syncope] ilgrosso commented on a change in pull request #264: [SYNCOPE-1635] Use singleton bean for each domain for each rule with conf

2021-05-20 Thread GitBox
ilgrosso commented on a change in pull request #264: URL: https://github.com/apache/syncope/pull/264#discussion_r636173742 ## File path: core/spring/src/main/java/org/apache/syncope/core/spring/ImplementationManager.java ## @@ -216,28 +217,27 @@ }

[GitHub] [syncope] DmitriyBrashevets commented on a change in pull request #264: [SYNCOPE-1635] Use singleton bean for each domain for each rule with conf

2021-05-20 Thread GitBox
DmitriyBrashevets commented on a change in pull request #264: URL: https://github.com/apache/syncope/pull/264#discussion_r636167234 ## File path: core/spring/src/main/java/org/apache/syncope/core/spring/ImplementationManager.java ## @@ -216,28 +217,27 @@ }

[GitHub] [syncope] DmitriyBrashevets commented on a change in pull request #264: [SYNCOPE-1635] Use singleton bean for each domain for each rule with conf

2021-05-20 Thread GitBox
DmitriyBrashevets commented on a change in pull request #264: URL: https://github.com/apache/syncope/pull/264#discussion_r636167234 ## File path: core/spring/src/main/java/org/apache/syncope/core/spring/ImplementationManager.java ## @@ -216,28 +217,27 @@ }

[GitHub] [syncope] ilgrosso commented on a change in pull request #264: [SYNCOPE-1635] Use singleton bean for each domain for each rule with conf

2021-05-20 Thread GitBox
ilgrosso commented on a change in pull request #264: URL: https://github.com/apache/syncope/pull/264#discussion_r636028258 ## File path: core/spring/src/main/java/org/apache/syncope/core/spring/ImplementationManager.java ## @@ -96,7 +97,7 @@ } } -public

[GitHub] [syncope] DmitriyBrashevets opened a new pull request #264: [SYNCOPE-1635] Use singleton bean for each domain for each rule with conf

2021-05-20 Thread GitBox
DmitriyBrashevets opened a new pull request #264: URL: https://github.com/apache/syncope/pull/264 …conf -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [syncope] ilgrosso commented on pull request #263: [SYNCOPE-1634] Provision group during user/group owner update

2021-05-18 Thread GitBox
ilgrosso commented on pull request #263: URL: https://github.com/apache/syncope/pull/263#issuecomment-843287982 thanks @DmitriyBrashevets ! I am going to cherry-pick on `master` -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [syncope] ilgrosso merged pull request #263: [SYNCOPE-1634] Provision group during user/group owner update

2021-05-18 Thread GitBox
ilgrosso merged pull request #263: URL: https://github.com/apache/syncope/pull/263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [syncope] DmitriyBrashevets commented on a change in pull request #263: [SYNCOPE-1634] Provision group during user/group owner update

2021-05-18 Thread GitBox
DmitriyBrashevets commented on a change in pull request #263: URL: https://github.com/apache/syncope/pull/263#discussion_r634485482 ## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/GroupDataBinderImpl.java ## @@ -207,16 +207,43

[GitHub] [syncope] DmitriyBrashevets commented on a change in pull request #263: [SYNCOPE-1634] Provision group during user/group owner update

2021-05-18 Thread GitBox
DmitriyBrashevets commented on a change in pull request #263: URL: https://github.com/apache/syncope/pull/263#discussion_r634484113 ## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/GroupDataBinderImpl.java ## @@ -207,16 +207,43

[GitHub] [syncope] DmitriyBrashevets commented on a change in pull request #263: [SYNCOPE-1634] Provision group during user/group owner update

2021-05-18 Thread GitBox
DmitriyBrashevets commented on a change in pull request #263: URL: https://github.com/apache/syncope/pull/263#discussion_r634483108 ## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/GroupDataBinderImpl.java ## @@ -207,16 +207,43

[GitHub] [syncope] DmitriyBrashevets commented on a change in pull request #263: [SYNCOPE-1634] Provision group during user/group owner update

2021-05-18 Thread GitBox
DmitriyBrashevets commented on a change in pull request #263: URL: https://github.com/apache/syncope/pull/263#discussion_r634482576 ## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/GroupDataBinderImpl.java ## @@ -207,16 +207,43

[GitHub] [syncope] ilgrosso commented on a change in pull request #263: [SYNCOPE-1634] Provision group during user/group owner update

2021-05-18 Thread GitBox
ilgrosso commented on a change in pull request #263: URL: https://github.com/apache/syncope/pull/263#discussion_r634443411 ## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/GroupDataBinderImpl.java ## @@ -207,16 +207,43 @@

[GitHub] [syncope] DmitriyBrashevets opened a new pull request #263: [SYNCOPE-1634] Provision group during user/group owner update

2021-05-18 Thread GitBox
DmitriyBrashevets opened a new pull request #263: URL: https://github.com/apache/syncope/pull/263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [syncope] ilgrosso merged pull request #262: [SYNCOPE-1630] (1) centralizing security checks in DAOs and (2) impro…

2021-05-11 Thread GitBox
ilgrosso merged pull request #262: URL: https://github.com/apache/syncope/pull/262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [syncope] ilgrosso edited a comment on pull request #262: [SYNCOPE-1630] (1) centralizing security checks in DAOs and (2) impro…

2021-05-04 Thread GitBox
ilgrosso edited a comment on pull request #262: URL: https://github.com/apache/syncope/pull/262#issuecomment-831143894 ~~Still TODO: add a pre-defined `GROUP_OWNER` Role where to place the set of Entitlements to assign, rather than do it by code~~ -- This is an automated message from

[GitHub] [syncope] ilgrosso commented on pull request #262: [SYNCOPE-1630] (1) centralizing security checks in DAOs and (2) impro…

2021-05-03 Thread GitBox
ilgrosso commented on pull request #262: URL: https://github.com/apache/syncope/pull/262#issuecomment-831143894 Still TODO: add a pre-defined `GROUP_OWNER` Role where to place the set of Entitlements to assign, rather than do it by code -- This is an automated message from the Apache

[GitHub] [syncope] mmoayyed merged pull request #258: Switch to CAS 6.4

2021-04-23 Thread GitBox
mmoayyed merged pull request #258: URL: https://github.com/apache/syncope/pull/258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [syncope] ilgrosso opened a new pull request #262: [SYNCOPE-1630] (1) centralizing security checks in DAOs and (2) impro…

2021-04-21 Thread GitBox
ilgrosso opened a new pull request #262: URL: https://github.com/apache/syncope/pull/262 …ve JPAAnySearchDAO -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [syncope] ilgrosso merged pull request #261: [SYNCOPE-1545] WA > Profiles

2021-04-14 Thread GitBox
ilgrosso merged pull request #261: URL: https://github.com/apache/syncope/pull/261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [syncope] ilgrosso opened a new pull request #261: [SYNCOPE-1545] WA > Profiles

2021-04-14 Thread GitBox
ilgrosso opened a new pull request #261: URL: https://github.com/apache/syncope/pull/261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [syncope] ilgrosso commented on a change in pull request #258: Switch to CAS 6.4

2021-04-09 Thread GitBox
ilgrosso commented on a change in pull request #258: URL: https://github.com/apache/syncope/pull/258#discussion_r610533237 ## File path: fit/wa-reference/src/test/java/org/apache/syncope/fit/ui/SAML2SP4UIITCase.java ## @@ -156,6 +158,20 @@ public static void idpSetup() {

[GitHub] [syncope] ilgrosso merged pull request #260: [SYNCOPE-1545] WA > OIDC 1.0

2021-04-09 Thread GitBox
ilgrosso merged pull request #260: URL: https://github.com/apache/syncope/pull/260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [syncope] ilgrosso opened a new pull request #260: [SYNCOPE-1545] WA > OIDC 1.0

2021-04-08 Thread GitBox
ilgrosso opened a new pull request #260: URL: https://github.com/apache/syncope/pull/260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [syncope] ilgrosso merged pull request #259: [SYNCOPE-1545] WA > SAML 2.0

2021-04-08 Thread GitBox
ilgrosso merged pull request #259: URL: https://github.com/apache/syncope/pull/259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [syncope] ilgrosso opened a new pull request #259: [SYNCOPE-1545] WA > SAML 2.0

2021-04-07 Thread GitBox
ilgrosso opened a new pull request #259: URL: https://github.com/apache/syncope/pull/259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [syncope] mmoayyed commented on pull request #258: Switch to CAS 6.4 RC3

2021-04-06 Thread GitBox
mmoayyed commented on pull request #258: URL: https://github.com/apache/syncope/pull/258#issuecomment-814080962 Fixed the exceptions locally. Further testing however shows that there are number of other issues regarding logout operations for SAML2 and OIDC. So, at the moment it's not

[GitHub] [syncope] mmoayyed edited a comment on pull request #258: Switch to CAS 6.4 RC3

2021-04-06 Thread GitBox
mmoayyed edited a comment on pull request #258: URL: https://github.com/apache/syncope/pull/258#issuecomment-813973306 It seems like the exceptions are due to the fact that xmlsectool ships with and leaks opensaml 4.0.1, whereas the configuration requires 4.1.0. I will play around with

[GitHub] [syncope] mmoayyed commented on pull request #258: Switch to CAS 6.4 RC3

2021-04-06 Thread GitBox
mmoayyed commented on pull request #258: URL: https://github.com/apache/syncope/pull/258#issuecomment-813973306 It seems like the exceptions are due to the fact that xmlsectool ships with and leaks opensaml 4.0.1, whereas the configuration requires 4.1.0. I will play around with some

[GitHub] [syncope] ilgrosso commented on pull request #258: Switch to CAS 6.4 RC3

2021-04-06 Thread GitBox
ilgrosso commented on pull request #258: URL: https://github.com/apache/syncope/pull/258#issuecomment-813877241 @mmoayyed please merge latest changes from `master` to fix build with Payara. About CAS / Pac4j upgrade, I am getting the same exceptions locally:

[GitHub] [syncope] ilgrosso merged pull request #257: Check compatibility with JDK 17

2021-04-02 Thread GitBox
ilgrosso merged pull request #257: URL: https://github.com/apache/syncope/pull/257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [syncope] mmoayyed merged pull request #251: SYNCOPE-1625 - Support delegation/impersonation for WA

2021-04-02 Thread GitBox
mmoayyed merged pull request #251: URL: https://github.com/apache/syncope/pull/251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [syncope] ilgrosso opened a new pull request #257: Check compatibility with JDK 17

2021-04-02 Thread GitBox
ilgrosso opened a new pull request #257: URL: https://github.com/apache/syncope/pull/257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [syncope] ilgrosso opened a new pull request #256: [SYNCOPE-1545] Configuration > AM Policies

2021-04-01 Thread GitBox
ilgrosso opened a new pull request #256: URL: https://github.com/apache/syncope/pull/256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [syncope] ilgrosso merged pull request #255: [SYNCOPE-1545] Allow to manage and deploy ClientApp's properties

2021-03-30 Thread GitBox
ilgrosso merged pull request #255: URL: https://github.com/apache/syncope/pull/255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [syncope] ilgrosso opened a new pull request #255: [SYNCOPE-1545] Allow to manage and deploy ClientApp's properties

2021-03-30 Thread GitBox
ilgrosso opened a new pull request #255: URL: https://github.com/apache/syncope/pull/255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

<    1   2   3   4   5   6   7   8   9   >