[GitHub] [systemml] mboehm7 commented on issue #866: [SYSTEMML-2533] Error in running MNIST LeNet algorithm

2020-03-01 Thread GitBox
mboehm7 commented on issue #866: [SYSTEMML-2533] Error in running MNIST LeNet algorithm URL: https://github.com/apache/systemml/pull/866#issuecomment-593146440 LGTM. Thanks for catching this issue @HannanKan. You're right and the reason for the conflict is that the related script max_pool2

[GitHub] [systemml] mboehm7 commented on issue #866: [SYSTEMML-2533] Error in running MNIST LeNet algorithm

2020-03-01 Thread GitBox
mboehm7 commented on issue #866: [SYSTEMML-2533] Error in running MNIST LeNet algorithm URL: https://github.com/apache/systemml/pull/866#issuecomment-593146612 Also could you please associate your github account with the email of your commit or change your commit so you get properly linked

[GitHub] [systemml] asfgit closed pull request #866: [SYSTEMML-2533] Error in running MNIST LeNet algorithm

2020-03-01 Thread GitBox
asfgit closed pull request #866: [SYSTEMML-2533] Error in running MNIST LeNet algorithm URL: https://github.com/apache/systemml/pull/866 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [systemml] HannanKan opened a new pull request #867: [SYSTEMML-2533] Error in running MNIST LeNet algorithm

2020-03-01 Thread GitBox
HannanKan opened a new pull request #867: [SYSTEMML-2533] Error in running MNIST LeNet algorithm URL: https://github.com/apache/systemml/pull/867 Fix bug in [[SYSTEMML-2533]](https://issues.apache.org/jira/projects/SYSTEMML/issues/SYSTEMML-2533?filter=allopenissues) according to help from

[GitHub] [systemml] HannanKan commented on issue #866: [SYSTEMML-2533] Error in running MNIST LeNet algorithm

2020-03-01 Thread GitBox
HannanKan commented on issue #866: [SYSTEMML-2533] Error in running MNIST LeNet algorithm URL: https://github.com/apache/systemml/pull/866#issuecomment-593184435 > LGTM. Thanks for catching this issue @HannanKan. You're right and the reason for the conflict is that the related script max_p

[GitHub] [systemml] raymondtay opened a new pull request #868: [SYSTEMML-2537] Improve the consistency of predicates in "if-then-else" expressions

2020-03-24 Thread GitBox
raymondtay opened a new pull request #868: [SYSTEMML-2537] Improve the consistency of predicates in "if-then-else" expressions URL: https://github.com/apache/systemml/pull/868 The original issue i noticed was when the conditional predicate in the if-expression didn't seem what i was used t

[GitHub] [systemml] mboehm7 commented on issue #868: [SYSTEMML-2537] Improve the consistency of predicates in "if-then-else" expressions

2020-03-25 Thread GitBox
mboehm7 commented on issue #868: [SYSTEMML-2537] Improve the consistency of predicates in "if-then-else" expressions URL: https://github.com/apache/systemml/pull/868#issuecomment-604042157 thanks for creating the issue, but I'm afraid that DML follows R semantics here where both if conditi

[GitHub] [systemml] mboehm7 edited a comment on issue #868: [SYSTEMML-2537] Improve the consistency of predicates in "if-then-else" expressions

2020-03-25 Thread GitBox
mboehm7 edited a comment on issue #868: [SYSTEMML-2537] Improve the consistency of predicates in "if-then-else" expressions URL: https://github.com/apache/systemml/pull/868#issuecomment-604042157 thanks for creating the issue, but I'm afraid that DML follows R semantics here where both if

[GitHub] [systemml] raymondtay commented on issue #868: [SYSTEMML-2537] Improve the consistency of predicates in "if-then-else" expressions

2020-03-25 Thread GitBox
raymondtay commented on issue #868: [SYSTEMML-2537] Improve the consistency of predicates in "if-then-else" expressions URL: https://github.com/apache/systemml/pull/868#issuecomment-604192818 > thanks for creating the issue, but I'm afraid that DML follows R semantics here where both if co

[GitHub] [systemml] raymondtay closed pull request #868: [SYSTEMML-2537] Improve the consistency of predicates in "if-then-else" expressions

2020-03-25 Thread GitBox
raymondtay closed pull request #868: [SYSTEMML-2537] Improve the consistency of predicates in "if-then-else" expressions URL: https://github.com/apache/systemml/pull/868 This is an automated message from the Apache Git Servi

[GitHub] [systemml] asfgit closed pull request #119: [SYSTEMML-637] Hybrid Flink Linear regression example

2020-03-27 Thread GitBox
asfgit closed pull request #119: [SYSTEMML-637] Hybrid Flink Linear regression example URL: https://github.com/apache/systemml/pull/119 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [systemml] Baunsgaard opened a new pull request #869: [MINOR] GitHub Workflows Cache Dependencies

2020-03-28 Thread GitBox
Baunsgaard opened a new pull request #869: [MINOR] GitHub Workflows Cache Dependencies URL: https://github.com/apache/systemml/pull/869 Workflows cache dependencies. In small test cases this reduce the time to execute tests to half. Especially true in the python tests cases. No

[GitHub] [systemml] Baunsgaard opened a new pull request #870: [MINOR] Travis badge

2020-03-28 Thread GitBox
Baunsgaard opened a new pull request #870: [MINOR] Travis badge URL: https://github.com/apache/systemml/pull/870 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [systemml] mboehm7 commented on issue #869: [MINOR] GitHub Workflows Cache Dependencies

2020-03-28 Thread GitBox
mboehm7 commented on issue #869: [MINOR] GitHub Workflows Cache Dependencies URL: https://github.com/apache/systemml/pull/869#issuecomment-605507240 LGTM - thanks @Baunsgaard. This is an automated message from the Apache Git S

[GitHub] [systemml] asfgit closed pull request #869: [MINOR] GitHub Workflows Cache Dependencies

2020-03-28 Thread GitBox
asfgit closed pull request #869: [MINOR] GitHub Workflows Cache Dependencies URL: https://github.com/apache/systemml/pull/869 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [systemml] mboehm7 commented on issue #870: [MINOR] Travis badge

2020-03-28 Thread GitBox
mboehm7 commented on issue #870: [MINOR] Travis badge URL: https://github.com/apache/systemml/pull/870#issuecomment-605507560 LGTM thanks @Baunsgaard. I guess the different urls originate from the special treatment of apache open source projects. --

[GitHub] [systemml] asfgit closed pull request #870: [MINOR] Travis badge

2020-03-28 Thread GitBox
asfgit closed pull request #870: [MINOR] Travis badge URL: https://github.com/apache/systemml/pull/870 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [systemml] Baunsgaard opened a new pull request #871: [SYSTEMDS-314] Python Federated Matrices

2020-03-29 Thread GitBox
Baunsgaard opened a new pull request #871: [SYSTEMDS-314] Python Federated Matrices URL: https://github.com/apache/systemml/pull/871 This commit contains: - Easy start of federated worker in /bin/systemds.sh - Setup of tests for the Python language bindings federated matrices -

[GitHub] [systemml] Baunsgaard commented on issue #871: [SYSTEMDS-314] Python Federated Matrices

2020-03-29 Thread GitBox
Baunsgaard commented on issue #871: [SYSTEMDS-314] Python Federated Matrices URL: https://github.com/apache/systemml/pull/871#issuecomment-605601427 It would be good to have a minor release with at least the federated worker startup part of this commit.

[GitHub] [systemml] Baunsgaard commented on issue #871: [SYSTEMDS-314] Python Federated Matrices

2020-03-29 Thread GitBox
Baunsgaard commented on issue #871: [SYSTEMDS-314] Python Federated Matrices URL: https://github.com/apache/systemml/pull/871#issuecomment-605601606 Also containing documentation update such that it is using relative paths to documentation. This makes the references work in different for

[GitHub] [systemml] Baunsgaard commented on issue #871: [SYSTEMDS-314] Python Federated Matrices

2020-03-29 Thread GitBox
Baunsgaard commented on issue #871: [SYSTEMDS-314] Python Federated Matrices URL: https://github.com/apache/systemml/pull/871#issuecomment-605605198 Note, some tests are failing in python federated. This is intentionally left in, so that we at some point can go back and fix the underlyin

[GitHub] [systemml] Baunsgaard edited a comment on issue #871: [SYSTEMDS-314] Python Federated Matrices

2020-03-29 Thread GitBox
Baunsgaard edited a comment on issue #871: [SYSTEMDS-314] Python Federated Matrices URL: https://github.com/apache/systemml/pull/871#issuecomment-605605198 Note, some tests are failing in python federated. This is intentionally left in, so that we at some point can go back and fix the u

[GitHub] [systemml] Baunsgaard opened a new pull request #872: [WIP][SYSTEMDS-273] Refactor Compressed Package

2020-03-29 Thread GitBox
Baunsgaard opened a new pull request #872: [WIP][SYSTEMDS-273] Refactor Compressed Package URL: https://github.com/apache/systemml/pull/872 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [systemml] corepointer commented on a change in pull request #871: [SYSTEMDS-314] Python Federated Matrices

2020-03-30 Thread GitBox
corepointer commented on a change in pull request #871: [SYSTEMDS-314] Python Federated Matrices URL: https://github.com/apache/systemml/pull/871#discussion_r400014472 ## File path: src/main/python/tests/federated/runFedTest.sh ## @@ -0,0 +1,65 @@ +#/bin/bash +#---

[GitHub] [systemml] corepointer commented on a change in pull request #871: [SYSTEMDS-314] Python Federated Matrices

2020-03-30 Thread GitBox
corepointer commented on a change in pull request #871: [SYSTEMDS-314] Python Federated Matrices URL: https://github.com/apache/systemml/pull/871#discussion_r400012824 ## File path: docker/pythonsysds.Dockerfile ## @@ -0,0 +1,28 @@ +#---

[GitHub] [systemml] Baunsgaard commented on a change in pull request #871: [SYSTEMDS-314] Python Federated Matrices

2020-03-30 Thread GitBox
Baunsgaard commented on a change in pull request #871: [SYSTEMDS-314] Python Federated Matrices URL: https://github.com/apache/systemml/pull/871#discussion_r400045627 ## File path: docker/pythonsysds.Dockerfile ## @@ -0,0 +1,28 @@ +#

[GitHub] [systemml] Baunsgaard commented on a change in pull request #871: [SYSTEMDS-314] Python Federated Matrices

2020-03-30 Thread GitBox
Baunsgaard commented on a change in pull request #871: [SYSTEMDS-314] Python Federated Matrices URL: https://github.com/apache/systemml/pull/871#discussion_r400051977 ## File path: src/main/python/tests/federated/runFedTest.sh ## @@ -0,0 +1,65 @@ +#/bin/bash +#

[GitHub] [systemml] Baunsgaard commented on issue #871: [SYSTEMDS-314] Python Federated Matrices

2020-03-30 Thread GitBox
Baunsgaard commented on issue #871: [SYSTEMDS-314] Python Federated Matrices URL: https://github.com/apache/systemml/pull/871#issuecomment-605904266 > LGTM except for the failing tests. In your comment, you mention that the failing tests are left in as a reminder to fix some bugs. Why not c

[GitHub] [systemml] kev-inn opened a new pull request #873: Update python package, making use of java distribution bin zip

2020-03-31 Thread GitBox
kev-inn opened a new pull request #873: Update python package, making use of java distribution bin zip URL: https://github.com/apache/systemml/pull/873 Updates the `setup.py`, making it read the `README.md` to remove redundancy and using the new github link. Additionally now the ste

[GitHub] [systemml] Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip

2020-03-31 Thread GitBox
Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip URL: https://github.com/apache/systemml/pull/873#discussion_r400857902 ## File path: src/main/python/setup.py ## @@ -49,19 +48,7 @@ name=ARTIFACT_NAME

[GitHub] [systemml] Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip

2020-03-31 Thread GitBox
Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip URL: https://github.com/apache/systemml/pull/873#discussion_r400858736 ## File path: src/main/python/README.md ## @@ -1,4 +1,7 @@ -# Python Readme +# Syste

[GitHub] [systemml] Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip

2020-03-31 Thread GitBox
Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip URL: https://github.com/apache/systemml/pull/873#discussion_r400855878 ## File path: src/main/python/BUILD_INSTRUCTIONS.md ## @@ -23,27 +23,34 @@ limitatio

[GitHub] [systemml] Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip

2020-03-31 Thread GitBox
Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip URL: https://github.com/apache/systemml/pull/873#discussion_r400859398 ## File path: src/main/python/setup.py ## @@ -49,19 +48,7 @@ name=ARTIFACT_NAME

[GitHub] [systemml] kev-inn opened a new pull request #874: Add SystemDSContext for systemds operations

2020-03-31 Thread GitBox
kev-inn opened a new pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874 Adds a `SystemDSContext` object which has to be used for the function calls which generate the input data for our SystemDS script. It can be used as an pyth

[GitHub] [systemml] Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip

2020-03-31 Thread GitBox
Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip URL: https://github.com/apache/systemml/pull/873#discussion_r400855251 ## File path: .github/workflows/python.yml ## @@ -57,7 +57,7 @@ jobs: ${{

[GitHub] [systemml] Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip

2020-03-31 Thread GitBox
Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip URL: https://github.com/apache/systemml/pull/873#discussion_r400855332 ## File path: .github/workflows/python.yml ## @@ -86,16 +86,5 @@ jobs: cd s

[GitHub] [systemml] Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip

2020-03-31 Thread GitBox
Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip URL: https://github.com/apache/systemml/pull/873#discussion_r400857253 ## File path: src/main/python/README.md ## @@ -1,4 +1,7 @@ -# Python Readme +# Syste

[GitHub] [systemml] kev-inn commented on a change in pull request #873: Update python package, making use of java distribution bin zip

2020-03-31 Thread GitBox
kev-inn commented on a change in pull request #873: Update python package, making use of java distribution bin zip URL: https://github.com/apache/systemml/pull/873#discussion_r400861209 ## File path: .github/workflows/python.yml ## @@ -86,16 +86,5 @@ jobs: cd src/

[GitHub] [systemml] kev-inn commented on a change in pull request #873: Update python package, making use of java distribution bin zip

2020-03-31 Thread GitBox
kev-inn commented on a change in pull request #873: Update python package, making use of java distribution bin zip URL: https://github.com/apache/systemml/pull/873#discussion_r400860953 ## File path: .github/workflows/python.yml ## @@ -57,7 +57,7 @@ jobs: ${{ ru

[GitHub] [systemml] kev-inn commented on a change in pull request #873: Update python package, making use of java distribution bin zip

2020-03-31 Thread GitBox
kev-inn commented on a change in pull request #873: Update python package, making use of java distribution bin zip URL: https://github.com/apache/systemml/pull/873#discussion_r400861801 ## File path: src/main/python/BUILD_INSTRUCTIONS.md ## @@ -23,27 +23,34 @@ limitations

[GitHub] [systemml] kev-inn commented on a change in pull request #873: Update python package, making use of java distribution bin zip

2020-03-31 Thread GitBox
kev-inn commented on a change in pull request #873: Update python package, making use of java distribution bin zip URL: https://github.com/apache/systemml/pull/873#discussion_r400862401 ## File path: src/main/python/README.md ## @@ -1,4 +1,7 @@ -# Python Readme +# SystemDS

[GitHub] [systemml] Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip

2020-03-31 Thread GitBox
Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip URL: https://github.com/apache/systemml/pull/873#discussion_r400863094 ## File path: .github/workflows/python.yml ## @@ -86,16 +86,5 @@ jobs: cd s

[GitHub] [systemml] kev-inn commented on a change in pull request #873: Update python package, making use of java distribution bin zip

2020-03-31 Thread GitBox
kev-inn commented on a change in pull request #873: Update python package, making use of java distribution bin zip URL: https://github.com/apache/systemml/pull/873#discussion_r400863451 ## File path: src/main/python/setup.py ## @@ -49,19 +48,7 @@ name=ARTIFACT_NAME,

[GitHub] [systemml] Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip

2020-03-31 Thread GitBox
Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip URL: https://github.com/apache/systemml/pull/873#discussion_r400863444 ## File path: src/main/python/BUILD_INSTRUCTIONS.md ## @@ -23,27 +23,34 @@ limitatio

[GitHub] [systemml] kev-inn commented on a change in pull request #873: Update python package, making use of java distribution bin zip

2020-03-31 Thread GitBox
kev-inn commented on a change in pull request #873: Update python package, making use of java distribution bin zip URL: https://github.com/apache/systemml/pull/873#discussion_r400865792 ## File path: src/main/python/BUILD_INSTRUCTIONS.md ## @@ -23,27 +23,34 @@ limitations

[GitHub] [systemml] kev-inn commented on a change in pull request #873: Update python package, making use of java distribution bin zip

2020-03-31 Thread GitBox
kev-inn commented on a change in pull request #873: Update python package, making use of java distribution bin zip URL: https://github.com/apache/systemml/pull/873#discussion_r400870534 ## File path: src/main/python/README.md ## @@ -1,4 +1,7 @@ -# Python Readme +# SystemDS

[GitHub] [systemml] Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip

2020-03-31 Thread GitBox
Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip URL: https://github.com/apache/systemml/pull/873#discussion_r400877466 ## File path: src/main/python/setup.py ## @@ -49,19 +48,7 @@ name=ARTIFACT_NAME

[GitHub] [systemml] Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip

2020-03-31 Thread GitBox
Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip URL: https://github.com/apache/systemml/pull/873#discussion_r400878301 ## File path: src/main/python/BUILD_INSTRUCTIONS.md ## @@ -23,27 +23,34 @@ limitatio

[GitHub] [systemml] kev-inn commented on a change in pull request #873: Update python package, making use of java distribution bin zip

2020-03-31 Thread GitBox
kev-inn commented on a change in pull request #873: Update python package, making use of java distribution bin zip URL: https://github.com/apache/systemml/pull/873#discussion_r400878868 ## File path: src/main/python/BUILD_INSTRUCTIONS.md ## @@ -23,27 +23,34 @@ limitations

[GitHub] [systemml] Baunsgaard commented on issue #873: Update python package, making use of java distribution bin zip

2020-03-31 Thread GitBox
Baunsgaard commented on issue #873: Update python package, making use of java distribution bin zip URL: https://github.com/apache/systemml/pull/873#issuecomment-606612194 LGTM This is an automated message from the Apache Git

[GitHub] [systemml] Baunsgaard opened a new pull request #875: [WIP] Kmv k minimum values (Destinct value estimation algoritm)

2020-03-31 Thread GitBox
Baunsgaard opened a new pull request #875: [WIP] Kmv k minimum values (Destinct value estimation algoritm) URL: https://github.com/apache/systemml/pull/875 Kevin S. Beyer, Peter J. Haas, Berthold Reinwald, Yannis Sismanis, Rainer Gemulla: On synopses for distinct‐value estimation under mul

[GitHub] [systemml] Baunsgaard commented on issue #875: [WIP] Kmv k minimum values (Destinct value estimation algoritm)

2020-03-31 Thread GitBox
Baunsgaard commented on issue #875: [WIP] Kmv k minimum values (Destinct value estimation algoritm) URL: https://github.com/apache/systemml/pull/875#issuecomment-606862480 Also including bit array data type utilizing long to contain the bits. Initially i thought i needed it, but apparent

[GitHub] [systemml] Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations

2020-04-04 Thread GitBox
Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874#discussion_r403498534 ## File path: src/main/python/systemds/script_building/dag.py ## @@ -20,11 +20,15 @@ #

[GitHub] [systemml] Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations

2020-04-04 Thread GitBox
Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874#discussion_r403498970 ## File path: src/main/python/systemds/utils/converters.py ## @@ -44,7 +44,7 @@ def numpy_to_matrix_blo

[GitHub] [systemml] Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations

2020-04-04 Thread GitBox
Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874#discussion_r403497891 ## File path: src/main/python/systemds/context/systemds_context.py ## @@ -0,0 +1,145 @@ +# ---

[GitHub] [systemml] Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations

2020-04-04 Thread GitBox
Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874#discussion_r403497547 ## File path: src/main/python/systemds/context/systemds_context.py ## @@ -0,0 +1,145 @@ +# ---

[GitHub] [systemml] Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations

2020-04-04 Thread GitBox
Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874#discussion_r403497746 ## File path: src/main/python/systemds/context/systemds_context.py ## @@ -0,0 +1,145 @@ +# ---

[GitHub] [systemml] Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations

2020-04-04 Thread GitBox
Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874#discussion_r403496508 ## File path: src/main/python/docs/source/matrix.rst ## @@ -23,6 +23,23 @@ Matrix API == +S

[GitHub] [systemml] Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations

2020-04-04 Thread GitBox
Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874#discussion_r403497434 ## File path: src/main/python/docs/source/simple_examples.rst ## @@ -62,36 +72,43 @@ Remember to first

[GitHub] [systemml] Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations

2020-04-04 Thread GitBox
Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874#discussion_r403496467 ## File path: src/main/python/docs/source/matrix.rst ## @@ -23,6 +23,23 @@ Matrix API == +S

[GitHub] [systemml] Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations

2020-04-04 Thread GitBox
Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874#discussion_r403497973 ## File path: src/main/python/systemds/matrix/matrix.py ## @@ -22,22 +22,29 @@ __all__ = ['Matrix', 'f

[GitHub] [systemml] Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations

2020-04-04 Thread GitBox
Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874#discussion_r403498141 ## File path: src/main/python/systemds/matrix/operation_node.py ## @@ -19,86 +19,92 @@ # #---

[GitHub] [systemml] Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations

2020-04-04 Thread GitBox
Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874#discussion_r40349 ## File path: src/main/python/systemds/context/__init__.py ## @@ -0,0 +1,19 @@ +#

[GitHub] [systemml] Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations

2020-04-04 Thread GitBox
Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874#discussion_r403497299 ## File path: src/main/python/docs/source/simple_examples.rst ## @@ -50,10 +56,14 @@ As output we get::

[GitHub] [systemml] Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations

2020-04-04 Thread GitBox
Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874#discussion_r403498782 ## File path: src/main/python/systemds/utils/consts.py ## @@ -0,0 +1,23 @@ +#

[GitHub] [systemml] Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations

2020-04-04 Thread GitBox
Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874#discussion_r403497486 ## File path: src/main/python/docs/source/simple_examples.rst ## @@ -62,36 +72,43 @@ Remember to first

[GitHub] [systemml] Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations

2020-04-04 Thread GitBox
Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874#discussion_r403496672 ## File path: src/main/python/docs/source/matrix.rst ## @@ -49,13 +66,18 @@ Matrix -- A ``Matri

[GitHub] [systemml] Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations

2020-04-04 Thread GitBox
Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874#discussion_r403501389 ## File path: src/main/python/systemds/context/systemds_context.py ## @@ -0,0 +1,145 @@ +# ---

[GitHub] [systemml] Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations

2020-04-04 Thread GitBox
Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874#discussion_r403497706 ## File path: src/main/python/systemds/context/systemds_context.py ## @@ -0,0 +1,145 @@ +# ---

[GitHub] [systemml] Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations

2020-04-04 Thread GitBox
Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874#discussion_r403497568 ## File path: src/main/python/systemds/context/systemds_context.py ## @@ -0,0 +1,145 @@ +# ---

[GitHub] [systemml] Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations

2020-04-04 Thread GitBox
Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874#discussion_r403497147 ## File path: src/main/python/docs/source/matrix.rst ## @@ -49,13 +66,18 @@ Matrix -- A ``Matri

[GitHub] [systemml] Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations

2020-04-04 Thread GitBox
Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874#discussion_r403498825 ## File path: src/main/python/systemds/utils/consts.py ## @@ -0,0 +1,23 @@ +#

[GitHub] [systemml] Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations

2020-04-04 Thread GitBox
Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874#discussion_r403498855 ## File path: src/main/python/systemds/context/systemds_context.py ## @@ -0,0 +1,145 @@ +# ---

[GitHub] [systemml] Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations

2020-04-04 Thread GitBox
Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874#discussion_r403496748 ## File path: src/main/python/docs/source/matrix.rst ## @@ -49,13 +66,18 @@ Matrix -- A ``Matri

[GitHub] [systemml] Baunsgaard commented on issue #871: [SYSTEMDS-314] Python Federated Matrices

2020-04-04 Thread GitBox
Baunsgaard commented on issue #871: [SYSTEMDS-314] Python Federated Matrices URL: https://github.com/apache/systemml/pull/871#issuecomment-609071537 @mboehm7 I have commented out the "advanced" federated matrix tests. This means it now verifies that the python federated basics work, a

[GitHub] [systemml] phaniarnab opened a new pull request #876: [SYSTEMDS-331] Cache and Reuse scalar results

2020-04-05 Thread GitBox
phaniarnab opened a new pull request #876: [SYSTEMDS-331] Cache and Reuse scalar results URL: https://github.com/apache/systemml/pull/876 - This patch contains lineage caching support for scalar objects. This enables instruction level and multi-level reuse of operations/functions/statemen

[GitHub] [systemml] Baunsgaard commented on a change in pull request #876: [SYSTEMDS-331] Cache and Reuse scalar results

2020-04-05 Thread GitBox
Baunsgaard commented on a change in pull request #876: [SYSTEMDS-331] Cache and Reuse scalar results URL: https://github.com/apache/systemml/pull/876#discussion_r403703752 ## File path: src/main/java/org/apache/sysds/runtime/instructions/cp/StringObject.java ## @@ -59,6 +

[GitHub] [systemml] phaniarnab commented on a change in pull request #876: [SYSTEMDS-331] Cache and Reuse scalar results

2020-04-05 Thread GitBox
phaniarnab commented on a change in pull request #876: [SYSTEMDS-331] Cache and Reuse scalar results URL: https://github.com/apache/systemml/pull/876#discussion_r403723111 ## File path: src/main/java/org/apache/sysds/runtime/instructions/cp/StringObject.java ## @@ -59,6 +

[GitHub] [systemml] phaniarnab commented on issue #876: [SYSTEMDS-331] Cache and Reuse scalar results

2020-04-05 Thread GitBox
phaniarnab commented on issue #876: [SYSTEMDS-331] Cache and Reuse scalar results URL: https://github.com/apache/systemml/pull/876#issuecomment-609441851 StatementBlock level reuse, i.e. reusing the outputs of a statement block from cache. -

[GitHub] [systemml] Baunsgaard opened a new pull request #877: SystemDS Documentation

2020-04-07 Thread GitBox
Baunsgaard opened a new pull request #877: SystemDS Documentation URL: https://github.com/apache/systemml/pull/877 Brute change of documentation page to reflect name change. To fully enforce this two more steps are needed: 1. https://github.com/apache/systemml-website 2. Acc

[GitHub] [systemml] Baunsgaard opened a new pull request #878: Git Ignore for documentation build

2020-04-07 Thread GitBox
Baunsgaard opened a new pull request #878: Git Ignore for documentation build URL: https://github.com/apache/systemml/pull/878 Git ignore for when switching between documentation branch and back. This is an automated message f

[GitHub] [systemml] j143 commented on issue #877: SystemDS Documentation

2020-04-07 Thread GitBox
j143 commented on issue #877: SystemDS Documentation URL: https://github.com/apache/systemml/pull/877#issuecomment-610732106 Hi @Baunsgaard, priliminary comments: - [ ] Documentation _name refactoring_ can be done on feature by feature basis. i.e., > 1. changing

[GitHub] [systemml] j143 commented on a change in pull request #877: SystemDS Documentation

2020-04-07 Thread GitBox
j143 commented on a change in pull request #877: SystemDS Documentation URL: https://github.com/apache/systemml/pull/877#discussion_r405240804 ## File path: README.md ## @@ -17,26 +17,49 @@ limitations under the License. {% endcomment %} --> -# Apache SystemML Documenta

[GitHub] [systemml] j143 commented on a change in pull request #877: SystemDS Documentation

2020-04-07 Thread GitBox
j143 commented on a change in pull request #877: SystemDS Documentation URL: https://github.com/apache/systemml/pull/877#discussion_r405241622 ## File path: .gitignore ## @@ -0,0 +1,15 @@ +.classpath +.jekyll-cache/ +.project +_site/ +Gemfile.lock + +## VS Code + +.settings

[GitHub] [systemml] j143 commented on issue #878: Git Ignore for documentation build

2020-04-07 Thread GitBox
j143 commented on issue #878: Git Ignore for documentation build URL: https://github.com/apache/systemml/pull/878#issuecomment-610738521 LGTM 👍 . Thanks. This is an automated message from the Apache Git Service. To respond to

[GitHub] [systemml] Baunsgaard opened a new pull request #879: [MINOR] Git ignore for documentation

2020-04-08 Thread GitBox
Baunsgaard opened a new pull request #879: [MINOR] Git ignore for documentation URL: https://github.com/apache/systemml/pull/879 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [systemml] Baunsgaard commented on a change in pull request #877: SystemDS Documentation

2020-04-08 Thread GitBox
Baunsgaard commented on a change in pull request #877: SystemDS Documentation URL: https://github.com/apache/systemml/pull/877#discussion_r405389855 ## File path: .gitignore ## @@ -0,0 +1,15 @@ +.classpath +.jekyll-cache/ +.project +_site/ +Gemfile.lock + +## VS Code + +.se

[GitHub] [systemml] Baunsgaard commented on a change in pull request #877: SystemDS Documentation

2020-04-08 Thread GitBox
Baunsgaard commented on a change in pull request #877: SystemDS Documentation URL: https://github.com/apache/systemml/pull/877#discussion_r405390846 ## File path: .gitignore ## @@ -0,0 +1,15 @@ +.classpath +.jekyll-cache/ +.project +_site/ +Gemfile.lock + +## VS Code + +.se

[GitHub] [systemml] Baunsgaard commented on a change in pull request #877: SystemDS Documentation

2020-04-08 Thread GitBox
Baunsgaard commented on a change in pull request #877: SystemDS Documentation URL: https://github.com/apache/systemml/pull/877#discussion_r405391317 ## File path: README.md ## @@ -17,26 +17,49 @@ limitations under the License. {% endcomment %} --> -# Apache SystemML Doc

[GitHub] [systemml] Baunsgaard edited a comment on issue #877: SystemDS Documentation

2020-04-08 Thread GitBox
Baunsgaard edited a comment on issue #877: SystemDS Documentation URL: https://github.com/apache/systemml/pull/877#issuecomment-610861056 When switching the MLContext to DSContext it does not align with the new python. These again, have to be rewritten. -

[GitHub] [systemml] Baunsgaard commented on issue #877: SystemDS Documentation

2020-04-08 Thread GitBox
Baunsgaard commented on issue #877: SystemDS Documentation URL: https://github.com/apache/systemml/pull/877#issuecomment-610861056 When switching the MLContext to DSContext it does not allign with the new python. These again, have to be rewritten. ---

[GitHub] [systemml] j143 commented on issue #879: [MINOR] Git ignore for documentation

2020-04-08 Thread GitBox
j143 commented on issue #879: [MINOR] Git ignore for documentation URL: https://github.com/apache/systemml/pull/879#issuecomment-610862349 Hi, can the commit be formatted as shown in this snip (Adding description, however small would be great!) For example: [DOC][MINOR] .gitignore for vs

[GitHub] [systemml] Baunsgaard commented on issue #879: [MINOR] Git ignore for documentation

2020-04-08 Thread GitBox
Baunsgaard commented on issue #879: [MINOR] Git ignore for documentation URL: https://github.com/apache/systemml/pull/879#issuecomment-610864922 > Hi, can the commit be formatted as shown in this snip (Adding description, however small would be great!) > For example: [DOC][MINOR] .gitign

[GitHub] [systemml] j143 commented on issue #877: SystemDS Documentation

2020-04-08 Thread GitBox
j143 commented on issue #877: SystemDS Documentation URL: https://github.com/apache/systemml/pull/877#issuecomment-610867367 Hey! > When switching the MLContext to DSContext it does not allign with the new python. > These again, have to be rewritten. it seems `MLContext` is not

[GitHub] [systemml] j143 commented on issue #877: SystemDS Documentation

2020-04-08 Thread GitBox
j143 commented on issue #877: SystemDS Documentation URL: https://github.com/apache/systemml/pull/877#issuecomment-610868265 > * [ ] Also, renaming of the following files can be considered (exhaustive list) > > 1. [developer-tools-systemml.md](https://github.com/apache/systemml

[GitHub] [systemml] j143 commented on a change in pull request #879: [MINOR] Git ignore for documentation

2020-04-08 Thread GitBox
j143 commented on a change in pull request #879: [MINOR] Git ignore for documentation URL: https://github.com/apache/systemml/pull/879#discussion_r405410429 ## File path: .gitignore ## @@ -0,0 +1,15 @@ +.classpath +.jekyll-cache/ +.project +_site/ +Gemfile.lock + +## VS Co

[GitHub] [systemml] Baunsgaard commented on issue #877: SystemDS Documentation

2020-04-08 Thread GitBox
Baunsgaard commented on issue #877: SystemDS Documentation URL: https://github.com/apache/systemml/pull/877#issuecomment-610873871 > > * [ ] Also, renaming of the following files can be considered (exhaustive list) > > > > > > 1. [developer-tools-systemml.md](https://github.co

[GitHub] [systemml] asfgit closed pull request #878: Git Ignore for documentation build

2020-04-08 Thread GitBox
asfgit closed pull request #878: Git Ignore for documentation build URL: https://github.com/apache/systemml/pull/878 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [systemml] asfgit closed pull request #879: [MINOR] Git ignore for documentation

2020-04-08 Thread GitBox
asfgit closed pull request #879: [MINOR] Git ignore for documentation URL: https://github.com/apache/systemml/pull/879 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [systemml] j143 opened a new pull request #880: [MINOR] [DOC] skip IntelliJ, and mvn build config files

2020-04-08 Thread GitBox
j143 opened a new pull request #880: [MINOR] [DOC] skip IntelliJ, and mvn build config files URL: https://github.com/apache/systemml/pull/880 This PR is for discussion and work related to few more add the to be ignored files. Configuration files related to 1. maven build - [ ]

<    3   4   5   6   7   8   9   10   >