Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/30
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/29
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/29#discussion_r98803604
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/HBaseTransactionPruningPlugin.java
---
@@ -219,13
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/31
@gokulavasan I took a pass over this, I have a few comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/31#discussion_r99760211
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/DataJanitorState.java
---
@@ -120,6 +143,22 @@ public
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/31#discussion_r99759970
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/DataJanitorState.java
---
@@ -102,11 +107,29 @@ public
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/31#discussion_r99760732
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/DataJanitorState.java
---
@@ -129,17 +168,19 @@ public
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/31#discussion_r99750392
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/InvalidListPruningDebug.java
---
@@ -0,0 +1,191
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/31#discussion_r99751362
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/InvalidListPruningDebug.java
---
@@ -0,0 +1,191
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/31#discussion_r99750520
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/InvalidListPruningDebug.java
---
@@ -0,0 +1,191
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/31#discussion_r99750194
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/HBaseTransactionPruningPlugin.java
---
@@ -147,6 +147,7
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/31#discussion_r99750124
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/InvalidListPruningDebug.java
---
@@ -0,0 +1,191
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/31#discussion_r99750227
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/InvalidListPruningDebug.java
---
@@ -0,0 +1,191
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/31#discussion_r99750467
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/InvalidListPruningDebug.java
---
@@ -0,0 +1,191
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/31#discussion_r99761297
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/InvalidListPruningDebug.java
---
@@ -0,0 +1,191
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/31#discussion_r99760787
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/DataJanitorState.java
---
@@ -129,17 +168,19 @@ public
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/32#discussion_r99882082
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriterSupplier.java
---
@@ -0,0 +1,52
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/32#discussion_r99879439
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriterSupplier.java
---
@@ -0,0 +1,52
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/31#discussion_r99962992
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/DataJanitorState.java
---
@@ -129,17 +168,19 @@ public
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/32#discussion_r100201292
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriter.java
---
@@ -18,77 +18,85
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/32#discussion_r100202801
--- Diff:
tephra-hbase-compat-1.1-base/src/test/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriterSupplierTest.java
---
@@ -0,0
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/32#discussion_r100203117
--- Diff:
tephra-hbase-compat-1.1-base/src/test/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriterSupplierTest.java
---
@@ -0,0
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/32#discussion_r100202882
--- Diff:
tephra-hbase-compat-1.1-base/src/test/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriterSupplierTest.java
---
@@ -0,0
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/32#discussion_r100201530
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriter.java
---
@@ -18,77 +18,85
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/32#discussion_r100202843
--- Diff:
tephra-hbase-compat-1.1-base/src/test/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriterSupplierTest.java
---
@@ -0,0
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/32#discussion_r100202630
--- Diff:
tephra-hbase-compat-1.1-base/src/test/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriterSupplierTest.java
---
@@ -0,0
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/32#discussion_r100202537
--- Diff:
tephra-hbase-compat-1.1-base/src/test/java/org/apache/tephra/hbase/txprune/InvalidListPruneTest.java
---
@@ -334,6 +337,46
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/32#discussion_r100200476
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriter.java
---
@@ -18,77 +18,85
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/32#discussion_r100193873
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriter.java
---
@@ -18,56 +18,56
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/32#discussion_r100202379
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriterSupplier.java
---
@@ -0,0 +1,84
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/32#discussion_r100202356
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriterSupplier.java
---
@@ -0,0 +1,84
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/32
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/31
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/32#discussion_r100040267
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriter.java
---
@@ -18,56 +18,56
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/32#discussion_r100042824
--- Diff:
tephra-hbase-compat-1.1-base/src/test/java/org/apache/tephra/hbase/txprune/InvalidListPruneTest.java
---
@@ -360,8 +404,18
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/32#discussion_r100028436
--- Diff:
tephra-core/src/main/java/org/apache/tephra/coprocessor/TransactionStateCache.java
---
@@ -70,7 +71,11 @@ public void setConf
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/29#discussion_r98786621
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriter.java
---
@@ -0,0 +1,104
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/29#discussion_r98780450
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/HBaseTransactionPruningPlugin.java
---
@@ -209,6 +212,31
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/29
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/29#discussion_r98780134
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriter.java
---
@@ -77,7 +78,7 @@ public
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/29#discussion_r98786925
--- Diff:
tephra-hbase-compat-1.1-base/src/test/java/org/apache/tephra/hbase/txprune/InvalidListPruneTest.java
---
@@ -135,6 +138,15
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/29#discussion_r98782081
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -324,7 +326,10
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/29#discussion_r98786420
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriter.java
---
@@ -0,0 +1,104
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/28#discussion_r97401610
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -140,29 +141,25
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/28#discussion_r97436585
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -140,29 +141,25
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/29#discussion_r98135660
--- Diff: tephra-core/src/main/java/org/apache/tephra/TxConstants.java ---
@@ -369,6 +369,12 @@
* Interval in seconds to schedule
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/28#discussion_r97917171
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -140,29 +143,37
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/28
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/28#discussion_r97702427
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -303,10 +305,22
GitHub user poornachandra opened a pull request:
https://github.com/apache/incubator-tephra/pull/38
TEPHRA-224 Handle delay between transaction max lifetime check and data
writes while pruning
JIRA - https://issues.apache.org/jira/browse/TEPHRA-224
You can merge this pull request
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/38#discussion_r102366454
--- Diff: tephra-core/src/main/java/org/apache/tephra/TxConstants.java ---
@@ -376,6 +376,11 @@
public static final String
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/37#discussion_r102348853
--- Diff:
tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
@@ -1123,15 +1112,14 @@ private boolean
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/38#discussion_r102366609
--- Diff:
tephra-core/src/main/java/org/apache/tephra/txprune/TransactionPruningRunnable.java
---
@@ -57,8 +60,13 @@ public void run
GitHub user poornachandra opened a pull request:
https://github.com/apache/incubator-tephra/pull/37
TEPHRA-223 Encapsulate the two data structures used for invalid
transactions to avoid update issues
JIRA - https://issues.apache.org/jira/browse/TEPHRA-223
Approach
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/37#discussion_r102123021
--- Diff:
tephra-core/src/main/java/org/apache/tephra/manager/InvalidTxList.java ---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/37#discussion_r102125886
--- Diff:
tephra-core/src/main/java/org/apache/tephra/manager/InvalidTxList.java ---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/37
@anew @gokulavasan I have addressed the comments, please take another look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/37#discussion_r102127364
--- Diff:
tephra-core/src/main/java/org/apache/tephra/manager/InvalidTxList.java ---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/38#discussion_r102559503
--- Diff:
tephra-core/src/main/java/org/apache/tephra/txprune/TransactionPruningRunnable.java
---
@@ -57,8 +60,13 @@ public void run
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/38
@anew @chtyim I have addressed comments. Please take another look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user poornachandra closed the pull request at:
https://github.com/apache/incubator-tephra/pull/38
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/38
Merged this PR to branch release/0.11.0-incubating
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/34
@gokulavasan I have ported the changes to other compat modules, please take
a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/35#discussion_r100931439
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -340,12 +345,7
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/35#discussion_r100931390
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -454,28 +441,39
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/35#discussion_r100940705
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -454,28 +442,38
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/35#discussion_r100931804
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -454,28 +441,39
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/35#discussion_r100932301
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -356,8 +356,8
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/35#discussion_r100940812
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriter.java
---
@@ -97,27 +101,33
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/35
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/34#discussion_r100647433
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/HBaseTransactionPruningPlugin.java
---
@@ -288,23
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/34#discussion_r100648648
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/HBaseTransactionPruningPlugin.java
---
@@ -322,6
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/34#discussion_r100648684
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/DataJanitorState.java
---
@@ -366,6 +371,56 @@ public
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/34
@anew @gokulavasan In addition to addressing comments, I have added two
more commits, please take a look
---
If your project is set up for it, you can reply to this email and have
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/34
Thanks @anew. I will squash the commits and then port changes to other
compat modules.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/35#discussion_r100709175
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriter.java
---
@@ -81,14 +84,23
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/35#discussion_r100709097
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -317,31 +317,31
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/35#discussion_r100709949
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriter.java
---
@@ -81,14 +84,23
GitHub user poornachandra opened a pull request:
https://github.com/apache/incubator-tephra/pull/34
TEPHRA-216 Handle empty transactional regions during inactive list pruning
JIRA - https://issues.apache.org/jira/browse/TEPHRA-216
Approach:
1. Transaction Processor
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/26
@twdsilva Some code changes have not been ported over to file
tephra-hbase-compat-1.1-base/src/test/java/org/apache/tephra/hbase/TransactionAwareHTableTest.java,
hence the tests
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/4
LGTM. Please squash the commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/2#discussion_r77899606
--- Diff:
tephra-core/src/main/java/org/apache/tephra/runtime/TransactionDistributedModule.java
---
@@ -41,14 +41,15 @@
@Override
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/2#discussion_r77906210
--- Diff:
tephra-core/src/test/java/org/apache/tephra/distributed/ThriftTransactionServerTest.java
---
@@ -188,21 +224,35 @@ public void
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/2#discussion_r77901080
--- Diff:
tephra-core/src/main/java/org/apache/tephra/runtime/TransactionInMemoryModule.java
---
@@ -43,10 +44,12 @@ public
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/9#discussion_r78230677
--- Diff: tephra-examples/pom.xml ---
@@ -51,6 +55,53 @@
tephra-core
${project.version}
+
--- End
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/8#discussion_r78137456
--- Diff:
tephra-core/src/test/java/org/apache/tephra/distributed/PooledClientProviderTest.java
---
@@ -137,15 +137,15 @@ public Boolean call
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/10#discussion_r78493478
--- Diff:
tephra-core/src/main/java/org/apache/tephra/runtime/DefaultTransactionManagerProvider.java
---
@@ -0,0 +1,71
GitHub user poornachandra opened a pull request:
https://github.com/apache/incubator-tephra/pull/10
TEPHRA-179 Transaction service high availability changes
Restructuring the Transaction Service classes to allow for HA restart while
binding Transaction Manager and other classes
GitHub user poornachandra opened a pull request:
https://github.com/apache/incubator-tephra/pull/9
Wait for Transaction Service to announce itself to fix flaky tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/poornachandra
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/17#discussion_r82304628
--- Diff:
tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
@@ -722,7 +725,10 @@ public Transaction startShort
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/17
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/14#discussion_r79964659
--- Diff:
tephra-core/src/main/java/org/apache/tephra/TransactionContext.java ---
@@ -88,7 +88,27 @@ public boolean removeTransactionAware
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/13
LGTM, thanks for the contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/14#discussion_r79965483
--- Diff:
tephra-core/src/main/java/org/apache/tephra/TransactionContext.java ---
@@ -97,6 +127,7 @@ public void start() throws
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/3#discussion_r77885100
--- Diff: pom.xml ---
@@ -346,6 +352,18 @@
+
+org.slf4j
+log4j-over
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/19
@anew One way to handle the above issue is to define a time limit that
defines a maximum duration a transaction can be used for writing. While doing
data writes, we could add some
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/19
@anew I'll add the maximum duration check as a separate PR. I'll file a
JIRA for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/18#discussion_r84387594
--- Diff:
tephra-core/src/test/java/org/apache/tephra/TransactionSystemTest.java ---
@@ -33,25 +33,33 @@
*/
public abstract class
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/18#discussion_r84388540
--- Diff:
tephra-core/src/test/java/org/apache/tephra/ThriftTransactionSystemTest.java ---
@@ -124,4 +127,39 @@ protected
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/18#discussion_r84387667
--- Diff:
tephra-core/src/test/java/org/apache/tephra/TransactionSystemTest.java ---
@@ -33,25 +33,33 @@
*/
public abstract class
1 - 100 of 186 matches
Mail list logo
