[jira] [Commented] (THRIFT-3129) Unexpected include behavior

2015-05-06 Thread Konrad Grochowski (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530204#comment-14530204 ] Konrad Grochowski commented on THRIFT-3129: --- try {{-I../project1}} - it should

[jira] [Updated] (THRIFT-3129) Unexpected include behavior

2015-05-06 Thread David Ehrmann (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Ehrmann updated THRIFT-3129: -- Description: I have the following directory structure: {code} ./project0/wrapper.thrift

[jira] [Reopened] (THRIFT-2000) TNonblocking server does not compile with libevent 2.0.21-stable

2015-05-06 Thread Konrad Grochowski (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Grochowski reopened THRIFT-2000: --- I still need those ifdefs from patch - I'll double check it later. TNonblocking server

[jira] [Comment Edited] (THRIFT-3129) Unexpected include behavior

2015-05-06 Thread David Ehrmann (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530239#comment-14530239 ] David Ehrmann edited comment on THRIFT-3129 at 5/6/15 9:40 AM:

[jira] [Comment Edited] (THRIFT-3129) Unexpected include behavior

2015-05-06 Thread David Ehrmann (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530239#comment-14530239 ] David Ehrmann edited comment on THRIFT-3129 at 5/6/15 9:40 AM:

[jira] [Commented] (THRIFT-3129) Unexpected include behavior

2015-05-06 Thread Konrad Grochowski (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530282#comment-14530282 ] Konrad Grochowski commented on THRIFT-3129: --- all types from included file has

[jira] [Updated] (THRIFT-3129) Unexpected include behavior

2015-05-06 Thread David Ehrmann (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Ehrmann updated THRIFT-3129: -- Description: I have the following directory structure: {code} ./project0/wrapper.thrift

[jira] [Comment Edited] (THRIFT-3129) Unexpected include behavior

2015-05-06 Thread David Ehrmann (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530239#comment-14530239 ] David Ehrmann edited comment on THRIFT-3129 at 5/6/15 9:37 AM:

[jira] [Commented] (THRIFT-2000) TNonblocking server does not compile with libevent 2.0.21-stable

2015-05-06 Thread Konrad Grochowski (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530303#comment-14530303 ] Konrad Grochowski commented on THRIFT-2000: --- ohhh I see what happened - on

[jira] [Closed] (THRIFT-2000) TNonblocking server does not compile with libevent 2.0.21-stable

2015-05-06 Thread Konrad Grochowski (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Grochowski closed THRIFT-2000. - Resolution: Not A Problem Fix Version/s: (was: 0.9.3) Assignee:

[jira] [Commented] (THRIFT-2000) TNonblocking server does not compile with libevent 2.0.21-stable

2015-05-06 Thread Konrad Grochowski (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530290#comment-14530290 ] Konrad Grochowski commented on THRIFT-2000: --- I have no idea how

[jira] [Comment Edited] (THRIFT-3129) Unexpected include behavior

2015-05-06 Thread David Ehrmann (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530239#comment-14530239 ] David Ehrmann edited comment on THRIFT-3129 at 5/6/15 9:35 AM:

[jira] [Commented] (THRIFT-1676) Allow specifying IP/hostname in TServer::serve

2015-05-06 Thread Konrad Grochowski (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530208#comment-14530208 ] Konrad Grochowski commented on THRIFT-1676: --- If I remember corectly

[jira] [Commented] (THRIFT-3129) Unexpected include behavior

2015-05-06 Thread David Ehrmann (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530239#comment-14530239 ] David Ehrmann commented on THRIFT-3129: --- Using the file, not the path, was a

[jira] [Commented] (THRIFT-3122) Javascript struct constructor should properly initialize struct and container members from plain js arguments

2015-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530260#comment-14530260 ] ASF GitHub Bot commented on THRIFT-3122: Github user henrique commented on the

[GitHub] thrift pull request: THRIFT-3122 Convert plain js objects given as...

2015-05-06 Thread henrique
Github user henrique commented on the pull request: https://github.com/apache/thrift/pull/476#issuecomment-99401213 Thanks for fixing it Igor but the acceptance tests make cross fail here: https://travis-ci.org/apache/thrift/jobs/61195454#L5395 --- If your project is set up for

[jira] [Created] (THRIFT-3129) Unexpected include behavior

2015-05-06 Thread David Ehrmann (JIRA)
David Ehrmann created THRIFT-3129: - Summary: Unexpected include behavior Key: THRIFT-3129 URL: https://issues.apache.org/jira/browse/THRIFT-3129 Project: Thrift Issue Type: Bug Affects

[jira] [Commented] (THRIFT-3129) Unexpected include behavior

2015-05-06 Thread David Ehrmann (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530331#comment-14530331 ] David Ehrmann commented on THRIFT-3129: --- Good catch. Thanks! Unexpected include

[jira] [Closed] (THRIFT-3129) Unexpected include behavior

2015-05-06 Thread David Ehrmann (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Ehrmann closed THRIFT-3129. - Resolution: Invalid Unexpected include behavior ---

[jira] [Commented] (THRIFT-2000) TNonblocking server does not compile with libevent 2.0.21-stable

2015-05-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530391#comment-14530391 ] James E. King, III commented on THRIFT-2000: I put some of this info into

[GitHub] thrift pull request: add valgrind suppression support to the Exper...

2015-05-06 Thread jeking3
GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/481 add valgrind suppression support to the ExperimentalMemCheck test run You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift

[jira] [Closed] (THRIFT-2150) Should windows/config.h define WIN32_LEAN_AND_MEAN?

2015-05-06 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig closed THRIFT-2150. - Resolution: Won't Fix This is a Microsoft build infrastructure issue that is external to the project

[GitHub] thrift pull request: add valgrind suppression support to the Exper...

2015-05-06 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/481 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-2474 complete the ntohll precompile co...

2015-05-06 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/482 THRIFT-2474 complete the ntohll precompile conditionals You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift

[jira] [Commented] (THRIFT-2474) thrift.h causes a compile failure

2015-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530572#comment-14530572 ] ASF GitHub Bot commented on THRIFT-2474: GitHub user jeking3 opened a pull

[jira] [Commented] (THRIFT-2474) thrift.h causes a compile failure

2015-05-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530575#comment-14530575 ] James E. King, III commented on THRIFT-2474: It looks like this was mostly

[jira] [Reopened] (THRIFT-3086) C++ Valgrind Error Cleanup

2015-05-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reopened THRIFT-3086: I'm reopening this to get pull request https://github.com/apache/thrift/pull/481

[jira] [Commented] (THRIFT-2000) TNonblocking server does not compile with libevent 2.0.21-stable

2015-05-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530389#comment-14530389 ] James E. King, III commented on THRIFT-2000: Okay - you filled in the

[jira] [Commented] (THRIFT-3130) Remove the last vestiges of THRIFT_OVERLOAD_IF from THRIFT-1316

2015-05-06 Thread Konrad Grochowski (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531532#comment-14531532 ] Konrad Grochowski commented on THRIFT-3130: --- unfortunately - it does not seem

[jira] [Commented] (THRIFT-2000) TNonblocking server does not compile with libevent 2.0.21-stable

2015-05-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531321#comment-14531321 ] James E. King, III commented on THRIFT-2000: boost::asio is a solid cross

[jira] [Commented] (THRIFT-3130) Remove the last vestiges of THRIFT_OVERLOAD_IF from THRIFT-1316

2015-05-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531342#comment-14531342 ] James E. King, III commented on THRIFT-3130: Given I added a new header by

[jira] [Commented] (THRIFT-3130) Remove the last vestiges of THRIFT_OVERLOAD_IF from THRIFT-1316

2015-05-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531486#comment-14531486 ] James E. King, III commented on THRIFT-3130: Please examine the changes to

[GitHub] thrift pull request: THRIFT-3122 Convert plain js objects given as...

2015-05-06 Thread itkach
Github user itkach commented on the pull request: https://github.com/apache/thrift/pull/476#issuecomment-99608147 I see that the build failed again: https://travis-ci.org/apache/thrift/jobs/61506900#L5435 but it doesn't look like this is related to my changes. When I run tests

[jira] [Commented] (THRIFT-3130) Remove the last vestiges of THRIFT_OVERLOAD_IF from THRIFT-1316

2015-05-06 Thread Konrad Grochowski (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531426#comment-14531426 ] Konrad Grochowski commented on THRIFT-3130: --- if you remove THRIFT_OVERLOAD_IF

[jira] [Commented] (THRIFT-3122) Javascript struct constructor should properly initialize struct and container members from plain js arguments

2015-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531397#comment-14531397 ] ASF GitHub Bot commented on THRIFT-3122: Github user itkach commented on the pull

[jira] [Commented] (THRIFT-3099) cmake build is broken on FreeBSD

2015-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531144#comment-14531144 ] ASF GitHub Bot commented on THRIFT-3099: Github user jeking3 commented on the

[jira] [Commented] (THRIFT-2850) CMake for Apache Thrift

2015-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531141#comment-14531141 ] ASF GitHub Bot commented on THRIFT-2850: Github user jeking3 closed the pull

[GitHub] thrift pull request: THRIFT-3099 cmake build is broken on FreeBSD

2015-05-06 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/446#issuecomment-99566610 This was merged on 16/Apr and can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (THRIFT-3088) TThreadPoolServer with Sasl auth may leak CLOSE_WAIT socket

2015-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531152#comment-14531152 ] ASF GitHub Bot commented on THRIFT-3088: Github user jeking3 commented on the

[GitHub] thrift pull request: THRIFT-2850 get windows cmake working again a...

2015-05-06 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/474 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3084 add optional concurrent client li...

2015-05-06 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/473 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3084 add optional concurrent client li...

2015-05-06 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/473#issuecomment-99566156 Closing as it was merged into external repo. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] thrift pull request: Thrift 3097

2015-05-06 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/443#issuecomment-99566931 This was merged on Apr 15 and can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Created] (THRIFT-3130) Remove the last vestiges of THRIFT_OVERLOAD_IF from THRIFT-1316

2015-05-06 Thread James E. King, III (JIRA)
James E. King, III created THRIFT-3130: -- Summary: Remove the last vestiges of THRIFT_OVERLOAD_IF from THRIFT-1316 Key: THRIFT-3130 URL: https://issues.apache.org/jira/browse/THRIFT-3130 Project:

[jira] [Commented] (THRIFT-3083) C++ Consolidate server processing loops in TSimpleServer, TThreadedServer, TThreadPoolServer

2015-05-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531100#comment-14531100 ] James E. King, III commented on THRIFT-3083: The use of the

[jira] [Commented] (THRIFT-3130) Remove the last vestiges of THRIFT_OVERLOAD_IF from THRIFT-1316

2015-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531120#comment-14531120 ] ASF GitHub Bot commented on THRIFT-3130: GitHub user jeking3 opened a pull

[GitHub] thrift pull request: [THRIFT-3088] TThreadPoolServer with Sasl aut...

2015-05-06 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/432#issuecomment-99567451 This was committed on Apr 12 and can be closed, however please check the TServer variants in Java and see that they use the same logic to close all resources. --- If

[jira] [Commented] (THRIFT-2000) TNonblocking server does not compile with libevent 2.0.21-stable

2015-05-06 Thread Konrad Grochowski (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531185#comment-14531185 ] Konrad Grochowski commented on THRIFT-2000: --- no idea - I had to reproduce make

[GitHub] thrift pull request: THRIFT-3130 finish removal of THRIFT_OVERLOAD...

2015-05-06 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/483 THRIFT-3130 finish removal of THRIFT_OVERLOAD_IF Testing proved it was unnecessary. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] thrift pull request: THRIFT-2850 get windows cmake working again a...

2015-05-06 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/474#issuecomment-99566301 Closing as it was merged into external repo. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (THRIFT-3084) C++ add concurrent client limit to threaded servers

2015-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531138#comment-14531138 ] ASF GitHub Bot commented on THRIFT-3084: Github user jeking3 commented on the

[jira] [Commented] (THRIFT-3084) C++ add concurrent client limit to threaded servers

2015-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531139#comment-14531139 ] ASF GitHub Bot commented on THRIFT-3084: Github user jeking3 closed the pull

[jira] [Commented] (THRIFT-2850) CMake for Apache Thrift

2015-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531140#comment-14531140 ] ASF GitHub Bot commented on THRIFT-2850: Github user jeking3 commented on the

[jira] [Commented] (THRIFT-2000) TNonblocking server does not compile with libevent 2.0.21-stable

2015-05-06 Thread Konrad Grochowski (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531174#comment-14531174 ] Konrad Grochowski commented on THRIFT-2000: --- It can be reproduced on Linux if

[jira] [Commented] (THRIFT-2000) TNonblocking server does not compile with libevent 2.0.21-stable

2015-05-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531180#comment-14531180 ] James E. King, III commented on THRIFT-2000: I found that with the cmake

[jira] [Commented] (THRIFT-3083) C++ Consolidate server processing loops in TSimpleServer, TThreadedServer, TThreadPoolServer

2015-05-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530967#comment-14530967 ] James E. King, III commented on THRIFT-3083: Investigating whether these

[GitHub] thrift pull request: THRIFT-2474 complete the ntohll precompile co...

2015-05-06 Thread jeking3
GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/482 THRIFT-2474 complete the ntohll precompile conditionals You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift

[GitHub] thrift pull request: THRIFT-2474 complete the ntohll precompile co...

2015-05-06 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/482 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-2474) thrift.h causes a compile failure

2015-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530932#comment-14530932 ] ASF GitHub Bot commented on THRIFT-2474: Github user jeking3 closed the pull

[jira] [Commented] (THRIFT-2474) thrift.h causes a compile failure

2015-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530933#comment-14530933 ] ASF GitHub Bot commented on THRIFT-2474: GitHub user jeking3 reopened a pull

[jira] [Commented] (THRIFT-2994) Node.js TJSONProtocol cannot be used for object serialization.

2015-05-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531813#comment-14531813 ] James E. King, III commented on THRIFT-2994: THRIFT-2994: Fix TJsonProtocol

[jira] [Commented] (THRIFT-2877) Optimize generated hashCode

2015-05-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531828#comment-14531828 ] James E. King, III commented on THRIFT-2877: This passed CI 11 days ago.

[jira] [Comment Edited] (THRIFT-3130) Remove the last vestiges of THRIFT_OVERLOAD_IF from THRIFT-1316

2015-05-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531807#comment-14531807 ] James E. King, III edited comment on THRIFT-3130 at 5/7/15 1:27 AM:

[GitHub] thrift pull request: THRIFT-2835 Add possibility to distribute gen...

2015-05-06 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/368#issuecomment-99664082 Lots of work in here! You might want to close and re-open this pull request to kick a new build. It needs to pass CI before anyone can merge it. --- If your project

[jira] [Commented] (THRIFT-2835) Add possibility to distribute generators separately from thrift core, and load them dynamically

2015-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531817#comment-14531817 ] ASF GitHub Bot commented on THRIFT-2835: Github user jeking3 commented on the

[jira] [Commented] (THRIFT-3130) Remove the last vestiges of THRIFT_OVERLOAD_IF from THRIFT-1316

2015-05-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531807#comment-14531807 ] James E. King, III commented on THRIFT-3130: Well, this compiled clean:

[jira] [Commented] (THRIFT-3121) Librt does not exist on OS X

2015-05-06 Thread Thomas Bartelmess (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530701#comment-14530701 ] Thomas Bartelmess commented on THRIFT-3121: --- You are right. I forgot about

[jira] [Commented] (THRIFT-3121) Librt does not exist on OS X

2015-05-06 Thread Thomas Bartelmess (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530706#comment-14530706 ] Thomas Bartelmess commented on THRIFT-3121: ---

[jira] [Commented] (THRIFT-3121) Librt does not exist on OS X

2015-05-06 Thread Thomas Bartelmess (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530707#comment-14530707 ] Thomas Bartelmess commented on THRIFT-3121: ---

[jira] [Commented] (THRIFT-3121) Librt does not exist on OS X

2015-05-06 Thread Thomas Bartelmess (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530705#comment-14530705 ] Thomas Bartelmess commented on THRIFT-3121: ---

[jira] [Issue Comment Deleted] (THRIFT-3121) Librt does not exist on OS X

2015-05-06 Thread Thomas Bartelmess (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Bartelmess updated THRIFT-3121: -- Comment: was deleted (was: http://docs.travis-ci.com/user/multi-os/ They have a multi

[jira] [Comment Edited] (THRIFT-3121) Librt does not exist on OS X

2015-05-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530672#comment-14530672 ] James E. King, III edited comment on THRIFT-3121 at 5/6/15 3:32 PM:

[jira] [Commented] (THRIFT-3121) Librt does not exist on OS X

2015-05-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530677#comment-14530677 ] James E. King, III commented on THRIFT-3121: Also this points out that the

[jira] [Commented] (THRIFT-3121) Librt does not exist on OS X

2015-05-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530672#comment-14530672 ] James E. King, III commented on THRIFT-3121: I added these tests, so I

[jira] [Updated] (THRIFT-3128) Go generated code produces name collisions between services

2015-05-06 Thread Adam Beberg (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Beberg updated THRIFT-3128: Affects Version/s: (was: 0.9.3) 0.9.2 Go generated code produces name

[jira] [Commented] (THRIFT-2188) allow java servers to bind to a random port, and get that port back out of the transport

2015-05-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531997#comment-14531997 ] James E. King, III commented on THRIFT-2188: Probably worth checking if this

[jira] [Commented] (THRIFT-1944) Binding to zero port

2015-05-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531992#comment-14531992 ] James E. King, III commented on THRIFT-1944: This appears to have been fixed

[jira] [Updated] (THRIFT-3128) Go generated code produces name collisions between services

2015-05-06 Thread Adam Beberg (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Beberg updated THRIFT-3128: Fix Version/s: (was: 0.9.3) Go generated code produces name collisions between services

[jira] [Commented] (THRIFT-3130) Remove the last vestiges of THRIFT_OVERLOAD_IF from THRIFT-1316

2015-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14532000#comment-14532000 ] ASF GitHub Bot commented on THRIFT-3130: Github user jeking3 commented on the

[GitHub] thrift pull request: THRIFT-3130 finish removal of THRIFT_OVERLOAD...

2015-05-06 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/483#issuecomment-99718040 I made some small changes to the TServerIntegrationTest to support testing THRIFT-1944 and rebased the fixup so there's still only one commit tag. The resulting build

[GitHub] thrift pull request: THRIFT-3130 finish removal of THRIFT_OVERLOAD...

2015-05-06 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/483 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3130) Remove the last vestiges of THRIFT_OVERLOAD_IF from THRIFT-1316

2015-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531998#comment-14531998 ] ASF GitHub Bot commented on THRIFT-3130: Github user jeking3 closed the pull

[jira] [Commented] (THRIFT-3130) Remove the last vestiges of THRIFT_OVERLOAD_IF from THRIFT-1316

2015-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531999#comment-14531999 ] ASF GitHub Bot commented on THRIFT-3130: GitHub user jeking3 reopened a pull

[GitHub] thrift pull request: THRIFT-3130 finish removal of THRIFT_OVERLOAD...

2015-05-06 Thread jeking3
GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/483 THRIFT-3130 finish removal of THRIFT_OVERLOAD_IF Testing proved it was unnecessary. You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (THRIFT-3121) Librt does not exist on OS X

2015-05-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530773#comment-14530773 ] James E. King, III commented on THRIFT-3121: I think that you can use if