[jira] [Commented] (THRIFT-4474) PHP generator use PSR-4 default

[ https://issues.apache.org/jira/browse/THRIFT-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397994#comment-16397994 ] ASF GitHub Bot commented on THRIFT-4474: Github user RobberPhex commented on a diff in the pull

[GitHub] thrift pull request #1479: THRIFT-4474: generate PHP code use PSR-4 style de...

Github user RobberPhex commented on a diff in the pull request: https://github.com/apache/thrift/pull/1479#discussion_r174337789 --- Diff: lib/php/README.md --- @@ -20,34 +19,46 @@ KIND, either express or implied. See the License for the specific language governing permissions

[jira] [Commented] (THRIFT-4382) Replace the use of Perl Indirect Object Syntax calls to new()

[ https://issues.apache.org/jira/browse/THRIFT-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397877#comment-16397877 ] ASF GitHub Bot commented on THRIFT-4382: Github user djzort commented on the issue:

[GitHub] thrift issue #1261: THRIFT-4382: Replace the use of Indirect Object Syntax c...

Github user djzort commented on the issue: https://github.com/apache/thrift/pull/1261 it's still on my TODO list, but is very low. I will get to it sooner or later. ---

[jira] [Commented] (THRIFT-4513) thrift generated java code is not stable for constants

[ https://issues.apache.org/jira/browse/THRIFT-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397815#comment-16397815 ] ASF GitHub Bot commented on THRIFT-4513: Github user romanoid commented on the issue:

[GitHub] thrift issue #1505: THRIFT-4513: Fixing java thrift compiler to generate con...

Github user romanoid commented on the issue: https://github.com/apache/thrift/pull/1505 Fix is in, the only failure left is this one, I'm not sure if it is instability of tests or real problem: https://travis-ci.org/apache/thrift/jobs/353050154 ---

[GitHub] thrift issue #1474: Recognize fbthrift TApplicationException codes

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1474 @jfarrell can you please give a final say on this? ---

[jira] [Commented] (THRIFT-4513) thrift generated java code is not stable for constants

[ https://issues.apache.org/jira/browse/THRIFT-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397404#comment-16397404 ] ASF GitHub Bot commented on THRIFT-4513: Github user romanoid commented on the issue:

[GitHub] thrift issue #1505: THRIFT-4513: Fixing java thrift compiler to generate con...

Github user romanoid commented on the issue: https://github.com/apache/thrift/pull/1505 @jeking3 done, thanks, let's see if it passes. ---

[jira] [Updated] (THRIFT-4461) Compiler directive should match Delphi XE4

[ https://issues.apache.org/jira/browse/THRIFT-4461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anton Shchyrov updated THRIFT-4461: --- Description: In module Thrift.Utils daclared two methods   {code:java} class function

[jira] [Updated] (THRIFT-4462) First line in Console duplicated

[ https://issues.apache.org/jira/browse/THRIFT-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anton Shchyrov updated THRIFT-4462: --- Description: Method Console.Write/WriteLine in class TGUIConsole after called method *Write*

[jira] [Updated] (THRIFT-4467) Add methods WriteFmt/WriteLineFmt to TThriftConsole class

[ https://issues.apache.org/jira/browse/THRIFT-4467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anton Shchyrov updated THRIFT-4467: --- Description: For ease of use, add methods   {code:java} procedure

[jira] [Updated] (THRIFT-4468) Make the class TGUIConsole thread-safe

[ https://issues.apache.org/jira/browse/THRIFT-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anton Shchyrov updated THRIFT-4468: --- Description: In Delphi all methods that refer to VCL should do it only from main thread. But

[jira] [Updated] (THRIFT-4481) TBinaryProtocol.writeMessageEnd isn't trowable exception

[ https://issues.apache.org/jira/browse/THRIFT-4481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anton Shchyrov updated THRIFT-4481: --- Description: In base class TProtocol method writeMessageEnd can throw exception TException

[jira] [Updated] (THRIFT-4518) The exception text disappears

[ https://issues.apache.org/jira/browse/THRIFT-4518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anton Shchyrov updated THRIFT-4518: --- Description: When the server method throws an exception TException, only the string 

[jira] [Updated] (THRIFT-4518) The exception text disappears

[ https://issues.apache.org/jira/browse/THRIFT-4518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anton Shchyrov updated THRIFT-4518: --- Description: When the server method throws an exception TException, only the string 

[jira] [Commented] (THRIFT-4429) Make TThreadPoolServer.executorService_ available in inherited classes and refactor methods to be able customization

[ https://issues.apache.org/jira/browse/THRIFT-4429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397369#comment-16397369 ] ASF GitHub Bot commented on THRIFT-4429: Github user asfgit closed the pull request at:

[jira] [Resolved] (THRIFT-4429) Make TThreadPoolServer.executorService_ available in inherited classes and refactor methods to be able customization

[ https://issues.apache.org/jira/browse/THRIFT-4429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4429. Resolution: Fixed Fix Version/s: 0.12.0 Committed - thanks. > Make

[jira] [Assigned] (THRIFT-4429) Make TThreadPoolServer.executorService_ available in inherited classes and refactor methods to be able customization

[ https://issues.apache.org/jira/browse/THRIFT-4429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4429: -- Assignee: James E. King, III > Make TThreadPoolServer.executorService_

[GitHub] thrift pull request #1485: THRIFT-4429: Make TThreadPoolServer.executorServi...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1485 ---

[jira] [Commented] (THRIFT-4429) Make TThreadPoolServer.executorService_ available in inherited classes and refactor methods to be able customization

[ https://issues.apache.org/jira/browse/THRIFT-4429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397365#comment-16397365 ] ASF GitHub Bot commented on THRIFT-4429: Github user dmvolod commented on the issue:

[GitHub] thrift issue #1485: THRIFT-4429: Make TThreadPoolServer.executorService_ ava...

Github user dmvolod commented on the issue: https://github.com/apache/thrift/pull/1485 Thanks a lot for review. ---

[GitHub] thrift issue #1480: [nodejs] Fix issue with connection failures silently fai...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1480 @bananer apart from missing any testing, is this a reasonable enhancement? ---

[jira] [Created] (THRIFT-4518) The exception text disappears

Anton Shchyrov created THRIFT-4518: -- Summary: The exception text disappears Key: THRIFT-4518 URL: https://issues.apache.org/jira/browse/THRIFT-4518 Project: Thrift Issue Type: Bug

[jira] [Commented] (THRIFT-4187) Dart -> Rust Framed cross tests fail

[ https://issues.apache.org/jira/browse/THRIFT-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397190#comment-16397190 ] ASF GitHub Bot commented on THRIFT-4187: Github user allengeorge commented on the issue:

[GitHub] thrift issue #1269: THRIFT-4187 Allow dart framed transport to read incomple...

Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1269 Yup. Will do. I'm a gonna set myself a target to get it done by end of next week. I've been lax on this :/ ---

[GitHub] thrift issue #1058: Node.js: Set/unset client seqid for json_protocol and co...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1058 In general I want to make sure all clients send a seqid and all servers put that seqid in the result. Without this we won't be able to have clients that can have multiple outstanding requests in

[GitHub] thrift issue #1058: Node.js: Set/unset client seqid for json_protocol and co...

Github user bananer commented on the issue: https://github.com/apache/thrift/pull/1058 @jeking3 To be honest, I don't know why this is useful/necessary. I think there is no need for a seqid because the connection between request and response is handled through callbacks

[GitHub] thrift pull request #1479: THRIFT-4474: generate PHP code use PSR-4 style de...

Github user dcelasun commented on a diff in the pull request: https://github.com/apache/thrift/pull/1479#discussion_r174183088 --- Diff: lib/php/README.md --- @@ -20,34 +19,46 @@ KIND, either express or implied. See the License for the specific language governing permissions

[jira] [Commented] (THRIFT-4474) PHP generator use PSR-4 default

[ https://issues.apache.org/jira/browse/THRIFT-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397141#comment-16397141 ] ASF GitHub Bot commented on THRIFT-4474: Github user dcelasun commented on a diff in the pull

[GitHub] thrift pull request #1479: THRIFT-4474: generate PHP code use PSR-4 style de...

Github user dcelasun commented on a diff in the pull request: https://github.com/apache/thrift/pull/1479#discussion_r174183533 --- Diff: lib/php/README.md --- @@ -20,34 +19,46 @@ KIND, either express or implied. See the License for the specific language governing permissions

[jira] [Commented] (THRIFT-4474) PHP generator use PSR-4 default

[ https://issues.apache.org/jira/browse/THRIFT-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397140#comment-16397140 ] ASF GitHub Bot commented on THRIFT-4474: Github user dcelasun commented on a diff in the pull

[jira] [Commented] (THRIFT-4474) PHP generator use PSR-4 default

[ https://issues.apache.org/jira/browse/THRIFT-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397139#comment-16397139 ] ASF GitHub Bot commented on THRIFT-4474: Github user dcelasun commented on the issue:

[GitHub] thrift issue #1479: THRIFT-4474: generate PHP code use PSR-4 style default

Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1479 Added some doc comments. The actual code looks fine to me. ---

[jira] [Updated] (THRIFT-4509) js and nodejs libraries need to be refreshed with current libraries

[ https://issues.apache.org/jira/browse/THRIFT-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4509: --- Component/s: (was: Node.js - Library) > js and nodejs libraries need to be

[jira] [Resolved] (THRIFT-4509) js and nodejs libraries need to be refreshed with current libraries

[ https://issues.apache.org/jira/browse/THRIFT-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4509. Resolution: Fixed Assignee: James E. King, III Fix Version/s:

[jira] [Commented] (THRIFT-4187) Dart -> Rust Framed cross tests fail

[ https://issues.apache.org/jira/browse/THRIFT-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397134#comment-16397134 ] ASF GitHub Bot commented on THRIFT-4187: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1269: THRIFT-4187 Allow dart framed transport to read incomple...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1269 This needs to be rebased and completed. ---

[jira] [Commented] (THRIFT-4509) js and nodejs libraries need to be refreshed with current libraries

[ https://issues.apache.org/jira/browse/THRIFT-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397132#comment-16397132 ] ASF GitHub Bot commented on THRIFT-4509: Github user bananer commented on the issue:

[GitHub] thrift issue #1506: THRIFT-4509: grunt update (rebased)

Github user bananer commented on the issue: https://github.com/apache/thrift/pull/1506 @jeking3 I think all the problems mentioned in THRIFT-4509 are resolved now. With the package-lock being included now, there should also be less random build failures. The node and js parts of

[GitHub] thrift issue #1141: support for timeout in node http connection

Github user bananer commented on the issue: https://github.com/apache/thrift/pull/1141 @jeking3 it looks like a simple change now that support for node 4 can be dropped. However, I'm not sure what the expected behaviour in case of a timeout should be. Just from looking at the code it

[jira] [Commented] (THRIFT-3916) Errors thrown from JavaScript client is strings and not errors

[ https://issues.apache.org/jira/browse/THRIFT-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397108#comment-16397108 ] ASF GitHub Bot commented on THRIFT-3916: Github user bananer commented on the issue:

[GitHub] thrift issue #1075: THRIFT-3916 Throw proper errors from JS, not strings

Github user bananer commented on the issue: https://github.com/apache/thrift/pull/1075 @jeking3 This is a well-intended change but I think it is not implemented correctly and will break error handling for users. In some places in the compiler the input to `render_recv_throw`

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397065#comment-16397065 ] ASF GitHub Bot commented on THRIFT-4476: Github user ozymaxx commented on the issue:

[GitHub] thrift issue #1496: THRIFT-4476: Typecasting problem on list items (+ low pr...

Github user ozymaxx commented on the issue: https://github.com/apache/thrift/pull/1496 I have just disabled my new tests on `MSVC2013` builders and kicked a build. Let's see what happens. If the tests also fail on the `CYGWIN` machine, I will also write out new tests for the x86

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397049#comment-16397049 ] ASF GitHub Bot commented on THRIFT-4476: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1496: THRIFT-4476: Typecasting problem on list items (+ low pr...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1496 I put the MSVC2013 job back in to make sure we had some backwards compatibility... glad I did. I wonder if we have 32-bit issues with double in general in thrift? ---

[jira] [Updated] (THRIFT-3458) Register thrift in D package registry

[ https://issues.apache.org/jira/browse/THRIFT-3458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3458: --- Description: add dub.sdl or dub.json and register it at code.dlang.org  #723 has

[jira] [Commented] (THRIFT-3458) Register thrift in D package registry

[ https://issues.apache.org/jira/browse/THRIFT-3458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397021#comment-16397021 ] ASF GitHub Bot commented on THRIFT-3458: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1380: Support x64 build mode on Windows with DMD v2.076.0.

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1380 THRIFT-3458 is also related, and the approach in THRIFT-3458 would allow us to add the apache git repo to dub directly so we should move in that direction, but still try to use dub to build in

[jira] [Resolved] (THRIFT-4504) Use dlang native build and package manager (dub) for builds

[ https://issues.apache.org/jira/browse/THRIFT-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4504. Resolution: Duplicate Assignee: James E. King, III Resolving as a dupe of

[jira] [Assigned] (THRIFT-3458) Register thrift in D package registry

[ https://issues.apache.org/jira/browse/THRIFT-3458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-3458: -- Assignee: James E. King, III (was: Jake Farrell) > Register thrift in D

[jira] [Closed] (THRIFT-4504) Use dlang native build and package manager (dub) for builds

[ https://issues.apache.org/jira/browse/THRIFT-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III closed THRIFT-4504. -- > Use dlang native build and package manager (dub) for builds >

[jira] [Commented] (THRIFT-4504) Use dlang native build and package manager (dub) for builds

[ https://issues.apache.org/jira/browse/THRIFT-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397019#comment-16397019 ] James E. King, III commented on THRIFT-4504: I think the approach in

[jira] [Commented] (THRIFT-4431) Repetitive use of HTTPClientTransport causes "Errno::EMFILE: Failed to open TCP connection"

[ https://issues.apache.org/jira/browse/THRIFT-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397013#comment-16397013 ] ASF GitHub Bot commented on THRIFT-4431: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1447: THRIFT-4431 Ruby library: Finish http connection after f...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1447 @lompy will you be able to carry this forward? ---

[jira] [Commented] (THRIFT-4474) PHP generator use PSR-4 default

[ https://issues.apache.org/jira/browse/THRIFT-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397011#comment-16397011 ] ASF GitHub Bot commented on THRIFT-4474: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1479: THRIFT-4474: generate PHP code use PSR-4 style default

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1479 Any other php folks out there want to comment or review on the breaking change here? It looks like the strategy was to change the generator and provide a flag to allow folks to generate older

[jira] [Commented] (THRIFT-4382) Replace the use of Perl Indirect Object Syntax calls to new()

[ https://issues.apache.org/jira/browse/THRIFT-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397001#comment-16397001 ] ASF GitHub Bot commented on THRIFT-4382: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1261: THRIFT-4382: Replace the use of Indirect Object Syntax c...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1261 If you are able to finish this up and do the tutorial code, or if you are not able to complete this, please let me know. ---

[GitHub] thrift issue #1141: support for timeout in node http connection

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1141 @bananer this would be a good candidate to pick up and run with. ---

[jira] [Commented] (THRIFT-4509) js and nodejs libraries need to be refreshed with current libraries

[ https://issues.apache.org/jira/browse/THRIFT-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396996#comment-16396996 ] ASF GitHub Bot commented on THRIFT-4509: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-3916) Errors thrown from JavaScript client is strings and not errors

[ https://issues.apache.org/jira/browse/THRIFT-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396995#comment-16396995 ] ASF GitHub Bot commented on THRIFT-3916: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1058: Node.js: Set/unset client seqid for json_protocol and co...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1058 @bananer is this worth pulling forward if it passes a build? ---

[GitHub] thrift issue #1075: THRIFT-3916 Throw proper errors from JS, not strings

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1075 @bananer is this worth pulling forward if it passes a build? Is it a breaking change? ---

[GitHub] thrift issue #1506: THRIFT-4509: grunt update (rebased)

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1506 With this merged would you say that THRIFT-4509 is now fixed, or is there more work to do? ---

[jira] [Commented] (THRIFT-4509) js and nodejs libraries need to be refreshed with current libraries

[ https://issues.apache.org/jira/browse/THRIFT-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396992#comment-16396992 ] ASF GitHub Bot commented on THRIFT-4509: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1506: THRIFT-4509: grunt update (rebased)

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1506 ---

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396631#comment-16396631 ] ASF GitHub Bot commented on THRIFT-4476: Github user ozymaxx closed the pull request at:

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

Github user ozymaxx closed the pull request at: https://github.com/apache/thrift/pull/1496 ---

[GitHub] thrift issue #1496: THRIFT-4476: Typecasting problem on list items (+ low pr...

Github user ozymaxx commented on the issue: https://github.com/apache/thrift/pull/1496 The AppVeyor builder with the `MSVC2013` configuration generates large double constants differently as the old `MSVC2010` configuration used to do. So I will add a condition to not do the

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396630#comment-16396630 ] ASF GitHub Bot commented on THRIFT-4476: Github user ozymaxx commented on the issue: