[jira] [Created] (THRIFT-4524) .NET Core Server doesn't close properly when cancelled

Stephen Starkie created THRIFT-4524: --- Summary: .NET Core Server doesn't close properly when cancelled Key: THRIFT-4524 URL: https://issues.apache.org/jira/browse/THRIFT-4524 Project: Thrift

[GitHub] thrift pull request #1510: THRIFT-4476: Typecasting problem on floating-poin...

GitHub user ozymaxx opened a pull request: https://github.com/apache/thrift/pull/1510 THRIFT-4476: Typecasting problem on floating-point list items, emitting doubles with high precision in Python, JS, Java, C++ and Erlang Squashed version see the related issue:

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406199#comment-16406199 ] ASF GitHub Bot commented on THRIFT-4476: GitHub user ozymaxx opened a pull request:

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

Github user ozymaxx closed the pull request at: https://github.com/apache/thrift/pull/1496 ---

[GitHub] thrift issue #744: update TSocket.php

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/744 @lihanharry please move this forward or it will eventually be closed due to inactivity. @RobberPhex any concerns with this code? ---

[GitHub] thrift pull request #1511: THRIFT-4476: Typecasting problem on double list i...

GitHub user ozymaxx opened a pull request: https://github.com/apache/thrift/pull/1511 THRIFT-4476: Typecasting problem on double list items, emitting doubles with high precision (for Java, C++, Python, JS and Erlang) All commits have been squashed into one see the related

[jira] [Updated] (THRIFT-4514) Remove pthread library support and use std::thread or boost::thread

[ https://issues.apache.org/jira/browse/THRIFT-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4514: --- Description: We have a pretty awful thread class implementation: 1. The build

[jira] [Commented] (THRIFT-4524) .NET Core Server doesn't close properly when cancelled

[ https://issues.apache.org/jira/browse/THRIFT-4524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406330#comment-16406330 ] ASF GitHub Bot commented on THRIFT-4524: GitHub user stephenstarkie opened a pull request:

[GitHub] thrift issue #1269: THRIFT-4187 Allow dart framed transport to read incomple...

Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1269 @jeking3 Any chance this could be merged? TY! ---

[GitHub] thrift issue #1269: THRIFT-4187 Allow dart framed transport to read incomple...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1269 I'd suggest waiting to see how the CI build fares given a change was made. So today is a distinct possibility. Also, you can commit your own changes. There's no rule against it. :) ---

[jira] [Commented] (THRIFT-2790) thrift -gen all => an option to generate all languages and features

[ https://issues.apache.org/jira/browse/THRIFT-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406226#comment-16406226 ] ASF GitHub Bot commented on THRIFT-2790: Github user jeking3 commented on the issue:

[GitHub] thrift issue #798: THRIFT-3560: C++: declared TTransport::isOpen() and TTran...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/798 I am okay making this change for 0.12.0; if you can rebase, squash, and fix up the issues and force push, and if there are any other methods that need the same const correctness, let's do those too.

[jira] [Commented] (THRIFT-3560) C++ TTransport::isOpen() and TTransport::getOrigin() should be const member functions

[ https://issues.apache.org/jira/browse/THRIFT-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406228#comment-16406228 ] ASF GitHub Bot commented on THRIFT-3560: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406232#comment-16406232 ] ASF GitHub Bot commented on THRIFT-4476: GitHub user ozymaxx opened a pull request:

[GitHub] thrift issue #1084: THRIFT-3773 Swift 3 Native Library

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1084 Okay, so I could merge this, but I need to know (since I've never used cocoa, swift, or any of the apple stuff really): * Are there breaking changes? * Are they documented? * Is it

[jira] [Commented] (THRIFT-3773) Swift Library

[ https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406239#comment-16406239 ] ASF GitHub Bot commented on THRIFT-3773: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-4187) Dart -> Rust Framed cross tests fail

[ https://issues.apache.org/jira/browse/THRIFT-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406194#comment-16406194 ] ASF GitHub Bot commented on THRIFT-4187: Github user allengeorge commented on the issue:

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406218#comment-16406218 ] ASF GitHub Bot commented on THRIFT-4476: Github user ozymaxx commented on the issue:

[GitHub] thrift issue #1510: THRIFT-4476: Typecasting problem on floating-point list ...

Github user ozymaxx commented on the issue: https://github.com/apache/thrift/pull/1510 @jeking3 I squashed all into one commit and opened another branch (I had some problems while changing the history) ---

[GitHub] thrift pull request #1510: THRIFT-4476: Typecasting problem on floating-poin...

Github user ozymaxx closed the pull request at: https://github.com/apache/thrift/pull/1510 ---

[jira] [Commented] (THRIFT-4187) Dart -> Rust Framed cross tests fail

[ https://issues.apache.org/jira/browse/THRIFT-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406222#comment-16406222 ] ASF GitHub Bot commented on THRIFT-4187: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406223#comment-16406223 ] ASF GitHub Bot commented on THRIFT-4476: Github user ozymaxx closed the pull request at:

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406247#comment-16406247 ] ASF GitHub Bot commented on THRIFT-4476: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1511: THRIFT-4476: Typecasting problem on double list items, e...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1511 Thanks for the squash. We'll get this merged. ---

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406200#comment-16406200 ] ASF GitHub Bot commented on THRIFT-4476: Github user ozymaxx closed the pull request at:

[GitHub] thrift issue #782: THRIFT-2790 thrift -gen all => an option to generate all ...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/782 Should this be moved forward or closed? ---

[GitHub] thrift issue #972: THRIFT-3770 Implement Python 3.4+ asyncio support

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/972 @jfarrell please close this; the author indicated no interest in finishing the work due to the team's past inaction on pull request management. ---

[jira] [Commented] (THRIFT-3770) Support Python 3.4+ asyncio support

[ https://issues.apache.org/jira/browse/THRIFT-3770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406229#comment-16406229 ] ASF GitHub Bot commented on THRIFT-3770: Github user jeking3 commented on the issue:

[GitHub] thrift pull request #1512: Fix for THRIFT-4524

GitHub user stephenstarkie opened a pull request: https://github.com/apache/thrift/pull/1512 Fix for THRIFT-4524 Also fixed up the project files to include quoted Program Files paths You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (THRIFT-4489) Unix domain socket support for NodeJS client

[ https://issues.apache.org/jira/browse/THRIFT-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406394#comment-16406394 ] ASF GitHub Bot commented on THRIFT-4489: Github user danielhtshih commented on the issue:

[GitHub] thrift issue #1491: THRIFT-4489: Add UDS support for nodejs thrift client

Github user danielhtshih commented on the issue: https://github.com/apache/thrift/pull/1491 @jeking3 please use this single commit https://github.com/apache/thrift/pull/1491/commits/041f91dd6042b98c5bbd0846f5e6ed7fb6fd4bf1 Thanks. ---

[GitHub] thrift issue #1269: THRIFT-4187 Allow dart framed transport to read incomple...

Github user markerickson-wf commented on the issue: https://github.com/apache/thrift/pull/1269 +1 ---

[jira] [Commented] (THRIFT-4187) Dart -> Rust Framed cross tests fail

[ https://issues.apache.org/jira/browse/THRIFT-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406569#comment-16406569 ] ASF GitHub Bot commented on THRIFT-4187: Github user markerickson-wf commented on the issue:

[GitHub] thrift pull request #1513: THRIFT-4358: add unix domain socket option to rub...

GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1513 THRIFT-4358: add unix domain socket option to ruby cross tests This is the first time I've tried to use ruby with any seriousness. I like the unit test framework (rspec) - very descriptive

[jira] [Commented] (THRIFT-4358) Add unix domain sockets in ruby to cross test - code exists

[ https://issues.apache.org/jira/browse/THRIFT-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406879#comment-16406879 ] ASF GitHub Bot commented on THRIFT-4358: GitHub user jeking3 opened a pull request:

[jira] [Resolved] (THRIFT-4524) .NET Core Server doesn't close properly when cancelled

[ https://issues.apache.org/jira/browse/THRIFT-4524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4524. Resolution: Fixed Fix Version/s: 0.12.0 > .NET Core Server doesn't close

[GitHub] thrift pull request #1512: Fix for THRIFT-4524

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1512 ---

[jira] [Commented] (THRIFT-4524) .NET Core Server doesn't close properly when cancelled

[ https://issues.apache.org/jira/browse/THRIFT-4524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406974#comment-16406974 ] ASF GitHub Bot commented on THRIFT-4524: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-4187) Dart -> Rust Framed cross tests fail

[ https://issues.apache.org/jira/browse/THRIFT-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406949#comment-16406949 ] ASF GitHub Bot commented on THRIFT-4187: Github user allengeorge commented on the issue:

[GitHub] thrift issue #1269: THRIFT-4187 Allow dart framed transport to read incomple...

Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1269 No problem! I'm sorry I was lax and left it so long :/ Looks like the tests passed, so it's good to merge. Not 100% of the process, so I'll follow up via email. ---

[jira] [Resolved] (THRIFT-4187) Dart -> Rust Framed cross tests fail

[ https://issues.apache.org/jira/browse/THRIFT-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-4187. -- Resolution: Fixed Fix Version/s: 0.12.0 Fixed as of

[jira] [Resolved] (THRIFT-4476) Typecasting problem on list items

[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4476. Resolution: Fixed Assignee: James E. King, III Fix Version/s:

[GitHub] thrift issue #1269: THRIFT-4187 Allow dart framed transport to read incomple...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1269 Remember to resolve https://issues.apache.org/jira/browse/THRIFT-4187 as fixed in 0.12.0. ---

[jira] [Commented] (THRIFT-4187) Dart -> Rust Framed cross tests fail

[ https://issues.apache.org/jira/browse/THRIFT-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406962#comment-16406962 ] ASF GitHub Bot commented on THRIFT-4187: Github user jeking3 commented on the issue:

[jira] [Created] (THRIFT-4526) Implement rubocop for ruby in the sca build, once clean into every make

James E. King, III created THRIFT-4526: -- Summary: Implement rubocop for ruby in the sca build, once clean into every make Key: THRIFT-4526 URL: https://issues.apache.org/jira/browse/THRIFT-4526

[GitHub] thrift issue #1269: THRIFT-4187 Allow dart framed transport to read incomple...

Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1269 @jeking3 Yup - just did that. Is there a way to do it automatically, or is it a manual process (for now)? ---

[jira] [Assigned] (THRIFT-4524) .NET Core Server doesn't close properly when cancelled

[ https://issues.apache.org/jira/browse/THRIFT-4524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4524: -- Assignee: James E. King, III > .NET Core Server doesn't close properly when

[jira] [Updated] (THRIFT-4476) Typecasting problem on list items

[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4476: --- Component/s: Python - Compiler JavaScript - Compiler

[jira] [Commented] (THRIFT-4187) Dart -> Rust Framed cross tests fail

[ https://issues.apache.org/jira/browse/THRIFT-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406968#comment-16406968 ] ASF GitHub Bot commented on THRIFT-4187: Github user allengeorge commented on the issue:

[GitHub] thrift pull request #1269: THRIFT-4187 Allow dart framed transport to read i...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1269 ---

[GitHub] thrift pull request #1511: THRIFT-4476: Typecasting problem on double list i...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1511 ---

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406959#comment-16406959 ] ASF GitHub Bot commented on THRIFT-4476: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1514: THRIFT-4525: add ruby cross test ssl support

GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1514 THRIFT-4525: add ruby cross test ssl support You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift THRIFT-4525 Alternatively you can

[jira] [Commented] (THRIFT-4525) Add ssl socket option to ruby cross tests

[ https://issues.apache.org/jira/browse/THRIFT-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407462#comment-16407462 ] ASF GitHub Bot commented on THRIFT-4525: GitHub user jeking3 opened a pull request:

[GitHub] thrift issue #1491: THRIFT-4489: Add UDS support for nodejs thrift client

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1491 Looks good, will merge in the morning. ---

[jira] [Commented] (THRIFT-4489) Unix domain socket support for NodeJS client

[ https://issues.apache.org/jira/browse/THRIFT-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407465#comment-16407465 ] ASF GitHub Bot commented on THRIFT-4489: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-4358) Add unix domain sockets in ruby to cross test - code exists

[ https://issues.apache.org/jira/browse/THRIFT-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407461#comment-16407461 ] ASF GitHub Bot commented on THRIFT-4358: Github user asfgit closed the pull request at:

[GitHub] thrift issue #1491: THRIFT-4489: Add UDS support for nodejs thrift client

Github user danielhtshih commented on the issue: https://github.com/apache/thrift/pull/1491 @jeking3 here is the single commit https://github.com/danielhtshih/thrift/commit/9c560daf52fcd89c212451f0793973af17f6cc55 from THRIFT-4489-squashed Thanks. ---

[jira] [Commented] (THRIFT-4489) Unix domain socket support for NodeJS client

[ https://issues.apache.org/jira/browse/THRIFT-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407279#comment-16407279 ] ASF GitHub Bot commented on THRIFT-4489: Github user danielhtshih commented on the issue:

[GitHub] thrift pull request #1513: THRIFT-4358: add unix domain socket option to rub...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1513 ---

[jira] [Commented] (THRIFT-4524) .NET Core Server doesn't close properly when cancelled

[ https://issues.apache.org/jira/browse/THRIFT-4524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406783#comment-16406783 ] ASF GitHub Bot commented on THRIFT-4524: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1512: Fix for THRIFT-4524

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1512 Build failures appear unrelated to the change. ---

[jira] [Created] (THRIFT-4525) Add ssl socket option to ruby cross tests

James E. King, III created THRIFT-4525: -- Summary: Add ssl socket option to ruby cross tests Key: THRIFT-4525 URL: https://issues.apache.org/jira/browse/THRIFT-4525 Project: Thrift Issue

[GitHub] thrift issue #1491: THRIFT-4489: Add UDS support for nodejs thrift client

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1491 This squash was not done properly. It includes all of the master commits in it. You want to start with an updated master: git checkout master git pull Then you want

[jira] [Commented] (THRIFT-4489) Unix domain socket support for NodeJS client

[ https://issues.apache.org/jira/browse/THRIFT-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406890#comment-16406890 ] ASF GitHub Bot commented on THRIFT-4489: Github user jeking3 commented on the issue: