[
https://issues.apache.org/jira/browse/THRIFT-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018123#comment-15018123
]
Carl Hall commented on THRIFT-2143:
---
Hi [~jensg], IIRC I added {{::Thrift::Types::ENUM}} to know when
GitHub user markerickson-wf opened a pull request:
https://github.com/apache/thrift/pull/706
THRIFT-3434 Produce a reasonable name for includes in Dart generator
Use the namespace, if available, then the file name. Previously the Dart
generator was producing an empty string when a
[
https://issues.apache.org/jira/browse/THRIFT-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018325#comment-15018325
]
ASF GitHub Bot commented on THRIFT-3434:
GitHub user markerickson-wf opened a pull request:
[
https://issues.apache.org/jira/browse/THRIFT-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018532#comment-15018532
]
Mark Erickson commented on THRIFT-3351:
---
Since the Dart bindings are merged in, ideally this should
[
https://issues.apache.org/jira/browse/THRIFT-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-3434.
Resolution: Fixed
Fix Version/s: 1.0
LGTM, committed.
> Dart generator produces empty name
[
https://issues.apache.org/jira/browse/THRIFT-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018591#comment-15018591
]
Tom Lippincott commented on THRIFT-3433:
Is this definitely a problem with the Haskell
[
https://issues.apache.org/jira/browse/THRIFT-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018718#comment-15018718
]
ASF GitHub Bot commented on THRIFT-3434:
Github user asfgit closed the pull request at:
Github user cjthompson commented on the pull request:
https://github.com/apache/thrift/pull/707#issuecomment-158525127
Looking at this change, I believe this will break namespacing because the
output will be invalid JavaScript:
javascript
var Namespace.Object.Type =
Github user bracki commented on the pull request:
https://github.com/apache/thrift/pull/707#issuecomment-158531284
@cjthompson Good catch! I haven't tried out using `js` namespaces.
What are they good for anyways? Wouldn't you define your namespace when
requiring the files?
[
https://issues.apache.org/jira/browse/THRIFT-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018790#comment-15018790
]
ASF GitHub Bot commented on THRIFT-1840:
GitHub user bracki opened a pull request:
GitHub user bracki opened a pull request:
https://github.com/apache/thrift/pull/707
Fix generated Node JS code
As reported in https://issues.apache.org/jira/browse/THRIFT-1840 and
https://issues.apache.org/jira/browse/THRIFT-2527 the generated JS code
pollutes the global namespace
Github user thomaslee commented on the pull request:
https://github.com/apache/thrift/pull/705#issuecomment-158567838
The other failure:
```
/home/travis/build/apache/thrift/lib/java/build.xml:148: Failed to copy
[
https://issues.apache.org/jira/browse/THRIFT-3432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15019202#comment-15019202
]
ASF GitHub Bot commented on THRIFT-3432:
Github user thomaslee commented on the pull request:
Tom Lee created THRIFT-3435:
---
Summary: Put generated Java code for fullcamel tests in a separate
package/namespace
Key: THRIFT-3435
URL: https://issues.apache.org/jira/browse/THRIFT-3435
Project: Thrift
[
https://issues.apache.org/jira/browse/THRIFT-3432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15019200#comment-15019200
]
ASF GitHub Bot commented on THRIFT-3432:
Github user thomaslee commented on the pull request:
Github user thomaslee commented on the pull request:
https://github.com/apache/thrift/pull/705#issuecomment-158567751
hm afaict that build failure is unrelated to my change:
https://s3.amazonaws.com/archive.travis-ci.org/jobs/92019024/log.txt
Failure is:
```
GitHub user thomaslee opened a pull request:
https://github.com/apache/thrift/pull/708
THRIFT-3435 Separate package for fullcamel thrift
An annoyance for folks trying to work with Thrift's Java code in an IDE:
the generated fullcamel classes conflict with the non-fullcamel classes.
[
https://issues.apache.org/jira/browse/THRIFT-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15019219#comment-15019219
]
ASF GitHub Bot commented on THRIFT-3435:
GitHub user thomaslee opened a pull request:
[
https://issues.apache.org/jira/browse/THRIFT-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tom Lee updated THRIFT-3435:
Flags: Patch
> Put generated Java code for fullcamel tests in a separate package/namespace
>
[
https://issues.apache.org/jira/browse/THRIFT-3432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tom Lee updated THRIFT-3432:
Flags: Patch
Patch Info: Patch Available
> Add a TByteBuffer transport to the Java library
>
[
https://issues.apache.org/jira/browse/THRIFT-3431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tom Lee updated THRIFT-3431:
Flags: Patch
Patch Info: Patch Available
> Avoid "schemes" HashMap lookups during struct
[
https://issues.apache.org/jira/browse/THRIFT-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tom Lee updated THRIFT-3435:
Patch Info: Patch Available
> Put generated Java code for fullcamel tests in a separate package/namespace
22 matches
Mail list logo
