[
https://issues.apache.org/jira/browse/THRIFT-4366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xiaomingzhongguo updated THRIFT-4366:
-
Summary: upgrade thrift lib to 0.10 ,coredump at readMessageBegin (was:
upgrade to
[
https://issues.apache.org/jira/browse/THRIFT-4366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xiaomingzhongguo updated THRIFT-4366:
-
Priority: Critical (was: Blocker)
> upgrade to 0.10 CPP ,when readMessageBegin coredump
[
https://issues.apache.org/jira/browse/THRIFT-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221465#comment-16221465
]
ASF GitHub Bot commented on THRIFT-4373:
Github user sokac commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221466#comment-16221466
]
ASF GitHub Bot commented on THRIFT-4373:
Github user sokac commented on a diff in the pull
Github user sokac commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1401#discussion_r147295690
--- Diff: lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp ---
@@ -709,6 +715,9 @@ void binary_serialize(int8_t thrift_typeID,
PHPOutputTransport&
Github user sokac commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1401#discussion_r147295660
--- Diff: lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp ---
@@ -699,6 +702,9 @@ void binary_serialize_hashtable_key(int8_t keytype,
[
https://issues.apache.org/jira/browse/THRIFT-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221464#comment-16221464
]
ASF GitHub Bot commented on THRIFT-4373:
Github user sokac commented on a diff in the pull
Github user sokac commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1401#discussion_r147295629
--- Diff: lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp ---
@@ -537,6 +537,9 @@ void binary_deserialize(int8_t thrift_typeID,
PHPInputTransport&
[
https://issues.apache.org/jira/browse/THRIFT-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221324#comment-16221324
]
ASF GitHub Bot commented on THRIFT-4372:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1402
Makes sense, thanks for the info. Every little bit helps us all improve
what we do next.
---
[
https://issues.apache.org/jira/browse/THRIFT-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221023#comment-16221023
]
ASF GitHub Bot commented on THRIFT-4372:
Github user Jens-G commented on the issue:
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1402
> Why not actually use (2^16)-1 which is the limit?
Several reasons. First, aligned memory access is always faster. If we
subtract 1 byte, we get the worst case. Next, at least on Windows a
[
https://issues.apache.org/jira/browse/THRIFT-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-4372.
Resolution: Fixed
Fix Version/s: 0.11.0
Committed.
> Pipe write operations across a
[
https://issues.apache.org/jira/browse/THRIFT-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220978#comment-16220978
]
ASF GitHub Bot commented on THRIFT-4372:
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1402
---
I’m guessing there isn’t a standard release schedule for thrift which is
totally fine, but could something be added to the root README to clarify? Even
something that says “Releases are TBD on an as-needed basis” would be helpful.
[
https://issues.apache.org/jira/browse/THRIFT-4374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220680#comment-16220680
]
ASF GitHub Bot commented on THRIFT-4374:
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1400
---
[
https://issues.apache.org/jira/browse/THRIFT-4374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220681#comment-16220681
]
ASF GitHub Bot commented on THRIFT-4374:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1400
It only works when creating the PR :)
---
[
https://issues.apache.org/jira/browse/THRIFT-4374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220678#comment-16220678
]
ASF GitHub Bot commented on THRIFT-4374:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1400
Please remember to put the Jira THRIFT ticket name into the title of every
pull request. It makes it easier to merge, as a notification is posted in the
jira with the pull command to use.
---
[
https://issues.apache.org/jira/browse/THRIFT-4374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-4374:
--
Assignee: James E. King, III (was: Robert Lu)
> cannot load thrift_protocol
[
https://issues.apache.org/jira/browse/THRIFT-4374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220676#comment-16220676
]
ASF GitHub Bot commented on THRIFT-4374:
Github user jeking3 commented on a diff in the pull
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1400#discussion_r147188692
--- Diff: lib/php/src/ext/thrift_protocol/config.m4 ---
@@ -25,6 +25,8 @@ PHP_ARG_ENABLE(thrift_protocol, whether to enable the
thrift_protocol extension,
[
https://issues.apache.org/jira/browse/THRIFT-4374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220663#comment-16220663
]
ASF GitHub Bot commented on THRIFT-4374:
Github user RobberPhex commented on the issue:
Github user RobberPhex commented on the issue:
https://github.com/apache/thrift/pull/1400
There is the [issue](https://issues.apache.org/jira/browse/THRIFT-4374)
---
Robert Lu created THRIFT-4374:
-
Summary: cannot load thrift_protocol due to undefined symbol:
_ZTVN10__cxxabiv120__si_class_type_infoE
Key: THRIFT-4374
URL: https://issues.apache.org/jira/browse/THRIFT-4374
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220658#comment-16220658
]
ASF GitHub Bot commented on THRIFT-4285:
Github user jeking3 commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220653#comment-16220653
]
ASF GitHub Bot commented on THRIFT-4372:
Github user jeking3 commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220655#comment-16220655
]
ASF GitHub Bot commented on THRIFT-4372:
Github user jeking3 commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220656#comment-16220656
]
ASF GitHub Bot commented on THRIFT-4372:
Github user jeking3 commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220654#comment-16220654
]
ASF GitHub Bot commented on THRIFT-4372:
Github user jeking3 commented on a diff in the pull
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1382
0.11.0 cycle hasn't started yet - you still have some time (I don't know
how much).
---
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1402#discussion_r147185494
--- Diff: lib/csharp/src/Transport/TNamedPipeServerTransport.cs ---
@@ -239,40 +239,51 @@ public override void Write(byte[] buf, int off, int
len)
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1402#discussion_r147185064
--- Diff: lib/csharp/src/Transport/TNamedPipeClientTransport.cs ---
@@ -88,7 +89,18 @@ public override void Write(byte[] buf, int off, int len)
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1402#discussion_r147185326
--- Diff: lib/csharp/src/Transport/TNamedPipeClientTransport.cs ---
@@ -88,7 +89,18 @@ public override void Write(byte[] buf, int off, int len)
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1402#discussion_r147185736
--- Diff: lib/csharp/src/Transport/TNamedPipeServerTransport.cs ---
@@ -239,40 +239,51 @@ public override void Write(byte[] buf, int off, int
len)
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1400
What's the Jira ticket number this is associated with?
---
[
https://issues.apache.org/jira/browse/THRIFT-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220634#comment-16220634
]
James E. King, III commented on THRIFT-2998:
While this change looks good, when I enable
[
https://issues.apache.org/jira/browse/THRIFT-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4370:
---
Priority: Blocker (was: Minor)
> Ubuntu Artful cppcheck and flake8 are more
[
https://issues.apache.org/jira/browse/THRIFT-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4370.
Resolution: Fixed
Fix Version/s: 0.11.0
> Ubuntu Artful cppcheck and flake8
[
https://issues.apache.org/jira/browse/THRIFT-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220632#comment-16220632
]
ASF GitHub Bot commented on THRIFT-4370:
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1399
---
[
https://issues.apache.org/jira/browse/THRIFT-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220523#comment-16220523
]
ASF GitHub Bot commented on THRIFT-4370:
Github user jeking3 commented on a diff in the pull
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1399#discussion_r147157619
--- Diff: lib/py/setup.py ---
@@ -22,7 +22,7 @@
import sys
try:
from setuptools import setup, Extension
-except:
+except
[
https://issues.apache.org/jira/browse/THRIFT-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220023#comment-16220023
]
ASF GitHub Bot commented on THRIFT-4373:
Github user RobberPhex commented on the issue:
Github user RobberPhex commented on the issue:
https://github.com/apache/thrift/pull/1401
If we want process REFERENCE everywhere.
I think we should review every line of `zval` used, is it?
---
[
https://issues.apache.org/jira/browse/THRIFT-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220018#comment-16220018
]
ASF GitHub Bot commented on THRIFT-4373:
Github user RobberPhex commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220019#comment-16220019
]
ASF GitHub Bot commented on THRIFT-4373:
Github user RobberPhex commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220020#comment-16220020
]
ASF GitHub Bot commented on THRIFT-4373:
Github user RobberPhex commented on a diff in the pull
Github user RobberPhex commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1401#discussion_r147051880
--- Diff: lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp ---
@@ -537,6 +537,9 @@ void binary_deserialize(int8_t thrift_typeID,
Github user RobberPhex commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1401#discussion_r147052024
--- Diff: lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp ---
@@ -699,6 +702,9 @@ void binary_serialize_hashtable_key(int8_t keytype,
Github user RobberPhex commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1401#discussion_r147052177
--- Diff: lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp ---
@@ -709,6 +715,9 @@ void binary_serialize(int8_t thrift_typeID,
54 matches
Mail list logo
