[jira] [Commented] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve()

[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226689#comment-15226689 ] Ben Craig commented on THRIFT-3768: --- ThreadManager is a mess. When the C++11 revolution comes, it will

[jira] [Commented] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve()

[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220756#comment-15220756 ] Ben Craig commented on THRIFT-3768: --- You probably will need two vectors. You can service the vectors

[jira] [Commented] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve()

[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220595#comment-15220595 ] Ben Craig commented on THRIFT-3768: --- Not sure how this will get reflected in code, but I would argue

[jira] [Commented] (THRIFT-3238) Fix TNamedPipeServer can be interrupted by faulty client

[ https://issues.apache.org/jira/browse/THRIFT-3238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15213225#comment-15213225 ] Ben Craig commented on THRIFT-3238: --- ugh, makes sense. The remainder of the attached patch makes more

[jira] [Commented] (THRIFT-3371) Abstract namespace Unix domain sockets broken in C++

[ https://issues.apache.org/jira/browse/THRIFT-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14951302#comment-14951302 ] Ben Craig commented on THRIFT-3371: --- +1 > Abstract namespace Unix domain sockets broken in C++ >

[jira] [Commented] (THRIFT-3237) Fix TNamedPipeServer::createNamedPipe memory leak

[ https://issues.apache.org/jira/browse/THRIFT-3237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944140#comment-14944140 ] Ben Craig commented on THRIFT-3237: --- +1 > Fix TNamedPipeServer::createNamedPipe memory leak >

[jira] [Commented] (THRIFT-3228) Fix TAutoOverlapThread may reference released memory

[ https://issues.apache.org/jira/browse/THRIFT-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934471#comment-14934471 ] Ben Craig commented on THRIFT-3228: --- There are basically two major options... 1. Break behavioral

[jira] [Resolved] (THRIFT-3270) reusing TNonblockingServer::TConnection cause dirty TSocket

[ https://issues.apache.org/jira/browse/THRIFT-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-3270. --- Resolution: Fixed Thanks for the patch Jesse! reusing TNonblockingServer::TConnection cause dirty

[jira] [Resolved] (THRIFT-3252) Missing TConcurrentClientSyncInfo.h in cpp Makefile, so doesn't install

[ https://issues.apache.org/jira/browse/THRIFT-3252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-3252. --- Resolution: Fixed Assignee: Adam Beberg Fix Version/s: 0.9.3 Missing

[jira] [Commented] (THRIFT-3252) Missing TConcurrentClientSyncInfo.h in cpp Makefile, so doesn't install

[ https://issues.apache.org/jira/browse/THRIFT-3252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637987#comment-14637987 ] Ben Craig commented on THRIFT-3252: --- Committed. Thanks! Missing

[jira] [Resolved] (THRIFT-3224) Fix TNamedPipeServer unpredictable behavior on accept

[ https://issues.apache.org/jira/browse/THRIFT-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-3224. --- Resolution: Fixed Fix TNamedPipeServer unpredictable behavior on accept

[jira] [Commented] (THRIFT-3225) Fix TPipeServer unpredictable behavior on interrupt()

[ https://issues.apache.org/jira/browse/THRIFT-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14629697#comment-14629697 ] Ben Craig commented on THRIFT-3225: --- Resolved in the same patch as THRIFT-3224 Fix

[jira] [Resolved] (THRIFT-3225) Fix TPipeServer unpredictable behavior on interrupt()

[ https://issues.apache.org/jira/browse/THRIFT-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-3225. --- Resolution: Fixed Fix TPipeServer unpredictable behavior on interrupt()

[jira] [Commented] (THRIFT-3246) Reduce the number of trivial warnings in Windows C++ CMake builds

[ https://issues.apache.org/jira/browse/THRIFT-3246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14628511#comment-14628511 ] Ben Craig commented on THRIFT-3246: --- This was mostly on the test side, and I don't

[jira] [Closed] (THRIFT-3231) CPP: Limit recursion depth to 64

[ https://issues.apache.org/jira/browse/THRIFT-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig closed THRIFT-3231. - CPP: Limit recursion depth to 64 Key: THRIFT-3231

[jira] [Created] (THRIFT-3247) Generate a C++ thread-safe client

Ben Craig created THRIFT-3247: - Summary: Generate a C++ thread-safe client Key: THRIFT-3247 URL: https://issues.apache.org/jira/browse/THRIFT-3247 Project: Thrift Issue Type: Improvement

[jira] [Created] (THRIFT-3246) Reduce the number of trivial warnings in Windows C++ CMake builds

Ben Craig created THRIFT-3246: - Summary: Reduce the number of trivial warnings in Windows C++ CMake builds Key: THRIFT-3246 URL: https://issues.apache.org/jira/browse/THRIFT-3246 Project: Thrift

[jira] [Resolved] (THRIFT-3245) Tutorials can't be disabled when using CMake

[ https://issues.apache.org/jira/browse/THRIFT-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-3245. --- Resolution: Fixed Assignee: Pascal Bach Fix Version/s: 0.9.2 Tutorials can't be

[jira] [Closed] (THRIFT-3245) Tutorials can't be disabled when using CMake

[ https://issues.apache.org/jira/browse/THRIFT-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig closed THRIFT-3245. - Tutorials can't be disabled when using CMake

[jira] [Commented] (THRIFT-3245) Tutorials can't be disabled when using CMake

[ https://issues.apache.org/jira/browse/THRIFT-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14628038#comment-14628038 ] Ben Craig commented on THRIFT-3245: --- Thanks for the pull request Pascal. Once Travis

[jira] [Reopened] (THRIFT-2858) Enable header field case insensitive match in THttpServer

[ https://issues.apache.org/jira/browse/THRIFT-2858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig reopened THRIFT-2858: --- This breaks the windows build. Windows doesn't have a strncasecmp or strcasestr. Pull request will be

[jira] [Resolved] (THRIFT-2858) Enable header field case insensitive match in THttpServer

[ https://issues.apache.org/jira/browse/THRIFT-2858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-2858. --- Resolution: Fixed Enable header field case insensitive match in THttpServer

[jira] [Resolved] (THRIFT-3246) Reduce the number of trivial warnings in Windows C++ CMake builds

[ https://issues.apache.org/jira/browse/THRIFT-3246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-3246. --- Resolution: Fixed Reduce the number of trivial warnings in Windows C++ CMake builds

[jira] [Commented] (THRIFT-3224) Fix TNamedPipeServer unpredictable behavior on accept

[ https://issues.apache.org/jira/browse/THRIFT-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627073#comment-14627073 ] Ben Craig commented on THRIFT-3224: --- [~pjanicki] I have updated my pull request. It

[jira] [Commented] (THRIFT-3224) Fix TNamedPipeServer unpredictable behavior on accept

[ https://issues.apache.org/jira/browse/THRIFT-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621612#comment-14621612 ] Ben Craig commented on THRIFT-3224: --- updated my pull request. Take a look at that when

[jira] [Commented] (THRIFT-3221) Create a tool to audit network compatibility between two .thrift files

[ https://issues.apache.org/jira/browse/THRIFT-3221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621618#comment-14621618 ] Ben Craig commented on THRIFT-3221: --- should be fixed now. Create a tool to audit

[jira] [Commented] (THRIFT-3225) Fix TPipeServer unpredictable behavior on interrupt()

[ https://issues.apache.org/jira/browse/THRIFT-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621624#comment-14621624 ] Ben Craig commented on THRIFT-3225: --- This might be right. I'm going to try to dig up

[jira] [Closed] (THRIFT-3217) Provide a little endian variant of the binary protocol in C++

[ https://issues.apache.org/jira/browse/THRIFT-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig closed THRIFT-3217. - Provide a little endian variant of the binary protocol in C++

[jira] [Closed] (THRIFT-3221) Create a tool to audit network compatibility between two .thrift files

[ https://issues.apache.org/jira/browse/THRIFT-3221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig closed THRIFT-3221. - Create a tool to audit network compatibility between two .thrift files

[jira] [Resolved] (THRIFT-3221) Create a tool to audit network compatibility between two .thrift files

[ https://issues.apache.org/jira/browse/THRIFT-3221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-3221. --- Resolution: Fixed Create a tool to audit network compatibility between two .thrift files

[jira] [Commented] (THRIFT-3228) Fix TAutoOverlapThread may reference released memory

[ https://issues.apache.org/jira/browse/THRIFT-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14620491#comment-14620491 ] Ben Craig commented on THRIFT-3228: --- A lot of my uses of Thrift involve multiple users

[jira] [Resolved] (THRIFT-3231) CPP: Limit recursion depth to 64

[ https://issues.apache.org/jira/browse/THRIFT-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-3231. --- Resolution: Fixed CPP: Limit recursion depth to 64

[jira] [Commented] (THRIFT-3224) Fix TNamedPipeServer unpredictable behavior on accept

[ https://issues.apache.org/jira/browse/THRIFT-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14620524#comment-14620524 ] Ben Craig commented on THRIFT-3224: --- I agree that TAutoHandle references can make this

[jira] [Commented] (THRIFT-3228) Fix TAutoOverlapThread may reference released memory

[ https://issues.apache.org/jira/browse/THRIFT-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618801#comment-14618801 ] Ben Craig commented on THRIFT-3228: --- Function level statics are not thread safe in

[jira] [Created] (THRIFT-3231) CPP: Limit recursion depth to 64

Ben Craig created THRIFT-3231: - Summary: CPP: Limit recursion depth to 64 Key: THRIFT-3231 URL: https://issues.apache.org/jira/browse/THRIFT-3231 Project: Thrift Issue Type: Bug

[jira] [Resolved] (THRIFT-3217) Provide a little endian variant of the binary protocol in C++

[ https://issues.apache.org/jira/browse/THRIFT-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-3217. --- Resolution: Fixed Fix Version/s: 0.9.3 Provide a little endian variant of the binary

[jira] [Commented] (THRIFT-3225) Fix TPipeServer unpredictable behavior on close

[ https://issues.apache.org/jira/browse/THRIFT-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14617321#comment-14617321 ] Ben Craig commented on THRIFT-3225: --- -1 close() doesn't need to be / shouldn't be

[jira] [Commented] (THRIFT-3225) Fix TPipeServer unpredictable behavior on close

[ https://issues.apache.org/jira/browse/THRIFT-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14617329#comment-14617329 ] Ben Craig commented on THRIFT-3225: --- doh! please back this out. I'm reviewing some of

[jira] [Commented] (THRIFT-3224) Fix TNamedPipeServer unpredictable behavior on accept

[ https://issues.apache.org/jira/browse/THRIFT-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14617344#comment-14617344 ] Ben Craig commented on THRIFT-3224: --- This patch leaks pipes if the TPipe ctor throws.

[jira] [Commented] (THRIFT-3226) Fix TNamedPipeServer trapped in loop on accept

[ https://issues.apache.org/jira/browse/THRIFT-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14617351#comment-14617351 ] Ben Craig commented on THRIFT-3226: --- Don't try to use closed transports. Calling

[jira] [Commented] (THRIFT-3221) Create a tool to audit network compatibility between two .thrift files

[ https://issues.apache.org/jira/browse/THRIFT-3221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614374#comment-14614374 ] Ben Craig commented on THRIFT-3221: --- The compiler help says how to use it, but right

[jira] [Created] (THRIFT-3221) Create a tool to audit network compatibility between two .thrift files

Ben Craig created THRIFT-3221: - Summary: Create a tool to audit network compatibility between two .thrift files Key: THRIFT-3221 URL: https://issues.apache.org/jira/browse/THRIFT-3221 Project: Thrift

[jira] [Resolved] (THRIFT-3219) Provide a C++ tutorial on server-side IP logging and per-connection state

[ https://issues.apache.org/jira/browse/THRIFT-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-3219. --- Resolution: Fixed Assignee: Ben Craig Provide a C++ tutorial on server-side IP logging and

[jira] [Closed] (THRIFT-3219) Provide a C++ tutorial on server-side IP logging and per-connection state

[ https://issues.apache.org/jira/browse/THRIFT-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig closed THRIFT-3219. - Provide a C++ tutorial on server-side IP logging and per-connection state

[jira] [Commented] (THRIFT-3217) Provide a little endian variant of the binary protocol in C++

[ https://issues.apache.org/jira/browse/THRIFT-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14613180#comment-14613180 ] Ben Craig commented on THRIFT-3217: --- I'll see if I can rustle up some ARM numbers.

[jira] [Commented] (THRIFT-3217) Provide a little endian variant of the binary protocol in C++

[ https://issues.apache.org/jira/browse/THRIFT-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14613505#comment-14613505 ] Ben Craig commented on THRIFT-3217: --- Beefed up the performance test a bit. Here's my

[jira] [Assigned] (THRIFT-3217) Provide a little endian variant of the binary protocol in C++

[ https://issues.apache.org/jira/browse/THRIFT-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig reassigned THRIFT-3217: - Assignee: Ben Craig Provide a little endian variant of the binary protocol in C++

[jira] [Created] (THRIFT-3219) Provide a C++ tutorial on server-side IP logging and per-connection state

Ben Craig created THRIFT-3219: - Summary: Provide a C++ tutorial on server-side IP logging and per-connection state Key: THRIFT-3219 URL: https://issues.apache.org/jira/browse/THRIFT-3219 Project: Thrift

[jira] [Updated] (THRIFT-3217) Provide a little endian variant of the binary protocol in C++

[ https://issues.apache.org/jira/browse/THRIFT-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-3217: -- Component/s: C++ - Library Provide a little endian variant of the binary protocol in C++

[jira] [Created] (THRIFT-3217) Provide a little endian variant of the binary protocol in C++

Ben Craig created THRIFT-3217: - Summary: Provide a little endian variant of the binary protocol in C++ Key: THRIFT-3217 URL: https://issues.apache.org/jira/browse/THRIFT-3217 Project: Thrift

[jira] [Commented] (THRIFT-3038) Use of volatile in cpp library

[ https://issues.apache.org/jira/browse/THRIFT-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562856#comment-14562856 ] Ben Craig commented on THRIFT-3038: --- You could take that path that the threading and

[jira] [Commented] (THRIFT-3038) Use of volatile in cpp library

[ https://issues.apache.org/jira/browse/THRIFT-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14561769#comment-14561769 ] Ben Craig commented on THRIFT-3038: --- The Thrift Cpp library does not currently require

[jira] [Commented] (THRIFT-1944) Binding to zero port

[ https://issues.apache.org/jira/browse/THRIFT-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14532578#comment-14532578 ] Ben Craig commented on THRIFT-1944: --- To recap from earlier in the thread... 1)

[jira] [Closed] (THRIFT-2150) Should windows/config.h define WIN32_LEAN_AND_MEAN?

[ https://issues.apache.org/jira/browse/THRIFT-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig closed THRIFT-2150. - Resolution: Won't Fix This is a Microsoft build infrastructure issue that is external to the project

[jira] [Updated] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-2441: -- Assignee: James E. King, III (was: Ben Craig) Cannot shutdown TThreadedServer when clients are still

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511098#comment-14511098 ] Ben Craig commented on THRIFT-2441: --- committed. Thanks jeking3! Cannot shutdown

[jira] [Resolved] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-2441. --- Resolution: Fixed Cannot shutdown TThreadedServer when clients are still connected

[jira] [Closed] (THRIFT-2119) Compiling the Thrift C++ Library with Visual Studio 2005

[ https://issues.apache.org/jira/browse/THRIFT-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig closed THRIFT-2119. - Resolution: Won't Fix See other comments. VS2005 is old enough that we don't feel the need to

[jira] [Commented] (THRIFT-2119) Compiling the Thrift C++ Library with Visual Studio 2005

[ https://issues.apache.org/jira/browse/THRIFT-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503602#comment-14503602 ] Ben Craig commented on THRIFT-2119: --- I am fine dropping this as well. I will close.

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490579#comment-14490579 ] Ben Craig commented on THRIFT-2441: --- +1 Cannot shutdown TThreadedServer when clients

[jira] [Commented] (THRIFT-3081) C++ Consolidate client processing loops in TServers

[ https://issues.apache.org/jira/browse/THRIFT-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490598#comment-14490598 ] Ben Craig commented on THRIFT-3081: --- I approve of the general direction of the recently

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487648#comment-14487648 ] Ben Craig commented on THRIFT-2441: --- oh, sorry about that. I wasn't sure if this had

[jira] [Commented] (THRIFT-3084) C++ add concurrent client limit to threaded servers

[ https://issues.apache.org/jira/browse/THRIFT-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14481443#comment-14481443 ] Ben Craig commented on THRIFT-3084: --- That logic allows for maxConnections + 1 to be

[jira] [Commented] (THRIFT-3084) C++ add concurrent client limit to threaded servers

[ https://issues.apache.org/jira/browse/THRIFT-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14482250#comment-14482250 ] Ben Craig commented on THRIFT-3084: --- I was going to argue more, but then I argued

[jira] [Commented] (THRIFT-3084) C++ add concurrent client limit to threaded servers

[ https://issues.apache.org/jira/browse/THRIFT-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14482236#comment-14482236 ] Ben Craig commented on THRIFT-3084: --- I'm great with gutting TThreadedServer, but I

[jira] [Commented] (THRIFT-3084) C++ add concurrent client limit to threaded servers

[ https://issues.apache.org/jira/browse/THRIFT-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14481350#comment-14481350 ] Ben Craig commented on THRIFT-3084: --- I think that the ThreadManager class already

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14394389#comment-14394389 ] Ben Craig commented on THRIFT-2441: --- I approve of the direction of this patch. I

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14394837#comment-14394837 ] Ben Craig commented on THRIFT-2441: --- I don't know why the peek is there. In the server

[jira] [Commented] (THRIFT-1025) C++ ServerSocket should inherit from Socket with the necessary Ctor to listen on connections from a specific host (similar to perl library)

[ https://issues.apache.org/jira/browse/THRIFT-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14394729#comment-14394729 ] Ben Craig commented on THRIFT-1025: --- +1 C++ ServerSocket should inherit from Socket

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392880#comment-14392880 ] Ben Craig commented on THRIFT-2441: --- I think we're converging on a great answer.

[jira] [Comment Edited] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392880#comment-14392880 ] Ben Craig edited comment on THRIFT-2441 at 4/2/15 4:00 PM: --- I

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391440#comment-14391440 ] Ben Craig commented on THRIFT-2441: --- Did not provide a way to maintain the current

[jira] [Commented] (THRIFT-3063) C++ build -Wunused-parameter warnings on processor_test, TransportTest

[ https://issues.apache.org/jira/browse/THRIFT-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388564#comment-14388564 ] Ben Craig commented on THRIFT-3063: --- Visual Studio /W4 has a similar warning ( C4100 ).

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388768#comment-14388768 ] Ben Craig commented on THRIFT-2441: --- I agree that the issue is a real one, and should

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388513#comment-14388513 ] Ben Craig commented on THRIFT-2441: --- TServerSocket's pattern is basically what I had in

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386681#comment-14386681 ] Ben Craig commented on THRIFT-2441: --- however this patch applies after the listening

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386696#comment-14386696 ] Ben Craig commented on THRIFT-2441: --- When there is a network disconnect, the socket

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386763#comment-14386763 ] Ben Craig commented on THRIFT-2441: --- I am leery in general of closing a transport in

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386093#comment-14386093 ] Ben Craig commented on THRIFT-2441: --- -1 for this specific fix. Closing a socket that

[jira] [Commented] (THRIFT-2873) TPipe and TPipeServer don't compile on Windows with UNICODE enabled

[ https://issues.apache.org/jira/browse/THRIFT-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234216#comment-14234216 ] Ben Craig commented on THRIFT-2873: --- +1 TPipe and TPipeServer don't compile on

[jira] [Commented] (THRIFT-2873) TPipe and TPipeServer don't compile on windows with UNICODE enabled

[ https://issues.apache.org/jira/browse/THRIFT-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14233069#comment-14233069 ] Ben Craig commented on THRIFT-2873: --- casting from a const char * to a LPCTSTR with

[jira] [Commented] (THRIFT-2873) TPipe and TPipeServer don't compile on windows with UNICODE enabled

[ https://issues.apache.org/jira/browse/THRIFT-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14233606#comment-14233606 ] Ben Craig commented on THRIFT-2873: --- [~pascal.bach] I think you are correct. TPipe and

[jira] [Commented] (THRIFT-2799) Build Problem(s): ld: library not found for -l:libboost_unit_test_framework.a

[ https://issues.apache.org/jira/browse/THRIFT-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14202050#comment-14202050 ] Ben Craig commented on THRIFT-2799: --- 'missing separator' normally means that you missed

[jira] [Commented] (THRIFT-2799) Build Problem(s): ld: library not found for -l:libboost_unit_test_framework.a

[ https://issues.apache.org/jira/browse/THRIFT-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14200970#comment-14200970 ] Ben Craig commented on THRIFT-2799: --- A colon snuck into your library name. Your link

[jira] [Commented] (THRIFT-2799) Build Problem(s): ld: library not found for -l:libboost_unit_test_framework.a

[ https://issues.apache.org/jira/browse/THRIFT-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14201005#comment-14201005 ] Ben Craig commented on THRIFT-2799: --- Try changing thrift / lib / cpp / test /

[jira] [Commented] (THRIFT-2717) C++11 generator

[ https://issues.apache.org/jira/browse/THRIFT-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14161861#comment-14161861 ] Ben Craig commented on THRIFT-2717: --- Most of the features mentioned in the ticket don't

[jira] [Commented] (THRIFT-2717) C++11 generator

[ https://issues.apache.org/jira/browse/THRIFT-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14161922#comment-14161922 ] Ben Craig commented on THRIFT-2717: --- Add some extra directories maybe? calculator.cpp #

[jira] [Commented] (THRIFT-2717) C++11 generator

[ https://issues.apache.org/jira/browse/THRIFT-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14162264#comment-14162264 ] Ben Craig commented on THRIFT-2717: --- v2 headers could #error if used with too old of a

[jira] [Commented] (THRIFT-2717) C++11 generator

[ https://issues.apache.org/jira/browse/THRIFT-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14157949#comment-14157949 ] Ben Craig commented on THRIFT-2717: --- we may be able to (sort of) drop boost from the

[jira] [Commented] (THRIFT-2717) C++11 generator

[ https://issues.apache.org/jira/browse/THRIFT-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14158101#comment-14158101 ] Ben Craig commented on THRIFT-2717: --- They only need to use tcxx::shared_ptr if they

[jira] [Commented] (THRIFT-2717) C++11 generator

[ https://issues.apache.org/jira/browse/THRIFT-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14144771#comment-14144771 ] Ben Craig commented on THRIFT-2717: --- RHEL and CentOS 6 use gcc 4.4. RHEL 7 came out

[jira] [Commented] (THRIFT-2717) C++11 generator

[ https://issues.apache.org/jira/browse/THRIFT-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14143739#comment-14143739 ] Ben Craig commented on THRIFT-2717: --- I think I've had a misunderstanding with what this

[jira] [Comment Edited] (THRIFT-2717) C++11 generator

[ https://issues.apache.org/jira/browse/THRIFT-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14143739#comment-14143739 ] Ben Craig edited comment on THRIFT-2717 at 9/22/14 8:23 PM: I

[jira] [Commented] (THRIFT-2698) Errors while compiling thrift client for Windows CE

[ https://issues.apache.org/jira/browse/THRIFT-2698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14130497#comment-14130497 ] Ben Craig commented on THRIFT-2698: --- Most of those errors come from boost. Boost 1.55

[jira] [Commented] (THRIFT-2639) c_glib: Expose as properties members of generated structs

[ https://issues.apache.org/jira/browse/THRIFT-2639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14084644#comment-14084644 ] Ben Craig commented on THRIFT-2639: --- I think that the C++ community is still a ways off

[jira] [Commented] (THRIFT-2416) Cannot use TCompactProtocol with MSVC

[ https://issues.apache.org/jira/browse/THRIFT-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14053730#comment-14053730 ] Ben Craig commented on THRIFT-2416: --- You could fix if for the platforms that you care

[jira] [Commented] (THRIFT-2416) Cannot use TCompactProtocol with MSVC

[ https://issues.apache.org/jira/browse/THRIFT-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14053892#comment-14053892 ] Ben Craig commented on THRIFT-2416: --- The attached patch looks fine to me (though I

[jira] [Commented] (THRIFT-2581) TFDTransport destructor should not throw

[ https://issues.apache.org/jira/browse/THRIFT-2581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042072#comment-14042072 ] Ben Craig commented on THRIFT-2581: --- The current patch isn't perfect, but it's good

[jira] [Commented] (THRIFT-2581) TFDTransport destructor should not throw

[ https://issues.apache.org/jira/browse/THRIFT-2581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039957#comment-14039957 ] Ben Craig commented on THRIFT-2581: --- I'm not entirely sure I like that test case in

[jira] [Commented] (THRIFT-2575) Thrift includes siginfo_t within apache::thrift::protocol namespace

[ https://issues.apache.org/jira/browse/THRIFT-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14031045#comment-14031045 ] Ben Craig commented on THRIFT-2575: --- This has been fixed in master. Thrift includes

  1   2   3   4   >