[jira] [Commented] (THRIFT-4219) Golang HTTP clients created with Nil buffer

2017-07-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082994#comment-16082994 ] ASF GitHub Bot commented on THRIFT-4219: Github user asfgit closed the pull reque

[jira] [Commented] (THRIFT-4219) Golang HTTP clients created with Nil buffer

2017-07-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082082#comment-16082082 ] ASF GitHub Bot commented on THRIFT-4219: Github user dcelasun commented on the is

[jira] [Commented] (THRIFT-4219) Golang HTTP clients created with Nil buffer

2017-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071257#comment-16071257 ] ASF GitHub Bot commented on THRIFT-4219: Github user Jens-G commented on the issu

[jira] [Commented] (THRIFT-4219) Golang HTTP clients created with Nil buffer

2017-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067174#comment-16067174 ] ASF GitHub Bot commented on THRIFT-4219: Github user dcelasun commented on the is

[jira] [Commented] (THRIFT-4219) Golang HTTP clients created with Nil buffer

2017-06-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045613#comment-16045613 ] ASF GitHub Bot commented on THRIFT-4219: Github user dcelasun commented on the is

[jira] [Commented] (THRIFT-4219) Golang HTTP clients created with Nil buffer

2017-06-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045586#comment-16045586 ] ASF GitHub Bot commented on THRIFT-4219: GitHub user dcelasun opened a pull reque

[jira] [Commented] (THRIFT-4219) Golang HTTP clients created with Nil buffer

2017-06-09 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044830#comment-16044830 ] Can Celasun commented on THRIFT-4219: - Noted. I'll keep the design principles in mind

[jira] [Commented] (THRIFT-4219) Golang Http Clients Created with Nil Buffer

2017-06-09 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044556#comment-16044556 ] Jens Geyer commented on THRIFT-4219: {quote} I've checked the Java and Python clients

[jira] [Commented] (THRIFT-4219) Golang Http Clients Created with Nil Buffer

2017-06-08 Thread James Mouradian (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043689#comment-16043689 ] James Mouradian commented on THRIFT-4219: - I am in favor of making things consist

[jira] [Commented] (THRIFT-4219) Golang Http Clients Created with Nil Buffer

2017-06-08 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043533#comment-16043533 ] Can Celasun commented on THRIFT-4219: - {quote}We should not do anything that breaks c

[jira] [Commented] (THRIFT-4219) Golang Http Clients Created with Nil Buffer

2017-06-08 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043522#comment-16043522 ] Jens Geyer commented on THRIFT-4219: The layout, behaviour and names of the methods a

[jira] [Commented] (THRIFT-4219) Golang Http Clients Created with Nil Buffer

2017-06-08 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043451#comment-16043451 ] Can Celasun commented on THRIFT-4219: - [~jmrdi] I agree that the current situation is

[jira] [Commented] (THRIFT-4219) Golang Http Clients Created with Nil Buffer

2017-06-08 Thread James Mouradian (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043419#comment-16043419 ] James Mouradian commented on THRIFT-4219: - [~calcifer] It seems extremely unintui

[jira] [Commented] (THRIFT-4219) Golang Http Clients Created with Nil Buffer

2017-06-08 Thread James Mouradian (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043396#comment-16043396 ] James Mouradian commented on THRIFT-4219: - [~jensg] By that, I meant it may be wo

[jira] [Commented] (THRIFT-4219) Golang Http Clients Created with Nil Buffer

2017-06-06 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16038395#comment-16038395 ] Can Celasun commented on THRIFT-4219: - [~jmrdi] {{NewTHttpClient}} is for making a si

[jira] [Commented] (THRIFT-4219) Golang Http Clients Created with Nil Buffer

2017-06-01 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16033622#comment-16033622 ] Jens Geyer commented on THRIFT-4219: {quote}A patch probably fits well with ... {quot