[GitHub] tinkerpop issue #842: TINKERPOP-1945

2018-05-23 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/842 I don't think it's wrong to mark something as "deprecated" in preparation for a future non-usage that may or may not happen. I think the point is to establish the intent to users that we no

[jira] [Commented] (TINKERPOP-1945) Add support for extended GraphSon types to Gremlin.net

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488060#comment-16488060 ] ASF GitHub Bot commented on TINKERPOP-1945: --- Github user danielcweber commented on the

[GitHub] tinkerpop issue #842: TINKERPOP-1945

2018-05-23 Thread danielcweber
Github user danielcweber commented on the issue: https://github.com/apache/tinkerpop/pull/842 >remove all deserializers again for which no serializer exists and vice versa Why would we do that? If we can construct (i.e. deserialize) e.g. a DateTime of whatever a server gives

[jira] [Commented] (TINKERPOP-1945) Add support for extended GraphSon types to Gremlin.net

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487927#comment-16487927 ] ASF GitHub Bot commented on TINKERPOP-1945: --- Github user FlorianHockmann commented on the

[GitHub] tinkerpop issue #842: TINKERPOP-1945

2018-05-23 Thread FlorianHockmann
Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/842 After thinking a bit more about this, my conclusion was that deprecating those types doesn't really make sense unless we plan on GraphSON 4.0 as we couldn't remove the types before that.

[jira] [Commented] (TINKERPOP-1942) Binary serialization format

2018-05-23 Thread Florian Hockmann (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487893#comment-16487893 ] Florian Hockmann commented on TINKERPOP-1942: - I like the idea of using a binary

[GitHub] tinkerpop issue #868: Tinkerpop 1913

2018-05-23 Thread FlorianHockmann
Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/868 @ashwini-ms did you see my comment regarding whether `IGremlinClient` should return a `ResultSet` now instead of an `IReadOnlyCollection`? It's now a bit hidden as GitHub collapsed it

[jira] [Commented] (TINKERPOP-1897) Provide Docker images of Gremlin Server and Console

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487796#comment-16487796 ] ASF GitHub Bot commented on TINKERPOP-1897: --- Github user FlorianHockmann commented on the

[GitHub] tinkerpop issue #802: Add docker images for console and server TINKERPOP-189...

2018-05-23 Thread FlorianHockmann
Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/802 No, you're right. That is something that is very unlikely to occur and I can't think of other (more likely) reasons where the build of the docker images could fail as they really only

[jira] [Commented] (TINKERPOP-1897) Provide Docker images of Gremlin Server and Console

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487659#comment-16487659 ] ASF GitHub Bot commented on TINKERPOP-1897: --- Github user spmallette commented on the issue:

[GitHub] tinkerpop issue #802: Add docker images for console and server TINKERPOP-189...

2018-05-23 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/802 > detect when changes break the Docker images, e.g., when the naming of the zip archives or their location changes That's fair, though that specific example seems really unlikely to

[jira] [Commented] (TINKERPOP-1897) Provide Docker images of Gremlin Server and Console

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487649#comment-16487649 ] ASF GitHub Bot commented on TINKERPOP-1897: --- Github user FlorianHockmann commented on the

[GitHub] tinkerpop issue #802: Add docker images for console and server TINKERPOP-189...

2018-05-23 Thread FlorianHockmann
Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/802 > what is the advantage to building these images if a .docker file is present? A reason to keep this option is that it makes it easier to detect when changes break the Docker

[jira] [Commented] (TINKERPOP-1897) Provide Docker images of Gremlin Server and Console

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487613#comment-16487613 ] ASF GitHub Bot commented on TINKERPOP-1897: --- Github user FlorianHockmann commented on a diff

[GitHub] tinkerpop pull request #802: Add docker images for console and server TINKER...

2018-05-23 Thread FlorianHockmann
Github user FlorianHockmann commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/802#discussion_r190320705 --- Diff: docs/src/reference/gremlin-applications.asciidoc --- @@ -353,6 +353,38 @@ variable initialization code into the console. Like,

[jira] [Commented] (TINKERPOP-1897) Provide Docker images of Gremlin Server and Console

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487608#comment-16487608 ] ASF GitHub Bot commented on TINKERPOP-1897: --- Github user spmallette commented on a diff in

[GitHub] tinkerpop pull request #802: Add docker images for console and server TINKER...

2018-05-23 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/802#discussion_r190319710 --- Diff: gremlin-driver/src/test/java/org/apache/tinkerpop/gremlin/driver/ResultQueueTest.java --- @@ -281,7 +281,7 @@ public void

[jira] [Commented] (TINKERPOP-1897) Provide Docker images of Gremlin Server and Console

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487604#comment-16487604 ] ASF GitHub Bot commented on TINKERPOP-1897: --- Github user FlorianHockmann commented on a diff

[GitHub] tinkerpop pull request #802: Add docker images for console and server TINKER...

2018-05-23 Thread FlorianHockmann
Github user FlorianHockmann commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/802#discussion_r190319039 --- Diff: gremlin-driver/src/test/java/org/apache/tinkerpop/gremlin/driver/ResultQueueTest.java --- @@ -281,7 +281,7 @@ public void

[jira] [Created] (TINKERPOP-1975) Introduce with() step modulator

2018-05-23 Thread stephen mallette (JIRA)
stephen mallette created TINKERPOP-1975: --- Summary: Introduce with() step modulator Key: TINKERPOP-1975 URL: https://issues.apache.org/jira/browse/TINKERPOP-1975 Project: TinkerPop