[GitHub] tinkerpop issue #705: make TinkerGraph cloneable

Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/705 Yes. Exactly. Here is the thing is -- I don't really care for TinkerPop3 anymore so it can go as people want it too, I won't fight. But if you want to start aligning concepts so TinkerPop4

[GitHub] tinkerpop issue #705: make TinkerGraph cloneable

Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/705 hmm - and then a TinkerGraph strategy that converts `g.V().drop()` to a `clear()` operation somehow (to avoid overhead of iterating all the vertices? by that logic is `clone()`

[GitHub] tinkerpop issue #705: make TinkerGraph cloneable

Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/705 `TinkerGraph.clear()` is bad too. It is `g.V().drop()`. ---

[GitHub] tinkerpop issue #705: make TinkerGraph cloneable

Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/705 `clone()` won't work well for all graphs though. Making it a generalized utility for `clone()` just seems to invite more trouble than having it just available to TinkerGraph where it at least

[GitHub] tinkerpop issue #705: make TinkerGraph cloneable

Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/705 I don't think it is a good idea to implement `TinkerGraph.clone()`. I think, instead, that there could be a "clone utility" that works for all graphs, not just TinkerGraph. E.g. ```

[GitHub] tinkerpop issue #705: make TinkerGraph cloneable

Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/705 @mpollmeier a few things: 1. could you please retarget this at tp32 - seems like it would be ok to include this feature there 2. update CHANGELOG to mention this change 3. add

[GitHub] tinkerpop pull request #705: make TinkerGraph cloneable

Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/705#discussion_r137840681 --- Diff: tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerGraph.java --- @@ -340,6 +342,14 @@ private void

[GitHub] tinkerpop pull request #705: make TinkerGraph cloneable

Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/705#discussion_r137840343 --- Diff: tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerGraphTest.java --- @@ -592,6 +592,31 @@ public

[GitHub] tinkerpop pull request #705: make TinkerGraph cloneable

Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/705#discussion_r137840086 --- Diff: tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerGraphTest.java --- @@ -592,6 +592,31 @@ public

[GitHub] tinkerpop pull request #705: make TinkerGraph cloneable

Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/705#discussion_r137839998 --- Diff: tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerGraph.java --- @@ -340,6 +342,14 @@ private void

[jira] [Closed] (TINKERPOP-1767) Method for graph providers to check an IO version and type

[ https://issues.apache.org/jira/browse/TINKERPOP-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1767. --- Resolution: Done > Method for graph providers to check an IO version and type >

[jira] [Commented] (TINKERPOP-1767) Method for graph providers to check an IO version and type

[ https://issues.apache.org/jira/browse/TINKERPOP-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158916#comment-16158916 ] ASF GitHub Bot commented on TINKERPOP-1767: --- Github user asfgit closed the pull request at:

[GitHub] tinkerpop pull request #706: TINKERPOP-1767 Added Io.requiresVersion(Object)

Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/706 ---

[jira] [Closed] (TINKERPOP-1768) Bump to Jackson 2.8.10

[ https://issues.apache.org/jira/browse/TINKERPOP-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1768. --- Resolution: Done Fix Version/s: 3.2.7 > Bump to Jackson 2.8.10 >

[jira] [Commented] (TINKERPOP-1768) Bump to Jackson 2.8.10

[ https://issues.apache.org/jira/browse/TINKERPOP-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158870#comment-16158870 ] ASF GitHub Bot commented on TINKERPOP-1768: --- Github user asfgit closed the pull request at:

[GitHub] tinkerpop pull request #707: TINKERPOP-1768 Bump to Jackson 2.8.10

Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/707 ---

[jira] [Commented] (TINKERPOP-1766) Gremlin.Net: Closed connections should not be re-used

[ https://issues.apache.org/jira/browse/TINKERPOP-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158731#comment-16158731 ] ASF GitHub Bot commented on TINKERPOP-1766: --- Github user FlorianHockmann commented on the

[GitHub] tinkerpop issue #704: TINKERPOP-1766 Gremlin.Net: Add handling for closed co...

Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/704 > Should we file a different ticket for the pool improvements? Yes, I think a dedicated ticket for those improvements is a good idea and it makes probably sense if you create it

Re: [DISCUSS] Some JIRA adjustments

You would only know through tribal knowedge and the changelog I guess. sucks - i just realized that there are duplicates all through the changelog because there's been spotty application of a single fix version. dah On Fri, Sep 8, 2017 at 9:33 AM, Daniel Kuppitz wrote: > But

Re: [DISCUSS] Some JIRA adjustments

But who will remember a few months after a release, that it was 3.3.1 that went out together with 3.2.7, and not 3.3.0? When I see 3.2.7 in the fix version, I know it must be somewhere in the 3.3 line, too, but I wouldn't know that it was 3.3.1 for example. That's why I always prefer to specify

Re: [DISCUSS] Some JIRA adjustments

a while back we'd decided that since all fixes roll forward to other releases, that we would only add the fix version to the lowest common release. so if you fix something 3.2.7 then it will automatically be included in 3.3.1 (we've not had a case yet where something is only fixed in 3.2.x but not

Re: [DISCUSS] Some JIRA adjustments

> > a. reserve "fix version" for when we actually close the ticket That's how I always used to do it. However, sometimes (just recently) I noticed that you took away one version. The fix went into tp32/ and then got merged into master/. So it will end up being part of 3.2.7 and 3.3.1 and

[jira] [Commented] (TINKERPOP-1489) Provide a Javascript Gremlin Language Variant

[ https://issues.apache.org/jira/browse/TINKERPOP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158445#comment-16158445 ] ASF GitHub Bot commented on TINKERPOP-1489: --- Github user spmallette commented on the issue:

[GitHub] tinkerpop issue #695: TINKERPOP-1489 JavaScript GLV

Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/695 I mostly cared about nashorn to achieve testing as we did in python. I sense that most folks won't want to run on nashorn itself, so perhaps direct support of nashorn doesn't really matter

[jira] [Commented] (TINKERPOP-1766) Gremlin.Net: Closed connections should not be re-used

[ https://issues.apache.org/jira/browse/TINKERPOP-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158424#comment-16158424 ] ASF GitHub Bot commented on TINKERPOP-1766: --- Github user jorgebay commented on the issue:

[GitHub] tinkerpop issue #704: TINKERPOP-1766 Gremlin.Net: Add handling for closed co...

Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/704 About request pipelining, you can send in a queue one by one regardless of whether or not it was received. On the read side, once a message is received you issue a following call to

[jira] [Commented] (TINKERPOP-1489) Provide a Javascript Gremlin Language Variant

[ https://issues.apache.org/jira/browse/TINKERPOP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158244#comment-16158244 ] ASF GitHub Bot commented on TINKERPOP-1489: --- Github user jorgebay commented on the issue:

[GitHub] tinkerpop issue #695: TINKERPOP-1489 JavaScript GLV

Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/695 I've removed support for Nashorn as part of #626 (see first comment). JavaScript engines don't provide a standard way to deal with and import modules, so supporting with multiple runtimes is