Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/448
Hi @al3xandru This work has already been merged and will be released
in TinkerPop 3.2.3. To answer your concerns though:
1. In order to make life easier for TinkerPop, its important tha
Github user al3xandru commented on the issue:
https://github.com/apache/tinkerpop/pull/448
A bit late to the conversation as I've noticed this hasn't been merged yet.
> I don't think there's a use case in the context of the python GLV, but we
have that use case in GraphSON in
Github user aholmberg commented on the issue:
https://github.com/apache/tinkerpop/pull/448
Pushed the split names. I didn't see issues related to these changes
running `process-docs.sh`.
May have been related to the previous removal of GraphSONWriter/Reader.
---
If your project i
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/448
> Maybe we should clarify what APIs really need to be preserved.
imo i think that could be debated. at this point, i think being sorta
cautious and following what's been working for a j
Github user aholmberg commented on the issue:
https://github.com/apache/tinkerpop/pull/448
Maybe we should clarify what APIs really need to be preserved. I have been
thinking about the `process` package, and `structure` module as the Gremlin
API, and the `driver` and `io` as distinct
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/448
I don't think there's a use case in the context of the python GLV, but we
have that use case in GraphSON in legacy support for TinkerPop 2.x based
GraphSON (the migration scenario mentioned). I
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/448
@aholmberg We have had a distinction between reader/writer since the
beginning of TinkerPop. I believe (@spmallette knows more) that there is a
`GryoMapper` class that has all the serializers regist
Github user aholmberg commented on the issue:
https://github.com/apache/tinkerpop/pull/448
Thanks. I see the code there. What is not clear to me is why these two
things are divided, and why that API should be replicated here. I'm having a
hard time doing this change because it makes i
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/448
Cool @aholmberg ... Here are some more pointers.
https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/GraphReader.java
Github user aholmberg commented on the issue:
https://github.com/apache/tinkerpop/pull/448
- rebased
- dropped `unittest.TestCase` assertions
- added custom graphson_io to DriverRemoteConnection
I haven't had a chance to get back to the GraphSONIO vs Reader/Writer
ques
Github user aholmberg commented on the issue:
https://github.com/apache/tinkerpop/pull/448
(also, ACK on rebase -- I should be getting to it today)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user aholmberg commented on the issue:
https://github.com/apache/tinkerpop/pull/448
> you changed GraphSONWriter and GraphSONWriter to GraphSONIO
This was not Python-specific, but felt like a natural design to me. I
unified the I/O per type, and tied those together at t
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/448
Hi -- one thing to add. I notice you changed `GraphSONWriter` and
`GraphSONWriter` to `GraphSONIO` ... The writer/reader names are identical to
Gremlin-Java. If its possible, can we leave the origin
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/448
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if t
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/448
I like these changes. With a solid rebase of master/ given my recent
`TraversalStrategy` serializer work, I'm good with merging this PR.
VOTE +1.
---
If your project is set up for it, you
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/448
Yeah makes sense. I'm hoping to do some major refactors of the Driver over
the next couple months anyway, but I'm juggling too many things right now.
Either way this seems good to go.
---
If y
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/448
@aholmberg I know. Sorry. I'm not graceful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user aholmberg commented on the issue:
https://github.com/apache/tinkerpop/pull/448
argh. needs a third rebase, too :-/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user aholmberg commented on the issue:
https://github.com/apache/tinkerpop/pull/448
> graphson_io=None to the __init__ method signature
I think that is a fine idea. I was mostly focused on the GraphSON API and
not concerned with adding it to the token RemoteConnection i
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/448
I like this. Much simpler, well tested, in general a nice PR. Pretty slick
using the metaclass to create the de-/serializer maps. One thing I wonder:
Presumably using the `GraphSONIO` i
Github user aholmberg commented on the issue:
https://github.com/apache/tinkerpop/pull/448
I'm ambivalent on that. I just noticed unittest was present, and the bare
assertions were not very informative. I can take that commit out if you think
it's not worth it now.
---
If your proje
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/448
To be honest, I think that we should move away from the `unittest`
framework in the future. I know that `pytest` allows for unittest integration,
but in general this is to facilitate the transit
Github user aholmberg commented on the issue:
https://github.com/apache/tinkerpop/pull/448
Thanks Marko.
Rebased again. Also removed print statement from one test and updated
Python tests to use `unittest.TestCase` assertions.
---
If your project is set up for it, you can reply t
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/448
This looks good. However, can you please rebase with `master/` as there
have been some changes to `graphson.py`. Also, if there is anything that needs
to be added to `gremlin-variants.asciidoc` abou
24 matches
Mail list logo
