Questions about the ajp1.3 connector

2011-06-15 Thread 姚伟斌
Hi, folks, I have some questions about the ajp1.3 connector. Is there any other official document for ajp1.3 connector? This url ( http://tomcat.apache.org/connectors-doc/ajp/ajpv13a.html) seems lack of something. In Send Body Chunk Packet, Is always there an extra zero byte with each packet

Re: [VOTE] Release Apache Tomcat 7.0.16

2011-06-15 Thread Mark Thomas
On 11/06/2011 12:33, Mark Thomas wrote: The proposed Apache Tomcat 7.0.16 release is now available for voting. It can be obtained from: http://people.apache.org/~markt/dev/tomcat-7/v7.0.16/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_16/ The proposed

DO NOT REPLY [Bug 51306] NPE in DeltaRequest.writeExternal(DeltaRequest.java:267) when handling remote session expiration

2011-06-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51306 --- Comment #8 from Ronald Klop ron...@echteman.nl 2011-06-15 08:59:35 UTC --- I have customers who are 'logged out' in their words and that correlates with the times of these errors in the logs. No hard evidence though. And the weirdest

[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2011-06-15 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This

DO NOT REPLY [Bug 51376] New: Dynamically added Servlet instances ignore setLoadOnStartup(), @ServletSecurity, etc

2011-06-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51376 Bug #: 51376 Summary: Dynamically added Servlet instances ignore setLoadOnStartup(), @ServletSecurity, etc Product: Tomcat 7 Version: 7.0.14 Platform: PC

DO NOT REPLY [Bug 51376] Dynamically added Servlet instances ignore setLoadOnStartup(), @ServletSecurity, etc

2011-06-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51376 --- Comment #1 from Mark Thomas ma...@apache.org 2011-06-15 12:04:43 UTC --- (In reply to comment #0) * @ServletSecurity is ignored This is as required by the Servlet spec (section 13.4.1) so this aspect of the bug report is INVALID.

svn commit: r1136010 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/juli/ClassLoaderLogManager.java test/org/apache/juli/ webapps/docs/changelog.xml

2011-06-15 Thread kkolinko
Author: kkolinko Date: Wed Jun 15 12:20:01 2011 New Revision: 1136010 URL: http://svn.apache.org/viewvc?rev=1136010view=rev Log: Improve system property replacement code in ClassLoaderLogManager of Tomcat JULI. Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=51249 1. Do not use

DO NOT REPLY [Bug 51249] JULI ClassLoaderLogManager doesn't properly handle ${} when replacing property values

2011-06-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51249 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added Status|NEW

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2011-06-15 Thread Konstantin Kolinko
The failure happened in [junit] Test org.apache.catalina.core.TestAsyncContextImpl FAILED when running with NIO. Running the same test with BIO was OK. The log file from the test is [1]. [1]:

DO NOT REPLY [Bug 51376] Dynamically added Servlet instances ignore setLoadOnStartup(), @ServletSecurity, etc

2011-06-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51376 --- Comment #2 from Mark Thomas ma...@apache.org 2011-06-15 12:48:20 UTC --- The Servlet TCK still passes with my change in place so I am going to go ahead and commit it to fix this issue. I'll be a little while as I need to write a test

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2011-06-15 Thread Mark Thomas
On 15/06/2011 13:29, Konstantin Kolinko wrote: The failure happened in [junit] Test org.apache.catalina.core.TestAsyncContextImpl FAILED when running with NIO. Running the same test with BIO was OK. The log file from the test is [1]. [1]:

svn commit: r1136017 - /tomcat/trunk/webapps/docs/setup.xml

2011-06-15 Thread markt
Author: markt Date: Wed Jun 15 12:55:24 2011 New Revision: 1136017 URL: http://svn.apache.org/viewvc?rev=1136017view=rev Log: Fix typo reported by @earthgecko Modified: tomcat/trunk/webapps/docs/setup.xml Modified: tomcat/trunk/webapps/docs/setup.xml URL:

svn commit: r1136024 - in /tomcat: tc5.5.x/trunk/container/webapps/docs/setup.xml tc6.0.x/trunk/webapps/docs/setup.xml

2011-06-15 Thread kkolinko
Author: kkolinko Date: Wed Jun 15 13:16:06 2011 New Revision: 1136024 URL: http://svn.apache.org/viewvc?rev=1136024view=rev Log: Backport of r1136017 Fix typo in documentation reported by @earthgecko Modified: tomcat/tc5.5.x/trunk/container/webapps/docs/setup.xml

svn commit: r1136028 - in /tomcat/trunk: java/org/apache/catalina/core/StandardWrapper.java test/org/apache/catalina/core/TestStandardContext.java webapps/docs/changelog.xml

2011-06-15 Thread markt
Author: markt Date: Wed Jun 15 13:21:16 2011 New Revision: 1136028 URL: http://svn.apache.org/viewvc?rev=1136028view=rev Log: (empty) Modified: tomcat/trunk/java/org/apache/catalina/core/StandardWrapper.java tomcat/trunk/test/org/apache/catalina/core/TestStandardContext.java

DO NOT REPLY [Bug 51376] Dynamically added Servlet instances ignore setLoadOnStartup(), @ServletSecurity, etc

2011-06-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51376 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

DO NOT REPLY [Bug 50677] Allow system property variables in catalina.properties

2011-06-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50677 --- Comment #4 from Konstantin Kolinko knst.koli...@gmail.com 2011-06-15 13:28:20 UTC --- One more discussion at users@: http://tomcat.markmail.org/thread/4hjo26xeqcuixyw4 tomcat 7: common.loader property in catalina.properties does not

svn commit: r1136043 - in /tomcat/trunk: java/org/apache/catalina/startup/Bootstrap.java webapps/docs/changelog.xml

2011-06-15 Thread kkolinko
Author: kkolinko Date: Wed Jun 15 13:51:03 2011 New Revision: 1136043 URL: http://svn.apache.org/viewvc?rev=1136043view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50677 Allow ANT style variables in the common.loader and other *.loader properties in conf/catalina.properties

DO NOT REPLY [Bug 50677] Allow system property variables in catalina.properties

2011-06-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50677 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added Status|NEW

svn commit: r1136070 - /tomcat/trunk/conf/catalina.properties

2011-06-15 Thread kkolinko
Author: kkolinko Date: Wed Jun 15 14:32:08 2011 New Revision: 1136070 URL: http://svn.apache.org/viewvc?rev=1136070view=rev Log: Add sunmscapi.jar to jarsToSkip I found it in version 6u25 of Oracle JDK and JRE on Windows 32-bit. Modified: tomcat/trunk/conf/catalina.properties Modified:

svn commit: r1136073 - in /tomcat/trunk: conf/logging.properties java/org/apache/jasper/resources/LocalStrings.properties webapps/docs/changelog.xml

2011-06-15 Thread kkolinko
Author: kkolinko Date: Wed Jun 15 14:48:11 2011 New Revision: 1136073 URL: http://svn.apache.org/viewvc?rev=1136073view=rev Log: Add to the logging.properties file a sample configuration setting for enabling debug messages in TldLocationsCache. Slightly improve the messages printed by

DO NOT REPLY [Bug 51376] Dynamically added Servlet instances ignore setLoadOnStartup(), @ServletSecurity, etc

2011-06-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51376 Artem Troitskiy axt...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED

DO NOT REPLY [Bug 51379] New: The method setVar(String) in the type DataTableTag is not applicable for the arguments (JspValueExpression)

2011-06-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51379 Bug #: 51379 Summary: The method setVar(String) in the type DataTableTag is not applicable for the arguments (JspValueExpression) Product: Tomcat 6 Version: 6.0.14

DO NOT REPLY [Bug 51379] The method setVar(String) in the type DataTableTag is not applicable for the arguments (JspValueExpression)

2011-06-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51379 --- Comment #1 from Kallol kallol.chaudh...@tcs.com 2011-06-15 15:03:58 UTC --- Created attachment 27160 -- https://issues.apache.org/bugzilla/attachment.cgi?id=27160 This is the test project developed using eclipse 3.4 and Apache Tomcat

svn commit: r1136090 - in /tomcat/trunk/java/org/apache/coyote/ajp: AjpAprProcessor.java AjpAprProtocol.java

2011-06-15 Thread markt
Author: markt Date: Wed Jun 15 15:43:53 2011 New Revision: 1136090 URL: http://svn.apache.org/viewvc?rev=1136090view=rev Log: Align code between connectors in preparation for pulling code up to the superclass No need to pass the socket into the asyncDispatch() call. It will always have been set

svn commit: r1136091 - in /tomcat/trunk/java/org/apache/coyote/ajp: AjpNioProcessor.java AjpProcessor.java

2011-06-15 Thread markt
Author: markt Date: Wed Jun 15 15:46:54 2011 New Revision: 1136091 URL: http://svn.apache.org/viewvc?rev=1136091view=rev Log: Align code between connectors in preparation for pulling code up to the superclass Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpNioProcessor.java

svn commit: r1136099 - /tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java

2011-06-15 Thread markt
Author: markt Date: Wed Jun 15 15:56:59 2011 New Revision: 1136099 URL: http://svn.apache.org/viewvc?rev=1136099view=rev Log: Align code between connectors in preparation for pulling code up to the superclass When returning SocketState.CLOSED, recycle is always called Modified:

Re: [VOTE] Release Apache Tomcat 7.0.16

2011-06-15 Thread Yoav Shapira
On Sat, Jun 11, 2011 at 7:33 AM, Mark Thomas ma...@apache.org wrote: The proposed Apache Tomcat 7.0.16 release is now available for voting. It can be obtained from: http://people.apache.org/~markt/dev/tomcat-7/v7.0.16/ The svn tag is:

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2011-06-15 Thread Rainer Jung
On 15.06.2011 14:49, Mark Thomas wrote: On 15/06/2011 13:29, Konstantin Kolinko wrote: The failure happened in [junit] Test org.apache.catalina.core.TestAsyncContextImpl FAILED when running with NIO. Running the same test with BIO was OK. The log file from the test is [1]. [1]:

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2011-06-15 Thread Rainer Jung
On 15.06.2011 14:49, Mark Thomas wrote: On 15/06/2011 13:29, Konstantin Kolinko wrote: The failure happened in [junit] Test org.apache.catalina.core.TestAsyncContextImpl FAILED when running with NIO. Running the same test with BIO was OK. The log file from the test is [1]. [1]:

svn commit: r1136106 - in /tomcat/trunk/java/org/apache/coyote/ajp: AjpNioProcessor.java AjpProcessor.java

2011-06-15 Thread markt
Author: markt Date: Wed Jun 15 16:19:06 2011 New Revision: 1136106 URL: http://svn.apache.org/viewvc?rev=1136106view=rev Log: Align code between connectors in preparation for pulling code up to the superclass No need to close the AJP connection if there was no error Modified:

svn commit: r1136108 - in /tomcat/trunk/java/org/apache/coyote/ajp: AbstractAjpProcessor.java AjpAprProcessor.java AjpNioProcessor.java AjpProcessor.java

2011-06-15 Thread markt
Author: markt Date: Wed Jun 15 16:24:42 2011 New Revision: 1136108 URL: http://svn.apache.org/viewvc?rev=1136108view=rev Log: Pull up asyncDispatch() Modified: tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java

Testfailures in Tomcat 7

2011-06-15 Thread Christoph Pater
Hi, I'm Christoph, a java developer from cologne, germany. I had a little free time and checked out the tomcat trunk. I want to look at the code and maybe use my further free time to do some bugfixes to contribute. So the ant build runs fine and I integrated the sources in eclipse. But when I

Re: Crash in APR when pausing endpoint

2011-06-15 Thread Christopher Schultz
Rainer, On 6/13/2011 11:49 AM, Mark Thomas wrote: Analysis and patch make sense to me. +1 Nice analysis. Nice to see I'm not the only one who can code-up a nice race condition. -chris signature.asc Description: OpenPGP digital signature

Re: Testfailures in Tomcat 7

2011-06-15 Thread Mark Thomas
On 15/06/2011 21:11, Christoph Pater wrote: Hi, I'm Christoph, a java developer from cologne, germany. I had a little free time and checked out the tomcat trunk. I want to look at the code and maybe use my further free time to do some bugfixes to contribute. So the ant build runs fine

svn commit: r1136179 - in /tomcat/trunk: java/org/apache/catalina/core/StandardWrapper.java test/org/apache/catalina/core/TestStandardContext.java

2011-06-15 Thread markt
Author: markt Date: Wed Jun 15 20:32:14 2011 New Revision: 1136179 URL: http://svn.apache.org/viewvc?rev=1136179view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51376 Complete fix. Ensure Servlet.destroy() is only called if Servlet.init() was called. Modified:

DO NOT REPLY [Bug 51376] Dynamically added Servlet instances ignore setLoadOnStartup(), @ServletSecurity, etc

2011-06-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51376 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|REOPENED|RESOLVED

DO NOT REPLY [Bug 51379] The method setVar(String) in the type DataTableTag is not applicable for the arguments (JspValueExpression)

2011-06-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51379 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

DO NOT REPLY [Bug 51382] New: Link to download pages are broken

2011-06-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51382 Bug #: 51382 Summary: Link to download pages are broken Product: Taglibs Version: unspecified Platform: PC Status: NEW Severity: major Priority: P2

DO NOT REPLY [Bug 41539] NullPointerException during Embedded tomcat restart

2011-06-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=41539 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEEDINFO|RESOLVED

DO NOT REPLY [Bug 43538] [patch] Show the hostname and IP address in the manager webapp

2011-06-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43538 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1136216 - in /tomcat/trunk: java/org/apache/catalina/manager/ webapps/docs/

2011-06-15 Thread markt
Author: markt Date: Wed Jun 15 21:58:00 2011 New Revision: 1136216 URL: http://svn.apache.org/viewvc?rev=1136216view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43538 Add host name and IP address to the HTML Manager application. Patch by Dennis Lundberg. Modified:

DO NOT REPLY [Bug 48956] SSI regular expressions not working

2011-06-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48956 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1136231 - in /tomcat/trunk: java/org/apache/catalina/ssi/ExpressionParseTree.java webapps/docs/changelog.xml

2011-06-15 Thread markt
Author: markt Date: Wed Jun 15 22:44:00 2011 New Revision: 1136231 URL: http://svn.apache.org/viewvc?rev=1136231view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48956 Implement regular expression support for SSI Modified:

DO NOT REPLY [Bug 51379] The method setVar(String) in the type DataTableTag is not applicable for the arguments (JspValueExpression)

2011-06-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51379 --- Comment #3 from Kallol kallol.chaudh...@tcs.com 2011-06-16 04:50:18 UTC --- I wanted to report this as a bug only for eclipse 3.4 and Tomcat 6.0.14. There are several such similar issues raised by other people for which there have