arkanovicz commented on issue #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-616897939
> Can you retry with a vanilla Tomcat and the most recent curl?
I've spent enough time digging for this bug (to end up finding it in a SSE
dependency), including step by step
michael-o commented on issue #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-616852929
> I see. But at that point, you do not know who set up the header, so the
stack
> I see. But at that point, you do not know who set up the header, so the
stack trace won't be
michael-o edited a comment on issue #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-616852929
> I see. But at that point, you do not know who set up the header, so the
stack trace won't be informative.
Can you retry with a vanilla Tomcat and the most recent curl?
arkanovicz commented on issue #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-616850925
I see. But at that point, you do not know who set up the header, so the
stack trace won't be informative.
This is
On Mon, Apr 20, 2020 at 9:46 PM Mark Thomas wrote:
> Hi,
>
> I'm working in the issue reported on users@
>
> I've fixed the errors described there and have got to the point where
> StoreConfig.store(Context) is being called but the call fails if the
> Context doesn't already have a configuration
The Buildbot has detected a restored build on builder tomcat-9-trunk while
building tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-9-trunk/builds/181
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: asf946_ubuntu
Build Reason: The
michael-o commented on issue #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-616794864
We are talking about this code block:
https://github.com/apache/tomcat/blob/65bc61a466fdc4ccc0ee281bd411fca7cb11adb0/java/org/apache/coyote/http11/Http11Processor.java#L932-L956
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new c832182 Log a warning if adding CredentialHandler
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git.
from 6a313e9 Remove deprecated code
add 65bc61a Log a warning if adding CredentialHandler to CombinedRealm
No new
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new acd0cc3 Log a warning if addind CredentialHandler
michael-o edited a comment on issue #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-616789924
Why can't I reproduce it although I have an h2c response?!
This is an automated message from the Apache Git
michael-o commented on issue #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-616789924
Why can't I reproduce it although I have an h2c reponse?!
This is an automated message from the Apache Git Service.
To
arkanovicz commented on issue #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-616771727
@markt-asf This happens for instance in SSE components (tomcat does *not*
provide such components), or more generally in *any* J2EE filters or servlets,
coded before HTTP/2.0, which
Hi,
I'm working in the issue reported on users@
I've fixed the errors described there and have got to the point where
StoreConfig.store(Context) is being called but the call fails if the
Context doesn't already have a configuration file. Is this intended? The
docs suggest that the file will be
markt-asf commented on issue #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-616767803
That would also allow some clean up in the current code that sets the header
and has to take account of any value that may have been set by the application.
rmaucher commented on issue #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-616764169
Since it's now 2020, shouldn't it be doable to block any attempt to set the
connection header by the application ?
This
michael-o edited a comment on issue #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-616754168
I fail to see this issue:
Pure:
```
$ curl --http2 -NvIsq http://localhost:8080
HTTP/1.1 101
Connection: Upgrade
Upgrade: h2c
Date: Mon, 20 Apr 2020
michael-o commented on issue #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-616754168
I fail to see this issue:
Pure:
```
$ curl --http2 -NvIsq http://localhost:8080
HTTP/1.1 101
Connection: Upgrade
Upgrade: h2c
Date: Mon, 20 Apr 2020 19:10:48 GMT
Am 2020-04-20 um 15:11 schrieb Konstantin Kolinko:
пн, 20 апр. 2020 г. в 11:05, Mark Thomas :
On 18/04/2020 20:59, micha...@apache.org wrote:
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch 7.0.x
in repository
rmaucher commented on issue #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-616745834
-1
Tomcat covers the most egregious cases, but this is probably not one of
them. Even in HTTP/1.1, what the application does setting this connection
header is nonsense and will never
markt-asf commented on issue #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-616745000
I'm curious why applications think they need to set the connection header.
I'd expect the container to handle this. Further, applications that want to set
this header can/should use
arkanovicz commented on issue #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-616715639
Of course, you will need to actually *add* the faulty header to the response
to see this error.
This is an
arkanovicz commented on issue #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-616714936
@michael-o curl example:
$ curl --http2 -Nv "https://some.http2.url/;
* Trying 127.0.0.1:8833...
* TCP_NODELAY set
* Connected to some.http2.url
michael-o commented on issue #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-616689787
Can you show your sample curl input/output?
This is an automated message from the Apache Git Service.
To respond to the
arkanovicz opened a new pull request #277:
URL: https://github.com/apache/tomcat/pull/277
Connection headers like `Connection: keep-alive` are invalid in HTTP/2.0,
and some clients (like Safari or curl) are very touchy about it.
When an application component adds the typical
https://bz.apache.org/bugzilla/show_bug.cgi?id=63191
--- Comment #16 from Boris Petrov ---
Just a heads up. The same still happens on Tomcat 9.0.34 and CometD 5 (on 4
too). Doesn't happen *at all* when using CometD 3 (which uses blocking IO).
--
You are receiving this mail because:
You are the
On 20/04/2020 10:45, Rainer Jung wrote:
> Hi Mark, hi all,
>
> Am 20.04.2020 um 11:15 schrieb Mark Thomas:
>> On 19/04/2020 14:04, Rainer Jung wrote:
>>> It might be too simplistic, but the following at least stops the
>>> connection close (but I don't know, whether it also prevents it in cases
prankkelkar opened a new pull request #276:
URL: https://github.com/apache/tomcat/pull/276
As Travis CI [officially
supports](https://blog.travis-ci.com/2019-11-12-multi-cpu-architecture-ibm-power-ibm-z)
s390x builds, adding support for same.
Changes:
* Added s390x to build
пн, 20 апр. 2020 г. в 11:05, Mark Thomas :
>
> On 18/04/2020 20:59, micha...@apache.org wrote:
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > michaelo pushed a commit to branch 7.0.x
> > in repository https://gitbox.apache.org/repos/asf/tomcat.git
> >
> >
> > The
pzygielo commented on a change in pull request #275:
URL: https://github.com/apache/tomcat/pull/275#discussion_r410846802
##
File path: java/org/apache/catalina/loader/WebappClassLoaderBase.java
##
@@ -1813,35 +1813,40 @@ private void clearReferencesThreads() {
govi20 edited a comment on issue #275:
URL: https://github.com/apache/tomcat/pull/275#issuecomment-616538397
Thanks for the feedback. Looks like the first two steps are already covered
in the code. Small refactoring would be to ensure interrupt is **not** called
on executor thread.
govi20 commented on issue #275:
URL: https://github.com/apache/tomcat/pull/275#issuecomment-616538397
Looks like the first two steps are already covered in the code. Small
refactoring would be to ensure interrupt is not called on executor thread.
```
if (!usingExecutor &&
The Buildbot has detected a new failure on builder tomcat-9-trunk while
building tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-9-trunk/builds/180
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: asf946_ubuntu
Build Reason: The
Am 2020-04-20 um 11:11 schrieb Rémy Maucherat:
On Mon, Apr 20, 2020 at 10:58 AM Michael Osipov wrote:
Am 2020-04-20 um 10:05 schrieb Mark Thomas:
On 18/04/2020 20:59, micha...@apache.org wrote:
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to
Am 2020-04-20 um 11:32 schrieb Mark Thomas:
On 20/04/2020 09:52, Michael Osipov wrote:
Am 2020-04-19 um 17:32 schrieb Rainer Jung:
Hi Michael,
Am 19.04.2020 um 17:11 schrieb Michael Osipov:
Am 2020-04-19 um 14:40 schrieb Rainer Jung:
I observed this when using Apache mod_proxy_http and
Hi Mark, hi all,
Am 20.04.2020 um 11:15 schrieb Mark Thomas:
On 19/04/2020 14:04, Rainer Jung wrote:
It might be too simplistic, but the following at least stops the
connection close (but I don't know, whether it also prevents it in cases
where it should still be done):
diff --git
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 6a313e99d4b46c8b8d5193c3112b440f3fac8e7f
Author: Mark Thomas
AuthorDate: Mon Apr 20 10:36:25 2020 +0100
Remove
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 001104b731c6c3df30d0cbf70b3d305e2f736f46
Author: Mark Thomas
AuthorDate: Mon Apr 20 10:36:10 2020 +0100
Refactor to
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git.
from 66468c8 Add missing closing tag
new 001104b Refactor to allow removal of Constants class
new 6a313e9
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 0ee74f4 Refactor to allow removal of Constants
On 20/04/2020 09:52, Michael Osipov wrote:
> Am 2020-04-19 um 17:32 schrieb Rainer Jung:
>> Hi Michael,
>>
>> Am 19.04.2020 um 17:11 schrieb Michael Osipov:
>>> Am 2020-04-19 um 14:40 schrieb Rainer Jung:
I observed this when using Apache mod_proxy_http and
mod_proxy_balancer with
On 19/04/2020 14:04, Rainer Jung wrote:
> It might be too simplistic, but the following at least stops the
> connection close (but I don't know, whether it also prevents it in cases
> where it should still be done):
>
> diff --git a/java/org/apache/coyote/http11/Http11Processor.java
>
On Mon, Apr 20, 2020 at 10:58 AM Michael Osipov wrote:
> Am 2020-04-20 um 10:05 schrieb Mark Thomas:
> > On 18/04/2020 20:59, micha...@apache.org wrote:
> >> This is an automated email from the ASF dual-hosted git repository.
> >>
> >> michaelo pushed a commit to branch 7.0.x
> >> in repository
Am 2020-04-20 um 10:05 schrieb Mark Thomas:
On 18/04/2020 20:59, micha...@apache.org wrote:
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were
Am 2020-04-20 um 10:25 schrieb Mark Thomas:
On 18/04/2020 21:19, Michael Osipov wrote:
Folks,
the WebDAV servlet still sends a reason phrase on multistatus (207).I'd
like to drop it in master and 9.0.x. It is inconsistent with the
behavior with these versions. Any objections/opinions on
Am 2020-04-19 um 17:32 schrieb Rainer Jung:
Hi Michael,
Am 19.04.2020 um 17:11 schrieb Michael Osipov:
Am 2020-04-19 um 14:40 schrieb Rainer Jung:
I observed this when using Apache mod_proxy_http and
mod_proxy_balancer with ping=5000, which wil add the expectation to
any POST request. I
markt-asf commented on issue #275:
URL: https://github.com/apache/tomcat/pull/275#issuecomment-616400683
Thanks for the updates. Exactly the sort of thing I had in mind.
Looking at the updated code, I'm wondering whether a slightly wider
refactoring makes sense. Something like:
-
On 18/04/2020 21:19, Michael Osipov wrote:
> Folks,
>
> the WebDAV servlet still sends a reason phrase on multistatus (207).I'd
> like to drop it in master and 9.0.x. It is inconsistent with the
> behavior with these versions. Any objections/opinions on dropping it?
I agree it is inconsistent
On Mon, Apr 20, 2020 at 10:58 AM Martin Grigorov
wrote:
> Hi,
>
> On Mon, Apr 20, 2020 at 3:03 AM wrote:
>
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> ebourg pushed a commit to branch master
>> in repository
>>
On 18/04/2020 20:59, micha...@apache.org wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> michaelo pushed a commit to branch 7.0.x
> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>
>
> The following commit(s) were added to refs/heads/7.0.x by this
https://bz.apache.org/bugzilla/show_bug.cgi?id=64355
Remy Maucherat changed:
What|Removed |Added
Resolution|--- |INVALID
Status|REOPENED
Hi,
On Mon, Apr 20, 2020 at 3:03 AM wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> ebourg pushed a commit to branch master
> in repository
> https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git
>
> commit f23a64982f793ebe43665466cf780f57979e63d4
>
52 matches
Mail list logo
