Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/137
> Anyway, those package.html files are just fragments consumed by javadoc
tool. I suspect that changing the attributes of the HTML element does not have
any effect on generated Java
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/137
I'm all in favour of improving accessibility.
The changes to package.html and similar look good.
The changes to anything under test/ need to be reverted. Those are test
artefacts
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/135
This has been fixed via
[POEditor](https://poeditor.com/projects/view?id=221603) and will be included
in 9.0.15 onwards
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/135
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/134
I tried adding a Last-Modified HTTP header but that didn't help. The
history approach looks to be the best solution at this point
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/134
The browser history will give you what you need (to the minute anyway) in
both Chrome Firefox and IE. This is a generic solution that works for any web
page for any service - not just one page
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/134
How easy it is to get hold of the last modified date does vary by browser
but - given that Tomcat already provides this in the headers - I don't see much
benefit here. And micheal-o's comment
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/132
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/132
Fixed in:
- trunk for 9.0.14 onwards
- 8.5.x for 8.5.36 onwards
- 7.0.x for 7.0.93 onwards
Thanks for the report and for the patch
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/131
Spam. Reported to GitHub's abuse team.
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/131
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/130
I can see what you are trying to do but I'm not sure the change creates
enough of a visual separation to make much of a difference. I don't think it
will do much to reduce the risk
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/125
Patch has been applied with a few changes:
- portOffset was not cached on the Connector (to align with recent changes
to how port is handled)
- handle special case port values where
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/129
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/129
Thanks. Patch applied to 9.0.x, 8.5.x and 7.0.x for the next release of
each.
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/125
I've now spent some time looking at this more closely.
I like the idea of setting this once on the `Server` and then
auto-magically setting this on the `Connector`s.
As I reviewed
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/123
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/123
Thanks for reviewing this code and providing a patch. Unfortunately, we
plan to shortly move away from our custom signing service and switch to the
solution provided by DigiCert that integrates
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/127
Nice idea. I've applied a variation of this patch to Tomcat. The key
changes were:
- Only ignore source on Context elements
- Ignore source on Context elements in server.xml and context.xml
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/126
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/126
-1 here too for much the same reason. A filter would work better for this.
Ignoring the thread related concerns, I'd also point out that new features
without a description of the use case
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/125
I've skimmed this and it looks good. I'm currently buried in TLS 1.3 stuff
but wanted to let you know that the PR had been seen and that I hope to get it
into the next 9.0.x release
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/124
Nice catch with handling the port. The patch I had come up with missed that.
I refactored populateHost() as it bugged me to set the server name one way
(that might throw an IOE and break
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/122
There is nothing in the spec that says Tomcat is required to do that.
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/122
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/122
Closing the PR as the requested change is not correct.
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/120
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/120
The double = is deliberate. The OP needs to RTFM.
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/117
Looks great. Applied. Many thanks.
(note: there was one s/HOME/BASE/ required in the webapps section)
---
-
To unsubscribe
Github user markt-asf commented on a diff in the pull request:
https://github.com/apache/tomcat/pull/117#discussion_r20982
--- Diff: webapps/docs/introduction.xml ---
@@ -89,6 +80,122 @@ same as $CATALINA_HOME.
+
+ Throughout the documentation
Github user markt-asf commented on a diff in the pull request:
https://github.com/apache/tomcat/pull/117#discussion_r209308073
--- Diff: webapps/docs/introduction.xml ---
@@ -89,6 +80,122 @@ same as $CATALINA_HOME.
+
+ Throughout the documentation
Github user markt-asf commented on a diff in the pull request:
https://github.com/apache/tomcat/pull/117#discussion_r209306777
--- Diff: webapps/docs/introduction.xml ---
@@ -89,6 +80,122 @@ same as $CATALINA_HOME.
+
+ Throughout the documentation
Github user markt-asf commented on a diff in the pull request:
https://github.com/apache/tomcat/pull/118#discussion_r209292288
--- Diff: java/org/apache/catalina/ha/session/SessionMessageImpl.java ---
@@ -144,7 +144,7 @@ public String getEventTypeString()
case
Github user markt-asf commented on a diff in the pull request:
https://github.com/apache/tomcat/pull/118#discussion_r209290720
--- Diff: java/org/apache/tomcat/dbcp/dbcp2/managed/ManagedConnection.java
---
@@ -1,4 +1,4 @@
-/**
+vi /**
--- End diff
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/118
Thanks for this. Working through a review of the patch now.
Note that there are some files that we can't change such as the Oracle
provided XSDs
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/115
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/115
Thanks for the PR. We have fixed this but with a simpler approach that
makes use of `ConcurrentDateFormat.formatRfc1123
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/77
These have been resolved since this PR was opened.
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/77
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/49
Thanks for the patch. Sorry it took a while to apply it. Due to our delays
I had to adapt things a little.
Fixed in:
- trunk for 9.0.9 onwards
- 8.5.x for 8.5.32 onwards
- 8.0.x
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/49
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/111
The docs (`config/valve.xml` and `config/filter.xml`) need to be updated
with the new defaults as well.
---
-
To unsubscribe
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/108
I agree this should configurable on the Host.
It should be possible to remove the Comparator entirely if the version code
is used directly in the Mapper.
I'd like this to be more robust
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/109
I came very close to fixing this but in the end I opted not to.
I covered the argument for making this change in my previous comment. The
reasons against it are:
- it would
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/109
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/109
The specification is not as explicit as it could be in this case. The spec
text refers to the Javadoc. The Javadoc says "Returns the resource located at
the named path as an InputStream o
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/109
I'm not convinced the proposed approach is the right one in this case.
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/108
I think there is a lot of merit in Chris's idea. The concept of some sort
of internal pre-computed version string that addresses ordering concerns by
zero padding numerical components is one
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/108
I have applied the optimisation commit (thanks) but not the ordering
changes.
The patch changes the order for undeploy without changing the order for
version mapping. This will lead
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/105
This needs some discussion on the dev@ list.
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/102
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/101
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/101
Thanks for the report and the patch. Fixed for trunk and 8.5.x.
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/97
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/97
All updated.
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/97
Thanks looks great. I'll add it shortly. I'll apply to all versions and
then tweak the various version specific parts so they reflect the current
version
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/96
I've fixed this in trunk. Given the behaviour changes (you can bet someone
depends on a 403 rather than a 405 response) I'm not going to back-port it.
The way I ended up tackling this (WebDAV
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/96
No argument with Konstantin's points here. I started to look at
implementing this and I realised that the WebDAV is inconsistent with how the
allow header is generated. A method may not be included
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/96
Lack of response == lazy consensus. I plan to look at applying these
patches (or possibly a variation of them) before tagging 9.0.x
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/96
Getting back to whether readOnly should affect POST, my own view is that it
should not. readOnly refers to whether the default Servlet can change static
content. For static content request
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/96
I wanted to clear something up. It is not a case of me being willing to
change something or not. I don't get to decide these things on my own. It is a
community decision. Normally, we discuss
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/96
The inconsistency stems from the different status codes used. If TRACE is
disabled at the connector, level then a 405 is returned for TRACE requests. If
readOnly is set in the DefaultServlet, a 403
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/96
The current OPTIONS behaviour is intentional.
OPTIONS lists the valid methods, not the permitted methods, for a resource.
The GET/POST issue is before my time with the project
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/95
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/95
Thanks for the patch. There wasn't anything wrong with it but the more I
thought about it, the more I thought that referencing the DTD directly was a
better solution
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/95
This is a partial fix. It only addresses the attributes of the mbean
element.
I'm wondering if, rather than duplicate the comments in the DTD file, if it
would be simpler to copy the DTD
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/87
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/87
Applied in r1815802
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/85
Note there is a minor typo in the test method name. I'll fix that when I
apply the patch.
---
-
To unsubscribe, e-mail: dev
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/73
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/76
Looking at this is on my TODO list to look at before the next release
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/84
This needs a wider discussion on the dev list first.
However I do have some initial high level comments:
- The choice of package is unexpected
- Headers need to be standard ASF
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/83
Thanks for the proposed patch. I opted for a more general solution in
StringUtils since fixing that problem there should - in theory - prevent it
appearing anywhere else StringUtils is used
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/83
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/82
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/83
The duplicated code is a sign that this could be handled elsewhere with
less code (i.e. in StringUtils)
---
-
To unsubscribe, e
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/79
We could pull the entries and add "That's it!" after the list.
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/79
Those aren't placeholders. It is intentional content. I believe they are
meant to be a lighthearted way of indicating that 'Context' is the only term
that needs introducing
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/73
No objections to back-porting here.
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/78
Thanks. Patch applied to trunk and back-ported to 8.5.x, 8.0.x and 7.0.x.
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/78
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/77
Making those classes final will cause problems if users have extended any
of them. While that seems unlikely, experience suggests it has probably been
done somewhere. Is there any reason
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/76
I did wonder if this would be better as configuration on WsFilter but on
reflection a separate Filter looks to be simpler for users to configure.
The patch needs documentation (webapps/docs
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/73
Chris's original concern with the BZ 57767 patch (lack of Javadoc) still
needs to be addressed.
---
-
To unsubscribe, e-mail
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/63
I've added some comments to the bugzilla issue on how this might be
addressed.
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/74
I think I've pulled the obvious wins into Tomcat. Take a look and if you
think there is merit in further changes please feel free to open another pull
request
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/74
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/74
There is definitely some value here although we might not choose to skip
some parts of the patch. Let me pull in the obvious stuff and then we can see
what is left
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/74
Generally, I'm in favour of refactoring that reduces the overall volume of
code.
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/75
-1
The public API of specification defined classes may not be changed.
This method would be worth adding to o.a.catalina.filters.FilterBase if any
of Tomcat's internal filter implementations
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/72
My point is that with the o.a.c.webresources.Cache in place, this solution
offers little additional benefit. I'm not suggesting creating dependencies from
Jasper to Catalina.
On closer
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/72
Tomcat provides (by default) a static content cache in the resources layer
so I do wonder if there is much benefit in caching the content in the JSP
engine as well.
The proposed cache appears
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/70
Patch applied. Many thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/70
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user markt-asf commented on a diff in the pull request:
https://github.com/apache/tomcat/pull/70#discussion_r129111529
--- Diff: java/org/apache/catalina/valves/AbstractAccessLogValve.java ---
@@ -1506,6 +1508,38 @@ public void addElement(CharArrayWriter buf, Date
date
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/5
As requested.
Note: normally projects can't close PRs like this but I can because of my
infra role.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/68
Tomcat fails to compile after applying this patch.
Looking in to this, I don't see any reason for BaseModelMBean to throw
exceptions in its constructor. As far as I can tell
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/65
My favourite kind of patch. It fixes a problem by deleting stuff. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/59
Most added comments add no value. The s/poller/pollers/ change is the only
one worth considering and that is a trivial change.
The patch uses a mix of tabs and spaces for indents.
---
If your
1 - 100 of 133 matches
Mail list logo
