Re: Stabilizing the trunk (9.0.x) build

2015-03-02 Thread Mark Thomas
On 27/02/2015 15:01, Mark Thomas wrote: On 27/02/2015 14:42, Christopher Schultz wrote: On 2/27/15 7:00 AM, Mark Thomas wrote: snip/ There is also an issue with APR on Linux that I can reproduce (with some code changes) that triggers a crash every couple of runs. Next time is happens, can

Re: Stabilizing the trunk (9.0.x) build

2015-02-27 Thread Christopher Schultz
Mark, On 2/27/15 7:00 AM, Mark Thomas wrote: Another update. I think I am getting close to being able to commit these changes[1]. The current status is: - NIO appears to pass on Windows, OSX and Linux - APR appears to pass on OSX and Linux - APR unknown on Windows - NIO2 appears to pass

Re: Stabilizing the trunk (9.0.x) build

2015-02-27 Thread Mark Thomas
On 27/02/2015 14:42, Christopher Schultz wrote: Mark, On 2/27/15 7:00 AM, Mark Thomas wrote: Another update. I think I am getting close to being able to commit these changes[1]. The current status is: - NIO appears to pass on Windows, OSX and Linux - APR appears to pass on OSX and Linux

Re: Stabilizing the trunk (9.0.x) build

2015-02-27 Thread Rémy Maucherat
2015-02-27 13:00 GMT+01:00 Mark Thomas ma...@apache.org: Another update. I think I am getting close to being able to commit these changes[1]. The current status is: - NIO appears to pass on Windows, OSX and Linux - APR appears to pass on OSX and Linux - APR unknown on Windows - NIO2

Re: Stabilizing the trunk (9.0.x) build

2015-02-27 Thread Mark Thomas
Another update. I think I am getting close to being able to commit these changes[1]. The current status is: - NIO appears to pass on Windows, OSX and Linux - APR appears to pass on OSX and Linux - APR unknown on Windows - NIO2 appears to pass on OSX and Linux - NIO2 hanging on Windows I say

Re: Stabilizing the trunk (9.0.x) build

2015-02-26 Thread Mark Thomas
On 26/02/2015 21:58, Christopher Schultz wrote: Mark, On 2/23/15 4:16 AM, Mark Thomas wrote: Given that it is my changes that have triggered the problems I think I have a responsibility to fix them (and intend to do so over) but I'm not going to say no if anyone wants to pitch in.

Re: Stabilizing the trunk (9.0.x) build

2015-02-26 Thread Mark Thomas
On 26/02/2015 12:25, Rémy Maucherat wrote: 2015-02-26 11:42 GMT+01:00 Mark Thomas ma...@apache.org: What I have at the moment is at: https://github.com/markt-asf/tomcat/tree/markt-trunk I'm currently running the unit tests. Looking good. Better, certainly. NIO tests pass on Windows,

Re: Stabilizing the trunk (9.0.x) build

2015-02-26 Thread Rémy Maucherat
2015-02-26 17:40 GMT+01:00 Mark Thomas ma...@apache.org: Better, certainly. NIO tests pass on Windows, Linux and OSX. Very good ! I've found a bug in NIO2 + SSL that is fairly common on Linux/OSX that I have fixed and am re-running the tests. Aw, *another* one ? I haven't really

Re: Stabilizing the trunk (9.0.x) build

2015-02-26 Thread Mark Thomas
On 26/02/2015 17:34, Rémy Maucherat wrote: 2015-02-26 17:40 GMT+01:00 Mark Thomas ma...@apache.org: Better, certainly. NIO tests pass on Windows, Linux and OSX. Very good ! I've found a bug in NIO2 + SSL that is fairly common on Linux/OSX that I have fixed and am re-running the

Re: Stabilizing the trunk (9.0.x) build

2015-02-26 Thread Mark Thomas
On 25/02/2015 19:32, Rémy Maucherat wrote: 2015-02-25 19:36 GMT+01:00 Mark Thomas ma...@apache.org: I was planning on waiting until the build was stable but given that: - read/write concurrency is at the root of a lot of these issues - only WebSocket should be using it now in trunk - the

Re: Stabilizing the trunk (9.0.x) build

2015-02-26 Thread Rémy Maucherat
2015-02-26 11:42 GMT+01:00 Mark Thomas ma...@apache.org: What I have at the moment is at: https://github.com/markt-asf/tomcat/tree/markt-trunk I'm currently running the unit tests. Looking good. Rémy

Re: Stabilizing the trunk (9.0.x) build

2015-02-26 Thread Christopher Schultz
Mark, On 2/23/15 4:16 AM, Mark Thomas wrote: Given that it is my changes that have triggered the problems I think I have a responsibility to fix them (and intend to do so over) but I'm not going to say no if anyone wants to pitch in. Therefore, I'm starting this thread so that we can

Re: Stabilizing the trunk (9.0.x) build

2015-02-25 Thread Rémy Maucherat
2015-02-24 16:33 GMT+01:00 Mark Thomas ma...@apache.org: On 24/02/2015 13:10, Rémy Maucherat wrote: I'm having issues with the write timeout tests in TestWsWebSocketContainer, which made me do some changes since there are still things I don't understand: These appear to be OK for me at

Re: Stabilizing the trunk (9.0.x) build

2015-02-25 Thread Mark Thomas
On 25/02/2015 14:31, Rémy Maucherat wrote: 2015-02-24 16:33 GMT+01:00 Mark Thomas ma...@apache.org: On 24/02/2015 13:10, Rémy Maucherat wrote: I'm having issues with the write timeout tests in TestWsWebSocketContainer, which made me do some changes since there are still things I don't

Re: Stabilizing the trunk (9.0.x) build

2015-02-25 Thread Rémy Maucherat
2015-02-25 19:36 GMT+01:00 Mark Thomas ma...@apache.org: I was planning on waiting until the build was stable but given that: - read/write concurrency is at the root of a lot of these issues - only WebSocket should be using it now in trunk - the plan is to refactor WebSocket to remove it

Re: Stabilizing the trunk (9.0.x) build

2015-02-24 Thread Mark Thomas
Progress is being made. TestWsWebSocketContainer.testMaxMessageSize04() is fixed. I do want to come back to exactly how/if flushing is performed on ServletOutputStream.close() but I plan on parking that until the other failures are fixed. Next on my list is TestUpgrade.testMessagesBlocking(). I

Re: Stabilizing the trunk (9.0.x) build

2015-02-24 Thread Rainer Jung
Am 24.02.2015 um 10:01 schrieb Mark Thomas: On a related topic the Gump OpenSSL tests are still failing. They pass when run directly from the command line on vmgump.a.o. I can't come up with a better idea than adding some debugging to the tests. I installed OpenSSL master (current snapshot)

Re: Stabilizing the trunk (9.0.x) build

2015-02-24 Thread Mark Thomas
On 24/02/2015 09:01, Mark Thomas wrote: Progress is being made. TestWsWebSocketContainer.testMaxMessageSize04() is fixed. I do want to come back to exactly how/if flushing is performed on ServletOutputStream.close() but I plan on parking that until the other failures are fixed. Next on

Re: Stabilizing the trunk (9.0.x) build

2015-02-24 Thread Rémy Maucherat
2015-02-24 10:01 GMT+01:00 Mark Thomas ma...@apache.org: Progress is being made. TestWsWebSocketContainer.testMaxMessageSize04() is fixed. I do want to come back to exactly how/if flushing is performed on ServletOutputStream.close() but I plan on parking that until the other failures are

Re: Stabilizing the trunk (9.0.x) build

2015-02-24 Thread Mark Thomas
On 24/02/2015 13:10, Rémy Maucherat wrote: I'm having issues with the write timeout tests in TestWsWebSocketContainer, which made me do some changes since there are still things I don't understand: These appear to be OK for me at the moment with NIO and NIO2 but the very nature of timing

Re: Stabilizing the trunk (9.0.x) build

2015-02-23 Thread Mark Thomas
On 23/02/2015 10:40, Rémy Maucherat wrote: 2015-02-23 10:16 GMT+01:00 Mark Thomas ma...@apache.org: Given that it is my changes that have triggered the problems I think I have a responsibility to fix them (and intend to do so over) but I'm not going to say no if anyone wants to pitch in.

Re: Stabilizing the trunk (9.0.x) build

2015-02-23 Thread Rémy Maucherat
2015-02-23 10:16 GMT+01:00 Mark Thomas ma...@apache.org: Given that it is my changes that have triggered the problems I think I have a responsibility to fix them (and intend to do so over) but I'm not going to say no if anyone wants to pitch in. Therefore, I'm starting this thread so that we