Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-10 Thread Mark Thomas
On 09/08/2022 20:19, Christopher Schultz wrote: On 8/9/22 14:09, Mark Thomas wrote: This issue is the zip files. Time stamps in zip files use local (yes, local - I didn't mistype that) time. Hence you need to use the same time zone to get a repeatable build. We have a few options here:

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-10 Thread Han Li
Mark, Can I make a suggestion related to the ant build script. Can we add two properties to set the values of ` -Duser.language` and `-Duser.country`, because in the course of my testing I found that some of the unit test assertions are in English, but there may be cases where the values are

[GitHub] [tomcat] funkman commented on pull request #524: Dir redirect use301

2022-08-10 Thread GitBox
funkman commented on PR #524: URL: https://github.com/apache/tomcat/pull/524#issuecomment-1210989613 closing due to open issues (don't want to it to hang) --- will rethink options as time permits -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tomcat] funkman closed pull request #524: Dir redirect use301

2022-08-10 Thread GitBox
funkman closed pull request #524: Dir redirect use301 URL: https://github.com/apache/tomcat/pull/524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-10 Thread Christopher Schultz
Han, On 8/10/22 06:25, Han Li wrote: Mark, Can I make a suggestion related to the ant build script. Can we add two properties to set the values of ` -Duser.language` and `-Duser.country`, because in the course of my testing I found that some of the unit test assertions are in English, but

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-10 Thread Christopher Schultz
Mark, On 8/10/22 06:02, Mark Thomas wrote: On 09/08/2022 20:19, Christopher Schultz wrote: On 8/9/22 14:09, Mark Thomas wrote: This issue is the zip files. Time stamps in zip files use local (yes, local - I didn't mistype that) time. Hence you need to use the same time zone to get a

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-10 Thread Konstantin Kolinko
ср, 10 авг. 2022 г. в 13:25, Han Li : > > Mark, > > Can I make a suggestion related to the ant build script. Can we add two > properties to set the values of ` -Duser.language` and `-Duser.country`, > because in the course of my testing I found that some of the unit test > assertions are in

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-10 Thread Han Li
> 2022年8月11日 05:20,Christopher Schultz 写道: > > Han, > > On 8/10/22 06:25, Han Li wrote: >> Mark, >> Can I make a suggestion related to the ant build script. Can we add two >> properties to set the values of ` -Duser.language` and `-Duser.country`, >> because in the course of my testing I

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-10 Thread Han Li
> 2022年8月11日 06:52,Konstantin Kolinko 写道: > > ср, 10 авг. 2022 г. в 13:25, Han Li >: >> >> Mark, >> >> Can I make a suggestion related to the ant build script. Can we add two >> properties to set the values of ` -Duser.language` and `-Duser.country`, >> because