[Bug 54184] Tomcat 7.0.32, IE javascript comments - number of dashes must be even
https://issues.apache.org/bugzilla/show_bug.cgi?id=54184 --- Comment #2 from bill bill.tom...@beanfactory.co.uk --- Quite agree Mark, That was just me trying to work out where the issue was. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Using comments.apache.org for our live docs
2012/11/20 Rainer Jung rainer.j...@kippdata.de: On 08.11.2012 23:25, Konstantin Kolinko wrote: 2012/11/8 Rainer Jung rainer.j...@kippdata.de: Several notes: A final version would include a reference to tomcat.apache.org Yes, noted. 1. I think it needs to also allow tomcat.[eu|us].apache.org mirrors and ci.apache.org where nightly builds of documentation are published. It would be trivial to include those hosts in the server name check. But: any comment is associated with a URL. Either you send an explicit URL, when the comment is added, or the comments server uses the URL in the Referer header. Now that URL serves two purposes: - the comment add command returns with a redirect to that page. So the URL should be self-referential, otherwise adding a comment would kick you off the previous page. - the URL is linked from the comments dashboard If we wanted multiple sites who serve our docs to share the comments, then the page URL we sent needs to be an URI without server and port. Still all the sites would need to have a uniform URI structure. At least ci will not have the same URI structure for the docs as tomcat.a.o. tomcat.eu and tomcat.us will. The downside to switching to a URI is, that the links form the dashboard will be broken. So I suggest to support comments only on the official tomcat.a.o and use full page URLs as the prototype does. If we need a single official URL, I would prefer to use https://tomcat.apache.org/ (with HTTPS). As in better be safe. Other than that I am OK with enabling the feature on tomcat.a.o only. Updated patch available at http://people.apache.org/~rjung/patches/tc-trunk-comments-v2.patch +1. Good. There is stray +LICENSE line before section name=Privacy Policy in comments.xml. I think you'll want to apply additional menu items (those additions in project.xml files) regardless of this patch. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Using comments.apache.org for our live docs
On 22.11.2012 12:43, Konstantin Kolinko wrote: 2012/11/20 Rainer Jung rainer.j...@kippdata.de: On 08.11.2012 23:25, Konstantin Kolinko wrote: 2012/11/8 Rainer Jung rainer.j...@kippdata.de: So I suggest to support comments only on the official tomcat.a.o and use full page URLs as the prototype does. If we need a single official URL, I would prefer to use https://tomcat.apache.org/ (with HTTPS). As in better be safe. Other than that I am OK with enabling the feature on tomcat.a.o only. I think for http and https there might be some code in comments. I'll check whether we can support http and https in parallel. Updated patch available at http://people.apache.org/~rjung/patches/tc-trunk-comments-v2.patch +1. Good. There is stray +LICENSE line before section name=Privacy Policy in comments.xml. Right, I added the word as a reminder when I wrote the file and forgot to remove it. I think you'll want to apply additional menu items (those additions in project.xml files) regardless of this patch. Mr Eagle eye :) Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54190] New: TestNonLoginAndBasicAuthenticator does not test session timeout properly
https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 Bug ID: 54190 Summary: TestNonLoginAndBasicAuthenticator does not test session timeout properly Product: Tomcat 7 Version: trunk Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: br...@pingtoo.com Classification: Unclassified Created attachment 29621 -- https://issues.apache.org/bugzilla/attachment.cgi?id=29621action=edit Extensive update to the test class to demonstrate session timeout properly While working on a new test case for a different Authenticator, I decided to follow the timeout test case in this class. Although all the test cases currently run successfully, I discovered three fundamental flaws in the existing timeout test case: 1. The BasicAuthenticator does not create a session by default, so there was no session to actually timeout. 2. Context.setSessionTimeout() was called with a timeout in seconds, but this method expects a timeout argument in minutes. 3. The presence of 401 Unauthorized status was intended to confirm a session timeout, but it was erroneously succeeding because no credentials were supplied when attempting to re-access the protected resource. The attached patch is quite extensive, but cannot easily be broken into smaller units: 1. The AuthenticatorBase.setAlwaysUseSession variable can now be manipulated by test cases. 2. The doTestBasic method has been reimplemented so that it only makes a single HTTP GET request (instead of two). 3. doTestBasic can now be controlled to authenticate or not, and it will also harvest a session cookie and can also supply that cookie in subsequent requests. 4. The doTestNonLogin method can be controlled to send a saved session cookie. 5. The erroneous timeout test case has been reimplemented has been renamed and properly commented to explain that it is not testing a timeout. 6. A new session persistence test case has been added. 7. A new session persistence timeout test case has been added. 8. Raw boolean control flags have been replaced with self-documenting constants. 9. Helpful comments have been added in some places where the logic is not self-evident. The enclosed patch file is backward compatible and passes checkstyle. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly
https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 Brian Burch br...@pingtoo.com changed: What|Removed |Added Priority|P2 |P4 Severity|normal |minor --- Comment #1 from Brian Burch br...@pingtoo.com --- Sorry! I forgot to set a realistic priority to this bug. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-taglibs-standard has an issue affecting its community
integration.
This issue affects 2 projects,
and has been outstanding for 199 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-taglibs-standard : Standard Taglib
- tomcat-taglibs-standard-install : JSP Taglibs
Full details are available at:
http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/index.html
That said, some information snippets are provided here.
The following annotations (debug/informational/warning/error messages) were
provided:
-INFO- Optional dependency httpunit failed with reason build failed
-DEBUG- (Apache Gump generated) Apache Maven Settings in:
/srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml
-INFO- Failed with reason build failed
-DEBUG- Maven POM in:
/srv/gump/public/workspace/tomcat-taglibs/standard/pom.xml
-INFO- Failed to extract fallback artifacts from Gump Repository
The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/gump_work/build_tomcat-taglibs_tomcat-taglibs-standard.html
Work Name: build_tomcat-taglibs_tomcat-taglibs-standard (Type: Build)
Work ended in a state of : Failed
Elapsed: 21 secs
Command Line: /opt/maven2/bin/mvn --batch-mode -DskipTests=true --settings
/srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml
install
[Working Directory: /srv/gump/public/workspace/tomcat-taglibs/standard]
M2_HOME: /opt/maven2
-
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Nothing to compile - all classes are up to date
[debug] execute contextualize
[INFO] [resources:testResources {execution: default-testResources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory
/srv/gump/public/workspace/tomcat-taglibs/standard/spec/src/test/resources
[INFO] Copying 3 resources
[INFO] [compiler:testCompile {execution: default-testCompile}]
[INFO] No sources to compile
[INFO] [surefire:test {execution: default-test}]
[INFO] Tests are skipped.
[INFO] [bundle:bundle {execution: default-bundle}]
[INFO] [install:install {execution: default-install}]
[INFO] Installing
/srv/gump/public/workspace/tomcat-taglibs/standard/spec/target/taglibs-standard-spec-1.2-SNAPSHOT.jar
to
/srv/gump/public/workspace/mvnlocalrepo/shared/org/apache/taglibs/taglibs-standard-spec/1.2-SNAPSHOT/taglibs-standard-spec-1.2-SNAPSHOT.jar
[INFO] [bundle:install {execution: default-install}]
[INFO] Parsing
file:/srv/gump/public/workspace/mvnlocalrepo/shared/repository.xml
[INFO] Installing
org/apache/taglibs/taglibs-standard-spec/1.2-SNAPSHOT/taglibs-standard-spec-1.2-SNAPSHOT.jar
[INFO] Writing OBR metadata
[INFO]
[INFO] Building JSTL Implementation
[INFO]task-segment: [install]
[INFO]
[INFO] [remote-resources:process {execution: default}]
[INFO] snapshot org.apache.taglibs:taglibs-standard-spec:1.2-SNAPSHOT: checking
for updates from apache.snapshots
[debug] execute contextualize
[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 14 resources
[INFO] Copying 3 resources
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Compiling 96 source files to
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/target/classes
[INFO] -
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR]
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java:[38,7]
error: DataSourceWrapper is not abstract and does not override abstract method
getParentLogger() in CommonDataSource
[INFO] 1 error
[INFO] -
[INFO]
[ERROR] BUILD FAILURE
[INFO]
[INFO] Compilation failure
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java:[38,7]
error: DataSourceWrapper is not abstract and does not override abstract method
getParentLogger() in CommonDataSource
[INFO]
[INFO] For more information, run Maven with the -e switch
[INFO]
RE: tomcat-dbcp compilation failures
From: Toby Hobson [mailto:toby.hob...@gmail.com]
Subject: tomcat-dbcp compilation failures
I'm now seeing compilation failures on the tomcat-dbcp project:
tomcat7-deps/dbcp/src/java/org/apache/tomcat/dbcp/dbcp/BasicDataSource.java
53: error: BasicDataSource is not abstract and does not override abstract
method getParentLogger() in CommonDataSource
[javac] public class BasicDataSource implements DataSource {
Looks like you're using an inappropriate JDK level. As I recall, Tomcat 7 must
be built with JDK 6, although it can run on JRE/JDK 7 once built.
Sun/Oracle introduced incompatibilities in JDK 7, so developers cannot support
both in a single version of the code. Tomcat 8 will use JDK 7.
- Chuck
THIS COMMUNICATION MAY CONTAIN CONFIDENTIAL AND/OR OTHERWISE PROPRIETARY
MATERIAL and is thus for use only by the intended recipient. If you received
this in error, please contact the sender and delete the e-mail and its
attachments from all computers.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1412575 - in /tomcat/trunk: ./ java/org/apache/catalina/core/ java/org/apache/tomcat/util/modeler/ test/org/apache/catalina/core/
Author: markt
Date: Thu Nov 22 14:58:51 2012
New Revision: 1412575
URL: http://svn.apache.org/viewvc?rev=1412575view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54170
Ensure correct registration of Filters and Servlets in the JMX registry if the
Filter or Servlet name includes a character that must be quoted if used in an
ObjectName value.
Added:
tomcat/trunk/java/org/apache/tomcat/util/modeler/Util.java (with props)
tomcat/trunk/test/org/apache/catalina/core/TestApplicationFilterConfig.java
(with props)
Modified:
tomcat/trunk/TOMCAT-NEXT.txt
tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterConfig.java
tomcat/trunk/java/org/apache/catalina/core/StandardWrapper.java
Modified: tomcat/trunk/TOMCAT-NEXT.txt
URL:
http://svn.apache.org/viewvc/tomcat/trunk/TOMCAT-NEXT.txt?rev=1412575r1=1412574r2=1412575view=diff
==
--- tomcat/trunk/TOMCAT-NEXT.txt (original)
+++ tomcat/trunk/TOMCAT-NEXT.txt Thu Nov 22 14:58:51 2012
@@ -210,7 +210,7 @@ but possibly 7.1.x).
13. Fix all FindBugs warnings
- Complete for javax.*
-- Complete for o.a.[catalina|coyote|el].*
+- Complete for o.a.[catalina|coyote|el|juli|naming].*
- Remaining code in progress
14. Review date formatting with a view to reducing duplication.
Modified:
tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterConfig.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterConfig.java?rev=1412575r1=1412574r2=1412575view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterConfig.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterConfig.java Thu
Nov 22 14:58:51 2012
@@ -43,6 +43,7 @@ import org.apache.tomcat.InstanceManager
import org.apache.tomcat.util.ExceptionUtils;
import org.apache.tomcat.util.log.SystemLogHandler;
import org.apache.tomcat.util.modeler.Registry;
+import org.apache.tomcat.util.modeler.Util;
import org.apache.tomcat.util.res.StringManager;
@@ -416,16 +417,19 @@ public final class ApplicationFilterConf
String webMod = // + hostName + parentName;
String onameStr = null;
+String filterName = filterDef.getFilterName();
+if (Util.objectNameValueNeedsQuote(filterName)) {
+filterName = ObjectName.quote(filterName);
+}
if (context instanceof StandardContext) {
StandardContext standardContext = (StandardContext) context;
-onameStr = domain + :j2eeType=Filter,name= +
- filterDef.getFilterName() + ,WebModule= + webMod +
- ,J2EEApplication= +
+onameStr = domain + :j2eeType=Filter,name= + filterName +
+ ,WebModule= + webMod + ,J2EEApplication= +
standardContext.getJ2EEApplication() + ,J2EEServer= +
standardContext.getJ2EEServer();
} else {
-onameStr = domain + :j2eeType=Filter,name= +
- filterDef.getFilterName() + ,WebModule= + webMod;
+onameStr = domain + :j2eeType=Filter,name= + filterName +
+ ,WebModule= + webMod;
}
try {
oname = new ObjectName(onameStr);
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardWrapper.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardWrapper.java?rev=1412575r1=1412574r2=1412575view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardWrapper.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardWrapper.java Thu Nov 22
14:58:51 2012
@@ -66,6 +66,7 @@ import org.apache.tomcat.PeriodicEventLi
import org.apache.tomcat.util.ExceptionUtils;
import org.apache.tomcat.util.log.SystemLogHandler;
import org.apache.tomcat.util.modeler.Registry;
+import org.apache.tomcat.util.modeler.Util;
/**
* Standard implementation of the bWrapper/b interface that represents
@@ -1775,7 +1776,11 @@ public class StandardWrapper extends Con
StringBuilder keyProperties =
new StringBuilder(j2eeType=Servlet,name=);
-keyProperties.append(getName());
+String name = getName();
+if (Util.objectNameValueNeedsQuote(name)) {
+name = ObjectName.quote(name);
+}
+keyProperties.append(name);
keyProperties.append(getWebModuleKeyProperties());
Added: tomcat/trunk/java/org/apache/tomcat/util/modeler/Util.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/modeler/Util.java?rev=1412575view=auto
==
--- tomcat/trunk/java/org/apache/tomcat/util/modeler/Util.java (added)
+++
svn commit: r1412576 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/tomcat/util/modeler/ test/org/apache/catalina/core/ webapps/docs/
Author: markt
Date: Thu Nov 22 15:02:31 2012
New Revision: 1412576
URL: http://svn.apache.org/viewvc?rev=1412576view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54170
Ensure correct registration of Filters and Servlets in the JMX registry if the
Filter or Servlet name includes a character that must be quoted if used in an
ObjectName value.
Added:
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/modeler/Util.java
- copied unchanged from r1412575,
tomcat/trunk/java/org/apache/tomcat/util/modeler/Util.java
tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestApplicationFilterConfig.java
- copied unchanged from r1412575,
tomcat/trunk/test/org/apache/catalina/core/TestApplicationFilterConfig.java
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ApplicationFilterConfig.java
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardWrapper.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1412575
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ApplicationFilterConfig.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ApplicationFilterConfig.java?rev=1412576r1=1412575r2=1412576view=diff
==
---
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ApplicationFilterConfig.java
(original)
+++
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ApplicationFilterConfig.java
Thu Nov 22 15:02:31 2012
@@ -43,6 +43,7 @@ import org.apache.tomcat.InstanceManager
import org.apache.tomcat.util.ExceptionUtils;
import org.apache.tomcat.util.log.SystemLogHandler;
import org.apache.tomcat.util.modeler.Registry;
+import org.apache.tomcat.util.modeler.Util;
import org.apache.tomcat.util.res.StringManager;
@@ -416,16 +417,19 @@ public final class ApplicationFilterConf
String webMod = // + hostName + parentName;
String onameStr = null;
+String filterName = filterDef.getFilterName();
+if (Util.objectNameValueNeedsQuote(filterName)) {
+filterName = ObjectName.quote(filterName);
+}
if (context instanceof StandardContext) {
StandardContext standardContext = (StandardContext) context;
-onameStr = domain + :j2eeType=Filter,name= +
- filterDef.getFilterName() + ,WebModule= + webMod +
- ,J2EEApplication= +
+onameStr = domain + :j2eeType=Filter,name= + filterName +
+ ,WebModule= + webMod + ,J2EEApplication= +
standardContext.getJ2EEApplication() + ,J2EEServer= +
standardContext.getJ2EEServer();
} else {
-onameStr = domain + :j2eeType=Filter,name= +
- filterDef.getFilterName() + ,WebModule= + webMod;
+onameStr = domain + :j2eeType=Filter,name= + filterName +
+ ,WebModule= + webMod;
}
try {
oname = new ObjectName(onameStr);
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardWrapper.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardWrapper.java?rev=1412576r1=1412575r2=1412576view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardWrapper.java
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardWrapper.java Thu
Nov 22 15:02:31 2012
@@ -69,6 +69,7 @@ import org.apache.tomcat.PeriodicEventLi
import org.apache.tomcat.util.ExceptionUtils;
import org.apache.tomcat.util.log.SystemLogHandler;
import org.apache.tomcat.util.modeler.Registry;
+import org.apache.tomcat.util.modeler.Util;
/**
* Standard implementation of the bWrapper/b interface that represents
@@ -1851,7 +1852,11 @@ public class StandardWrapper extends Con
StringBuilder keyProperties =
new StringBuilder(j2eeType=Servlet,name=);
-keyProperties.append(getName());
+String name = getName();
+if (Util.objectNameValueNeedsQuote(name)) {
+name = ObjectName.quote(name);
+}
+keyProperties.append(name);
keyProperties.append(getWebModuleKeyProperties());
Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1412576r1=1412575r2=1412576view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Thu Nov 22 15:02:31 2012
@@ -59,6 +59,11 @@
fix
Fix unit test for AccessLogValve when using non-GMT
[Bug 54170] JMX ObjectName for Filters: names used without quoting (escaping)
https://issues.apache.org/bugzilla/show_bug.cgi?id=54170 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED OS||All --- Comment #1 from Mark Thomas ma...@apache.org --- Thanks for the report. Fixed in trunk and 7.0.x and will be included in 7.0.34 onwards. Servlets were affected as well as Filters. Both were fixed. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly
https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 --- Comment #2 from Mark Thomas ma...@apache.org --- testBasicLoginWithoutSession() seems to repeat the same pair of tests but the comments suggest that something different should happen the second time. What am I missing? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
What is the destiny of the Apache Tomcat project in view of java is getting more and more proprietary with Oracle?
Dear All, Could anybody please provide me with some info on the status of Apache Tomcat development? I can't clear up, what is the attitude of ASF to java-based projects after all this mess with leaving the JCP EC. Is it going to continue java language-based projects forever or is there any formal decision by ASF in this regard? My question arises from the fact that Apache Tomcat is java-based and therefore have to rely on Oracle java proprietary APIs. Please say, what I'm missing here? Thank you very much in advance. -- Regards, Alex Yursha
buildbot failure in ASF Buildbot on tomcat-trunk
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/3588 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1412575 Blamelist: markt BUILD FAILED: failed compile_1 sincerely, -The Buildbot
Re: [Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly
On 22/11/12 15:17, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 --- Comment #2 from Mark Thomas ma...@apache.org --- testBasicLoginWithoutSession() seems to repeat the same pair of tests but the comments suggest that something different should happen the second time. What am I missing? Thanks for looking at my change so carefully and quickly. You are not missing anything, Mark. Perhaps my comments section could be clearer. That particular test demonstrates something that I am sure you consider obvious... tc does not have any mechanism for remembering the client's successful authentication. The third call to doTestBasic, without providing any credentials, gets the 401 status because the server didn't have a cached session. The only reason I coded that explicit 401/200/401/200 sequence was to make it obviously and directly comparable with testBasicLoginSessionPersistence, which gets 401/200/200/200. Strictly speaking, I suppose the fourth doTestBasic is redundant, the third is a bit like stating the obvious, and then the whole of testAcceptProtectedBasic could be considered to be a duplicate. Nevertheless, the only test that takes any time at all is the one that involves a session timeout. My main motive for dotting the i's was to make the behaviour clear to a third person who might be trying to understand the way it works. Do you prefer to make the comments clearer, or take out the redundant logic? Brian - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly
https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 --- Comment #3 from Mark Thomas ma...@apache.org --- Your logic makes sense to me so my preference would be some more comments. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: tomcat-dbcp compilation failures
On 22.11.2012 15:37, Toby Hobson wrote:
After seeing the previous test failures with HEAD on t7/trunk I grabbed the
latest code but I'm now seeing compilation failures on the tomcat-dbcp
project:
tomcat7-deps/dbcp/src/java/org/apache/tomcat/dbcp/dbcp/BasicDataSource.java
53: error: BasicDataSource is not abstract and does not override abstract
method getParentLogger() in CommonDataSource
[javac] public class BasicDataSource implements DataSource {
There are a few more errors like this.
I've noticed that the errors are not on the t7 trunk itself but on the
dependencies which the ant script downloads.
Are there any docs or guidelines about the best way to build and test the
t7 codebase? because I seem to be hitting a lot of basic problems right now
:(
In addition to Chuck: Look at BUILDING.txt at the root of the checkout.
Regards,
Rainer
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly
On 22/11/12 16:46, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 --- Comment #3 from Mark Thomas ma...@apache.org --- Your logic makes sense to me so my preference would be some more comments. I will think about our discussion and try to improve the comments and so hopefully avoid confusing future readers. I will submit a new self-contained patch and obsolete the current one. Sorry to drift slightly (but not completely) off-topic. Could you give me your off-the-cuff opinion on this: Context.setSessionTimeout(int timeoutInMinutes) obliges tests that need to explore session timeout behaviour to hang the test process for at least 60 seconds, although most of that delay would be unnecessary. I don't actually know how often the Manager (is that the right component?) scans to expire Sessions, but it must do it more frequently than once a minute. I realise the method signature is part of a public api, but do you have a view on adding an alternative method to org.apache.catalina.core.StandardContext so that unit tests could set a session timeout in seconds? Thanks, Brian - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly
On 22/11/2012 17:32, Brian Burch wrote: On 22/11/12 16:46, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 --- Comment #3 from Mark Thomas ma...@apache.org --- Your logic makes sense to me so my preference would be some more comments. I will think about our discussion and try to improve the comments and so hopefully avoid confusing future readers. I will submit a new self-contained patch and obsolete the current one. Sorry to drift slightly (but not completely) off-topic. Could you give me your off-the-cuff opinion on this: Context.setSessionTimeout(int timeoutInMinutes) obliges tests that need to explore session timeout behaviour to hang the test process for at least 60 seconds, although most of that delay would be unnecessary. I don't actually know how often the Manager (is that the right component?) scans to expire Sessions, but it must do it more frequently than once a minute. It is the manager. It scans (goes to look up frequency) every 60 seconds by default (10s for background process * 6 for processExpiresFrequency) I realise the method signature is part of a public api, but do you have a view on adding an alternative method to org.apache.catalina.core.StandardContext so that unit tests could set a session timeout in seconds? I'm neutral. The delay doesn't really bother me. If you do go this way, you'll need to modify processExpiresFrequency for the Manager as well so checks happen more often. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly
On 22/11/12 18:39, Mark Thomas wrote: On 22/11/2012 17:32, Brian Burch wrote: On 22/11/12 16:46, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 --- Comment #3 from Mark Thomas ma...@apache.org --- Your logic makes sense to me so my preference would be some more comments. I will think about our discussion and try to improve the comments and so hopefully avoid confusing future readers. I will submit a new self-contained patch and obsolete the current one. Sorry to drift slightly (but not completely) off-topic. Could you give me your off-the-cuff opinion on this: Context.setSessionTimeout(int timeoutInMinutes) obliges tests that need to explore session timeout behaviour to hang the test process for at least 60 seconds, although most of that delay would be unnecessary. I don't actually know how often the Manager (is that the right component?) scans to expire Sessions, but it must do it more frequently than once a minute. It is the manager. It scans (goes to look up frequency) every 60 seconds by default (10s for background process * 6 for processExpiresFrequency) I realise the method signature is part of a public api, but do you have a view on adding an alternative method to org.apache.catalina.core.StandardContext so that unit tests could set a session timeout in seconds? I'm neutral. The delay doesn't really bother me. If you do go this way, you'll need to modify processExpiresFrequency for the Manager as well so checks happen more often. Perfect answer, thanks! If the Manager by default is scanning every 60 seconds, then it makes sense to live with a session timeout of 1 minute and a test case wait of about 70 seconds. That is what I am doing at the moment, and there isn't much point being clever unless a test suite is going to call for more than a few timeouts. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Offline generation of effective web.xml
Hi, I've prepared the initial change for offline generation of effective web.xml. The change is in github: https://github.com/violetagg/apache-tomcat-8.0/commits/master. I have a few minor changes that I plan to do but before then I prefer to get your opinion about the refactoring that I made and the change as a whole. Here is the list with the major changes that I did: - The java objects that represent data structures for web.xml were moved from o.a.catalina.deploy to o.a.tomcat.util.xml package. - The web.xml parser functionality was moved to a new package - o.a.tomcat.util.xml.parse - The functionality that scans for web fragments was moved to a new package - o.a.tomcat.util.xml.scanner - The functionality that scans for annotations was moved to a new package - o.a.tomcat.util.xml.processor - Added functionality for offline generation of effective web.xml I'm looking forward to your comments. Regards Violeta Georgieva 2012/9/11 Mark Thomas ma...@apache.org Violeta Georgieva miles...@gmail.com wrote: It would be very useful if I can provide this as part of the build infrastructure for example. If you can give me a hint from where to start I may try to provide a patch for 8.0.x? Wdyt? There is going to need to be a lot of refactoring for this. I'm not sure if a patch is the right way to go. Neither am I sure what the best way is. Maybe a git branch (e.g. on github) with a series of patches? I don't have enough experience with the git-svn integration to know if that would be easier or harder to deal with. In terms of what needs to be done: - the end result needs to be useable by both Jasper and Catalina - that pretty much means a new package and JAR under o.a.tomcat - Jasper cannot depend on Catalina (hence why everything needs to move packages) - the things that need to move to this new package - the web.xml parsing (i.e.the digester) - the annotation scanning - the SCI scanning - the merging - the object representation of web.xml - switch everything over to the new implementation This is a big change but most of it is just moving stuff around. It isn't changing functionality (well it is - JspC would process fragments which it doesn't currently for example but all the functional changes would be improvements of this nature) I suggest making a proposal to the dev list. If that gets support, I'd be happy to help with this. I suspect in that case a series of svn moves and patches would follow. Mark - To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
[Bug 54191] New: TomEE 1.5+ SNAPSHOT struggling with PrimeFaces p:calendar readonlyInput=#{someEL ? 'true' : 'false'}
https://issues.apache.org/bugzilla/show_bug.cgi?id=54191
Bug ID: 54191
Summary: TomEE 1.5+ SNAPSHOT struggling with PrimeFaces
p:calendar readonlyInput=#{someEL ? 'true' :
'false'}
Product: Tomcat 7
Version: 7.0.32
Hardware: PC
OS: Windows Vista
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
Assignee: dev@tomcat.apache.org
Reporter: smithh032...@gmail.com
Classification: Unclassified
Overview:
After discussing this with user community, it is believed that TomEE is
struggling with the following xhtml post/after AJAX submit (and during AJAX
render/update):
p:calendar readonlyInput=#{pf_usersController.loggedInViaIpad == 'Y' ? 'true'
: 'false'}
1. readonlyInput=... is a property of PrimeFaces' p:calendar component.
2. To meet a business requirement, I decided to populate this attribute via EL
3. After AJAX submit (and render), p:calendar loses its p:calendar client-side
attributes/behavior; an inputText is rendered only
4. This EL works as designed (and without issues) on Glassfish 3.1.2.2 and
MyFaces Core 2.1.9.
Steps to Reproduce:
1. Add EL (above) to the readonlyInput=... attribute of PrimeFaces p:calendar
component
2. Select a date via the p:calendar component after xhtml page is rendered in
the browser; AJAX submit is triggered
3. Repeat step # 2 above until p:calendar is rendered WITHOUT (jQuery
datepicker) 'button' and calendar popup/dropdown
Actual Results:
Sporadically, p:calendar is rendered WITHOUT (jQuery datepicker) 'button' and
calendar popup/dropdown
Expected Results:
p:calendar ALWAYS rendered WITH (jQuery datepicker) 'button' and calendar
popup/dropdown
Build Date Platform: Date and platform of the build in which you first
encountered the bug.
INFO: Starting Servlet Engine: Apache Tomcat (TomEE)/7.0.32
apache-tomee-1.5.1-20121117.041542-74-plus.zip
Additional Builds and Platforms:
PrimeFaces 3.5 SNAPSHOT, JUEL 2.2.5, OmniFaces 1.3 SNAPSHOT
Additional Information:
Screen captures:
1. BEFORE AJAX submit:
http://imageshack.us/photo/my-images/163/20121121ajaxcalendariss.jpg/
2. AFTER AJAX submit:
http://imageshack.us/photo/my-images/600/20121121ajaxcalendariss.jpg/
ORIGINAL xhtml below:
p:calendar id=filterTripDateFrom
value=#{pf_ordersController.filterTripDateFrom}
mode=popup showOn=button
readonlyInput=#{pf_usersController.loggedInViaIpad == 'Y' ? 'true' : 'false'}
navigator=true effect=fadeIn
pattern=MM/dd/ size=10
p:ajax partialSubmit=false
event=dateSelect
listener=#{pf_ordersController.filterTripDateFromSelected}
update=:ordersBrowseForm:ordersDataTable
:ordersBrowseForm:formMessages :ordersBrowseForm:_ajax_status /
/p:calendar
h:outputText value=To: /
p:calendar id=filterTripDateTo
value=#{pf_ordersController.filterTripDateTo}
mode=popup showOn=button
readonlyInput=#{pf_usersController.loggedInViaIpad == 'Y' ? 'true' : 'false'}
navigator=true effect=fadeIn pattern=MM/dd/
size=10
p:ajax partialSubmit=false
event=dateSelect
listener=#{pf_ordersController.filterTripDateToSelected}
update=:ordersBrowseForm:ordersDataTable
:ordersBrowseForm:formMessages :ordersBrowseForm:_ajax_status /
/p:calendar
WORKAROUND: use rendered=#{...} to render appropriate xhtml content (see
xhtml below)
h:outputText value=From: /
p:calendar id=filterTripDateFrom
value=#{pf_ordersController.filterTripDateFrom}
mode=popup showOn=button
navigator=true effect=fadeIn
pattern=MM/dd/ size=10
rendered=#{pf_usersController.loggedInViaIpad == 'N'}
p:ajax partialSubmit=false
event=dateSelect
listener=#{pf_ordersController.filterTripDateFromSelected}
update=:ordersBrowseForm:ordersDataTable
:ordersBrowseForm:formMessages :ordersBrowseForm:_ajax_status /
/p:calendar
p:calendar id=filterTripDateFromOnIpad
value=#{pf_ordersController.filterTripDateFrom}
mode=popup showOn=button readonlyInput=true
navigator=true effect=fadeIn
pattern=MM/dd/ size=10
rendered=#{pf_usersController.loggedInViaIpad == 'Y'}
p:ajax partialSubmit=false
event=dateSelect
listener=#{pf_ordersController.filterTripDateFromSelected}
update=:ordersBrowseForm:ordersDataTable
:ordersBrowseForm:formMessages :ordersBrowseForm:_ajax_status /
/p:calendar
h:outputText value=To: /
p:calendar id=filterTripDateTo
value=#{pf_ordersController.filterTripDateTo}
mode=popup showOn=button
navigator=true effect=fadeIn pattern=MM/dd/ size=10
rendered=#{pf_usersController.loggedInViaIpad == 'N'}
p:ajax partialSubmit=false
event=dateSelect
[Bug 54191] TomEE 1.5+ SNAPSHOT struggling with PrimeFaces p:calendar readonlyInput=#{someEL ? 'true' : 'false'}
https://issues.apache.org/bugzilla/show_bug.cgi?id=54191 --- Comment #1 from smithh032772 smithh032...@gmail.com --- Created attachment 29623 -- https://issues.apache.org/bugzilla/attachment.cgi?id=29623action=edit p:calendar WITH button BEFORE AJAX submit -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54191] TomEE 1.5+ SNAPSHOT struggling with PrimeFaces p:calendar readonlyInput=#{someEL ? 'true' : 'false'}
https://issues.apache.org/bugzilla/show_bug.cgi?id=54191 --- Comment #2 from smithh032772 smithh032...@gmail.com --- Created attachment 29624 -- https://issues.apache.org/bugzilla/attachment.cgi?id=29624action=edit p:calendar WITHOUT button AFTER AJAX submit -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54191] TomEE 1.5+ SNAPSHOT struggling with PrimeFaces p:calendar readonlyInput=#{someEL ? 'true' : 'false'}
https://issues.apache.org/bugzilla/show_bug.cgi?id=54191
--- Comment #3 from smithh032772 smithh032...@gmail.com ---
Below, is xhtml that has EL in the readonlyInput property, but I am not able to
duplicate this issue on the EL. I thought I may share this, so this xhtml can
be compared to the xhtml in the OP.
p:dataTable id=dt_tripsToConfirm var=order
value=#{pf_ordersController.tripsToConfirm}
p:column headerText=Trip Date
h:outputText escape=false
value=#{pf_ordersController.getTripDateDisplay(order.tripDateTime,
order.returnDateTime, true, true, true)}/
/p:column
p:column headerText=Customer
h:outputText value=#{order.customerId.customerName} /br/
h:outputText escape=false
value=#{pf_ordersController.getOrderCustomerPointOfContactListDisplay(order)}
/
/p:column
p:column headerText=Confirmed? style=text-align: center !important;
h:selectOneMenu value=#{order.confirmed} label=Confirmed
f:selectItem itemValue=#{bundle.DropdownOptionValueYes}
itemLabel=#{bundle.DropdownOptionLabelYes}/
f:selectItem itemValue=#{bundle.DropdownOptionValueNo}
itemLabel=#{bundle.DropdownOptionLabelNo}/
p:ajax partialSubmit=false
listener=#{pf_ordersController.confirmedChangedOnConfirmTrips(order)}
update=:pageContentPanel/
/h:selectOneMenu
/p:column
p:column headerText=Confirmed Date style=text-align: center
!important;
p:calendar value=#{order.confirmedDate}
rendered=#{order.confirmed == 'Y'}
label=Confirmed Date
mode=popup showOn=button
readonlyInput=#{pf_usersController.loggedInViaIpad == 'Y' ? 'true' : 'false'}
navigator=true effect=fadeIn
pattern=MM/dd/ size=8
f:convertDateTime pattern=MM/dd/ /
/p:calendar
/p:column
/p:dataTable
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
