Re: Tagging Tomcat Native 1.2.19

2018-11-30 Thread Mark Thomas
On 29/11/2018 23:39, Christopher Schultz wrote: > Mark, > > On 11/29/18 16:29, Mark Thomas wrote: >> I think the issues are resolved now so I plan to review the >> current state of the code and then tag either later today or early >> tomorrow. > > +1 I've just realised that we aren't including

Re: Tagging Tomcat Native 1.2.19

2018-11-29 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/29/18 16:29, Mark Thomas wrote: > I think the issues are resolved now so I plan to review the > current state of the code and then tag either later today or early > tomorrow. +1 - -chris -BEGIN PGP SIGNATURE- Comment: Using

Re: Tagging Tomcat Native 1.2.19

2018-11-29 Thread Mark Thomas
I think the issues are resolved now so I plan to review the current state of the code and then tag either later today or early tomorrow. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands,

Re: Tagging Tomcat Native 1.2.19

2018-11-24 Thread Rainer Jung
Another update: - APR connector works well - It looks like it has to do with readFromSSL() after the handshake returning 0 bytes. I remember having added some native code to mod_ssl for OpenSSL 1.1.1, which handles new behavior in OpenSSL SSL_read(). It can now return 0 and set the ssl

Re: Tagging Tomcat Native 1.2.19

2018-11-23 Thread Rainer Jung
One correction: using openssl s_client correctly does not hang. Only curl build with OpenSSL hangs. I tried my old curl builds and it seems it starts to hang with curl 7.24.0. Version 7.23.1 does not hang. The OpenSSL lib version on the client side does not seem to matter. I'll do some more

Re: Tagging Tomcat Native 1.2.19

2018-11-23 Thread Rainer Jung
Short addition: When using Apache httpd 2.4.37 build with OpenSSL 1.1.1a, there are no hangs with TLS 1.0. So it seems we have a relevant difference in our server-side use of the OpenSSL API. Easy to reproduce, but not easy to debug ... Regards, Rainer Am 23.11.2018 um 15:50 schrieb Rainer

Re: Tagging Tomcat Native 1.2.19

2018-11-23 Thread Rainer Jung
Am 23.11.2018 um 14:54 schrieb Mark Thomas: Hi all, Given bugs 62662 and 62944, I plan to tag 1.2.19 early next week with a view to including 1.2.19 in the next round of Tomcat releases. I observed a problem with TLS 1.0 under the following conditions: - using 9.0.13 with NIO plus tcnative

Re: Tagging Tomcat Native 1.2.19

2018-11-23 Thread Rémy Maucherat
On Fri, Nov 23, 2018 at 2:54 PM Mark Thomas wrote: > Hi all, > > Given bugs 62662 and 62944, I plan to tag 1.2.19 early next week with a > view to including 1.2.19 in the next round of Tomcat releases. > +1 Rémy