Re: MicroProfile rest client example

[David Blevins]

> On Nov 23, 2018, at 3:52 PM, César Hernández Mendoza  
> wrote:
> 
> Hi everybody,
> 
> I did a git bisect and this is the final output:
> 
> a5513230e8f77a4985916f901c3eda2c5c45c6d2 is the first bad commit
> commit a5513230e8f77a4985916f901c3eda2c5c45c6d2
> Author: Dennis Kieselhorst 
> Date:   Tue Oct 30 15:30:06 2018 +0100
> 
>Update CXF to latest release
> 
> :100644 100644 42b6643b26a64db3e381159191d588102e80478e
> 732703824b1d27f5c12f3ac6669c0c5a59a63030 M pom.xml
> 
> 
> Notice that my intention is not to blame anyone, instead, I'm providing
> enough context that allows all of us to help in fixing this issue.
> I would highly appreciate any information you may have about the background
> of  this commit [1],

I have a saying: The only people who don't break the build are those who do 
nothing. :)

On background, I think it's not more complicated than trying to stay current.

> Action for next week:
[..]
> b) It's important also to notice that we definitely need to add to TomEE
> some tests related to MicroProfile rest client integration.

You hit the nail on the head here.

If examples are finding bugs, it's a sign we need more tests of our own.

Mind you, the act of creating examples has an amazing way of surfacing bugs, 
just when they do, we should add a test case so the example isn't the only 
thing keeping us safe.


-David

Re: MicroProfile rest client example

[César Hernández Mendoza]

Hi everybody,

I did a git bisect and this is the final output:

a5513230e8f77a4985916f901c3eda2c5c45c6d2 is the first bad commit
commit a5513230e8f77a4985916f901c3eda2c5c45c6d2
Author: Dennis Kieselhorst 
Date:   Tue Oct 30 15:30:06 2018 +0100

Update CXF to latest release

:100644 100644 42b6643b26a64db3e381159191d588102e80478e
732703824b1d27f5c12f3ac6669c0c5a59a63030 M pom.xml


Notice that my intention is not to blame anyone, instead, I'm providing
enough context that allows all of us to help in fixing this issue.
I would highly appreciate any information you may have about the background
of  this commit [1],

Action for next week:
a) I need to investigate why the CXF update from version
3.2.6 to 3.2.7 breaks
the MicroProfile Rest Client integration.
b) It's important also to notice that we definitely need to add to TomEE
some tests related to MicroProfile rest client integration.



[1]
https://github.com/apache/tomee/commit/a5513230e8f77a4985916f901c3eda2c5c45c6d2


El vie., 23 nov. 2018 a las 14:05, César Hernández Mendoza (<
cesargu...@gmail.com>) escribió:

> Thanks for the reply,
>
> Build it  locally didn't solve the issue. I did this:
>
> a) Build entire TomEE using: mvn -Pquick -Dsurefire.useFile=false
> -DdisableXmlReport=true -DuniqueVersion=false -ff -Dassemble -DskipTests
> -DfailIfNoTests=false clean install
>
> b) Updated arquillian-tomee-remote version to: 8.0.0-SNAPSHOT for the
> example I'm building.
>
> c) Run the mp-rest-client using: mvn clean test
>
> d) The issue still appears.
>
> I also tested using for step a) mvn clean install -DskipTests without any
> successful result when running the mp-rest-client test.
>
> My plan now is doing a git bisect since this commit [1] from Oct 13,
> 2018 and HEAD.
>
> [1]
> https://github.com/apache/tomee/commit/a48208ac337cbeddbc2c27c27fe9fc68fdfafe3f
>
> Any ideas, comments or help are more than welcome :)
>
> El jue., 22 nov. 2018 a las 23:47, Romain Manni-Bucau (<
> rmannibu...@gmail.com>) escribió:
>
>> Hi César
>>
>> Not sure the snapshot was deployed, maybe build it locally
>> JL's fix does not change that error which is an outdated api in the
>> server.
>>
>> Le ven. 23 nov. 2018 03:58, César Hernández Mendoza > >
>> a écrit :
>>
>> > Hi,
>> > I updated my PR [1], the previous exception is no longer appearing since
>> > I'm not showing a Programmatic Standalone MicroProfile RestClient.
>> >
>> > I'm still using Tomee remote and Deployment(testable=true) [2]
>> >
>> > I feel I'm close to having a concrete example but now I'm facing a new
>> > issue which I need help and/or advice:
>> >
>> > * The tests run fine from the IDE (IntelliJ)
>> >
>> > * But after doing on a terminal: mvn clean test I got  this error
>> (Complete
>> > stack trace [4]): java.lang.NoSuchMethodError:
>> >
>> >
>> org.eclipse.microprofile.rest.client.RestClientBuilder.baseUri(Ljava/net/URI;)Lorg/eclipse/microprofile/rest/client/RestClientBuilder;
>> >
>> > * After investing some time trying to see where the issue was, I found
>> that
>> > if I change in my pom.xml the version of arquillian-tomee-remote   from
>> > 8.0.0-SNAPSHOT   to   8.0.0-M1 , the issue disappears and both IDE and
>> > maven clean test runs without any issue.
>> >
>> > * @Jean-Louis, I see we had a recent commit on master for
>> > arquillian-tomee-remote
>> > [3], tomorrow I´m planning to revert the Commit and check if that fixes
>> the
>> > current issue, but if the issue I´m having is an expected behavior, can
>> you
>> > please take a quick look and let me know if I´m missing something.
>> >
>> >
>> > [1]
>> >
>> >
>> https://github.com/cesarhernandezgt/tomee/commit/6179cdc8f654e9bfaec29e276ed999d9bfca3388#diff-cf40b757e6a74b3ffcfa2462457e3201R44
>> > [2]
>> >
>> >
>> https://github.com/cesarhernandezgt/tomee/blob/mp-rest-client-example/examples/mp-rest-client/src/test/java/org/superbiz/rest/BookResourceTest.java#L19
>> > [3]
>> >
>> >
>> https://github.com/apache/tomee/commit/7e33681b48562138efe41219b7c8f6e499bf8506#diff-a66043deab99db291cb46640c07dd3a5
>> > [4] java.lang.NoSuchMethodError:
>> >
>> >
>> org.eclipse.microprofile.rest.client.RestClientBuilder.baseUri(Ljava/net/URI;)Lorg/eclipse/microprofile/rest/client/RestClientBuilder;
>> >
>> > at
>> >
>> org.apache.cxf.microprofile.client.cdi.RestClientBean.create(RestClientBean.java:95)
>> > at
>> >
>> org.apache.webbeans.component.third.ThirdpartyBeanImpl.create(ThirdpartyBeanImpl.java:97)
>> > at
>> >
>> org.apache.webbeans.context.DependentContext.getInstance(DependentContext.java:68)
>> > at
>> >
>> org.apache.webbeans.context.AbstractContext.get(AbstractContext.java:125)
>> > at
>> >
>> org.apache.webbeans.container.BeanManagerImpl.getReference(BeanManagerImpl.java:813)
>> > at
>> >
>> org.apache.webbeans.container.BeanManagerImpl.getInjectableReference(BeanManagerImpl.java:673)
>> > at
>> >
>> org.apache.webbeans.inject.AbstractInjectable.inject(AbstractInjectable.java:100)
>> > at
>> >
>> 

Re: How Can I Help?

[Michael Redlich]

Thanks, Richard!


On Fri, Nov 23, 2018 at 11:50 AM Richard Monson-Haefel <
monsonhae...@gmail.com> wrote:

> Welcome, Mike!!
>
> On Fri, Nov 23, 2018 at 9:45 AM Michael Redlich  wrote:
>
>> Hello:
>>
>> My name is Michael Redlich and I was just confirmed to the TomEE
>> Developers
>> mailing list.
>>
>> Here's some background information about myself:
>>
>>- I live in Flemington , New
>> Jersey
>>with my lovely wife, Rowena.  We love to visit New Orleans, LA and
>> Newport,
>>RI on a regular basis.  We are avid cyclists and I am an avid runner.
>>- I have worked for ExxonMobil for almost 29 years.
>>- I have been writing for InfoQ
>> since May 2016.
>>- I founded the ACGNJ Java Users Group  in 2001
>>and co-facilitate the group with Barry Burd
>>.
>>
>> I am very interested in MicroProfile APIs.  I look forward to contributing
>> to TomEE!
>>
>> Sincerely,
>>
>> Mike.
>>
>>
>>
>>
>> --
>> *Code*, *Write*, *Cycle*, *Run*, *Drink*,
>> *Sleep ... Repeat*
>>
>> *InfoQ  Java Queue Editor*
>> https://about.me/mpredli 
>> https://twitter.com/mpredli
>> https://redlich.net/
>> https://javasig.org/
>> *Laissez Les Bon Temps Rouler*
>>
>

-- 
*Code*, *Write*, *Cycle*, *Run*, *Drink*,
*Sleep ... Repeat*

*InfoQ  Java Queue Editor*
https://about.me/mpredli 
https://twitter.com/mpredli
https://redlich.net/
https://javasig.org/
*Laissez Les Bon Temps Rouler*

Re: Write tests geronimo

[Romain Manni-Bucau]

Hi Ivan

TCK are in geronimo and they use arquillian, tomee just reapplies them to
check the packaging does not break anything and its classloading is fine as
well so you can write tests the same.




Le ven. 23 nov. 2018 19:51, Ivan Junckes Filho  a
écrit :

> Hello guys, I did a change on Geronimo Metrics.
> https://github.com/apache/geronimo-metrics/pull/2
>
> geronimo-metrics, as you are aware, is a library used in TomEE.
>
> I am wondering how can I write a test for my change. Writing a test in
> TomEE for this is very simple, but writing a test in geronimo I don't know
> how to do it.
>
> Basically what I need it to have an app, deploy it with a resource, call
> an endpoint annotated with @Gauge and check if the gauge metric works.
>
> https://github.com/apache/tomee/pull/213 (This does it in the TomEE side)
>
> I see some references to Meecrowave in the project as well, not sure how
> some tests use Meecrowave and if that is a pattern we should use there.
>
> The TCK for MicroProfile Metrics is on TomEE, so the other question is if
> we should just rely on the TCK or if we should not.
>
> Thanks.
>

Re: MicroProfile rest client example

[César Hernández Mendoza]

Thanks for the reply,

Build it  locally didn't solve the issue. I did this:

a) Build entire TomEE using: mvn -Pquick -Dsurefire.useFile=false
-DdisableXmlReport=true -DuniqueVersion=false -ff -Dassemble -DskipTests
-DfailIfNoTests=false clean install

b) Updated arquillian-tomee-remote version to: 8.0.0-SNAPSHOT for the
example I'm building.

c) Run the mp-rest-client using: mvn clean test

d) The issue still appears.

I also tested using for step a) mvn clean install -DskipTests without any
successful result when running the mp-rest-client test.

My plan now is doing a git bisect since this commit [1] from Oct 13,
2018 and HEAD.

[1]
https://github.com/apache/tomee/commit/a48208ac337cbeddbc2c27c27fe9fc68fdfafe3f

Any ideas, comments or help are more than welcome :)

El jue., 22 nov. 2018 a las 23:47, Romain Manni-Bucau (<
rmannibu...@gmail.com>) escribió:

> Hi César
>
> Not sure the snapshot was deployed, maybe build it locally
> JL's fix does not change that error which is an outdated api in the server.
>
> Le ven. 23 nov. 2018 03:58, César Hernández Mendoza 
> a écrit :
>
> > Hi,
> > I updated my PR [1], the previous exception is no longer appearing since
> > I'm not showing a Programmatic Standalone MicroProfile RestClient.
> >
> > I'm still using Tomee remote and Deployment(testable=true) [2]
> >
> > I feel I'm close to having a concrete example but now I'm facing a new
> > issue which I need help and/or advice:
> >
> > * The tests run fine from the IDE (IntelliJ)
> >
> > * But after doing on a terminal: mvn clean test I got  this error
> (Complete
> > stack trace [4]): java.lang.NoSuchMethodError:
> >
> >
> org.eclipse.microprofile.rest.client.RestClientBuilder.baseUri(Ljava/net/URI;)Lorg/eclipse/microprofile/rest/client/RestClientBuilder;
> >
> > * After investing some time trying to see where the issue was, I found
> that
> > if I change in my pom.xml the version of arquillian-tomee-remote   from
> > 8.0.0-SNAPSHOT   to   8.0.0-M1 , the issue disappears and both IDE and
> > maven clean test runs without any issue.
> >
> > * @Jean-Louis, I see we had a recent commit on master for
> > arquillian-tomee-remote
> > [3], tomorrow I´m planning to revert the Commit and check if that fixes
> the
> > current issue, but if the issue I´m having is an expected behavior, can
> you
> > please take a quick look and let me know if I´m missing something.
> >
> >
> > [1]
> >
> >
> https://github.com/cesarhernandezgt/tomee/commit/6179cdc8f654e9bfaec29e276ed999d9bfca3388#diff-cf40b757e6a74b3ffcfa2462457e3201R44
> > [2]
> >
> >
> https://github.com/cesarhernandezgt/tomee/blob/mp-rest-client-example/examples/mp-rest-client/src/test/java/org/superbiz/rest/BookResourceTest.java#L19
> > [3]
> >
> >
> https://github.com/apache/tomee/commit/7e33681b48562138efe41219b7c8f6e499bf8506#diff-a66043deab99db291cb46640c07dd3a5
> > [4] java.lang.NoSuchMethodError:
> >
> >
> org.eclipse.microprofile.rest.client.RestClientBuilder.baseUri(Ljava/net/URI;)Lorg/eclipse/microprofile/rest/client/RestClientBuilder;
> >
> > at
> >
> org.apache.cxf.microprofile.client.cdi.RestClientBean.create(RestClientBean.java:95)
> > at
> >
> org.apache.webbeans.component.third.ThirdpartyBeanImpl.create(ThirdpartyBeanImpl.java:97)
> > at
> >
> org.apache.webbeans.context.DependentContext.getInstance(DependentContext.java:68)
> > at
> > org.apache.webbeans.context.AbstractContext.get(AbstractContext.java:125)
> > at
> >
> org.apache.webbeans.container.BeanManagerImpl.getReference(BeanManagerImpl.java:813)
> > at
> >
> org.apache.webbeans.container.BeanManagerImpl.getInjectableReference(BeanManagerImpl.java:673)
> > at
> >
> org.apache.webbeans.inject.AbstractInjectable.inject(AbstractInjectable.java:100)
> > at
> >
> org.apache.webbeans.inject.InjectableField.doInjection(InjectableField.java:65)
> > at
> >
> org.apache.webbeans.portable.InjectionTargetImpl.injectFields(InjectionTargetImpl.java:227)
> > at
> >
> org.apache.webbeans.portable.InjectionTargetImpl.inject(InjectionTargetImpl.java:213)
> > at
> >
> org.apache.webbeans.portable.InjectionTargetImpl.inject(InjectionTargetImpl.java:203)
> > at org.apache.webbeans.inject.OWBInjector.inject(OWBInjector.java:56)
> > at
> >
> org.apache.openejb.arquillian.common.enrichment.OpenEJBEnricher.doInject(OpenEJBEnricher.java:131)
> > at
> >
> org.apache.openejb.arquillian.common.enrichment.OpenEJBEnricher.enrich(OpenEJBEnricher.java:100)
> > at
> >
> org.apache.openejb.arquillian.common.TomEEInjectionEnricher.enrich(TomEEInjectionEnricher.java:52)
> > at
> >
> org.jboss.arquillian.test.impl.TestInstanceEnricher.enrich(TestInstanceEnricher.java:52)
> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > at
> >
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> > at
> >
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > at java.lang.reflect.Method.invoke(Method.java:498)
> > at
> 

Write tests geronimo

[Ivan Junckes Filho]

Hello guys, I did a change on Geronimo Metrics.
https://github.com/apache/geronimo-metrics/pull/2

geronimo-metrics, as you are aware, is a library used in TomEE.

I am wondering how can I write a test for my change. Writing a test in
TomEE for this is very simple, but writing a test in geronimo I don't know
how to do it.

Basically what I need it to have an app, deploy it with a resource, call an
endpoint annotated with @Gauge and check if the gauge metric works.

https://github.com/apache/tomee/pull/213 (This does it in the TomEE side)

I see some references to Meecrowave in the project as well, not sure how
some tests use Meecrowave and if that is a pattern we should use there.

The TCK for MicroProfile Metrics is on TomEE, so the other question is if
we should just rely on the TCK or if we should not.

Thanks.

Re: Metrics Gauge Example and Bug

[Ivan Junckes Filho]

Hey guys can anyone review and merge this?

https://github.com/apache/tomee/pull/218


On Fri, Nov 23, 2018 at 2:22 PM Roberto Cortez 
wrote:

> And it did cover. The test was failing.
>
> > On 23 Nov 2018, at 16:00, Romain Manni-Bucau 
> wrote:
> >
> >
> https://github.com/apache/tomee/blob/4c7fd4af95983a92bef89dc598873310dd13dd2e/server/openejb-cxf-rs/src/test/java/org/apache/openejb/server/cxf/rs/johnzon/JsonbJaxrsProviderTest.java
> > was supposed to cover that
> >
> > Romain Manni-Bucau
> > @rmannibucau  |  Blog
> >  | Old Blog
> >  | Github <
> https://github.com/rmannibucau> |
> > LinkedIn  | Book
> > <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
> >
> >
> > Le ven. 23 nov. 2018 à 16:58, Bruno Baptista  a
> écrit :
> >
> >> We should probably add a test for that regression.
> >>
> >> Bruno Baptista
> >> https://twitter.com/brunobat_
> >>
> >>
> >> On 23/11/18 15:50, Ivan Junckes Filho wrote:
> >>> It worked, thanks man!
> >>>
> >>> On Fri, Nov 23, 2018 at 12:40 PM Roberto Cortez 
> >> wrote:
> >>>
>  Yes, that was the issue. This should fix it:
> 
> 
> >>
> https://github.com/apache/tomee/commit/1bfb65a1837235f4e9ad4458f67aabcab5eff829
> 
>  Try to pull the code and test it again.
> 
>  Cheers,
>  Roberto
> 
>  On 23 Nov 2018, at 14:14, Roberto Cortez  wrote:
> 
>  No point. I’ve found the issue:
> 
>  It’s here:
> 
> 
> >>
> https://github.com/tomitribe/tomee/commit/7f18f4bcfe64119b9001d5ac6bffeb7324987a37
> 
>  This commit reverted back the new JsonbProvider to the old
> >> JohnzonProvider.
> 
>  The fix should be just to replace one with another. Let me try it and
> >> test.
> 
>  Cheers,
>  Roberto
> 
>  On 23 Nov 2018, at 12:06, Ivan Junckes Filho 
>  wrote:
> 
>  I was using the current master.
> 
>  1.1.9
> 
>  I will try to use the version Romain proposed and see how it works.
> 
> 
>  On Thu, Nov 22, 2018 at 7:36 PM Roberto Cortez <
>  radcor...@yahoo.com.invalid> wrote:
> 
> > Hey,
> >
> > I think metrics doesn’t even run properly on TomEE 7.x because of CDI
> >> 2.0.
> >
> > Regarding the fail, I’m not sure what is wrong. I remember seeing
> that
> > before and I think it got fixed when we added the JsonB JAX-RS
> >> Provider.
> > Maybe there is a regression in some place.
> >
> > Cheers,
> > Roberto
> >
> >> On 22 Nov 2018, at 21:08, Romain Manni-Bucau  >
> > wrote:
> >> Hi Ivan
> >>
> >> Do you use tomee 8 with johnzon 1.1.10? Works well on this one
> >> normally
> > if johnzon defaults are not broken. On tomee 7 you need to add jsonb
> ;)
> >> Le jeu. 22 nov. 2018 21:51, Ivan Junckes Filho <
> ivanjunc...@gmail.com
> > > a écrit :
> >> Also there are a lot of properties being returned on that payload
> that
> > are not needed like rate1, rate5... etc.
> >>
> >>
> >> On Thu, Nov 22, 2018 at 6:26 PM Ivan Junckes Filho <
> > ivanjunc...@gmail.com > wrote:
> >> The issue with the TCK is because meter in the spec expects
> > fifteenMinRate instead of fifteenMinuteRate.
> >> Same apply for the other properties like fiveMin..oneMin..
> >>
> >> @JsonbProperty("fifteenMinRate") is probably being ignored.
> >>
> >>
> >>
> >>
> >> On Thu, Nov 22, 2018 at 5:46 PM Ivan Junckes Filho <
> > ivanjunc...@gmail.com > wrote:
> >> Hey Romain, it is actually a mapping issue. I created the PR but the
> > microprofile metrics TCK seems to be broken on TomEE, so I am not
> sure
> >> if
> > the PR is reliable.
> >> https://github.com/apache/geronimo-metrics/pull/2 <
> > https://github.com/apache/geronimo-metrics/pull/2>
> >> I will try to check what is going on with the TCK on TomEE, if you
> >> have
> > any tips let me know.
> >>
> >>
> >>
> >>
> >> On Wed, Nov 21, 2018 at 7:59 PM Romain Manni-Bucau <
> > rmannibu...@gmail.com > wrote:
> >> Hi Ivan
> >>
> >> It is a bug in tomee scanning I think
> >>
> >>
> >> Le mer. 21 nov. 2018 21:35, Ivan Junckes Filho <
> ivanjunc...@gmail.com
> > > a
> >> écrit :
> >>
> >>> Hey guys, I was writing an example of metrics gauge (WIP).
> >>>
> >>> https://github.com/apache/tomee/pull/213 <
> > https://github.com/apache/tomee/pull/213>
> >>> And I found a bug when trying access a gauge with "Accept:
> >>> application/json".
> >>>
> >>> Just to let you know that I will work on a fix for this:
> >>>
> >>> 21-Nov-2018 17:24:08.811 WARNING 

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timed example

[ivanjunckes]

GitHub user ivanjunckes opened a pull request:

https://github.com/apache/tomee/pull/218

TOMEE-2290 - Metrics timed example



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ivanjunckes/tomee metrics-timed-example

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomee/pull/218.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #218


commit db9022e95a0b0ea119146226de10c233f0ff679c
Author: ivanjunckes 
Date:   2018-11-23T13:57:51Z

adding dependencies

commit 533afa8cfa3f8c60d20683603be8b0033a5852e6
Author: ivanjunckes 
Date:   2018-11-23T14:02:52Z

Adding jax-rs resource

commit 1b7baccd47ea7816bf7c03fb2946f25a4cb63e12
Author: ivanjunckes 
Date:   2018-11-23T15:32:27Z

Merge branch 'master' of github.com:apache/tomee into metrics-timed-example

commit a87cf682cef5e6ae4c0f46409a9df5f8f4453bef
Author: ivanjunckes 
Date:   2018-11-23T18:08:47Z

Adding test and a few changes




---

Re: Please review PR# 217

[Bruno Baptista]

ok

Bruno Baptista
https://twitter.com/brunobat_


On 23/11/18 16:32, Jonathan Gallimore wrote:

I already merged it - it looked good to me. Thanks for the PR, and congrats
on your first Open Source contribution!

Jon

On Fri, 23 Nov 2018, 16:12 Frankie 
Could someone please review this PR?

It is my first contribution to an open source project ever, so please be
graceful (and give hints) if I missed something ... ;-)
This trivial dependency update was the perfect issue for that, so I could
focus on the tools and processes.

Thank you.



--
Sent from:
http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: How Can I Help?

[Michael Redlich]

Hi Ivan:

Sure thing!  I will get started on that later today!

Mike.

On Fri, Nov 23, 2018 at 11:11 AM Ivan Junckes Filho 
wrote:

> Hi Michael, great to have you here!
>
> I would suggest that you start doing some MicroProfile examples.
>
> What about taking this task?
> https://issues.apache.org/jira/browse/TOMEE-2287
>
> We have very similar examples that will help you with that, it is
> documented in the ticket.
>
> Let us know if you have questions!
>
> On Fri, Nov 23, 2018 at 1:45 PM Michael Redlich  wrote:
>
>> Hello:
>>
>> My name is Michael Redlich and I was just confirmed to the TomEE
>> Developers
>> mailing list.
>>
>> Here's some background information about myself:
>>
>>- I live in Flemington , New
>> Jersey
>>with my lovely wife, Rowena.  We love to visit New Orleans, LA and
>> Newport,
>>RI on a regular basis.  We are avid cyclists and I am an avid runner.
>>- I have worked for ExxonMobil for almost 29 years.
>>- I have been writing for InfoQ
>> since May 2016.
>>- I founded the ACGNJ Java Users Group  in 2001
>>and co-facilitate the group with Barry Burd
>>.
>>
>> I am very interested in MicroProfile APIs.  I look forward to contributing
>> to TomEE!
>>
>> Sincerely,
>>
>> Mike.
>>
>>
>>
>>
>> --
>> *Code*, *Write*, *Cycle*, *Run*, *Drink*,
>> *Sleep ... Repeat*
>>
>> *InfoQ  Java Queue Editor*
>> https://about.me/mpredli 
>> https://twitter.com/mpredli
>> https://redlich.net/
>> https://javasig.org/
>> *Laissez Les Bon Temps Rouler*
>>
>

-- 
*Code*, *Write*, *Cycle*, *Run*, *Drink*,
*Sleep ... Repeat*

*InfoQ  Java Queue Editor*
https://about.me/mpredli 
https://twitter.com/mpredli
https://redlich.net/
https://javasig.org/
*Laissez Les Bon Temps Rouler*

Re: Please review PR# 217

[Jonathan Gallimore]

I already merged it - it looked good to me. Thanks for the PR, and congrats
on your first Open Source contribution!

Jon

On Fri, 23 Nov 2018, 16:12 Frankie  Could someone please review this PR?
>
> It is my first contribution to an open source project ever, so please be
> graceful (and give hints) if I missed something ... ;-)
> This trivial dependency update was the perfect issue for that, so I could
> focus on the tools and processes.
>
> Thank you.
>
>
>
> --
> Sent from:
> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
>

Re: Please review PR# 217

[Bruno Baptista]

Thanks Frankie!

I'll have a look.

Bruno Baptista
https://twitter.com/brunobat_


On 23/11/18 16:12, Frankie wrote:

Could someone please review this PR?

It is my first contribution to an open source project ever, so please be
graceful (and give hints) if I missed something ... ;-)
This trivial dependency update was the perfect issue for that, so I could
focus on the tools and processes.

Thank you.



--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Please review PR# 217

[Frankie]

BTW: why is the automatic generated message from the PR noted "by
cesarhernandezgt"?



--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Metrics Gauge Example and Bug

[Roberto Cortez]

And it did cover. The test was failing. 

> On 23 Nov 2018, at 16:00, Romain Manni-Bucau  wrote:
> 
> https://github.com/apache/tomee/blob/4c7fd4af95983a92bef89dc598873310dd13dd2e/server/openejb-cxf-rs/src/test/java/org/apache/openejb/server/cxf/rs/johnzon/JsonbJaxrsProviderTest.java
> was supposed to cover that
> 
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github  |
> LinkedIn  | Book
> 
> 
> 
> Le ven. 23 nov. 2018 à 16:58, Bruno Baptista  a écrit :
> 
>> We should probably add a test for that regression.
>> 
>> Bruno Baptista
>> https://twitter.com/brunobat_
>> 
>> 
>> On 23/11/18 15:50, Ivan Junckes Filho wrote:
>>> It worked, thanks man!
>>> 
>>> On Fri, Nov 23, 2018 at 12:40 PM Roberto Cortez 
>> wrote:
>>> 
 Yes, that was the issue. This should fix it:
 
 
>> https://github.com/apache/tomee/commit/1bfb65a1837235f4e9ad4458f67aabcab5eff829
 
 Try to pull the code and test it again.
 
 Cheers,
 Roberto
 
 On 23 Nov 2018, at 14:14, Roberto Cortez  wrote:
 
 No point. I’ve found the issue:
 
 It’s here:
 
 
>> https://github.com/tomitribe/tomee/commit/7f18f4bcfe64119b9001d5ac6bffeb7324987a37
 
 This commit reverted back the new JsonbProvider to the old
>> JohnzonProvider.
 
 The fix should be just to replace one with another. Let me try it and
>> test.
 
 Cheers,
 Roberto
 
 On 23 Nov 2018, at 12:06, Ivan Junckes Filho 
 wrote:
 
 I was using the current master.
 
 1.1.9
 
 I will try to use the version Romain proposed and see how it works.
 
 
 On Thu, Nov 22, 2018 at 7:36 PM Roberto Cortez <
 radcor...@yahoo.com.invalid> wrote:
 
> Hey,
> 
> I think metrics doesn’t even run properly on TomEE 7.x because of CDI
>> 2.0.
> 
> Regarding the fail, I’m not sure what is wrong. I remember seeing that
> before and I think it got fixed when we added the JsonB JAX-RS
>> Provider.
> Maybe there is a regression in some place.
> 
> Cheers,
> Roberto
> 
>> On 22 Nov 2018, at 21:08, Romain Manni-Bucau 
> wrote:
>> Hi Ivan
>> 
>> Do you use tomee 8 with johnzon 1.1.10? Works well on this one
>> normally
> if johnzon defaults are not broken. On tomee 7 you need to add jsonb ;)
>> Le jeu. 22 nov. 2018 21:51, Ivan Junckes Filho  > a écrit :
>> Also there are a lot of properties being returned on that payload that
> are not needed like rate1, rate5... etc.
>> 
>> 
>> On Thu, Nov 22, 2018 at 6:26 PM Ivan Junckes Filho <
> ivanjunc...@gmail.com > wrote:
>> The issue with the TCK is because meter in the spec expects
> fifteenMinRate instead of fifteenMinuteRate.
>> Same apply for the other properties like fiveMin..oneMin..
>> 
>> @JsonbProperty("fifteenMinRate") is probably being ignored.
>> 
>> 
>> 
>> 
>> On Thu, Nov 22, 2018 at 5:46 PM Ivan Junckes Filho <
> ivanjunc...@gmail.com > wrote:
>> Hey Romain, it is actually a mapping issue. I created the PR but the
> microprofile metrics TCK seems to be broken on TomEE, so I am not sure
>> if
> the PR is reliable.
>> https://github.com/apache/geronimo-metrics/pull/2 <
> https://github.com/apache/geronimo-metrics/pull/2>
>> I will try to check what is going on with the TCK on TomEE, if you
>> have
> any tips let me know.
>> 
>> 
>> 
>> 
>> On Wed, Nov 21, 2018 at 7:59 PM Romain Manni-Bucau <
> rmannibu...@gmail.com > wrote:
>> Hi Ivan
>> 
>> It is a bug in tomee scanning I think
>> 
>> 
>> Le mer. 21 nov. 2018 21:35, Ivan Junckes Filho  > a
>> écrit :
>> 
>>> Hey guys, I was writing an example of metrics gauge (WIP).
>>> 
>>> https://github.com/apache/tomee/pull/213 <
> https://github.com/apache/tomee/pull/213>
>>> And I found a bug when trying access a gauge with "Accept:
>>> application/json".
>>> 
>>> Just to let you know that I will work on a fix for this:
>>> 
>>> 21-Nov-2018 17:24:08.811 WARNING [http-nio-8080-exec-4]
>>> org.apache.cxf.jaxrs.model.OperationResourceInfoComparator.compare
> Both
> 
>> org.apache.geronimo.microprofile.metrics.common.jaxrs.MetricsEndpoints#getJson
>>> and
>>> 
> 
>> org.apache.geronimo.microprofile.metrics.jaxrs.CdiMetricsEndpoints#getJson
>>> are equal candidates for handling the current request which can lead
> to
>>> unpredictable results
>>> 21-Nov-2018 17:26:52.183 SEVERE 

Please review PR# 217

[Frankie]

Could someone please review this PR?

It is my first contribution to an open source project ever, so please be
graceful (and give hints) if I missed something ... ;-)
This trivial dependency update was the perfect issue for that, so I could
focus on the tools and processes.

Thank you.



--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: How Can I Help?

[Ivan Junckes Filho]

Hi Michael, great to have you here!

I would suggest that you start doing some MicroProfile examples.

What about taking this task?
https://issues.apache.org/jira/browse/TOMEE-2287

We have very similar examples that will help you with that, it is
documented in the ticket.

Let us know if you have questions!

On Fri, Nov 23, 2018 at 1:45 PM Michael Redlich  wrote:

> Hello:
>
> My name is Michael Redlich and I was just confirmed to the TomEE Developers
> mailing list.
>
> Here's some background information about myself:
>
>- I live in Flemington , New Jersey
>with my lovely wife, Rowena.  We love to visit New Orleans, LA and
> Newport,
>RI on a regular basis.  We are avid cyclists and I am an avid runner.
>- I have worked for ExxonMobil for almost 29 years.
>- I have been writing for InfoQ
> since May 2016.
>- I founded the ACGNJ Java Users Group  in 2001
>and co-facilitate the group with Barry Burd
>.
>
> I am very interested in MicroProfile APIs.  I look forward to contributing
> to TomEE!
>
> Sincerely,
>
> Mike.
>
>
>
>
> --
> *Code*, *Write*, *Cycle*, *Run*, *Drink*,
> *Sleep ... Repeat*
>
> *InfoQ  Java Queue Editor*
> https://about.me/mpredli 
> https://twitter.com/mpredli
> https://redlich.net/
> https://javasig.org/
> *Laissez Les Bon Temps Rouler*
>

Re: TOMEE-2241: Best way to handle resolved Issue when update required?

[Jonathan Gallimore]

I saw your PR come in. Thanks for that - I've merged it!

Jon

On Fri, Nov 23, 2018 at 10:41 AM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:

> You did the right thing already - post here. :-) It was me that messed up,
> I apologize. A few folks are out for thanksgiving, but we'll figure out
> what's needed to get you in the right group in JIRA so you can assign
> tickets to yourself.
>
> Jon
>
> On Fri, Nov 23, 2018 at 10:39 AM Frankie  wrote:
>
>> Thank you, Jon.
>> What is the best way to claim a ticket then? Obviously we already had the
>> case that more than one wanted to do that ... ;-)
>>
>>
>>
>> --
>> Sent from:
>> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
>>
>

[GitHub] tomee pull request #217: TOMEE-2288 Update commons-lang3 to current Version ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/tomee/pull/217


---

[GitHub] tomee pull request #217: TOMEE-2288 Update commons-lang3 to current Version ...

[kaminfeuer]

GitHub user kaminfeuer opened a pull request:

https://github.com/apache/tomee/pull/217

TOMEE-2288 Update commons-lang3 to current Version 3.8.1



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kaminfeuer/tomee master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomee/pull/217.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #217


commit b1fe081be740b1b1615027e2afee090bfa7743fa
Author: Frank Jung 
Date:   2018-11-23T15:55:43Z

TOMEE-2288 Update commons-lang3 to current Version 3.8.1




---

Re: Metrics Gauge Example and Bug

[Romain Manni-Bucau]

https://github.com/apache/tomee/blob/4c7fd4af95983a92bef89dc598873310dd13dd2e/server/openejb-cxf-rs/src/test/java/org/apache/openejb/server/cxf/rs/johnzon/JsonbJaxrsProviderTest.java
was supposed to cover that

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le ven. 23 nov. 2018 à 16:58, Bruno Baptista  a écrit :

> We should probably add a test for that regression.
>
> Bruno Baptista
> https://twitter.com/brunobat_
>
>
> On 23/11/18 15:50, Ivan Junckes Filho wrote:
> > It worked, thanks man!
> >
> > On Fri, Nov 23, 2018 at 12:40 PM Roberto Cortez 
> wrote:
> >
> >> Yes, that was the issue. This should fix it:
> >>
> >>
> https://github.com/apache/tomee/commit/1bfb65a1837235f4e9ad4458f67aabcab5eff829
> >>
> >> Try to pull the code and test it again.
> >>
> >> Cheers,
> >> Roberto
> >>
> >> On 23 Nov 2018, at 14:14, Roberto Cortez  wrote:
> >>
> >> No point. I’ve found the issue:
> >>
> >> It’s here:
> >>
> >>
> https://github.com/tomitribe/tomee/commit/7f18f4bcfe64119b9001d5ac6bffeb7324987a37
> >>
> >> This commit reverted back the new JsonbProvider to the old
> JohnzonProvider.
> >>
> >> The fix should be just to replace one with another. Let me try it and
> test.
> >>
> >> Cheers,
> >> Roberto
> >>
> >> On 23 Nov 2018, at 12:06, Ivan Junckes Filho 
> >> wrote:
> >>
> >> I was using the current master.
> >>
> >> 1.1.9
> >>
> >> I will try to use the version Romain proposed and see how it works.
> >>
> >>
> >> On Thu, Nov 22, 2018 at 7:36 PM Roberto Cortez <
> >> radcor...@yahoo.com.invalid> wrote:
> >>
> >>> Hey,
> >>>
> >>> I think metrics doesn’t even run properly on TomEE 7.x because of CDI
> 2.0.
> >>>
> >>> Regarding the fail, I’m not sure what is wrong. I remember seeing that
> >>> before and I think it got fixed when we added the JsonB JAX-RS
> Provider.
> >>> Maybe there is a regression in some place.
> >>>
> >>> Cheers,
> >>> Roberto
> >>>
>  On 22 Nov 2018, at 21:08, Romain Manni-Bucau 
> >>> wrote:
>  Hi Ivan
> 
>  Do you use tomee 8 with johnzon 1.1.10? Works well on this one
> normally
> >>> if johnzon defaults are not broken. On tomee 7 you need to add jsonb ;)
>  Le jeu. 22 nov. 2018 21:51, Ivan Junckes Filho  >>> > a écrit :
>  Also there are a lot of properties being returned on that payload that
> >>> are not needed like rate1, rate5... etc.
> 
> 
>  On Thu, Nov 22, 2018 at 6:26 PM Ivan Junckes Filho <
> >>> ivanjunc...@gmail.com > wrote:
>  The issue with the TCK is because meter in the spec expects
> >>> fifteenMinRate instead of fifteenMinuteRate.
>  Same apply for the other properties like fiveMin..oneMin..
> 
>  @JsonbProperty("fifteenMinRate") is probably being ignored.
> 
> 
> 
> 
>  On Thu, Nov 22, 2018 at 5:46 PM Ivan Junckes Filho <
> >>> ivanjunc...@gmail.com > wrote:
>  Hey Romain, it is actually a mapping issue. I created the PR but the
> >>> microprofile metrics TCK seems to be broken on TomEE, so I am not sure
> if
> >>> the PR is reliable.
>  https://github.com/apache/geronimo-metrics/pull/2 <
> >>> https://github.com/apache/geronimo-metrics/pull/2>
>  I will try to check what is going on with the TCK on TomEE, if you
> have
> >>> any tips let me know.
> 
> 
> 
> 
>  On Wed, Nov 21, 2018 at 7:59 PM Romain Manni-Bucau <
> >>> rmannibu...@gmail.com > wrote:
>  Hi Ivan
> 
>  It is a bug in tomee scanning I think
> 
> 
>  Le mer. 21 nov. 2018 21:35, Ivan Junckes Filho  >>> > a
>  écrit :
> 
> > Hey guys, I was writing an example of metrics gauge (WIP).
> >
> > https://github.com/apache/tomee/pull/213 <
> >>> https://github.com/apache/tomee/pull/213>
> > And I found a bug when trying access a gauge with "Accept:
> > application/json".
> >
> > Just to let you know that I will work on a fix for this:
> >
> > 21-Nov-2018 17:24:08.811 WARNING [http-nio-8080-exec-4]
> > org.apache.cxf.jaxrs.model.OperationResourceInfoComparator.compare
> >>> Both
> >>>
> org.apache.geronimo.microprofile.metrics.common.jaxrs.MetricsEndpoints#getJson
> > and
> >
> >>>
> org.apache.geronimo.microprofile.metrics.jaxrs.CdiMetricsEndpoints#getJson
> > are equal candidates for handling the current request which can lead
> >>> to
> > unpredictable results
> > 21-Nov-2018 17:26:52.183 SEVERE [http-nio-8080-exec-4]
> > org.apache.cxf.jaxrs.utils.JAXRSUtils.logMessageHandlerProblem
> >>> Problem with
> > writing the data, class java.util.Collections$SingletonMap,
> >>> 

Re: Metrics Gauge Example and Bug

[Bruno Baptista]

We should probably add a test for that regression.

Bruno Baptista
https://twitter.com/brunobat_


On 23/11/18 15:50, Ivan Junckes Filho wrote:

It worked, thanks man!

On Fri, Nov 23, 2018 at 12:40 PM Roberto Cortez  wrote:


Yes, that was the issue. This should fix it:

https://github.com/apache/tomee/commit/1bfb65a1837235f4e9ad4458f67aabcab5eff829

Try to pull the code and test it again.

Cheers,
Roberto

On 23 Nov 2018, at 14:14, Roberto Cortez  wrote:

No point. I’ve found the issue:

It’s here:

https://github.com/tomitribe/tomee/commit/7f18f4bcfe64119b9001d5ac6bffeb7324987a37

This commit reverted back the new JsonbProvider to the old JohnzonProvider.

The fix should be just to replace one with another. Let me try it and test.

Cheers,
Roberto

On 23 Nov 2018, at 12:06, Ivan Junckes Filho 
wrote:

I was using the current master.

1.1.9

I will try to use the version Romain proposed and see how it works.


On Thu, Nov 22, 2018 at 7:36 PM Roberto Cortez <
radcor...@yahoo.com.invalid> wrote:


Hey,

I think metrics doesn’t even run properly on TomEE 7.x because of CDI 2.0.

Regarding the fail, I’m not sure what is wrong. I remember seeing that
before and I think it got fixed when we added the JsonB JAX-RS Provider.
Maybe there is a regression in some place.

Cheers,
Roberto


On 22 Nov 2018, at 21:08, Romain Manni-Bucau 

wrote:

Hi Ivan

Do you use tomee 8 with johnzon 1.1.10? Works well on this one normally

if johnzon defaults are not broken. On tomee 7 you need to add jsonb ;)

Le jeu. 22 nov. 2018 21:51, Ivan Junckes Filho 
> a écrit :

Also there are a lot of properties being returned on that payload that

are not needed like rate1, rate5... etc.



On Thu, Nov 22, 2018 at 6:26 PM Ivan Junckes Filho <

ivanjunc...@gmail.com > wrote:

The issue with the TCK is because meter in the spec expects

fifteenMinRate instead of fifteenMinuteRate.

Same apply for the other properties like fiveMin..oneMin..

@JsonbProperty("fifteenMinRate") is probably being ignored.




On Thu, Nov 22, 2018 at 5:46 PM Ivan Junckes Filho <

ivanjunc...@gmail.com > wrote:

Hey Romain, it is actually a mapping issue. I created the PR but the

microprofile metrics TCK seems to be broken on TomEE, so I am not sure if
the PR is reliable.

https://github.com/apache/geronimo-metrics/pull/2 <

https://github.com/apache/geronimo-metrics/pull/2>

I will try to check what is going on with the TCK on TomEE, if you have

any tips let me know.





On Wed, Nov 21, 2018 at 7:59 PM Romain Manni-Bucau <

rmannibu...@gmail.com > wrote:

Hi Ivan

It is a bug in tomee scanning I think


Le mer. 21 nov. 2018 21:35, Ivan Junckes Filho 
> a

écrit :


Hey guys, I was writing an example of metrics gauge (WIP).

https://github.com/apache/tomee/pull/213 <

https://github.com/apache/tomee/pull/213>

And I found a bug when trying access a gauge with "Accept:
application/json".

Just to let you know that I will work on a fix for this:

21-Nov-2018 17:24:08.811 WARNING [http-nio-8080-exec-4]
org.apache.cxf.jaxrs.model.OperationResourceInfoComparator.compare

Both
org.apache.geronimo.microprofile.metrics.common.jaxrs.MetricsEndpoints#getJson

and


org.apache.geronimo.microprofile.metrics.jaxrs.CdiMetricsEndpoints#getJson

are equal candidates for handling the current request which can lead

to

unpredictable results
21-Nov-2018 17:26:52.183 SEVERE [http-nio-8080-exec-4]
org.apache.cxf.jaxrs.utils.JAXRSUtils.logMessageHandlerProblem

Problem with

writing the data, class java.util.Collections$SingletonMap,

ContentType:

application/json
21-Nov-2018 17:26:52.184 WARNING [http-nio-8080-exec-4]
org.apache.cxf.phase.PhaseInterceptorChain.doDefaultLogging

Interceptor for

{


http://jaxrs.common.metrics.microprofile.geronimo.apache.org/}MetricsEndpoints
  <
http://jaxrs.common.metrics.microprofile.geronimo.apache.org/%7DMetricsEndpoints

has thrown exception, unwinding now
  org.apache.cxf.interceptor.Fault
at


org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.handleWriteException(JAXRSOutInterceptor.java:396)

at


org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.serializeMessage(JAXRSOutInterceptor.java:272)

at


org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.processResponse(JAXRSOutInterceptor.java:122)

at


org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.handleMessage(JAXRSOutInterceptor.java:84)

at


org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)

at


org.apache.cxf.interceptor.OutgoingChainInterceptor.handleMessage(OutgoingChainInterceptor.java:90)

at


org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)

at


org.apache.cxf.transport.ChainInitiationObserver.onMessage(ChainInitiationObserver.java:121)

at


org.apache.cxf.transport.http.AbstractHTTPDestination.invoke(AbstractHTTPDestination.java:267)

at

Re: Metrics Gauge Example and Bug

[Ivan Junckes Filho]

It worked, thanks man!

On Fri, Nov 23, 2018 at 12:40 PM Roberto Cortez  wrote:

> Yes, that was the issue. This should fix it:
>
> https://github.com/apache/tomee/commit/1bfb65a1837235f4e9ad4458f67aabcab5eff829
>
> Try to pull the code and test it again.
>
> Cheers,
> Roberto
>
> On 23 Nov 2018, at 14:14, Roberto Cortez  wrote:
>
> No point. I’ve found the issue:
>
> It’s here:
>
> https://github.com/tomitribe/tomee/commit/7f18f4bcfe64119b9001d5ac6bffeb7324987a37
>
> This commit reverted back the new JsonbProvider to the old JohnzonProvider.
>
> The fix should be just to replace one with another. Let me try it and test.
>
> Cheers,
> Roberto
>
> On 23 Nov 2018, at 12:06, Ivan Junckes Filho 
> wrote:
>
> I was using the current master.
>
> 1.1.9
>
> I will try to use the version Romain proposed and see how it works.
>
>
> On Thu, Nov 22, 2018 at 7:36 PM Roberto Cortez <
> radcor...@yahoo.com.invalid> wrote:
>
>> Hey,
>>
>> I think metrics doesn’t even run properly on TomEE 7.x because of CDI 2.0.
>>
>> Regarding the fail, I’m not sure what is wrong. I remember seeing that
>> before and I think it got fixed when we added the JsonB JAX-RS Provider.
>> Maybe there is a regression in some place.
>>
>> Cheers,
>> Roberto
>>
>> > On 22 Nov 2018, at 21:08, Romain Manni-Bucau 
>> wrote:
>> >
>> > Hi Ivan
>> >
>> > Do you use tomee 8 with johnzon 1.1.10? Works well on this one normally
>> if johnzon defaults are not broken. On tomee 7 you need to add jsonb ;)
>> >
>> > Le jeu. 22 nov. 2018 21:51, Ivan Junckes Filho > > a écrit :
>> > Also there are a lot of properties being returned on that payload that
>> are not needed like rate1, rate5... etc.
>> >
>> >
>> >
>> > On Thu, Nov 22, 2018 at 6:26 PM Ivan Junckes Filho <
>> ivanjunc...@gmail.com > wrote:
>> > The issue with the TCK is because meter in the spec expects
>> fifteenMinRate instead of fifteenMinuteRate.
>> >
>> > Same apply for the other properties like fiveMin..oneMin..
>> >
>> > @JsonbProperty("fifteenMinRate") is probably being ignored.
>> >
>> >
>> >
>> >
>> > On Thu, Nov 22, 2018 at 5:46 PM Ivan Junckes Filho <
>> ivanjunc...@gmail.com > wrote:
>> > Hey Romain, it is actually a mapping issue. I created the PR but the
>> microprofile metrics TCK seems to be broken on TomEE, so I am not sure if
>> the PR is reliable.
>> > https://github.com/apache/geronimo-metrics/pull/2 <
>> https://github.com/apache/geronimo-metrics/pull/2>
>> >
>> > I will try to check what is going on with the TCK on TomEE, if you have
>> any tips let me know.
>> >
>> >
>> >
>> >
>> >
>> > On Wed, Nov 21, 2018 at 7:59 PM Romain Manni-Bucau <
>> rmannibu...@gmail.com > wrote:
>> > Hi Ivan
>> >
>> > It is a bug in tomee scanning I think
>> >
>> >
>> > Le mer. 21 nov. 2018 21:35, Ivan Junckes Filho > > a
>> > écrit :
>> >
>> > > Hey guys, I was writing an example of metrics gauge (WIP).
>> > >
>> > > https://github.com/apache/tomee/pull/213 <
>> https://github.com/apache/tomee/pull/213>
>> > >
>> > > And I found a bug when trying access a gauge with "Accept:
>> > > application/json".
>> > >
>> > > Just to let you know that I will work on a fix for this:
>> > >
>> > > 21-Nov-2018 17:24:08.811 WARNING [http-nio-8080-exec-4]
>> > > org.apache.cxf.jaxrs.model.OperationResourceInfoComparator.compare
>> Both
>> > >
>> org.apache.geronimo.microprofile.metrics.common.jaxrs.MetricsEndpoints#getJson
>> > > and
>> > >
>> org.apache.geronimo.microprofile.metrics.jaxrs.CdiMetricsEndpoints#getJson
>> > > are equal candidates for handling the current request which can lead
>> to
>> > > unpredictable results
>> > > 21-Nov-2018 17:26:52.183 SEVERE [http-nio-8080-exec-4]
>> > > org.apache.cxf.jaxrs.utils.JAXRSUtils.logMessageHandlerProblem
>> Problem with
>> > > writing the data, class java.util.Collections$SingletonMap,
>> ContentType:
>> > > application/json
>> > > 21-Nov-2018 17:26:52.184 WARNING [http-nio-8080-exec-4]
>> > > org.apache.cxf.phase.PhaseInterceptorChain.doDefaultLogging
>> Interceptor for
>> > > {
>> > >
>> http://jaxrs.common.metrics.microprofile.geronimo.apache.org/}MetricsEndpoints
>>  <
>> http://jaxrs.common.metrics.microprofile.geronimo.apache.org/%7DMetricsEndpoints
>> >
>> > > has thrown exception, unwinding now
>> > >  org.apache.cxf.interceptor.Fault
>> > > at
>> > >
>> org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.handleWriteException(JAXRSOutInterceptor.java:396)
>> > > at
>> > >
>> org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.serializeMessage(JAXRSOutInterceptor.java:272)
>> > > at
>> > >
>> org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.processResponse(JAXRSOutInterceptor.java:122)
>> > > at
>> > >
>> org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.handleMessage(JAXRSOutInterceptor.java:84)
>> > > at
>> > >
>> org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)
>> 

[GitHub] tomee issue #215: WIP mp-metrics-metered

[ivanjunckes]

Github user ivanjunckes commented on the issue:

https://github.com/apache/tomee/pull/215
  
@ferdisn good news. @radcortez has fixed the issue.

There was a regression with the jsonb provider that caused the issue.

https://github.com/apache/tomee/commit/1bfb65a1837235f4e9ad4458f67aabcab5eff829

Update your tomee master and try again.


---

How Can I Help?

[Michael Redlich]

Hello:

My name is Michael Redlich and I was just confirmed to the TomEE Developers
mailing list.

Here's some background information about myself:

   - I live in Flemington , New Jersey
   with my lovely wife, Rowena.  We love to visit New Orleans, LA and Newport,
   RI on a regular basis.  We are avid cyclists and I am an avid runner.
   - I have worked for ExxonMobil for almost 29 years.
   - I have been writing for InfoQ
    since May 2016.
   - I founded the ACGNJ Java Users Group  in 2001
   and co-facilitate the group with Barry Burd
   .

I am very interested in MicroProfile APIs.  I look forward to contributing
to TomEE!

Sincerely,

Mike.




-- 
*Code*, *Write*, *Cycle*, *Run*, *Drink*,
*Sleep ... Repeat*

*InfoQ  Java Queue Editor*
https://about.me/mpredli 
https://twitter.com/mpredli
https://redlich.net/
https://javasig.org/
*Laissez Les Bon Temps Rouler*

Re: Please review PR #201

[Romain Manni-Bucau]

Le ven. 23 nov. 2018 à 16:34, Bruno Baptista  a écrit :

> Hi Romain,
>
> About "The point is not the cdi bean but the executor. So high level you
> deploy an
> app not using safeguard but it being present and you ensure the container
> has no executor resource instantiated (you will get one (the facade))."
>
> Sorry Romain, I still don't understand how the code in the PR can
> possible affect something not using the FT API or Safeguard in particular.
>

I think the code is ok but it uses assumptions which are likely not obvious
and it is not tested so next commit will break it - since this code must be
reworked anyway - and you will not see it.
So better to ensure the build guarantee all the outcome we want for end
users.


>
> In relation to the Managed executor... What you say makes sense but I
> wonder how likely it is to happen and if it's enough to hold the PR. Do
> you have a custom executor example somewhere?
>

We have some in the core tests you can reuse. But long story short you run
your test, don't use safeguard and guarantee in @Test by looking up the
resource directly using internals (SystemInstance > ContainerSystem and so
on) that the instance is not yet instantiated. See for a test doing exactly
that:
https://github.com/apache/tomee/blob/master/container/openejb-core/src/test/java/org/apache/openejb/assembler/classic/LazyResourceTest.java#L41

To summarize:

1. CDI is lazy
2. we define the default executor as being lazy
3. we assume safeguard will not impact an app not using it

==> you must ensure that 3 didnt trigger an executor creation, it is fine
to rely on 1+2 (which means so "main" code)


>
> Cheers
>
> Bruno Baptista
> https://twitter.com/brunobat_
>
>
> On 23/11/18 15:14, Romain Manni-Bucau wrote:
> > Le ven. 23 nov. 2018 à 15:49, Bruno Baptista  a
> écrit :
> >
> >> Hi Romain,
> >>
> >> Thanks for your comment.
> >>
> >> The class doing the resource injection is lazy loaded, specifically
> >> /FailsafeContainerExecutionManagerProvider/. I did verify it in
> >> development but no test was produced... And to say the truth I wouldn't
> >> know how to validate if a bean has already been loaded or not. Can you
> >> please provide a test example?
> >>
> > The point is not the cdi bean but the executor. So high level you deploy
> an
> > app not using safeguard but it being present and you ensure the container
> > has no executor resource instantiated (you will get one (the facade)).
> >
> >
> >> Please explain what do you mean by "MP-fault-tolerance executor for that
> >> case if noone exists". It will exist, that's the whole purpose of this
> >> PR. Can you please provide an example where a
> >> /ManagedScheduledExecutorService/ will not be present?
> >>
> > You can see it as "don't let it default to a random executor". This is
> the
> > current behavior. So here is what can happen:
> >
> > 1. The user doesnt use any executor -> it defaults -> it is ok
> > 2. The user uses one or more executors for his app -> it defaults to it
> ->
> > it messes up the app and does not have the expected setting
> >
> > Case 2 is important cause it can really make it not functional and even
> > lead to locks in some cases so better to not let it happen and just
> create
> > a safeguard executor if
> > the user didnt specify he wants safeguard to use the executor
> > "'mysafeguardexecutor".
> >
> > This is why the config is important and I mentionned it early even if it
> is
> > not the most sexy part to do, I agree.
> >
> >
> >> Cheers
> >>
> >> Bruno Baptista
> >> https://twitter.com/brunobat_
> >>
> >>
> >> On 23/11/18 14:39, Romain Manni-Bucau wrote:
>  It's lazily loaded, so no worries on that regard.
> >>> What is "it" here? :)
> >>>
> >>> Conretely the bean instantiation yes cause it is normal scoped and the
> >>> resource too cause it is by default lazy in tomee (service-jar.xml) but
> >> it
> >>> is worth a test that prevent regression on that behavior IMHO, I didn't
> >>> catch on in the PR.
> >>>
> >>> Concretely in terms of container we can want to create a dedicated
> >>> MP-fault-tolerance executor for that case if noone exists and the user
> >>> didn't specify one cause this default behavior (cumulated with tomee
> >>> defaulting on @Resouce) will make this not reliable which is quite
> >>> ridiculous when you think about it for something about failt tolerance.
> >>> This is why it should be in before next release. Now if you do the PR
> >> next
> >>> week it is fine, was not to do it today but to ensure it is not merged
> >> and
> >>> the enthusiasm makes it forgotten.
> >>>
> >>> Romain Manni-Bucau
> >>> @rmannibucau  |  Blog
> >>>  | Old Blog
> >>>  | Github <
> >> https://github.com/rmannibucau> |
> >>> LinkedIn  | Book
> >>> <
> >>
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >>>
> >>>
> >>> Le ven. 23 

Re: How can I help?

[Jose Henrique Ventura]

Hi Guys,

Many thanks for the Welcome Jean and thanks for sharing your thoughts with the 
community, Richard.

Either Java EE 8 support and Microprofile examples sound good to me but I would 
say the examples could be a good start to get involved how you guys work and 
step by step we can go pointing to other directions.


Best Regards,
José Henrique Ventura.
https://josehenriqueventura.github.io

Sent with ProtonMail Secure Email.

‐‐‐ Original Message ‐‐‐
On Friday, November 23, 2018 11:54 AM, Richard Monson-Haefel 
 wrote:

> Welcome, José!
>
> I'm so glad you've decided to get involved! If you need any more help, and
> I'm sure you will because everyone doest at first, please let us know.
> Everyone here wants to see you succeed!
>
> Richard
>
> On Thu, Nov 22, 2018 at 3:31 PM Jose Henrique Ventura
> jose.vent...@protonmail.com.invalid wrote:
>
> > Hi Guys,
> > Today I stepped by Richard Monson-Haefel's tweet where he describes his
> > journey with Open Source projects and
> > I really liked the initiative of encouraging developers to join an Open
> > Source project. I know that there are many Open Source project around there
> > but I think there is a lack of information of how people can get started
> > with.
> > I'm really interested in getting started with an Open Source project
> > especially now with Jakarta EE and MicroProfile.
> > I'm interested and I would like to know "How can I help?". =)
> > Best Regards,
> > José Henrique Ventura.
> > https://josehenriqueventura.github.io
> > Sent with ProtonMail Secure Email.

Re: Please review PR #201

[Bruno Baptista]

Hi Romain,

About "The point is not the cdi bean but the executor. So high level you 
deploy an

app not using safeguard but it being present and you ensure the container
has no executor resource instantiated (you will get one (the facade))."

Sorry Romain, I still don't understand how the code in the PR can 
possible affect something not using the FT API or Safeguard in particular.


In relation to the Managed executor... What you say makes sense but I 
wonder how likely it is to happen and if it's enough to hold the PR. Do 
you have a custom executor example somewhere?


Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 23/11/18 15:14, Romain Manni-Bucau wrote:

Le ven. 23 nov. 2018 à 15:49, Bruno Baptista  a écrit :


Hi Romain,

Thanks for your comment.

The class doing the resource injection is lazy loaded, specifically
/FailsafeContainerExecutionManagerProvider/. I did verify it in
development but no test was produced... And to say the truth I wouldn't
know how to validate if a bean has already been loaded or not. Can you
please provide a test example?


The point is not the cdi bean but the executor. So high level you deploy an
app not using safeguard but it being present and you ensure the container
has no executor resource instantiated (you will get one (the facade)).



Please explain what do you mean by "MP-fault-tolerance executor for that
case if noone exists". It will exist, that's the whole purpose of this
PR. Can you please provide an example where a
/ManagedScheduledExecutorService/ will not be present?


You can see it as "don't let it default to a random executor". This is the
current behavior. So here is what can happen:

1. The user doesnt use any executor -> it defaults -> it is ok
2. The user uses one or more executors for his app -> it defaults to it ->
it messes up the app and does not have the expected setting

Case 2 is important cause it can really make it not functional and even
lead to locks in some cases so better to not let it happen and just create
a safeguard executor if
the user didnt specify he wants safeguard to use the executor
"'mysafeguardexecutor".

This is why the config is important and I mentionned it early even if it is
not the most sexy part to do, I agree.



Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 23/11/18 14:39, Romain Manni-Bucau wrote:

It's lazily loaded, so no worries on that regard.

What is "it" here? :)

Conretely the bean instantiation yes cause it is normal scoped and the
resource too cause it is by default lazy in tomee (service-jar.xml) but

it

is worth a test that prevent regression on that behavior IMHO, I didn't
catch on in the PR.

Concretely in terms of container we can want to create a dedicated
MP-fault-tolerance executor for that case if noone exists and the user
didn't specify one cause this default behavior (cumulated with tomee
defaulting on @Resouce) will make this not reliable which is quite
ridiculous when you think about it for something about failt tolerance.
This is why it should be in before next release. Now if you do the PR

next

week it is fine, was not to do it today but to ensure it is not merged

and

the enthusiasm makes it forgotten.

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github <

https://github.com/rmannibucau> |

LinkedIn  | Book
<

https://www.packtpub.com/application-development/java-ee-8-high-performance



Le ven. 23 nov. 2018 à 15:18, Jonathan Gallimore <
jonathan.gallim...@gmail.com> a écrit :


Maybe add those config options in a second PR? What do you think?

Jon

On Fri, Nov 23, 2018 at 2:01 PM Bruno Baptista 

wrote:

Hi Romain,

In the end I decided to simply use the server default, for now.

It will only be used if annotations are called in the code. It's lazily
loaded, so no worries on that regard.

Cheers.

Bruno Baptista
https://twitter.com/brunobat_


On 23/11/18 12:31, Romain Manni-Bucau wrote:

Didnt you want to make the pool configurable and not instantiated if

not

used?

Le ven. 23 nov. 2018 13:20, Daniel Cunha  a

écrit :

Hey Bruno,

awesome! It really sounds good! I just push my +1 :)

Em sex, 23 de nov de 2018 às 06:44, Bruno Baptista <

bruno...@gmail.com>

escreveu:


Thanks!

Additionally, I've requested a Safeguard 1.0.1 release. we shouldn't

be

using snapshots.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 22/11/18 19:30, Roberto Cortez wrote:

Cool! Thank you.

I’ll have a look.


On 22 Nov 2018, at 19:08, Bruno Baptista 

wrote:

Hi!

I think the code is ready. Can some of you please review this pull

request:

https://github.com/apache/tomee/pull/201

Related to:TOMEE-2278 <

https://issues.apache.org/jira/browse/TOMEE-2278>-

Use Managed Executor with Safeguard Fault Tolerance lib

Cheers.

--
Bruno Baptista
https://twitter.com/brunobat_



--
Daniel "soro" Cunha

Re: Please review PR #201

[Romain Manni-Bucau]

Le ven. 23 nov. 2018 à 15:49, Bruno Baptista  a écrit :

> Hi Romain,
>
> Thanks for your comment.
>
> The class doing the resource injection is lazy loaded, specifically
> /FailsafeContainerExecutionManagerProvider/. I did verify it in
> development but no test was produced... And to say the truth I wouldn't
> know how to validate if a bean has already been loaded or not. Can you
> please provide a test example?
>

The point is not the cdi bean but the executor. So high level you deploy an
app not using safeguard but it being present and you ensure the container
has no executor resource instantiated (you will get one (the facade)).


>
> Please explain what do you mean by "MP-fault-tolerance executor for that
> case if noone exists". It will exist, that's the whole purpose of this
> PR. Can you please provide an example where a
> /ManagedScheduledExecutorService/ will not be present?
>

You can see it as "don't let it default to a random executor". This is the
current behavior. So here is what can happen:

1. The user doesnt use any executor -> it defaults -> it is ok
2. The user uses one or more executors for his app -> it defaults to it ->
it messes up the app and does not have the expected setting

Case 2 is important cause it can really make it not functional and even
lead to locks in some cases so better to not let it happen and just create
a safeguard executor if
the user didnt specify he wants safeguard to use the executor
"'mysafeguardexecutor".

This is why the config is important and I mentionned it early even if it is
not the most sexy part to do, I agree.


>
> Cheers
>
> Bruno Baptista
> https://twitter.com/brunobat_
>
>
> On 23/11/18 14:39, Romain Manni-Bucau wrote:
> >> It's lazily loaded, so no worries on that regard.
> > What is "it" here? :)
> >
> > Conretely the bean instantiation yes cause it is normal scoped and the
> > resource too cause it is by default lazy in tomee (service-jar.xml) but
> it
> > is worth a test that prevent regression on that behavior IMHO, I didn't
> > catch on in the PR.
> >
> > Concretely in terms of container we can want to create a dedicated
> > MP-fault-tolerance executor for that case if noone exists and the user
> > didn't specify one cause this default behavior (cumulated with tomee
> > defaulting on @Resouce) will make this not reliable which is quite
> > ridiculous when you think about it for something about failt tolerance.
> > This is why it should be in before next release. Now if you do the PR
> next
> > week it is fine, was not to do it today but to ensure it is not merged
> and
> > the enthusiasm makes it forgotten.
> >
> > Romain Manni-Bucau
> > @rmannibucau  |  Blog
> >  | Old Blog
> >  | Github <
> https://github.com/rmannibucau> |
> > LinkedIn  | Book
> > <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
> >
> >
> > Le ven. 23 nov. 2018 à 15:18, Jonathan Gallimore <
> > jonathan.gallim...@gmail.com> a écrit :
> >
> >> Maybe add those config options in a second PR? What do you think?
> >>
> >> Jon
> >>
> >> On Fri, Nov 23, 2018 at 2:01 PM Bruno Baptista 
> wrote:
> >>
> >>> Hi Romain,
> >>>
> >>> In the end I decided to simply use the server default, for now.
> >>>
> >>> It will only be used if annotations are called in the code. It's lazily
> >>> loaded, so no worries on that regard.
> >>>
> >>> Cheers.
> >>>
> >>> Bruno Baptista
> >>> https://twitter.com/brunobat_
> >>>
> >>>
> >>> On 23/11/18 12:31, Romain Manni-Bucau wrote:
>  Didnt you want to make the pool configurable and not instantiated if
> >> not
>  used?
> 
>  Le ven. 23 nov. 2018 13:20, Daniel Cunha  a
> >>> écrit :
> > Hey Bruno,
> >
> > awesome! It really sounds good! I just push my +1 :)
> >
> > Em sex, 23 de nov de 2018 às 06:44, Bruno Baptista <
> >> bruno...@gmail.com>
> > escreveu:
> >
> >> Thanks!
> >>
> >> Additionally, I've requested a Safeguard 1.0.1 release. we shouldn't
> >> be
> >> using snapshots.
> >>
> >> Cheers
> >>
> >> Bruno Baptista
> >> https://twitter.com/brunobat_
> >>
> >>
> >> On 22/11/18 19:30, Roberto Cortez wrote:
> >>> Cool! Thank you.
> >>>
> >>> I’ll have a look.
> >>>
>  On 22 Nov 2018, at 19:08, Bruno Baptista 
> >> wrote:
>  Hi!
> 
>  I think the code is ready. Can some of you please review this pull
> >> request:
>  https://github.com/apache/tomee/pull/201
> 
>  Related to:TOMEE-2278 <
> > https://issues.apache.org/jira/browse/TOMEE-2278>-
> >> Use Managed Executor with Safeguard Fault Tolerance lib
>  Cheers.
> 
>  --
>  Bruno Baptista
>  https://twitter.com/brunobat_
> 
> 
> > --
> > Daniel "soro" Cunha
> > 

Re: Please review PR #201

[Bruno Baptista]

Hi Romain,

Thanks for your comment.

The class doing the resource injection is lazy loaded, specifically 
/FailsafeContainerExecutionManagerProvider/. I did verify it in 
development but no test was produced... And to say the truth I wouldn't 
know how to validate if a bean has already been loaded or not. Can you 
please provide a test example?


Please explain what do you mean by "MP-fault-tolerance executor for that 
case if noone exists". It will exist, that's the whole purpose of this 
PR. Can you please provide an example where a 
/ManagedScheduledExecutorService/ will not be present?


Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 23/11/18 14:39, Romain Manni-Bucau wrote:

It's lazily loaded, so no worries on that regard.

What is "it" here? :)

Conretely the bean instantiation yes cause it is normal scoped and the
resource too cause it is by default lazy in tomee (service-jar.xml) but it
is worth a test that prevent regression on that behavior IMHO, I didn't
catch on in the PR.

Concretely in terms of container we can want to create a dedicated
MP-fault-tolerance executor for that case if noone exists and the user
didn't specify one cause this default behavior (cumulated with tomee
defaulting on @Resouce) will make this not reliable which is quite
ridiculous when you think about it for something about failt tolerance.
This is why it should be in before next release. Now if you do the PR next
week it is fine, was not to do it today but to ensure it is not merged and
the enthusiasm makes it forgotten.

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le ven. 23 nov. 2018 à 15:18, Jonathan Gallimore <
jonathan.gallim...@gmail.com> a écrit :


Maybe add those config options in a second PR? What do you think?

Jon

On Fri, Nov 23, 2018 at 2:01 PM Bruno Baptista  wrote:


Hi Romain,

In the end I decided to simply use the server default, for now.

It will only be used if annotations are called in the code. It's lazily
loaded, so no worries on that regard.

Cheers.

Bruno Baptista
https://twitter.com/brunobat_


On 23/11/18 12:31, Romain Manni-Bucau wrote:

Didnt you want to make the pool configurable and not instantiated if

not

used?

Le ven. 23 nov. 2018 13:20, Daniel Cunha  a

écrit :

Hey Bruno,

awesome! It really sounds good! I just push my +1 :)

Em sex, 23 de nov de 2018 às 06:44, Bruno Baptista <

bruno...@gmail.com>

escreveu:


Thanks!

Additionally, I've requested a Safeguard 1.0.1 release. we shouldn't

be

using snapshots.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 22/11/18 19:30, Roberto Cortez wrote:

Cool! Thank you.

I’ll have a look.


On 22 Nov 2018, at 19:08, Bruno Baptista 

wrote:

Hi!

I think the code is ready. Can some of you please review this pull

request:

https://github.com/apache/tomee/pull/201

Related to:TOMEE-2278 <

https://issues.apache.org/jira/browse/TOMEE-2278>-

Use Managed Executor with Safeguard Fault Tolerance lib

Cheers.

--
Bruno Baptista
https://twitter.com/brunobat_



--
Daniel "soro" Cunha
https://twitter.com/dvlc_

Re: Please review PR #201

[Romain Manni-Bucau]

> It's lazily loaded, so no worries on that regard.

What is "it" here? :)

Conretely the bean instantiation yes cause it is normal scoped and the
resource too cause it is by default lazy in tomee (service-jar.xml) but it
is worth a test that prevent regression on that behavior IMHO, I didn't
catch on in the PR.

Concretely in terms of container we can want to create a dedicated
MP-fault-tolerance executor for that case if noone exists and the user
didn't specify one cause this default behavior (cumulated with tomee
defaulting on @Resouce) will make this not reliable which is quite
ridiculous when you think about it for something about failt tolerance.
This is why it should be in before next release. Now if you do the PR next
week it is fine, was not to do it today but to ensure it is not merged and
the enthusiasm makes it forgotten.

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le ven. 23 nov. 2018 à 15:18, Jonathan Gallimore <
jonathan.gallim...@gmail.com> a écrit :

> Maybe add those config options in a second PR? What do you think?
>
> Jon
>
> On Fri, Nov 23, 2018 at 2:01 PM Bruno Baptista  wrote:
>
> > Hi Romain,
> >
> > In the end I decided to simply use the server default, for now.
> >
> > It will only be used if annotations are called in the code. It's lazily
> > loaded, so no worries on that regard.
> >
> > Cheers.
> >
> > Bruno Baptista
> > https://twitter.com/brunobat_
> >
> >
> > On 23/11/18 12:31, Romain Manni-Bucau wrote:
> > > Didnt you want to make the pool configurable and not instantiated if
> not
> > > used?
> > >
> > > Le ven. 23 nov. 2018 13:20, Daniel Cunha  a
> > écrit :
> > >
> > >> Hey Bruno,
> > >>
> > >> awesome! It really sounds good! I just push my +1 :)
> > >>
> > >> Em sex, 23 de nov de 2018 às 06:44, Bruno Baptista <
> bruno...@gmail.com>
> > >> escreveu:
> > >>
> > >>> Thanks!
> > >>>
> > >>> Additionally, I've requested a Safeguard 1.0.1 release. we shouldn't
> be
> > >>> using snapshots.
> > >>>
> > >>> Cheers
> > >>>
> > >>> Bruno Baptista
> > >>> https://twitter.com/brunobat_
> > >>>
> > >>>
> > >>> On 22/11/18 19:30, Roberto Cortez wrote:
> >  Cool! Thank you.
> > 
> >  I’ll have a look.
> > 
> > > On 22 Nov 2018, at 19:08, Bruno Baptista 
> wrote:
> > >
> > > Hi!
> > >
> > > I think the code is ready. Can some of you please review this pull
> > >>> request:
> > > https://github.com/apache/tomee/pull/201
> > >
> > > Related to:TOMEE-2278 <
> > >> https://issues.apache.org/jira/browse/TOMEE-2278>-
> > >>> Use Managed Executor with Safeguard Fault Tolerance lib
> > > Cheers.
> > >
> > > --
> > > Bruno Baptista
> > > https://twitter.com/brunobat_
> > >
> > >
> > >>
> > >> --
> > >> Daniel "soro" Cunha
> > >> https://twitter.com/dvlc_
> > >>
> >
>

Re: Metrics Gauge Example and Bug

[Roberto Cortez]

Yes, that was the issue. This should fix it:
https://github.com/apache/tomee/commit/1bfb65a1837235f4e9ad4458f67aabcab5eff829 


Try to pull the code and test it again.

Cheers,
Roberto

> On 23 Nov 2018, at 14:14, Roberto Cortez  wrote:
> 
> No point. I’ve found the issue:
> 
> It’s here:
> https://github.com/tomitribe/tomee/commit/7f18f4bcfe64119b9001d5ac6bffeb7324987a37
>  
> 
> 
> This commit reverted back the new JsonbProvider to the old JohnzonProvider.
> 
> The fix should be just to replace one with another. Let me try it and test.
> 
> Cheers,
> Roberto
> 
>> On 23 Nov 2018, at 12:06, Ivan Junckes Filho > > wrote:
>> 
>> I was using the current master.
>> 1.1.9
>> I will try to use the version Romain proposed and see how it works.
>> 
>> On Thu, Nov 22, 2018 at 7:36 PM Roberto Cortez > > wrote:
>> Hey,
>> 
>> I think metrics doesn’t even run properly on TomEE 7.x because of CDI 2.0.
>> 
>> Regarding the fail, I’m not sure what is wrong. I remember seeing that 
>> before and I think it got fixed when we added the JsonB JAX-RS Provider. 
>> Maybe there is a regression in some place.
>> 
>> Cheers,
>> Roberto
>> 
>> > On 22 Nov 2018, at 21:08, Romain Manni-Bucau > > > wrote:
>> > 
>> > Hi Ivan
>> > 
>> > Do you use tomee 8 with johnzon 1.1.10? Works well on this one normally if 
>> > johnzon defaults are not broken. On tomee 7 you need to add jsonb ;)
>> > 
>> > Le jeu. 22 nov. 2018 21:51, Ivan Junckes Filho > >  > > >> a écrit :
>> > Also there are a lot of properties being returned on that payload that are 
>> > not needed like rate1, rate5... etc.
>> > 
>> > 
>> > 
>> > On Thu, Nov 22, 2018 at 6:26 PM Ivan Junckes Filho > >  > > >> wrote:
>> > The issue with the TCK is because meter in the spec expects fifteenMinRate 
>> > instead of fifteenMinuteRate.
>> > 
>> > Same apply for the other properties like fiveMin..oneMin..
>> > 
>> > @JsonbProperty("fifteenMinRate") is probably being ignored.
>> > 
>> > 
>> > 
>> > 
>> > On Thu, Nov 22, 2018 at 5:46 PM Ivan Junckes Filho > >  > > >> wrote:
>> > Hey Romain, it is actually a mapping issue. I created the PR but the 
>> > microprofile metrics TCK seems to be broken on TomEE, so I am not sure if 
>> > the PR is reliable.
>> > https://github.com/apache/geronimo-metrics/pull/2 
>> >  
>> > > > >
>> > 
>> > I will try to check what is going on with the TCK on TomEE, if you have 
>> > any tips let me know.
>> > 
>> > 
>> > 
>> > 
>> > 
>> > On Wed, Nov 21, 2018 at 7:59 PM Romain Manni-Bucau > >  > > >> wrote:
>> > Hi Ivan
>> > 
>> > It is a bug in tomee scanning I think
>> > 
>> > 
>> > Le mer. 21 nov. 2018 21:35, Ivan Junckes Filho > >  > > >> a
>> > écrit :
>> > 
>> > > Hey guys, I was writing an example of metrics gauge (WIP).
>> > >
>> > > https://github.com/apache/tomee/pull/213 
>> > >  
>> > > > > > >
>> > >
>> > > And I found a bug when trying access a gauge with "Accept:
>> > > application/json".
>> > >
>> > > Just to let you know that I will work on a fix for this:
>> > >
>> > > 21-Nov-2018 17:24:08.811 WARNING [http-nio-8080-exec-4]
>> > > org.apache.cxf.jaxrs.model.OperationResourceInfoComparator.compare Both
>> > > org.apache.geronimo.microprofile.metrics.common.jaxrs.MetricsEndpoints#getJson
>> > > and
>> > > org.apache.geronimo.microprofile.metrics.jaxrs.CdiMetricsEndpoints#getJson
>> > > are equal candidates for handling the current request which can lead to
>> > > unpredictable results
>> > > 21-Nov-2018 17:26:52.183 SEVERE [http-nio-8080-exec-4]
>> > > org.apache.cxf.jaxrs.utils.JAXRSUtils.logMessageHandlerProblem Problem 
>> > > with
>> > > writing the data, class java.util.Collections$SingletonMap, ContentType:
>> > > application/json
>> > > 21-Nov-2018 17:26:52.184 WARNING [http-nio-8080-exec-4]
>> > > org.apache.cxf.phase.PhaseInterceptorChain.doDefaultLogging Interceptor 
>> > > for
>> > > {
>> > > http://jaxrs.common.metrics.microprofile.geronimo.apache.org/}MetricsEndpoints
>> > >  
>> > > 

Re: Please review PR #201

[Roberto Cortez]

I’m ok with that.

> On 23 Nov 2018, at 14:15, Bruno Baptista  wrote:
> 
> So... Jon suggested to me that the configurable resource can be done in an 
> additional PR by one of the new guys. I think it's an excellent ideal.
> 
> If no one disagrees, I'll create a Jira with the details for it.
> 
> Bruno Baptista
> https://twitter.com/brunobat_
> 
> 
> On 23/11/18 14:05, Roberto Cortez wrote:
>> If we are happy, I would like to merge it. I could use some of the common 
>> project setup for other work.
>> 
>>> On 23 Nov 2018, at 14:01, Bruno Baptista  wrote:
>>> 
>>> Hi Romain,
>>> 
>>> In the end I decided to simply use the server default, for now.
>>> 
>>> It will only be used if annotations are called in the code. It's lazily 
>>> loaded, so no worries on that regard.
>>> 
>>> Cheers.
>>> 
>>> Bruno Baptista
>>> https://twitter.com/brunobat_
>>> 
>>> 
>>> On 23/11/18 12:31, Romain Manni-Bucau wrote:
 Didnt you want to make the pool configurable and not instantiated if not
 used?
 
 Le ven. 23 nov. 2018 13:20, Daniel Cunha  a écrit :
 
> Hey Bruno,
> 
> awesome! It really sounds good! I just push my +1 :)
> 
> Em sex, 23 de nov de 2018 às 06:44, Bruno Baptista 
> escreveu:
> 
>> Thanks!
>> 
>> Additionally, I've requested a Safeguard 1.0.1 release. we shouldn't be
>> using snapshots.
>> 
>> Cheers
>> 
>> Bruno Baptista
>> https://twitter.com/brunobat_
>> 
>> 
>> On 22/11/18 19:30, Roberto Cortez wrote:
>>> Cool! Thank you.
>>> 
>>> I’ll have a look.
>>> 
 On 22 Nov 2018, at 19:08, Bruno Baptista  wrote:
 
 Hi!
 
 I think the code is ready. Can some of you please review this pull
>> request:
 https://github.com/apache/tomee/pull/201
 
 Related to:TOMEE-2278 <
> https://issues.apache.org/jira/browse/TOMEE-2278>-
>> Use Managed Executor with Safeguard Fault Tolerance lib
 Cheers.
 
 --
 Bruno Baptista
 https://twitter.com/brunobat_
 
 
> --
> Daniel "soro" Cunha
> https://twitter.com/dvlc_
> 

Re: Please review PR #201

[Jonathan Gallimore]

Maybe add those config options in a second PR? What do you think?

Jon

On Fri, Nov 23, 2018 at 2:01 PM Bruno Baptista  wrote:

> Hi Romain,
>
> In the end I decided to simply use the server default, for now.
>
> It will only be used if annotations are called in the code. It's lazily
> loaded, so no worries on that regard.
>
> Cheers.
>
> Bruno Baptista
> https://twitter.com/brunobat_
>
>
> On 23/11/18 12:31, Romain Manni-Bucau wrote:
> > Didnt you want to make the pool configurable and not instantiated if not
> > used?
> >
> > Le ven. 23 nov. 2018 13:20, Daniel Cunha  a
> écrit :
> >
> >> Hey Bruno,
> >>
> >> awesome! It really sounds good! I just push my +1 :)
> >>
> >> Em sex, 23 de nov de 2018 às 06:44, Bruno Baptista 
> >> escreveu:
> >>
> >>> Thanks!
> >>>
> >>> Additionally, I've requested a Safeguard 1.0.1 release. we shouldn't be
> >>> using snapshots.
> >>>
> >>> Cheers
> >>>
> >>> Bruno Baptista
> >>> https://twitter.com/brunobat_
> >>>
> >>>
> >>> On 22/11/18 19:30, Roberto Cortez wrote:
>  Cool! Thank you.
> 
>  I’ll have a look.
> 
> > On 22 Nov 2018, at 19:08, Bruno Baptista  wrote:
> >
> > Hi!
> >
> > I think the code is ready. Can some of you please review this pull
> >>> request:
> > https://github.com/apache/tomee/pull/201
> >
> > Related to:TOMEE-2278 <
> >> https://issues.apache.org/jira/browse/TOMEE-2278>-
> >>> Use Managed Executor with Safeguard Fault Tolerance lib
> > Cheers.
> >
> > --
> > Bruno Baptista
> > https://twitter.com/brunobat_
> >
> >
> >>
> >> --
> >> Daniel "soro" Cunha
> >> https://twitter.com/dvlc_
> >>
>

Re: Please review PR #201

[Bruno Baptista]

So... Jon suggested to me that the configurable resource can be done in 
an additional PR by one of the new guys. I think it's an excellent ideal.


If no one disagrees, I'll create a Jira with the details for it.

Bruno Baptista
https://twitter.com/brunobat_


On 23/11/18 14:05, Roberto Cortez wrote:

If we are happy, I would like to merge it. I could use some of the common 
project setup for other work.


On 23 Nov 2018, at 14:01, Bruno Baptista  wrote:

Hi Romain,

In the end I decided to simply use the server default, for now.

It will only be used if annotations are called in the code. It's lazily loaded, 
so no worries on that regard.

Cheers.

Bruno Baptista
https://twitter.com/brunobat_


On 23/11/18 12:31, Romain Manni-Bucau wrote:

Didnt you want to make the pool configurable and not instantiated if not
used?

Le ven. 23 nov. 2018 13:20, Daniel Cunha  a écrit :


Hey Bruno,

awesome! It really sounds good! I just push my +1 :)

Em sex, 23 de nov de 2018 às 06:44, Bruno Baptista 
escreveu:


Thanks!

Additionally, I've requested a Safeguard 1.0.1 release. we shouldn't be
using snapshots.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 22/11/18 19:30, Roberto Cortez wrote:

Cool! Thank you.

I’ll have a look.


On 22 Nov 2018, at 19:08, Bruno Baptista  wrote:

Hi!

I think the code is ready. Can some of you please review this pull

request:

https://github.com/apache/tomee/pull/201

Related to:TOMEE-2278 <

https://issues.apache.org/jira/browse/TOMEE-2278>-

Use Managed Executor with Safeguard Fault Tolerance lib

Cheers.

--
Bruno Baptista
https://twitter.com/brunobat_



--
Daniel "soro" Cunha
https://twitter.com/dvlc_

Re: Metrics Gauge Example and Bug

[Roberto Cortez]

No point. I’ve found the issue:

It’s here:
https://github.com/tomitribe/tomee/commit/7f18f4bcfe64119b9001d5ac6bffeb7324987a37
 


This commit reverted back the new JsonbProvider to the old JohnzonProvider.

The fix should be just to replace one with another. Let me try it and test.

Cheers,
Roberto

> On 23 Nov 2018, at 12:06, Ivan Junckes Filho  wrote:
> 
> I was using the current master.
> 1.1.9
> I will try to use the version Romain proposed and see how it works.
> 
> On Thu, Nov 22, 2018 at 7:36 PM Roberto Cortez  > wrote:
> Hey,
> 
> I think metrics doesn’t even run properly on TomEE 7.x because of CDI 2.0.
> 
> Regarding the fail, I’m not sure what is wrong. I remember seeing that before 
> and I think it got fixed when we added the JsonB JAX-RS Provider. Maybe there 
> is a regression in some place.
> 
> Cheers,
> Roberto
> 
> > On 22 Nov 2018, at 21:08, Romain Manni-Bucau  > > wrote:
> > 
> > Hi Ivan
> > 
> > Do you use tomee 8 with johnzon 1.1.10? Works well on this one normally if 
> > johnzon defaults are not broken. On tomee 7 you need to add jsonb ;)
> > 
> > Le jeu. 22 nov. 2018 21:51, Ivan Junckes Filho  >   > >> a écrit :
> > Also there are a lot of properties being returned on that payload that are 
> > not needed like rate1, rate5... etc.
> > 
> > 
> > 
> > On Thu, Nov 22, 2018 at 6:26 PM Ivan Junckes Filho  >   > >> wrote:
> > The issue with the TCK is because meter in the spec expects fifteenMinRate 
> > instead of fifteenMinuteRate.
> > 
> > Same apply for the other properties like fiveMin..oneMin..
> > 
> > @JsonbProperty("fifteenMinRate") is probably being ignored.
> > 
> > 
> > 
> > 
> > On Thu, Nov 22, 2018 at 5:46 PM Ivan Junckes Filho  >   > >> wrote:
> > Hey Romain, it is actually a mapping issue. I created the PR but the 
> > microprofile metrics TCK seems to be broken on TomEE, so I am not sure if 
> > the PR is reliable.
> > https://github.com/apache/geronimo-metrics/pull/2 
> >  
> >  > >
> > 
> > I will try to check what is going on with the TCK on TomEE, if you have any 
> > tips let me know.
> > 
> > 
> > 
> > 
> > 
> > On Wed, Nov 21, 2018 at 7:59 PM Romain Manni-Bucau  >   > >> wrote:
> > Hi Ivan
> > 
> > It is a bug in tomee scanning I think
> > 
> > 
> > Le mer. 21 nov. 2018 21:35, Ivan Junckes Filho  >   > >> a
> > écrit :
> > 
> > > Hey guys, I was writing an example of metrics gauge (WIP).
> > >
> > > https://github.com/apache/tomee/pull/213 
> > >  
> > >  > > >
> > >
> > > And I found a bug when trying access a gauge with "Accept:
> > > application/json".
> > >
> > > Just to let you know that I will work on a fix for this:
> > >
> > > 21-Nov-2018 17:24:08.811 WARNING [http-nio-8080-exec-4]
> > > org.apache.cxf.jaxrs.model.OperationResourceInfoComparator.compare Both
> > > org.apache.geronimo.microprofile.metrics.common.jaxrs.MetricsEndpoints#getJson
> > > and
> > > org.apache.geronimo.microprofile.metrics.jaxrs.CdiMetricsEndpoints#getJson
> > > are equal candidates for handling the current request which can lead to
> > > unpredictable results
> > > 21-Nov-2018 17:26:52.183 SEVERE [http-nio-8080-exec-4]
> > > org.apache.cxf.jaxrs.utils.JAXRSUtils.logMessageHandlerProblem Problem 
> > > with
> > > writing the data, class java.util.Collections$SingletonMap, ContentType:
> > > application/json
> > > 21-Nov-2018 17:26:52.184 WARNING [http-nio-8080-exec-4]
> > > org.apache.cxf.phase.PhaseInterceptorChain.doDefaultLogging Interceptor 
> > > for
> > > {
> > > http://jaxrs.common.metrics.microprofile.geronimo.apache.org/}MetricsEndpoints
> > >  
> > > 
> > >  
> > >  > >  
> > > >
> > > has thrown exception, unwinding now
> > >  org.apache.cxf.interceptor.Fault
> > > at
> > > org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.handleWriteException(JAXRSOutInterceptor.java:396)
> > > at
> > > 

Re: Please review PR #201

[Roberto Cortez]

If we are happy, I would like to merge it. I could use some of the common 
project setup for other work.

> On 23 Nov 2018, at 14:01, Bruno Baptista  wrote:
> 
> Hi Romain,
> 
> In the end I decided to simply use the server default, for now.
> 
> It will only be used if annotations are called in the code. It's lazily 
> loaded, so no worries on that regard.
> 
> Cheers.
> 
> Bruno Baptista
> https://twitter.com/brunobat_
> 
> 
> On 23/11/18 12:31, Romain Manni-Bucau wrote:
>> Didnt you want to make the pool configurable and not instantiated if not
>> used?
>> 
>> Le ven. 23 nov. 2018 13:20, Daniel Cunha  a écrit :
>> 
>>> Hey Bruno,
>>> 
>>> awesome! It really sounds good! I just push my +1 :)
>>> 
>>> Em sex, 23 de nov de 2018 às 06:44, Bruno Baptista 
>>> escreveu:
>>> 
 Thanks!
 
 Additionally, I've requested a Safeguard 1.0.1 release. we shouldn't be
 using snapshots.
 
 Cheers
 
 Bruno Baptista
 https://twitter.com/brunobat_
 
 
 On 22/11/18 19:30, Roberto Cortez wrote:
> Cool! Thank you.
> 
> I’ll have a look.
> 
>> On 22 Nov 2018, at 19:08, Bruno Baptista  wrote:
>> 
>> Hi!
>> 
>> I think the code is ready. Can some of you please review this pull
 request:
>> https://github.com/apache/tomee/pull/201
>> 
>> Related to:TOMEE-2278 <
>>> https://issues.apache.org/jira/browse/TOMEE-2278>-
 Use Managed Executor with Safeguard Fault Tolerance lib
>> Cheers.
>> 
>> --
>> Bruno Baptista
>> https://twitter.com/brunobat_
>> 
>> 
>>> 
>>> --
>>> Daniel "soro" Cunha
>>> https://twitter.com/dvlc_
>>> 

Re: Please review PR #201

[Bruno Baptista]

Hi Romain,

In the end I decided to simply use the server default, for now.

It will only be used if annotations are called in the code. It's lazily 
loaded, so no worries on that regard.


Cheers.

Bruno Baptista
https://twitter.com/brunobat_


On 23/11/18 12:31, Romain Manni-Bucau wrote:

Didnt you want to make the pool configurable and not instantiated if not
used?

Le ven. 23 nov. 2018 13:20, Daniel Cunha  a écrit :


Hey Bruno,

awesome! It really sounds good! I just push my +1 :)

Em sex, 23 de nov de 2018 às 06:44, Bruno Baptista 
escreveu:


Thanks!

Additionally, I've requested a Safeguard 1.0.1 release. we shouldn't be
using snapshots.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 22/11/18 19:30, Roberto Cortez wrote:

Cool! Thank you.

I’ll have a look.


On 22 Nov 2018, at 19:08, Bruno Baptista  wrote:

Hi!

I think the code is ready. Can some of you please review this pull

request:

https://github.com/apache/tomee/pull/201

Related to:TOMEE-2278 <

https://issues.apache.org/jira/browse/TOMEE-2278>-

Use Managed Executor with Safeguard Fault Tolerance lib

Cheers.

--
Bruno Baptista
https://twitter.com/brunobat_




--
Daniel "soro" Cunha
https://twitter.com/dvlc_

[GitHub] tomee issue #201: TOMEE-2278 - Use Managed Executor with Safeguard Fault Tol...

[danielsoro]

Github user danielsoro commented on the issue:

https://github.com/apache/tomee/pull/201
  
+1


---

Re: How can I help?

[Daniel Cunha]

Hey Weverthon,

Jonathan gave you an awesome feedback, you can ping us on the list when you
need help.

We will be happy to help you on this journey!
I'm really happy to see you here!


Em sex, 23 de nov de 2018 às 08:52, Richard Monson-Haefel <
monsonhae...@gmail.com> escreveu:

> Welcome, Weverthon!  I'm glad that Jonathan was able to help you and
> welcome you!  I'm looking forward to learning more about you.
>
> Richard
>
> On Thu, Nov 22, 2018 at 2:26 PM Weverthon Medeiros 
> wrote:
>
> > Hello guys,
> > I saw Richard Monson-Haefel's post on the blog, and also, talked to
> Daniel
> > Cunha about starting to contribute.
> >
> > So, how can I help?
> >
> > Kind regards,
> > Weverthon Medeiros
> > http://linkedin.com/in/weverthon
> >
>


-- 
Daniel "soro" Cunha
https://twitter.com/dvlc_

Re: Metrics Gauge Example and Bug

[Ivan Junckes Filho]

I was using the current master.

1.1.9

I will try to use the version Romain proposed and see how it works.


On Thu, Nov 22, 2018 at 7:36 PM Roberto Cortez 
wrote:

> Hey,
>
> I think metrics doesn’t even run properly on TomEE 7.x because of CDI 2.0.
>
> Regarding the fail, I’m not sure what is wrong. I remember seeing that
> before and I think it got fixed when we added the JsonB JAX-RS Provider.
> Maybe there is a regression in some place.
>
> Cheers,
> Roberto
>
> > On 22 Nov 2018, at 21:08, Romain Manni-Bucau 
> wrote:
> >
> > Hi Ivan
> >
> > Do you use tomee 8 with johnzon 1.1.10? Works well on this one normally
> if johnzon defaults are not broken. On tomee 7 you need to add jsonb ;)
> >
> > Le jeu. 22 nov. 2018 21:51, Ivan Junckes Filho  > a écrit :
> > Also there are a lot of properties being returned on that payload that
> are not needed like rate1, rate5... etc.
> >
> >
> >
> > On Thu, Nov 22, 2018 at 6:26 PM Ivan Junckes Filho <
> ivanjunc...@gmail.com > wrote:
> > The issue with the TCK is because meter in the spec expects
> fifteenMinRate instead of fifteenMinuteRate.
> >
> > Same apply for the other properties like fiveMin..oneMin..
> >
> > @JsonbProperty("fifteenMinRate") is probably being ignored.
> >
> >
> >
> >
> > On Thu, Nov 22, 2018 at 5:46 PM Ivan Junckes Filho <
> ivanjunc...@gmail.com > wrote:
> > Hey Romain, it is actually a mapping issue. I created the PR but the
> microprofile metrics TCK seems to be broken on TomEE, so I am not sure if
> the PR is reliable.
> > https://github.com/apache/geronimo-metrics/pull/2 <
> https://github.com/apache/geronimo-metrics/pull/2>
> >
> > I will try to check what is going on with the TCK on TomEE, if you have
> any tips let me know.
> >
> >
> >
> >
> >
> > On Wed, Nov 21, 2018 at 7:59 PM Romain Manni-Bucau <
> rmannibu...@gmail.com > wrote:
> > Hi Ivan
> >
> > It is a bug in tomee scanning I think
> >
> >
> > Le mer. 21 nov. 2018 21:35, Ivan Junckes Filho  > a
> > écrit :
> >
> > > Hey guys, I was writing an example of metrics gauge (WIP).
> > >
> > > https://github.com/apache/tomee/pull/213 <
> https://github.com/apache/tomee/pull/213>
> > >
> > > And I found a bug when trying access a gauge with "Accept:
> > > application/json".
> > >
> > > Just to let you know that I will work on a fix for this:
> > >
> > > 21-Nov-2018 17:24:08.811 WARNING [http-nio-8080-exec-4]
> > > org.apache.cxf.jaxrs.model.OperationResourceInfoComparator.compare Both
> > >
> org.apache.geronimo.microprofile.metrics.common.jaxrs.MetricsEndpoints#getJson
> > > and
> > >
> org.apache.geronimo.microprofile.metrics.jaxrs.CdiMetricsEndpoints#getJson
> > > are equal candidates for handling the current request which can lead to
> > > unpredictable results
> > > 21-Nov-2018 17:26:52.183 SEVERE [http-nio-8080-exec-4]
> > > org.apache.cxf.jaxrs.utils.JAXRSUtils.logMessageHandlerProblem Problem
> with
> > > writing the data, class java.util.Collections$SingletonMap,
> ContentType:
> > > application/json
> > > 21-Nov-2018 17:26:52.184 WARNING [http-nio-8080-exec-4]
> > > org.apache.cxf.phase.PhaseInterceptorChain.doDefaultLogging
> Interceptor for
> > > {
> > >
> http://jaxrs.common.metrics.microprofile.geronimo.apache.org/}MetricsEndpoints
> <
> http://jaxrs.common.metrics.microprofile.geronimo.apache.org/%7DMetricsEndpoints
> >
> > > has thrown exception, unwinding now
> > >  org.apache.cxf.interceptor.Fault
> > > at
> > >
> org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.handleWriteException(JAXRSOutInterceptor.java:396)
> > > at
> > >
> org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.serializeMessage(JAXRSOutInterceptor.java:272)
> > > at
> > >
> org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.processResponse(JAXRSOutInterceptor.java:122)
> > > at
> > >
> org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.handleMessage(JAXRSOutInterceptor.java:84)
> > > at
> > >
> org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)
> > > at
> > >
> org.apache.cxf.interceptor.OutgoingChainInterceptor.handleMessage(OutgoingChainInterceptor.java:90)
> > > at
> > >
> org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)
> > > at
> > >
> org.apache.cxf.transport.ChainInitiationObserver.onMessage(ChainInitiationObserver.java:121)
> > > at
> > >
> org.apache.cxf.transport.http.AbstractHTTPDestination.invoke(AbstractHTTPDestination.java:267)
> > > at
> > >
> org.apache.openejb.server.cxf.rs.CxfRsHttpListener.doInvoke(CxfRsHttpListener.java:253)
> > > at
> > >
> org.apache.tomee.webservices.CXFJAXRSFilter.doFilter(CXFJAXRSFilter.java:94)
> > > at
> > >
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> > > at
> > >
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> > > at
> 

[GitHub] tomee issue #215: WIP mp-metrics-metered

[ivanjunckes]

Github user ivanjunckes commented on the issue:

https://github.com/apache/tomee/pull/215
  
Hi @ferdisn, yes I spot this issue while doing my example.

I started a thread about it on the mailing list: Look for "Metrics Gauge 
Example and Bug".

Send your PR there and ask questions on how to fix it. This is a great 
example of bug you can fix.

I checked the TCK yesterday and I was trying to find the solution  for this 
as well.

It seems to be a problem with the jsob provider. 


---

Re: How can I help?

[Richard Monson-Haefel]

Welcome, José!

I'm so glad you've decided to get involved!  If you need any more help, and
I'm sure you will because everyone doest at first, please let us know.
Everyone here wants to see you succeed!

Richard

On Thu, Nov 22, 2018 at 3:31 PM Jose Henrique Ventura
 wrote:

> Hi Guys,
>
> Today I stepped by Richard Monson-Haefel's tweet where he describes his
> journey with Open Source projects and
> I really liked the initiative of encouraging developers to join an Open
> Source project. I know that there are many Open Source project around there
> but I think there is a lack of information of how people can get started
> with.
>
> I'm really interested in getting started with an Open Source project
> especially now with Jakarta EE and MicroProfile.
>
> I'm interested and I would like to know "How can I help?". =)
>
> Best Regards,
> José Henrique Ventura.
> https://josehenriqueventura.github.io
>
> Sent with [ProtonMail](https://protonmail.com) Secure Email.

Re: How can I help?

[Richard Monson-Haefel]

Welcome, Weverthon!  I'm glad that Jonathan was able to help you and
welcome you!  I'm looking forward to learning more about you.

Richard

On Thu, Nov 22, 2018 at 2:26 PM Weverthon Medeiros 
wrote:

> Hello guys,
> I saw Richard Monson-Haefel's post on the blog, and also, talked to Daniel
> Cunha about starting to contribute.
>
> So, how can I help?
>
> Kind regards,
> Weverthon Medeiros
> http://linkedin.com/in/weverthon
>

Re: TOMEE-2241: Best way to handle resolved Issue when update required?

[Jonathan Gallimore]

You did the right thing already - post here. :-) It was me that messed up,
I apologize. A few folks are out for thanksgiving, but we'll figure out
what's needed to get you in the right group in JIRA so you can assign
tickets to yourself.

Jon

On Fri, Nov 23, 2018 at 10:39 AM Frankie  wrote:

> Thank you, Jon.
> What is the best way to claim a ticket then? Obviously we already had the
> case that more than one wanted to do that ... ;-)
>
>
>
> --
> Sent from:
> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
>

Re: TOMEE-2241: Best way to handle resolved Issue when update required?

[Frankie]

Thank you, Jon.
What is the best way to claim a ticket then? Obviously we already had the
case that more than one wanted to do that ... ;-)



--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: TOMEE-2241: Best way to handle resolved Issue when update required?

[Jonathan Gallimore]

Sorry, I missed this email. I've assigned the ticket to me, but its all
yours. To actually have an issue assigned to you, I believe you need to be
in the openejb-developers group, and for that. I don't have the permissions
to add you (someone else might). Ignore my comment on the ticket, its all
yours. Hopefully you can update the property in the root pom and you should
be good.

If you create a patch or a PR, I'll happily review and merge.

Cheers!

Jon

On Fri, Nov 23, 2018 at 9:58 AM Frankie  wrote:

> OK, Ticket created.
>
> I would like to create a patch, too. But I`m new with that in open source
> projects.
> So I have some questions on it.
> Is there a process to claim a Ticket to avoid multiple people working
> redundantly on it?
> Where can I find information how to use JIRA in TomEE project?
>
>
>
>
> --
> Sent from:
> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
>

Re: TOMEE-2241: Best way to handle resolved Issue when update required?

[Bruno Baptista]

Hey,

You need to register in Apache Jira (https://issues.apache.org/jira/), 
find the TomEE project and claim the jira for you.


Additionally, send an email to this list before you start the work and 
explaining what you want to do. That way there will be no collisions and 
if someone wants to help you he/she can.


Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 23/11/18 09:58, Frankie wrote:

OK, Ticket created.

I would like to create a patch, too. But I`m new with that in open source
projects.
So I have some questions on it.
Is there a process to claim a Ticket to avoid multiple people working
redundantly on it?
Where can I find information how to use JIRA in TomEE project?




--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: TOMEE-2241: Best way to handle resolved Issue when update required?

[Frankie]

OK, Ticket created.

I would like to create a patch, too. But I`m new with that in open source
projects.
So I have some questions on it.
Is there a process to claim a Ticket to avoid multiple people working
redundantly on it?
Where can I find information how to use JIRA in TomEE project?




--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Please review PR #201

[Bruno Baptista]

Thanks!

Additionally, I've requested a Safeguard 1.0.1 release. we shouldn't be 
using snapshots.


Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 22/11/18 19:30, Roberto Cortez wrote:

Cool! Thank you.

I’ll have a look.


On 22 Nov 2018, at 19:08, Bruno Baptista  wrote:

Hi!

I think the code is ready. Can some of you please review this pull request:

https://github.com/apache/tomee/pull/201

Related to:TOMEE-2278 - Use 
Managed Executor with Safeguard Fault Tolerance lib

Cheers.

--
Bruno Baptista
https://twitter.com/brunobat_

[GitHub] tomee pull request #216: WIP create a sample for java modules usage

[jeanouii]

GitHub user jeanouii opened a pull request:

https://github.com/apache/tomee/pull/216

WIP create a sample for java modules usage

This is work in progress.
The goal is to create an example to leverage Java Modules. The immediate 
goal I was looking for is to properly make tomee/master Java 11 compatible by 
adding java module information to it.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jeanouii/tomee master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomee/pull/216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #216


commit bc4b716d3674fae90ea724060f6b307c4c3d369e
Author: Jean-Louis Monteiro 
Date:   2018-11-20T10:49:05Z

Attempt to create a java modules example

commit d6b0dbc060aaff8f565d1f1099a30c281a48ee7c
Author: Jean-Louis Monteiro 
Date:   2018-11-20T10:49:15Z

Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tomee

commit aaa4dc0213d01ea8f099b0a3a9f1763740668c0e
Author: Jean-Louis Monteiro 
Date:   2018-11-23T08:57:33Z

Fix the build after renaming the package




---

Re: How can I help?

[Jean-Louis Monteiro]

Hi José,

We just got Jon answering a similar question yesterday so I'm going to
copy/paste his answer as it totally applies to your query.

Welcome to the community! We have a few things going on with TomEE at the
> moment including:
>
> * Java EE 8 support
> * Java 11 support
> * Microprofile examples
>
> In addition, improvements to the website, documentation and any patches are
> welcome. I myself am looking at MicroProfile JWT 1.1 support which is
> almost there, and also some experimentation with security managers on the
> side (likely quite a challenge). If either of those sound interesting to
> you, I'm happy to give you some pointers. Similarly, if you like the sound
> of something else, that is cool too, and I'm sure one of us can give you
> something to get started on.
>
> Is there a particular area of interest that you'd like to dive into? If
> you're completely new to TomEE, I'd suggest starting by grabbing the server
> and trying your existing applications on it. The general idea is "if it
> runs on Tomcat, it should run on TomEE". There are some cases where that
> doesn't quite hold true, but it should be possible for the most part.
> Similarly if you have apps on WildFly, Glassfish or another server, give
> them a go and see how you get on. Its great to see new people come to the
> project looking to help out, thank you!
>

Hope it helps.
If not, feel free to shot again and we'd be happy to help in any possible
way.

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Nov 22, 2018 at 10:31 PM Jose Henrique Ventura
 wrote:

> Hi Guys,
>
> Today I stepped by Richard Monson-Haefel's tweet where he describes his
> journey with Open Source projects and
> I really liked the initiative of encouraging developers to join an Open
> Source project. I know that there are many Open Source project around there
> but I think there is a lack of information of how people can get started
> with.
>
> I'm really interested in getting started with an Open Source project
> especially now with Jakarta EE and MicroProfile.
>
> I'm interested and I would like to know "How can I help?". =)
>
> Best Regards,
> José Henrique Ventura.
> https://josehenriqueventura.github.io
>
> Sent with [ProtonMail](https://protonmail.com) Secure Email.