[jira] [Resolved] (VELOCITY-861) Improve parser modification and build documentation

2015-06-02 Thread Mike Kienenberger (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger resolved VELOCITY-861. Resolution: Fixed Applied patch to 1.x trunk. Changed javacc4.2 version to 4.1

[jira] [Updated] (VELOCITY-861) Improve parser modification and build documentation

2015-06-02 Thread Mike Kienenberger (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger updated VELOCITY-861: --- Affects Version/s: (was: 1.7) 1.x Improve parser

[jira] [Updated] (VELOCITY-862) Rebuilding parser using javacc 4.1 loses Node import

2015-06-02 Thread Mike Kienenberger (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger updated VELOCITY-862: --- Fix Version/s: 1.x Rebuilding parser using javacc 4.1 loses Node import

[jira] [Updated] (VELOCITY-862) Rebuilding parser using javacc 4.1 loses Node import

2015-06-02 Thread Mike Kienenberger (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger updated VELOCITY-862: --- Summary: Rebuilding parser using javacc 4.1 loses Node import (was: Rebuilding

Re: [jira] [Resolved] (VELOCITY-861) Improve parser modification and build documentation

2015-06-02 Thread Sergiu Dumitriu
Should issues be Resolved or Closed? So far I've been closing them. On 06/02/2015 10:25 PM, Mike Kienenberger (JIRA) wrote: [ https://issues.apache.org/jira/browse/VELOCITY-861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger resolved

Re: [jira] [Resolved] (VELOCITY-861) Improve parser modification and build documentation

2015-06-02 Thread Sergiu Dumitriu
OK, thanks for the explanation. On 06/02/2015 10:37 PM, Mike Kienenberger wrote: I guess I should be more specific. Using resolve on fix and close on release: -- Allows users to see at a glance to know if the bug is unfixed, fixed but unreleased, or released. -- Allows the release

[jira] [Updated] (VELOCITY-864) Download and install Apache Rat task in preparation target for ant rat

2015-06-02 Thread Mike Kienenberger (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger updated VELOCITY-864: --- Affects Version/s: (was: 1.7.x) 1.x Download and

[jira] [Assigned] (VELOCITY-864) Download and install Apache Rat task in preparation target for ant rat

2015-06-02 Thread Mike Kienenberger (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger reassigned VELOCITY-864: -- Assignee: Mike Kienenberger Download and install Apache Rat task in

1.8-SNAPSHOT as version for 1.x pom.xml?

2015-06-02 Thread Mike Kienenberger
My maven knowledge is tragically small. Do we need to make the following change for the 1.x pom.xml? Index: pom.xml === --- pom.xml(revision 1683209) +++ pom.xml(working copy) @@ -33,7 +33,7 @@

Re: 1.8-SNAPSHOT as version for 1.x pom.xml?

2015-06-02 Thread Mike Kienenberger
Do you think we need to open issues for trivial obviously-broken build issues like this? I'm going to guess no. On Tue, Jun 2, 2015 at 10:56 PM, Sergiu Dumitriu sergiu.dumit...@gmail.com wrote: 1.7 is definitely wrong, since a non -SNAPSHOT version should only be present in a tagged release.

Re: [jira] [Updated] (VELOCITY-864) Download and install Apache Rat task in preparation target for ant rat

2015-06-02 Thread Mike Kienenberger
The ASF leaves almost all decisions like this up to the individual projects. There are only a few must items which have to be followed (releases build from source, code is owned by the ASF, code is licensed Apache License, notices for other licenses, brand management) As you and I are the

[jira] [Updated] (VELOCITY-862) Rebuilding parser using javacc 4.1 loses Node import

2015-06-02 Thread Mike Kienenberger (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger updated VELOCITY-862: --- Affects Version/s: (was: 1.x) Rebuilding parser using javacc 4.1 loses Node

[jira] [Updated] (VELOCITY-863) Regression: #settableft-paren no longer valid grammar

2015-06-02 Thread Mike Kienenberger (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger updated VELOCITY-863: --- Affects Version/s: (was: 1.7.x) Regression: #settableft-paren no longer valid

[jira] [Closed] (VELOCITY-846) Create a branch out of the 1.7 tag.

2015-06-02 Thread Mike Kienenberger (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger closed VELOCITY-846. -- Might as well close this as there's nothing further to be done. Create a branch out of

[jira] [Updated] (VELOCITY-816) Upgrade commons-lang from 2.4 to 2.6.

2015-06-02 Thread Mike Kienenberger (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger updated VELOCITY-816: --- Assignee: (was: Mike Kienenberger) Upgrade commons-lang from 2.4 to 2.6.

[jira] [Resolved] (VELOCITY-862) Rebuilding parser using javacc 4.1 loses Node import

2015-06-02 Thread Mike Kienenberger (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger resolved VELOCITY-862. Resolution: Fixed Applied patch to 1.x trunk. Rebuilding parser using javacc

[jira] [Updated] (VELOCITY-863) Regression: #settableft-paren no longer valid grammar

2015-06-02 Thread Mike Kienenberger (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger updated VELOCITY-863: --- Fix Version/s: 1.x Regression: #settableft-paren no longer valid grammar

[jira] [Reopened] (VELOCITY-863) Regression: #settableft-paren no longer valid grammar

2015-06-02 Thread Mike Kienenberger (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger reopened VELOCITY-863: Adding 1.x fix version Regression: #settableft-paren no longer valid grammar

[jira] [Resolved] (VELOCITY-863) Regression: #settableft-paren no longer valid grammar

2015-06-02 Thread Mike Kienenberger (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger resolved VELOCITY-863. Resolution: Fixed Added 1.x fix version Regression: #settableft-paren no longer

Re: [jira] [Resolved] (VELOCITY-861) Improve parser modification and build documentation

2015-06-02 Thread Mike Kienenberger
I like to resolve when fixed in svn and to close when released. I think it's more meaningful. On Tue, Jun 2, 2015 at 10:30 PM, Sergiu Dumitriu sergiu.dumit...@gmail.com wrote: Should issues be Resolved or Closed? So far I've been closing them. On 06/02/2015 10:25 PM, Mike Kienenberger (JIRA)

Re: svn commit: r1683210 - in /velocity/engine/branches/1.x: build/BUILD_PARSER_README.txt src/java/org/apache/velocity/runtime/parser/BUILD_README.txt src/java/org/apache/velocity/runtime/parser/buil

2015-06-02 Thread Sergiu Dumitriu
On 06/02/2015 10:15 PM, mkien...@apache.org wrote: +In the event that something 'serious' changes, such as an AST node is created +or altered, it must be *manually* moved to the node subdirectory, and have its +package declaration fixed. This should be an extremely rare event at this point

Re: svn commit: r1683210 - in /velocity/engine/branches/1.x: build/BUILD_PARSER_README.txt src/java/org/apache/velocity/runtime/parser/BUILD_README.txt src/java/org/apache/velocity/runtime/parser/buil

2015-06-02 Thread Mike Kienenberger
Yeah, that bothered me as well, but I'm no expert on the parser, so I didn't want to guess whether it was still applicable. If I didn't know, I left the original readme as-is. Java 3.1 has been required since 1.5, so it's been wrong for a long time. Please feel free to improve it further. On

Re: [jira] [Updated] (VELOCITY-864) Download and install Apache Rat task in preparation target for ant rat

2015-06-02 Thread Sergiu Dumitriu
In other projects that I've been involved in, the rule was that affects version should point to a released version, and if something doesn't affect a release version, then this should be left blank. Does Velocity / Apache in general follow a different rule? On 06/02/2015 10:53 PM, Mike

[jira] [Resolved] (VELOCITY-864) Download and install Apache Rat task in preparation target for ant rat

2015-06-02 Thread Mike Kienenberger (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger resolved VELOCITY-864. Resolution: Fixed Fix Version/s: 1.x Fixed in 1.x trunk. I couldn't apply

[jira] [Updated] (VELOCITY-864) Download and install Apache Rat task in preparation target for ant rat

2015-06-02 Thread Mike Kienenberger (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger updated VELOCITY-864: --- Affects Version/s: (was: 1.x) Download and install Apache Rat task in

[jira] [Assigned] (VELOCITY-861) Improve parser modification and build documentation

2015-06-02 Thread Mike Kienenberger (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger reassigned VELOCITY-861: -- Assignee: Mike Kienenberger Improve parser modification and build

[jira] [Assigned] (VELOCITY-862) Rebuilding parser using javacc 4.2 loses Node import

2015-06-02 Thread Mike Kienenberger (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger reassigned VELOCITY-862: -- Assignee: Mike Kienenberger Rebuilding parser using javacc 4.2 loses Node

[jira] [Updated] (VELOCITY-862) Rebuilding parser using javacc 4.2 loses Node import

2015-06-02 Thread Mike Kienenberger (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger updated VELOCITY-862: --- Affects Version/s: (was: 1.7) 1.x Rebuilding parser

[jira] [Reopened] (VELOCITY-860) Fix Velocity 1.7.x, 1.6.x, 1.5 ant download dependency build script

2015-06-02 Thread Mike Kienenberger (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger reopened VELOCITY-860: Adding 1.x fix version Fix Velocity 1.7.x, 1.6.x, 1.5 ant download dependency build

[jira] [Resolved] (VELOCITY-860) Fix Velocity 1.7.x, 1.6.x, 1.5 ant download dependency build script

2015-06-02 Thread Mike Kienenberger (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger resolved VELOCITY-860. Resolution: Fixed Added 1.x fix version Fix Velocity 1.7.x, 1.6.x, 1.5 ant

Re: [jira] [Resolved] (VELOCITY-861) Improve parser modification and build documentation

2015-06-02 Thread Mike Kienenberger
I guess I should be more specific. Using resolve on fix and close on release: -- Allows users to see at a glance to know if the bug is unfixed, fixed but unreleased, or released. -- Allows the release manager to quickly generate a list of changes. (At least, I'm guessing it will) On Tue, Jun

Fixing build issues in 1.x but not 2.x

2015-06-02 Thread Mike Kienenberger
I hope it's not a problem, but I'm only applying the build process fixes to the 1.x branch and not the 2.x branch. My thinking is that the work has most likely already been done on 2.x, and I'm also not sure I have the time to invest in the 2.x branch. If you see something that you think I

Re: 1.8-SNAPSHOT as version for 1.x pom.xml?

2015-06-02 Thread Sergiu Dumitriu
1.7 is definitely wrong, since a non -SNAPSHOT version should only be present in a tagged release. So yes, that needs to be changed. On 06/02/2015 10:52 PM, Mike Kienenberger wrote: My maven knowledge is tragically small. Do we need to make the following change for the 1.x pom.xml? Index:

[jira] [Commented] (VELOCITY-818) Case-insensitive matching ${object.methodName} == ${object.methodname} == ${object.methodName}

2015-06-02 Thread Sergiu Dumitriu (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570219#comment-14570219 ] Sergiu Dumitriu commented on VELOCITY-818: -- I agree that it doesn't make sense

[jira] [Assigned] (VELOCITY-816) Upgrade commons-lang from 2.4 to 2.6.

2015-06-02 Thread Mike Kienenberger (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger reassigned VELOCITY-816: -- Assignee: Mike Kienenberger Upgrade commons-lang from 2.4 to 2.6.

Re: [jira] [Commented] (VELOCITY-818) Case-insensitive matching ${object.methodName} == ${object.methodname} == ${object.methodName}

2015-06-02 Thread Mike Kienenberger
Well, I'm ok if you want to reopen it and do something with it, but I don't want to leave people with false hope. I guess I can see why it might be helpful in some cases where a non-technical user may not understand the need for case-sensitivity. On Tue, Jun 2, 2015 at 11:38 PM, Sergiu Dumitriu

Changing velocity web site

2015-06-02 Thread Mike Kienenberger
I am looking at velocity/site to determine what the process is in order to update it. It looks like Daniel converted velocity to svnpubsub in 2014. I can't find a jira issue in INFRA or VELOCITY dealing with it, though. Which directory is the live version? velocity/site/production? I can