Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/68#issuecomment-35252920
Please close this PR.
We don't have the karma to do it.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/50#issuecomment-35252942
Please close this PR.
We don't have the karma to do it.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/44#issuecomment-35252951
Please close this PR.
We don't have the karma to do it.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/32#issuecomment-35253061
Please close this PR. It seems there is no interest in this ...
We don't have the karma to do it.
Thanks!
---
If your project is set up for it, you can reply
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/71#issuecomment-36607567
The change is merged in `wicket-6.x` and `master` branches.
Please close this PR because we cannot do it.
Thanks!
---
If your project is set up for it, you
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/76#issuecomment-54809838
What is this Pull Request about ?
It looks like an invalid.
Please close it and open a new one.
Thank you!
---
If your project is set up for it, you can
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/77#issuecomment-56439132
The tests fail with:
Caused by: java.lang.IllegalStateException: Could not resolve Bean Property
from component: [TextField [Component id = input21
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/78#issuecomment-58332442
After merging this PR to wicket-6.x the following tests fail:
```
Failed tests:
optionPlaceholderDecode1(org.apache.wicket.core.request.mapper.MountedMapperTest
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/79#discussion_r19457125
--- Diff:
wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java ---
@@ -274,6 +262,11 @@ public void component(final Component component
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/79#discussion_r19457135
--- Diff:
wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java ---
@@ -574,7 +567,15 @@ public void component(Form? component, IVisitBytes
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/79#discussion_r19457202
--- Diff:
wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/MultipartServletWebRequestImpl.java
---
@@ -88,9 +87,9
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/79#discussion_r19457322
--- Diff:
wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/ServletWebRequest.java
---
@@ -49,6 +34,12 @@
import org.slf4j.Logger
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24095270
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacementCompressor.java
---
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24095885
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacementCompressor.java
---
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24094502
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
---
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24094208
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacementCompressor.java
---
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/87#issuecomment-72892809
The knowledge is there:
https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/request/resource/CssPackageResource.java#L65
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/87#issuecomment-72893477
A possible improvement:
- introduce IScopeAwareCssProcessor {process(String nonCompressed, Class
scope, String cssName)}
- check if the resolved ICssCompressor
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24094660
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacementCompressor.java
---
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24095985
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CompositeJavaScriptCompressor.java
---
@@ -0,0 +1,94 @@
+/*
+ * Licensed
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24095075
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacementCompressor.java
---
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24094954
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacementCompressor.java
---
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24095007
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacementCompressor.java
---
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24095694
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacementCompressor.java
---
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24094000
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
---
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24094145
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacementCompressor.java
---
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/87#issuecomment-73004275
I'll take of this PR!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/89#issuecomment-73305327
Thank you, Tobias!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/93#discussion_r24937730
--- Diff: wicket-examples/src/main/webapp/WEB-INF/web.xml ---
@@ -16,9 +16,9 @@
limitations under the License.
--
web-app xmlns=http
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/94#issuecomment-74512507
Thanks, Tobias!
I've cherry-picked the commit for 6.x and applied it to 7.x. GitHub didn't
recognize the commit and didn't close the PR.
Please close it manually
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/82#issuecomment-71863184
There are #85 and #86 now. This PR could be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/77#issuecomment-71863495
I believe this PR has been merged.
We don't have the karma to close it.
@tkruse Please close it. Thanks!
---
If your project is set up for it, you can reply
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/76#issuecomment-71863576
@DritonG Please close this PR. Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/74#issuecomment-73844439
https://issues.apache.org/jira/browse/WICKET-5623
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/109#issuecomment-82251290
Thanks, Max!
I've cherry-picked the changes to 6.x. No need of another PR.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/112#issuecomment-83941519
I'm afraid the PR cannot be used.
Your formatting style caused complete rewrite of the touched files and the
meaningful changes are lost in the noise
---
If your
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/113#discussion_r26884179
--- Diff:
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/event/WebSocketAbortedPayload.java
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/113#discussion_r26884227
--- Diff:
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/message/AbortedMessage.java
---
@@ -0,0
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/113#discussion_r26883895
--- Diff:
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/WebSocketSettings.java
---
@@ -155,6 +168,57
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/113#discussion_r26884059
--- Diff:
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/WebSocketConnectionOriginFilter.java
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/113#discussion_r26883969
--- Diff:
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/AbstractWebSocketProcessor.java
---
@@ -84,6
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/110#issuecomment-83664578
Thanks for the contribution!
The problem with the 800 files is that you used branch `build/7.0.0-M5`
instead of `master`.
If you cannot rebase the commits
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/55#issuecomment-78436705
@RoadRunner120485 Ping!
Please close the Pull Request because we don't have the permission to do
it. Thank you!
---
If your project is set up for it, you can reply
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/101#issuecomment-78436750
@tkruse Ping!
Please close this PR because we don't have the permissions to do it. Thank
you!
---
If your project is set up for it, you can reply to this email
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/97#discussion_r26283649
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacer.java ---
@@ -43,6 +49,8 @@
// The pattern to find URLs in CSS resources
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/97#discussion_r26283656
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacer.java ---
@@ -58,9 +66,12 @@ public String process(String input, Class? scope
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/97#discussion_r26283760
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacer.java ---
@@ -71,21 +82,67 @@ else if (imageCandidateUrl.isContextAbsolute
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/76#issuecomment-78437639
@DritonG Please close this Pull Request because we don't have the
permissions to do it ourselves. Thank you!
---
If your project is set up for it, you can reply
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/107#discussion_r26284011
--- Diff:
wicket-core/src/main/java/org/apache/wicket/markup/html/PackageResourceGuard.java
---
@@ -85,7 +85,8 @@ protected boolean acceptAbsolutePath
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/97#discussion_r26283695
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacer.java ---
@@ -71,21 +82,67 @@ else if (imageCandidateUrl.isContextAbsolute
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/97#issuecomment-78437280
Good job, Tobias!
I've made some minor comments. Please apply the suggested improvements and
squash the commits into one.
---
If your project is set up for it, you
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/108#issuecomment-78262804
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/99#discussion_r25233381
--- Diff:
wicket-auth-roles/src/test/java/org/apache/wicket/authroles/authorization/strategies/role/annotations/AnnotationsRoleAuthorizationStrategyTest.java
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/99#issuecomment-75711898
LGTM!
Just small nitpicks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/99#discussion_r25233416
--- Diff:
wicket-auth-roles/src/main/java/org/apache/wicket/authroles/authorization/strategies/role/annotations/AnnotationsRoleAuthorizationStrategy.java
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/99#discussion_r2520
--- Diff:
wicket-auth-roles/src/main/java/org/apache/wicket/authroles/authorization/strategies/role/annotations/AnnotationsRoleAuthorizationStrategy.java
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/99#discussion_r2522
--- Diff:
wicket-auth-roles/src/main/java/org/apache/wicket/authroles/authorization/strategies/role/annotations/AuthorizeResource.java
---
@@ -0,0 +1,42
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/99#discussion_r25233348
--- Diff:
wicket-auth-roles/src/test/java/org/apache/wicket/authroles/authorization/strategies/role/annotations/AnnotationsRoleAuthorizationStrategyTest.java
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/118#discussion_r30408568
--- Diff:
wicket-core/src/main/java/org/apache/wicket/model/StringResourceModel.java ---
@@ -275,110 +276,70 @@ public void setObject(String object
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/118#discussion_r30409143
--- Diff:
wicket-core/src/main/java/org/apache/wicket/model/StringResourceModel.java ---
@@ -275,110 +276,70 @@ public void setObject(String object
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/76#issuecomment-103373019
@asfgit @DritonG Please close this pull request. It is not applicable.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/118#issuecomment-103379768
The PR is merged but GitHub doesn't recognize it.
@gsmet Please close the PR.
Thanks!
---
If your project is set up for it, you can reply to this email
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/114#issuecomment-90409380
Hi,
I see this PR introduces some API changes.
We want to release Wicket 7.0.0 next week so I am a bit hesitant to merge
it.
Please start a discussion
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/113#issuecomment-90512131
Hi @Fogetti ,
Do you want me to improve the PR myself and merge it?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/119#discussion_r30675893
--- Diff:
wicket-ioc/src/main/java/org/apache/wicket/proxy/LazyInitProxyFactory.java ---
@@ -349,6 +368,33 @@ public Object writeReplace() throws
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/119#discussion_r30675808
--- Diff:
wicket-ioc/src/main/java/org/apache/wicket/proxy/LazyInitProxyFactory.java ---
@@ -157,14 +164,26 @@ else if (type.isInterface
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/124#discussion_r31666828
--- Diff:
wicket-core/src/test/java/org/apache/wicket/markup/html/image/InlineImageTest.java
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/124#issuecomment-108607617
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/129#issuecomment-114495547
The example/demo/test will be part of Wicket from now on so we have to
adapt it (package names, versions, etc.).
I guess the example will be only in 7.x
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/129#discussion_r33038416
--- Diff: testing/wicket-arquillian/pom.xml ---
@@ -0,0 +1,345 @@
+?xml version=1.0?
+!-- JBoss, Home of Professional Open Source Copyright 2013, Red
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/129#discussion_r33087367
--- Diff:
wicket-core/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
---
@@ -253,7 +254,7 @@ public BaseWicketTester(final
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/129#discussion_r33086279
--- Diff: testing/wicket-arquillian/pom.xml ---
@@ -0,0 +1,316 @@
+?xml version=1.0?
+!--
+ Licensed to the Apache Software Foundation (ASF
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/129#discussion_r33087613
--- Diff:
wicket-core/src/main/java/org/apache/wicket/util/tester/WicketTester.java ---
@@ -221,7 +221,7 @@ public WicketTester(final WebApplication
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/129#issuecomment-114632027
Just minor nitpicks.
Looks good to me!
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/129#discussion_r33086404
--- Diff: testing/wicket-arquillian/pom.xml ---
@@ -0,0 +1,316 @@
+?xml version=1.0?
+!--
+ Licensed to the Apache Software Foundation (ASF
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/129#discussion_r33227694
--- Diff: testing/wicket-arquillian/src/test/resources/arquillian.xml ---
@@ -0,0 +1,20 @@
+?xml version=1.0 encoding=UTF-8?
+arquillian xmlns=http
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/114#discussion_r33138716
--- Diff:
wicket-guice/src/main/java/org/apache/wicket/guice/GuiceFieldValueFactory.java
---
@@ -64,15 +68,34 @@ public Object getFieldValue(final Field
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/114#discussion_r33141370
--- Diff:
wicket-guice/src/main/java/org/apache/wicket/guice/GuiceFieldValueFactory.java
---
@@ -64,15 +68,34 @@ public Object getFieldValue(final Field
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/129#issuecomment-114870115
It seems your branch is too far from current master. I have problems to
merge it locally.
Could you please rebase it and probably squash your commits into one
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/129#issuecomment-115160254
Many thanks, Felipe!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/130#issuecomment-115165679
The PR has been merged!
Please close it because we do not own this mirror.
Thank you!
---
If your project is set up for it, you can reply to this email
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/128#issuecomment-113276065
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/129#discussion_r33015039
--- Diff: testing/wicket-arquillian/README.md ---
@@ -0,0 +1,89 @@
+wicket-war: Wicket Framework used in a WAR
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/129#discussion_r33015273
--- Diff: testing/wicket-arquillian/src/test/resources/arquillian.xml ---
@@ -0,0 +1,22 @@
+?xml version=1.0 encoding=UTF-8?
+arquillian xmlns=http
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/129#discussion_r33015092
--- Diff: testing/wicket-arquillian/pom.xml ---
@@ -0,0 +1,345 @@
+?xml version=1.0?
+!-- JBoss, Home of Professional Open Source Copyright 2013, Red
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/129#discussion_r33015149
--- Diff: testing/wicket-arquillian/pom.xml ---
@@ -0,0 +1,345 @@
+?xml version=1.0?
+!-- JBoss, Home of Professional Open Source Copyright 2013, Red
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/129#discussion_r33015132
--- Diff: testing/wicket-arquillian/pom.xml ---
@@ -0,0 +1,345 @@
+?xml version=1.0?
+!-- JBoss, Home of Professional Open Source Copyright 2013, Red
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/129#discussion_r33015115
--- Diff: testing/wicket-arquillian/pom.xml ---
@@ -0,0 +1,345 @@
+?xml version=1.0?
+!-- JBoss, Home of Professional Open Source Copyright 2013, Red
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/129#issuecomment-114388258
I've added some comments - we have to upgrade to latest Wicket. I can help
here if you want.
I don't see the change in BaseWicketTester in this PR. Please add
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/129#discussion_r33015211
--- Diff: testing/wicket-arquillian/src/main/webapp/WEB-INF/web.xml ---
@@ -0,0 +1,49 @@
+?xml version=1.0 encoding=UTF-8?
+!--
+JBoss, Home
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/126#issuecomment-112403950
Could you please update the commit message to mention WICKET-5914?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/127#issuecomment-112327544
What exactly is the use case ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/127#issuecomment-112331156
I see.
In this case you should also add a constructor without any arguments, like
https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/120#discussion_r31130617
--- Diff:
wicket-devutils/src/main/java/org/apache/wicket/devutils/debugbar/wicket-debugbar.js
---
@@ -26,5 +26,45 @@ function
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/120#issuecomment-105766171
My shell script for merging GitHub PRs was already in process when
@klopfdreh commented.
@klopfdreh Please apply your improvements in master branch
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/120#issuecomment-105766408
Yes. `$` - vanilla JS.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/122#issuecomment-106193860
I've merged this PR by cherry picking it.
It seems this confused GitHub and it cannot close the PR automatically.
@pulse00 Please close the PR. Thank you
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/131#discussion_r33447991
--- Diff: wicket-user-guide/pom.xml ---
@@ -1,195 +1,357 @@
?xml version=1.0 encoding=UTF-8?
-!--
- Licensed to the Apache Software Foundation
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/133#issuecomment-130575081
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/134#issuecomment-130631999
This is an API break and will have to wait Wicket 8.x.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
1 - 100 of 372 matches
Mail list logo
