Re: [Dev] [dev] please review and merge PR

I added some comments to elaborate how to fix the particular issue by improving better performance as an additional outcome. Regards Hasunie On Thu, Mar 1, 2018 at 10:54 AM, 김대경 wrote: > Can you please review and merge PR. > > [1]

[Dev] [dev] please review and merge PR

Can you please review and merge PR. [1] https://github.com/wso2/wso2-synapse/pull/1054 Best Regards. Daekyung Kim. ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge PR

On Thu, Feb 22, 2018 at 10:29 AM, SajithAR Ariyarathna wrote: > Hi Devs, > > Please review & merged PR https://github.com/wso2/carbon-appmgt/pull/709 > which fixes https://github.com/wso2/carbon-appmgt/issues/708 . > Merged. Regards, Dinusha > > Thanks. > > -- > Sajith

[Dev] Please review and merge PR

Hi Devs, Please review & merged PR https://github.com/wso2/carbon-appmgt/pull/709 which fixes https://github.com/wso2/carbon-appmgt/issues/708 . Thanks. -- Sajith Janaprasad Ariyarathna Senior Software Engineer; WSO2, Inc.; http://wso2.com/

Re: [Dev] [DEV] please review and merge

Hi Daekyung Kim, Thank you for your contribution. We will verify the fix and do the necessary Regards Senduran On Tue, Feb 20, 2018 at 12:06 PM, 김대경 wrote: > Can you please review and merge PR[1] . > > [1] https://github.com/wso2/wso2-synapse/pull/1045 > > Best Regards. >

[Dev] [DEV] please review and merge

Can you please review and merge PR[1] . [1] https://github.com/wso2/wso2-synapse/pull/1045 Best Regards. Daekyung Kim. ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge PR

Hi, I,m using salesforce connector in EI-6.1.1. I use this to query the salesforce objects using query and queryMore functions. The first query works, but of you do not do anything for about three hours and then call again. EI get a connection in the connection pool and make an http call and

Re: [Dev] Fwd: [DEV] Please review and merge PR

Hi, Merged the PR. Thanks, Chanaka. On Sun, Feb 4, 2018 at 9:28 PM, 김대경 <dkg@gmail.com> wrote: > Why it doesn't merged.. although approved. > > > -- 전달된 메일 -- > 보낸사람: "김대경" <dkg@gmail.com> > 날짜: 2018. 1. 30. 오전 11:03 > 제목: [D

Re: [Dev] Please review and merge PR

Hi Kim, Thank you for your contribution. We are reviewing your PR. As we are trying to reproduce the issue, can you please provide the exact scenario where you faced this issue? Thank you and regards, Nishadi On Sun, Feb 4, 2018 at 9:31 PM, 김대경 wrote: > > I wonder how it is

Re: [Dev] Please review and merge PR

I wonder how it is progressing... 2018. 1. 26. 오후 1:31에 "김대경" 님이 작성: Can you please review and merge PR[1] . [1] https://github.com/wso2/wso2-commons-httpclient/pull/18 Best Regards. Daekyung Kim. ___ Dev mailing list

[Dev] Fwd: [DEV] Please review and merge PR

Why it doesn't merged.. although approved. -- 전달된 메일 -- 보낸사람: "김대경" <dkg@gmail.com> 날짜: 2018. 1. 30. 오전 11:03 제목: [DEV] Please review and merge PR 받는사람: <dev@wso2.org> 참조: Can you please review and merge PR. [1] https://github.com/wso2/wso2-axis2/

[Dev] [DEV] Please review and merge PR

Can you please review and merge PR. [1] https://github.com/wso2/wso2-axis2/pull/132 Best Regards. Daekyung Kim. ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev

[Dev] Please review and merge PR

Can you please review and merge PR[1] . [1] https://github.com/wso2/wso2-axis2/pull/132 Best Regards. Daekyung Kim. ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev

[Dev] Please review and merge PR

Can you please review and merge PR[1] . [1] https://github.com/wso2/wso2-commons-httpclient/pull/18 Best Regards. Daekyung Kim. ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge PR

Hi Nuwandi, PR is now merged. Thanks *Prasanna Dangalla* Senior Software Engineer, WSO2, Inc.; http://wso2.com/ lean.enterprise.middleware *cell: +94 718 11 27 51* *twitter: @prasa77* On Mon, Dec 4, 2017 at 10:35 AM, Nuwandi Wickramasinghe wrote: > Hi, > > Please review

[Dev] Please review and merge PR

Hi, Please review and merge [1] [1] https://github.com/wso2/carbon-registry/pull/271 thanks Nuwandi -- Best Regards, Nuwandi Wickramasinghe Senior Software Engineer WSO2 Inc. Web : http://wso2.com Mobile : 0719214873 ___ Dev mailing list

Re: [Dev] Please review and merge

Hi Nuwandi, Reviewed and merged the PR[1] 1. https://github.com/wso2/carbon-registry/pull/268 Thanks Danesh On Wed, Nov 29, 2017 at 1:41 PM, Nuwandi Wickramasinghe wrote: > Hi, > > Please review and merge [1] > > [1] https://github.com/wso2/carbon-registry/pull/264 > >

[Dev] Please review and merge

Hi, Please review and merge [1] [1] https://github.com/wso2/carbon-registry/pull/264 thanks Nuwandi -- Best Regards, Nuwandi Wickramasinghe Senior Software Engineer WSO2 Inc. Web : http://wso2.com Mobile : 0719214873 ___ Dev mailing list

Re: [Dev] please review and merge

Hi Kim, Thanks a lot for your contribution. We'll do the needful. Thanks. On Wed, Nov 22, 2017 at 7:15 PM, 김대경 wrote: > Can you please review and merge PR[1] . > > [1] https://github.com/wso2/carbon-mediation/pull/906 > > Best Regards. > Daekyung Kim. > >

[Dev] please review and merge

Can you please review and merge PR[1] . [1] https://github.com/wso2/carbon-mediation/pull/906 Best Regards. Daekyung Kim. ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge PR

Hi Kim, Thanks a lot for your contribution. We'll do the needful. Thanks. On Mon, Nov 13, 2017 at 8:53 AM, Harsha Kumara wrote: > > > On Sun, Nov 12, 2017 at 7:28 PM, 김대경 wrote: > >> Can you please review and merge PR[1] and PR[2]. >> >> [1]

Re: [Dev] Please review and merge PR

On Sun, Nov 12, 2017 at 7:28 PM, 김대경 wrote: > Can you please review and merge PR[1] and PR[2]. > > [1] https://github.com/wso2/wso2-synapse/pull/952 > [2] https://github.com/wso2/carbon-mediation/pull/906 > > Best Regards. > Daekyung Kim. > >

[Dev] Please review and merge PR

Can you please review and merge PR[1] and PR[2]. [1] https://github.com/wso2/wso2-synapse/pull/952 [2] https://github.com/wso2/carbon-mediation/pull/906 Best Regards. Daekyung Kim. ___ Dev mailing list Dev@wso2.org

Re: [Dev] Please review and merge PR

Hi Johann, Sorry for the mistake. I have sent two separate emails for the issue. On Thu, Oct 12, 2017 at 11:55 AM, Johann Nallathamby wrote: > Hi Isuranga, > > First of all thank you for your contribution to WSO2 Identity Server. > > However, can you please follow the

Re: [Dev] Please review and merge PR

Hi Isuranga, First of all thank you for your contribution to WSO2 Identity Server. However, can you please follow the following protocol in order to get your PRs merged faster. 1. Create one JIRA per issue. Make sure you give the description clearly. Add the PRs related to the issue in the

[Dev] Please review and merge PR

Can you please review and merge PR[1] and PR[2]. [1] https://github.com/wso2/balana/pull/75 [2] https://github.com/wso2/carbon-identity-framework/pull/1112 Best Regards Isuranga Perera ___ Dev mailing list Dev@wso2.org

Re: [Dev] Please review and merge PR

Thanks Thusitha! On Tuesday, September 19, 2017, Thusitha Thilina Dayaratne < thusit...@wso2.com> wrote: > Hi Farasath, > > Merged the PR. > > > > > On Tue, Sep 19, 2017 at 6:36 PM, Farasath Ahamed > wrote: > >> Hi, >> >>

Re: [Dev] Please review and merge PR

Hi Farasath, Merged the PR. On Tue, Sep 19, 2017 at 6:36 PM, Farasath Ahamed wrote: > Hi, > > Can you please review and merge the following PR[1]. This needs to go into > Kernel 4.4.18 > > [1] https://github.com/wso2/carbon-kernel/pull/1538 > > > > > Thanks, > Farasath

[Dev] Please review and merge PR

Hi, Can you please review and merge the following PR[1]. This needs to go into Kernel 4.4.18 [1] https://github.com/wso2/carbon-kernel/pull/1538 Thanks, Farasath Ahamed Software Engineer, WSO2 Inc.; http://wso2.com Mobile: +94777603866 Blog: blog.farazath.com Twitter: @farazath619

Re: [Dev] Please review and merge the PR

thanks. On Tue, Sep 19, 2017 at 5:02 PM, Thusitha Thilina Dayaratne < thusit...@wso2.com> wrote: > Hi Nila, > > Merged the PR > > Thanks > Thusitha > > On Tue, Sep 19, 2017 at 4:56 PM, Nilasini Thirunavukkarasu < > nilas...@wso2.com> wrote: > >> Hi, >> >> Can you please review and merge the

Re: [Dev] Please review and merge the PR

Hi Nila, Merged the PR Thanks Thusitha On Tue, Sep 19, 2017 at 4:56 PM, Nilasini Thirunavukkarasu < nilas...@wso2.com> wrote: > Hi, > > Can you please review and merge the following PR. > [1] - https://github.com/wso2/carbon-kernel/pull/1533 > > > Thanks, > Nila. > > -- > Nilasini

[Dev] Please review and merge the PR

Hi, Can you please review and merge the following PR. [1] - https://github.com/wso2/carbon-kernel/pull/1533 Thanks, Nila. -- Nilasini Thirunavukkarasu Software Engineer - WSO2 Email : nilas...@wso2.com Mobile : +94775241823 Web : http://wso2.com/

Re: [Dev] Please review and merge the PRs

Thanks. On Tue, Sep 19, 2017 at 4:33 PM, Thusitha Thilina Dayaratne < thusit...@wso2.com> wrote: > Hi Thanuja, > > Merged the PRs > > Thanks > Thusitha > > On Tue, Sep 19, 2017 at 3:49 PM, Thanuja Jayasinghe > wrote: > >> Hi, >> >> Can you please review and merge the following

Re: [Dev] Please review and merge the PRs

Hi Thanuja, Merged the PRs Thanks Thusitha On Tue, Sep 19, 2017 at 3:49 PM, Thanuja Jayasinghe wrote: > Hi, > > Can you please review and merge the following PRs. > > [1] - https://github.com/wso2/carbon-kernel/pull/1535 > [2] -

[Dev] Please review and merge the PRs

Hi, Can you please review and merge the following PRs. [1] - https://github.com/wso2/carbon-kernel/pull/1535 [2] - https://github.com/wso2/carbon-kernel/pull/1531 Thanks, Thanuja -- *Thanuja Lakmal* Associate Technical Lead WSO2 Inc. http://wso2.com/ *lean.enterprise.middleware* Mobile:

Re: [Dev] Please review and merge PR for kernel

@thusitha: since the PR is sent to the 4.4.x branch, it will not close the issue when the PR is merged. Therefore we will have to close the issue after merging the PR. Regards, Nira On Thu, Sep 14, 2017 at 11:28 AM, Thusitha Thilina Dayaratne < thusit...@wso2.com> wrote: > Hi Pulasthi, > > PR

Re: [Dev] Please review and merge PR for kernel

Hi Pulasthi, PR merged. Thanks Thusitha On Thu, Sep 14, 2017 at 6:51 PM, Pulasthi Mahawithana wrote: > Hi, > > Please review and merge [1], which fixes [2]. Related Identity JIRA is at > [3]. > > [1] https://github.com/wso2/carbon-kernel/pull/1527 >

[Dev] Please review and merge PR for kernel

Hi, Please review and merge [1], which fixes [2]. Related Identity JIRA is at [3]. [1] https://github.com/wso2/carbon-kernel/pull/1527 [2]

Re: [Dev] Please review and merge the PR

Hi Sathya, Your PR was merged to carbon-deployment 4.7.x. Thanks, Dilan. *Dilan U. Ariyaratne* Senior Software Engineer WSO2 Inc. Mobile: +94766405580 <%2B94766405580> lean . enterprise . middleware On Thu, Sep 14, 2017 at 5:39 AM, Dilan Udara Ariyaratne

Re: [Dev] Please review and merge the PR

Hi Sathya, Added few more comments. Can you have a look ? Thanks, Dilan. *Dilan U. Ariyaratne* Senior Software Engineer WSO2 Inc. Mobile: +94766405580 <%2B94766405580> lean . enterprise . middleware On Wed, Sep 13, 2017 at 2:37 PM, Sathya Bandara wrote: >

[Dev] Please review and merge the PR

Hi, Can you please review and merge the PR [1]. This is regarding the Issue [2]. [1] https://github.com/wso2/carbon-deployment/pull/273 [2] https://github.com/wso2/carbon-deployment/issues/274 Thanks, Sathya -- Sathya Bandara Software Engineer WSO2 Inc. http://wso2.com Mobile: (+94) 715 360

Re: [Dev] Please review and merge

Thank you Madhawa. On Thu, Sep 7, 2017 at 1:04 PM, Madhawa Gunasekara wrote: > Merged. > > Regards, > Madhawa > > On Thu, Sep 7, 2017 at 2:10 AM, Manorama Perera wrote: > >> Hi, >> >> Please review and merge PR[1]. >> >> [1]

Re: [Dev] Please review and merge

Merged. Regards, Madhawa On Thu, Sep 7, 2017 at 2:10 AM, Manorama Perera wrote: > Hi, > > Please review and merge PR[1]. > > [1] https://github.com/wso2/carbon-commons/pull/278 > > Thanks, > Manorama > > -- > Manorama Perera > Software Engineer > WSO2, Inc.;

[Dev] Please review and merge

Hi, Please review and merge PR[1]. [1] https://github.com/wso2/carbon-commons/pull/278 Thanks, Manorama -- Manorama Perera Software Engineer WSO2, Inc.; http://wso2.com/ ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the PR

Thanks, Ashen. Your PR was merged on to carbon-kernel-4.4.x branch. Regards, Dilan. *Dilan U. Ariyaratne* Senior Software Engineer WSO2 Inc. Mobile: +94766405580 <%2B94766405580> lean . enterprise . middleware On Fri, Aug 11, 2017 at 3:33 PM, Ashen Weerathunga

Re: [Dev] Please review and merge the PR

Hi Dilan, I have done the changes and successfully build the component and kernel with the tests. Thanks, Ashen On Fri, Aug 11, 2017 at 8:09 AM, Dilan Udara Ariyaratne wrote: > Hi Ashen, > > Added Few more suggestions. Please go through and verify. > > Thanks, > Dilan. > >

Re: [Dev] Please review and merge the PR

Hi Ashen, Added Few more suggestions. Please go through and verify. Thanks, Dilan. *Dilan U. Ariyaratne* Senior Software Engineer WSO2 Inc. Mobile: +94766405580 <%2B94766405580> lean . enterprise . middleware On Thu, Aug 10, 2017 at 7:23 PM, Ashen Weerathunga

Re: [Dev] Please review and merge the PR

Hi Dilan, I have done the requested changes and updated the PR. Thanks, Ashen On Thu, Aug 10, 2017 at 6:23 AM, Dilan Udara Ariyaratne wrote: > Hi Ashen, > > Went through the code and added few comments, Please go through and verify. > > Thanks, > Dilan. > > *Dilan U.

Re: [Dev] Please review and merge the PR

Hi Ashen, Went through the code and added few comments, Please go through and verify. Thanks, Dilan. *Dilan U. Ariyaratne* Senior Software Engineer WSO2 Inc. Mobile: +94766405580 <%2B94766405580> lean . enterprise . middleware On Wed, Aug 9, 2017 at 1:44 PM, Ashen

[Dev] Please review and merge the PR

Hi, Can you please review and merge the PR [1]. This is regarding the Issue [2]. [1] https://github.com/wso2/carbon-kernel/pull/1464 [2] https://github.com/wso2/carbon-kernel/issues/1467 Thanks, Ashen -- *Ashen Weerathunga* Software Engineer WSO2 Inc.: http://wso2.com

Re: [Dev] Please review and merge the pull request

Hi Isuri, PR merged. Thanks On Wed, Aug 2, 2017 at 3:56 PM, Isuri Anuradha wrote: > changed the commit message. > > [1] -https://github.com/wso2/carbon-kernel/pull/1460 > > Regards, > Isuri Anuradha. > > On Wed, Aug 2, 2017 at 3:33 PM, Isuri Anuradha wrote: >

Re: [Dev] Please review and merge the pull request

changed the commit message. [1] -https://github.com/wso2/carbon-kernel/pull/1460 Regards, Isuri Anuradha. On Wed, Aug 2, 2017 at 3:33 PM, Isuri Anuradha wrote: > Pull request URL. > > [1] - https://github.com/wso2/carbon-kernel/pull/1460 > > Thanks. > > On Wed, Aug 2, 2017 at

Re: [Dev] Please review and merge the pull request

Pull request URL. [1] - https://github.com/wso2/carbon-kernel/pull/1460 Thanks. On Wed, Aug 2, 2017 at 3:10 PM, Isuri Anuradha wrote: > Hi! > > Please merge the pull request [1] which contains the fix for [2]. > > [1]- https://github.com/wso2/carbon-kernel/pull/1460 > [2]-

Re: [Dev] Please review and merge the pull request

Hi Farasath, It seems like the PR **url** is correct but the hyperlink is wrong. Just adding the PR link again to avoid the confusion. https://github.com/wso2/carbon-kernel/pull/1456 Regards, On Fri, Jul 28, 2017 at 6:58 PM, Farasath Ahamed wrote: > > > > On Fri, Jul 28,

Re: [Dev] Please review and merge the pull request

On Fri, Jul 28, 2017 at 6:29 PM, Dewni Weeraman wrote: > > Hi, > > Please merge the pull request [1] which contains the fix for [2]. > > [1] - https://github.com/wso2/carbon-kernel/pull/1456 > > This PR is already merged. Is this

[Dev] Please review and merge the pull request

Hi, Please merge the pull request [1] which contains the fix for [2]. [1] - https://github.com/wso2/carbon-kernel/pull/1456 [2] - https://github.com/wso2/carbon-kernel/issues/1455 Regards, Dewni Weeraman -- *Dewni Weeraman* Trainee Software

Re: [Dev] Please review and merge the pull request

Thanks! On Fri, Jul 21, 2017 at 10:17 AM, Thusitha Thilina Dayaratne < thusit...@wso2.com> wrote: > Hi Thanuja, > > PR is merged to 4.4.x branch. > > Thanks > Thusitha > > On Thu, Jul 20, 2017 at 6:31 PM, Thanuja Jayasinghe > wrote: > >> Hi Kishanthan, >> >> Please merge the

Re: [Dev] Please review and merge the pull request

Hi Thanuja, PR is merged to 4.4.x branch. Thanks Thusitha On Thu, Jul 20, 2017 at 6:31 PM, Thanuja Jayasinghe wrote: > Hi Kishanthan, > > Please merge the pull request [1] which contains the fix for [2]. > > [1] - https://github.com/wso2/carbon-kernel/pull/1445 > [2] -

[Dev] Please review and merge the pull request

Hi Kishanthan, Please merge the pull request [1] which contains the fix for [2]. [1] - https://github.com/wso2/carbon-kernel/pull/1445 [2] - https://github.com/wso2/carbon-kernel/issues/1444 Thanks, Thanuja -- *Thanuja Lakmal* Associate Technical Lead WSO2 Inc. http://wso2.com/

[Dev] Please review and merge the PR

Hi Jayanga, Please review and merge the PR[1] for issue[2]. 1. https://github.com/wso2/carbon-kernel/pull/1417 2. https://github.com/wso2/carbon-kernel/issues/1416 Best Regards, -- *Lahiru Manohara* *Software Engineer* Mobile: +94716561576 WSO2 Inc. | http://wso2.com lean.enterprise.middleware

Re: [Dev] Please review and merge the pull request

Thanks. On Wed, May 31, 2017 at 11:58 AM, Jayanga Dissanayake wrote: > Hi Tahnuja, > > Merged the PR. > > Thanks, > Jayanga. > > *Jayanga Dissanayake* > Associate Technical Lead > WSO2 Inc. - http://wso2.com/ > lean . enterprise . middleware > email: jaya...@wso2.com > mobile:

Re: [Dev] Please review and merge the pull request

Hi Tahnuja, Merged the PR. Thanks, Jayanga. *Jayanga Dissanayake* Associate Technical Lead WSO2 Inc. - http://wso2.com/ lean . enterprise . middleware email: jaya...@wso2.com mobile: +94772207259 On Tue, May 30, 2017 at 12:28 PM, Thanuja Jayasinghe

[Dev] Please review and merge the pull request

Hi Jayanga, Please merge the pull request [1] which contains the fix for [2]. [1] - https://github.com/wso2/carbon-kernel/pull/1388 [2] - https://github.com/wso2/carbon-kernel/issues/1387 Thanks, Thanuja -- *Thanuja Lakmal* Senior Software Engineer WSO2 Inc. http://wso2.com/

Re: [Dev] Please review and merge

Thanks, Rajjaz. Farasath Ahamed Software Engineer, WSO2 Inc.; http://wso2.com Mobile: +94777603866 Blog: blog.farazath.com Twitter: @farazath619 On Sat, May 6, 2017 at 11:29 AM, Rajjaz Mohammed wrote: > Hi All, >

Re: [Dev] Please review and merge

Hi All, You can find the new version of extension here[1]. [1] https://store.wso2.com/store/assets/isconnector/details/8affec9a-706f-4e72-83ec-f65c42895d40 On Sat, May 6, 2017 at 9:41 AM, Rajjaz Mohammed wrote: > Hi, > > We will do the needful to release the extension. > > On

Re: [Dev] Please review and merge

Hi, We will do the needful to release the extension. On Fri, May 5, 2017 at 6:07 PM, Farasath Ahamed wrote: > Hi Kathees, > > Also, can you do the needful to update the connector store with this > latest version? > > > Thanks, > Farasath > > Farasath Ahamed > Software

Re: [Dev] Please review and merge

Hi Kathees, Also, can you do the needful to update the connector store with this latest version? Thanks, Farasath Farasath Ahamed Software Engineer, WSO2 Inc.; http://wso2.com Mobile: +94777603866 Blog: blog.farazath.com Twitter: @farazath619

Re: [Dev] Please review and merge

Hi Ishara/Hasanthi, The PR is merged. Thanks, Kathees On Fri, May 5, 2017 at 1:00 PM, Ishara Karunarathna wrote: > Hi connector team, > > Can we get this merged ? > > -Ishara > > On Fri, May 5, 2017 at 10:11 AM, Hasanthi Purnima Dissanayake < > hasan...@wso2.com> wrote: >

Re: [Dev] Please review and merge

Hi connector team, Can we get this merged ? -Ishara On Fri, May 5, 2017 at 10:11 AM, Hasanthi Purnima Dissanayake < hasan...@wso2.com> wrote: > Hi Kathees > > Fixed the comments. > > Thanks, > > Hasanthi Dissanayake > > Software Engineer | WSO2 > > E: hasan...@wso2.com > M :0718407133|

Re: [Dev] Please review and merge

Hi Kathees Fixed the comments. Thanks, Hasanthi Dissanayake Software Engineer | WSO2 E: hasan...@wso2.com M :0718407133| http://wso2.com On Fri, May 5, 2017 at 9:45 AM, Kathees Rajendram wrote: > Thanks Hasanthi for your fix. > > Please fix those

Re: [Dev] Please review and merge

Thanks Hasanthi for your fix. Please fix those comments in the PR. Thanks, Kathees On Thu, May 4, 2017 at 3:16 PM, Hasanthi Purnima Dissanayake < hasan...@wso2.com> wrote: > Hi connector team, > Please review and merge [1] which fixes [2]. >

[Dev] Please review and merge

Hi connector team, Please review and merge [1] which fixes [2]. [1]https://github.com/wso2-extensions/identity-oauth2-grant-jwt/pull/14 [2]https://wso2.org/jira/browse/IDENTITY-5888 Thanks, Hasanthi Dissanayake Software Engineer | WSO2 E: hasan...@wso2.com M :0718407133| http://wso2.com

[Dev] Please Review and Merge (WebSocket Client Connector)

Hi, Please review and merge this PR. https://github.com/wso2/carbon-transports/pull/287 Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. * *Email : irun...@wso2.com * *LinkedIn : https://lk.linkedin.com/in/irunika

[Dev] Please review and merge

Hi kernel team, Please review and merge [1] which fixes [2] [1] https://github.com/wso2-support/carbon4-kernel/pull/211 [2] https://wso2.org/jira/browse/IDENTITY-5314 Thanks, Hasanthi Dissanayake Software Engineer | WSO2 E: hasan...@wso2.com M :0718407133| http://wso2.com

Re: [Dev] Please review and merge the pull request

Thanks Thusitha !!! On Thu, Apr 6, 2017 at 11:58 AM, Thusitha Thilina Dayaratne < thusit...@wso2.com> wrote: > Merged. > > On Thu, Apr 6, 2017 at 11:54 AM, Vinod Kavinda wrote: > >> Hi Kishanthan, >> Please review and merge PR[1] for preparing 4.4.16 release. >> >> [1] -

Re: [Dev] Please review and merge the pull request

Merged. On Thu, Apr 6, 2017 at 11:54 AM, Vinod Kavinda wrote: > Hi Kishanthan, > Please review and merge PR[1] for preparing 4.4.16 release. > > [1] - https://github.com/wso2/carbon-kernel/pull/1350 > > Thanks > > On Thu, Apr 6, 2017 at 10:37 AM, Vijitha Ekanayake

Re: [Dev] Please review and merge the pull request

Hi Kishanthan, Please review and merge PR[1] for preparing 4.4.16 release. [1] - https://github.com/wso2/carbon-kernel/pull/1350 Thanks On Thu, Apr 6, 2017 at 10:37 AM, Vijitha Ekanayake wrote: > Hi Kishanthan, > > I've updated the PR[1] with the issue[2] and a proper

Re: [Dev] Please review and merge the pull request

Hi Kishanthan, I've updated the PR[1] with the issue[2] and a proper description. Could you review and merge the pull request? [1]. https://github.com/wso2/carbon-kernel/pull/1349 [2]. https://github.com/wso2/product-ei/issues/322 Thanks On Thu, Apr 6, 2017 at 9:59 AM, Kishanthan Thangarajah

Re: [Dev] Please review and merge the pull request

Can you also create a github issue with the proper description for this and link it with the PR? On Wed, Apr 5, 2017 at 9:44 PM, Vijitha Ekanayake wrote: > Hi Carbon team, > > Please merge the pull request [1] which contains critical fixes to > support DSS multitenancy over

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi all, Above PR has been closed since it ha2 two branches merged and make so many confusions and also make it very hard to maintain the code. So all the comments from the above PR will be resolved and cleaned in https://github.com/wso2/msf4j/pull/365 Please review and comment. Thanks and best

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi all, Above PR has been closed since it ha2 two branches merged and make so many confusions and also make it very hard to maintain the code. So all the comments from the above PR will be resolved and cleaned in https://github.com/wso2/msf4j/pull/365 Please review and comment. Thanks and best

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Thanks Vidura. Will check. *Irunika Weeraratne* *Software Engineer | WSO2, Inc. * *Email : irun...@wso2.com * *LinkedIn : https://lk.linkedin.com/in/irunika * *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Thu,

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi Irunika, Added some comments in [1] . Please do check. [1] MSF4J Web Socket Pull Request Thank you, Vidura Nanayakkara On Wed, Mar 8, 2017 at 6:21 PM, Irunika Weeraratne wrote: > Hi all, >

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi all, Please review the new changes did and comment. https://github.com/wso2/msf4j/pull/364 Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. * *Email : irun...@wso2.com * *LinkedIn : https://lk.linkedin.com/in/irunika

Re: [Dev] Please review and merge the PR

On Tue, Feb 21, 2017 at 6:03 PM, Ashen Weerathunga wrote: > Hi, > > Can you please review and merge the PR [1]. This is regarding the kernel > update requested in this mail thread [2]. > > [1] https://github.com/wso2/carbon-messaging/pull/57 > [2] [IS-6.0] Updating carbon-kernel

[Dev] Please review and merge

Hi APIM team, Please review and merge [1] [1] https://github.com/wso2/carbon-lcm/pull/1 Thanks Isura. *Isura Dilhara Karunaratne* Senior Software Engineer | WSO2 Email: is...@wso2.com Mob : +94 772 254 810 Blog : http://isurad.blogspot.com/ ___ Dev

Re: [Dev] Please review and merge the PR

Can you please review and apply this PR in order to proceed with other Carbon repos ? Thanks ! On Wed, Feb 15, 2017 at 11:58 AM, Ashen Weerathunga wrote: > Hi all, > > Can you please review and merge the PR [1]. This is regarding the kernel > update requested in this mail

[Dev] Please review and merge the PR

Hi all, Can you please review and merge the PR [1]. This is regarding the kernel update requested in this mail thread [2]. [1] https://github.com/wso2/carbon-jndi/pull/33 [2] [IS-6.0] Updating carbon-kernel version to 5.2.0-m3 Thanks, Ashen -- *Ashen Weerathunga* Software Engineer WSO2 Inc.:

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi all, Created new pull request with necessary changes[1]. please review and merge. [1]https://github.com/wso2/carbon-messaging/pull/41 Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. * *Email : irun...@wso2.com * *LinkedIn :

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi Senduran, Yes. We can use a general control message type instead of ping and pong messages. So I removed ping and pong carbon message types from Carbon-Messaging and added new message type ". Please review and merge. Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc.

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi Irunika, The above PR has PingCarbonMessage and PongCarbonMessage. It will be better if you could rename those two classes to generalized name. Regards Senduran On Fri, Jan 27, 2017 at 2:47 PM, Kishanthan Thangarajah wrote: > Looks ok. > > Senduran/Shafreen, can we

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Looks ok. Senduran/Shafreen, can we merge this PR? On Thu, Jan 26, 2017 at 7:27 PM, Irunika Weeraratne wrote: > Hi, > Fixed the issues mentioned. > Please review and merge. > > Thanks, > Irunika > > *Irunika Weeraratne* > *Software Engineer | WSO2, Inc. * >

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi, Fixed the issues mentioned. Please review and merge. Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. * *Email : irun...@wso2.com * *LinkedIn : https://lk.linkedin.com/in/irunika * *Mobile :

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Noted. Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. * *Email : irun...@wso2.com * *LinkedIn : https://lk.linkedin.com/in/irunika * *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Thu,

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

PR has some formatting issue to be fixed. Can you look into it? On Thu, Jan 26, 2017 at 12:03 PM, Irunika Weeraratne wrote: > Hi all, > Can you please review and merge the PR? > > Thanks, > Irunika > > *Irunika Weeraratne* > *Software Engineer | WSO2, Inc. *

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi all, Can you please review and merge the PR? Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. * *Email : irun...@wso2.com * *LinkedIn : https://lk.linkedin.com/in/irunika * *Mobile : +94712403314*

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi all, I modified the Carbon-Messaging according to the requirements. Please review and merge. https://github.com/wso2/carbon-messaging/pull/40 Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. * *Email : irun...@wso2.com * *LinkedIn :

[Dev] Please review and merge

Hi All, Please review and merge [1]. This is the fix for [2]. [1] - https://github.com/wso2/carbon-kernel/pull/1277 [2] - https://github.com/wso2/carbon-kernel/issues/1276 Thanks, Thanuja -- *Thanuja Lakmal* Senior Software Engineer WSO2 Inc. http://wso2.com/ *lean.enterprise.middleware*

Re: [Dev] Please review and merge

Hi Kishanthan Yes we have already configured auto release for this job. On Thu, Jan 19, 2017 at 11:44 PM, Kishanthan Thangarajah < kishant...@wso2.com> wrote: > Hi Maheshika, > > Have we enabled auto release for carbon-deployment 4.7.x branch [1]? If > not, we have to enable it. > > [1]

Re: [Dev] Please review and merge

Hi Maheshika, Have we enabled auto release for carbon-deployment 4.7.x branch [1]? If not, we have to enable it. [1] https://github.com/wso2/carbon-deployment/tree/4.7.x On Thu, Jan 19, 2017 at 6:39 PM, Kishanthan Thangarajah wrote: > This is merged. > > On Thu, Jan 19,

  1   2   3   4   5   6   7   >