jkesselm commented on PR #130:
URL: https://github.com/apache/xalan-java/pull/130#issuecomment-1829076570
> If a goal or phase in lifecycle A needs another one in lifecycle B, this
is a smell.
You're right, I misread. Apologies. It was tired and I was late.
The choice to put J
kriegaex commented on PR #130:
URL: https://github.com/apache/xalan-java/pull/130#issuecomment-1829010253
> You removed "site" from the build script.
No, I did not. I reckon it is late at your location, maybe your eyes are
just a bit tired. Please check again. I removed `compile`, bec
jkesselm merged PR #130:
URL: https://github.com/apache/xalan-java/pull/130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@xalan.apache
jkesselm commented on PR #130:
URL: https://github.com/apache/xalan-java/pull/130#issuecomment-1828454849
(Note that CI on the maven build will fail until the lib/ directory *is*
created.)
I'm going to merge this but put "site" back in for now -- it's a separate
issue.
--
This is
jkesselm commented on PR #130:
URL: https://github.com/apache/xalan-java/pull/130#issuecomment-1828162303
(In other words, unless I've missed something else you've done, that doesn't
seem to be just a cosmetic change.)
--
This is an automated message from the Apache Git Service.
To respo
jkesselm commented on PR #130:
URL: https://github.com/apache/xalan-java/pull/130#issuecomment-1828159843
You removed "site" from the build script. Remember that our "binary
distributions" zipfiles need to include the documentation. AFAICT, that means
site must occur before package produce
kriegaex opened a new pull request, #130:
URL: https://github.com/apache/xalan-java/pull/130
Copy dependencies to _[root]/lib_ directory during package phase. Also Build
Helper Maven Plugin to generate a property for the project root folder, using
it from Maven Dependency Plugin. This can c
