[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4545: CI broken

2023-01-18 Thread GitBox
jongyoul commented on code in PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1080757497 ## zeppelin-zengine/pom.xml: ## @@ -304,10 +304,6 @@ - Review Comment: Yeah, this kind of step is too hard to debug by IDE, but,

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4545: CI broken

2023-01-18 Thread GitBox
Reamer commented on code in PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1073665797 ## zeppelin-zengine/pom.xml: ## @@ -304,10 +304,6 @@ - Review Comment: It took me a long time to figure out that this execution breaks

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4545: CI broken

2023-01-18 Thread GitBox
Reamer commented on code in PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1073656877 ## python/src/test/java/org/apache/zeppelin/python/IPythonInterpreterTest.java: ## @@ -434,9 +434,6 @@ public void run() { InterpreterResult result =

[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken

2023-01-18 Thread GitBox
Reamer commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1387192701 > I think it's good but I just have one question. Is there any critical reason that we changed `test` to `verify`? It looks similar and `verify` is running after `test` and `package`,

[GitHub] [zeppelin] jongyoul commented on pull request #4545: CI broken

2023-01-18 Thread GitBox
jongyoul commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1387164198 I think it's good but I just have one question. Is there any critical reason that we changed `test` to `verify`? It looks similar and `verify` is running after `test` and `package`,

[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken

2023-01-17 Thread GitBox
Reamer commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1385569897 The tests are running through. I will clean up the PR now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [zeppelin] Reamer merged pull request #4557: [MINOR] Remove conda cache suffix

2023-01-17 Thread GitBox
Reamer merged PR #4557: URL: https://github.com/apache/zeppelin/pull/4557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] ustas4 commented on pull request #805: ZEPPELIN-580 Add support for multi select in form select box

2023-01-17 Thread GitBox
ustas4 commented on PR #805: URL: https://github.com/apache/zeppelin/pull/805#issuecomment-1384985576 I can't understand for what interpreter that code work. Tested for python 3.8 . Only one record selected. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zeppelin] Reamer opened a new pull request, #4557: [MINOR] Remove conda cache suffix

2023-01-16 Thread GitBox
Reamer opened a new pull request, #4557: URL: https://github.com/apache/zeppelin/pull/4557 ### What is this PR for? This PR removes an unnecessary cache suffix ### What type of PR is it? Bug Fix ### How should this be tested? * CI ### Questions: * Does

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`

2023-01-16 Thread GitBox
Reamer commented on code in PR #4556: URL: https://github.com/apache/zeppelin/pull/4556#discussion_r1071467869 ## .github/workflows/core.yml: ## @@ -59,7 +59,8 @@ jobs: !~/.m2/repository/org/apache/zeppelin/ ~/.spark-dist ~/.cache -

[GitHub] [zeppelin] jongyoul commented on pull request #4543: Bump jettison from 1.4.0 to 1.5.2

2023-01-16 Thread GitBox
jongyoul commented on PR #4543: URL: https://github.com/apache/zeppelin/pull/4543#issuecomment-1383755701 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] jongyoul commented on pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`

2023-01-16 Thread GitBox
jongyoul commented on PR #4556: URL: https://github.com/apache/zeppelin/pull/4556#issuecomment-1383660284 > Since the shading still creates weird classes, I will continue to work on #4545 . Agreed. It would be great if we could handle all thing this time. -- This is an automated

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`

2023-01-16 Thread GitBox
jongyoul commented on code in PR #4556: URL: https://github.com/apache/zeppelin/pull/4556#discussion_r1070951485 ## .github/workflows/core.yml: ## @@ -59,7 +59,8 @@ jobs: !~/.m2/repository/org/apache/zeppelin/ ~/.spark-dist ~/.cache -

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`

2023-01-16 Thread GitBox
jongyoul commented on code in PR #4556: URL: https://github.com/apache/zeppelin/pull/4556#discussion_r1070950816 ## zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/PooledRemoteClient.java: ## @@ -44,6 +45,9 @@ public PooledRemoteClient(SupplierWithIO

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`

2023-01-16 Thread GitBox
Reamer commented on code in PR #4556: URL: https://github.com/apache/zeppelin/pull/4556#discussion_r1070943224 ## .github/workflows/core.yml: ## @@ -59,7 +59,8 @@ jobs: !~/.m2/repository/org/apache/zeppelin/ ~/.spark-dist ~/.cache -

[GitHub] [zeppelin] Reamer merged pull request #4553: [ZEPPELIN-5874] polish flink code base

2023-01-16 Thread GitBox
Reamer merged PR #4553: URL: https://github.com/apache/zeppelin/pull/4553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] jongyoul merged pull request #4554: Bump global-modules-path and webpack-cli in /zeppelin-web

2023-01-15 Thread GitBox
jongyoul merged PR #4554: URL: https://github.com/apache/zeppelin/pull/4554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] jongyoul commented on pull request #4554: Bump global-modules-path and webpack-cli in /zeppelin-web

2023-01-15 Thread GitBox
jongyoul commented on PR #4554: URL: https://github.com/apache/zeppelin/pull/4554#issuecomment-1383453291 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] jongyoul merged pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`

2023-01-15 Thread GitBox
jongyoul merged PR #4556: URL: https://github.com/apache/zeppelin/pull/4556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] zjffdu commented on pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`

2023-01-15 Thread GitBox
zjffdu commented on PR #4556: URL: https://github.com/apache/zeppelin/pull/4556#issuecomment-1383400648 Thanks @jongyoul -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] jongyoul commented on pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`

2023-01-15 Thread GitBox
jongyoul commented on PR #4556: URL: https://github.com/apache/zeppelin/pull/4556#issuecomment-1383291254 CI is all green now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`

2023-01-15 Thread GitBox
jongyoul commented on code in PR #4556: URL: https://github.com/apache/zeppelin/pull/4556#discussion_r1070608092 ## zeppelin-interpreter-parent/pom.xml: ## @@ -113,6 +113,7 @@ org.apache.maven.plugins maven-shade-plugin +false

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`

2023-01-15 Thread GitBox
jongyoul commented on code in PR #4556: URL: https://github.com/apache/zeppelin/pull/4556#discussion_r1070608092 ## zeppelin-interpreter-parent/pom.xml: ## @@ -113,6 +113,7 @@ org.apache.maven.plugins maven-shade-plugin +false

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`

2023-01-15 Thread GitBox
jongyoul commented on code in PR #4556: URL: https://github.com/apache/zeppelin/pull/4556#discussion_r1070608092 ## zeppelin-interpreter-parent/pom.xml: ## @@ -113,6 +113,7 @@ org.apache.maven.plugins maven-shade-plugin +false

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`

2023-01-15 Thread GitBox
jongyoul commented on code in PR #4556: URL: https://github.com/apache/zeppelin/pull/4556#discussion_r1070564606 ## zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/PooledRemoteClient.java: ## @@ -44,6 +45,7 @@ public PooledRemoteClient(SupplierWithIO

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`

2023-01-15 Thread GitBox
jongyoul commented on code in PR #4556: URL: https://github.com/apache/zeppelin/pull/4556#discussion_r1070563685 ## zeppelin-interpreter-shaded/pom.xml: ## @@ -117,6 +117,8 @@ org/w3c/dom/**/* org/xml/sax/* org/xml/sax/**/* + +

[GitHub] [zeppelin] jongyoul commented on pull request #4555: [MINOR] Disable depeanabot branches for AppVeyor

2023-01-15 Thread GitBox
jongyoul commented on PR #4555: URL: https://github.com/apache/zeppelin/pull/4555#issuecomment-1383111656 Yeah ~ Works fine :-) #4546 https://user-images.githubusercontent.com/3612566/212535157-ba0e83b5-946e-4c94-90e4-2f4446f6777b.png;> -- This is an automated message from the

[GitHub] [zeppelin] jongyoul commented on pull request #4546: Bump ms from 0.7.0 to 2.0.0 in /zeppelin-web

2023-01-15 Thread GitBox
jongyoul commented on PR #4546: URL: https://github.com/apache/zeppelin/pull/4546#issuecomment-1383110971 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] jongyoul merged pull request #4555: [MINOR] Disable depeanabot branches for AppVeyor

2023-01-15 Thread GitBox
jongyoul merged PR #4555: URL: https://github.com/apache/zeppelin/pull/4555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] raboof commented on a diff in pull request #4549: [MINOR] document 'markdown' display system

2023-01-15 Thread GitBox
raboof commented on code in PR #4549: URL: https://github.com/apache/zeppelin/pull/4549#discussion_r1070548910 ## docs/usage/display_system/basic.md: ## @@ -1,7 +1,7 @@ --- layout: page title: "Basic Display System in Apache Zeppelin" -description: "There are 3 basic display

[GitHub] [zeppelin] jongyoul commented on pull request #4555: [MINOR] Disable depeanabot branches for AppVeyor

2023-01-15 Thread GitBox
jongyoul commented on PR #4555: URL: https://github.com/apache/zeppelin/pull/4555#issuecomment-1383084869 Haha, right.  Let's see how it goes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zeppelin] jongyoul opened a new pull request, #4556: [ZEPPELIN-5875] Fix a flaky test in `TimeoutLifecycleManagerTest`

2023-01-14 Thread GitBox
jongyoul opened a new pull request, #4556: URL: https://github.com/apache/zeppelin/pull/4556 ### What is this PR for? Fixing flaky test in `core-modules (hadoop[2|3])`. ### What type of PR is it? Bug Fix ### Todos * [ ] - Fix `testTimeout_2` ### What is the

[GitHub] [zeppelin] jongyoul opened a new pull request, #4555: [MINOR] Disable depeanabot branches for AppVeyor

2023-01-14 Thread GitBox
jongyoul opened a new pull request, #4555: URL: https://github.com/apache/zeppelin/pull/4555 ### What is this PR for? Disabling to execute AppVeyor jobs for branches for `dependabot`. ### What type of PR is it? Improvement ### Todos * [x] - Add `except` settings for

[GitHub] [zeppelin] jongyoul commented on pull request #4552: [MINOR] Fix wrong format for github actions of 'branches-ignore'

2023-01-14 Thread GitBox
jongyoul commented on PR #4552: URL: https://github.com/apache/zeppelin/pull/4552#issuecomment-1382739536 Checked it worked properly on #4554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] jongyoul commented on pull request #4554: Bump global-modules-path and webpack-cli in /zeppelin-web

2023-01-14 Thread GitBox
jongyoul commented on PR #4554: URL: https://github.com/apache/zeppelin/pull/4554#issuecomment-1382738392 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] jongyoul merged pull request #4549: [MINOR] document 'markdown' display system

2023-01-14 Thread GitBox
jongyoul merged PR #4549: URL: https://github.com/apache/zeppelin/pull/4549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] jongyoul merged pull request #4552: [MINOR] Fix wrong format for github actions of 'branches-ignore'

2023-01-14 Thread GitBox
jongyoul merged PR #4552: URL: https://github.com/apache/zeppelin/pull/4552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4554: Bump global-modules-path and webpack-cli in /zeppelin-web

2023-01-13 Thread GitBox
dependabot[bot] opened a new pull request, #4554: URL: https://github.com/apache/zeppelin/pull/4554 Removes [global-modules-path](https://github.com/rosen-vladimirov/global-modules-path). It's no longer used after updating ancestor dependency

[GitHub] [zeppelin] Reamer opened a new pull request, #4553: [ZEPPELIN-5874] polish flink code base

2023-01-13 Thread GitBox
Reamer opened a new pull request, #4553: URL: https://github.com/apache/zeppelin/pull/4553 ### What is this PR for? Just a little polish pull request, for classes I passed during #4545. ### What type of PR is it? - Refactoring ### What is the Jira issue? *

[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken

2023-01-13 Thread GitBox
Reamer commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1382117894 @zjffdu Do you have any idea how to fix the Flink compilation? I find the setup with the symlink of `flink-scala-parent` very unattractive, this does not seem clean. -- This is an

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4549: [MINOR] document 'markdown' display system

2023-01-13 Thread GitBox
jongyoul commented on code in PR #4549: URL: https://github.com/apache/zeppelin/pull/4549#discussion_r1069475492 ## docs/usage/display_system/basic.md: ## @@ -1,7 +1,7 @@ --- layout: page title: "Basic Display System in Apache Zeppelin" -description: "There are 3 basic

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4549: [MINOR] document 'markdown' display system

2023-01-13 Thread GitBox
Reamer commented on code in PR #4549: URL: https://github.com/apache/zeppelin/pull/4549#discussion_r1069465068 ## docs/usage/display_system/basic.md: ## @@ -1,7 +1,7 @@ --- layout: page title: "Basic Display System in Apache Zeppelin" -description: "There are 3 basic display

[GitHub] [zeppelin] jongyoul opened a new pull request, #4552: [MINOR] Fix wrong format for github actions of 'branches-ignore'

2023-01-13 Thread GitBox
jongyoul opened a new pull request, #4552: URL: https://github.com/apache/zeppelin/pull/4552 ### What is this PR for? I don't know when I missed it but the syntax was wrong in my lastest PR for github action #4529. It fixes this error referenced by

[GitHub] [zeppelin] jongyoul merged pull request #4376: Bump eventsource from 1.0.7 to 1.1.1 in /zeppelin-web-angular

2023-01-13 Thread GitBox
jongyoul merged PR #4376: URL: https://github.com/apache/zeppelin/pull/4376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] jongyoul commented on pull request #4377: Bump @angular/core from 8.2.12 to 11.0.5 in /zeppelin-web-angular

2023-01-13 Thread GitBox
jongyoul commented on PR #4377: URL: https://github.com/apache/zeppelin/pull/4377#issuecomment-1381766401 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] jongyoul commented on pull request #4461: Bump jszip from 3.2.2 to 3.10.1 in /zeppelin-web-angular

2023-01-13 Thread GitBox
jongyoul commented on PR #4461: URL: https://github.com/apache/zeppelin/pull/4461#issuecomment-1381765614 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] jongyoul commented on pull request #4502: Bump socket.io-parser and karma in /zeppelin-web-angular

2023-01-13 Thread GitBox
jongyoul commented on PR #4502: URL: https://github.com/apache/zeppelin/pull/4502#issuecomment-1381765142 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] jongyoul commented on pull request #4514: Bump engine.io and karma in /zeppelin-web-angular

2023-01-13 Thread GitBox
jongyoul commented on PR #4514: URL: https://github.com/apache/zeppelin/pull/4514#issuecomment-1381764269 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] jongyoul commented on pull request #4533: Bump simple-git and lint-staged in /zeppelin-web-angular

2023-01-13 Thread GitBox
jongyoul commented on PR #4533: URL: https://github.com/apache/zeppelin/pull/4533#issuecomment-1381763409 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] jongyoul commented on pull request #4527: Bump decode-uri-component from 0.2.0 to 0.2.2 in /zeppelin-web-angular

2023-01-13 Thread GitBox
jongyoul commented on PR #4527: URL: https://github.com/apache/zeppelin/pull/4527#issuecomment-1381763739 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] jongyoul commented on pull request #4539: Bump express from 4.17.1 to 4.18.2 in /zeppelin-web-angular

2023-01-13 Thread GitBox
jongyoul commented on PR #4539: URL: https://github.com/apache/zeppelin/pull/4539#issuecomment-1381762629 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] jongyoul commented on pull request #4535: Bump qs from 6.5.2 to 6.5.3 in /zeppelin-web-angular

2023-01-13 Thread GitBox
jongyoul commented on PR #4535: URL: https://github.com/apache/zeppelin/pull/4535#issuecomment-1381763003 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] jongyoul merged pull request #4544: Bump json5 from 1.0.1 to 1.0.2 in /zeppelin-web-angular

2023-01-13 Thread GitBox
jongyoul merged PR #4544: URL: https://github.com/apache/zeppelin/pull/4544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] Reamer merged pull request #4551: [Typo] Correct small typo

2023-01-13 Thread GitBox
Reamer merged PR #4551: URL: https://github.com/apache/zeppelin/pull/4551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] jongyoul commented on pull request #4551: [Typo] Correct small typo

2023-01-13 Thread GitBox
jongyoul commented on PR #4551: URL: https://github.com/apache/zeppelin/pull/4551#issuecomment-1381541566 Thank you. Could you please merge it? I'm out so I cannot merge it right now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [zeppelin] Reamer opened a new pull request, #4551: [Typo] Correct small typo

2023-01-13 Thread GitBox
Reamer opened a new pull request, #4551: URL: https://github.com/apache/zeppelin/pull/4551 ### What is this PR for? #4550 contains a small typo. ### What type of PR is it? Typo ### How should this be tested? * CI ### Questions: * Does the license files need

[GitHub] [zeppelin] Reamer commented on pull request #4550: [HOTFIX] Github Actions workaround

2023-01-13 Thread GitBox
Reamer commented on PR #4550: URL: https://github.com/apache/zeppelin/pull/4550#issuecomment-1381528776 @jongyoul Great that you have fixed this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zeppelin] jongyoul merged pull request #4550: [HOTFIX] Github Actions workaround

2023-01-13 Thread GitBox
jongyoul merged PR #4550: URL: https://github.com/apache/zeppelin/pull/4550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] jongyoul commented on pull request #4550: [HOTFIX] Github Actions workaround

2023-01-13 Thread GitBox
jongyoul commented on PR #4550: URL: https://github.com/apache/zeppelin/pull/4550#issuecomment-1381458684 @Reamer @zjffdu @huage1994 Can anyone approve this PR? It needs one approval at least to merge it;; -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zeppelin] jongyoul commented on pull request #4550: [HOTFIX] Github Actions workaround

2023-01-13 Thread GitBox
jongyoul commented on PR #4550: URL: https://github.com/apache/zeppelin/pull/4550#issuecomment-1381457227 The CI returned to the normal status ( there are still two infinite running tasks). I'll merge it as a hotfix.

[GitHub] [zeppelin] jongyoul commented on pull request #4545: CI broken

2023-01-12 Thread GitBox
jongyoul commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1381324679 I made #4550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [zeppelin] jongyoul opened a new pull request, #4550: [HOTFIX] Github Actions workaround

2023-01-12 Thread GitBox
jongyoul opened a new pull request, #4550: URL: https://github.com/apache/zeppelin/pull/4550 ### What is this PR for? Current CI fails everytime. It's already reported conda-incubator/setup-miniconda#274 ### What type of PR is it? Hot Fix ### Todos * [x] - Adopt

[GitHub] [zeppelin] jongyoul commented on pull request #4545: CI broken

2023-01-12 Thread GitBox
jongyoul commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1381318657 https://github.com/conda-incubator/setup-miniconda/issues/274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [zeppelin] jongyoul commented on pull request #4545: CI broken

2023-01-12 Thread GitBox
jongyoul commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1381314053 BTW, I see some different outputs for CI as well. Do you have any idea? https://user-images.githubusercontent.com/3612566/212240504-1def015b-859b-4a97-8c81-ec0a55cffd6f.png;>

[GitHub] [zeppelin] raboof opened a new pull request, #4549: [MINOR] document 'markdown' display system

2023-01-12 Thread GitBox
raboof opened a new pull request, #4549: URL: https://github.com/apache/zeppelin/pull/4549 ### What is this PR for? Document that the markdown display system exists ### What type of PR is it? Improvement Documentation ### Todos None ### What is the Jira

[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken

2023-01-12 Thread GitBox
Reamer commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1380118193 Spark CI-Jobs seems to be running without errors. https://github.com/apache/zeppelin/actions/runs/3894046270/jobs/6660597445 -- This is an automated message from the Apache Git

[GitHub] [zeppelin] 3792274 commented on pull request #1868: [ZEPPELIN-1917] Improve python.conda interpreter

2023-01-11 Thread GitBox
3792274 commented on PR #1868: URL: https://github.com/apache/zeppelin/pull/1868#issuecomment-1379934886 > @3792274 Hello, Could you please make an issue for it? I think it's easier to keep track of the issue. :-) yes you are right ,thank you. -- This is an automated message from

[GitHub] [zeppelin] jongyoul commented on pull request #1868: [ZEPPELIN-1917] Improve python.conda interpreter

2023-01-11 Thread GitBox
jongyoul commented on PR #1868: URL: https://github.com/apache/zeppelin/pull/1868#issuecomment-1379774588 @3792274 Hello, Could you please make an issue for it? I think it's easier to keep track of the issue. :-) -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [zeppelin] 3792274 commented on pull request #1868: [ZEPPELIN-1917] Improve python.conda interpreter

2023-01-11 Thread GitBox
3792274 commented on PR #1868: URL: https://github.com/apache/zeppelin/pull/1868#issuecomment-1379767545 > ### What is this PR for? > Add missing commands to the `python.conda` interpreter > > * `conda info` > * `conda list` > * `conda create` > * `conda install` > *

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4548: Bump debug, grunt-contrib-watch and grunt-usemin in /zeppelin-web

2023-01-11 Thread GitBox
dependabot[bot] opened a new pull request, #4548: URL: https://github.com/apache/zeppelin/pull/4548 Bumps [debug](https://github.com/debug-js/debug) to 2.6.9 and updates ancestor dependencies [debug](https://github.com/debug-js/debug),

[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken

2023-01-11 Thread GitBox
Reamer commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1378852906 The following error seems to be a maven reactor issue. Running the tests with ` -am -Dtest=org/apache/zeppelin/spark/*` seems to solve the issue (at least on my local machine) ```

[GitHub] [zeppelin] jongyoul commented on pull request #4547: fix(sec): upgrade org.codehaus.jettison:jettison to 1.5.1

2023-01-11 Thread GitBox
jongyoul commented on PR #4547: URL: https://github.com/apache/zeppelin/pull/4547#issuecomment-1378537285 Hello, Thank you for the contribution but it's duplicated with #4543. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4546: Bump ms from 0.7.0 to 2.0.0 in /zeppelin-web

2023-01-10 Thread GitBox
dependabot[bot] opened a new pull request, #4546: URL: https://github.com/apache/zeppelin/pull/4546 Bumps [ms](https://github.com/vercel/ms) from 0.7.0 to 2.0.0. Release notes Sourced from https://github.com/vercel/ms/releases;>ms's releases. 2.0.0 Major Changes

[GitHub] [zeppelin] jongyoul merged pull request #4541: [MINOR] Support aarch for frontend plugin

2023-01-10 Thread GitBox
jongyoul merged PR #4541: URL: https://github.com/apache/zeppelin/pull/4541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4545: CI broken

2023-01-09 Thread GitBox
Reamer commented on code in PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1065427653 ## zeppelin-interpreter-shaded/pom.xml: ## @@ -33,7 +33,7 @@ Zeppelin Interpreter Shaded - org.apache.zeppelin.shaded +shaded Review Comment: At

[GitHub] [zeppelin] jongyoul commented on pull request #4541: [MINOR] Support aarch for frontend plugin

2023-01-09 Thread GitBox
jongyoul commented on PR #4541: URL: https://github.com/apache/zeppelin/pull/4541#issuecomment-1376759595 @Reamer The CI becomes back as the previous so it's ok. Could you please recheck it? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [zeppelin] pan3793 commented on a diff in pull request #4545: CI broken

2023-01-09 Thread GitBox
pan3793 commented on code in PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1065327386 ## zeppelin-interpreter-shaded/pom.xml: ## @@ -33,7 +33,7 @@ Zeppelin Interpreter Shaded - org.apache.zeppelin.shaded +shaded Review Comment: If

[GitHub] [zeppelin] jongyoul merged pull request #4529: [MINOR] Specify branch names for Github action

2023-01-09 Thread GitBox
jongyoul merged PR #4529: URL: https://github.com/apache/zeppelin/pull/4529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken

2023-01-09 Thread GitBox
Reamer commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1375722112 The next error, which occurs frequently, is as follows. ``` 2023-01-06T17:43:32.9579892Z [ERROR] testIPythonProcessKilled Time elapsed: 3.305 s <<< ERROR!

[GitHub] [zeppelin] kriegaex commented on a diff in pull request #4545: CI broken

2023-01-09 Thread GitBox
kriegaex commented on code in PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1064453968 ## zeppelin-interpreter-shaded/pom.xml: ## @@ -33,7 +33,7 @@ Zeppelin Interpreter Shaded - org.apache.zeppelin.shaded +shaded Review Comment: I

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4545: CI broken

2023-01-09 Thread GitBox
Reamer commented on code in PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1064361473 ## zeppelin-interpreter-shaded/pom.xml: ## @@ -33,7 +33,7 @@ Zeppelin Interpreter Shaded - org.apache.zeppelin.shaded +shaded Review Comment: > is

[GitHub] [zeppelin] pan3793 commented on a diff in pull request #4545: CI broken

2023-01-07 Thread GitBox
pan3793 commented on code in PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1064020760 ## zeppelin-interpreter-shaded/pom.xml: ## @@ -33,7 +33,7 @@ Zeppelin Interpreter Shaded - org.apache.zeppelin.shaded +shaded Review Comment: is

[GitHub] [zeppelin] jongyoul commented on pull request #4545: CI broken

2023-01-06 Thread GitBox
jongyoul commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1374327740 Oh.. Interesting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] jongyoul commented on pull request #4541: [MINOR] Support aarch for frontend plugin

2023-01-06 Thread GitBox
jongyoul commented on PR #4541: URL: https://github.com/apache/zeppelin/pull/4541#issuecomment-1374326089 Thank you for the description. I also checked it and found the latest version is supporting that way. In our current version, the plugin tries to add suffix for arm64 to download

[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken

2023-01-06 Thread GitBox
Reamer commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1373918746 Next error ´´´ Error: Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.2.2:shade (default) on project zeppelin-jupyter-interpreter-shaded: Error creating

[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken

2023-01-06 Thread GitBox
Reamer commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1373780697 ``` Caused by: java.lang.ClassNotFoundException: org/apache/zeppelin/shaded/org.apache.zeppelin.shaded.org.apache.commons.pool2.impl.DefaultEvictionPolicy ``` looks like a

[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken

2023-01-06 Thread GitBox
Reamer commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1373762162 Found the following error inside log. Therefore I created [ZEPPELIN-5861](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-5861) ```

[GitHub] [zeppelin] Reamer opened a new pull request, #4545: CI broken

2023-01-06 Thread GitBox
Reamer opened a new pull request, #4545: URL: https://github.com/apache/zeppelin/pull/4545 ### What is this PR for? At the moment the CI is broken. This PullRequest is intended to be a common basis to fix the error quickly. ### What type of PR is it? Bug Fix ### Todos

[GitHub] [zeppelin] pan3793 commented on pull request #4541: [MINOR] Support aarch for frontend plugin

2023-01-06 Thread GitBox
pan3793 commented on PR #4541: URL: https://github.com/apache/zeppelin/pull/4541#issuecomment-1373491658 I roughly remember that NodeJS officially supported Apple Silicon in v16(actually in v15, but it's not an LTS, and was EOL), and eventually, they decided to port this feature to v14 but

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4544: Bump json5 from 1.0.1 to 1.0.2 in /zeppelin-web-angular

2023-01-05 Thread GitBox
dependabot[bot] opened a new pull request, #4544: URL: https://github.com/apache/zeppelin/pull/4544 Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. Release notes Sourced from https://github.com/json5/json5/releases;>json5's releases. v1.0.2 Fix:

[GitHub] [zeppelin] dependabot[bot] closed pull request #4490: Bump jettison from 1.4.0 to 1.5.1

2023-01-02 Thread GitBox
dependabot[bot] closed pull request #4490: Bump jettison from 1.4.0 to 1.5.1 URL: https://github.com/apache/zeppelin/pull/4490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] dependabot[bot] commented on pull request #4490: Bump jettison from 1.4.0 to 1.5.1

2023-01-02 Thread GitBox
dependabot[bot] commented on PR #4490: URL: https://github.com/apache/zeppelin/pull/4490#issuecomment-1369244028 Superseded by #4543. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4543: Bump jettison from 1.4.0 to 1.5.2

2023-01-02 Thread GitBox
dependabot[bot] opened a new pull request, #4543: URL: https://github.com/apache/zeppelin/pull/4543 Bumps [jettison](https://github.com/jettison-json/jettison) from 1.4.0 to 1.5.2. Release notes Sourced from https://github.com/jettison-json/jettison/releases;>jettison's releases.

[GitHub] [zeppelin] Reamer merged pull request #4542: [ZEPPELIN-5873] Update github actions

2023-01-02 Thread GitBox
Reamer merged PR #4542: URL: https://github.com/apache/zeppelin/pull/4542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] Reamer opened a new pull request, #4542: [ZEPPELIN-5873] Update github actions

2023-01-02 Thread GitBox
Reamer opened a new pull request, #4542: URL: https://github.com/apache/zeppelin/pull/4542 ### What is this PR for? This is a trivial PR which updates the CI actions. ### What type of PR is it? - Improvement ### What is the Jira issue? *

[GitHub] [zeppelin] jongyoul commented on pull request #4541: [MINOR] Support aarch for frontend plugin

2023-01-01 Thread GitBox
jongyoul commented on PR #4541: URL: https://github.com/apache/zeppelin/pull/4541#issuecomment-1368420571 @huage1994 Thank you. BTW, it has a dependency issue. It's related to Helium feature because it uses frontend-core to download npm package for custom visualization feature. I think

[GitHub] [zeppelin] huage1994 commented on pull request #4541: [MINOR] Support aarch for frontend plugin

2023-01-01 Thread GitBox
huage1994 commented on PR #4541: URL: https://github.com/apache/zeppelin/pull/4541#issuecomment-1368399071 It looks good to me  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] jongyoul commented on pull request #4541: [MINOR] Support aarch for frontend plugin

2022-12-29 Thread GitBox
jongyoul commented on PR #4541: URL: https://github.com/apache/zeppelin/pull/4541#issuecomment-1367157024 BTW, as mentioned in #4523, The compilation time becomes faster if we use arm jdk in m1 mac -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zeppelin] jongyoul opened a new pull request, #4541: [MINOR] Support aarch for frontend plugin

2022-12-29 Thread GitBox
jongyoul opened a new pull request, #4541: URL: https://github.com/apache/zeppelin/pull/4541 ### What is this PR for? Fixing build error when using aarch jdk for mac OS. our version of node doesn't support amd64 arch but the old plugin tries to download arm version. ### What type

[GitHub] [zeppelin] huage1994 merged pull request #4540: [ZEPPELIN-5869] Remove Incubating from Kyuubi reference

2022-12-28 Thread GitBox
huage1994 merged PR #4540: URL: https://github.com/apache/zeppelin/pull/4540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   3   4   5   6   7   8   9   10   >