[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4545: CI broken
jongyoul commented on code in PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1080757497 ## zeppelin-zengine/pom.xml: ## @@ -304,10 +304,6 @@ - Review Comment: Yeah, this kind of step is too hard to debug by IDE, but, unfortunately, Zeppelin has a bit lot of these types of modification. Hopefully, I would like to reduce/remove them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4545: CI broken
Reamer commented on code in PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1073665797 ## zeppelin-zengine/pom.xml: ## @@ -304,10 +304,6 @@ - Review Comment: It took me a long time to figure out that this execution breaks the Maven build. Until a few hours ago, I thought that this execution was just putting the dependencies under a location. What I didn't know is that this step also adds the dependency to the Maven reactor. This has led to various duplicate libraries within the Maven build, up to and including serious errors. It was hard to debug because the IDE ignores these dependencies. The funny or sad thing, the build step is completely unnecessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4545: CI broken
Reamer commented on code in PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1073656877
##
python/src/test/java/org/apache/zeppelin/python/IPythonInterpreterTest.java:
##
@@ -434,9 +434,6 @@ public void run() {
InterpreterResult result = interpreter.interpret("import
time\ntime.sleep(1000)",
getInterpreterContext());
waiter.assertEquals(InterpreterResult.Code.ERROR, result.code());
- waiter.assertEquals(
- "IPython kernel is abnormally exited, please check your code
and log.",
- result.message().get(0).getData());
Review Comment:
During my tests `result.message()` was always `null`. We can investigate
this later, as this has nothing to do with the issue.
In the summary of https://github.com/apache/zeppelin/actions/runs/3939354095
you can also see several errors which have errors because of this `null`.
The `0` errors indicate the `null` error:
After clicking on the message, the exception is displayed.
If you then look in the affected line, you will see a similar line.
https://github.com/apache/zeppelin/blob/0209d0d0d40e979bd284d89ec3eb6a90a34bf84a/spark/interpreter/src/test/java/org/apache/zeppelin/spark/SparkIRInterpreterTest.java#L110-L128
You should not make assertions within additional threads. See also:
https://rules.sonarsource.com/java/RSPEC-2186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken
Reamer commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1387192701 > I think it's good but I just have one question. Is there any critical reason that we changed `test` to `verify`? It looks similar and `verify` is running after `test` and `package`, and sometimes it uses more time. So I just wonder why `verify` is better than `test` in our cases. You are correct that `verify` comes far after `test` in the Maven lifecycle. This is required to enrich the Maven Reactor with the necessary artefacts (phase `package`). My goal is to remove the `install` step, which usually comes before any `test`. This would then save time again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4545: CI broken
jongyoul commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1387164198 I think it's good but I just have one question. Is there any critical reason that we changed `test` to `verify`? It looks similar and `verify` is running after `test` and `package`, and sometimes it uses more time. So I just wonder why `verify` is better than `test` in our cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken
Reamer commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1385569897 The tests are running through. I will clean up the PR now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer merged pull request #4557: [MINOR] Remove conda cache suffix
Reamer merged PR #4557: URL: https://github.com/apache/zeppelin/pull/4557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] ustas4 commented on pull request #805: ZEPPELIN-580 Add support for multi select in form select box
ustas4 commented on PR #805: URL: https://github.com/apache/zeppelin/pull/805#issuecomment-1384985576 I can't understand for what interpreter that code work. Tested for python 3.8 . Only one record selected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer opened a new pull request, #4557: [MINOR] Remove conda cache suffix
Reamer opened a new pull request, #4557: URL: https://github.com/apache/zeppelin/pull/4557 ### What is this PR for? This PR removes an unnecessary cache suffix ### What type of PR is it? Bug Fix ### How should this be tested? * CI ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`
Reamer commented on code in PR #4556:
URL: https://github.com/apache/zeppelin/pull/4556#discussion_r1071467869
##
.github/workflows/core.yml:
##
@@ -59,7 +59,8 @@ jobs:
!~/.m2/repository/org/apache/zeppelin/
~/.spark-dist
~/.cache
- key: ${{ runner.os }}-zeppelin-${{ hashFiles('**/pom.xml') }}
+~/conda_pkgs_dir
+ key: ${{ runner.os }}-zeppelin-${{ hashFiles('**/pom.xml') }}-${{
hashFiles('testing/env_python_3.7_with_R.yml') }}
Review Comment:
I'm afraid I don't have numbers, do you have numbers?
In order not to confuse others we should remove the suffix again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4543: Bump jettison from 1.4.0 to 1.5.2
jongyoul commented on PR #4543: URL: https://github.com/apache/zeppelin/pull/4543#issuecomment-1383755701 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`
jongyoul commented on PR #4556: URL: https://github.com/apache/zeppelin/pull/4556#issuecomment-1383660284 > Since the shading still creates weird classes, I will continue to work on #4545 . Agreed. It would be great if we could handle all thing this time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`
jongyoul commented on code in PR #4556:
URL: https://github.com/apache/zeppelin/pull/4556#discussion_r1070951485
##
.github/workflows/core.yml:
##
@@ -59,7 +59,8 @@ jobs:
!~/.m2/repository/org/apache/zeppelin/
~/.spark-dist
~/.cache
- key: ${{ runner.os }}-zeppelin-${{ hashFiles('**/pom.xml') }}
+~/conda_pkgs_dir
+ key: ${{ runner.os }}-zeppelin-${{ hashFiles('**/pom.xml') }}-${{
hashFiles('testing/env_python_3.7_with_R.yml') }}
Review Comment:
Oh? really? I didn't check the time carefully but felt like it reduce the
whole time to setup conda but didn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`
jongyoul commented on code in PR #4556:
URL: https://github.com/apache/zeppelin/pull/4556#discussion_r1070950816
##
zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/PooledRemoteClient.java:
##
@@ -44,6 +45,9 @@ public PooledRemoteClient(SupplierWithIO supplier, int
connectionPoolSize) {
GenericObjectPoolConfig poolConfig = new GenericObjectPoolConfig();
poolConfig.setMaxTotal(connectionPoolSize);
poolConfig.setMaxIdle(connectionPoolSize);
+// ZEPPELIN-5875 maven-shade-plugin issue
+//
`org/apache/zeppelin/shaded/org.apache.zeppelin.shaded.org.apache.commons.pool2.impl.DefaultEvictionPolicy`
Review Comment:
Yes, correct. It's a kind of shade configuration issue. We need to change it
but I thought we should make it normal at first. and Then, we could improve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`
Reamer commented on code in PR #4556:
URL: https://github.com/apache/zeppelin/pull/4556#discussion_r1070943224
##
.github/workflows/core.yml:
##
@@ -59,7 +59,8 @@ jobs:
!~/.m2/repository/org/apache/zeppelin/
~/.spark-dist
~/.cache
- key: ${{ runner.os }}-zeppelin-${{ hashFiles('**/pom.xml') }}
+~/conda_pkgs_dir
+ key: ${{ runner.os }}-zeppelin-${{ hashFiles('**/pom.xml') }}-${{
hashFiles('testing/env_python_3.7_with_R.yml') }}
Review Comment:
Why `${{ hashFiles('testing/env_python_3.7_with_R.yml') }}`? We do not have
a conda environment in the CI cache.
##
zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/PooledRemoteClient.java:
##
@@ -44,6 +45,9 @@ public PooledRemoteClient(SupplierWithIO supplier, int
connectionPoolSize) {
GenericObjectPoolConfig poolConfig = new GenericObjectPoolConfig();
poolConfig.setMaxTotal(connectionPoolSize);
poolConfig.setMaxIdle(connectionPoolSize);
+// ZEPPELIN-5875 maven-shade-plugin issue
+//
`org/apache/zeppelin/shaded/org.apache.zeppelin.shaded.org.apache.commons.pool2.impl.DefaultEvictionPolicy`
Review Comment:
I think we still have a shade problem.
`org/apache/zeppelin/shaded/org.apache.zeppelin.shaded.org.apache.commons.pool2.impl.DefaultEvictionPolicy`
does not look like a good class name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] Reamer merged pull request #4553: [ZEPPELIN-5874] polish flink code base
Reamer merged PR #4553: URL: https://github.com/apache/zeppelin/pull/4553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul merged pull request #4554: Bump global-modules-path and webpack-cli in /zeppelin-web
jongyoul merged PR #4554: URL: https://github.com/apache/zeppelin/pull/4554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4554: Bump global-modules-path and webpack-cli in /zeppelin-web
jongyoul commented on PR #4554: URL: https://github.com/apache/zeppelin/pull/4554#issuecomment-1383453291 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul merged pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`
jongyoul merged PR #4556: URL: https://github.com/apache/zeppelin/pull/4556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`
zjffdu commented on PR #4556: URL: https://github.com/apache/zeppelin/pull/4556#issuecomment-1383400648 Thanks @jongyoul -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`
jongyoul commented on PR #4556: URL: https://github.com/apache/zeppelin/pull/4556#issuecomment-1383291254 CI is all green now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`
jongyoul commented on code in PR #4556:
URL: https://github.com/apache/zeppelin/pull/4556#discussion_r1070608092
##
zeppelin-interpreter-parent/pom.xml:
##
@@ -113,6 +113,7 @@
org.apache.maven.plugins
maven-shade-plugin
+false
Review Comment:
It's a bit complicated but let me explain it.
When we install jar, `maven-instll-plugin` tries to install the file under
`/target/*.jar` into `.m2` but our shade script store shaded jars under
`/interpreter/{interpreter.name}` so the file under `/target` directory is an
original file which is not shaded. so `maven-install-plugin` copies the
original file into `.m2` directly as a result. BTW, in case of pom file,
`dependency-reduced-pom` would be copied into `.m2` directory even if the jar
is not shaded. In our old version of shade plugin, the default setting didn't
create `dependency-reduced-pom` when using `outputFile` configuration but in
the latest one, the plugin creates it even if we use `outputFile` setting. So I
disabled creating it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`
jongyoul commented on code in PR #4556:
URL: https://github.com/apache/zeppelin/pull/4556#discussion_r1070608092
##
zeppelin-interpreter-parent/pom.xml:
##
@@ -113,6 +113,7 @@
org.apache.maven.plugins
maven-shade-plugin
+false
Review Comment:
It's a bit complicated but let me explain it.
When we install jar, `maven-instll-plugin` tries to install the file under
`/target/*.jar` into `.m2` but our shade script store shaded jars under
`/interpreter/{interpreter.name}` so the file under `/target` directory is an
original file which is not shaded. so `maven-install-plugin` copies the
original file into `.m2` directly as a result. BTW, in case of pom file,
`dependency-reduced-pom` would be copied into `.m2` directory even if the jar
is not shaded. In our old version of shade plugin, the default setting didn't
create `dependency-reduced-pom` when using `outputFile` configuration but in
the latest one, the plugin creates it even if we use `outputFile` setting. So I
disabled to create it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`
jongyoul commented on code in PR #4556:
URL: https://github.com/apache/zeppelin/pull/4556#discussion_r1070608092
##
zeppelin-interpreter-parent/pom.xml:
##
@@ -113,6 +113,7 @@
org.apache.maven.plugins
maven-shade-plugin
+false
Review Comment:
It's a bit complicated but let me explain it.
When we install jar, `maven-instll-plugin` tries to install the file under
`/target/*.jar` into `.m2` but our shade script store shaded jars under
/interpreter`/{interpreter.name}` so the file under /target directory is an
original file which is not shaded. so maven-install-plugin copy the original
file into .m2 directly as a result. BTW, in case of pom file,
dependency-reduced-pom should be copied into .m2 directory even if the jar is
not shaded. In our old version of shade plugin, the default setting didn't
create dependency-reduced-pom when using `outputFile` configuration but the
latest one, the plugin creates even if we use `outputFile` setting. So I
disabled to create it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`
jongyoul commented on code in PR #4556:
URL: https://github.com/apache/zeppelin/pull/4556#discussion_r1070564606
##
zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/PooledRemoteClient.java:
##
@@ -44,6 +45,7 @@ public PooledRemoteClient(SupplierWithIO supplier, int
connectionPoolSize) {
GenericObjectPoolConfig poolConfig = new GenericObjectPoolConfig();
poolConfig.setMaxTotal(connectionPoolSize);
poolConfig.setMaxIdle(connectionPoolSize);
+
poolConfig.setEvictionPolicyClassName(DefaultEvictionPolicy.class.getName());
Review Comment:
It's similar to the above case. We can add ignore rule for shade as well but
I think it's better to set up the class name explicitly
```
Error: Exception in thread "main" java.lang.IllegalArgumentException: Unable
to create EvictionPolicy instance of type
org/apache/zeppelin/shaded/org.apache.zeppelin.shaded.org.apache.commons.pool2.impl.DefaultEvictionPolicy
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4556: [ZEPPELIN-5875] Fix flaky tests in `core-modules`
jongyoul commented on code in PR #4556: URL: https://github.com/apache/zeppelin/pull/4556#discussion_r1070563685 ## zeppelin-interpreter-shaded/pom.xml: ## @@ -117,6 +117,8 @@ org/w3c/dom/**/* org/xml/sax/* org/xml/sax/**/* + +org/eclipse/sisu/** Review Comment: It's because ``` [INFO] - [ERROR] COMPILATION ERROR : [INFO] - [ERROR] Bad service configuration file, or exception thrown while constructing Processor object: javax.annotation.processing.Processor: jar:file:/Users/jl/Works/Projects/zeppelin/zeppelin-interpreter-shaded/target/zeppelin-interpreter-shaded-0.11.0-SNAPSHOT.jar!/META-INF/services/javax.annotation.processing.Processor:1: Illegal provider-class name: org/apache/zeppelin/shaded/org.apache.zeppelin.shaded.org.eclipse.sisu.space.SisuIndexAPT6 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4555: [MINOR] Disable depeanabot branches for AppVeyor
jongyoul commented on PR #4555: URL: https://github.com/apache/zeppelin/pull/4555#issuecomment-1383111656 Yeah ~ Works fine :-) #4546 https://user-images.githubusercontent.com/3612566/212535157-ba0e83b5-946e-4c94-90e4-2f4446f6777b.png";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4546: Bump ms from 0.7.0 to 2.0.0 in /zeppelin-web
jongyoul commented on PR #4546: URL: https://github.com/apache/zeppelin/pull/4546#issuecomment-1383110971 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul merged pull request #4555: [MINOR] Disable depeanabot branches for AppVeyor
jongyoul merged PR #4555: URL: https://github.com/apache/zeppelin/pull/4555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] raboof commented on a diff in pull request #4549: [MINOR] document 'markdown' display system
raboof commented on code in PR #4549: URL: https://github.com/apache/zeppelin/pull/4549#discussion_r1070548910 ## docs/usage/display_system/basic.md: ## @@ -1,7 +1,7 @@ --- layout: page title: "Basic Display System in Apache Zeppelin" -description: "There are 3 basic display systems in Apache Zeppelin. By default, Zeppelin prints interpreter responce as a plain text using text display system. With %html directive, Zeppelin treats your output as HTML. You can also simply use %table display system to leverage Zeppelin's built in visualization." +description: "There are several display systems available in Apache Zeppelin. By default, Zeppelin prints interpreter responce as a plain text using %text display system. However, display systems for showing HTML, tables, markdown or even graph visualizations are also available." Review Comment: good catch, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4555: [MINOR] Disable depeanabot branches for AppVeyor
jongyoul commented on PR #4555: URL: https://github.com/apache/zeppelin/pull/4555#issuecomment-1383084869 Haha, right. 😁 Let's see how it goes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul opened a new pull request, #4556: [ZEPPELIN-5875] Fix a flaky test in `TimeoutLifecycleManagerTest`
jongyoul opened a new pull request, #4556: URL: https://github.com/apache/zeppelin/pull/4556 ### What is this PR for? Fixing flaky test in `core-modules (hadoop[2|3])`. ### What type of PR is it? Bug Fix ### Todos * [ ] - Fix `testTimeout_2` ### What is the Jira issue? * ZEPPELIN-5875 ### How should this be tested? * All CI should pass ### Screenshots (if appropriate) https://user-images.githubusercontent.com/3612566/212483837-888c0f34-6a16-41b5-b77e-e2a3074aa7ee.png";> ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul opened a new pull request, #4555: [MINOR] Disable depeanabot branches for AppVeyor
jongyoul opened a new pull request, #4555: URL: https://github.com/apache/zeppelin/pull/4555 ### What is this PR for? Disabling to execute AppVeyor jobs for branches for `dependabot`. ### What type of PR is it? Improvement ### Todos * [x] - Add `except` settings for `.appveyor.yml` ### What is the Jira issue? * N/A ### How should this be tested? * Open `dependabot` issue * @dependabot rebase * Check only one appveyor job ### Screenshots (if appropriate) https://user-images.githubusercontent.com/3612566/212478964-25146031-40e0-40ce-9e72-1e8e1626fbc2.png";> ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4552: [MINOR] Fix wrong format for github actions of 'branches-ignore'
jongyoul commented on PR #4552: URL: https://github.com/apache/zeppelin/pull/4552#issuecomment-1382739536 Checked it worked properly on #4554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4554: Bump global-modules-path and webpack-cli in /zeppelin-web
jongyoul commented on PR #4554: URL: https://github.com/apache/zeppelin/pull/4554#issuecomment-1382738392 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul merged pull request #4549: [MINOR] document 'markdown' display system
jongyoul merged PR #4549: URL: https://github.com/apache/zeppelin/pull/4549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul merged pull request #4552: [MINOR] Fix wrong format for github actions of 'branches-ignore'
jongyoul merged PR #4552: URL: https://github.com/apache/zeppelin/pull/4552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4554: Bump global-modules-path and webpack-cli in /zeppelin-web
dependabot[bot] opened a new pull request, #4554: URL: https://github.com/apache/zeppelin/pull/4554 Removes [global-modules-path](https://github.com/rosen-vladimirov/global-modules-path). It's no longer used after updating ancestor dependency [webpack-cli](https://github.com/webpack/webpack-cli). These dependencies need to be updated together. Removes `global-modules-path` Updates `webpack-cli` from 3.1.2 to 3.3.12 Changelog Sourced from https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md";>webpack-cli's changelog. 3.3.12 (2020-06-03) https://github.com/webpack/webpack-cli/compare/v3.3.11...v3.3.12";>Full Changelog 3.3.11 (2020-02-11) https://github.com/webpack/webpack-cli/compare/v3.3.10...v3.3.11";>Full Changelog 3.3.10 (2019-10-31) https://github.com/webpack/webpack-cli/compare/v3.3.9...v3.3.10";>Full Changelog New Features add new flag and patch sec dep (https://github-redirect.dependabot.com/webpack/webpack-cli/pull/1102";>#1102) 3.3.9 (2019-09-17) https://github.com/webpack/webpack-cli/compare/v3.3.8...v3.3.9";>Full Changelog Fix use process.exitCode instead of process.exit in compilerCallback (https://github.com/webpack/webpack-cli/commit/ee001bd";>ee001bd) 3.3.8 (2019-09-05) https://github.com/webpack/webpack-cli/compare/v3.3.7...v3.3.8";>Full Changelog Fix support both webpack versions (https://github.com/webpack/webpack-cli/commit/d28f9f5";>d28f9f5) Tests add schema tests (https://github.com/webpack/webpack-cli/commit/70bf934";>70bf934) 3.3.7 (2019-08-18) https://github.com/webpack/webpack-cli/compare/v3.3.6...v3.3.7";>Full Changelog ... (truncated) Commits https://github.com/webpack/webpack-cli/commit/33574ec82e1f6d8b71e872db086bbfaaf77707ba";>33574ec chore(release): 3.3.12 https://github.com/webpack/webpack-cli/commit/4f1a2f3268480d268c73719986791321d38ac5b3";>4f1a2f3 chore: bump dependencies for v3 (https://github-redirect.dependabot.com/webpack/webpack-cli/issues/1595";>#1595) https://github.com/webpack/webpack-cli/commit/ab910dfe16df71757c6a7de503e5a8d93c38";>ab910df docs(templates): Branding guide violation fix (https://github-redirect.dependabot.com/webpack/webpack-cli/issues/1226";>#1226) https://github.com/webpack/webpack-cli/commit/c9927e35d75828e3e2b71911b3747960d2e73e99";>c9927e3 fix: release stable https://github.com/webpack/webpack-cli/commit/a037dc81285008f069f5c5c8d8c1e736fa36a305";>a037dc8 fix: ci (https://github-redirect.dependabot.com/webpack/webpack-cli/issues/1193";>#1193) https://github.com/webpack/webpack-cli/commit/f9f08604a1ce5272b20d4f942e6861f3dc170dc0";>f9f0860 chore: v3.3.10 https://github.com/webpack/webpack-cli/commit/08a7650a5d9d930e7a7c99a43eb057b90eaefdac";>08a7650 chore: remove un-synced tests https://github.com/webpack/webpack-cli/commit/1208aa69552d2d0dbf49344e7b8ba20aa70e689e";>1208aa6 feat: add new flag and patch sec dep (https://github-redirect.dependabot.com/webpack/webpack-cli/issues/1102";>#1102) https://github.com/webpack/webpack-cli/commit/6ad60997da3624b86b89d6269bb63d48805e616b";>6ad6099 chore: sec patch https://github.com/webpack/webpack-cli/commit/48c03ab4108e1b1eb3a73595deefd744cf65f895";>48c03ab chore: v3.3.9 Additional commits viewable in https://github.com/webpack/webpack-cli/compare/v3.1.2...v3.3.12";>compare view Maintainer changes This version was pushed to npm by https://www.npmjs.com/~evilebottnawi";>evilebottnawi, a new releaser for webpack-cli since your current version. Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or
[GitHub] [zeppelin] Reamer opened a new pull request, #4553: [ZEPPELIN-5874] polish flink code base
Reamer opened a new pull request, #4553: URL: https://github.com/apache/zeppelin/pull/4553 ### What is this PR for? Just a little polish pull request, for classes I passed during #4545. ### What type of PR is it? - Refactoring ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-5874 ### How should this be tested? * CI ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken
Reamer commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1382117894 @zjffdu Do you have any idea how to fix the Flink compilation? I find the setup with the symlink of `flink-scala-parent` very unattractive, this does not seem clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4549: [MINOR] document 'markdown' display system
jongyoul commented on code in PR #4549: URL: https://github.com/apache/zeppelin/pull/4549#discussion_r1069475492 ## docs/usage/display_system/basic.md: ## @@ -1,7 +1,7 @@ --- layout: page title: "Basic Display System in Apache Zeppelin" -description: "There are 3 basic display systems in Apache Zeppelin. By default, Zeppelin prints interpreter responce as a plain text using text display system. With %html directive, Zeppelin treats your output as HTML. You can also simply use %table display system to leverage Zeppelin's built in visualization." +description: "There are several display systems available in Apache Zeppelin. By default, Zeppelin prints interpreter responce as a plain text using %text display system. However, display systems for showing HTML, tables, markdown or even graph visualizations are also available." Review Comment: ```suggestion description: "There are several display systems available in Apache Zeppelin. By default, Zeppelin prints interpreter response as a plain text using %text display system. However, display systems for showing HTML, tables, markdown or even graph visualizations are also available." ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4549: [MINOR] document 'markdown' display system
Reamer commented on code in PR #4549: URL: https://github.com/apache/zeppelin/pull/4549#discussion_r1069465068 ## docs/usage/display_system/basic.md: ## @@ -1,7 +1,7 @@ --- layout: page title: "Basic Display System in Apache Zeppelin" -description: "There are 3 basic display systems in Apache Zeppelin. By default, Zeppelin prints interpreter responce as a plain text using text display system. With %html directive, Zeppelin treats your output as HTML. You can also simply use %table display system to leverage Zeppelin's built in visualization." +description: "There are several display systems available in Apache Zeppelin. By default, Zeppelin prints interpreter responce as a plain text using %text display system. However, display systems for showing HTML, tables, markdown or even graph visualizations are also available." Review Comment: Small typo `responce` -> `response` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul opened a new pull request, #4552: [MINOR] Fix wrong format for github actions of 'branches-ignore'
jongyoul opened a new pull request, #4552: URL: https://github.com/apache/zeppelin/pull/4552 ### What is this PR for? I don't know when I missed it but the syntax was wrong in my lastest PR for github action #4529. It fixes this error referenced by https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushbranchestagsbranches-ignoretags-ignore ### What type of PR is it? Bug Fix ### Todos * [x] - Correct wrong settings ### What is the Jira issue? N/A ### How should this be tested? * Open Dependabot issue * @dependabot rebase * Check how many jobs are created ### Screenshots (if appropriate) https://user-images.githubusercontent.com/3612566/212321858-8a856b7e-7985-4188-a2cd-3bdd9b1776f6.png";> ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul merged pull request #4376: Bump eventsource from 1.0.7 to 1.1.1 in /zeppelin-web-angular
jongyoul merged PR #4376: URL: https://github.com/apache/zeppelin/pull/4376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4377: Bump @angular/core from 8.2.12 to 11.0.5 in /zeppelin-web-angular
jongyoul commented on PR #4377: URL: https://github.com/apache/zeppelin/pull/4377#issuecomment-1381766401 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4461: Bump jszip from 3.2.2 to 3.10.1 in /zeppelin-web-angular
jongyoul commented on PR #4461: URL: https://github.com/apache/zeppelin/pull/4461#issuecomment-1381765614 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4502: Bump socket.io-parser and karma in /zeppelin-web-angular
jongyoul commented on PR #4502: URL: https://github.com/apache/zeppelin/pull/4502#issuecomment-1381765142 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4514: Bump engine.io and karma in /zeppelin-web-angular
jongyoul commented on PR #4514: URL: https://github.com/apache/zeppelin/pull/4514#issuecomment-1381764269 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4533: Bump simple-git and lint-staged in /zeppelin-web-angular
jongyoul commented on PR #4533: URL: https://github.com/apache/zeppelin/pull/4533#issuecomment-1381763409 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4527: Bump decode-uri-component from 0.2.0 to 0.2.2 in /zeppelin-web-angular
jongyoul commented on PR #4527: URL: https://github.com/apache/zeppelin/pull/4527#issuecomment-1381763739 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4539: Bump express from 4.17.1 to 4.18.2 in /zeppelin-web-angular
jongyoul commented on PR #4539: URL: https://github.com/apache/zeppelin/pull/4539#issuecomment-1381762629 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4535: Bump qs from 6.5.2 to 6.5.3 in /zeppelin-web-angular
jongyoul commented on PR #4535: URL: https://github.com/apache/zeppelin/pull/4535#issuecomment-1381763003 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul merged pull request #4544: Bump json5 from 1.0.1 to 1.0.2 in /zeppelin-web-angular
jongyoul merged PR #4544: URL: https://github.com/apache/zeppelin/pull/4544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer merged pull request #4551: [Typo] Correct small typo
Reamer merged PR #4551: URL: https://github.com/apache/zeppelin/pull/4551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4551: [Typo] Correct small typo
jongyoul commented on PR #4551: URL: https://github.com/apache/zeppelin/pull/4551#issuecomment-1381541566 Thank you. Could you please merge it? I'm out so I cannot merge it right now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer opened a new pull request, #4551: [Typo] Correct small typo
Reamer opened a new pull request, #4551: URL: https://github.com/apache/zeppelin/pull/4551 ### What is this PR for? #4550 contains a small typo. ### What type of PR is it? Typo ### How should this be tested? * CI ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4550: [HOTFIX] Github Actions workaround
Reamer commented on PR #4550: URL: https://github.com/apache/zeppelin/pull/4550#issuecomment-1381528776 @jongyoul Great that you have fixed this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul merged pull request #4550: [HOTFIX] Github Actions workaround
jongyoul merged PR #4550: URL: https://github.com/apache/zeppelin/pull/4550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4550: [HOTFIX] Github Actions workaround
jongyoul commented on PR #4550: URL: https://github.com/apache/zeppelin/pull/4550#issuecomment-1381458684 @Reamer @zjffdu @huage1994 Can anyone approve this PR? It needs one approval at least to merge it;; -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4550: [HOTFIX] Github Actions workaround
jongyoul commented on PR #4550: URL: https://github.com/apache/zeppelin/pull/4550#issuecomment-1381457227 The CI returned to the normal status ( there are still two infinite running tasks). I'll merge it as a hotfix. https://user-images.githubusercontent.com/3612566/212270209-06ff47da-d6e7-40bc-9a63-1b712c60c1b1.png";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4545: CI broken
jongyoul commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1381324679 I made #4550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul opened a new pull request, #4550: [HOTFIX] Github Actions workaround
jongyoul opened a new pull request, #4550: URL: https://github.com/apache/zeppelin/pull/4550 ### What is this PR for? Current CI fails everytime. It's already reported conda-incubator/setup-miniconda#274 ### What type of PR is it? Hot Fix ### Todos * [x] - Adopt workaround ### What is the Jira issue? N/A ### How should this be tested? * CI passes ### Screenshots (if appropriate)  ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4545: CI broken
jongyoul commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1381318657 https://github.com/conda-incubator/setup-miniconda/issues/274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4545: CI broken
jongyoul commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1381314053 BTW, I see some different outputs for CI as well. Do you have any idea? https://user-images.githubusercontent.com/3612566/212240504-1def015b-859b-4a97-8c81-ec0a55cffd6f.png";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] raboof opened a new pull request, #4549: [MINOR] document 'markdown' display system
raboof opened a new pull request, #4549: URL: https://github.com/apache/zeppelin/pull/4549 ### What is this PR for? Document that the markdown display system exists ### What type of PR is it? Improvement Documentation ### Todos None ### What is the Jira issue? There is no Jira issue for this improvement ### How should this be tested? You could generate the documentation with this change ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken
Reamer commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1380118193 Spark CI-Jobs seems to be running without errors. https://github.com/apache/zeppelin/actions/runs/3894046270/jobs/6660597445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] 3792274 commented on pull request #1868: [ZEPPELIN-1917] Improve python.conda interpreter
3792274 commented on PR #1868: URL: https://github.com/apache/zeppelin/pull/1868#issuecomment-1379934886 > @3792274 Hello, Could you please make an issue for it? I think it's easier to keep track of the issue. :-) yes you are right ,thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #1868: [ZEPPELIN-1917] Improve python.conda interpreter
jongyoul commented on PR #1868: URL: https://github.com/apache/zeppelin/pull/1868#issuecomment-1379774588 @3792274 Hello, Could you please make an issue for it? I think it's easier to keep track of the issue. :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] 3792274 commented on pull request #1868: [ZEPPELIN-1917] Improve python.conda interpreter
3792274 commented on PR #1868:
URL: https://github.com/apache/zeppelin/pull/1868#issuecomment-1379767545
> ### What is this PR for?
> Add missing commands to the `python.conda` interpreter
>
> * `conda info`
> * `conda list`
> * `conda create`
> * `conda install`
> * `conda uninstall (alias of remove)`
> * `conda env *`
>
> Implementation Detail
> The reason I modified `PythonProcess` is due to NPE
>
> ```java
> //
https://github.com/apache/zeppelin/blob/master/python/src/main/java/org/apache/zeppelin/python/PythonProcess.java#L107-L118
>
>
> public String sendAndGetResult(String cmd) throws IOException {
> writer.println(cmd);
> writer.println();
> writer.println("\"" + STATEMENT_END + "\"");
> StringBuilder output = new StringBuilder();
> String line = null;
>
> // NPE when line is null
> while (!(line = reader.readLine()).contains(STATEMENT_END)) {
> logger.debug("Read line from python shell : " + line);
> output.append(line + "\n");
> }
> return output.toString();
> }
> ```
>
> ```
> java.lang.NullPointerException
> at
org.apache.zeppelin.python.PythonProcess.sendAndGetResult(PythonProcess.java:113)
> at
org.apache.zeppelin.python.PythonInterpreter.sendCommandToPython(PythonInterpreter.java:250)
> at
org.apache.zeppelin.python.PythonInterpreter.bootStrapInterpreter(PythonInterpreter.java:272)
> at
org.apache.zeppelin.python.PythonInterpreter.open(PythonInterpreter.java:100)
> at
org.apache.zeppelin.python.PythonCondaInterpreter.restartPythonProcess(PythonCondaInterpreter.java:139)
> at
org.apache.zeppelin.python.PythonCondaInterpreter.interpret(PythonCondaInterpreter.java:88)
> at
org.apache.zeppelin.interpreter.LazyOpenInterpreter.interpret(LazyOpenInterpreter.java:94)
> at
org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer$InterpretJob.jobRun(RemoteInterpreterServer.java:494)
> at org.apache.zeppelin.scheduler.Job.run(Job.java:175)
> at
org.apache.zeppelin.scheduler.FIFOScheduler$1.run(FIFOScheduler.java:139)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
> at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
> at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> ```
>
> ### What type of PR is it?
> [Improvement | Refactoring]
>
> ### Todos
> * [x] - info
> * [x] - list
> * [x] - create
> * [x] - install
> * [x] - uninstall (= remove)
> * [x] - env *
>
> ### What is the Jira issue?
> [ZEPPELIN-1917](https://issues.apache.org/jira/browse/ZEPPELIN-1917)
>
> ### How should this be tested?
> 1. Install [miniconda](http://conda.pydata.org/miniconda.html)
> 2. Make sure that your python interpreter can use `conda` (check the
Interpreter Binding page)
> 3. Remove `test` conda env since we will create in the following section
>
> ```shell
> $ conda env remove --yes --name test
> ```
>
> 4. Run these commands with `%python.conda`
>
> ```
> %python.conda info
> %python.conda env list
> %python.conda create --name test
>
> # you should be able to see `test` in the list
> %python.conda env list
> %python.conda activate pymysql
> %python.conda install pymysql
>
> # you should be able to import
> %python
> import pymysql.cursors
>
> %python.conda uninstall pymysql
> %python.conda deactivate pymysql
>
> # you should be able to see `No module named pymysql.cursor` since we
deactivated
> %python
> import pymysql.cursors
> ```
>
> ### Screenshots (if appropriate)
>
[
](https://cloud.githubusercontent.com/assets/4968473/21747565/98c0e366-d5ad-11e6-8000-e293996089fa.gif)
[
](https://cloud.githubusercontent.com/assets/4968473/21747565/98c0e366-d5ad-11e6-8000-e293996089fa.gif)
>
> ### Questions:
> * Does the licenses files need update? - NO
> * Is there breaking changes for older versions? - NO
> * Does this needs documentation? - NO
**how to remove the html tag?**
--
This
[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4548: Bump debug, grunt-contrib-watch and grunt-usemin in /zeppelin-web
dependabot[bot] opened a new pull request, #4548: URL: https://github.com/apache/zeppelin/pull/4548 Bumps [debug](https://github.com/debug-js/debug) to 2.6.9 and updates ancestor dependencies [debug](https://github.com/debug-js/debug), [grunt-contrib-watch](https://github.com/gruntjs/grunt-contrib-watch) and [grunt-usemin](https://github.com/yeoman/grunt-usemin). These dependencies need to be updated together. Updates `debug` from 0.7.4 to 2.6.9 Release notes Sourced from https://github.com/debug-js/debug/releases";>debug's releases. 2.6.9 Patches Remove ReDoS regexp in %o formatter: https://github-redirect.dependabot.com/debug-js/debug/issues/504";>#504 Credits Huge thanks to https://github.com/zhuangya";>@zhuangya for their help! release 2.6.7 No release notes provided. release 2.6.6 No release notes provided. release 2.6.5 No release notes provided. release 2.6.4 No release notes provided. release 2.6.3 No release notes provided. release 2.6.2 No release notes provided. release 2.6.1 No release notes provided. release 2.6.0 No release notes provided. release 2.5.2 No release notes provided. release 2.5.1 No release notes provided. release 2.4.5 No release notes provided. release 2.4.4 No release notes provided. release 2.4.3 No release notes provided. release 2.4.2 No release notes provided. ... (truncated) Changelog Sourced from https://github.com/debug-js/debug/blob/2.6.9/CHANGELOG.md";>debug's changelog. 2.6.9 / 2017-09-22 remove ReDoS regexp in %o formatter (https://github-redirect.dependabot.com/debug-js/debug/issues/504";>#504) 2.6.8 / 2017-05-18 Fix: Check for undefined on browser globals (https://github-redirect.dependabot.com/debug-js/debug/issues/462";>#462, https://github.com/marbemac";>@marbemac) 2.6.7 / 2017-05-16 Fix: Update ms to 2.0.0 to fix regular expression denial of service vulnerability (https://github-redirect.dependabot.com/debug-js/debug/issues/458";>#458, https://github.com/hubdotcom";>@hubdotcom) Fix: Inline extend function in node implementation (https://github-redirect.dependabot.com/debug-js/debug/issues/452";>#452, https://github.com/dougwilson";>@dougwilson) Docs: Fix typo (https://github-redirect.dependabot.com/debug-js/debug/issues/455";>#455, https://github.com/msasad";>@msasad) 2.6.5 / 2017-04-27 Fix: null reference check on window.documentElement.style.WebkitAppearance (https://github-redirect.dependabot.com/debug-js/debug/issues/447";>#447, https://github.com/thebigredgeek";>@thebigredgeek) Misc: clean up browser reference checks (https://github-redirect.dependabot.com/debug-js/debug/issues/447";>#447, https://github.com/thebigredgeek";>@thebigredgeek) Misc: add npm-debug.log to .gitignore (https://github.com/thebigredgeek";>@thebigredgeek) 2.6.4 / 2017-04-20 Fix: bug that would occure if process.env.DEBUG is a non-string value. (https://github-redirect.dependabot.com/debug-js/debug/issues/444";>#444, https://github.com/LucianBuzzo";>@LucianBuzzo) Chore: ignore bower.json in npm installations. (https://github-redirect.dependabot.com/debug-js/debug/issues/437";>#437, https://github.com/joaovieira";>@joaovieira) Misc: update "ms" to v0.7.3 (https://github.com/tootallnate";>@tootallnate) 2.6.3 / 2017-03-13 Fix: Electron reference to process.env.DEBUG (https://github-redirect.dependabot.com/debug-js/debug/issues/431";>#431, https://github.com/paulcbetts";>@paulcbetts) Docs: Changelog fix (https://github.com/thebigredgeek";>@thebigredgeek) 2.6.2 / 2017-03-10 Fix: DEBUG_MAX_ARRAY_LENGTH (https://github-redirect.dependabot.com/debug-js/debug/issues/420";>#420, https://github.com/slavaGanzin";>@slavaGanzin) Docs: Add backers and sponsors from Open Collective (https://github-redirect.dependabot.com/debug-js/debug/issues/422";>#422, https://github.com/piamancini";>@piamancini) Docs: Add Slackin invite badge (https://github.com/tootallnate";>@tootallnate) 2.6.1 / 2017-02-10 Fix: Module's export default syntax fix for IE8 Expected identifier error Fix: Whitelist DEBUG_FD for values 1 and 2 only (https://github-redirect.dependabot.com/debug-js/debug/issues/415";>#415, https://github.com/pi0";>@pi0) ... (truncated) Commits https://github.com/debug-js/debug/commit/13abeae468fea297d0dccc50bc55590809241083";>13abeae Release 2.6.9 https://github.com/debug-js/debug/commit/f53962e944a87e6ca9bb622a2a12dffc22a9bb5a";>f53962e remove ReDoS regexp in %o formatter (https://github-redirect.dependabot.com/debug-js/debug/issues/504";>#504) https://github.com/debug-js/debug/commit/52e1f21284322f167839e5d3a60f635c8b2dc842";>52e1f21 Release 2.6.8 https://github.com/debug-js/debug/commit/2482e08e4ef36416154ee27e9a2d60e568
[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken
Reamer commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1378852906 The following error seems to be a maven reactor issue. Running the tests with ` -am -Dtest=org/apache/zeppelin/spark/*` seems to solve the issue (at least on my local machine) ``` 2023-01-06T17:43:32.9579892Z [ERROR] testIPythonProcessKilled Time elapsed: 3.305 s <<< ERROR! 2023-01-06T17:43:32.9588899Z org.apache.zeppelin.interpreter.InterpreterException: java.lang.NoClassDefFoundError: io/grpc/stub/StreamObserver 2023-01-06T17:43:32.9597447Z at org.apache.zeppelin.spark.IPySparkInterpreterTest.startInterpreter(IPySparkInterpreterTest.java:98) 2023-01-06T17:43:32.9604208Z Caused by: java.lang.NoClassDefFoundError: io/grpc/stub/StreamObserver 2023-01-06T17:43:32.9612809Z at org.apache.zeppelin.spark.IPySparkInterpreterTest.startInterpreter(IPySparkInterpreterTest.java:98) 2023-01-06T17:43:32.9619547Z Caused by: java.lang.ClassNotFoundException: io.grpc.stub.StreamObserver 2023-01-06T17:43:32.9627967Z at org.apache.zeppelin.spark.IPySparkInterpreterTest.startInterpreter(IPySparkInterpreterTest.java:98) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4547: fix(sec): upgrade org.codehaus.jettison:jettison to 1.5.1
jongyoul commented on PR #4547: URL: https://github.com/apache/zeppelin/pull/4547#issuecomment-1378537285 Hello, Thank you for the contribution but it's duplicated with #4543. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4546: Bump ms from 0.7.0 to 2.0.0 in /zeppelin-web
dependabot[bot] opened a new pull request, #4546: URL: https://github.com/apache/zeppelin/pull/4546 Bumps [ms](https://github.com/vercel/ms) from 0.7.0 to 2.0.0. Release notes Sourced from https://github.com/vercel/ms/releases";>ms's releases. 2.0.0 Major Changes Limit str to 100 to avoid ReDoS of 0.3s: https://github-redirect.dependabot.com/vercel/ms/issues/89";>#89 Patches Ignored logs coming from npm: b1eaab752203e978492a4d540a7ae1d26e6306b1 Bumped dependencies to the latest version: bcf57157678fd5afc691383145a35e116f9704d0 Invalidated cache for slack badge: 94b995c1d6d5d13ec976a0c6849a3cca9b277e6b Credits Huge thanks to https://github.com/karenyavine";>@karenyavine for their help! 1.0.0 Major Changes Removed component specification: 1fbbe974cdcad96e592dcb65a7b2a8649f690420 Patches Test on LTS version of Node: c9b1fd319f0f9198d85ecf4ba83e46cc1216be04 Removed XO: 94068ea6d518387670df277f740b1abada80ed48 Use prettier and eslint: 57b3ef8e3423cae6254f94c5564a11b4492cff43 Badge for XO removed: 389840b329436117741b2ef13a172725082695b9 Removed browser testing: e818c3581aca3119c00d81901bfe8fe653bcfda4 More suitable name for file containing tests: ee91f307a8dc3581ebdad614ec0533ddb3d8bf56 0.7.3 Patches Mark "options" param as optional in jsdoc: https://github-redirect.dependabot.com/vercel/ms/issues/77";>#77 Lowercased text files: 5f0653ab192a30301aed8668b4588a87975b41ab Pinned dependencies: 126d7f094a1836b991c8d0abfeb4d0ce09ac280f Chore(package): update serve to version 5.0.1: https://github-redirect.dependabot.com/vercel/ms/issues/81";>#81 Credits Huge thanks to https://github.com/Jokero";>@Jokero for their help! 0.7.2 Patches 💅 Added license field to package.json file: https://github-redirect.dependabot.com/zeit/ms/pull/42";>zeit/ms#42 Renamed long and short (reserved keywords): https://github-redirect.dependabot.com/zeit/ms/pull/53";>zeit/ms#53 Capitalized important files: b2d9f9d Specified version numbers for devDependencies in package.json: abd3616 Updated license file to the latest version: 5d53ae8 Only upload important files to npm, instead of excluding certain ones: 2b2f02a Adjusted name of repository in package.json: e84f95d ... (truncated) Commits https://github.com/vercel/ms/commit/9b88d1568a52ec9bb67ecc8d2aa224fa38fd41f4";>9b88d15 2.0.0 https://github.com/vercel/ms/commit/94b995c1d6d5d13ec976a0c6849a3cca9b277e6b";>94b995c Invalidated cache for slack badge https://github.com/vercel/ms/commit/bcf57157678fd5afc691383145a35e116f9704d0";>bcf5715 Bumped dependencies to the latest version https://github.com/vercel/ms/commit/b1eaab752203e978492a4d540a7ae1d26e6306b1";>b1eaab7 Ignored logs coming from npm https://github.com/vercel/ms/commit/caae2988ba2a37765d055c4eee63d383320ee662";>caae298 Limit str to 100 to avoid ReDoS of 0.3s (https://github-redirect.dependabot.com/vercel/ms/issues/89";>#89) https://github.com/vercel/ms/commit/b83b36d7266fb1bd779fd19a2f98bab17a04d999";>b83b36d chore(package): update eslint to version 3.19.0 (https://github-redirect.dependabot.com/vercel/ms/issues/88";>#88) https://github.com/vercel/ms/commit/3f2a4d71eda1b12bd5d625cce6777bd3604e8923";>3f2a4d7 chore(package): update husky to version 0.13.3 (https://github-redirect.dependabot.com/vercel/ms/issues/86";>#86) https://github.com/vercel/ms/commit/7daf984a9011e720cc3c165ed82c4506f3471b37";>7daf984 1.0.0 https://github.com/vercel/ms/commit/ee91f307a8dc3581ebdad614ec0533ddb3d8bf56";>ee91f30 More suitable name for file containing tests https://github.com/vercel/ms/commit/e818c3581aca3119c00d81901bfe8fe653bcfda4";>e818c35 Removed browser testing Additional commits viewable in https://github.com/vercel/ms/compare/0.7.0...2.0.0";>compare view Maintainer changes This version was pushed to npm by https://www.npmjs.com/~leo";>leo, a new releaser for ms since your current version. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merg
[GitHub] [zeppelin] jongyoul merged pull request #4541: [MINOR] Support aarch for frontend plugin
jongyoul merged PR #4541: URL: https://github.com/apache/zeppelin/pull/4541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4545: CI broken
Reamer commented on code in PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1065427653 ## zeppelin-interpreter-shaded/pom.xml: ## @@ -33,7 +33,7 @@ Zeppelin Interpreter Shaded - org.apache.zeppelin.shaded +shaded Review Comment: At the moment there is nothing wrong with your suggested prefix, I have changed this and thank you for your opinion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4541: [MINOR] Support aarch for frontend plugin
jongyoul commented on PR #4541: URL: https://github.com/apache/zeppelin/pull/4541#issuecomment-1376759595 @Reamer The CI becomes back as the previous so it's ok. Could you please recheck it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] pan3793 commented on a diff in pull request #4545: CI broken
pan3793 commented on code in PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1065327386 ## zeppelin-interpreter-shaded/pom.xml: ## @@ -33,7 +33,7 @@ Zeppelin Interpreter Shaded - org.apache.zeppelin.shaded +shaded Review Comment: If there is still an issue with relocating into its own sub-package, I would recommend changing it to `shaded.org.apache.zeppelin` instead of a common `shaded`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul merged pull request #4529: [MINOR] Specify branch names for Github action
jongyoul merged PR #4529: URL: https://github.com/apache/zeppelin/pull/4529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken
Reamer commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1375722112 The next error, which occurs frequently, is as follows. ``` 2023-01-06T17:43:32.9579892Z [ERROR] testIPythonProcessKilled Time elapsed: 3.305 s <<< ERROR! 2023-01-06T17:43:32.9588899Z org.apache.zeppelin.interpreter.InterpreterException: java.lang.NoClassDefFoundError: io/grpc/stub/StreamObserver 2023-01-06T17:43:32.9597447Z at org.apache.zeppelin.spark.IPySparkInterpreterTest.startInterpreter(IPySparkInterpreterTest.java:98) 2023-01-06T17:43:32.9604208Z Caused by: java.lang.NoClassDefFoundError: io/grpc/stub/StreamObserver 2023-01-06T17:43:32.9612809Z at org.apache.zeppelin.spark.IPySparkInterpreterTest.startInterpreter(IPySparkInterpreterTest.java:98) 2023-01-06T17:43:32.9619547Z Caused by: java.lang.ClassNotFoundException: io.grpc.stub.StreamObserver 2023-01-06T17:43:32.9627967Z at org.apache.zeppelin.spark.IPySparkInterpreterTest.startInterpreter(IPySparkInterpreterTest.java:98) ``` We find the class `io/grpc/stub/StreamObserver` as a dependency in `zeppelin-jupyter-interpreter`. https://github.com/apache/zeppelin/blob/deb7f3b1c4c4a1b82ef85e59a327f7c8ad6f4714/zeppelin-jupyter-interpreter/pom.xml#L65-L69 `zeppelin-jupyter-interpreter` is a compile dependency of the `spark-interpreter` https://github.com/apache/zeppelin/blob/deb7f3b1c4c4a1b82ef85e59a327f7c8ad6f4714/spark/interpreter/pom.xml#L105-L119 At the moment I don't know where the problem is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] kriegaex commented on a diff in pull request #4545: CI broken
kriegaex commented on code in PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1064453968 ## zeppelin-interpreter-shaded/pom.xml: ## @@ -33,7 +33,7 @@ Zeppelin Interpreter Shaded - org.apache.zeppelin.shaded +shaded Review Comment: I agree with @Reamer that this config snippet is unrelated to the two Maven Shade issues mentioned in his comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4545: CI broken
Reamer commented on code in PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1064361473 ## zeppelin-interpreter-shaded/pom.xml: ## @@ -33,7 +33,7 @@ Zeppelin Interpreter Shaded - org.apache.zeppelin.shaded +shaded Review Comment: > is it necessary? I believe it was fixed in 3.3.0 by [MSHADE-252](https://issues.apache.org/jira/browse/MSHADE-252) I can't understand what [MSHADE-252](https://issues.apache.org/jira/browse/MSHADE-252) has to do with relocation of classes. In [MSHADE-252](https://issues.apache.org/jira/browse/MSHADE-252) it is about the correct generation of Java source files. There was even another issue [MSHADE-396](https://issues.apache.org/jira/browse/MSHADE-396) which I opened and closed with the help of @kriegaex. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] pan3793 commented on a diff in pull request #4545: CI broken
pan3793 commented on code in PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1064020760 ## zeppelin-interpreter-shaded/pom.xml: ## @@ -33,7 +33,7 @@ Zeppelin Interpreter Shaded - org.apache.zeppelin.shaded +shaded Review Comment: is it necessary? I believe it was fixed in 3.3.0 by [MSHADE-252](https://issues.apache.org/jira/browse/MSHADE-252) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4545: CI broken
jongyoul commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1374327740 Oh.. Interesting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4541: [MINOR] Support aarch for frontend plugin
jongyoul commented on PR #4541: URL: https://github.com/apache/zeppelin/pull/4541#issuecomment-1374326089 Thank you for the description. I also checked it and found the latest version is supporting that way. In our current version, the plugin tries to add suffix for arm64 to download proper node binary but in the latest version, it checks if the our node version is below 16 or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken
Reamer commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1373918746 Next error ´´´ Error: Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.2.2:shade (default) on project zeppelin-jupyter-interpreter-shaded: Error creating shaded jar: duplicate entry: META-INF/services/org.apache.zeppelin.jupyter.io.grpc.NameResolverProvider -> [Help 1] Error: Error: To see the full stack trace of the errors, re-run Maven with the -e switch. Error: Re-run Maven using the -X switch to enable full debug logging. Error: Error: For more information about the errors and possible solutions, please read the following articles: Error: [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException Error: Error: After correcting the problems, you can resume the build with the command Error:mvn -rf :zeppelin-jupyter-interpreter-shaded Error: Process completed with exit code 1. ``` Looks like the following issue [MSHADE-425](https://issues.apache.org/jira/browse/MSHADE-425) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken
Reamer commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1373780697 ``` Caused by: java.lang.ClassNotFoundException: org/apache/zeppelin/shaded/org.apache.zeppelin.shaded.org.apache.commons.pool2.impl.DefaultEvictionPolicy ``` looks like a shading issue. I was doing a little reading about shading and came across the following comment. Therefore the shading prefix change. > Please avoid shading a package into a subpackage of its own like com.fake to com.fake.shaded. You could potentially be getting some kind of recursive problem and depending on the algorithm used for replacing package and path names you could be lucky and it works or not. In your case it works for binaries because Maven Shade uses an ASM utility class for relocating binaries, which seems to do a good job. https://issues.apache.org/jira/browse/MSHADE-252?focusedCommentId=17314377&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17314377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken
Reamer commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1373762162 Found the following error inside log. Therefore I created [ZEPPELIN-5861](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-5861) ``` 2023-01-06T14:50:16.2093997Z [INFO] Interpreter launch command: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/8.0.352-8/x64/bin/java -Dfile.encoding=UTF-8 -Dlog4j.configuration=file:///home/runner/work/zeppelin/zeppelin/conf/log4j.properties -Dlog4j.configurationFile=file:///home/runner/work/zeppelin/zeppelin/conf/log4j2.properties -Dzeppelin.log.file=/home/runner/work/zeppelin/zeppelin/logs/zeppelin-interpreter-test-shared_process--fv-az335-610.log -Xmx1024m -cp :/home/runner/work/zeppelin/zeppelin/zeppelin-zengine/../local-repo/test/*:/home/runner/work/zeppelin/zeppelin/zeppelin-zengine/../interpreter_RemoteAngularObjectTest/test/*:/home/runner/work/zeppelin/zeppelin/zeppelin-interpreter-shaded/target/*:/home/runner/work/zeppelin/zeppelin/zeppelin-zengine/target/test-classes/*:::/home/runner/work/zeppelin/zeppelin/interpreter/zeppelin-interpreter-shaded-0.11.0-SNAPSHOT.jar:/home/runner/work/zeppelin/zeppelin/zeppelin-interpreter/target/classes:/home/runner/work/zeppelin/zeppelin /zeppelin-zengine/target/test-classes org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer 127.0.0.1 42277 test-shared_process : 2023-01-06T14:50:16.2095863Z 2023-01-06T14:50:16.2096005Z --- 2023-01-06T14:50:16.2096480Z at org.apache.zeppelin.interpreter.remote.RemoteAngularObjectTest.setUp(RemoteAngularObjectTest.java:72) 2023-01-06T14:50:16.2096958Z Caused by: java.io.IOException: 2023-01-06T14:50:16.2097229Z Fail to launch interpreter process: 2023-01-06T14:50:16.2097501Z --- 2023-01-06T14:50:16.2100576Z Interpreter download command: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/8.0.352-8/x64/bin/java -Dfile.encoding=UTF-8 -Dlog4j.configuration=file:///home/runner/work/zeppelin/zeppelin/conf/log4j.properties -Dlog4j.configurationFile=file:///home/runner/work/zeppelin/zeppelin/conf/log4j2.properties -Dzeppelin.log.file=/home/runner/work/zeppelin/zeppelin/logs/zeppelin-interpreter-test-shared_process--fv-az335-610.log -cp :/home/runner/work/zeppelin/zeppelin/zeppelin-zengine/../interpreter_RemoteAngularObjectTest/test/*:/home/runner/work/zeppelin/zeppelin/zeppelin-interpreter-shaded/target/*:/home/runner/work/zeppelin/zeppelin/zeppelin-zengine/target/test-classes/*:::/home/runner/work/zeppelin/zeppelin/interpreter/zeppelin-interpreter-shaded-0.11.0-SNAPSHOT.jar:/home/runner/work/zeppelin/zeppelin/zeppelin-interpreter/target/classes:/home/runner/work/zeppelin/zeppelin/zeppelin-zengine/target/test-classes org.apache.zeppelin.interpreter.remote.RemoteInterp reterDownloader 127.0.0.1 42277 test /home/runner/work/zeppelin/zeppelin/zeppelin-zengine/../local-repo/test 2023-01-06T14:50:16.2113231Z ##[error]Exception in thread "main" java.lang.IllegalArgumentException: Unable to create EvictionPolicy instance of type org/apache/zeppelin/shaded/org.apache.zeppelin.shaded.org.apache.commons.pool2.impl.DefaultEvictionPolicy 2023-01-06T14:50:16.2114631Z at org.apache.zeppelin.shaded.org.apache.commons.pool2.impl.BaseGenericObjectPool.setEvictionPolicyClassName(BaseGenericObjectPool.java:607) 2023-01-06T14:50:16.2115551Z at org.apache.zeppelin.shaded.org.apache.commons.pool2.impl.GenericObjectPool.setConfig(GenericObjectPool.java:321) 2023-01-06T14:50:16.2116321Z at org.apache.zeppelin.shaded.org.apache.commons.pool2.impl.GenericObjectPool.(GenericObjectPool.java:117) 2023-01-06T14:50:16.2116986Z at org.apache.zeppelin.interpreter.remote.PooledRemoteClient.(PooledRemoteClient.java:47) 2023-01-06T14:50:16.2117647Z at org.apache.zeppelin.interpreter.remote.RemoteInterpreterEventClient.(RemoteInterpreterEventClient.java:67) 2023-01-06T14:50:16.2118381Z at org.apache.zeppelin.interpreter.remote.RemoteInterpreterDownloader.main(RemoteInterpreterDownloader.java:58) 2023-01-06T14:50:16.2119172Z Caused by: java.lang.ClassNotFoundException: org/apache/zeppelin/shaded/org.apache.zeppelin.shaded.org.apache.commons.pool2.impl.DefaultEvictionPolicy 2023-01-06T14:50:16.2119735Z at java.lang.Class.forName0(Native Method) 2023-01-06T14:50:16.2120042Z at java.lang.Class.forName(Class.java:348) 2023-01-06T14:50:16.2120715Z at org.apache.zeppelin.shaded.org.apache.commons.pool2.impl.BaseGenericObjectPool.setEvictionPolicyClassName(BaseGenericObjectPool.java:598) 2023-01-06T14:50:16.2121304Z ... 5 more ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please
[GitHub] [zeppelin] Reamer opened a new pull request, #4545: CI broken
Reamer opened a new pull request, #4545: URL: https://github.com/apache/zeppelin/pull/4545 ### What is this PR for? At the moment the CI is broken. This PullRequest is intended to be a common basis to fix the error quickly. ### What type of PR is it? Bug Fix ### Todos * [ ] - Fix CI ### How should this be tested? * via current CI ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] pan3793 commented on pull request #4541: [MINOR] Support aarch for frontend plugin
pan3793 commented on PR #4541: URL: https://github.com/apache/zeppelin/pull/4541#issuecomment-1373491658 I roughly remember that NodeJS officially supported Apple Silicon in v16(actually in v15, but it's not an LTS, and was EOL), and eventually, they decided to port this feature to v14 but does not publish the binary artifacts. So I suppose upgrading NodeJS v16 is necessary. Sorry I can not take this because I don't have much knowledge in frontend stacks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4544: Bump json5 from 1.0.1 to 1.0.2 in /zeppelin-web-angular
dependabot[bot] opened a new pull request, #4544: URL: https://github.com/apache/zeppelin/pull/4544 Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. Release notes Sourced from https://github.com/json5/json5/releases";>json5's releases. v1.0.2 Fix: Properties with the name __proto__ are added to objects and arrays. (https://github-redirect.dependabot.com/json5/json5/issues/199";>#199) This also fixes a prototype pollution vulnerability reported by Jonathan Gregson! (https://github-redirect.dependabot.com/json5/json5/issues/295";>#295). This has been backported to v1. (https://github-redirect.dependabot.com/json5/json5/issues/298";>#298) Changelog Sourced from https://github.com/json5/json5/blob/main/CHANGELOG.md";>json5's changelog. Unreleased [https://github.com/json5/json5/tree/main";>code, https://github.com/json5/json5/compare/v2.2.3...HEAD";>diff] v2.2.3 [https://github.com/json5/json5/tree/v2.2.3";>code, https://github.com/json5/json5/compare/v2.2.2...v2.2.3";>diff] Fix: json5@2.2.3 is now the 'latest' release according to npm instead of v1.0.2. (https://github-redirect.dependabot.com/json5/json5/issues/299";>#299) v2.2.2 [https://github.com/json5/json5/tree/v2.2.2";>code, https://github.com/json5/json5/compare/v2.2.1...v2.2.2";>diff] Fix: Properties with the name __proto__ are added to objects and arrays. (https://github-redirect.dependabot.com/json5/json5/issues/199";>#199) This also fixes a prototype pollution vulnerability reported by Jonathan Gregson! (https://github-redirect.dependabot.com/json5/json5/issues/295";>#295). v2.2.1 [https://github.com/json5/json5/tree/v2.2.1";>code, https://github.com/json5/json5/compare/v2.2.0...v2.2.1";>diff] Fix: Removed dependence on minimist to patch CVE-2021-44906. (https://github-redirect.dependabot.com/json5/json5/issues/266";>#266) v2.2.0 [https://github.com/json5/json5/tree/v2.2.0";>code, https://github.com/json5/json5/compare/v2.1.3...v2.2.0";>diff] New: Accurate and documented TypeScript declarations are now included. There is no need to install @types/json5. (https://github-redirect.dependabot.com/json5/json5/issues/236";>#236, https://github-redirect.dependabot.com/json5/json5/issues/244";>#244) v2.1.3 [https://github.com/json5/json5/tree/v2.1.3";>code, https://github.com/json5/json5/compare/v2.1.2...v2.1.3";>diff] Fix: An out of memory bug when parsing numbers has been fixed. (https://github-redirect.dependabot.com/json5/json5/issues/228";>#228, https://github-redirect.dependabot.com/json5/json5/issues/229";>#229) v2.1.2 [https://github.com/json5/json5/tree/v2.1.2";>code, https://github.com/json5/json5/compare/v2.1.1...v2.1.2";>diff] ... (truncated) Commits https://github.com/json5/json5/commit/a62db1e51e1031d92ac260f5bb38bbed1fdbc754";>a62db1e 1.0.2 https://github.com/json5/json5/commit/e0c23fe458a77c0b2cdb271376be5d8d0908133c";>e0c23fe docs: update CHANGELOG for v1.0.2 https://github.com/json5/json5/commit/62a65408408d40aeea14c7869ed327acead12972";>62a6540 fix: add proto to objects and arrays See full diff in https://github.com/json5/json5/compare/v1.0.1...v1.0.2";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to i
[GitHub] [zeppelin] dependabot[bot] closed pull request #4490: Bump jettison from 1.4.0 to 1.5.1
dependabot[bot] closed pull request #4490: Bump jettison from 1.4.0 to 1.5.1 URL: https://github.com/apache/zeppelin/pull/4490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] dependabot[bot] commented on pull request #4490: Bump jettison from 1.4.0 to 1.5.1
dependabot[bot] commented on PR #4490: URL: https://github.com/apache/zeppelin/pull/4490#issuecomment-1369244028 Superseded by #4543. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4543: Bump jettison from 1.4.0 to 1.5.2
dependabot[bot] opened a new pull request, #4543: URL: https://github.com/apache/zeppelin/pull/4543 Bumps [jettison](https://github.com/jettison-json/jettison) from 1.4.0 to 1.5.2. Release notes Sourced from https://github.com/jettison-json/jettison/releases";>jettison's releases. Jettison 1.5.2 What's Changed Bump woodstox-core from 6.2.8 to 6.4.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/jettison-json/jettison/pull/51";>jettison-json/jettison#51 Fixing StackOverflow error by https://github.com/coheigea";>@coheigea in https://github-redirect.dependabot.com/jettison-json/jettison/pull/53";>jettison-json/jettison#53 Full Changelog: https://github.com/jettison-json/jettison/compare/jettison-1.5.1...jettison-1.5.2";>https://github.com/jettison-json/jettison/compare/jettison-1.5.1...jettison-1.5.2 Jettison 1.5.1 What's Changed Stack Overflow fix on malformed JSON by https://github.com/coheigea";>@coheigea in https://github-redirect.dependabot.com/jettison-json/jettison/pull/48";>jettison-json/jettison#48 Prevent infinite loop when a /* comment is not terminated by https://github.com/coheigea";>@coheigea in https://github-redirect.dependabot.com/jettison-json/jettison/pull/49";>jettison-json/jettison#49 Full Changelog: https://github.com/jettison-json/jettison/compare/jettison-1.5.0...jettison-1.5.1";>https://github.com/jettison-json/jettison/compare/jettison-1.5.0...jettison-1.5.1 Commits https://github.com/jettison-json/jettison/commit/6dc73a07ac47c7e3b4c7d041761fbc11aee2eb50";>6dc73a0 [maven-release-plugin] prepare release jettison-1.5.2 https://github.com/jettison-json/jettison/commit/19ae19ff57d00dbfa6f6c3af4fc4cb14fb5ca2df";>19ae19f Fixing StackOverflow error https://github.com/jettison-json/jettison/commit/325b51b36982b5ddfb10d76d2809ec422e9de0b1";>325b51b Bump woodstox-core from 6.2.8 to 6.4.0 https://github.com/jettison-json/jettison/commit/81d3786242c3c7f68eead911b432a81c7f24fa0b";>81d3786 [maven-release-plugin] prepare for next development iteration https://github.com/jettison-json/jettison/commit/bdb3982aaea184c2143e41981e33877c2fd66292";>bdb3982 [maven-release-plugin] prepare release jettison-1.5.1 https://github.com/jettison-json/jettison/commit/1268b7558bad9b989687009a094466b64d4da533";>1268b75 Prevent infinite loop when a /* comment is not terminated https://github.com/jettison-json/jettison/commit/cff9f2814ec8ae573e38f38abed039311bb7bfda";>cff9f28 Create codeql-analysis.yml https://github.com/jettison-json/jettison/commit/395f8625bcf688743872c8e7f59360d372e77811";>395f862 Stack Overflow fix on malformed JSON https://github.com/jettison-json/jettison/commit/a5d2223bafd4c5ec37723533fa5c4066ead4eaaa";>a5d2223 [maven-release-plugin] prepare for next development iteration https://github.com/jettison-json/jettison/commit/e1bf5293d10af3ebfcd8763eb51a20a659b9047c";>e1bf529 [maven-release-plugin] prepare release jettison-1.5.0 Additional commits viewable in https://github.com/jettison-json/jettison/compare/jettison-1.4.0...jettison-1.5.2";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating a
[GitHub] [zeppelin] Reamer merged pull request #4542: [ZEPPELIN-5873] Update github actions
Reamer merged PR #4542: URL: https://github.com/apache/zeppelin/pull/4542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer opened a new pull request, #4542: [ZEPPELIN-5873] Update github actions
Reamer opened a new pull request, #4542: URL: https://github.com/apache/zeppelin/pull/4542 ### What is this PR for? This is a trivial PR which updates the CI actions. ### What type of PR is it? - Improvement ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-5873 ### How should this be tested? * With current CI ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4541: [MINOR] Support aarch for frontend plugin
jongyoul commented on PR #4541: URL: https://github.com/apache/zeppelin/pull/4541#issuecomment-1368420571 @huage1994 Thank you. BTW, it has a dependency issue. It's related to Helium feature because it uses frontend-core to download npm package for custom visualization feature. I think we'd better reinvent the Helium with minimum but it's a problem anyway. I'll fix it and let you know. Please review it again after fixing the issue. ``` Dependency convergence error for com.fasterxml.jackson.core:jackson-core:2.13.0 paths to dependency are: +-org.apache.zeppelin:zeppelin-interpreter-integration:0.11.0-SNAPSHOT +-org.apache.zeppelin:zeppelin-zengine:0.11.0-SNAPSHOT +-com.github.eirslett:frontend-plugin-core:1.12.1 +-com.fasterxml.jackson.core:jackson-core:2.13.0 and +-org.apache.zeppelin:zeppelin-interpreter-integration:0.11.0-SNAPSHOT +-org.apache.zeppelin:zeppelin-server:0.11.0-SNAPSHOT +-com.fasterxml.jackson.core:jackson-databind:2.12.6.1 +-com.fasterxml.jackson.core:jackson-core:2.12.6 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] huage1994 commented on pull request #4541: [MINOR] Support aarch for frontend plugin
huage1994 commented on PR #4541: URL: https://github.com/apache/zeppelin/pull/4541#issuecomment-1368399071 It looks good to me 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4541: [MINOR] Support aarch for frontend plugin
jongyoul commented on PR #4541: URL: https://github.com/apache/zeppelin/pull/4541#issuecomment-1367157024 BTW, as mentioned in #4523, The compilation time becomes faster if we use arm jdk in m1 mac -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul opened a new pull request, #4541: [MINOR] Support aarch for frontend plugin
jongyoul opened a new pull request, #4541: URL: https://github.com/apache/zeppelin/pull/4541 ### What is this PR for? Fixing build error when using aarch jdk for mac OS. our version of node doesn't support amd64 arch but the old plugin tries to download arm version. ### What type of PR is it? Bug Fix ### Todos * [x] - Update `frontend-maven-plugin` ### What is the Jira issue? N/A ### How should this be tested? * Pass to build with arm jdk in macOS ### Screenshots (if appropriate) https://user-images.githubusercontent.com/3612566/209925519-a52c9d0a-289c-48a9-91b9-0837687736c6.png";> ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] huage1994 merged pull request #4540: [ZEPPELIN-5869] Remove Incubating from Kyuubi reference
huage1994 merged PR #4540: URL: https://github.com/apache/zeppelin/pull/4540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
