[jira] [Commented] (ZOOKEEPER-1172) Support for custom org.apache.zookeeper.client.HostProvider implementation.

2011-10-20 Thread Gunnar Wagenknecht (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131408#comment-13131408 ] Gunnar Wagenknecht commented on ZOOKEEPER-1172: --- Some feedback on that

[jira] [Updated] (ZOOKEEPER-1198) Refactorings and Cleanups

2011-10-20 Thread Thomas Koch (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch updated ZOOKEEPER-1198: --- Attachment: ZOOKEEPER-1198.patch Refactorings and Cleanups

[jira] [Updated] (ZOOKEEPER-1216) Fix more eclipse compiler warnings, also in Tests

2011-10-20 Thread Thomas Koch (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch updated ZOOKEEPER-1216: --- Attachment: ZOOKEEPER-1216.patch Sure I can update the patch. No problem with GIT. :-)

[jira] [Updated] (ZOOKEEPER-1221) Provide accessors for Request.{hdr|txn}

2011-10-20 Thread Thomas Koch (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch updated ZOOKEEPER-1221: --- Attachment: ZOOKEEPER-1221.patch Provide accessors for Request.{hdr|txn}

[jira] [Commented] (ZOOKEEPER-1221) Provide accessors for Request.{hdr|txn}

2011-10-20 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131444#comment-13131444 ] Hadoop QA commented on ZOOKEEPER-1221: -- -1 overall. Here are the results of

Failed: ZOOKEEPER-1198 PreCommit Build #633

2011-10-20 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1198 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/633/ ### ## LAST 60 LINES OF THE CONSOLE ###

[jira] [Commented] (ZOOKEEPER-1198) Refactorings and Cleanups

2011-10-20 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131446#comment-13131446 ] Hadoop QA commented on ZOOKEEPER-1198: -- -1 overall. Here are the results of

Success: ZOOKEEPER-1216 PreCommit Build #634

2011-10-20 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1216 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/634/ ### ## LAST 60 LINES OF THE CONSOLE ###

Failed: ZOOKEEPER-1221 PreCommit Build #635

2011-10-20 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1221 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/635/ ### ## LAST 60 LINES OF THE CONSOLE ###

[jira] [Commented] (ZOOKEEPER-1216) Fix more eclipse compiler warnings, also in Tests

2011-10-20 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131447#comment-13131447 ] Hadoop QA commented on ZOOKEEPER-1216: -- +1 overall. Here are the results of

[jira] [Commented] (ZOOKEEPER-1193) Remove upgrade code

2011-10-20 Thread Thomas Koch (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131454#comment-13131454 ] Thomas Koch commented on ZOOKEEPER-1193: I've tried to understand the forrest

[jira] [Updated] (ZOOKEEPER-1198) Refactorings and Cleanups

2011-10-20 Thread Thomas Koch (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch updated ZOOKEEPER-1198: --- Attachment: ZOOKEEPER-1198.patch Refactorings and Cleanups

Failed: ZOOKEEPER-1198 PreCommit Build #636

2011-10-20 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1198 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/636/ ### ## LAST 60 LINES OF THE CONSOLE ###

[jira] [Updated] (ZOOKEEPER-1221) Provide accessors for Request.{hdr|txn}

2011-10-20 Thread Thomas Koch (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch updated ZOOKEEPER-1221: --- Attachment: ZOOKEEPER-1221.patch Provide accessors for Request.{hdr|txn}

[jira] [Commented] (ZOOKEEPER-1198) Refactorings and Cleanups

2011-10-20 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131473#comment-13131473 ] Hadoop QA commented on ZOOKEEPER-1198: -- -1 overall. Here are the results of

[jira] [Commented] (ZOOKEEPER-1221) Provide accessors for Request.{hdr|txn}

2011-10-20 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131490#comment-13131490 ] Hadoop QA commented on ZOOKEEPER-1221: -- +1 overall. Here are the results of

[jira] [Updated] (ZOOKEEPER-1198) Refactorings and Cleanups

2011-10-20 Thread Thomas Koch (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch updated ZOOKEEPER-1198: --- Attachment: (was: ZOOKEEPER-1198.patch) Refactorings and Cleanups

[jira] [Updated] (ZOOKEEPER-1198) Refactorings and Cleanups

2011-10-20 Thread Thomas Koch (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch updated ZOOKEEPER-1198: --- Attachment: ZOOKEEPER-1198.patch Refactorings and Cleanups

[jira] [Updated] (ZOOKEEPER-1198) Refactorings and Cleanups

2011-10-20 Thread Thomas Koch (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch updated ZOOKEEPER-1198: --- Attachment: (was: ZOOKEEPER-1198.patch) Refactorings and Cleanups

[jira] [Updated] (ZOOKEEPER-1198) Refactorings and Cleanups

2011-10-20 Thread Thomas Koch (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch updated ZOOKEEPER-1198: --- Attachment: (was: ZOOKEEPER-1198.patch) Refactorings and Cleanups

[jira] [Commented] (ZOOKEEPER-1198) Refactorings and Cleanups

2011-10-20 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131503#comment-13131503 ] Hadoop QA commented on ZOOKEEPER-1198: -- -1 overall. Here are the results of

Failed: ZOOKEEPER-1198 PreCommit Build #638

2011-10-20 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1198 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/638/ ### ## LAST 60 LINES OF THE CONSOLE ###

Re: Review Request: ZOOKEEPER-1177: Optimzations for memory and locking in the WatchManager

2011-10-20 Thread fpj
On 2011-10-19 23:45:06, Vikas Mehta wrote: /src/java/main/org/apache/zookeeper/server/WatchManager.java, line 124 https://reviews.apache.org/r/2399/diff/1/?file=50634#file50634line124 freePathIds is mainly to remember holes in the allocated pathIds using the pathIdSeq. For this

[jira] [Updated] (ZOOKEEPER-1198) Refactorings and Cleanups

2011-10-20 Thread Thomas Koch (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch updated ZOOKEEPER-1198: --- Attachment: ZOOKEEPER-1198.patch Refactorings and Cleanups

Failed: ZOOKEEPER-1198 PreCommit Build #639

2011-10-20 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1198 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/639/ ### ## LAST 60 LINES OF THE CONSOLE ###

[jira] [Commented] (ZOOKEEPER-1198) Refactorings and Cleanups

2011-10-20 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131550#comment-13131550 ] Hadoop QA commented on ZOOKEEPER-1198: -- -1 overall. Here are the results of

Why does multi-op check operation increment zxid?

2011-10-20 Thread Thomas Koch
Hi, I'm woundering: The check operation is threaded like a write operation in PrepRequestProcessor. It gets a TxnHeader attached and increments the zxid. However the switch cases in ObserverRequestProcessor, CommitProcessor, FollowerRequestProcessor and ReadOnlyRequestProcessor thread a check

Re: Why does multi-op check operation increment zxid?

2011-10-20 Thread Ted Dunning
Both of these sound like bugs. Sent from my iPhone On Oct 20, 2011, at 6:44, Thomas Koch tho...@koch.ro wrote: Hi, I'm woundering: The check operation is threaded like a write operation in PrepRequestProcessor. It gets a TxnHeader attached and increments the zxid. However the switch

Re: Why does multi-op check operation increment zxid?

2011-10-20 Thread Thomas Koch
Ted Dunning: Both of these sound like bugs. Thank you for the quick reply. BTW: I found this out while converting ZooDefs.OpCode to an Enum. I'd be glad, if somebody would have a (longer) comment to my mail: Enum too slow? Using an enum for the OpCode I can really do some very nice cleanups.

[jira] [Updated] (ZOOKEEPER-1198) Refactorings and Cleanups

2011-10-20 Thread Thomas Koch (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch updated ZOOKEEPER-1198: --- Attachment: ZOOKEEPER-1198.patch Refactorings and Cleanups

Failed: ZOOKEEPER-1198 PreCommit Build #640

2011-10-20 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1198 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/640/ ### ## LAST 60 LINES OF THE CONSOLE ###

[jira] [Created] (ZOOKEEPER-1236) Security uses proprietary Sun APIs

2011-10-20 Thread Patrick Hunt (Created) (JIRA)
Security uses proprietary Sun APIs -- Key: ZOOKEEPER-1236 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1236 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.4.0

[jira] [Assigned] (ZOOKEEPER-1236) Security uses proprietary Sun APIs

2011-10-20 Thread Patrick Hunt (Assigned) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt reassigned ZOOKEEPER-1236: --- Assignee: Eugene Koontz Eugene - could you take a look at resolving this?

Re: Why does multi-op check operation increment zxid?

2011-10-20 Thread Marshall McMullen
I agree with Ted, these are both definitely bugs. On Thu, Oct 20, 2011 at 6:52 AM, Ted Dunning ted.dunn...@gmail.com wrote: Both of these sound like bugs. Sent from my iPhone On Oct 20, 2011, at 6:44, Thomas Koch tho...@koch.ro wrote: Hi, I'm woundering: The check operation is

[jira] [Commented] (ZOOKEEPER-1216) Fix more eclipse compiler warnings, also in Tests

2011-10-20 Thread Patrick Hunt (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131718#comment-13131718 ] Patrick Hunt commented on ZOOKEEPER-1216: - You're preaching to the choir dude.

[jira] [Commented] (ZOOKEEPER-1193) Remove upgrade code

2011-10-20 Thread Patrick Hunt (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131721#comment-13131721 ] Patrick Hunt commented on ZOOKEEPER-1193: - Forrest has always been painful

[jira] [Resolved] (ZOOKEEPER-1193) Remove upgrade code

2011-10-20 Thread Patrick Hunt (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt resolved ZOOKEEPER-1193. - Resolution: Fixed Hadoop Flags: Reviewed committed to trunk. It seems that we

[jira] [Created] (ZOOKEEPER-1237) ERRORs being logged when queued responses are sent after socket has closed.

2011-10-20 Thread Patrick Hunt (Created) (JIRA)
ERRORs being logged when queued responses are sent after socket has closed. --- Key: ZOOKEEPER-1237 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1237 Project: ZooKeeper

[jira] [Created] (ZOOKEEPER-1238) when the linger time was changed for NIO the patch missed Netty

2011-10-20 Thread Patrick Hunt (Created) (JIRA)
when the linger time was changed for NIO the patch missed Netty --- Key: ZOOKEEPER-1238 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1238 Project: ZooKeeper Issue Type: Bug

[jira] [Commented] (ZOOKEEPER-1197) Incorrect socket handling of 4 letter words for NIO

2011-10-20 Thread Patrick Hunt (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131775#comment-13131775 ] Patrick Hunt commented on ZOOKEEPER-1197: - Can you take a look at

[jira] [Commented] (ZOOKEEPER-1237) ERRORs being logged when queued responses are sent after socket has closed.

2011-10-20 Thread Patrick Hunt (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131859#comment-13131859 ] Patrick Hunt commented on ZOOKEEPER-1237: - sendBuffer is eating (log then

[jira] [Commented] (ZOOKEEPER-1204) Shorten calls to ZooTrace

2011-10-20 Thread Patrick Hunt (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131894#comment-13131894 ] Patrick Hunt commented on ZOOKEEPER-1204: - ZooTrace is an artifact of version

any concerns removing ZooTrace functionality?

2011-10-20 Thread Patrick Hunt
In https://issues.apache.org/jira/browse/ZOOKEEPER-1204?focusedCommentId=13131894#comment-13131894 I've proposed removing ZooTrace entirely (it is an artifact of v1 zookeeper, where not even log4j was used). This would be for 3.5.0, we'd replace ZooTrace with regular slf4j logging (at trace

Re: Why does multi-op check operation increment zxid?

2011-10-20 Thread Marshall McMullen
Did anyone open a Jira case on these bugs? On Thu, Oct 20, 2011 at 10:07 AM, Marshall McMullen marshall.mcmul...@gmail.com wrote: I agree with Ted, these are both definitely bugs. On Thu, Oct 20, 2011 at 6:52 AM, Ted Dunning ted.dunn...@gmail.comwrote: Both of these sound like bugs. Sent

[jira] [Commented] (ZOOKEEPER-1237) ERRORs being logged when queued responses are sent after socket has closed.

2011-10-20 Thread Camille Fournier (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13132146#comment-13132146 ] Camille Fournier commented on ZOOKEEPER-1237: - Why do we ignore that

[jira] [Commented] (BOOKKEEPER-88) derby doesn't like - in the topic names

2011-10-20 Thread Ivan Kelly (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131471#comment-13131471 ] Ivan Kelly commented on BOOKKEEPER-88: -- Why doesn't it like '-'? What kind of