Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/592
Nice catch @PhantomThief
Do you think writing a unit test would worth to cover the issue?
---
Github user a470577391 closed the pull request at:
https://github.com/apache/zookeeper/pull/573
---
See https://builds.apache.org/job/ZooKeeper-trunk/140/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 143.92 KB...]
[junit] Tests run: 1, Failures: 0,
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2032/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 78.98 MB...]
[exec] +1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570996#comment-16570996
]
Hadoop QA commented on ZOOKEEPER-3111:
--
-1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2031/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 78.95 MB...]
[exec] +1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570993#comment-16570993
]
Hadoop QA commented on ZOOKEEPER-3112:
--
+1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2030/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 78.79 MB...]
[exec] +1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570979#comment-16570979
]
Hadoop QA commented on ZOOKEEPER-3110:
--
+1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3111:
--
Labels: pull-request-available (was: )
> Add socket buffer size option to tune
GitHub user lvfangmin opened a pull request:
https://github.com/apache/zookeeper/pull/593
[ZOOKEEPER-3111] Add socket buffer size option to tune the TCP throughput
between leader and learner
You can merge this pull request into a Git repository by running:
$ git pull
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3112:
--
Labels: pull-request-available (was: )
> fd leak due to
GitHub user PhantomThief opened a pull request:
https://github.com/apache/zookeeper/pull/592
ZOOKEEPER-3112: fix fd leak due to UnresolvedAddressException on connâ¦
â¦ect.
You can merge this pull request into a Git repository by running:
$ git pull
Tianzhou Wang created ZOOKEEPER-3112:
Summary: fd leak due to UnresolvedAddressException on connect.
Key: ZOOKEEPER-3112
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3112
Project:
Fangmin Lv created ZOOKEEPER-3111:
-
Summary: Add socket buffer size option to tune the TCP throughput
between leader and learner
Key: ZOOKEEPER-3111
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3111
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3110:
--
Labels: pull-request-available (was: )
> Improve the closeSession throughput in
GitHub user lvfangmin opened a pull request:
https://github.com/apache/zookeeper/pull/591
[ZOOKEEPER-3110] Improve the closeSession throughput in PrepRequestProcessor
You can merge this pull request into a Git repository by running:
$ git pull
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fangmin Lv updated ZOOKEEPER-3110:
--
Description:
On leader every expired global session will add 3 lines of logs, which is
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570957#comment-16570957
]
Hadoop QA commented on ZOOKEEPER-1177:
--
-1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2029/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 80.05 MB...]
[exec]
Fangmin Lv created ZOOKEEPER-3110:
-
Summary: Improve the closeSession throughput in
PrepRequestProcessor
Key: ZOOKEEPER-3110
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3110
Project:
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2028/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 73.71 MB...]
[exec]
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570947#comment-16570947
]
Hadoop QA commented on ZOOKEEPER-1177:
--
-1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-1177:
--
Labels: pull-request-available (was: )
> Enabling a large number of watches for a
GitHub user lvfangmin opened a pull request:
https://github.com/apache/zookeeper/pull/590
[ZOOKEEPER-1177] Add the memory optimized watch manager for concentrate
watches scenario
The current HashSet based WatcherManager will consume more than 40GB memory
when
creating 300M
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/580
@eolivelli
I got that this is Facebook work on adding new metrics and at the same time
you're working on a generic long term solution for ZooKeeper metrics system.
My point is that
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2027/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 41.06 MB...]
[exec] +1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570471#comment-16570471
]
Hadoop QA commented on ZOOKEEPER-3030:
--
+1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570363#comment-16570363
]
Hadoop QA commented on ZOOKEEPER-3030:
--
-1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2026/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 40.86 MB...]
[exec] +1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2020/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 79.84 MB...]
[exec] +1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570316#comment-16570316
]
Hadoop QA commented on ZOOKEEPER-3103:
--
+1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2025/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 6.55 KB...]
[exec] % Total
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2024/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 6.55 KB...]
[exec] % Total
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/580
@anmolnar this change is a backport from Facebook fork.
in PR #582 I have started a brand new work, to design and implement a long
term ZK internal API to instrument server and client
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2023/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 6.55 KB...]
[exec] Pull
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2021/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 35.85 KB...]
[exec] +1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570285#comment-16570285
]
Hadoop QA commented on ZOOKEEPER-3103:
--
-1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2022/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 6.71 KB...]
[exec]
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2019/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 6.66 KB...]
[exec] % Total
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/582
@anmolnar that you for catching those file, I did a 'git add .' too
aggressively.
@lvfangmin I have addressed you comments
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2017/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 6.55 KB...]
[exec] % Total
GitHub user nkalmar opened a pull request:
https://github.com/apache/zookeeper/pull/589
ZOOKEEPER-3030 - MAVEN MIGRATION 3.4 - Step 1.3 - move contrib directories
â¦ories
You can merge this pull request into a Git repository by running:
$ git pull
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2016/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 77.78 MB...]
[exec]
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570239#comment-16570239
]
Hadoop QA commented on ZOOKEEPER-2261:
--
-1 overall. GitHub Pull Request Build
+1
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/580#discussion_r207891221
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -33,17 +34,17 @@
public class ServerStats {
private static
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570186#comment-16570186
]
Hadoop QA commented on ZOOKEEPER-3030:
--
+1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2015/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 79.10 MB...]
[exec] +1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570171#comment-16570171
]
Hudson commented on ZOOKEEPER-3085:
---
FAILURE: Integrated in Jenkins build ZooKeeper-trunk #138 (See
See https://builds.apache.org/job/ZooKeeper-trunk/138/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 144.38 KB...]
[junit] Running
GitHub user nkalmar reopened a pull request:
https://github.com/apache/zookeeper/pull/574
ZOOKEEPER-3030 - MAVEN MIGRATION - Step 1.3 - move contrib directories
Move the contrib projects according to new directory structure.
In the PR src/contrib/zkperl/build/check_zk_version.c
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r207874376
--- Diff: .gitignore ---
@@ -79,3 +79,4 @@ src/c/depcomp
src/c/install-sh
src/c/ltmain.sh
src/c/missing
+/nbproject/private/
---
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r207874562
--- Diff: nbproject/project.xml ---
@@ -0,0 +1,124 @@
+
--- End diff --
Same here. You don't want to commit your IDE specific files.
Github user nkalmar closed the pull request at:
https://github.com/apache/zookeeper/pull/574
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/574
Committed to branch-3.5 and master.
Thanks @nkalmar !
Please close this PR and create another one for 3.4
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/572
Committed to master branch.
Thanks @nkalmar !
---
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/572
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-2693:
--
Labels: pull-request-available (was: )
> DOS attack on wchp/wchc four letter
Github user anmolnar commented on the pull request:
https://github.com/apache/zookeeper/commit/a2623a625a4778720f7d5482d0a66e9b37ae556f#commitcomment-29970536
@maoling Trying to find the best email thread in MarkMail for you, but
@nkalmar gave you a very good reasoning. It's a long
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570082#comment-16570082
]
Hadoop QA commented on ZOOKEEPER-3030:
--
+1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2014/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 78.44 MB...]
[exec] +1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2013/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 79.94 MB...]
[exec]
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570033#comment-16570033
]
Hadoop QA commented on ZOOKEEPER-3030:
--
-1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2012/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 79.08 MB...]
[exec] +1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570009#comment-16570009
]
Hadoop QA commented on ZOOKEEPER-3030:
--
-1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569995#comment-16569995
]
Hudson commented on ZOOKEEPER-3057:
---
FAILURE: Integrated in Jenkins build ZooKeeper-trunk #137 (See
See https://builds.apache.org/job/ZooKeeper-trunk/137/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 144.58 KB...]
[junit] Running
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2011/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 79.81 MB...]
[exec] +1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569905#comment-16569905
]
Hadoop QA commented on ZOOKEEPER-3030:
--
-1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2010/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 79.18 MB...]
[exec] +1
Github user nkalmar commented on the issue:
https://github.com/apache/zookeeper/pull/572
The build failed due to NetUtilsTest not having apache license. I did not
create or made modification to that file. I checked master, it is currently in
the same way, so master should fail with
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569869#comment-16569869
]
Hadoop QA commented on ZOOKEEPER-3030:
--
-1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569862#comment-16569862
]
Hadoop QA commented on ZOOKEEPER-3085:
--
-1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2008/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 79.72 MB...]
[exec] +1
74 matches
Mail list logo