[jira] [Commented] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments

2012-01-25 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13193471#comment-13193471 ] Benjamin Reed commented on ZOOKEEPER-1366: -- once the @Test annotation

[jira] [Commented] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments

2012-01-25 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13193558#comment-13193558 ] Benjamin Reed commented on ZOOKEEPER-1366: -- i don't think we should commit

[jira] [Updated] (ZOOKEEPER-1355) Add zk.updateServerList(newServerList)

2012-01-25 Thread Benjamin Reed (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-1355: - Hadoop Flags: Reviewed Add zk.updateServerList(newServerList

[jira] [Commented] (ZOOKEEPER-1355) Add zk.updateServerList(newServerList)

2012-01-25 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13193561#comment-13193561 ] Benjamin Reed commented on ZOOKEEPER-1355: -- +1 i think this is ready

[jira] [Commented] (ZOOKEEPER-1367) Data inconsistencies and unexpired ephemeral nodes after cluster restart

2012-01-24 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13192863#comment-13192863 ] Benjamin Reed commented on ZOOKEEPER-1367: -- so when you say that you only add

[jira] [Commented] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments

2012-01-19 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13189488#comment-13189488 ] Benjamin Reed commented on ZOOKEEPER-1366: -- +1 nice patch. i vaguely remember

[jira] [Commented] (ZOOKEEPER-973) bind() could fail on Leader because it does not setReuseAddress on its ServerSocket

2012-01-19 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13189491#comment-13189491 ] Benjamin Reed commented on ZOOKEEPER-973: - +1 looks good bind

[jira] [Commented] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments

2012-01-19 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13189538#comment-13189538 ] Benjamin Reed commented on ZOOKEEPER-1366: -- good catch zhihong! i wish hudson

[jira] [Commented] (ZOOKEEPER-1355) Add zk.updateServerList(newServerList)

2012-01-19 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13189553#comment-13189553 ] Benjamin Reed commented on ZOOKEEPER-1355: -- can you freshen the patch alex

[jira] [Commented] (ZOOKEEPER-1355) Add zk.updateServerList(newServerList)

2012-01-11 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184245#comment-13184245 ] Benjamin Reed commented on ZOOKEEPER-1355: -- this looks really good! i have

Re: Roadmap?

2012-01-04 Thread Benjamin Reed
we've done roadmaps in the past, and they don't seem to work out. in the end it all really depends on the contributions that we get. making releases feature based tends to encourage the just-in-time implementation of the required features at the last minute, which leads to a delayed and unstable

[jira] [Commented] (ZOOKEEPER-1177) Enabling a large number of watches for a large number of clients

2012-01-03 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13178851#comment-13178851 ] Benjamin Reed commented on ZOOKEEPER-1177: -- perhaps we should make

Re: zookeeper client retry logic..

2012-01-03 Thread Benjamin Reed
this is a good observation. one problem with this reasoning is that the timeout should really be based on expected latencies which is independent of the number of servers. one problem you may run into with this logic is if you have a bunch of servers, like 9, your timeouts may get too small and

[jira] [Commented] (ZOOKEEPER-575) remove System.exit calls to make the server more container friendly

2012-01-03 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13179139#comment-13179139 ] Benjamin Reed commented on ZOOKEEPER-575: - this looks good we should commit

[jira] [Commented] (ZOOKEEPER-442) need a way to remove watches that are no longer of interest

2012-01-03 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13179151#comment-13179151 ] Benjamin Reed commented on ZOOKEEPER-442: - daniel, i'm ready to look

[jira] [Commented] (ZOOKEEPER-1343) getEpochToPropose should check if lastAcceptedEpoch is greater or equal than epoch

2012-01-03 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13179156#comment-13179156 ] Benjamin Reed commented on ZOOKEEPER-1343: -- +1 looks great. the tabs seem

Re: [VOTE] Release ZooKeeper 3.4.2 (candidate 0)

2011-12-25 Thread Benjamin Reed
+1 looks good. thanx ben On Sun, Dec 25, 2011 at 11:11 AM, Mahadev Konar maha...@hortonworks.com wrote: +1 ran unit tests and some basic tests on the release. thanks mahadev On Thu, Dec 22, 2011 at 1:57 PM, Patrick Hunt ph...@apache.org wrote: +1, lgtm. verified sig/xsum, rat, also ran

Re: misgiving about quorm/lead.java 's getEpochToPropose function

2011-12-23 Thread Benjamin Reed
i agree. that is a bug. good catch fish! btw, we need to fix the tabs in that function too! ben On Fri, Dec 23, 2011 at 4:57 AM, Flavio Junqueira f...@yahoo-inc.com wrote: Alex and I discussed it a bit offline and it seems to be bug for us. I have created a jira (ZOOKEEPER-1343) and I'll try

[jira] [Commented] (ZOOKEEPER-1343) getEpochToPropose should check if lastAcceptedEpoch is greater or equal than epoch

2011-12-23 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175434#comment-13175434 ] Benjamin Reed commented on ZOOKEEPER-1343: -- please also fix the tabs

[jira] [Commented] (ZOOKEEPER-1292) FLETest is flaky

2011-12-23 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175497#comment-13175497 ] Benjamin Reed commented on ZOOKEEPER-1292: -- +1 looks good

Re: order of async requests to zookeeper

2011-12-22 Thread Benjamin Reed
are all of these requests being issued from the same zookeeper handle? ben On Thu, Dec 22, 2011 at 6:09 PM, Ted Yu yuzhih...@gmail.com wrote: Hi, The following originated from discussion on a feature in HBase which relies on zookeeper for coordination. A task is removed from the tasks map.

[jira] [Commented] (ZOOKEEPER-1334) Zookeeper 3.4.x is not OSGi compliant - MANIFEST.MF is flawed

2011-12-20 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173298#comment-13173298 ] Benjamin Reed commented on ZOOKEEPER-1334: -- thanx for reporting this. what

Re: hedwig admin code

2011-12-20 Thread Benjamin Reed
On 19 Dec 2011, at 23:22, Benjamin Reed wrote: we need a hedwig api and cli that allows you to get information such as which hubs are up, which hubs own which topic (and perhaps change the assignment), remove topics, remove subscriptions, etc. ben On Mon, Dec 19, 2011 at 2:17 PM, Flavio

Re: Two Leaders?!

2011-12-20 Thread Benjamin Reed
i've seen it before when the configuration files haven't been setup properly. i would check the configuration. if the leader is still the leader, it must have active followers connected to it, otherwise it would give up leadership. i would use netstat to find out who they are. ben On Tue, Dec

[jira] [Commented] (ZOOKEEPER-1333) NPE in FileTxnSnapLog when restarting a cluster

2011-12-20 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173456#comment-13173456 ] Benjamin Reed commented on ZOOKEEPER-1333: -- there are times that you don't

Re: Two Leaders?!

2011-12-20 Thread Benjamin Reed
at 10:13 AM, Benjamin Reed br...@apache.org wrote: i've seen it before when the configuration files haven't been setup properly. i would check the configuration. if the leader is still the leader, it must have active followers connected to it, otherwise it would give up leadership. i would use

[jira] [Commented] (ZOOKEEPER-1333) NPE in FileTxnSnapLog when restarting a cluster

2011-12-20 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173476#comment-13173476 ] Benjamin Reed commented on ZOOKEEPER-1333: -- i looked more closely

Re: Two Leaders?!

2011-12-20 Thread Benjamin Reed
there is a jira for an improvement that would add to the protocol checks to make sure that the server configurations are compatible and make sure that client configurations are compatible. i can't seem to find them though... ben On Tue, Dec 20, 2011 at 12:24 PM, Marshall McMullen

[jira] [Commented] (ZOOKEEPER-1333) NPE in FileTxnSnapLog when restarting a cluster

2011-12-20 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173859#comment-13173859 ] Benjamin Reed commented on ZOOKEEPER-1333: -- +1 this looks good. i can't think

Re: How does cross Region Publication work in Hedwig (what are the guarantees)?

2011-12-19 Thread Benjamin Reed
i can answer the last question about sequence ids. the ids are independent between regions. region A may publish a, b, c and region B may publish x, y, z. region A's sequence may be (1,a), (2,b), (3,c), (4, x), (5,y), (6,z). while region B's sequence may be (1,x), (2,a), (3, b), (4,c), (5, y),

[jira] [Created] (ZOOKEEPER-1327) there are still remnants of hadoop urls

2011-12-12 Thread Benjamin Reed (Created) (JIRA)
there are still remnants of hadoop urls --- Key: ZOOKEEPER-1327 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1327 Project: ZooKeeper Issue Type: Bug Reporter: Benjamin Reed

Re: [VOTE] Release ZooKeeper 3.4.1 (candidate 0)

2011-12-12 Thread Benjamin Reed
+1 tests pass and everything looks good. i did notice one problem: ZOOKEEPER-1327 there are still remnants of hadoop urls in some of our files. that might explain why users keep finding the old wiki pages! it's not a blocker, so i don't think it should hold up the release. ben On Mon, Dec 12,

[jira] [Commented] (ZOOKEEPER-1269) Multi deserialization issues

2011-12-09 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166609#comment-13166609 ] Benjamin Reed commented on ZOOKEEPER-1269: -- +1 excellent work camille

[jira] [Commented] (ZOOKEEPER-1292) FLETest is flaky

2011-12-07 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164622#comment-13164622 ] Benjamin Reed commented on ZOOKEEPER-1292: -- can you a comment to the LEThread

[jira] [Commented] (ZOOKEEPER-1316) zookeeper_init leaks memory if chroot is just '/'

2011-12-07 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164624#comment-13164624 ] Benjamin Reed commented on ZOOKEEPER-1316: -- +1 good catch and fix. i agreed

[jira] [Updated] (ZOOKEEPER-1319) Missing data after restarting+expanding a cluster

2011-12-07 Thread Benjamin Reed (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-1319: - Attachment: ZOOKEEPER-1319_trunk2.patch this should fix everything. i'd like to add

[jira] [Commented] (ZOOKEEPER-1319) Missing data after restarting+expanding a cluster

2011-12-07 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164996#comment-13164996 ] Benjamin Reed commented on ZOOKEEPER-1319: -- never mind, i figured out

[jira] [Commented] (ZOOKEEPER-1319) Missing data after restarting+expanding a cluster

2011-12-07 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164997#comment-13164997 ] Benjamin Reed commented on ZOOKEEPER-1319: -- never mind, i figured out

[jira] [Updated] (BOOKKEEPER-31) Need a project logo

2011-12-06 Thread Benjamin Reed (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-31?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated BOOKKEEPER-31: Attachment: bookeper_wht.png bookeper_blk.png here are hi-res pngs one

Re: Proposal: create a separate ZooKeeper release artifact for recipes

2011-12-05 Thread Benjamin Reed
be to go incubator first. At some point we would deprecate the existing ZK recipes (ala Curator had suitable replacements). Patrick On Fri, Jul 22, 2011 at 10:59 AM, Benjamin Reed br...@apache.org wrote: while i agree with the sentiment of not fragmenting the zookeeper community

Re: Proposal: create a separate ZooKeeper release artifact for recipes

2011-12-05 Thread Benjamin Reed
recipes and the recipes really do need separate release cycles.  Independent releases should be not much of an issue given how compatible ZK versions tend to be. On Mon, Dec 5, 2011 at 10:59 AM, Benjamin Reed br...@apache.org wrote: i also agreed that it would be great to build a community

Re: [VOTE] BookKeeper 4.0.0 Release Candidate 1

2011-12-04 Thread Benjamin Reed
+1 this looks great ivan! excellent work. i do have one question for pat. in the binary tar files do we have to put in something special for the licenses of the included binaries? ben On Fri, Dec 2, 2011 at 12:13 PM, Ivan Kelly iv...@apache.org wrote: This is the second candidate release for

[jira] [Commented] (BOOKKEEPER-131) Fix zookeeper test dependency

2011-12-01 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13161098#comment-13161098 ] Benjamin Reed commented on BOOKKEEPER-131: -- +1 looks good

[jira] [Commented] (BOOKKEEPER-134) Delete superfluous lib directories

2011-12-01 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13161239#comment-13161239 ] Benjamin Reed commented on BOOKKEEPER-134: -- +1 Delete

[jira] [Commented] (ZOOKEEPER-1312) Add a getChildrenWithStat operation

2011-11-30 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13160642#comment-13160642 ] Benjamin Reed commented on ZOOKEEPER-1312: -- why do you need multi op? you

[jira] [Commented] (BOOKKEEPER-127) Make poms use official zookeeper 3.4.0

2011-11-29 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159575#comment-13159575 ] Benjamin Reed commented on BOOKKEEPER-127: -- +1 looks good

[jira] [Commented] (BOOKKEEPER-128) pom and script modifications required for generating release packages

2011-11-29 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159577#comment-13159577 ] Benjamin Reed commented on BOOKKEEPER-128: -- +1 pom

[jira] [Commented] (BOOKKEEPER-122) Review BookKeeper server documentation

2011-11-29 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159590#comment-13159590 ] Benjamin Reed commented on BOOKKEEPER-122: -- it looks good

[jira] [Commented] (BOOKKEEPER-111) Document bookie recovery feature

2011-11-29 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159617#comment-13159617 ] Benjamin Reed commented on BOOKKEEPER-111: -- looks pretty good. there is a two

[jira] [Commented] (BOOKKEEPER-111) Document bookie recovery feature

2011-11-29 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159634#comment-13159634 ] Benjamin Reed commented on BOOKKEEPER-111: -- +1 looks good thanx ivan

[jira] [Commented] (BOOKKEEPER-62) Bookie can not start when encountering corrupted records

2011-11-29 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159805#comment-13159805 ] Benjamin Reed commented on BOOKKEEPER-62: - i don't think we want

[jira] [Commented] (BOOKKEEPER-31) Need a project logo

2011-11-22 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155462#comment-13155462 ] Benjamin Reed commented on BOOKKEEPER-31: - yes, george just gave this to me

Re: [VOTE] Release ZooKeeper 3.3.4 (candidate 0)

2011-11-19 Thread Benjamin Reed
+1 looks great. thanx for doing the release pat! On Sat, Nov 19, 2011 at 10:12 AM, Roman Shaposhnik r...@apache.org wrote: On Wed, Nov 16, 2011 at 11:11 PM, Patrick Hunt ph...@apache.org wrote: I have created a candidate build for ZooKeeper 3.3.4. 22 JIRAs are addressed in this release. ***

Re: [VOTE] Release ZooKeeper 3.4.0 (candidate 2)

2011-11-18 Thread Benjamin Reed
+1. looks good. one issue i found, which is i'm not sure if it is an issue or not due to my ignorance of maven, is that i had to specify the packaging when installing the jar file into my local repository: mvn install:install-file -Dfile=/tmp/zookeeper-3.4.0/dist-maven/zookeeper-3.4.0-test.jar

[jira] [Commented] (ZOOKEEPER-1264) FollowerResyncConcurrencyTest failing intermittently

2011-11-03 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13143232#comment-13143232 ] Benjamin Reed commented on ZOOKEEPER-1264: -- yeah, the observers (as far as my

[jira] [Commented] (ZOOKEEPER-1264) FollowerResyncConcurrencyTest failing intermittently

2011-11-03 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13143233#comment-13143233 ] Benjamin Reed commented on ZOOKEEPER-1264: -- henry could you check

[jira] [Commented] (ZOOKEEPER-1282) Learner.java not following Zab 1.0 protocol - setCurrentEpoch should be done upon receipt of NEWLEADER (before acking it) and not upon receipt of UPTODATE

2011-11-03 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13143692#comment-13143692 ] Benjamin Reed commented on ZOOKEEPER-1282: -- there is a test and a fix

[jira] [Updated] (ZOOKEEPER-1264) FollowerResyncConcurrencyTest failing intermittently

2011-11-02 Thread Benjamin Reed (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-1264: - Attachment: ZOOKEEPER-1264unittest.patch i've created a unit test to reproduce

Re: Comment from Martin Fowler

2011-11-02 Thread Benjamin Reed
the tests aren't green dude! that is exactly what i proposed waiting for. ben On Wed, Nov 2, 2011 at 2:57 AM, Thomas Koch tho...@koch.ro wrote: Martin Fowler wrote a comment yesterday on our recent discussion about refactoring: http://martinfowler.com/bliki/OpportunisticRefactoring.html

[jira] [Commented] (ZOOKEEPER-1264) FollowerResyncConcurrencyTest failing intermittently

2011-11-02 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142182#comment-13142182 ] Benjamin Reed commented on ZOOKEEPER-1264: -- just a quick update. i'm able

[jira] [Updated] (ZOOKEEPER-1264) FollowerResyncConcurrencyTest failing intermittently

2011-11-02 Thread Benjamin Reed (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-1264: - Attachment: ZOOKEEPER-1264unittest.patch here is the unit test. doing a snapshot

[jira] [Updated] (ZOOKEEPER-1264) FollowerResyncConcurrencyTest failing intermittently

2011-11-02 Thread Benjamin Reed (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-1264: - Attachment: ZOOKEEPER-1264.patch i think i got it. camille can you try it with your

[jira] [Commented] (ZOOKEEPER-1264) FollowerResyncConcurrencyTest failing intermittently

2011-11-02 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142328#comment-13142328 ] Benjamin Reed commented on ZOOKEEPER-1264: -- i agree, we should have the extra

[jira] [Commented] (ZOOKEEPER-1282) Learner.java not following Zab 1.0 protocol - setCurrentEpoch should be done upon receipt of NEWLEADER (before acking it) and not upon receipt of UPTODATE

2011-11-02 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142638#comment-13142638 ] Benjamin Reed commented on ZOOKEEPER-1282: -- i can easily put a test and fix

[jira] [Updated] (ZOOKEEPER-1264) FollowerResyncConcurrencyTest failing intermittently

2011-11-02 Thread Benjamin Reed (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-1264: - Attachment: ZOOKEEPER-1264.patch this patch merges camille's test in as well

[jira] [Commented] (ZOOKEEPER-1264) FollowerResyncConcurrencyTest failing intermittently

2011-11-01 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141244#comment-13141244 ] Benjamin Reed commented on ZOOKEEPER-1264: -- the reason we take a snapshot

[jira] [Commented] (ZOOKEEPER-1264) FollowerResyncConcurrencyTest failing intermittently

2011-11-01 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141263#comment-13141263 ] Benjamin Reed commented on ZOOKEEPER-1264: -- ah cool. ok i'll check it out now

[jira] [Commented] (ZOOKEEPER-1264) FollowerResyncConcurrencyTest failing intermittently

2011-11-01 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141275#comment-13141275 ] Benjamin Reed commented on ZOOKEEPER-1264: -- i applied your patch to trunk

[jira] [Commented] (ZOOKEEPER-1264) FollowerResyncConcurrencyTest failing intermittently

2011-11-01 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141355#comment-13141355 ] Benjamin Reed commented on ZOOKEEPER-1264: -- got it. i think i see how to make

Re: Better testing for client code...

2011-11-01 Thread Benjamin Reed
i second the need for such a mocked ZooKeeper client! there are a couple of failure cases to test in an application that uses ZooKeeper, but we don't provide a good library to generate them. ben On Tue, Nov 1, 2011 at 11:10 AM, Ted Dunning ted.dunn...@gmail.com wrote: The testing pain that I

cleanup and subjective patches

2011-10-31 Thread Benjamin Reed
i know we have discussed this in the past, but we never really came to a consensus or policy, so i'd like to reopen the discussion on cleanup and subjective patches. currently there are 7 jiras for cleanup issues, 6 of them marked as major. the problem with cleanup or subjective patches is that

Re: cleanup and subjective patches

2011-10-31 Thread Benjamin Reed
started in the drafts folder until I've calmed down again. Benjamin Reed: deprioritizing them doesn't help because the patches themselves bit rot. shortly they will not apply and then they will be worthless. the poor contributor would then be left with the task of maintaining

Re: cleanup and subjective patches

2011-10-31 Thread Benjamin Reed
. Benjamin Reed: deprioritizing them doesn't help because the patches themselves bit rot. shortly they will not apply and then they will be worthless. the poor contributor would then be left with the task of maintaining a patch that would never commit. You should really give GIT a try. I've

[jira] [Commented] (ZOOKEEPER-1269) Multi deserialization issues

2011-10-29 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139305#comment-13139305 ] Benjamin Reed commented on ZOOKEEPER-1269: -- we convert multi to idempotent

[jira] [Commented] (BOOKKEEPER-89) Bookkeeper API changes for initial Bookkeeper release

2011-10-27 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13137211#comment-13137211 ] Benjamin Reed commented on BOOKKEEPER-89: - +1 yes, i think you are right ivan

[jira] [Commented] (BOOKKEEPER-89) Bookkeeper API changes for initial Bookkeeper release

2011-10-26 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13136010#comment-13136010 ] Benjamin Reed commented on BOOKKEEPER-89: - looks great. i like how you moved

Re: Why does multi-op check operation increment zxid?

2011-10-25 Thread Benjamin Reed
to be addressing. so, it's sucking up some valuable committer time. having said that, if a committer does think it is a good idea and wants to shepherd the patch, i certainly wouldn't stand in the way. ben On Mon, Oct 24, 2011 at 10:52 AM, Thomas Koch tho...@koch.ro wrote: Benjamin Reed: i

Re: Why does multi-op check operation increment zxid?

2011-10-23 Thread Benjamin Reed
(and better because it would provide completeness checking). Ben, do you have something specific in mind here?  Were you referring to the boxing/unboxing cost?  Or the clarity of the code in question?  Or something I didn't think of? On Fri, Oct 21, 2011 at 3:32 PM, Benjamin Reed br

Re: Why does multi-op check operation increment zxid?

2011-10-21 Thread Benjamin Reed
i think you found the bug because you reviewed that code to convert to enum. is there something inherit to using enums that helped? i don't think it is wise to use enum when many (most perhaps) of the accesses need to be integers. ben On Thu, Oct 20, 2011 at 6:28 AM, Thomas Koch tho...@koch.ro

[jira] [Commented] (BOOKKEEPER-88) derby doesn't like - in the topic names

2011-10-21 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133147#comment-13133147 ] Benjamin Reed commented on BOOKKEEPER-88: - it's a sql error. i think the derby

Re: Review of public APIs

2011-10-21 Thread Benjamin Reed
i also agee. we should also call it a 4.0 release. ben On Fri, Oct 21, 2011 at 2:17 AM, Ivan Kelly iv...@yahoo-inc.com wrote: I agree with Utkarsh. Initial release is as good of an excuse we'll ever have for breaking stuff. The changes themselves shouldn't be too big though. Ill have a go

[jira] [Created] (BOOKKEEPER-88) derby doesn't like - in the topic names

2011-10-19 Thread Benjamin Reed (Created) (JIRA)
derby doesn't like - in the topic names --- Key: BOOKKEEPER-88 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-88 Project: Bookkeeper Issue Type: Bug Reporter: Benjamin Reed

[jira] [Updated] (BOOKKEEPER-88) derby doesn't like - in the topic names

2011-10-19 Thread Benjamin Reed (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated BOOKKEEPER-88: Attachment: BOOKKEEPER-88.patch derby doesn't like - in the topic names

[jira] [Commented] (ZOOKEEPER-1231) refactor int constants in o.a.z.s.q.Leader to enum

2011-10-18 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13129915#comment-13129915 ] Benjamin Reed commented on ZOOKEEPER-1231: -- i don't think this is a good idea

[jira] [Commented] (BOOKKEEPER-84) Add versioning for ZK metadata

2011-10-18 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13129856#comment-13129856 ] Benjamin Reed commented on BOOKKEEPER-84: - (i'll commit) Add

[jira] [Commented] (BOOKKEEPER-86) bookkeeper-benchmark fails to compile after BOOKKEEPER-68

2011-10-18 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13129882#comment-13129882 ] Benjamin Reed commented on BOOKKEEPER-86: - +1 looks good

[jira] [Commented] (BOOKKEEPER-39) Bookie server failed to restart because of too many ledgers (more than ~50,000 ledgers)

2011-10-07 Thread Benjamin Reed (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13123036#comment-13123036 ] Benjamin Reed commented on BOOKKEEPER-39: - great work sijie! i think it may

Re: Get rid of unnecessary Interfaces

2011-09-23 Thread Benjamin Reed
that's right tom. many of those interfaces were put in by design so that later we can have other implementations, some of them were not there originally. i agree thomas that it is a pain that you have to do two clicks in eclipse to get to the actual implementation. i believe the beans are used

[jira] [Commented] (ZOOKEEPER-1199) Make OpCode an enum

2011-09-22 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13112595#comment-13112595 ] Benjamin Reed commented on ZOOKEEPER-1199: -- -1 i don't think this is a valid

[jira] [Commented] (ZOOKEEPER-1200) Remove obsolete DataTreeBuilder

2011-09-22 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13112605#comment-13112605 ] Benjamin Reed commented on ZOOKEEPER-1200: -- +1 wow nice find thomas! what

Re: Committers: ensure you commit to the proper branch/version.

2011-09-22 Thread Benjamin Reed
i asked mahadev about committing to 3.4.0 and he said to just do trunk. see 1191. there was only one patch. the patch for 1192 subsumed 1191. ben On Thu, Sep 22, 2011 at 10:35 AM, Patrick Hunt ph...@apache.org wrote: When committing a change be sure where you are committing it. Mahadev

[jira] [Updated] (ZOOKEEPER-1191) Synchronization issue - wait not in guarded block

2011-09-22 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-1191: - Fix Version/s: (was: 3.4.0) 3.5.0 Synchronization issue

[jira] [Updated] (ZOOKEEPER-1192) Leader.waitForEpochAck() checks waitingForNewEpoch instead of checking electionFinished

2011-09-22 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-1192: - Fix Version/s: (was: 3.4.0) Leader.waitForEpochAck() checks waitingForNewEpoch

[jira] [Commented] (ZOOKEEPER-1201) Clean SaslServerCallbackHandler.java

2011-09-22 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13112790#comment-13112790 ] Benjamin Reed commented on ZOOKEEPER-1201: -- why is this classified

[jira] [Commented] (ZOOKEEPER-1192) Leader.waitForEpochAck() checks waitingForNewEpoch instead of checking electionFinished

2011-09-21 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13109887#comment-13109887 ] Benjamin Reed commented on ZOOKEEPER-1192: -- +1 looks great alex. i think

[jira] [Commented] (ZOOKEEPER-1194) Two possible race conditions during leader establishment

2011-09-21 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13112149#comment-13112149 ] Benjamin Reed commented on ZOOKEEPER-1194: -- can we break this out from 1192

[jira] [Commented] (ZOOKEEPER-1172) Support for custom org.apache.zookeeper.client.HostProvider implementation.

2011-09-21 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13112193#comment-13112193 ] Benjamin Reed commented on ZOOKEEPER-1172: -- this is great functionality

[jira] [Updated] (ZOOKEEPER-1192) Leader.waitForEpochAck() checks waitingForNewEpoch instead of checking electionFinished

2011-09-21 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-1192: - Attachment: ZOOKEEPER-1192.patch the patch with the tabs and ^Ms fixed

bookkeeper status report

2011-09-16 Thread Benjamin Reed
we need to get our report to pat this weekend. what do you think about this? BookKeeper status report for September 2011. Bookkeeper is a distributed, reliable, and high performance logging service. The project also includes Hedwig which is a highly scalable Pub/Sub service built on top of

[jira] [Commented] (BOOKKEEPER-67) BookieReadWriteTest gets blocked and never finishes

2011-09-14 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104597#comment-13104597 ] Benjamin Reed commented on BOOKKEEPER-67: - on my linux machine i have

<    1   2   3   4   5   6   >