Github user mfenes closed the pull request at:
https://github.com/apache/zookeeper/pull/471
---
Github user mfenes closed the pull request at:
https://github.com/apache/zookeeper/pull/470
---
Github user mfenes closed the pull request at:
https://github.com/apache/zookeeper/pull/469
---
Github user mfenes commented on the issue:
https://github.com/apache/zookeeper/pull/469
@phunt @anmolnar Should I close this PR then?
---
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/469#discussion_r179420191
--- Diff: build.xml ---
@@ -1861,4 +1861,18 @@
xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
+
Github user mfenes closed the pull request at:
https://github.com/apache/zookeeper/pull/391
---
Github user mfenes closed the pull request at:
https://github.com/apache/zookeeper/pull/375
---
Github user mfenes commented on the issue:
https://github.com/apache/zookeeper/pull/490
Hi @leventov, in the commits, there are test code changes, too. Are these
related to the error prone compiler change, or these are just other bugs which
you've fixed?
---
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/490#discussion_r175393694
--- Diff: build.xml ---
@@ -475,23 +484,36 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
pattern="${
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/490#discussion_r175393897
--- Diff: build.xml ---
@@ -475,23 +484,36 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
pattern="${
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/469#discussion_r169695831
--- Diff: build.xml ---
@@ -1861,4 +1861,18 @@
xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
+
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/469#discussion_r169691663
--- Diff: build.xml ---
@@ -1861,4 +1861,18 @@
xmlns:cs="antlib:com.puppycrawl.tools.checkstyl
Github user mfenes closed the pull request at:
https://github.com/apache/zookeeper/pull/459
---
Github user mfenes closed the pull request at:
https://github.com/apache/zookeeper/pull/458
---
GitHub user mfenes opened a pull request:
https://github.com/apache/zookeeper/pull/471
ZOOKEEPER-2983: Print the classpath when running compile and test ant
targets
ZOOKEEPER-2983: Print the classpath when running compile and test ant
targets
I've added 2 new ant targets
GitHub user mfenes opened a pull request:
https://github.com/apache/zookeeper/pull/470
ZOOKEEPER-2983: Print the classpath when running compile and test ant
targets
ZOOKEEPER-2983: Print the classpath when running compile and test ant
targets
I've added 2 new ant targets
GitHub user mfenes opened a pull request:
https://github.com/apache/zookeeper/pull/469
ZOOKEEPER-2983: Print the classpath when running compile and test ant
targets
ZOOKEEPER-2983: Print the classpath when running compile and test ant
targets
I've added 2 new ant targets
GitHub user mfenes opened a pull request:
https://github.com/apache/zookeeper/pull/467
ZOOKEEPER-2968: Add C client code coverage tests
ZOOKEEPER-2968: Add C client code coverage tests
This PR adds a new ant target 'c_coverage_report' which generates coverage
report
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/450#discussion_r168891236
--- Diff:
src/java/test/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java
---
@@ -35,92 +38,181 @@
public class
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/459#discussion_r168889616
--- Diff: src/java/test/org/apache/zookeeper/test/ClientBase.java ---
@@ -351,20 +351,37 @@ static void verifyThreadTerminated(Thread thread,
long millis
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/458#discussion_r16396
--- Diff: src/java/test/org/apache/zookeeper/test/ClientBase.java ---
@@ -368,22 +368,37 @@ static void verifyThreadTerminated(Thread thread,
long millis
Github user mfenes commented on the issue:
https://github.com/apache/zookeeper/pull/459
@afine I've removed the whitespace changes. Please have a look if it looks
right now.
---
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/462#discussion_r168271141
--- Diff: build.xml ---
@@ -220,7 +220,7 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle">
-
+
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/462#discussion_r168179473
--- Diff: build.xml ---
@@ -220,7 +220,7 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle">
-
+
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/453#discussion_r167835407
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java ---
@@ -758,6 +760,11 @@ public boolean syncFollower(long peerLastZxid
Github user mfenes commented on the issue:
https://github.com/apache/zookeeper/pull/461
Please add a JIRA to this pull request.
---
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/453#discussion_r167513290
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java ---
@@ -758,6 +760,11 @@ public boolean syncFollower(long peerLastZxid
GitHub user mfenes opened a pull request:
https://github.com/apache/zookeeper/pull/459
ZOOKEEPER-2967: Add check to validate dataDir and dataLogDir parameters at
startup
ZOOKEEPER-2967: Add check to validate dataDir and dataLogDir parameters at
startup
This PR adds
GitHub user mfenes opened a pull request:
https://github.com/apache/zookeeper/pull/458
ZOOKEEPER-2967: Add check to validate dataDir and dataLogDir parameters at
startup
ZOOKEEPER-2967: Add check to validate dataDir and dataLogDir parameters at
startup
This PR adds
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/450#discussion_r165525848
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
@@ -136,13 +136,51 @@ public FileTxnSnapLog(File dataDir, File
Github user mfenes commented on the issue:
https://github.com/apache/zookeeper/pull/450
@afine I've made the following changes:
Replaced "log" and "snapshot" strings with constants
FileTxnLog.LOG_FILE_PREFIX and FileSnap.SNAPSHOT_FILE_PREFIX.
Used U
Github user mfenes commented on the issue:
https://github.com/apache/zookeeper/pull/443
@phunt @afine I've made the following changes: moved Clover (db, lib,
reports) to ${build.dir}/clover. Included test sources with `` in
clover-setup.
Changed naming to follow other tools
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/450#discussion_r164606812
--- Diff:
src/java/test/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java
---
@@ -159,4 +159,222 @@ public void onTxnLoaded(TxnHeader hdr
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/450#discussion_r164605998
--- Diff:
src/java/test/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java
---
@@ -159,4 +159,222 @@ public void onTxnLoaded(TxnHeader hdr
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/450#discussion_r164605964
--- Diff:
src/java/test/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java
---
@@ -159,4 +159,222 @@ public void onTxnLoaded(TxnHeader hdr
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/450#discussion_r164605860
--- Diff:
src/java/test/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java
---
@@ -159,4 +159,222 @@ public void onTxnLoaded(TxnHeader hdr
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/450#discussion_r164605834
--- Diff:
src/java/test/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java
---
@@ -159,4 +159,222 @@ public void onTxnLoaded(TxnHeader hdr
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/450#discussion_r164605909
--- Diff:
src/java/test/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java
---
@@ -159,4 +159,222 @@ public void onTxnLoaded(TxnHeader hdr
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/450#discussion_r164605723
--- Diff: src/java/main/org/apache/zookeeper/server/persistence/Util.java
---
@@ -294,5 +297,25 @@ public int compare(File o1, File o2
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/450#discussion_r164605619
--- Diff: src/java/main/org/apache/zookeeper/server/persistence/Util.java
---
@@ -294,5 +297,25 @@ public int compare(File o1, File o2
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/450#discussion_r164605521
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
@@ -136,13 +136,51 @@ public FileTxnSnapLog(File dataDir, File
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/450#discussion_r164605358
--- Diff:
src/java/test/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java
---
@@ -159,4 +159,222 @@ public void onTxnLoaded(TxnHeader hdr
Github user mfenes commented on the issue:
https://github.com/apache/zookeeper/pull/451
Looking at the static initialization block in InetAddressCachePolicy more
deeply, the default TTL is 30 seconds if there is no SecurityManager installed.
So caching a positive lookup forever
Github user mfenes commented on the issue:
https://github.com/apache/zookeeper/pull/451
Re-resolving at StaticHostProvider level may not be sufficient as
InetAddress.getAllByName(String host) itself uses a Java-level cache inside
InetAddress and turns to name service (e.g. DNS) only
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/443#discussion_r163684223
--- Diff: build.xml ---
@@ -23,6 +23,48 @@ xmlns:artifact="antlib:org.apache.maven.artifact.ant"
xmlns:maven="antlib:org.apache.mav
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/443#discussion_r163678316
--- Diff: build.xml ---
@@ -1406,50 +1410,53 @@
xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
+
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/443#discussion_r163675784
--- Diff: build.xml ---
@@ -124,6 +160,7 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
+
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/443#discussion_r163670562
--- Diff: build.xml ---
@@ -1406,50 +1410,53 @@
xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
+
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/450#discussion_r163290319
--- Diff: src/java/main/org/apache/zookeeper/server/persistence/Util.java
---
@@ -294,5 +297,25 @@ public int compare(File o1, File o2
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/450#discussion_r163290119
--- Diff: src/java/main/org/apache/zookeeper/server/persistence/Util.java
---
@@ -294,5 +297,25 @@ public int compare(File o1, File o2
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/450#discussion_r163289284
--- Diff: src/java/main/org/apache/zookeeper/server/persistence/Util.java
---
@@ -83,7 +86,7 @@ public static URI makeFileLoggerURL(File dataDir, File
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/450#discussion_r163282674
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
@@ -136,13 +136,51 @@ public FileTxnSnapLog(File dataDir, File
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/450#discussion_r163282090
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
@@ -136,13 +136,51 @@ public FileTxnSnapLog(File dataDir, File
Github user mfenes commented on the issue:
https://github.com/apache/zookeeper/pull/443
@phunt I've fixed "ant compile-test". Now clover dependencies are pulled
into build only when run.clover=true. Thanks for noticing this.
---
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/443#discussion_r163218498
--- Diff: build.xml ---
@@ -132,21 +169,16 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyl
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/443#discussion_r163198966
--- Diff: build.xml ---
@@ -124,6 +160,7 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
+
Github user mfenes commented on the issue:
https://github.com/apache/zookeeper/pull/443
@phunt I've added ivy.xml configuration for Clover: test-coverage-java and
created an ant target with the same name, so generating a coverage report for
Java became as simple as running ant test
Github user mfenes commented on the issue:
https://github.com/apache/zookeeper/pull/443
@anmolnar Clover home is now set to test.java.build.dir. No need to
configure CLOVER_HOME environment variable.
---
GitHub user mfenes opened a pull request:
https://github.com/apache/zookeeper/pull/450
ZOOKEEPER-2967: Add check to validate dataDir and dataLogDir parameteâ¦
ZOOKEEPER-2967: Add check to validate dataDir and dataLogDir parameters at
startup
This PR adds a check
Github user mfenes commented on the issue:
https://github.com/apache/zookeeper/pull/443
@anmolnar Yes, OpenClover's Intellectual property protection page
http://openclover.org/doc/manual/4.2.0/developer-guide--intellectual-property-protection.html
says that
- Clover Core
Github user mfenes commented on the issue:
https://github.com/apache/zookeeper/pull/443
@phunt According to OpenClover 4.2.0 Release Notes at
http://openclover.org/doc/openclover-4.2.0-release-notes.html
_"No license key required
OpenClover requires no license key, in
GitHub user mfenes opened a pull request:
https://github.com/apache/zookeeper/pull/445
ZOOKEEPER-2955: Enable Clover code coverage report
ZOOKEEPER-2955: Enable Clover code coverage report
This PR configures OpenClover to generate Java code coverage reports
GitHub user mfenes opened a pull request:
https://github.com/apache/zookeeper/pull/444
ZOOKEEPER-2955: Enable Clover code coverage report
ZOOKEEPER-2955: Enable Clover code coverage report
This PR configures OpenClover to generate Java code coverage reports
GitHub user mfenes opened a pull request:
https://github.com/apache/zookeeper/pull/443
ZOOKEEPER-2955: Enable Clover code coverage report
ZOOKEEPER-2955: Enable Clover code coverage report
This PR configures OpenClover to generate Java code coverage reports
Github user mfenes commented on the issue:
https://github.com/apache/zookeeper/pull/427
@fr0stbyte could you please add a description to your PR so that everybody
could understand the purpose of this change?
---
Github user mfenes commented on the issue:
https://github.com/apache/zookeeper/pull/423
Could you please provide a description of your change
---
Github user mfenes closed the pull request at:
https://github.com/apache/zookeeper/pull/404
---
Github user mfenes closed the pull request at:
https://github.com/apache/zookeeper/pull/405
---
GitHub user mfenes opened a pull request:
https://github.com/apache/zookeeper/pull/406
ZOOKEEPER-2690: Update documentation source for ZOOKEEPER-2574
ZOOKEEPER-2690: Update documentation source for ZOOKEEPER-2574
Added the documentation changes from PR #111 to the source
GitHub user mfenes opened a pull request:
https://github.com/apache/zookeeper/pull/405
ZOOKEEPER-2690: Update documentation source for ZOOKEEPER-2574
ZOOKEEPER-2690: Update documentation source for ZOOKEEPER-2574
Added the documentation changes from PR
https://github.com
GitHub user mfenes opened a pull request:
https://github.com/apache/zookeeper/pull/404
ZOOKEEPER-2690: Update documentation source for ZOOKEEPER-2574
ZOOKEEPER-2690: Update documentation source for ZOOKEEPER-2574
Added the documentation changes from PR
https://github.com
Github user mfenes closed the pull request at:
https://github.com/apache/zookeeper/pull/375
---
GitHub user mfenes reopened a pull request:
https://github.com/apache/zookeeper/pull/375
ZOOKEEPER-1363: Categorise unit tests by 'test-commit', 'full-test' etc
ZOOKEEPER-1363: Categorise unit tests by 'test-commit', 'full-test' etc
Added new capability of defining test
GitHub user mfenes reopened a pull request:
https://github.com/apache/zookeeper/pull/375
ZOOKEEPER-1363: Categorise unit tests by 'test-commit', 'full-test' etc
ZOOKEEPER-1363: Categorise unit tests by 'test-commit', 'full-test' etc
Added new capability of defining test
Github user mfenes closed the pull request at:
https://github.com/apache/zookeeper/pull/375
---
Github user mfenes commented on the issue:
https://github.com/apache/zookeeper/pull/371
Regex implementation would be shorter to ignore the spaces and empty
strings as
```
connectString.replaceAll("\\s", "").replaceAll(",+", ",").spl
Github user mfenes closed the pull request at:
https://github.com/apache/zookeeper/pull/390
---
GitHub user mfenes opened a pull request:
https://github.com/apache/zookeeper/pull/391
ZOOKEEPER-2727: WARN and stacktrace for normally closed socket
ZOOKEEPER-2727: WARN and stacktrace for normally closed socket
Log level reduced to info for EndOfStreamException
Github user mfenes closed the pull request at:
https://github.com/apache/zookeeper/pull/355
---
Github user mfenes commented on the issue:
https://github.com/apache/zookeeper/pull/375
The reason why I've created a test category for "slow" and not for "fast"
is because this way one can specify a test category by ant test
-Dtest.category=... and can exclude t
GitHub user mfenes opened a pull request:
https://github.com/apache/zookeeper/pull/390
ZOOKEEPER-2908: quorum.auth.MiniKdcTest.testKerberosLogin failing witâ¦
ZOOKEEPER-2908: quorum.auth.MiniKdcTest.testKerberosLogin failing with NPE
on Java 9
Cause:
The NPE
GitHub user mfenes reopened a pull request:
https://github.com/apache/zookeeper/pull/375
ZOOKEEPER-1363: Categorise unit tests by 'test-commit', 'full-test' etc
ZOOKEEPER-1363: Categorise unit tests by 'test-commit', 'full-test' etc
Added new capability of defining test
Github user mfenes closed the pull request at:
https://github.com/apache/zookeeper/pull/375
---
GitHub user mfenes opened a pull request:
https://github.com/apache/zookeeper/pull/375
ZOOKEEPER-1363: Categorise unit tests by 'test-commit', 'full-test' etc
ZOOKEEPER-1363: Categorise unit tests by 'test-commit', 'full-test' etc
Added new capability of defining test
GitHub user mfenes reopened a pull request:
https://github.com/apache/zookeeper/pull/355
ZOOKEEPER-2809: Unnecessary stack-trace in server when the client disâ¦
Unnecessary stack-trace in server when the client disconnects unexpectedly.
Backport from master, branch-3.5
Github user mfenes closed the pull request at:
https://github.com/apache/zookeeper/pull/355
---
GitHub user mfenes reopened a pull request:
https://github.com/apache/zookeeper/pull/355
ZOOKEEPER-2809: Unnecessary stack-trace in server when the client disâ¦
Unnecessary stack-trace in server when the client disconnects unexpectedly.
Backport from master, branch-3.5
Github user mfenes closed the pull request at:
https://github.com/apache/zookeeper/pull/355
---
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/355#discussion_r137005402
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -374,14 +373,12 @@ void doIO(SelectionKey k) throws InterruptedException
GitHub user mfenes opened a pull request:
https://github.com/apache/zookeeper/pull/355
ZOOKEEPER-2809: Unnecessary stack-trace in server when the client disâ¦
Unnecessary stack-trace in server when the client disconnects unexpectedly.
Backport from master, branch-3.5
90 matches
Mail list logo
