Re: Review Request 35204: ZOOKEEPER-2193: reconfig command completes even if parameter is wrong obviously

2015-06-22 Thread Yasuhito Fukuda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35204/ --- (Updated 6月 23, 2015, 1:39 p.m.) Review request for zookeeper. Bugs: ZOOKEEPE

Re: Review Request 35204: ZOOKEEPER-2193: reconfig command completes even if parameter is wrong obviously

2015-06-21 Thread Raul Gutierrez Segales
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35204/#review88716 --- src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java (l

Re: Review Request 35204: ZOOKEEPER-2193: reconfig command completes even if parameter is wrong obviously

2015-06-21 Thread Raul Gutierrez Segales
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35204/#review88715 --- src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java (l

Re: Review Request 35204: ZOOKEEPER-2193: reconfig command completes even if parameter is wrong obviously

2015-06-19 Thread Yasuhito Fukuda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35204/ --- (Updated 6月 19, 2015, 4:33 p.m.) Review request for zookeeper. Bugs: ZOOKEEPE

Re: Review Request 35204: ZOOKEEPER-2193: reconfig command completes even if parameter is wrong obviously

2015-06-11 Thread Yasuhito Fukuda
> On 6月 10, 2015, 11:17 a.m., Raul Gutierrez Segales wrote: > > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java, line 128 > > > > > > this'll override the default type which is Participant: > > >

Re: Review Request 35204: ZOOKEEPER-2193: reconfig command completes even if parameter is wrong obviously

2015-06-11 Thread Yasuhito Fukuda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35204/ --- (Updated 6月 11, 2015, 4:59 p.m.) Review request for zookeeper. Bugs: ZOOKEEPE

Re: Review Request 35204: ZOOKEEPER-2193: reconfig command completes even if parameter is wrong obviously

2015-06-09 Thread Raul Gutierrez Segales
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35204/#review87340 --- src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java

Re: Review Request 35204: ZOOKEEPER-2193: reconfig command completes even if parameter is wrong obviously

2015-06-08 Thread Yasuhito Fukuda
> On 6月 9, 2015, 10:12 a.m., Raul Gutierrez Segales wrote: > > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java, line 304 > > > > > > sounds like myAddrs could be constructed and saved from the > > con

Re: Review Request 35204: ZOOKEEPER-2193: reconfig command completes even if parameter is wrong obviously

2015-06-08 Thread Yasuhito Fukuda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35204/ --- (Updated 6月 9, 2015, 3:45 p.m.) Review request for zookeeper. Bugs: ZOOKEEPER

Re: Review Request 35204: ZOOKEEPER-2193: reconfig command completes even if parameter is wrong obviously

2015-06-08 Thread Raul Gutierrez Segales
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35204/#review87114 --- src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java

Review Request 35204: ZOOKEEPER-2193: reconfig command completes even if parameter is wrong obviously

2015-06-08 Thread Yasuhito Fukuda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35204/ --- Review request for zookeeper. Bugs: ZOOKEEPER-2193 https://issues.apache.or