[
https://issues.apache.org/jira/browse/ZOOKEEPER-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Norbert Kalmar resolved ZOOKEEPER-3021.
---
Resolution: Done
> Umbrella: Migrate project structure to Maven build
>
anmolnar commented on issue #836: Fix for license files and contrib folder
during release (3.4)
URL: https://github.com/apache/zookeeper/pull/836#issuecomment-467827093
@phunt I removed the one in the resources folder. Looks like the file was
not missing and the patch is a simple move
anmolnar commented on a change in pull request #730: Zookeeper-3188: Improve
resilience to network
URL: https://github.com/apache/zookeeper/pull/730#discussion_r260771808
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/MultipleAddresses.java
anmolnar commented on a change in pull request #730: Zookeeper-3188: Improve
resilience to network
URL: https://github.com/apache/zookeeper/pull/730#discussion_r260766216
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/MultipleAddresses.java
anmolnar commented on a change in pull request #730: Zookeeper-3188: Improve
resilience to network
URL: https://github.com/apache/zookeeper/pull/730#discussion_r260772663
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
anmolnar commented on a change in pull request #730: Zookeeper-3188: Improve
resilience to network
URL: https://github.com/apache/zookeeper/pull/730#discussion_r260754702
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java
##
@@
anmolnar commented on a change in pull request #730: Zookeeper-3188: Improve
resilience to network
URL: https://github.com/apache/zookeeper/pull/730#discussion_r260756647
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java
##
@@
anmolnar commented on a change in pull request #730: Zookeeper-3188: Improve
resilience to network
URL: https://github.com/apache/zookeeper/pull/730#discussion_r260772089
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
anmolnar commented on a change in pull request #730: Zookeeper-3188: Improve
resilience to network
URL: https://github.com/apache/zookeeper/pull/730#discussion_r260761623
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/MultipleAddresses.java
anmolnar commented on a change in pull request #730: Zookeeper-3188: Improve
resilience to network
URL: https://github.com/apache/zookeeper/pull/730#discussion_r260771808
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/MultipleAddresses.java
anmolnar commented on a change in pull request #730: Zookeeper-3188: Improve
resilience to network
URL: https://github.com/apache/zookeeper/pull/730#discussion_r260756137
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java
##
@@
anmolnar commented on a change in pull request #730: Zookeeper-3188: Improve
resilience to network
URL: https://github.com/apache/zookeeper/pull/730#discussion_r260760811
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/MultipleAddresses.java
anmolnar edited a comment on issue #836: Fix for license files and contrib
folder during release (3.4)
URL: https://github.com/apache/zookeeper/pull/836#issuecomment-467908721
Committed. Thanks @phunt & @nkalmar !
This is an
anmolnar closed pull request #836: Fix for license files and contrib folder
during release (3.4)
URL: https://github.com/apache/zookeeper/pull/836
This is an automated message from the Apache Git Service.
To respond to the
anmolnar commented on issue #836: Fix for license files and contrib folder
during release (3.4)
URL: https://github.com/apache/zookeeper/pull/836#issuecomment-467908721
Committed. Thanks @phunt !
This is an automated message
asfgit closed pull request #837: Fix typo in error log message, added missing
space
URL: https://github.com/apache/zookeeper/pull/837
This is an automated message from the Apache Git Service.
To respond to the message,
nicolasguyomar opened a new pull request #837: Fix typo in error log message,
added missing space
URL: https://github.com/apache/zookeeper/pull/837
Fix typo in error log message, added missing space
This is an automated
David created ZOOKEEPER-3292:
Summary: ZooKeeper C Client for Windows: should include winports.h
Key: ZOOKEEPER-3292
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3292
Project: ZooKeeper
phunt commented on issue #837: Fix typo in error log message, added missing
space
URL: https://github.com/apache/zookeeper/pull/837#issuecomment-467931129
+1 thanks @nicolasguyomar !
This is an automated message from the
anmolnar commented on a change in pull request #796: ZOOKEEPER-3267: Add
watcher metrics
URL: https://github.com/apache/zookeeper/pull/796#discussion_r260708549
##
File path:
zookeeper-server/src/test/java/org/apache/zookeeper/server/watch/WatcherCleanerTest.java
##
@@
anmolnar commented on issue #639: ZOOKEEPER-2122: add openssl to zookeeper c
client to support ssl
URL: https://github.com/apache/zookeeper/pull/639#issuecomment-467829319
@roodkcab There's still no test failure in your builds. As I mentioned, you
need to add your test files to release
anmolnar edited a comment on issue #639: ZOOKEEPER-2122: add openssl to
zookeeper c client to support ssl
URL: https://github.com/apache/zookeeper/pull/639#issuecomment-467829319
@roodkcab There's still no test failure in your builds. As I mentioned, you
need to add your test resource
roodkcab commented on issue #639: ZOOKEEPER-2122: add openssl to zookeeper c
client to support ssl
URL: https://github.com/apache/zookeeper/pull/639#issuecomment-467818704
@anmolnar I don't know why unittest run
roodkcab edited a comment on issue #639: ZOOKEEPER-2122: add openssl to
zookeeper c client to support ssl
URL: https://github.com/apache/zookeeper/pull/639#issuecomment-467818704
@anmolnar I don't know why unittest run testSSL, I wrapped
CPPUNIT_TEST(testSSL) with HAVE_OPENSSL_H macro, it
asfgit closed pull request #835: Fix for lincense files and contrib folder
during release
URL: https://github.com/apache/zookeeper/pull/835
This is an automated message from the Apache Git Service.
To respond to the
anmolnar commented on issue #835: Fix for lincense files and contrib folder
during release
URL: https://github.com/apache/zookeeper/pull/835#issuecomment-467827784
Committed to 3.5 and master branches. Thanks everybody for the help!
roodkcab edited a comment on issue #639: ZOOKEEPER-2122: add openssl to
zookeeper c client to support ssl
URL: https://github.com/apache/zookeeper/pull/639#issuecomment-467818704
@anmolnar I don't know why unittest run testSSL, I wrapped
CPPUNIT_TEST(testSSL) with HAVE_OPENSSL_H macro, it
roodkcab edited a comment on issue #639: ZOOKEEPER-2122: add openssl to
zookeeper c client to support ssl
URL: https://github.com/apache/zookeeper/pull/639#issuecomment-467818704
@anmolnar I don't know why unittest run testSSL, I wrapped
CPPUNIT_TEST(testSSL) with HAVE_OPENSSL_H macro, it
I will take a look
Enrico
Il mer 27 feb 2019, 13:12 Apache Jenkins Server
ha scritto:
> See <
> https://builds.apache.org/job/zookeeper-master-maven/97/display/redirect>
>
> --
> Started by an SCM change
> [EnvInject] - Loading node environment
anmolnar commented on issue #836: Fix for license files and contrib folder
during release (3.4)
URL: https://github.com/apache/zookeeper/pull/836#issuecomment-467845182
retest maven build
This is an automated message from
roodkcab commented on issue #639: ZOOKEEPER-2122: add openssl to zookeeper c
client to support ssl
URL: https://github.com/apache/zookeeper/pull/639#issuecomment-467802625
@anmolnar seems some problem with unittest, I test connection establish but
not close. I'll make some test on that
Note: we discuss this on our wiki too:
https://cwiki.apache.org/confluence/display/CURATOR/Submitting+Pull+Requests
> On Feb 27, 2019, at 11:37 AM, Patrick Hunt wrote:
>
> Historically we've only committed changes that have an associated JIRA. Now
> with the move to gitbox we are seeing
athanatos commented on issue #787: ZOOKEEPER-3253: client should not send
requests with cxid=-4, -2, or -1
URL: https://github.com/apache/zookeeper/pull/787#issuecomment-467962868
@phunt I was unable to find anything server side that actually compares
cxids other than to check equality.
I think we should have a jira for all significant changes, and I would let
the committer decide about what is significant or not.
Basically anything worth to mention in the release notes should get a jira,
but for typo fixes or other similar things we could spare it.
Just my thoughts.
Regards,
There were a few typo/language/cosmetic related patches which were so small
that we've decided it's probably not worth the effort to create a Jira for
every one of them.
Similarly, I haven't created Jiras for issues that were found in release
candidates.
Other than this we generally still don't
Yea, the commit I just did was a single missing space so no big deal.
Jordan's link is to curator current policy which seems very similar to ours.
I know what current state is. My question though is what do people think?
Stay with the current mechanism or move to something else? Staying put is
Is it because of simplicity (no need to decide whether a jira is necessary) or
there’s a huge downside of committing patches without Jiras?
Andor
> On 2019. Feb 27., at 17:41, Jordan Zimmerman
> wrote:
>
> For Curator we require a Jira. If we get a PR without a Jira we always ask
> them
athanatos commented on issue #787: ZOOKEEPER-3253: client should not send
requests with cxid=-4, -2, or -1
URL: https://github.com/apache/zookeeper/pull/787#issuecomment-467963738
Pushed to fix the commit message -- forgot to update it before.
athanatos edited a comment on issue #787: ZOOKEEPER-3253: client should not
send requests with cxid=-4, -2, or -1
URL: https://github.com/apache/zookeeper/pull/787#issuecomment-467962868
@phunt I was unable to find anything server side that actually compares
cxids other than to check
This is a bugfix release candidate for 3.4.14. It fixes 8 issues, mostly build
/ unit tests issues,
dependency updates flagged by OWASP, NPE and a name resolution problem. Among
these it also supports
experimental Maven build and Markdown based documentation generation.
The full release notes
phunt commented on issue #787: ZOOKEEPER-3253: client should not send requests
with cxid=-4, -2, or -1
URL: https://github.com/apache/zookeeper/pull/787#issuecomment-467940965
So here's my current concern, which I have not had time yet to look at and I
think should be addressed before
Hi Pat,
I’ve just created a new release candidate with the issues resolved that you
mentioned here.
Regarding number of files: releases prior to 3.4.14 has included the contrib
folder twice: one at top level (src+bin), another one in the ’src’ folder (src
only).
From 3.4.14 we only include
phunt edited a comment on issue #787: ZOOKEEPER-3253: client should not send
requests with cxid=-4, -2, or -1
URL: https://github.com/apache/zookeeper/pull/787#issuecomment-467940965
So here's my current concern, which I have not had time yet to look at and I
think should be addressed
I tend to agree with Tamaas. A few lines of typo fix and similar patches
should be OK.
Anything bigger, it should have a jira. Basically how it was done recently.
Regards,
Norbert
On Wed, Feb 27, 2019 at 6:51 PM Tamas Penzes
wrote:
> I think we should have a jira for all significant changes,
Historically we've only committed changes that have an associated JIRA. Now
with the move to gitbox we are seeing increased submissions (PRs) that
don't include a JIRA - I just committed one and then realized that it
didn't include a JIRA (sorry about that!). Given github and the recent move
to
For Curator we require a Jira. If we get a PR without a Jira we always ask them
to create one.
-JZ
> On Feb 27, 2019, at 11:37 AM, Patrick Hunt wrote:
>
> Historically we've only committed changes that have an associated JIRA. Now
> with the move to gitbox we are seeing increased submissions
See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/3221/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 11.52 KB...]
[move] Moving 1 file to
I think that having a JIRA makes it simpler to create release notes and
track bugfixes/new features.
Trivial changes, like typos are not worth a JIRA.
My 2 cents
Enrico
Il mer 27 feb 2019, 17:57 Patrick Hunt ha scritto:
> Yea, the commit I just did was a single missing space so no big deal.
>
48 matches
Mail list logo
